)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"407cdb5cd20ee2f17571d338dd437a418b4ee0f5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"couple of clean steps in vendor drivers that can be performed"},{"line_number":11,"context_line":"out-of-band. There is no mechanism available to disable in-band"},{"line_number":12,"context_line":"cleaning in Ironic if one wishes to execute only out-of-band"},{"line_number":13,"context_line":"clean steps."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This commit adds new boolean parameter \u0027oob_cleaning\u0027 that can"},{"line_number":16,"context_line":"be set in the Ironic config file to restrict cleaning operation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a74a57a_312789b7","line":13,"updated":"2016-11-25 11:54:13.000000000","message":"I think the right approach is to check if all requested steps are out-of-band, and then do not boot the ramdisk, etc.","commit_id":"f240adecb376be441b5b7f46795dc11ef900658a"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b54986e6d569287d8514c2368f27a4fe38beb354","unresolved":false,"context_lines":[{"line_number":10,"context_line":"couple of clean steps in vendor drivers that can be performed"},{"line_number":11,"context_line":"out-of-band. There is no mechanism available to disable in-band"},{"line_number":12,"context_line":"cleaning in Ironic if one wishes to execute only out-of-band"},{"line_number":13,"context_line":"clean steps."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This commit adds new boolean parameter \u0027oob_cleaning\u0027 that can"},{"line_number":16,"context_line":"be set in the Ironic config file to restrict cleaning operation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a74a57a_3647684c","line":13,"in_reply_to":"5a74a57a_312789b7","updated":"2016-11-25 19:35:37.000000000","message":"++","commit_id":"f240adecb376be441b5b7f46795dc11ef900658a"}],"ironic/conf/deploy.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"b54986e6d569287d8514c2368f27a4fe38beb354","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    cfg.BoolOpt(\u0027oob_cleaning\u0027,"},{"line_number":79,"context_line":"                default\u003dFalse,"},{"line_number":80,"context_line":"                help\u003d_(\u0027Set this to True to execute only out-of-band \u0027"},{"line_number":81,"context_line":"                       \u0027clean steps.\u0027)),"},{"line_number":82,"context_line":"]"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_b6a8d8dc","line":81,"updated":"2016-11-25 19:35:37.000000000","message":"I am -2 to a global default of this nature.  Something in driver_info would make more sense to me.","commit_id":"f240adecb376be441b5b7f46795dc11ef900658a"}],"ironic/drivers/modules/ilo/common.py":[{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"70975e5e0555372f5142696d89bb2e3e0c9bd283","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    \u0027client_port\u0027: _(\"port to be used for iLO operations. Optional.\"),"},{"line_number":58,"context_line":"    \u0027client_timeout\u0027: _(\"timeout (in seconds) for iLO operations. Optional.\"),"},{"line_number":59,"context_line":"    \u0027ca_file\u0027: _(\"CA certificate file to validate iLO. Optional\"),"},{"line_number":60,"context_line":"    \u0027oob_cleaning\u0027: _(\"Whether Ironic should perform only perform only \""},{"line_number":61,"context_line":"                      \"out-of-band cleaning; default value is False. \""},{"line_number":62,"context_line":"                      \"Optional\"),"},{"line_number":63,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_26253f08","line":60,"range":{"start_line":60,"start_character":23,"end_line":60,"end_character":70},"updated":"2016-11-03 06:12:08.000000000","message":"\u0027perform only\u0027 is repeated.","commit_id":"800e68c9c2b98eb494ce8bc1f83250c01e4bee98"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8291e6f732b75a63fbdeb67f81b9ae93cbcb57d8","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    \u0027client_port\u0027: _(\"port to be used for iLO operations. Optional.\"),"},{"line_number":58,"context_line":"    \u0027client_timeout\u0027: _(\"timeout (in seconds) for iLO operations. Optional.\"),"},{"line_number":59,"context_line":"    \u0027ca_file\u0027: _(\"CA certificate file to validate iLO. Optional\"),"},{"line_number":60,"context_line":"    \u0027oob_cleaning\u0027: _(\"Whether Ironic should perform only perform only \""},{"line_number":61,"context_line":"                      \"out-of-band cleaning; default value is False. \""},{"line_number":62,"context_line":"                      \"Optional\"),"},{"line_number":63,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_8228b434","line":60,"range":{"start_line":60,"start_character":23,"end_line":60,"end_character":70},"in_reply_to":"ba5da102_26253f08","updated":"2016-11-03 06:17:06.000000000","message":"Will fix in next patch.","commit_id":"800e68c9c2b98eb494ce8bc1f83250c01e4bee98"}],"ironic/drivers/modules/ilo/deploy.py":[{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"70975e5e0555372f5142696d89bb2e3e0c9bd283","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        # If node is in system POST, setting boot device fails."},{"line_number":224,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        driver_info \u003d ilo_common.parse_driver_info(task.node)"},{"line_number":227,"context_line":"        if driver_info[\u0027oob_cleaning\u0027]:"},{"line_number":228,"context_line":"            return states.CLEANING"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        return super(IloVirtualMediaIscsiDeploy, self).prepare_cleaning(task)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_c211cc53","line":227,"range":{"start_line":226,"start_character":8,"end_line":227,"end_character":38},"updated":"2016-11-03 06:12:08.000000000","message":"Can this be replaces by _is_oob_cleaning(task) as it is used by more than one method?","commit_id":"800e68c9c2b98eb494ce8bc1f83250c01e4bee98"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8291e6f732b75a63fbdeb67f81b9ae93cbcb57d8","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        # If node is in system POST, setting boot device fails."},{"line_number":224,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        driver_info \u003d ilo_common.parse_driver_info(task.node)"},{"line_number":227,"context_line":"        if driver_info[\u0027oob_cleaning\u0027]:"},{"line_number":228,"context_line":"            return states.CLEANING"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        return super(IloVirtualMediaIscsiDeploy, self).prepare_cleaning(task)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5da102_c270ec74","line":227,"range":{"start_line":226,"start_character":8,"end_line":227,"end_character":38},"in_reply_to":"ba5da102_c211cc53","updated":"2016-11-03 06:17:06.000000000","message":"You mean a method? I think method would be a overkill for checking a element in dictionary.","commit_id":"800e68c9c2b98eb494ce8bc1f83250c01e4bee98"}]}