)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"d9a0fb811829f1ee2b7502617b5343e9376ed136","unresolved":false,"context_lines":[{"line_number":12,"context_line":"To connect again, user should re-activate console."},{"line_number":13,"context_line":"This already covered in nova virt driver."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Also added timeout check for 300 sec for users connection."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: If92b3a9cff2d0fc1280f8e9dfc4bc8fa100c91ec"},{"line_number":18,"context_line":"Closes-bug: #1611279"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da4df55a_9ffa0cbc","line":15,"range":{"start_line":15,"start_character":29,"end_line":15,"end_character":32},"updated":"2016-12-26 04:51:30.000000000","message":"Please change to 600 as you changed in the code.","commit_id":"dfd0f26714b25538aae2c7930a51ac4037919dfd"},{"author":{"_account_id":8259,"name":"Andrey Shestakov","email":"ashestakov@mirantis.com","username":"ashestakov"},"change_message_id":"46b6752f0dca27d8456258c54bcd23d754c6fc5b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"To connect again, user should re-activate console."},{"line_number":13,"context_line":"This already covered in nova virt driver."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Also added timeout check for 300 sec for users connection."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: If92b3a9cff2d0fc1280f8e9dfc4bc8fa100c91ec"},{"line_number":18,"context_line":"Closes-bug: #1611279"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da4df55a_a1224fff","line":15,"range":{"start_line":15,"start_character":29,"end_line":15,"end_character":32},"in_reply_to":"da4df55a_9ffa0cbc","updated":"2016-12-26 09:34:36.000000000","message":"Done","commit_id":"dfd0f26714b25538aae2c7930a51ac4037919dfd"},{"author":{"_account_id":10453,"name":"octopuszhang","email":"zhangyf@rc.inesa.com","username":"1"},"change_message_id":"cccf6c26c85f3554da45c6b543eaf72d81984a48","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove \u0027fork\u0027 option from socat command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"socat should not forks for each new connection."},{"line_number":10,"context_line":"After this change socat console will be available only for single user connection"},{"line_number":11,"context_line":"and will be closed after user connection close."},{"line_number":12,"context_line":"To connect again, user should re-activate console."},{"line_number":13,"context_line":"This already covered in nova virt driver."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da4df55a_8101ca6c","line":10,"range":{"start_line":10,"start_character":71,"end_line":10,"end_character":81},"updated":"2016-12-26 10:08:39.000000000","message":"too long","commit_id":"f80a3f89384274635d20221b3059c85d649b45f0"},{"author":{"_account_id":8259,"name":"Andrey Shestakov","email":"ashestakov@mirantis.com","username":"ashestakov"},"change_message_id":"de8444e50761cbb521bfe9b23af9d97be75b53b2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove \u0027fork\u0027 option from socat command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"socat should not forks for each new connection."},{"line_number":10,"context_line":"After this change socat console will be available only for single user connection"},{"line_number":11,"context_line":"and will be closed after user connection close."},{"line_number":12,"context_line":"To connect again, user should re-activate console."},{"line_number":13,"context_line":"This already covered in nova virt driver."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da4df55a_64079418","line":10,"range":{"start_line":10,"start_character":71,"end_line":10,"end_character":81},"in_reply_to":"da4df55a_8101ca6c","updated":"2016-12-26 10:10:08.000000000","message":"Done","commit_id":"f80a3f89384274635d20221b3059c85d649b45f0"},{"author":{"_account_id":10453,"name":"octopuszhang","email":"zhangyf@rc.inesa.com","username":"1"},"change_message_id":"cccf6c26c85f3554da45c6b543eaf72d81984a48","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"socat should not forks for each new connection."},{"line_number":10,"context_line":"After this change socat console will be available only for single user connection"},{"line_number":11,"context_line":"and will be closed after user connection close."},{"line_number":12,"context_line":"To connect again, user should re-activate console."},{"line_number":13,"context_line":"This already covered in nova virt driver."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da4df55a_211ade7d","line":11,"range":{"start_line":11,"start_character":25,"end_line":11,"end_character":29},"updated":"2016-12-26 10:08:39.000000000","message":"user\u0027s","commit_id":"f80a3f89384274635d20221b3059c85d649b45f0"},{"author":{"_account_id":8259,"name":"Andrey Shestakov","email":"ashestakov@mirantis.com","username":"ashestakov"},"change_message_id":"de8444e50761cbb521bfe9b23af9d97be75b53b2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"socat should not forks for each new connection."},{"line_number":10,"context_line":"After this change socat console will be available only for single user connection"},{"line_number":11,"context_line":"and will be closed after user connection close."},{"line_number":12,"context_line":"To connect again, user should re-activate console."},{"line_number":13,"context_line":"This already covered in nova virt driver."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da4df55a_4406101e","line":11,"range":{"start_line":11,"start_character":25,"end_line":11,"end_character":29},"in_reply_to":"da4df55a_211ade7d","updated":"2016-12-26 10:10:08.000000000","message":"Done","commit_id":"f80a3f89384274635d20221b3059c85d649b45f0"}],"ironic/drivers/modules/console_utils.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"da9b5c5d787b1cdc766c7d8609c19399f912baff","unresolved":false,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    # put together the command and arguments for invoking the console"},{"line_number":284,"context_line":"    args \u003d [\u0027socat\u0027]"},{"line_number":285,"context_line":"    args.append(\u0027-T300\u0027)"},{"line_number":286,"context_line":"    args.append(\u0027-L%s\u0027 % pid_file)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    console_host \u003d CONF.my_ip"}],"source_content_type":"text/x-python","patch_set":2,"id":"da4df55a_637333e8","line":285,"updated":"2016-12-23 14:34:03.000000000","message":"I think a reason why or human logic behind a 5 minute timeout would be good to detail in-line.  There may be other reasons why that a reviewer is unaware of, and at the same time an operator might greatly disagree with a five minute timeout if they are waiting for a long running process to complete that does not emit anything to the console.","commit_id":"38953beeda0b0e058e828b388d7424e326456be6"},{"author":{"_account_id":8259,"name":"Andrey Shestakov","email":"ashestakov@mirantis.com","username":"ashestakov"},"change_message_id":"eb9798ebeea60f54917e8adbce1e68c1fdd9c23d","unresolved":false,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    # put together the command and arguments for invoking the console"},{"line_number":284,"context_line":"    args \u003d [\u0027socat\u0027]"},{"line_number":285,"context_line":"    args.append(\u0027-T300\u0027)"},{"line_number":286,"context_line":"    args.append(\u0027-L%s\u0027 % pid_file)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    console_host \u003d CONF.my_ip"}],"source_content_type":"text/x-python","patch_set":2,"id":"da4df55a_efa54204","line":285,"in_reply_to":"da4df55a_39cb1c55","updated":"2016-12-23 16:13:02.000000000","message":"Done","commit_id":"38953beeda0b0e058e828b388d7424e326456be6"},{"author":{"_account_id":8259,"name":"Andrey Shestakov","email":"ashestakov@mirantis.com","username":"ashestakov"},"change_message_id":"40cbbc9801479bb146f02f5bc7ef67bf6bc07b87","unresolved":false,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    # put together the command and arguments for invoking the console"},{"line_number":284,"context_line":"    args \u003d [\u0027socat\u0027]"},{"line_number":285,"context_line":"    args.append(\u0027-T300\u0027)"},{"line_number":286,"context_line":"    args.append(\u0027-L%s\u0027 % pid_file)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    console_host \u003d CONF.my_ip"}],"source_content_type":"text/x-python","patch_set":2,"id":"da4df55a_d6d65f26","line":285,"in_reply_to":"da4df55a_637333e8","updated":"2016-12-23 14:47:15.000000000","message":"But, you can re-activate console after. Is 10 min enough? :) Make it configurable seems is hard.","commit_id":"38953beeda0b0e058e828b388d7424e326456be6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"47acbae3a18836458a7ab1a536ad845fd40a621c","unresolved":false,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    # put together the command and arguments for invoking the console"},{"line_number":284,"context_line":"    args \u003d [\u0027socat\u0027]"},{"line_number":285,"context_line":"    args.append(\u0027-T300\u0027)"},{"line_number":286,"context_line":"    args.append(\u0027-L%s\u0027 % pid_file)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    console_host \u003d CONF.my_ip"}],"source_content_type":"text/x-python","patch_set":2,"id":"da4df55a_39cb1c55","line":285,"in_reply_to":"da4df55a_d6d65f26","updated":"2016-12-23 15:27:40.000000000","message":"I think 10 minutes is slightly more reasonable.  Few things take \u003e10 minutes these days, even with spinning rust. :)","commit_id":"38953beeda0b0e058e828b388d7424e326456be6"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"d9a0fb811829f1ee2b7502617b5343e9376ed136","unresolved":false,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    # put together the command and arguments for invoking the console"},{"line_number":284,"context_line":"    args \u003d [\u0027socat\u0027]"},{"line_number":285,"context_line":"    args.append(\u0027-T600\u0027)"},{"line_number":286,"context_line":"    args.append(\u0027-L%s\u0027 % pid_file)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    console_host \u003d CONF.my_ip"}],"source_content_type":"text/x-python","patch_set":4,"id":"da4df55a_ff687889","line":285,"updated":"2016-12-26 04:51:30.000000000","message":"Can you add a comment to describe how this works?","commit_id":"dfd0f26714b25538aae2c7930a51ac4037919dfd"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"6d3bc17ab5e5939dd9fe552b02a1834d2aec79b4","unresolved":false,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    # put together the command and arguments for invoking the console"},{"line_number":284,"context_line":"    args \u003d [\u0027socat\u0027]"},{"line_number":285,"context_line":"    args.append(\u0027-T600\u0027)"},{"line_number":286,"context_line":"    args.append(\u0027-L%s\u0027 % pid_file)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    console_host \u003d CONF.my_ip"}],"source_content_type":"text/x-python","patch_set":4,"id":"da4df55a_269f55b5","line":285,"in_reply_to":"da4df55a_ff687889","updated":"2016-12-26 08:40:15.000000000","message":"+1 to add note here, wondered if we want to make it configurable.","commit_id":"dfd0f26714b25538aae2c7930a51ac4037919dfd"},{"author":{"_account_id":8259,"name":"Andrey Shestakov","email":"ashestakov@mirantis.com","username":"ashestakov"},"change_message_id":"46b6752f0dca27d8456258c54bcd23d754c6fc5b","unresolved":false,"context_lines":[{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    # put together the command and arguments for invoking the console"},{"line_number":284,"context_line":"    args \u003d [\u0027socat\u0027]"},{"line_number":285,"context_line":"    args.append(\u0027-T600\u0027)"},{"line_number":286,"context_line":"    args.append(\u0027-L%s\u0027 % pid_file)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    console_host \u003d CONF.my_ip"}],"source_content_type":"text/x-python","patch_set":4,"id":"da4df55a_611067a9","line":285,"in_reply_to":"da4df55a_ff687889","updated":"2016-12-26 09:34:36.000000000","message":"Done","commit_id":"dfd0f26714b25538aae2c7930a51ac4037919dfd"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"afa2746d6f8b2f77d21234afade4b3c94f4f90bc","unresolved":false,"context_lines":[{"line_number":283,"context_line":"    # put together the command and arguments for invoking the console"},{"line_number":284,"context_line":"    args \u003d [\u0027socat\u0027]"},{"line_number":285,"context_line":"    # set timeout check for user\u0027s connection. After 10min of inactivity"},{"line_number":286,"context_line":"    # on client side, connection will be closed."},{"line_number":287,"context_line":"    args.append(\u0027-T600\u0027)"},{"line_number":288,"context_line":"    args.append(\u0027-L%s\u0027 % pid_file)"},{"line_number":289,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da4df55a_dd50f734","line":286,"updated":"2016-12-27 15:26:25.000000000","message":"nit: Maybe we should have a configurable at some point, so perhaps a TODO for later?","commit_id":"bc8b0be232901d0a6533d4ac4cc11eb260bb55f9"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"af6d8d558b9c4dc514d86abd11810ba6e7d6f708","unresolved":false,"context_lines":[{"line_number":283,"context_line":"    # put together the command and arguments for invoking the console"},{"line_number":284,"context_line":"    args \u003d [\u0027socat\u0027]"},{"line_number":285,"context_line":"    # set timeout check for user\u0027s connection. After 10min of inactivity"},{"line_number":286,"context_line":"    # on client side, connection will be closed."},{"line_number":287,"context_line":"    args.append(\u0027-T600\u0027)"},{"line_number":288,"context_line":"    args.append(\u0027-L%s\u0027 % pid_file)"},{"line_number":289,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_105e8445","line":286,"in_reply_to":"da4df55a_dd50f734","updated":"2016-12-29 04:30:00.000000000","message":"++","commit_id":"bc8b0be232901d0a6533d4ac4cc11eb260bb55f9"},{"author":{"_account_id":8259,"name":"Andrey Shestakov","email":"ashestakov@mirantis.com","username":"ashestakov"},"change_message_id":"9ac2e17affa0153bb06db8e11ee241d4730a89f9","unresolved":false,"context_lines":[{"line_number":283,"context_line":"    # put together the command and arguments for invoking the console"},{"line_number":284,"context_line":"    args \u003d [\u0027socat\u0027]"},{"line_number":285,"context_line":"    # set timeout check for user\u0027s connection. After 10min of inactivity"},{"line_number":286,"context_line":"    # on client side, connection will be closed."},{"line_number":287,"context_line":"    args.append(\u0027-T600\u0027)"},{"line_number":288,"context_line":"    args.append(\u0027-L%s\u0027 % pid_file)"},{"line_number":289,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ba5201f7_9c8d227e","line":286,"in_reply_to":"da4df55a_dd50f734","updated":"2016-12-29 17:30:30.000000000","message":"Done","commit_id":"bc8b0be232901d0a6533d4ac4cc11eb260bb55f9"}],"ironic/releasenotes/notes/fix-socat-command-afc840284446870a.yaml":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"da9b5c5d787b1cdc766c7d8609c19399f912baff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixed forking issue with socat console."},{"line_number":4,"context_line":"    This bug allows to setup unlimit number of connections to socat,"},{"line_number":5,"context_line":"    and each next connection will destroy IPMI console in previous one."},{"line_number":6,"context_line":"    This fix limits councurrent number of connections to single server to 1."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"da4df55a_837817f4","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":43},"updated":"2016-12-23 14:34:03.000000000","message":"Ironic prefers release notes written in the active tense.","commit_id":"38953beeda0b0e058e828b388d7424e326456be6"},{"author":{"_account_id":8259,"name":"Andrey Shestakov","email":"ashestakov@mirantis.com","username":"ashestakov"},"change_message_id":"40cbbc9801479bb146f02f5bc7ef67bf6bc07b87","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixed forking issue with socat console."},{"line_number":4,"context_line":"    This bug allows to setup unlimit number of connections to socat,"},{"line_number":5,"context_line":"    and each next connection will destroy IPMI console in previous one."},{"line_number":6,"context_line":"    This fix limits councurrent number of connections to single server to 1."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"da4df55a_566eef96","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":43},"in_reply_to":"da4df55a_837817f4","updated":"2016-12-23 14:47:15.000000000","message":"Done","commit_id":"38953beeda0b0e058e828b388d7424e326456be6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"da9b5c5d787b1cdc766c7d8609c19399f912baff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixed forking issue with socat console."},{"line_number":4,"context_line":"    This bug allows to setup unlimit number of connections to socat,"},{"line_number":5,"context_line":"    and each next connection will destroy IPMI console in previous one."},{"line_number":6,"context_line":"    This fix limits councurrent number of connections to single server to 1."},{"line_number":7,"context_line":"    Socat console closes after connection ends. To connect again, user should"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"da4df55a_23a3eb50","line":4,"updated":"2016-12-23 14:34:03.000000000","message":"Perhaps: ?\n\n    - Fixes issue with socat console support where an unlimited\n      number of connections could be created, resulting in the prior\n      session being destroyed.  Connections are now limited\n      to a single connection per server.  Socat now closes the\n      console connection upon disconnect or timeout.  To reconnect,\n      users should re-activate the console.","commit_id":"38953beeda0b0e058e828b388d7424e326456be6"},{"author":{"_account_id":8259,"name":"Andrey Shestakov","email":"ashestakov@mirantis.com","username":"ashestakov"},"change_message_id":"40cbbc9801479bb146f02f5bc7ef67bf6bc07b87","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixed forking issue with socat console."},{"line_number":4,"context_line":"    This bug allows to setup unlimit number of connections to socat,"},{"line_number":5,"context_line":"    and each next connection will destroy IPMI console in previous one."},{"line_number":6,"context_line":"    This fix limits councurrent number of connections to single server to 1."},{"line_number":7,"context_line":"    Socat console closes after connection ends. To connect again, user should"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"da4df55a_766db397","line":4,"in_reply_to":"da4df55a_23a3eb50","updated":"2016-12-23 14:47:15.000000000","message":"Done","commit_id":"38953beeda0b0e058e828b388d7424e326456be6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"da9b5c5d787b1cdc766c7d8609c19399f912baff","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    This fix limits councurrent number of connections to single server to 1."},{"line_number":7,"context_line":"    Socat console closes after connection ends. To connect again, user should"},{"line_number":8,"context_line":"    re-activate console."},{"line_number":9,"context_line":"    Added timeout check for console connections."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"da4df55a_235e8b76","line":9,"range":{"start_line":9,"start_character":3,"end_line":9,"end_character":48},"updated":"2016-12-23 14:34:03.000000000","message":"Seems like a separate fix?","commit_id":"38953beeda0b0e058e828b388d7424e326456be6"},{"author":{"_account_id":8259,"name":"Andrey Shestakov","email":"ashestakov@mirantis.com","username":"ashestakov"},"change_message_id":"40cbbc9801479bb146f02f5bc7ef67bf6bc07b87","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    This fix limits councurrent number of connections to single server to 1."},{"line_number":7,"context_line":"    Socat console closes after connection ends. To connect again, user should"},{"line_number":8,"context_line":"    re-activate console."},{"line_number":9,"context_line":"    Added timeout check for console connections."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"da4df55a_36fa4bbe","line":9,"range":{"start_line":9,"start_character":3,"end_line":9,"end_character":48},"in_reply_to":"da4df55a_235e8b76","updated":"2016-12-23 14:47:15.000000000","message":"i described all small issues in single bug in LP. Should i split this this by two patches?","commit_id":"38953beeda0b0e058e828b388d7424e326456be6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"47acbae3a18836458a7ab1a536ad845fd40a621c","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    This fix limits councurrent number of connections to single server to 1."},{"line_number":7,"context_line":"    Socat console closes after connection ends. To connect again, user should"},{"line_number":8,"context_line":"    re-activate console."},{"line_number":9,"context_line":"    Added timeout check for console connections."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"da4df55a_59cd405c","line":9,"range":{"start_line":9,"start_character":3,"end_line":9,"end_character":48},"in_reply_to":"da4df55a_36fa4bbe","updated":"2016-12-23 15:27:40.000000000","message":"Given how minor it is, I think it is fine  It is actually logical to do, it should in this case, I just think it should just be presented as clearly as possible.","commit_id":"38953beeda0b0e058e828b388d7424e326456be6"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"af6d8d558b9c4dc514d86abd11810ba6e7d6f708","unresolved":false,"context_lines":[{"line_number":4,"context_line":"      number of connections could be created, resulting in the prior"},{"line_number":5,"context_line":"      session being destroyed.  Connections are now limited"},{"line_number":6,"context_line":"      to a single connection per server.  Socat now closes the"},{"line_number":7,"context_line":"      console connection upon disconnect or timeout.  To reconnect,"},{"line_number":8,"context_line":"      users should re-activate the console."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ba5201f7_702c30ac","line":7,"range":{"start_line":7,"start_character":44,"end_line":7,"end_character":51},"updated":"2016-12-29 04:30:00.000000000","message":"Please mention time out value.","commit_id":"bc8b0be232901d0a6533d4ac4cc11eb260bb55f9"},{"author":{"_account_id":8259,"name":"Andrey Shestakov","email":"ashestakov@mirantis.com","username":"ashestakov"},"change_message_id":"9ac2e17affa0153bb06db8e11ee241d4730a89f9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"      number of connections could be created, resulting in the prior"},{"line_number":5,"context_line":"      session being destroyed.  Connections are now limited"},{"line_number":6,"context_line":"      to a single connection per server.  Socat now closes the"},{"line_number":7,"context_line":"      console connection upon disconnect or timeout.  To reconnect,"},{"line_number":8,"context_line":"      users should re-activate the console."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ba5201f7_fc7b8e79","line":7,"range":{"start_line":7,"start_character":44,"end_line":7,"end_character":51},"in_reply_to":"ba5201f7_702c30ac","updated":"2016-12-29 17:30:30.000000000","message":"Done","commit_id":"bc8b0be232901d0a6533d4ac4cc11eb260bb55f9"}]}