)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"b0598221a5b2aae5d524578a3df577e03240dfa8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds snmp driver auto discovery for APC and baytech"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When instanciated, this new snmp driver chooses the appropriate"},{"line_number":10,"context_line":"snmp driver selected by asking the device system description."},{"line_number":11,"context_line":"Each snmp device indicates which model and manufacturer is by"},{"line_number":12,"context_line":"reponding to a standardized call."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f7c97a3_3a0e678c","line":9,"range":{"start_line":9,"start_character":5,"end_line":9,"end_character":17},"updated":"2018-06-19 11:04:41.000000000","message":"typo?","commit_id":"b5a8e98eeb9c491ecfdee9f8a2a8c9cb53c6035b"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"fe69bc55f4cc0506e973f59553e0f7d7f8979978","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds snmp driver auto discovery for APC and baytech"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When instanciated, this new snmp driver chooses the appropriate"},{"line_number":10,"context_line":"snmp driver selected by asking the device system description."},{"line_number":11,"context_line":"Each snmp device indicates which model and manufacturer is by"},{"line_number":12,"context_line":"reponding to a standardized call."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f7c97a3_207788d3","line":9,"range":{"start_line":9,"start_character":5,"end_line":9,"end_character":17},"in_reply_to":"5f7c97a3_3a0e678c","updated":"2018-06-26 15:20:57.000000000","message":"Done","commit_id":"b5a8e98eeb9c491ecfdee9f8a2a8c9cb53c6035b"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"b0598221a5b2aae5d524578a3df577e03240dfa8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When instanciated, this new snmp driver chooses the appropriate"},{"line_number":10,"context_line":"snmp driver selected by asking the device system description."},{"line_number":11,"context_line":"Each snmp device indicates which model and manufacturer is by"},{"line_number":12,"context_line":"reponding to a standardized call."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9bf01a0c567048d0169db281684d16a00e39f6b8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f7c97a3_7a793ff9","line":11,"range":{"start_line":11,"start_character":56,"end_line":11,"end_character":58},"updated":"2018-06-19 11:04:41.000000000","message":"*it* is","commit_id":"b5a8e98eeb9c491ecfdee9f8a2a8c9cb53c6035b"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"b0598221a5b2aae5d524578a3df577e03240dfa8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When instanciated, this new snmp driver chooses the appropriate"},{"line_number":10,"context_line":"snmp driver selected by asking the device system description."},{"line_number":11,"context_line":"Each snmp device indicates which model and manufacturer is by"},{"line_number":12,"context_line":"reponding to a standardized call."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9bf01a0c567048d0169db281684d16a00e39f6b8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f7c97a3_9a1e9bb9","line":11,"range":{"start_line":11,"start_character":5,"end_line":11,"end_character":9},"updated":"2018-06-19 11:04:41.000000000","message":"SNMP","commit_id":"b5a8e98eeb9c491ecfdee9f8a2a8c9cb53c6035b"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"fe69bc55f4cc0506e973f59553e0f7d7f8979978","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When instanciated, this new snmp driver chooses the appropriate"},{"line_number":10,"context_line":"snmp driver selected by asking the device system description."},{"line_number":11,"context_line":"Each snmp device indicates which model and manufacturer is by"},{"line_number":12,"context_line":"reponding to a standardized call."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9bf01a0c567048d0169db281684d16a00e39f6b8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f7c97a3_007cccb3","line":11,"range":{"start_line":11,"start_character":5,"end_line":11,"end_character":9},"in_reply_to":"5f7c97a3_9a1e9bb9","updated":"2018-06-26 15:20:57.000000000","message":"Done","commit_id":"b5a8e98eeb9c491ecfdee9f8a2a8c9cb53c6035b"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"b0598221a5b2aae5d524578a3df577e03240dfa8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When instanciated, this new snmp driver chooses the appropriate"},{"line_number":10,"context_line":"snmp driver selected by asking the device system description."},{"line_number":11,"context_line":"Each snmp device indicates which model and manufacturer is by"},{"line_number":12,"context_line":"reponding to a standardized call."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9bf01a0c567048d0169db281684d16a00e39f6b8"},{"line_number":15,"context_line":"Story: #1635644"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f7c97a3_5a5fa374","line":12,"range":{"start_line":12,"start_character":10,"end_line":12,"end_character":33},"updated":"2018-06-19 11:04:41.000000000","message":"Maybe: by conveying this information through the sysDescr SNMP object?","commit_id":"b5a8e98eeb9c491ecfdee9f8a2a8c9cb53c6035b"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"b0598221a5b2aae5d524578a3df577e03240dfa8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When instanciated, this new snmp driver chooses the appropriate"},{"line_number":10,"context_line":"snmp driver selected by asking the device system description."},{"line_number":11,"context_line":"Each snmp device indicates which model and manufacturer is by"},{"line_number":12,"context_line":"reponding to a standardized call."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9bf01a0c567048d0169db281684d16a00e39f6b8"},{"line_number":15,"context_line":"Story: #1635644"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f7c97a3_1a804bbf","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":9},"updated":"2018-06-19 11:04:41.000000000","message":"typo","commit_id":"b5a8e98eeb9c491ecfdee9f8a2a8c9cb53c6035b"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"fe69bc55f4cc0506e973f59553e0f7d7f8979978","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When instanciated, this new snmp driver chooses the appropriate"},{"line_number":10,"context_line":"snmp driver selected by asking the device system description."},{"line_number":11,"context_line":"Each snmp device indicates which model and manufacturer is by"},{"line_number":12,"context_line":"reponding to a standardized call."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I9bf01a0c567048d0169db281684d16a00e39f6b8"},{"line_number":15,"context_line":"Story: #1635644"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5f7c97a3_407644da","line":12,"range":{"start_line":12,"start_character":10,"end_line":12,"end_character":33},"in_reply_to":"5f7c97a3_5a5fa374","updated":"2018-06-26 15:20:57.000000000","message":"Done","commit_id":"b5a8e98eeb9c491ecfdee9f8a2a8c9cb53c6035b"}],"ironic/drivers/modules/snmp.py":[{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"b08cf0cfa7d6958153633931bb59e2e605a093a3","unresolved":false,"context_lines":[{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":492,"context_line":"        super(SNMPDriverAuto, self).__init__(*args, **kwargs)"},{"line_number":493,"context_line":"        sys_obj_oid \u003d self.client.get(self.SYS_OBJ_OID)"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        if \u0027iso.3.6.1.4.1.318.1.3.4.6\u0027 \u003d\u003d sys_obj_oid:"},{"line_number":496,"context_line":"            self.driver_name \u003d \u0027apc_rackpdu\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf3e73b7_6912065b","line":493,"range":{"start_line":493,"start_character":0,"end_line":493,"end_character":55},"updated":"2017-08-07 17:41:09.000000000","message":"The fundamentally different and theoretically more universal approach may be to inspect `SNMPv2-MIB::sysORTable` to see which MIBs this SNMP agent implements. The drivers may carry a property of the SNMP object (in form of a MIB name) they require to operate. \n\nOnce we figure which MIBs given agent implements, we may select a subset of drivers requiring that MIB and give them a try.\n\nIt looks like MIB-based would be a more precise approach in comparison with enterprise OID based.","commit_id":"fd89a36ef60f9e8b4e3051d8d41d1b543774590e"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"b08cf0cfa7d6958153633931bb59e2e605a093a3","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        super(SNMPDriverAuto, self).__init__(*args, **kwargs)"},{"line_number":493,"context_line":"        sys_obj_oid \u003d self.client.get(self.SYS_OBJ_OID)"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        if \u0027iso.3.6.1.4.1.318.1.3.4.6\u0027 \u003d\u003d sys_obj_oid:"},{"line_number":496,"context_line":"            self.driver_name \u003d \u0027apc_rackpdu\u0027"},{"line_number":497,"context_line":"        elif \u0027iso.3.6.1.4.1.4779\u0027 \u003d\u003d sys_obj_oid:"},{"line_number":498,"context_line":"            self.driver_name \u003d \u0027baytech_mrp27\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf3e73b7_b6b5e9f0","line":495,"range":{"start_line":495,"start_character":8,"end_line":495,"end_character":54},"updated":"2017-08-07 17:41:09.000000000","message":"May be worth noting in the code (?) that the order of sysObjectID comparison is important. The structure of the OID is that the prefix (1.3.6.1.4.1) is always the same, the next sub-OID is IANA enterprise number optionally followed by more sub-OIDs possibly referring to a product/family within that enterprise.\n\nTherefore it may make sense to try the longest OID first.","commit_id":"fd89a36ef60f9e8b4e3051d8d41d1b543774590e"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"b08cf0cfa7d6958153633931bb59e2e605a093a3","unresolved":false,"context_lines":[{"line_number":493,"context_line":"        sys_obj_oid \u003d self.client.get(self.SYS_OBJ_OID)"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        if \u0027iso.3.6.1.4.1.318.1.3.4.6\u0027 \u003d\u003d sys_obj_oid:"},{"line_number":496,"context_line":"            self.driver_name \u003d \u0027apc_rackpdu\u0027"},{"line_number":497,"context_line":"        elif \u0027iso.3.6.1.4.1.4779\u0027 \u003d\u003d sys_obj_oid:"},{"line_number":498,"context_line":"            self.driver_name \u003d \u0027baytech_mrp27\u0027"},{"line_number":499,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf3e73b7_493d02ba","line":496,"range":{"start_line":496,"start_character":0,"end_line":496,"end_character":44},"updated":"2017-08-07 17:41:09.000000000","message":"Would it make sense to let the drivers \"announce\" via a property which OID (or MIB object) they actually utilize and pick the drivers based on that? That would hopefully remove the","commit_id":"fd89a36ef60f9e8b4e3051d8d41d1b543774590e"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"b0598221a5b2aae5d524578a3df577e03240dfa8","unresolved":false,"context_lines":[{"line_number":617,"context_line":"        super(SNMPDriverAuto, self).__init__(*args, **kwargs)"},{"line_number":618,"context_line":"        sys_obj_oid \u003d self.client.get(self.SYS_OBJ_OID)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"        if \u0027iso.3.6.1.4.1.318.1.3.4.6\u0027 \u003d\u003d sys_obj_oid:"},{"line_number":621,"context_line":"            self.driver_name \u003d \u0027apc_rackpdu\u0027"},{"line_number":622,"context_line":"        elif \u0027iso.3.6.1.4.1.4779\u0027 \u003d\u003d sys_obj_oid:"},{"line_number":623,"context_line":"            self.driver_name \u003d \u0027baytech_mrp27\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_da85f3af","line":620,"range":{"start_line":620,"start_character":39,"end_line":620,"end_character":41},"updated":"2018-06-19 11:04:41.000000000","message":"May be we could build a map SYS_OBJ_OID_VALUE-\u003edriver_name automatically and use it for dict lookup instead of explicit if/then branching?","commit_id":"b5a8e98eeb9c491ecfdee9f8a2a8c9cb53c6035b"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"fe69bc55f4cc0506e973f59553e0f7d7f8979978","unresolved":false,"context_lines":[{"line_number":617,"context_line":"        super(SNMPDriverAuto, self).__init__(*args, **kwargs)"},{"line_number":618,"context_line":"        sys_obj_oid \u003d self.client.get(self.SYS_OBJ_OID)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"        if \u0027iso.3.6.1.4.1.318.1.3.4.6\u0027 \u003d\u003d sys_obj_oid:"},{"line_number":621,"context_line":"            self.driver_name \u003d \u0027apc_rackpdu\u0027"},{"line_number":622,"context_line":"        elif \u0027iso.3.6.1.4.1.4779\u0027 \u003d\u003d sys_obj_oid:"},{"line_number":623,"context_line":"            self.driver_name \u003d \u0027baytech_mrp27\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_c0625416","line":620,"range":{"start_line":620,"start_character":39,"end_line":620,"end_character":41},"in_reply_to":"5f7c97a3_da85f3af","updated":"2018-06-26 15:20:57.000000000","message":"Refactored","commit_id":"b5a8e98eeb9c491ecfdee9f8a2a8c9cb53c6035b"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"b0598221a5b2aae5d524578a3df577e03240dfa8","unresolved":false,"context_lines":[{"line_number":618,"context_line":"        sys_obj_oid \u003d self.client.get(self.SYS_OBJ_OID)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"        if \u0027iso.3.6.1.4.1.318.1.3.4.6\u0027 \u003d\u003d sys_obj_oid:"},{"line_number":621,"context_line":"            self.driver_name \u003d \u0027apc_rackpdu\u0027"},{"line_number":622,"context_line":"        elif \u0027iso.3.6.1.4.1.4779\u0027 \u003d\u003d sys_obj_oid:"},{"line_number":623,"context_line":"            self.driver_name \u003d \u0027baytech_mrp27\u0027"},{"line_number":624,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_7abe1f65","line":621,"range":{"start_line":621,"start_character":12,"end_line":621,"end_character":44},"updated":"2018-06-19 11:04:41.000000000","message":"May be it makes sense to log that we\u0027ve chosen this driver automatically based on the sysoid hint?","commit_id":"b5a8e98eeb9c491ecfdee9f8a2a8c9cb53c6035b"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"fe69bc55f4cc0506e973f59553e0f7d7f8979978","unresolved":false,"context_lines":[{"line_number":618,"context_line":"        sys_obj_oid \u003d self.client.get(self.SYS_OBJ_OID)"},{"line_number":619,"context_line":""},{"line_number":620,"context_line":"        if \u0027iso.3.6.1.4.1.318.1.3.4.6\u0027 \u003d\u003d sys_obj_oid:"},{"line_number":621,"context_line":"            self.driver_name \u003d \u0027apc_rackpdu\u0027"},{"line_number":622,"context_line":"        elif \u0027iso.3.6.1.4.1.4779\u0027 \u003d\u003d sys_obj_oid:"},{"line_number":623,"context_line":"            self.driver_name \u003d \u0027baytech_mrp27\u0027"},{"line_number":624,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_8068dcf3","line":621,"range":{"start_line":621,"start_character":12,"end_line":621,"end_character":44},"in_reply_to":"5f7c97a3_7abe1f65","updated":"2018-06-26 15:20:57.000000000","message":"Done","commit_id":"b5a8e98eeb9c491ecfdee9f8a2a8c9cb53c6035b"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"b0598221a5b2aae5d524578a3df577e03240dfa8","unresolved":false,"context_lines":[{"line_number":622,"context_line":"        elif \u0027iso.3.6.1.4.1.4779\u0027 \u003d\u003d sys_obj_oid:"},{"line_number":623,"context_line":"            self.driver_name \u003d \u0027baytech_mrp27\u0027"},{"line_number":624,"context_line":"        else:"},{"line_number":625,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":626,"context_line":"                \"SNMPPowerDriver: unknown driver %s \") % sys_obj_oid)"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"        self.driver \u003d DRIVER_CLASSES[self.driver_name](*args, **kwargs)"},{"line_number":629,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_1ae7ebae","line":626,"range":{"start_line":625,"start_character":12,"end_line":626,"end_character":69},"updated":"2018-06-19 11:04:41.000000000","message":"Is it just two drivers being considered? Why no all of them?","commit_id":"b5a8e98eeb9c491ecfdee9f8a2a8c9cb53c6035b"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"fe69bc55f4cc0506e973f59553e0f7d7f8979978","unresolved":false,"context_lines":[{"line_number":622,"context_line":"        elif \u0027iso.3.6.1.4.1.4779\u0027 \u003d\u003d sys_obj_oid:"},{"line_number":623,"context_line":"            self.driver_name \u003d \u0027baytech_mrp27\u0027"},{"line_number":624,"context_line":"        else:"},{"line_number":625,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":626,"context_line":"                \"SNMPPowerDriver: unknown driver %s \") % sys_obj_oid)"},{"line_number":627,"context_line":""},{"line_number":628,"context_line":"        self.driver \u003d DRIVER_CLASSES[self.driver_name](*args, **kwargs)"},{"line_number":629,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_a06b98ed","line":626,"range":{"start_line":625,"start_character":12,"end_line":626,"end_character":69},"in_reply_to":"5f7c97a3_1ae7ebae","updated":"2018-06-26 15:20:57.000000000","message":"Done","commit_id":"b5a8e98eeb9c491ecfdee9f8a2a8c9cb53c6035b"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"b0598221a5b2aae5d524578a3df577e03240dfa8","unresolved":false,"context_lines":[{"line_number":727,"context_line":"    \u0027cyberpower\u0027: SNMPDriverCyberPower,"},{"line_number":728,"context_line":"    \u0027eatonpower\u0027: SNMPDriverEatonPower,"},{"line_number":729,"context_line":"    \u0027teltronix\u0027: SNMPDriverTeltronix,"},{"line_number":730,"context_line":"    \u0027baytech_mrp27\u0027: SNMPDriverBaytechMRP27,"},{"line_number":731,"context_line":"    \u0027auto\u0027: SNMPDriverAuto"},{"line_number":732,"context_line":"}"},{"line_number":733,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_3ab8a773","line":730,"range":{"start_line":730,"start_character":5,"end_line":730,"end_character":18},"updated":"2018-06-19 11:04:41.000000000","message":"nit: is this an unrelated change?","commit_id":"b5a8e98eeb9c491ecfdee9f8a2a8c9cb53c6035b"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"8eaad024bba937bebb0ee1301d4a7172bac0208d","unresolved":false,"context_lines":[{"line_number":727,"context_line":"    \u0027cyberpower\u0027: SNMPDriverCyberPower,"},{"line_number":728,"context_line":"    \u0027eatonpower\u0027: SNMPDriverEatonPower,"},{"line_number":729,"context_line":"    \u0027teltronix\u0027: SNMPDriverTeltronix,"},{"line_number":730,"context_line":"    \u0027baytech_mrp27\u0027: SNMPDriverBaytechMRP27,"},{"line_number":731,"context_line":"    \u0027auto\u0027: SNMPDriverAuto"},{"line_number":732,"context_line":"}"},{"line_number":733,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_49bc36b4","line":730,"range":{"start_line":730,"start_character":5,"end_line":730,"end_character":18},"in_reply_to":"5f7c97a3_3ab8a773","updated":"2018-06-26 11:32:31.000000000","message":"Indeed, moved into [1].\n\n1. https://review.openstack.org/#/c/578068/1","commit_id":"b5a8e98eeb9c491ecfdee9f8a2a8c9cb53c6035b"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8f623fc76464f5874a0ab7436d515e40bd677e78","unresolved":false,"context_lines":[{"line_number":706,"context_line":""},{"line_number":707,"context_line":"        drivers_map \u003d {}"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"        for name, obj in inspect.getmembers(sys.modules[__name__]):"},{"line_number":710,"context_line":"            if (inspect.isclass(obj) and"},{"line_number":711,"context_line":"                    issubclass(obj, SNMPDriverBase) and"},{"line_number":712,"context_line":"                    getattr(obj, \u0027system_id\u0027, ())):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_9a836856","line":709,"updated":"2018-06-26 16:52:34.000000000","message":"Why not use DRIVER_CLASSES?","commit_id":"07bc2c0d8448ce327fa2f8e7e9c6166519397c67"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"29792a125118f2ac3449acd7a931ec9915de9962","unresolved":false,"context_lines":[{"line_number":706,"context_line":""},{"line_number":707,"context_line":"        drivers_map \u003d {}"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"        for name, obj in inspect.getmembers(sys.modules[__name__]):"},{"line_number":710,"context_line":"            if (inspect.isclass(obj) and"},{"line_number":711,"context_line":"                    issubclass(obj, SNMPDriverBase) and"},{"line_number":712,"context_line":"                    getattr(obj, \u0027system_id\u0027, ())):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_48073818","line":709,"in_reply_to":"5f7c97a3_9a836856","updated":"2018-06-27 08:57:09.000000000","message":"Done","commit_id":"07bc2c0d8448ce327fa2f8e7e9c6166519397c67"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8f623fc76464f5874a0ab7436d515e40bd677e78","unresolved":false,"context_lines":[{"line_number":744,"context_line":""},{"line_number":745,"context_line":"        raise exception.InvalidParameterValue(_("},{"line_number":746,"context_line":"            \"SNMPDriverAuto: no driver matching %(system_id)s\") %"},{"line_number":747,"context_line":"            {\u0027system_id\u0027: system_id})"},{"line_number":748,"context_line":""},{"line_number":749,"context_line":"    def _snmp_power_state(self):"},{"line_number":750,"context_line":"        current_power_state \u003d self.driver._snmp_power_state()"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_faae1ce2","line":747,"updated":"2018-06-26 16:52:34.000000000","message":"Just a suggestion - you could put the content of this __init__ function in a function, and specify that function as the driver class for auto. Then have the function return the created driver object. This means the driver only needs to implement the power interface API.","commit_id":"07bc2c0d8448ce327fa2f8e7e9c6166519397c67"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"29792a125118f2ac3449acd7a931ec9915de9962","unresolved":false,"context_lines":[{"line_number":744,"context_line":""},{"line_number":745,"context_line":"        raise exception.InvalidParameterValue(_("},{"line_number":746,"context_line":"            \"SNMPDriverAuto: no driver matching %(system_id)s\") %"},{"line_number":747,"context_line":"            {\u0027system_id\u0027: system_id})"},{"line_number":748,"context_line":""},{"line_number":749,"context_line":"    def _snmp_power_state(self):"},{"line_number":750,"context_line":"        current_power_state \u003d self.driver._snmp_power_state()"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_083620e8","line":747,"in_reply_to":"5f7c97a3_faae1ce2","updated":"2018-06-27 08:57:09.000000000","message":"Right, we can do that.... But I feel like it\u0027s a bit more complicated to read because it makes up for a new use-case e.g. function vs class...","commit_id":"07bc2c0d8448ce327fa2f8e7e9c6166519397c67"}],"releasenotes/notes/add-snmp-pdu-driver-type-discovery-1f280b7f06fd1ca5.yaml":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"8f623fc76464f5874a0ab7436d515e40bd677e78","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds new ``auto`` type of the ``driver_info/snmp_driver`` setting which"},{"line_number":5,"context_line":"    makes ironic automatically picking suitable SNMP driver type based on"},{"line_number":6,"context_line":"    the ``SNMPv2-MIB::sysObjectID`` value as reported by the PDU being"},{"line_number":7,"context_line":"    managed."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5f7c97a3_3ac0147c","line":5,"updated":"2018-06-26 16:52:34.000000000","message":"s/picking/select a/","commit_id":"07bc2c0d8448ce327fa2f8e7e9c6166519397c67"},{"author":{"_account_id":26340,"name":"Ilya Etingof","email":"etingof@gmail.com","username":"etingof"},"change_message_id":"29792a125118f2ac3449acd7a931ec9915de9962","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds new ``auto`` type of the ``driver_info/snmp_driver`` setting which"},{"line_number":5,"context_line":"    makes ironic automatically picking suitable SNMP driver type based on"},{"line_number":6,"context_line":"    the ``SNMPv2-MIB::sysObjectID`` value as reported by the PDU being"},{"line_number":7,"context_line":"    managed."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5f7c97a3_54fef869","line":5,"in_reply_to":"5f7c97a3_3ac0147c","updated":"2018-06-27 08:57:09.000000000","message":"Done","commit_id":"07bc2c0d8448ce327fa2f8e7e9c6166519397c67"}]}
