)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"9bafc182726ab443e7dc7b603fa6799f73ed2703","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Convert iPXE boot config to proper Jinja template"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently we do a mix of Jinja template rendering (on deploy image boot)"},{"line_number":10,"context_line":"and modifyinig the boot config inplace on disk with regexps (on"},{"line_number":11,"context_line":"switching to service mode for netboot-ed nodes)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"For Dynamic iPXE configuration we need to properly render configs from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a629dbe_86b5a232","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":14},"updated":"2016-11-08 19:53:46.000000000","message":"nit: s/modifyinig/modifying","commit_id":"99fff6a5056673029f425bb1517f8708fe250ef0"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"cc8c9db25e3d171144848df48c161bb1b4e1ad1f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Convert iPXE boot config to proper Jinja template"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently we do a mix of Jinja template rendering (on deploy image boot)"},{"line_number":10,"context_line":"and modifyinig the boot config inplace on disk with regexps (on"},{"line_number":11,"context_line":"switching to service mode for netboot-ed nodes)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"For Dynamic iPXE configuration we need to properly render configs from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a77a97e_2abb950f","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":14},"in_reply_to":"9a629dbe_3af786f6","updated":"2016-11-16 20:03:59.000000000","message":"Done","commit_id":"99fff6a5056673029f425bb1517f8708fe250ef0"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"9f015a2e749813e786df769ca2c076d316e03d47","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Convert iPXE boot config to proper Jinja template"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently we do a mix of Jinja template rendering (on deploy image boot)"},{"line_number":10,"context_line":"and modifyinig the boot config inplace on disk with regexps (on"},{"line_number":11,"context_line":"switching to service mode for netboot-ed nodes)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"For Dynamic iPXE configuration we need to properly render configs from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a629dbe_3af786f6","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":14},"in_reply_to":"9a629dbe_86b5a232","updated":"2016-11-08 20:12:06.000000000","message":"will fix","commit_id":"99fff6a5056673029f425bb1517f8708fe250ef0"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"9bafc182726ab443e7dc7b603fa6799f73ed2703","unresolved":false,"context_lines":[{"line_number":11,"context_line":"switching to service mode for netboot-ed nodes)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"For Dynamic iPXE configuration we need to properly render configs from"},{"line_number":14,"context_line":"templates during pxe config swith too,"},{"line_number":15,"context_line":"and not resort to parsing/editing existing files on disk."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch changes the default iPXE boot config to proper Jinja2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a629dbe_0680b245","line":14,"range":{"start_line":14,"start_character":28,"end_line":14,"end_character":33},"updated":"2016-11-08 19:53:46.000000000","message":"?","commit_id":"99fff6a5056673029f425bb1517f8708fe250ef0"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"9f015a2e749813e786df769ca2c076d316e03d47","unresolved":false,"context_lines":[{"line_number":11,"context_line":"switching to service mode for netboot-ed nodes)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"For Dynamic iPXE configuration we need to properly render configs from"},{"line_number":14,"context_line":"templates during pxe config swith too,"},{"line_number":15,"context_line":"and not resort to parsing/editing existing files on disk."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch changes the default iPXE boot config to proper Jinja2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a629dbe_7ad9fe82","line":14,"range":{"start_line":14,"start_character":28,"end_line":14,"end_character":33},"in_reply_to":"9a629dbe_0680b245","updated":"2016-11-08 20:12:06.000000000","message":"switch\n\nwill fix","commit_id":"99fff6a5056673029f425bb1517f8708fe250ef0"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"cc8c9db25e3d171144848df48c161bb1b4e1ad1f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"switching to service mode for netboot-ed nodes)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"For Dynamic iPXE configuration we need to properly render configs from"},{"line_number":14,"context_line":"templates during pxe config swith too,"},{"line_number":15,"context_line":"and not resort to parsing/editing existing files on disk."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch changes the default iPXE boot config to proper Jinja2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a77a97e_8a42e90e","line":14,"range":{"start_line":14,"start_character":28,"end_line":14,"end_character":33},"in_reply_to":"9a629dbe_7ad9fe82","updated":"2016-11-16 20:03:59.000000000","message":"Done","commit_id":"99fff6a5056673029f425bb1517f8708fe250ef0"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"9bafc182726ab443e7dc7b603fa6799f73ed2703","unresolved":false,"context_lines":[{"line_number":20,"context_line":"deploy vs instance oriented (instead of pxe vs ipxe)."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Until all other boot config templates are converted to proper Jinja"},{"line_number":23,"context_line":"templates, iPXE is using it\u0027s own procedure for switching pxe boot configs."},{"line_number":24,"context_line":"Precautions have been taken to not break those using custom, out-of-tree"},{"line_number":25,"context_line":"templates for iPXE boot configuration."},{"line_number":26,"context_line":"Just for this purpose there are still some file reading/parsing parts -"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a629dbe_06f7d2f5","line":23,"range":{"start_line":23,"start_character":25,"end_line":23,"end_character":29},"updated":"2016-11-08 19:53:46.000000000","message":"nit: s/it\u0027s/its","commit_id":"99fff6a5056673029f425bb1517f8708fe250ef0"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"9f015a2e749813e786df769ca2c076d316e03d47","unresolved":false,"context_lines":[{"line_number":20,"context_line":"deploy vs instance oriented (instead of pxe vs ipxe)."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Until all other boot config templates are converted to proper Jinja"},{"line_number":23,"context_line":"templates, iPXE is using it\u0027s own procedure for switching pxe boot configs."},{"line_number":24,"context_line":"Precautions have been taken to not break those using custom, out-of-tree"},{"line_number":25,"context_line":"templates for iPXE boot configuration."},{"line_number":26,"context_line":"Just for this purpose there are still some file reading/parsing parts -"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a629dbe_9ae89212","line":23,"range":{"start_line":23,"start_character":25,"end_line":23,"end_character":29},"in_reply_to":"9a629dbe_06f7d2f5","updated":"2016-11-08 20:12:06.000000000","message":"will fix","commit_id":"99fff6a5056673029f425bb1517f8708fe250ef0"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"cc8c9db25e3d171144848df48c161bb1b4e1ad1f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"deploy vs instance oriented (instead of pxe vs ipxe)."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Until all other boot config templates are converted to proper Jinja"},{"line_number":23,"context_line":"templates, iPXE is using it\u0027s own procedure for switching pxe boot configs."},{"line_number":24,"context_line":"Precautions have been taken to not break those using custom, out-of-tree"},{"line_number":25,"context_line":"templates for iPXE boot configuration."},{"line_number":26,"context_line":"Just for this purpose there are still some file reading/parsing parts -"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a77a97e_aa45e517","line":23,"range":{"start_line":23,"start_character":25,"end_line":23,"end_character":29},"in_reply_to":"9a629dbe_9ae89212","updated":"2016-11-16 20:03:59.000000000","message":"Done","commit_id":"99fff6a5056673029f425bb1517f8708fe250ef0"}],"ironic/cmd/conductor.py":[{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"eb70ca300048bf04627e83609e056285cb7a642b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from oslo_log import log"},{"line_number":26,"context_line":"from oslo_service import service"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from ironic.common.i18n import _LW"},{"line_number":29,"context_line":"from ironic.common import pxe_utils"},{"line_number":30,"context_line":"from ironic.common import rpc_service"},{"line_number":31,"context_line":"from ironic.common import service as ironic_service"}],"source_content_type":"text/x-python","patch_set":21,"id":"bff0334d_347e5319","line":28,"range":{"start_line":28,"start_character":31,"end_line":28,"end_character":34},"updated":"2017-04-07 08:44:25.000000000","message":"This is deprecated. Please remove it.","commit_id":"83ac23bcdbd9b65d5321f661b51f44ce04572bb0"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"a3654dc702baea4bea87ce3fb64893e8ef49ea3e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from oslo_log import log"},{"line_number":26,"context_line":"from oslo_service import service"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from ironic.common.i18n import _LW"},{"line_number":29,"context_line":"from ironic.common import pxe_utils"},{"line_number":30,"context_line":"from ironic.common import rpc_service"},{"line_number":31,"context_line":"from ironic.common import service as ironic_service"}],"source_content_type":"text/x-python","patch_set":21,"id":"bff0334d_0af44ace","line":28,"range":{"start_line":28,"start_character":31,"end_line":28,"end_character":34},"in_reply_to":"bff0334d_347e5319","updated":"2017-04-07 09:48:20.000000000","message":"yep, was an artifact of rebase. done","commit_id":"83ac23bcdbd9b65d5321f661b51f44ce04572bb0"}],"ironic/common/pxe_utils.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e1e713d989e8f15bcb036a179135716749975f40","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"def warn_on_legacy_ipxe_templates():"},{"line_number":343,"context_line":"    msg \u003d _LW(\"The specified iPXE boot config template %s is not a proper \""},{"line_number":344,"context_line":"              \"Jinja template and must be updated. \""},{"line_number":345,"context_line":"              \"It will be fixed in-memory. \""},{"line_number":346,"context_line":"              \"This is deprecated and will be impossible in Pike release.\")"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a430d35_39f66bf9","line":343,"updated":"2017-02-07 20:17:53.000000000","message":"msg is used only when ipxe enabled, please move it under if statement.","commit_id":"6be56638a0417882737399536c2c3ff9845c0d8b"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"6aa822d018b1ea4ec345db8a77dfb358cf1fc91b","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"def warn_on_legacy_ipxe_templates():"},{"line_number":343,"context_line":"    msg \u003d _LW(\"The specified iPXE boot config template %s is not a proper \""},{"line_number":344,"context_line":"              \"Jinja template and must be updated. \""},{"line_number":345,"context_line":"              \"It will be fixed in-memory. \""},{"line_number":346,"context_line":"              \"This is deprecated and will be impossible in Pike release.\")"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa31d9ce_f14dec3e","line":343,"in_reply_to":"1a430d35_39f66bf9","updated":"2017-02-14 11:24:39.000000000","message":"Done","commit_id":"6be56638a0417882737399536c2c3ff9845c0d8b"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e1e713d989e8f15bcb036a179135716749975f40","unresolved":false,"context_lines":[{"line_number":347,"context_line":"    if CONF.pxe.ipxe_enabled:"},{"line_number":348,"context_line":"        # NOTE(pas-ha) casting to list for py3 support"},{"line_number":349,"context_line":"        # in py3 .values() returns dict_values object"},{"line_number":350,"context_line":"        templates \u003d list(CONF.pxe.pxe_config_template_by_arch.values())"},{"line_number":351,"context_line":"        templates.extend([CONF.pxe.uefi_pxe_config_template,"},{"line_number":352,"context_line":"                          CONF.pxe.pxe_config_template])"},{"line_number":353,"context_line":"        for path in {t for t in templates if t}:"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a430d35_f90b03d4","line":350,"updated":"2017-02-07 20:17:53.000000000","message":"The values here may be relative path according to tftp root, tftp basedir should be added prior in this case","commit_id":"6be56638a0417882737399536c2c3ff9845c0d8b"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"6aa822d018b1ea4ec345db8a77dfb358cf1fc91b","unresolved":false,"context_lines":[{"line_number":347,"context_line":"    if CONF.pxe.ipxe_enabled:"},{"line_number":348,"context_line":"        # NOTE(pas-ha) casting to list for py3 support"},{"line_number":349,"context_line":"        # in py3 .values() returns dict_values object"},{"line_number":350,"context_line":"        templates \u003d list(CONF.pxe.pxe_config_template_by_arch.values())"},{"line_number":351,"context_line":"        templates.extend([CONF.pxe.uefi_pxe_config_template,"},{"line_number":352,"context_line":"                          CONF.pxe.pxe_config_template])"},{"line_number":353,"context_line":"        for path in {t for t in templates if t}:"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa31d9ce_1195203e","line":350,"in_reply_to":"1a430d35_f90b03d4","updated":"2017-02-14 11:24:39.000000000","message":"Done","commit_id":"6be56638a0417882737399536c2c3ff9845c0d8b"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e1e713d989e8f15bcb036a179135716749975f40","unresolved":false,"context_lines":[{"line_number":360,"context_line":"                LOG.warning(msg, path)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"def _is_legacy_ipxe_template(template):"},{"line_number":364,"context_line":"    is_proper_template \u003d \"goto {{ pxe_options\" in template"},{"line_number":365,"context_line":"    is_ipxe \u003d template.split()[0].startswith(\"#!ipxe\")"},{"line_number":366,"context_line":"    return is_ipxe and not is_proper_template"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a430d35_b9509bd5","line":363,"updated":"2017-02-07 20:17:53.000000000","message":"would be good to have a comment here why such template is propper ipxe template.\n\nAlso please add docstring.","commit_id":"6be56638a0417882737399536c2c3ff9845c0d8b"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"6aa822d018b1ea4ec345db8a77dfb358cf1fc91b","unresolved":false,"context_lines":[{"line_number":360,"context_line":"                LOG.warning(msg, path)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"def _is_legacy_ipxe_template(template):"},{"line_number":364,"context_line":"    is_proper_template \u003d \"goto {{ pxe_options\" in template"},{"line_number":365,"context_line":"    is_ipxe \u003d template.split()[0].startswith(\"#!ipxe\")"},{"line_number":366,"context_line":"    return is_ipxe and not is_proper_template"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa31d9ce_319ea463","line":363,"in_reply_to":"1a430d35_b9509bd5","updated":"2017-02-14 11:24:39.000000000","message":"Done","commit_id":"6be56638a0417882737399536c2c3ff9845c0d8b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b32fc8dcbf55db388c30c989a5bb9c442e4191c5","unresolved":false,"context_lines":[{"line_number":354,"context_line":"                     for t in templates if t}:"},{"line_number":355,"context_line":"            # NOTE(pas-ha) do not check if path is real file,"},{"line_number":356,"context_line":"            # let the conductor fail on start right away if it is"},{"line_number":357,"context_line":"            # mis-configured with paths to non-existing templates"},{"line_number":358,"context_line":"            with open(path) as f:"},{"line_number":359,"context_line":"                template \u003d f.read()"},{"line_number":360,"context_line":"            if _is_legacy_ipxe_template(template):"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa31d9ce_a0e3a332","line":357,"updated":"2017-02-16 13:09:10.000000000","message":"So you\u0027ll be failing the conductor if e.g. one of the unused by_arch options is incorrect, whereas previously it could work perfectly fine if there were no netboot nodes with that arch. Guess need a reno with upgrade section :(","commit_id":"fad440515252095f1b854c3a75b84f7ad7695342"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"1debd3c930640e8002712d5d209f2abd8a827d38","unresolved":false,"context_lines":[{"line_number":354,"context_line":"                     for t in templates if t}:"},{"line_number":355,"context_line":"            # NOTE(pas-ha) do not check if path is real file,"},{"line_number":356,"context_line":"            # let the conductor fail on start right away if it is"},{"line_number":357,"context_line":"            # mis-configured with paths to non-existing templates"},{"line_number":358,"context_line":"            with open(path) as f:"},{"line_number":359,"context_line":"                template \u003d f.read()"},{"line_number":360,"context_line":"            if _is_legacy_ipxe_template(template):"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba2be162_9476fe03","line":357,"in_reply_to":"fa31d9ce_a0e3a332","updated":"2017-03-06 18:05:11.000000000","message":"Done","commit_id":"fad440515252095f1b854c3a75b84f7ad7695342"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"f66f40a3ac55639785dea2622525f416ff643fc2","unresolved":false,"context_lines":[{"line_number":354,"context_line":"                     for t in templates if t}:"},{"line_number":355,"context_line":"            # NOTE(pas-ha) do not check if path is real file,"},{"line_number":356,"context_line":"            # let the conductor fail on start right away if it is"},{"line_number":357,"context_line":"            # mis-configured with paths to non-existing templates"},{"line_number":358,"context_line":"            with open(path) as f:"},{"line_number":359,"context_line":"                template \u003d f.read()"},{"line_number":360,"context_line":"            if _is_legacy_ipxe_template(template):"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa31d9ce_a7e3b232","line":357,"in_reply_to":"fa31d9ce_a0e3a332","updated":"2017-02-16 15:55:08.000000000","message":"I can drop that note and do .isfile() check to warn only on files that are actually there","commit_id":"fad440515252095f1b854c3a75b84f7ad7695342"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"eb70ca300048bf04627e83609e056285cb7a642b","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from ironic.common import dhcp_factory"},{"line_number":26,"context_line":"from ironic.common import exception"},{"line_number":27,"context_line":"from ironic.common.i18n import _, _LW"},{"line_number":28,"context_line":"from ironic.common import utils"},{"line_number":29,"context_line":"from ironic.drivers.modules import deploy_utils"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"bff0334d_f477cb39","line":27,"range":{"start_line":27,"start_character":34,"end_line":27,"end_character":37},"updated":"2017-04-07 08:44:25.000000000","message":"ditto","commit_id":"83ac23bcdbd9b65d5321f661b51f44ce04572bb0"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"a3654dc702baea4bea87ce3fb64893e8ef49ea3e","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from ironic.common import dhcp_factory"},{"line_number":26,"context_line":"from ironic.common import exception"},{"line_number":27,"context_line":"from ironic.common.i18n import _, _LW"},{"line_number":28,"context_line":"from ironic.common import utils"},{"line_number":29,"context_line":"from ironic.drivers.modules import deploy_utils"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"bff0334d_85c16be7","line":27,"range":{"start_line":27,"start_character":34,"end_line":27,"end_character":37},"in_reply_to":"bff0334d_f477cb39","updated":"2017-04-07 09:48:20.000000000","message":"Done","commit_id":"83ac23bcdbd9b65d5321f661b51f44ce04572bb0"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"102a6a0911dbbfed524d8484e094e6da22183b9f","unresolved":false,"context_lines":[{"line_number":427,"context_line":"    if iwdi:"},{"line_number":428,"context_line":"        boot_disk_type \u003d \u0027boot_whole_disk\u0027"},{"line_number":429,"context_line":"    elif trusted_boot:"},{"line_number":430,"context_line":"        boot_disk_type \u003d \u0027trusted_boot\u0027"},{"line_number":431,"context_line":"    else:"},{"line_number":432,"context_line":"        boot_disk_type \u003d \u0027boot_partition\u0027"},{"line_number":433,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"5ff73747_1154cec9","line":430,"updated":"2017-04-24 07:07:52.000000000","message":"there is no \u0027trusted_boot\u0027 label in the template [0] looks like after rendering it will be broken, but might be I\u0027m missing something.\n\nhttps://review.openstack.org/#/c/393462/23/ironic/drivers/modules/ipxe_config.template","commit_id":"ecc7a9ebbcfabf4807e31a27c022257810355f89"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"38f45e8c88a83e5957ec8eb82d7015964b5bebdb","unresolved":false,"context_lines":[{"line_number":427,"context_line":"    if iwdi:"},{"line_number":428,"context_line":"        boot_disk_type \u003d \u0027boot_whole_disk\u0027"},{"line_number":429,"context_line":"    elif trusted_boot:"},{"line_number":430,"context_line":"        boot_disk_type \u003d \u0027trusted_boot\u0027"},{"line_number":431,"context_line":"    else:"},{"line_number":432,"context_line":"        boot_disk_type \u003d \u0027boot_partition\u0027"},{"line_number":433,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"5ff73747_6a49c75e","line":430,"in_reply_to":"5ff73747_1154cec9","updated":"2017-05-03 10:03:29.000000000","message":"we do have the same problem with current way of iPXE + trusted boot [0] when using the default ipxe_config.template so this is just replicating existing behavior.\n\nSo yes, with default template it would not work, but with a custom one that actually has \u0027trusted_boot\u0027 target it might.\n\nFixing it for default iPXE template should be a task for a separate bug/patch IMO, but unfortunately I have no HW to test it with.\n\n[0] https://github.com/openstack/ironic/blob/39b797faf16b4c6a0f508c51de36c090147b5725/ironic/drivers/modules/deploy_utils.py#L292-L309","commit_id":"ecc7a9ebbcfabf4807e31a27c022257810355f89"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"425de9fa216352a3213dfa01da92eee1ef76cc1c","unresolved":false,"context_lines":[{"line_number":427,"context_line":"    if iwdi:"},{"line_number":428,"context_line":"        boot_disk_type \u003d \u0027boot_whole_disk\u0027"},{"line_number":429,"context_line":"    elif trusted_boot:"},{"line_number":430,"context_line":"        boot_disk_type \u003d \u0027trusted_boot\u0027"},{"line_number":431,"context_line":"    else:"},{"line_number":432,"context_line":"        boot_disk_type \u003d \u0027boot_partition\u0027"},{"line_number":433,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"5ff73747_eaf15703","line":430,"in_reply_to":"5ff73747_6a49c75e","updated":"2017-05-03 10:06:00.000000000","message":"thanks for pointing this, can you please open a bug to track this, and add here to TODO or FIXME to do not forget about this problem in future?","commit_id":"ecc7a9ebbcfabf4807e31a27c022257810355f89"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"6d83b69ff8e6d8cfb445ef9ca1b6d08be10a2895","unresolved":false,"context_lines":[{"line_number":427,"context_line":"    if iwdi:"},{"line_number":428,"context_line":"        boot_disk_type \u003d \u0027boot_whole_disk\u0027"},{"line_number":429,"context_line":"    elif trusted_boot:"},{"line_number":430,"context_line":"        boot_disk_type \u003d \u0027trusted_boot\u0027"},{"line_number":431,"context_line":"    else:"},{"line_number":432,"context_line":"        boot_disk_type \u003d \u0027boot_partition\u0027"},{"line_number":433,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"5ff73747_f5201c9e","line":430,"in_reply_to":"5ff73747_eaf15703","updated":"2017-05-03 10:37:52.000000000","message":"https://bugs.launchpad.net/ironic/+bug/1687897\n\nadded a comment to ipxe_config.template","commit_id":"ecc7a9ebbcfabf4807e31a27c022257810355f89"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a3e22a122702b7e574fe5fa9ee34ec544fd1cd94","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"def warn_on_legacy_ipxe_templates():"},{"line_number":343,"context_line":"    if CONF.pxe.ipxe_enabled:"},{"line_number":344,"context_line":"        # NOTE(pas-ha) casting to list for py3 support"},{"line_number":345,"context_line":"        # in py3 .values() returns dict_values object"},{"line_number":346,"context_line":"        templates \u003d list(CONF.pxe.pxe_config_template_by_arch.values())"}],"source_content_type":"text/x-python","patch_set":26,"id":"1f013ff3_1fe5bea8","line":343,"updated":"2017-05-16 16:54:02.000000000","message":"this function is too deeply nested, I\u0027d prefer\n\n if not CONF.pxe.ipxe_enabled:\n    return\n\nhere","commit_id":"c842d7309eb29da2da6fd5654de820dd59e16ae0"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"63f103aaeee1a2d66d94d52379e5b7b775f759ea","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"def warn_on_legacy_ipxe_templates():"},{"line_number":343,"context_line":"    if CONF.pxe.ipxe_enabled:"},{"line_number":344,"context_line":"        # NOTE(pas-ha) casting to list for py3 support"},{"line_number":345,"context_line":"        # in py3 .values() returns dict_values object"},{"line_number":346,"context_line":"        templates \u003d list(CONF.pxe.pxe_config_template_by_arch.values())"}],"source_content_type":"text/x-python","patch_set":26,"id":"1f013ff3_d725e8c3","line":343,"in_reply_to":"1f013ff3_1fe5bea8","updated":"2017-05-17 09:26:49.000000000","message":"Done","commit_id":"c842d7309eb29da2da6fd5654de820dd59e16ae0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a3e22a122702b7e574fe5fa9ee34ec544fd1cd94","unresolved":false,"context_lines":[{"line_number":350,"context_line":"                     for t in templates if t}:"},{"line_number":351,"context_line":"            # NOTE(pas-ha) do not fail on missing files,"},{"line_number":352,"context_line":"            # produce warnings only for present legacy-formatted ipxe files"},{"line_number":353,"context_line":"            if os.path.isfile(path):"},{"line_number":354,"context_line":"                with open(path) as f:"},{"line_number":355,"context_line":"                    template \u003d f.read()"},{"line_number":356,"context_line":"                if _is_legacy_ipxe_template(template):"}],"source_content_type":"text/x-python","patch_set":26,"id":"1f013ff3_ffdfb2d3","line":353,"updated":"2017-05-16 16:54:02.000000000","message":"for the same reason:\n\n if not os.path.isfile(path):\n     continue","commit_id":"c842d7309eb29da2da6fd5654de820dd59e16ae0"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"63f103aaeee1a2d66d94d52379e5b7b775f759ea","unresolved":false,"context_lines":[{"line_number":350,"context_line":"                     for t in templates if t}:"},{"line_number":351,"context_line":"            # NOTE(pas-ha) do not fail on missing files,"},{"line_number":352,"context_line":"            # produce warnings only for present legacy-formatted ipxe files"},{"line_number":353,"context_line":"            if os.path.isfile(path):"},{"line_number":354,"context_line":"                with open(path) as f:"},{"line_number":355,"context_line":"                    template \u003d f.read()"},{"line_number":356,"context_line":"                if _is_legacy_ipxe_template(template):"}],"source_content_type":"text/x-python","patch_set":26,"id":"1f013ff3_972f60a0","line":353,"in_reply_to":"1f013ff3_ffdfb2d3","updated":"2017-05-17 09:26:49.000000000","message":"Done","commit_id":"c842d7309eb29da2da6fd5654de820dd59e16ae0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a3e22a122702b7e574fe5fa9ee34ec544fd1cd94","unresolved":false,"context_lines":[{"line_number":351,"context_line":"            # NOTE(pas-ha) do not fail on missing files,"},{"line_number":352,"context_line":"            # produce warnings only for present legacy-formatted ipxe files"},{"line_number":353,"context_line":"            if os.path.isfile(path):"},{"line_number":354,"context_line":"                with open(path) as f:"},{"line_number":355,"context_line":"                    template \u003d f.read()"},{"line_number":356,"context_line":"                if _is_legacy_ipxe_template(template):"},{"line_number":357,"context_line":"                    LOG.warning("}],"source_content_type":"text/x-python","patch_set":26,"id":"1f013ff3_dff0766a","line":354,"updated":"2017-05-16 16:54:02.000000000","message":"speaking of python 3, I suspect we need to open the file with \"t\" flag..","commit_id":"c842d7309eb29da2da6fd5654de820dd59e16ae0"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"63f103aaeee1a2d66d94d52379e5b7b775f759ea","unresolved":false,"context_lines":[{"line_number":351,"context_line":"            # NOTE(pas-ha) do not fail on missing files,"},{"line_number":352,"context_line":"            # produce warnings only for present legacy-formatted ipxe files"},{"line_number":353,"context_line":"            if os.path.isfile(path):"},{"line_number":354,"context_line":"                with open(path) as f:"},{"line_number":355,"context_line":"                    template \u003d f.read()"},{"line_number":356,"context_line":"                if _is_legacy_ipxe_template(template):"},{"line_number":357,"context_line":"                    LOG.warning("}],"source_content_type":"text/x-python","patch_set":26,"id":"1f013ff3_b8436eaf","line":354,"in_reply_to":"1f013ff3_dff0766a","updated":"2017-05-17 09:26:49.000000000","message":"\u0027r\u0027 (synonym to \u0027rt\u0027) mode is default at least for 3.5 and 3.6 [0], and \u0027t\u0027 seems absent from py2 [1], so I guess sticking to defaults is fine to support both at once\n\n[0] https://docs.python.org/3/library/functions.html#open\n\n[1] https://docs.python.org/2/library/functions.html#open","commit_id":"c842d7309eb29da2da6fd5654de820dd59e16ae0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a3e22a122702b7e574fe5fa9ee34ec544fd1cd94","unresolved":false,"context_lines":[{"line_number":378,"context_line":"    :returns: True or False"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    \"\"\""},{"line_number":381,"context_line":"    is_proper_template \u003d \"goto {{ pxe_options\" in template"},{"line_number":382,"context_line":"    is_ipxe \u003d template.split()[0].startswith(\"#!ipxe\")"},{"line_number":383,"context_line":"    return is_ipxe and not is_proper_template"},{"line_number":384,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"1f013ff3_bff36a73","line":381,"updated":"2017-05-16 16:54:02.000000000","message":"does not look too robust. I hope we have a unit test that the current template does not cause a warning (in case we change it one day to not match this)","commit_id":"c842d7309eb29da2da6fd5654de820dd59e16ae0"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"63f103aaeee1a2d66d94d52379e5b7b775f759ea","unresolved":false,"context_lines":[{"line_number":378,"context_line":"    :returns: True or False"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    \"\"\""},{"line_number":381,"context_line":"    is_proper_template \u003d \"goto {{ pxe_options\" in template"},{"line_number":382,"context_line":"    is_ipxe \u003d template.split()[0].startswith(\"#!ipxe\")"},{"line_number":383,"context_line":"    return is_ipxe and not is_proper_template"},{"line_number":384,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"1f013ff3_d8e4faae","line":381,"in_reply_to":"1f013ff3_bff36a73","updated":"2017-05-17 09:26:49.000000000","message":"good idea, I\u0027ve added such test","commit_id":"c842d7309eb29da2da6fd5654de820dd59e16ae0"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"86472d3df0c928f42e30b3d030a6f3b57a0a83c2","unresolved":false,"context_lines":[{"line_number":365,"context_line":"        with open(path) as f:"},{"line_number":366,"context_line":"            template \u003d f.read()"},{"line_number":367,"context_line":"        if _is_legacy_ipxe_template(template):"},{"line_number":368,"context_line":"            LOG.warning("},{"line_number":369,"context_line":"                \"The specified iPXE boot config template %s is not \""},{"line_number":370,"context_line":"                \"a proper Jinja template and must be updated. \""},{"line_number":371,"context_line":"                \"It will be fixed in-memory. This is deprecated \""},{"line_number":372,"context_line":"                \"and will be impossible in Queens release.\","},{"line_number":373,"context_line":"                path)"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"def _is_legacy_ipxe_template(template):"}],"source_content_type":"text/x-python","patch_set":28,"id":"ff0f0b1f_791d270e","line":373,"range":{"start_line":368,"start_character":0,"end_line":373,"end_character":21},"updated":"2017-05-26 13:01:21.000000000","message":"nit: we could reduce spams in logs by warning once with list of paths","commit_id":"0202971b10e0cfff5954483217c13268be09d043"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5b150c385515df4d9d4b884903923db9bd5b6f90","unresolved":false,"context_lines":[{"line_number":441,"context_line":"    LOG.debug(\"Building service PXE config for node %s\", node.uuid)"},{"line_number":442,"context_line":"    iwdi \u003d node.driver_internal_info.get(\u0027is_whole_disk_image\u0027)"},{"line_number":443,"context_line":"    trusted_boot \u003d deploy_utils.is_trusted_boot_requested(node)"},{"line_number":444,"context_line":"    iscsi_boot \u003d deploy_utils.is_iscsi_boot(task)"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"    if iwdi:"},{"line_number":447,"context_line":"        boot_disk_type \u003d \u0027boot_whole_disk\u0027"}],"source_content_type":"text/x-python","patch_set":31,"id":"3f1d235d_0010a700","line":444,"updated":"2017-07-03 16:00:14.000000000","message":"in pxe._build_pxe_config options we just look at the driver_internal_info flag, why is this bit different? Or should we update the pxe module method? It seems to me that they should follow the same logic.","commit_id":"f926347765d1b3228389f6876bcf037119f2a653"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"791bfb73ae9271e76b68e12c26805e10ec07e191","unresolved":false,"context_lines":[{"line_number":441,"context_line":"    LOG.debug(\"Building service PXE config for node %s\", node.uuid)"},{"line_number":442,"context_line":"    iwdi \u003d node.driver_internal_info.get(\u0027is_whole_disk_image\u0027)"},{"line_number":443,"context_line":"    trusted_boot \u003d deploy_utils.is_trusted_boot_requested(node)"},{"line_number":444,"context_line":"    iscsi_boot \u003d deploy_utils.is_iscsi_boot(task)"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"    if iwdi:"},{"line_number":447,"context_line":"        boot_disk_type \u003d \u0027boot_whole_disk\u0027"}],"source_content_type":"text/x-python","patch_set":31,"id":"3f1d235d_de66fc29","line":444,"in_reply_to":"3f1d235d_0010a700","updated":"2017-07-04 09:32:29.000000000","message":"in fact such discrepancies were mostly present before this patch already.\n\nit seems that the logic of boot from volume currently supports only iscsi+ipxe case, but is written to accommodate for other possibilities in the future.\n\nSo IMO we should indeed rather fix the pxe._build_pxe_config_options to be more explicit. When other than iscsi+ipxe use cases arise it would have to be fixed though.","commit_id":"f926347765d1b3228389f6876bcf037119f2a653"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"159ebb3e9513cbb081b77b28ec7a17c4572182e1","unresolved":false,"context_lines":[{"line_number":441,"context_line":"    LOG.debug(\"Building service PXE config for node %s\", node.uuid)"},{"line_number":442,"context_line":"    iwdi \u003d node.driver_internal_info.get(\u0027is_whole_disk_image\u0027)"},{"line_number":443,"context_line":"    trusted_boot \u003d deploy_utils.is_trusted_boot_requested(node)"},{"line_number":444,"context_line":"    iscsi_boot \u003d deploy_utils.is_iscsi_boot(task)"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"    if iwdi:"},{"line_number":447,"context_line":"        boot_disk_type \u003d \u0027boot_whole_disk\u0027"}],"source_content_type":"text/x-python","patch_set":31,"id":"3f1d235d_185ec511","line":444,"in_reply_to":"3f1d235d_de66fc29","updated":"2017-07-04 11:44:03.000000000","message":"Done","commit_id":"f926347765d1b3228389f6876bcf037119f2a653"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"c5f37fda5855732c1ba24ce69fe45537db98229b","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        with open(path) as f:"},{"line_number":389,"context_line":"            template \u003d f.read()"},{"line_number":390,"context_line":"        if _is_legacy_ipxe_template(template):"},{"line_number":391,"context_line":"            LOG.warning("},{"line_number":392,"context_line":"                \"The specified iPXE boot config template %s is not \""},{"line_number":393,"context_line":"                \"a proper Jinja template and must be updated. \""},{"line_number":394,"context_line":"                \"It will be fixed in-memory. This is deprecated \""}],"source_content_type":"text/x-python","patch_set":37,"id":"df3967d1_83afb37b","line":391,"updated":"2017-08-04 09:18:36.000000000","message":"nit: do log outside the loop with all unproper templates, but ok as is.","commit_id":"c5977bba5a2e3303eae9023b344fc2da96320bef"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"9bafc182726ab443e7dc7b603fa6799f73ed2703","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        have one or neither, but not both."},{"line_number":311,"context_line":"    \"\"\""},{"line_number":312,"context_line":"    if CONF.pxe.ipxe_enabled:"},{"line_number":313,"context_line":"        # NOTE(pas-ha) this will be seen only by those using this method"},{"line_number":314,"context_line":"        # from out-of-tree drivers with iPXE enabled"},{"line_number":315,"context_line":"        LOG.warning(_LW(\"Using \u0027switch_pxe_config\u0027 method whith iPXE enabled \""},{"line_number":316,"context_line":"                        \"is deprecated. \""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_06eb52b1","line":313,"updated":"2016-11-08 19:53:46.000000000","message":"I\u0027m not sure this is necessary, if only out-of-tree drivers will be affected by this","commit_id":"99fff6a5056673029f425bb1517f8708fe250ef0"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"9f015a2e749813e786df769ca2c076d316e03d47","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        have one or neither, but not both."},{"line_number":311,"context_line":"    \"\"\""},{"line_number":312,"context_line":"    if CONF.pxe.ipxe_enabled:"},{"line_number":313,"context_line":"        # NOTE(pas-ha) this will be seen only by those using this method"},{"line_number":314,"context_line":"        # from out-of-tree drivers with iPXE enabled"},{"line_number":315,"context_line":"        LOG.warning(_LW(\"Using \u0027switch_pxe_config\u0027 method whith iPXE enabled \""},{"line_number":316,"context_line":"                        \"is deprecated. \""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_5a97da8f","line":313,"in_reply_to":"9a629dbe_06eb52b1","updated":"2016-11-08 20:12:06.000000000","message":"I am not sure if there is any out-of-tree boot interface using it, but just to be sure I\u0027d leave this warning.","commit_id":"99fff6a5056673029f425bb1517f8708fe250ef0"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e1e713d989e8f15bcb036a179135716749975f40","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        is_whole_disk_image and trusted_boot are mutually exclusive. You can"},{"line_number":312,"context_line":"        have one or neither, but not both."},{"line_number":313,"context_line":"    \"\"\""},{"line_number":314,"context_line":"    if CONF.pxe.ipxe_enabled:"},{"line_number":315,"context_line":"        # NOTE(pas-ha) this will be seen only by those using this method"},{"line_number":316,"context_line":"        # from out-of-tree drivers with iPXE enabled"},{"line_number":317,"context_line":"        LOG.warning(_LW(\"Using \u0027switch_pxe_config\u0027 method whith iPXE enabled \""}],"source_content_type":"text/x-python","patch_set":16,"id":"1a430d35_f9c06352","line":314,"updated":"2017-02-07 20:17:53.000000000","message":"according to deprecation policy this message should be shown only once per conductor start.","commit_id":"6be56638a0417882737399536c2c3ff9845c0d8b"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"6aa822d018b1ea4ec345db8a77dfb358cf1fc91b","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        is_whole_disk_image and trusted_boot are mutually exclusive. You can"},{"line_number":312,"context_line":"        have one or neither, but not both."},{"line_number":313,"context_line":"    \"\"\""},{"line_number":314,"context_line":"    if CONF.pxe.ipxe_enabled:"},{"line_number":315,"context_line":"        # NOTE(pas-ha) this will be seen only by those using this method"},{"line_number":316,"context_line":"        # from out-of-tree drivers with iPXE enabled"},{"line_number":317,"context_line":"        LOG.warning(_LW(\"Using \u0027switch_pxe_config\u0027 method whith iPXE enabled \""}],"source_content_type":"text/x-python","patch_set":16,"id":"1a430d35_4bfb0548","line":314,"in_reply_to":"1a430d35_f9c06352","updated":"2017-02-14 11:24:39.000000000","message":"unfortunately this seems impossible, as whether this function will ever be used depends on whether an image requiring netboot will be deployed on any node, and that we can not predict.\n\nOTOH, only operators who use some custom, out-of-tree boot interfaces inherited from / based on / similar to PXEBoot will ever see this warning (since the default PXEBoot implementation is changed in this patch already), and I\u0027m even not sure such ones exist at all (a comment to this regard is below)","commit_id":"6be56638a0417882737399536c2c3ff9845c0d8b"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"eb70ca300048bf04627e83609e056285cb7a642b","unresolved":false,"context_lines":[{"line_number":330,"context_line":"    if CONF.pxe.ipxe_enabled:"},{"line_number":331,"context_line":"        # NOTE(pas-ha) this will be seen only by those using this method"},{"line_number":332,"context_line":"        # from out-of-tree drivers with iPXE enabled"},{"line_number":333,"context_line":"        LOG.warning(_LW(\"Using \u0027switch_pxe_config\u0027 method whith iPXE enabled \""},{"line_number":334,"context_line":"                        \"is deprecated. \""},{"line_number":335,"context_line":"                        \"Use ironic.common.pxe_utils.render_switched_config \""},{"line_number":336,"context_line":"                        \"instead. If using netboot-ed nodes and custom \""}],"source_content_type":"text/x-python","patch_set":21,"id":"bff0334d_340e533b","line":333,"range":{"start_line":333,"start_character":20,"end_line":333,"end_character":23},"updated":"2017-04-07 08:44:25.000000000","message":"ditto","commit_id":"83ac23bcdbd9b65d5321f661b51f44ce04572bb0"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"eb70ca300048bf04627e83609e056285cb7a642b","unresolved":false,"context_lines":[{"line_number":330,"context_line":"    if CONF.pxe.ipxe_enabled:"},{"line_number":331,"context_line":"        # NOTE(pas-ha) this will be seen only by those using this method"},{"line_number":332,"context_line":"        # from out-of-tree drivers with iPXE enabled"},{"line_number":333,"context_line":"        LOG.warning(_LW(\"Using \u0027switch_pxe_config\u0027 method whith iPXE enabled \""},{"line_number":334,"context_line":"                        \"is deprecated. \""},{"line_number":335,"context_line":"                        \"Use ironic.common.pxe_utils.render_switched_config \""},{"line_number":336,"context_line":"                        \"instead. If using netboot-ed nodes and custom \""}],"source_content_type":"text/x-python","patch_set":21,"id":"bff0334d_a7ffd7ff","line":333,"range":{"start_line":333,"start_character":58,"end_line":333,"end_character":63},"updated":"2017-04-07 08:44:25.000000000","message":"with","commit_id":"83ac23bcdbd9b65d5321f661b51f44ce04572bb0"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"a3654dc702baea4bea87ce3fb64893e8ef49ea3e","unresolved":false,"context_lines":[{"line_number":330,"context_line":"    if CONF.pxe.ipxe_enabled:"},{"line_number":331,"context_line":"        # NOTE(pas-ha) this will be seen only by those using this method"},{"line_number":332,"context_line":"        # from out-of-tree drivers with iPXE enabled"},{"line_number":333,"context_line":"        LOG.warning(_LW(\"Using \u0027switch_pxe_config\u0027 method whith iPXE enabled \""},{"line_number":334,"context_line":"                        \"is deprecated. \""},{"line_number":335,"context_line":"                        \"Use ironic.common.pxe_utils.render_switched_config \""},{"line_number":336,"context_line":"                        \"instead. If using netboot-ed nodes and custom \""}],"source_content_type":"text/x-python","patch_set":21,"id":"bff0334d_65b8a775","line":333,"range":{"start_line":333,"start_character":20,"end_line":333,"end_character":23},"in_reply_to":"bff0334d_340e533b","updated":"2017-04-07 09:48:20.000000000","message":"Done","commit_id":"83ac23bcdbd9b65d5321f661b51f44ce04572bb0"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"a3654dc702baea4bea87ce3fb64893e8ef49ea3e","unresolved":false,"context_lines":[{"line_number":330,"context_line":"    if CONF.pxe.ipxe_enabled:"},{"line_number":331,"context_line":"        # NOTE(pas-ha) this will be seen only by those using this method"},{"line_number":332,"context_line":"        # from out-of-tree drivers with iPXE enabled"},{"line_number":333,"context_line":"        LOG.warning(_LW(\"Using \u0027switch_pxe_config\u0027 method whith iPXE enabled \""},{"line_number":334,"context_line":"                        \"is deprecated. \""},{"line_number":335,"context_line":"                        \"Use ironic.common.pxe_utils.render_switched_config \""},{"line_number":336,"context_line":"                        \"instead. If using netboot-ed nodes and custom \""}],"source_content_type":"text/x-python","patch_set":21,"id":"bff0334d_25b29f95","line":333,"range":{"start_line":333,"start_character":58,"end_line":333,"end_character":63},"in_reply_to":"bff0334d_a7ffd7ff","updated":"2017-04-07 09:48:20.000000000","message":"Done","commit_id":"83ac23bcdbd9b65d5321f661b51f44ce04572bb0"}],"ironic/drivers/modules/ipxe.py":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"9bafc182726ab443e7dc7b603fa6799f73ed2703","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def warn_on_templates():"},{"line_number":31,"context_line":"    msg \u003d _LW(\"The specified iPXE boot config template %s is not a proper \""},{"line_number":32,"context_line":"              \"Jinja template and must be updated. \""},{"line_number":33,"context_line":"              \"It will be fixed in-memory. \""},{"line_number":34,"context_line":"              \"This is deprecated and will be impossible in the future.\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_a679c6fe","line":31,"updated":"2016-11-08 19:53:46.000000000","message":"nit: can you add a comment here, or maybe in the conductor startup code where you call this, when to remove the deprecation warning? I think that\u0027d be start of Queens cycle but not totally sure","commit_id":"99fff6a5056673029f425bb1517f8708fe250ef0"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"9f015a2e749813e786df769ca2c076d316e03d47","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def warn_on_templates():"},{"line_number":31,"context_line":"    msg \u003d _LW(\"The specified iPXE boot config template %s is not a proper \""},{"line_number":32,"context_line":"              \"Jinja template and must be updated. \""},{"line_number":33,"context_line":"              \"It will be fixed in-memory. \""},{"line_number":34,"context_line":"              \"This is deprecated and will be impossible in the future.\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a629dbe_da9beac7","line":31,"in_reply_to":"9a629dbe_a679c6fe","updated":"2016-11-08 20:12:06.000000000","message":"I\u0027m not sure either. Depending on when this is merged,\nit could be even in Pike as it concerns out-of-tree custom ipxe boot configs.","commit_id":"99fff6a5056673029f425bb1517f8708fe250ef0"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"cc8c9db25e3d171144848df48c161bb1b4e1ad1f","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def warn_on_templates():"},{"line_number":31,"context_line":"    msg \u003d _LW(\"The specified iPXE boot config template %s is not a proper \""},{"line_number":32,"context_line":"              \"Jinja template and must be updated. \""},{"line_number":33,"context_line":"              \"It will be fixed in-memory. \""},{"line_number":34,"context_line":"              \"This is deprecated and will be impossible in the future.\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_4a5ff1e4","line":31,"in_reply_to":"9a629dbe_da9beac7","updated":"2016-11-16 20:03:59.000000000","message":"Done","commit_id":"99fff6a5056673029f425bb1517f8708fe250ef0"}],"ironic/drivers/modules/ipxe_config.template":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b32fc8dcbf55db388c30c989a5bb9c442e4191c5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!ipxe"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"goto {{ pxe_options.boot_target | default(\"deploy\") }}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":":deploy"},{"line_number":6,"context_line":"imgfree"}],"source_content_type":"application/octet-stream","patch_set":17,"id":"fa31d9ce_2510a5a8","line":3,"range":{"start_line":3,"start_character":34,"end_line":3,"end_character":51},"updated":"2017-02-16 13:09:10.000000000","message":"Why do we need this one? We always have the value we need, if I read the code correctly.","commit_id":"fad440515252095f1b854c3a75b84f7ad7695342"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"f66f40a3ac55639785dea2622525f416ff643fc2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!ipxe"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"goto {{ pxe_options.boot_target | default(\"deploy\") }}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":":deploy"},{"line_number":6,"context_line":"imgfree"}],"source_content_type":"application/octet-stream","patch_set":17,"id":"fa31d9ce_67c61a4b","line":3,"range":{"start_line":3,"start_character":34,"end_line":3,"end_character":51},"in_reply_to":"fa31d9ce_2510a5a8","updated":"2017-02-16 15:55:08.000000000","message":"that\u0027s for compatibility with possible out-of tree drivers based on PXEBoot, that might still rely on switch_pxe_config to edit the file in-place - they might not have this option passed into template","commit_id":"fad440515252095f1b854c3a75b84f7ad7695342"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"412b21869292f7b952b9020cc9275ace5cecf262","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!ipxe"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"goto {{ pxe_options.boot_target | default(\"deploy\") }}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":":deploy"},{"line_number":6,"context_line":"imgfree"}],"source_content_type":"application/octet-stream","patch_set":17,"id":"fa31d9ce_f2772a9d","line":3,"range":{"start_line":3,"start_character":34,"end_line":3,"end_character":51},"in_reply_to":"fa31d9ce_67c61a4b","updated":"2017-02-16 16:04:57.000000000","message":"gotcha, so this is needed for both ways, new pxe driver using old template and old pxe driver using new template.\n\nAlso, asked that as a general comment, do you intend to do the same for pxe templates?","commit_id":"fad440515252095f1b854c3a75b84f7ad7695342"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"7911faf152281188090670a6d9da76cd304b6bee","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!ipxe"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"goto {{ pxe_options.boot_target | default(\"deploy\") }}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":":deploy"},{"line_number":6,"context_line":"imgfree"}],"source_content_type":"application/octet-stream","patch_set":17,"id":"fa31d9ce_cd2fe7a5","line":3,"range":{"start_line":3,"start_character":34,"end_line":3,"end_character":51},"in_reply_to":"fa31d9ce_f2772a9d","updated":"2017-02-16 16:46:13.000000000","message":"frankly speaking - not right now :)\n\nRendering whole desired template at once is a hard dependency for dynamic iPXE feature I am implementing.\n\nI do see value in moving all pxe templates to such model too - less regex-based edits of files on disk :), also would simplify takeover, and reduce network usage (+improve security?) if we go a step further and render only the boot_target part of the template that is really going to be executed at this particular boot.\n\nThe problem is, doing this for PXE is going to be less smooth in terms of backward-compat and more complex in the code - there are many types of pxe-templates (we have essentially 3 or 4 different ones in code tree) while ipxe is single type and easily recognizable by its shebang. So fixing the old templates on the fly as I am doing for ipxe ones would be more complex/error prone, or otherwise we\u0027d need to demand that on upgrade all custom out-of-tree templates in use _must_ be upgraded as well (OTOH honestly I have no idea if such things really exist...)\n\nBut if the community sees a merit to such effort I could surely take a swing at that :)","commit_id":"fad440515252095f1b854c3a75b84f7ad7695342"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"4a0a0f3285baa5e14f11d5907f0d4da0da232d0a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!ipxe"},{"line_number":2,"context_line":"# FIXME(pas-ha) add trusted_boot boot target, LP #1687897"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"goto {{ pxe_options.boot_target | default(\"deploy\") }}"},{"line_number":5,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":24,"id":"5ff73747_30fe9205","line":2,"updated":"2017-05-03 11:08:54.000000000","message":"unittests should be updated accordingly.","commit_id":"8fef648a03ff68c5c31ea4d5cf150e27044e026a"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"cc73ce2ec1e2464e27891f08905ed31cf031751c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!ipxe"},{"line_number":2,"context_line":"# FIXME(pas-ha) add trusted_boot boot target, LP #1687897"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"goto {{ pxe_options.boot_target | default(\"deploy\") }}"},{"line_number":5,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":24,"id":"5ff73747_c30d61e9","line":2,"in_reply_to":"5ff73747_30fe9205","updated":"2017-05-03 13:39:13.000000000","message":"I will change this line to proper Jinja2 comment instead so I do not have to replicate this line in the test samples of rendered config as well, and it will not appear in the final rendered config too, less content to transfer over wires.","commit_id":"8fef648a03ff68c5c31ea4d5cf150e27044e026a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a3e22a122702b7e574fe5fa9ee34ec544fd1cd94","unresolved":false,"context_lines":[{"line_number":17,"context_line":"boot"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":":boot_whole_disk"},{"line_number":20,"context_line":"sanboot --no-describe"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"1f013ff3_3fd63ac5","line":20,"updated":"2017-05-16 16:54:02.000000000","message":"nit: no newline at end of file","commit_id":"c842d7309eb29da2da6fd5654de820dd59e16ae0"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"63f103aaeee1a2d66d94d52379e5b7b775f759ea","unresolved":false,"context_lines":[{"line_number":17,"context_line":"boot"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":":boot_whole_disk"},{"line_number":20,"context_line":"sanboot --no-describe"}],"source_content_type":"application/octet-stream","patch_set":26,"id":"1f013ff3_fa44491d","line":20,"in_reply_to":"1f013ff3_3fd63ac5","updated":"2017-05-17 09:26:49.000000000","message":"Done","commit_id":"c842d7309eb29da2da6fd5654de820dd59e16ae0"}],"ironic/drivers/modules/pxe.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b32fc8dcbf55db388c30c989a5bb9c442e4191c5","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        iwdi \u003d node.driver_internal_info.get(\u0027is_whole_disk_image\u0027)"},{"line_number":247,"context_line":"        deploy_utils.switch_pxe_config("},{"line_number":248,"context_line":"            pxe_config_path, root_uuid_or_disk_id,"},{"line_number":249,"context_line":"            deploy_utils.get_boot_mode_for_deploy(node),"},{"line_number":250,"context_line":"            iwdi, deploy_utils.is_trusted_boot_requested(node))"},{"line_number":251,"context_line":"    else:"},{"line_number":252,"context_line":"        pxe_utils.create_service_ipxe_config(node, pxe_options,"},{"line_number":253,"context_line":"                                             root_uuid_or_disk_id)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa31d9ce_2580a546","line":250,"range":{"start_line":249,"start_character":12,"end_line":250,"end_character":62},"updated":"2017-02-16 13:09:10.000000000","message":"Why not pass these into create_service_ipxe_config on L252? Instead of doing this inside that fucntion? At least this will make things a bit more lookalike.","commit_id":"fad440515252095f1b854c3a75b84f7ad7695342"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"f66f40a3ac55639785dea2622525f416ff643fc2","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        iwdi \u003d node.driver_internal_info.get(\u0027is_whole_disk_image\u0027)"},{"line_number":247,"context_line":"        deploy_utils.switch_pxe_config("},{"line_number":248,"context_line":"            pxe_config_path, root_uuid_or_disk_id,"},{"line_number":249,"context_line":"            deploy_utils.get_boot_mode_for_deploy(node),"},{"line_number":250,"context_line":"            iwdi, deploy_utils.is_trusted_boot_requested(node))"},{"line_number":251,"context_line":"    else:"},{"line_number":252,"context_line":"        pxe_utils.create_service_ipxe_config(node, pxe_options,"},{"line_number":253,"context_line":"                                             root_uuid_or_disk_id)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa31d9ce_6769ba25","line":250,"range":{"start_line":249,"start_character":12,"end_line":250,"end_character":62},"in_reply_to":"fa31d9ce_2580a546","updated":"2017-02-16 15:55:08.000000000","message":"not really got you. Would you like to have interfaces/signatures of switch_pxe_config and create_service_ipxe_config functions to be the same?","commit_id":"fad440515252095f1b854c3a75b84f7ad7695342"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"1debd3c930640e8002712d5d209f2abd8a827d38","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        iwdi \u003d node.driver_internal_info.get(\u0027is_whole_disk_image\u0027)"},{"line_number":247,"context_line":"        deploy_utils.switch_pxe_config("},{"line_number":248,"context_line":"            pxe_config_path, root_uuid_or_disk_id,"},{"line_number":249,"context_line":"            deploy_utils.get_boot_mode_for_deploy(node),"},{"line_number":250,"context_line":"            iwdi, deploy_utils.is_trusted_boot_requested(node))"},{"line_number":251,"context_line":"    else:"},{"line_number":252,"context_line":"        pxe_utils.create_service_ipxe_config(node, pxe_options,"},{"line_number":253,"context_line":"                                             root_uuid_or_disk_id)"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba2be162_8edb3f21","line":250,"range":{"start_line":249,"start_character":12,"end_line":250,"end_character":62},"in_reply_to":"fa31d9ce_325b8230","updated":"2017-03-06 18:05:11.000000000","message":"IMO from the logic of those methods it would be more appropriate to make the signature of create_service_ipxe_config to be more similar to create_pxe_config (as those two are rendering the final config from a template, and possibly in the future might actually become a single method..)\n\nI\u0027ll edit the create_service_ipxe_config to have (task, pxe_options, pxe_config_template, root_uuid) as args (so compared to create_pxe_config, only root_... arg is added.","commit_id":"fad440515252095f1b854c3a75b84f7ad7695342"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"412b21869292f7b952b9020cc9275ace5cecf262","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        iwdi \u003d node.driver_internal_info.get(\u0027is_whole_disk_image\u0027)"},{"line_number":247,"context_line":"        deploy_utils.switch_pxe_config("},{"line_number":248,"context_line":"            pxe_config_path, root_uuid_or_disk_id,"},{"line_number":249,"context_line":"            deploy_utils.get_boot_mode_for_deploy(node),"},{"line_number":250,"context_line":"            iwdi, deploy_utils.is_trusted_boot_requested(node))"},{"line_number":251,"context_line":"    else:"},{"line_number":252,"context_line":"        pxe_utils.create_service_ipxe_config(node, pxe_options,"},{"line_number":253,"context_line":"                                             root_uuid_or_disk_id)"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa31d9ce_325b8230","line":250,"range":{"start_line":249,"start_character":12,"end_line":250,"end_character":62},"in_reply_to":"fa31d9ce_6769ba25","updated":"2017-02-16 16:04:57.000000000","message":"not same, but similar :)","commit_id":"fad440515252095f1b854c3a75b84f7ad7695342"}],"ironic/tests/unit/common/test_pxe_utils.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b32fc8dcbf55db388c30c989a5bb9c442e4191c5","unresolved":false,"context_lines":[{"line_number":675,"context_line":"    @mock.patch.object(pxe_utils, \u0027LOG\u0027, autospec\u003dTrue)"},{"line_number":676,"context_line":"    def test_warn_on_legacy_ipxe_templtates(self, log_mock):"},{"line_number":677,"context_line":"        self.config(group\u003d\u0027pxe\u0027, ipxe_enabled\u003dTrue)"},{"line_number":678,"context_line":"        self.config(group\u003d\u0027pxe\u0027, pxe_config_template\u003d\u0027spam\u0027)"},{"line_number":679,"context_line":"        self.config(group\u003d\u0027pxe\u0027, uefi_pxe_config_template\u003d\u0027ham\u0027)"},{"line_number":680,"context_line":"        template \u003d \"#!ipxe\\ngoto deploy\""},{"line_number":681,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"fa31d9ce_c516e957","line":678,"updated":"2017-02-16 13:09:10.000000000","message":"Could you also add by_arch values here?","commit_id":"fad440515252095f1b854c3a75b84f7ad7695342"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"1debd3c930640e8002712d5d209f2abd8a827d38","unresolved":false,"context_lines":[{"line_number":675,"context_line":"    @mock.patch.object(pxe_utils, \u0027LOG\u0027, autospec\u003dTrue)"},{"line_number":676,"context_line":"    def test_warn_on_legacy_ipxe_templtates(self, log_mock):"},{"line_number":677,"context_line":"        self.config(group\u003d\u0027pxe\u0027, ipxe_enabled\u003dTrue)"},{"line_number":678,"context_line":"        self.config(group\u003d\u0027pxe\u0027, pxe_config_template\u003d\u0027spam\u0027)"},{"line_number":679,"context_line":"        self.config(group\u003d\u0027pxe\u0027, uefi_pxe_config_template\u003d\u0027ham\u0027)"},{"line_number":680,"context_line":"        template \u003d \"#!ipxe\\ngoto deploy\""},{"line_number":681,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"ba2be162_c9045816","line":678,"in_reply_to":"fa31d9ce_c516e957","updated":"2017-03-06 18:05:11.000000000","message":"Done","commit_id":"fad440515252095f1b854c3a75b84f7ad7695342"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"f66f40a3ac55639785dea2622525f416ff643fc2","unresolved":false,"context_lines":[{"line_number":675,"context_line":"    @mock.patch.object(pxe_utils, \u0027LOG\u0027, autospec\u003dTrue)"},{"line_number":676,"context_line":"    def test_warn_on_legacy_ipxe_templtates(self, log_mock):"},{"line_number":677,"context_line":"        self.config(group\u003d\u0027pxe\u0027, ipxe_enabled\u003dTrue)"},{"line_number":678,"context_line":"        self.config(group\u003d\u0027pxe\u0027, pxe_config_template\u003d\u0027spam\u0027)"},{"line_number":679,"context_line":"        self.config(group\u003d\u0027pxe\u0027, uefi_pxe_config_template\u003d\u0027ham\u0027)"},{"line_number":680,"context_line":"        template \u003d \"#!ipxe\\ngoto deploy\""},{"line_number":681,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"fa31d9ce_4753d66c","line":678,"in_reply_to":"fa31d9ce_c516e957","updated":"2017-02-16 15:55:08.000000000","message":"will do","commit_id":"fad440515252095f1b854c3a75b84f7ad7695342"}]}
