)]}'
{"ironic/drivers/base.py":[{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"af776caa4f99f52c1971f8359abff4d95493982b","unresolved":false,"context_lines":[{"line_number":513,"context_line":"            information.  Different implementations of boot interface will"},{"line_number":514,"context_line":"            have different ways of passing parameters to the ramdisk."},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"        :returns: complete boot config ready to be passed to node as a string"},{"line_number":517,"context_line":"        \"\"\""},{"line_number":518,"context_line":"        raise NotImplementedError"},{"line_number":519,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3a461143_1ef5c7eb","line":516,"range":{"start_line":516,"start_character":8,"end_line":516,"end_character":17},"updated":"2017-02-01 05:48:28.000000000","message":":raises: is missing\n\nI propose to raise UnsupportedDriverExtension here instead of NotImplementedError, because it simplifies the implementation of [1].  \n\n :raises: UnsupportedDriverExtension\n\n [1] https://review.openstack.org/#/c/394399/18/ironic/conductor/manager.py@2596","commit_id":"a04de3ed46c9f961ba70e3a01f96f86e6016b510"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"5f8bc583300ab0957e5ef9ef25105520cd27dd75","unresolved":false,"context_lines":[{"line_number":513,"context_line":"            information.  Different implementations of boot interface will"},{"line_number":514,"context_line":"            have different ways of passing parameters to the ramdisk."},{"line_number":515,"context_line":""},{"line_number":516,"context_line":"        :returns: complete boot config ready to be passed to node as a string"},{"line_number":517,"context_line":"        \"\"\""},{"line_number":518,"context_line":"        raise NotImplementedError"},{"line_number":519,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"1a430d35_dbe004fd","line":516,"range":{"start_line":516,"start_character":8,"end_line":516,"end_character":17},"in_reply_to":"3a461143_1ef5c7eb","updated":"2017-02-07 17:13:05.000000000","message":"Done","commit_id":"a04de3ed46c9f961ba70e3a01f96f86e6016b510"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"af776caa4f99f52c1971f8359abff4d95493982b","unresolved":false,"context_lines":[{"line_number":515,"context_line":""},{"line_number":516,"context_line":"        :returns: complete boot config ready to be passed to node as a string"},{"line_number":517,"context_line":"        \"\"\""},{"line_number":518,"context_line":"        raise NotImplementedError"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"class PowerInterface(BaseInterface):"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a461143_3efc43b7","line":518,"range":{"start_line":518,"start_character":8,"end_line":518,"end_character":33},"updated":"2017-02-01 05:48:28.000000000","message":"Wouldn\u0027t it better to raise UnsupportedDriverExtension here such as inject_nmi at L.871 [2]?\n\n raise exception.UnsupportedDriverExtension(\n    driver\u003dtask.node.driver, extension\u003d\u0027get_boot_config\u0027)","commit_id":"a04de3ed46c9f961ba70e3a01f96f86e6016b510"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"5f8bc583300ab0957e5ef9ef25105520cd27dd75","unresolved":false,"context_lines":[{"line_number":515,"context_line":""},{"line_number":516,"context_line":"        :returns: complete boot config ready to be passed to node as a string"},{"line_number":517,"context_line":"        \"\"\""},{"line_number":518,"context_line":"        raise NotImplementedError"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"class PowerInterface(BaseInterface):"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a430d35_bbdb384e","line":518,"range":{"start_line":518,"start_character":8,"end_line":518,"end_character":33},"in_reply_to":"3a461143_3efc43b7","updated":"2017-02-07 17:13:05.000000000","message":"Done","commit_id":"a04de3ed46c9f961ba70e3a01f96f86e6016b510"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"af776caa4f99f52c1971f8359abff4d95493982b","unresolved":false,"context_lines":[{"line_number":868,"context_line":"        :param task: A TaskManager instance containing the node to act on."},{"line_number":869,"context_line":"        :raises: UnsupportedDriverExtension"},{"line_number":870,"context_line":"        \"\"\""},{"line_number":871,"context_line":"        raise exception.UnsupportedDriverExtension("},{"line_number":872,"context_line":"            driver\u003dtask.node.driver, extension\u003d\u0027inject_nmi\u0027)"},{"line_number":873,"context_line":""},{"line_number":874,"context_line":""},{"line_number":875,"context_line":"class InspectInterface(BaseInterface):"}],"source_content_type":"text/x-python","patch_set":15,"id":"3a461143_5e1e6f0c","line":872,"range":{"start_line":871,"start_character":8,"end_line":872,"end_character":60},"updated":"2017-02-01 05:48:28.000000000","message":"[2] reference from L.518","commit_id":"a04de3ed46c9f961ba70e3a01f96f86e6016b510"}],"ironic/drivers/modules/pxe.py":[{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"b530bb91eec44b853ef3cf653e0287c7518b0f45","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        \"\"\""},{"line_number":578,"context_line":"        node \u003d task.node"},{"line_number":579,"context_line":"        if node.provision_state \u003d\u003d states.ACTIVE:"},{"line_number":580,"context_line":"            # netboot-ed node, serve it the switched boot config"},{"line_number":581,"context_line":"            instance_image_info \u003d _get_instance_image_info("},{"line_number":582,"context_line":"                node, task.context)"},{"line_number":583,"context_line":"            root_uuid_or_disk_id \u003d node.driver_internal_info.get("}],"source_content_type":"text/x-python","patch_set":16,"id":"1a430d35_1c299837","line":580,"updated":"2017-02-08 00:06:17.000000000","message":"*netbooted node","commit_id":"e314cda026984dc14923190f1f450bbbf79a3cb3"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"b530bb91eec44b853ef3cf653e0287c7518b0f45","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        \"\"\""},{"line_number":578,"context_line":"        node \u003d task.node"},{"line_number":579,"context_line":"        if node.provision_state \u003d\u003d states.ACTIVE:"},{"line_number":580,"context_line":"            # netboot-ed node, serve it the switched boot config"},{"line_number":581,"context_line":"            instance_image_info \u003d _get_instance_image_info("},{"line_number":582,"context_line":"                node, task.context)"},{"line_number":583,"context_line":"            root_uuid_or_disk_id \u003d node.driver_internal_info.get("}],"source_content_type":"text/x-python","patch_set":16,"id":"1a430d35_3c22d452","line":580,"updated":"2017-02-08 00:06:17.000000000","message":"*netbooted node","commit_id":"e314cda026984dc14923190f1f450bbbf79a3cb3"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"35924ca29ce45f290822e5e14dd481bf35196d13","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        \"\"\""},{"line_number":578,"context_line":"        node \u003d task.node"},{"line_number":579,"context_line":"        if node.provision_state \u003d\u003d states.ACTIVE:"},{"line_number":580,"context_line":"            # netboot-ed node, serve it the switched boot config"},{"line_number":581,"context_line":"            instance_image_info \u003d _get_instance_image_info("},{"line_number":582,"context_line":"                node, task.context)"},{"line_number":583,"context_line":"            root_uuid_or_disk_id \u003d node.driver_internal_info.get("}],"source_content_type":"text/x-python","patch_set":16,"id":"fa31d9ce_f795dc86","line":580,"in_reply_to":"1a430d35_3c22d452","updated":"2017-02-14 11:24:55.000000000","message":"Done","commit_id":"e314cda026984dc14923190f1f450bbbf79a3cb3"}],"ironic/tests/unit/common/test_pxe_utils.py":[{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"b530bb91eec44b853ef3cf653e0287c7518b0f45","unresolved":false,"context_lines":[{"line_number":625,"context_line":"                          \u0027ip_version\u0027: 4},"},{"line_number":626,"context_line":"                         {\u0027opt_name\u0027: \u0027tag:ipxe,bootfile-name\u0027,"},{"line_number":627,"context_line":"                          \u0027opt_value\u0027: expected_boot_script_url,"},{"line_number":628,"context_line":"                          \u0027ip_version\u0027: 4}]"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":631,"context_line":"            self.assertItemsEqual(expected_info,"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a430d35_0115b547","line":628,"updated":"2017-02-08 00:06:17.000000000","message":"Can this test be broken down into two - one for neutron and the other for isc?","commit_id":"e314cda026984dc14923190f1f450bbbf79a3cb3"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"35924ca29ce45f290822e5e14dd481bf35196d13","unresolved":false,"context_lines":[{"line_number":625,"context_line":"                          \u0027ip_version\u0027: 4},"},{"line_number":626,"context_line":"                         {\u0027opt_name\u0027: \u0027tag:ipxe,bootfile-name\u0027,"},{"line_number":627,"context_line":"                          \u0027opt_value\u0027: expected_boot_script_url,"},{"line_number":628,"context_line":"                          \u0027ip_version\u0027: 4}]"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":631,"context_line":"            self.assertItemsEqual(expected_info,"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa31d9ce_57914846","line":628,"in_reply_to":"1a430d35_0115b547","updated":"2017-02-14 11:24:55.000000000","message":"Done","commit_id":"e314cda026984dc14923190f1f450bbbf79a3cb3"}],"ironic/tests/unit/drivers/modules/test_pxe.py":[{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"b530bb91eec44b853ef3cf653e0287c7518b0f45","unresolved":false,"context_lines":[{"line_number":867,"context_line":"        self.node.save()"},{"line_number":868,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":869,"context_line":"            dhcp_opts \u003d pxe_utils.dhcp_options_for_instance(task)"},{"line_number":870,"context_line":"            task.driver.boot.prepare_ramdisk(task, {\u0027foo\u0027: \u0027bar\u0027})"},{"line_number":871,"context_line":""},{"line_number":872,"context_line":"            mock_deploy_img_info.assert_called_once_with(task.node)"},{"line_number":873,"context_line":"            provider_mock.update_dhcp.assert_called_once_with(task, dhcp_opts)"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a430d35_9cc3c856","line":870,"updated":"2017-02-08 00:06:17.000000000","message":"Please define {\u0027foo\u0027: \u0027bar\u0027} as part of the other constants at the start of this test method.","commit_id":"e314cda026984dc14923190f1f450bbbf79a3cb3"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"35924ca29ce45f290822e5e14dd481bf35196d13","unresolved":false,"context_lines":[{"line_number":867,"context_line":"        self.node.save()"},{"line_number":868,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":869,"context_line":"            dhcp_opts \u003d pxe_utils.dhcp_options_for_instance(task)"},{"line_number":870,"context_line":"            task.driver.boot.prepare_ramdisk(task, {\u0027foo\u0027: \u0027bar\u0027})"},{"line_number":871,"context_line":""},{"line_number":872,"context_line":"            mock_deploy_img_info.assert_called_once_with(task.node)"},{"line_number":873,"context_line":"            provider_mock.update_dhcp.assert_called_once_with(task, dhcp_opts)"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa31d9ce_f7015c39","line":870,"in_reply_to":"1a430d35_9cc3c856","updated":"2017-02-14 11:24:55.000000000","message":"Done. Just removed this as it is not used anywhere else in this test.","commit_id":"e314cda026984dc14923190f1f450bbbf79a3cb3"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"b530bb91eec44b853ef3cf653e0287c7518b0f45","unresolved":false,"context_lines":[{"line_number":873,"context_line":"            provider_mock.update_dhcp.assert_called_once_with(task, dhcp_opts)"},{"line_number":874,"context_line":"            mock_cache_r_k.assert_called_once_with("},{"line_number":875,"context_line":"                self.context, task.node,"},{"line_number":876,"context_line":"                {\u0027deploy_kernel\u0027: \u0027a\u0027, \u0027kernel\u0027: \u0027b\u0027})"},{"line_number":877,"context_line":"            mock_instance_img_info.assert_called_once_with(task.node,"},{"line_number":878,"context_line":"                                                           self.context)"},{"line_number":879,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1a430d35_fca84c8e","line":876,"updated":"2017-02-08 00:06:17.000000000","message":"Same comment as above.","commit_id":"e314cda026984dc14923190f1f450bbbf79a3cb3"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"35924ca29ce45f290822e5e14dd481bf35196d13","unresolved":false,"context_lines":[{"line_number":873,"context_line":"            provider_mock.update_dhcp.assert_called_once_with(task, dhcp_opts)"},{"line_number":874,"context_line":"            mock_cache_r_k.assert_called_once_with("},{"line_number":875,"context_line":"                self.context, task.node,"},{"line_number":876,"context_line":"                {\u0027deploy_kernel\u0027: \u0027a\u0027, \u0027kernel\u0027: \u0027b\u0027})"},{"line_number":877,"context_line":"            mock_instance_img_info.assert_called_once_with(task.node,"},{"line_number":878,"context_line":"                                                           self.context)"},{"line_number":879,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"fa31d9ce_579788eb","line":876,"in_reply_to":"1a430d35_fca84c8e","updated":"2017-02-14 11:24:55.000000000","message":"Done","commit_id":"e314cda026984dc14923190f1f450bbbf79a3cb3"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"b530bb91eec44b853ef3cf653e0287c7518b0f45","unresolved":false,"context_lines":[{"line_number":1146,"context_line":"                task.node, task.context)"},{"line_number":1147,"context_line":"            mock_build_pxe.assert_called_once_with("},{"line_number":1148,"context_line":"                task, mock_instance_img_info.return_value, service\u003dTrue)"},{"line_number":1149,"context_line":"            switch_pxe_config_mock.assert_called_once_with("},{"line_number":1150,"context_line":"                task.node, {\u0027spam\u0027: \u0027ham\u0027, \u0027eggs\u0027: \u0027vikings\u0027},"},{"line_number":1151,"context_line":"                \u0027i_am_root\u0027, on_disk\u003dFalse)"},{"line_number":1152,"context_line":"        self.assertEqual(\u0027fake_rendered_template\u0027, config)"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a430d35_7c9d3c65","line":1150,"range":{"start_line":1149,"start_character":28,"end_line":1150,"end_character":28},"updated":"2017-02-08 00:06:17.000000000","message":"Same comment as above.","commit_id":"e314cda026984dc14923190f1f450bbbf79a3cb3"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"35924ca29ce45f290822e5e14dd481bf35196d13","unresolved":false,"context_lines":[{"line_number":1146,"context_line":"                task.node, task.context)"},{"line_number":1147,"context_line":"            mock_build_pxe.assert_called_once_with("},{"line_number":1148,"context_line":"                task, mock_instance_img_info.return_value, service\u003dTrue)"},{"line_number":1149,"context_line":"            switch_pxe_config_mock.assert_called_once_with("},{"line_number":1150,"context_line":"                task.node, {\u0027spam\u0027: \u0027ham\u0027, \u0027eggs\u0027: \u0027vikings\u0027},"},{"line_number":1151,"context_line":"                \u0027i_am_root\u0027, on_disk\u003dFalse)"},{"line_number":1152,"context_line":"        self.assertEqual(\u0027fake_rendered_template\u0027, config)"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa31d9ce_77c3aced","line":1150,"range":{"start_line":1149,"start_character":28,"end_line":1150,"end_character":28},"in_reply_to":"1a430d35_7c9d3c65","updated":"2017-02-14 11:24:55.000000000","message":"Done","commit_id":"e314cda026984dc14923190f1f450bbbf79a3cb3"}]}
