)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f590d5417af6b25fe95fcd3e90c8d5f00d2330ec","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    tools/ironic/scripts/setup-network.sh"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"are executed by sudo and the PS4 value disappears during sudo. Add a"},{"line_number":15,"context_line":"PS4 value so that we get better logs during their execution."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: If06f079bed16d9c84569594aa64259bf06f91a1e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a629dbe_339d0d66","line":15,"updated":"2016-11-08 12:31:56.000000000","message":"nit: explain what PS4 is about, e.g:\n\nPS4 is used to prefix the tracing output enabled by \"set -x\"","commit_id":"e34b73a9fead39a8112f8c7be8c67b743e75668f"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"1f6ec6ac67317a9f50029e7aa6052a1a448a1ee5","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    tools/ironic/scripts/setup-network.sh"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"are executed by sudo and the PS4 value disappears during sudo. Add a"},{"line_number":15,"context_line":"PS4 value so that we get better logs during their execution."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: If06f079bed16d9c84569594aa64259bf06f91a1e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a629dbe_33918df1","line":15,"in_reply_to":"9a629dbe_339d0d66","updated":"2016-11-08 12:35:00.000000000","message":"Makes sense to me :)","commit_id":"e34b73a9fead39a8112f8c7be8c67b743e75668f"}],"devstack/tools/ironic/scripts/cleanup-node.sh":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f590d5417af6b25fe95fcd3e90c8d5f00d2330ec","unresolved":false,"context_lines":[{"line_number":8,"context_line":"set -exu"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# Make tracing more educational"},{"line_number":11,"context_line":"export PS4\u003d\u0027+ ${BASH_SOURCE:-}:${FUNCNAME[0]:-}:L${LINENO:-}:   \u0027"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"LIBVIRT_STORAGE_POOL\u003d${LIBVIRT_STORAGE_POOL:-\"default\"}"},{"line_number":14,"context_line":"LIBVIRT_CONNECT_URI\u003d${LIBVIRT_CONNECT_URI:-\"qemu:///system\"}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a629dbe_73bb05c5","line":11,"updated":"2016-11-08 12:31:56.000000000","message":"Would be good to have this template as part of a common file and get it sourced on this scripts instead of duplicating this line over. What do you think ?","commit_id":"e34b73a9fead39a8112f8c7be8c67b743e75668f"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"1de1cbbb25902bba8cd5a70639824bec1f75bd3d","unresolved":false,"context_lines":[{"line_number":8,"context_line":"set -exu"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# Make tracing more educational"},{"line_number":11,"context_line":"export PS4\u003d\u0027+ ${BASH_SOURCE:-}:${FUNCNAME[0]:-}:L${LINENO:-}:   \u0027"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"LIBVIRT_STORAGE_POOL\u003d${LIBVIRT_STORAGE_POOL:-\"default\"}"},{"line_number":14,"context_line":"LIBVIRT_CONNECT_URI\u003d${LIBVIRT_CONNECT_URI:-\"qemu:///system\"}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a629dbe_f3d8f5f1","line":11,"in_reply_to":"9a629dbe_73bb05c5","updated":"2016-11-08 12:34:05.000000000","message":"A trade-off between added complexity and code duplication. Since this gets run as \u0027sudo\u0027 it makes it maybe a tiny bit more complicated.\n\nAlso putting in the logic to source in a common file is more complicated than this one export line.\n\nWhat do you think?","commit_id":"e34b73a9fead39a8112f8c7be8c67b743e75668f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"16e833808b8a9794c724b66474150700b2e69e30","unresolved":false,"context_lines":[{"line_number":8,"context_line":"set -exu"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# Make tracing more educational"},{"line_number":11,"context_line":"export PS4\u003d\u0027+ ${BASH_SOURCE:-}:${FUNCNAME[0]:-}:L${LINENO:-}:   \u0027"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"LIBVIRT_STORAGE_POOL\u003d${LIBVIRT_STORAGE_POOL:-\"default\"}"},{"line_number":14,"context_line":"LIBVIRT_CONNECT_URI\u003d${LIBVIRT_CONNECT_URI:-\"qemu:///system\"}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a629dbe_33a8ad1f","line":11,"in_reply_to":"9a629dbe_f3d8f5f1","updated":"2016-11-08 12:35:26.000000000","message":"Cool, I\u0027m good with it. If we happen to duplicate this even more then we can move to a common place.","commit_id":"e34b73a9fead39a8112f8c7be8c67b743e75668f"}]}