)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"4514254c13c54cfc69a698f23cc7f2c4a1bbf36a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the built-in VNC server of iDRAC platform available on"},{"line_number":11,"context_line":"iDRAC7 or later, firmware \u003e\u003d 1.50.50"},{"line_number":12,"context_line":"(Dell PowerEdge 12th gen with FW update, 13th gen out of the box,"},{"line_number":13,"context_line":"with iDRAC Entreprise license)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Management is implemented as ironic Console interface and uses WS-MAN"},{"line_number":16,"context_line":"HTTP API. An example driver using this interface is added (agent_drac_vnc)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a77a97e_eeb1b890","line":13,"updated":"2016-11-16 18:01:10.000000000","message":"Typo: \"Enterprise\"","commit_id":"01dee929ace348c8254e71086b1d4ce914b59f48"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"4514254c13c54cfc69a698f23cc7f2c4a1bbf36a","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"For now this interface is plugged as standard Console interface of"},{"line_number":19,"context_line":"ironic driver, but actually this work depends on \"VNC Graphical console\""},{"line_number":20,"context_line":"spec being implemented."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Some parts of this implementation are planned to be proposed to"},{"line_number":23,"context_line":"python-dracclient, as currently the code exposes too much of ws-man"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a77a97e_8e4e8494","line":20,"updated":"2016-11-16 18:01:10.000000000","message":"Maybe add a Depends-On or other link to the spec?","commit_id":"01dee929ace348c8254e71086b1d4ce914b59f48"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"6c16e25fee3142ad430a657ff3af595d368f16ca","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"For now this interface is plugged as standard Console interface of"},{"line_number":19,"context_line":"ironic driver, but actually this work depends on \"VNC Graphical console\""},{"line_number":20,"context_line":"spec being implemented."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Some parts of this implementation are planned to be proposed to"},{"line_number":23,"context_line":"python-dracclient, as currently the code exposes too much of ws-man"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a77a97e_cc5dfaed","line":20,"in_reply_to":"7a77a97e_8e4e8494","updated":"2016-11-22 18:25:47.000000000","message":"not really - the depends-on should be on patch that implements that spec :) this is already working as is by \"hijacking\" console interface","commit_id":"01dee929ace348c8254e71086b1d4ce914b59f48"}],"ironic/drivers/drac.py":[{"author":{"_account_id":7900,"name":"Tomasz Paszkowski","email":"ss7pro@gmail.com","username":"tpaszkowski"},"change_message_id":"406e56558874779368d5d8b3854333bac30b462f","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            \u0027PXEDracInspectorDriver\u0027)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"class AgentDracVNCDriver(base.BaseDriver):"},{"line_number":77,"context_line":"    \"\"\"DRAC driver using Agent for deploy and exposing VNC console.\"\"\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_213f5a26","line":76,"updated":"2016-11-22 17:11:56.000000000","message":"We also need an option to include VNC console in other drivers (ie: ipmitool). You can easily imagine an environment where you want keep using ipmitool but take advantage of VNC. Best would be to make this easily plug-able by every driver.","commit_id":"01dee929ace348c8254e71086b1d4ce914b59f48"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"6c16e25fee3142ad430a657ff3af595d368f16ca","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            \u0027PXEDracInspectorDriver\u0027)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"class AgentDracVNCDriver(base.BaseDriver):"},{"line_number":77,"context_line":"    \"\"\"DRAC driver using Agent for deploy and exposing VNC console.\"\"\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_c917ac52","line":76,"in_reply_to":"7a77a97e_213f5a26","updated":"2016-11-22 18:25:47.000000000","message":"right now it is already possible - create your own driver and specify this as console (or in the future, \u0027graphical_console\u0027) interface, just check that dracclient is installed as it is done here.\n\nas for \u0027easy-plug\u0027 - that would depend on implementing \u0027driver composition reform\u0027 spec which wil allow to combine drivers from interfaces at run time. Driver composition reform is per community decision already a pre-requisite for the \"VNC console\" spec","commit_id":"01dee929ace348c8254e71086b1d4ce914b59f48"},{"author":{"_account_id":7900,"name":"Tomasz Paszkowski","email":"ss7pro@gmail.com","username":"tpaszkowski"},"change_message_id":"406e56558874779368d5d8b3854333bac30b462f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        self.management \u003d management.DracManagement()"},{"line_number":89,"context_line":"        self.raid \u003d raid.DracRAID()"},{"line_number":90,"context_line":"        self.vendor \u003d vendor_passthru.DracVendorPassthru()"},{"line_number":91,"context_line":"        self.console \u003d vnc.iDracVNCConsole()"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"class FakeDracVNCDriver(base.BaseDriver):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_61db121c","line":91,"updated":"2016-11-22 17:11:56.000000000","message":"Can we introduce a new field name, ie: self.graphical_console here ? It would be nice to keep an option for generic console (ie: SOL) and let it to operator and user to select which one they would like to use.","commit_id":"01dee929ace348c8254e71086b1d4ce914b59f48"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"6c16e25fee3142ad430a657ff3af595d368f16ca","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        self.management \u003d management.DracManagement()"},{"line_number":89,"context_line":"        self.raid \u003d raid.DracRAID()"},{"line_number":90,"context_line":"        self.vendor \u003d vendor_passthru.DracVendorPassthru()"},{"line_number":91,"context_line":"        self.console \u003d vnc.iDracVNCConsole()"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"class FakeDracVNCDriver(base.BaseDriver):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_ec01d605","line":91,"in_reply_to":"7a77a97e_61db121c","updated":"2016-11-22 18:25:47.000000000","message":"The VNC spec is proposing separate interfaces for serial and graphical, so it will be available in the final version (whenever it comes :) )","commit_id":"01dee929ace348c8254e71086b1d4ce914b59f48"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"4514254c13c54cfc69a698f23cc7f2c4a1bbf36a","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.console \u003d vnc.iDracVNCConsole()"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"class FakeDracVNCDriver(base.BaseDriver):"},{"line_number":95,"context_line":"    \"\"\"All fake except for VNC console.\"\"\""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_9036a250","line":94,"updated":"2016-11-16 18:01:10.000000000","message":"All the other fake drivers seem to live in ironic/drivers/fake.py.","commit_id":"01dee929ace348c8254e71086b1d4ce914b59f48"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"06a2724139b86c61e982518781413cca4f4bea88","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.console \u003d vnc.iDracVNCConsole()"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"class FakeDracVNCDriver(base.BaseDriver):"},{"line_number":95,"context_line":"    \"\"\"All fake except for VNC console.\"\"\""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_b7d99759","line":94,"in_reply_to":"7a77a97e_9036a250","updated":"2016-11-28 09:29:47.000000000","message":"Done","commit_id":"01dee929ace348c8254e71086b1d4ce914b59f48"}],"ironic/drivers/modules/drac/vnc.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8bb00794c7f045999cfa53859b7f0875aab6c878","unresolved":false,"context_lines":[{"line_number":36,"context_line":"}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# TODO(pas-ha): propose iDRACCard[Service|View] mgmt to python-dracclient"},{"line_number":40,"context_line":"class iDRACCard(object):"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def __init__(self, name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_11cdc030","line":39,"range":{"start_line":39,"start_character":1,"end_line":39,"end_character":73},"updated":"2016-11-11 14:53:19.000000000","message":"FYI https://review.openstack.org/394221","commit_id":"e988b287bb19cb1b07cf5a2a8d444061e8735607"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"4514254c13c54cfc69a698f23cc7f2c4a1bbf36a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"}"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# TODO(pas-ha): propose iDRACCard[Service|View] mgmt to python-dracclient"},{"line_number":40,"context_line":"class iDRACCard(object):"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def __init__(self, name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_104b72ca","line":39,"updated":"2016-11-16 18:01:10.000000000","message":"I eagerly look forward to reviewing that patch :-)","commit_id":"01dee929ace348c8254e71086b1d4ce914b59f48"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"7e79fac70363301f711e0fa808ad9b85b805967c","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    def get_console(self, task):"},{"line_number":209,"context_line":"        p_info \u003d parse_vnc_driver_info(task.node)"},{"line_number":210,"context_line":"        p_info.update(drac_common.parse_driver_info(task.node))"},{"line_number":211,"context_line":"        url \u003d \"vnc://{host}:{port}\".format(host\u003dp_info[\u0027drac_host\u0027],"},{"line_number":212,"context_line":"                                           port\u003dp_info[\u0027drac_vnc_port\u0027])"},{"line_number":213,"context_line":"        return {\u0027type\u0027: \u0027vnc\u0027, \u0027url\u0027: url}"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a74a57a_1a8acbbf","line":211,"range":{"start_line":211,"start_character":56,"end_line":211,"end_character":65},"updated":"2016-11-24 12:47:40.000000000","message":"change to \u0027drac_address\u0027 once https://review.openstack.org/#/c/401234 is merged","commit_id":"01dee929ace348c8254e71086b1d4ce914b59f48"}]}