)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"56ef33d24b9fd39b7d7e0fe99b44e980b0207ded","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hugo Nicodemos \u003cnicodemos@lsd.ufcg.edu.br\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-15 17:05:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Missing or not needed return values in OneView deploy interface"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is about to add the return values of some methods in"},{"line_number":10,"context_line":"the OneView drivers deploy interface or remove it when return"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a74a57a_cb3830f1","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":63},"updated":"2016-11-28 08:15:35.000000000","message":"Fix return values in OneView deploy interface","commit_id":"e2509eb82ee3d4b39effd3678b2760b58ccb1c66"}],"ironic/drivers/modules/oneview/deploy.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5b3cfe6fde751a75464487ab3a3aab016c0f697e","unresolved":false,"context_lines":[{"line_number":221,"context_line":"    oneview_driver \u003d common.ISCSI_PXE_ONEVIEW"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    def get_properties(self):"},{"line_number":224,"context_line":"        return deploy_utils.get_properties()"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    def validate(self, task):"},{"line_number":227,"context_line":"        common.verify_node_info(task.node)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_11ebdcb1","line":224,"updated":"2016-11-13 22:26:51.000000000","message":"Ugh :( Please add some unittests too.","commit_id":"fb5b77fd152b7b27513db5798deff309e6d52d28"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d8ea2e2bb606cf03669d359c9e0bc60a49da4a36","unresolved":false,"context_lines":[{"line_number":221,"context_line":"    oneview_driver \u003d common.ISCSI_PXE_ONEVIEW"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    def get_properties(self):"},{"line_number":224,"context_line":"        return deploy_utils.get_properties()"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    def validate(self, task):"},{"line_number":227,"context_line":"        common.verify_node_info(task.node)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_9d4a9154","line":224,"in_reply_to":"9a629dbe_11ebdcb1","updated":"2016-11-14 10:18:33.000000000","message":"++","commit_id":"fb5b77fd152b7b27513db5798deff309e6d52d28"}],"releasenotes/notes/fix-oneview-deploy-return-values-ab2ec6ae568d95a5.yaml":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5b3cfe6fde751a75464487ab3a3aab016c0f697e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixes OneView deploy interface, where some methods was missing"},{"line_number":4,"context_line":"    the return value or it was not needed."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a629dbe_51cd545c","line":3,"range":{"start_line":3,"start_character":55,"end_line":3,"end_character":58},"updated":"2016-11-13 22:26:51.000000000","message":"were","commit_id":"fb5b77fd152b7b27513db5798deff309e6d52d28"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e11ba588ad25e232e1423b0a02fc09d1224bc8ae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixes OneView deploy interface, where some methods were missing"},{"line_number":4,"context_line":"    the return value or it was not needed."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7a77a97e_33a9b4e0","line":3,"updated":"2016-11-21 14:34:50.000000000","message":"Could you describe something user-visible here instead (or in addition)? Like, the driver properties output was missing. was tear_down return value missing anyhow visible from the api?","commit_id":"e2509eb82ee3d4b39effd3678b2760b58ccb1c66"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"56ef33d24b9fd39b7d7e0fe99b44e980b0207ded","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixes OneView deploy interface, where some methods were missing"},{"line_number":4,"context_line":"    the return value or it was not needed."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5a74a57a_8b4b9886","line":3,"in_reply_to":"5a74a57a_d62714c8","updated":"2016-11-28 08:15:35.000000000","message":"+1 to be more specific here.","commit_id":"e2509eb82ee3d4b39effd3678b2760b58ccb1c66"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"0c70e499845c58ad16154cb1883ef99fc14e528f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixes OneView deploy interface, where some methods were missing"},{"line_number":4,"context_line":"    the return value or it was not needed."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5a74a57a_d62714c8","line":3,"in_reply_to":"7a77a97e_33a9b4e0","updated":"2016-11-25 20:08:49.000000000","message":"++.  Looking through this, from a development standpoint, this is the missing piece, what exactly was being encountered by users.","commit_id":"e2509eb82ee3d4b39effd3678b2760b58ccb1c66"}]}
