)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"f3a0060cd54797bc17fbd04bf7583d930369d4c6","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"It also makes portgroups\u0027 address field optional for all API"},{"line_number":13,"context_line":"microversions."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Partial-Bug: #1618754"},{"line_number":16,"context_line":"Change-Id: Id8c62fa56908040b0df16cc54c122ce2473a4587"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"1a6eadb0_698e1a2f","line":14,"updated":"2016-12-16 11:21:57.000000000","message":"We need to update API ref for this.","commit_id":"cce428112e8f258cf09483dbf245822ba6a2d5cf"}],"doc/source/dev/webapi-version-history.rst":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"deecf477e092b8ccdb4ba636f6a21391f73422f8","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"**1.26** (Ocata)"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    Add portgroup ``mode`` and ``properties`` fields."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"**1.25** (Ocata)"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"1a6eadb0_66ef291e","line":7,"updated":"2016-12-16 10:58:57.000000000","message":"Maybe a nit, but: Should we mention that the \"address\" field is not mandatory for portgroups anymore [1] ?\n\n[1] Although, the will affect all versions of the API :-/","commit_id":"cce428112e8f258cf09483dbf245822ba6a2d5cf"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"413b5b053b3a4780afa8808ce3dd9f9309db8f2b","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"**1.26** (Ocata)"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    Add portgroup ``mode`` and ``properties`` fields."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"**1.25** (Ocata)"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"1a6eadb0_461d69bc","line":7,"in_reply_to":"1a6eadb0_66ef291e","updated":"2016-12-19 21:29:13.000000000","message":"Yeah, it isn\u0027t only applicable to 1.26+; it applies to all versions. So I don\u0027t think we want to mention it here. I think it is sufficient to mention it in the release notes as a bug fix.","commit_id":"cce428112e8f258cf09483dbf245822ba6a2d5cf"}],"ironic/api/controllers/v1/portgroup.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5cafffccf596c66b7eb9c2c75c334999f9bccce6","unresolved":false,"context_lines":[{"line_number":95,"context_line":"       single NIC ports\"\"\""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    mode \u003d wsme.wsattr(wtypes.text)"},{"line_number":98,"context_line":"    \"\"\"The mode for this portgroup\"\"\""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    properties \u003d {wtypes.text: types.jsontype}"},{"line_number":101,"context_line":"    \"\"\"This portgroup\u0027s properties\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_c23917d9","line":98,"updated":"2016-12-15 00:43:18.000000000","message":"we may be copy/pasting this everywhere, but it would be nice to have a description of what the values are, eg linux kernel doc on bonding...","commit_id":"a3efc02e9cc757cc547e45ddaaf7d181357a4902"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9c29eae2a90653f2f4a0317de74ec37d07960156","unresolved":false,"context_lines":[{"line_number":95,"context_line":"       single NIC ports\"\"\""},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    mode \u003d wsme.wsattr(wtypes.text)"},{"line_number":98,"context_line":"    \"\"\"The mode for this portgroup\"\"\""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    properties \u003d {wtypes.text: types.jsontype}"},{"line_number":101,"context_line":"    \"\"\"This portgroup\u0027s properties\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_902f4e87","line":98,"in_reply_to":"1a6eadb0_c23917d9","updated":"2016-12-15 12:25:35.000000000","message":"Done","commit_id":"a3efc02e9cc757cc547e45ddaaf7d181357a4902"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5cafffccf596c66b7eb9c2c75c334999f9bccce6","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        \u0027detail\u0027: [\u0027GET\u0027],"},{"line_number":227,"context_line":"    }"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    invalid_sort_key_list \u003d [\u0027extra\u0027, \u0027internal_info\u0027]"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    _subcontroller_map \u003d {"},{"line_number":232,"context_line":"        \u0027ports\u0027: port.PortsController,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_427b478c","line":229,"updated":"2016-12-15 00:43:18.000000000","message":"+ properties?","commit_id":"a3efc02e9cc757cc547e45ddaaf7d181357a4902"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9c29eae2a90653f2f4a0317de74ec37d07960156","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        \u0027detail\u0027: [\u0027GET\u0027],"},{"line_number":227,"context_line":"    }"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    invalid_sort_key_list \u003d [\u0027extra\u0027, \u0027internal_info\u0027]"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    _subcontroller_map \u003d {"},{"line_number":232,"context_line":"        \u0027ports\u0027: port.PortsController,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_772e3144","line":229,"in_reply_to":"1a6eadb0_427b478c","updated":"2016-12-15 12:25:35.000000000","message":"++","commit_id":"a3efc02e9cc757cc547e45ddaaf7d181357a4902"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f431b21aba1e95cb06fb481c314496a2edd8937f","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    name \u003d wsme.wsattr(wtypes.text)"},{"line_number":88,"context_line":"    \"\"\"The logical name for this portgroup. See linux bonding"},{"line_number":89,"context_line":"    documentation for details:"},{"line_number":90,"context_line":"    https://www.kernel.org/doc/Documentation/networking/bonding.txt\"\"\""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    links \u003d wsme.wsattr([link.Link], readonly\u003dTrue)"},{"line_number":93,"context_line":"    \"\"\"A list containing a self link and associated portgroup links\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"1a6eadb0_5af06891","line":90,"updated":"2016-12-15 15:15:44.000000000","message":"I think we want this last sentence for \u0027mode\u0027 (L100)","commit_id":"07b72588087c78a57bd5da46c0384151e625c6f3"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a5c81de6080a42f63e015359fa75b3fb7c65f876","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    name \u003d wsme.wsattr(wtypes.text)"},{"line_number":88,"context_line":"    \"\"\"The logical name for this portgroup. See linux bonding"},{"line_number":89,"context_line":"    documentation for details:"},{"line_number":90,"context_line":"    https://www.kernel.org/doc/Documentation/networking/bonding.txt\"\"\""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    links \u003d wsme.wsattr([link.Link], readonly\u003dTrue)"},{"line_number":93,"context_line":"    \"\"\"A list containing a self link and associated portgroup links\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"1a6eadb0_1f65fdb3","line":90,"in_reply_to":"1a6eadb0_5af06891","updated":"2016-12-15 16:22:21.000000000","message":"ouch :)","commit_id":"07b72588087c78a57bd5da46c0384151e625c6f3"}],"ironic/api/controllers/v1/utils.py":[{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"2ed9180304d628fd3f3278d245b3249819accddc","unresolved":false,"context_lines":[{"line_number":290,"context_line":""},{"line_number":291,"context_line":"def check_allowed_portgroup_fields(fields):"},{"line_number":292,"context_line":"    \"\"\"Check if fetching a particular field of a portgroup is allowed."},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    This method checks if the required version is being requested for fields"},{"line_number":295,"context_line":"    that are only allowed to be fetched in a particular API version."},{"line_number":296,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_c5cedd59","line":293,"updated":"2016-12-13 12:15:39.000000000","message":"maybe refactor check_allowed_fields function?\nThen a dictionary of field names together with their checker functions could be declared on top of this file and simply iterated?","commit_id":"7d248ffa63493db345e0c6b1354002d452669ed9"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6ca5048ebb4ec5e5093c6783e759f312f6b26e21","unresolved":false,"context_lines":[{"line_number":290,"context_line":""},{"line_number":291,"context_line":"def check_allowed_portgroup_fields(fields):"},{"line_number":292,"context_line":"    \"\"\"Check if fetching a particular field of a portgroup is allowed."},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    This method checks if the required version is being requested for fields"},{"line_number":295,"context_line":"    that are only allowed to be fetched in a particular API version."},{"line_number":296,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_209c9a68","line":293,"in_reply_to":"1a6eadb0_c5cedd59","updated":"2016-12-14 15:59:19.000000000","message":"The problem with that is, it\u0027d be hard to make it generic. What if eg we need to have the check:\n\n if \u0027mode\u0027 in fields and \u0027properties\u0027 in fields and check_fun():\n\nor\n\n if \u0027abc\u0027 in fields and \u0027bcd\u0027 not in fields and check_fun():\n\nThe difference is - whether to or/and/not the checks. We\u0027d have to use a small DSL here for that. Let\u0027s do it simple :)","commit_id":"7d248ffa63493db345e0c6b1354002d452669ed9"}],"ironic/conf/default.py":[{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"2ed9180304d628fd3f3278d245b3249819accddc","unresolved":false,"context_lines":[{"line_number":180,"context_line":"portgroup_opts \u003d ["},{"line_number":181,"context_line":"    cfg.StrOpt(\u0027default_portgroup_mode\u0027,"},{"line_number":182,"context_line":"               default\u003d\u0027active-backup\u0027,"},{"line_number":183,"context_line":"               help\u003d_(\u0027Default mode for portgroups.\u0027)),"},{"line_number":184,"context_line":"]"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"service_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_a56d6134","line":183,"updated":"2016-12-13 12:15:39.000000000","message":"Maybe add where all available modes can be found?","commit_id":"7d248ffa63493db345e0c6b1354002d452669ed9"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6ca5048ebb4ec5e5093c6783e759f312f6b26e21","unresolved":false,"context_lines":[{"line_number":180,"context_line":"portgroup_opts \u003d ["},{"line_number":181,"context_line":"    cfg.StrOpt(\u0027default_portgroup_mode\u0027,"},{"line_number":182,"context_line":"               default\u003d\u0027active-backup\u0027,"},{"line_number":183,"context_line":"               help\u003d_(\u0027Default mode for portgroups.\u0027)),"},{"line_number":184,"context_line":"]"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"service_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_20c1fa2e","line":183,"in_reply_to":"1a6eadb0_a56d6134","updated":"2016-12-14 15:59:19.000000000","message":"Hm, OK, will try to add some info here.","commit_id":"7d248ffa63493db345e0c6b1354002d452669ed9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5cafffccf596c66b7eb9c2c75c334999f9bccce6","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    cfg.StrOpt(\u0027default_portgroup_mode\u0027,"},{"line_number":182,"context_line":"               default\u003d\u0027active-backup\u0027,"},{"line_number":183,"context_line":"               help\u003d_(\u0027Default mode for portgroups. Allowed values can be \u0027"},{"line_number":184,"context_line":"                      \u0027found in the linux kernel documentation on bonding, \u0027"},{"line_number":185,"context_line":"                      \u0027referred to as bonding modes.\u0027)),"},{"line_number":186,"context_line":"]"},{"line_number":187,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_e2c61367","line":184,"updated":"2016-12-15 00:43:18.000000000","message":"is there some definitive URL that we can put here?","commit_id":"a3efc02e9cc757cc547e45ddaaf7d181357a4902"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9c29eae2a90653f2f4a0317de74ec37d07960156","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    cfg.StrOpt(\u0027default_portgroup_mode\u0027,"},{"line_number":182,"context_line":"               default\u003d\u0027active-backup\u0027,"},{"line_number":183,"context_line":"               help\u003d_(\u0027Default mode for portgroups. Allowed values can be \u0027"},{"line_number":184,"context_line":"                      \u0027found in the linux kernel documentation on bonding, \u0027"},{"line_number":185,"context_line":"                      \u0027referred to as bonding modes.\u0027)),"},{"line_number":186,"context_line":"]"},{"line_number":187,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_37c3d939","line":184,"in_reply_to":"1a6eadb0_e2c61367","updated":"2016-12-15 12:25:35.000000000","message":"I\u0027ll add a link here.","commit_id":"a3efc02e9cc757cc547e45ddaaf7d181357a4902"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5cafffccf596c66b7eb9c2c75c334999f9bccce6","unresolved":false,"context_lines":[{"line_number":182,"context_line":"               default\u003d\u0027active-backup\u0027,"},{"line_number":183,"context_line":"               help\u003d_(\u0027Default mode for portgroups. Allowed values can be \u0027"},{"line_number":184,"context_line":"                      \u0027found in the linux kernel documentation on bonding, \u0027"},{"line_number":185,"context_line":"                      \u0027referred to as bonding modes.\u0027)),"},{"line_number":186,"context_line":"]"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"service_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_a2e97be8","line":185,"updated":"2016-12-15 00:43:18.000000000","message":"Can it be None? That\u0027s what was used in sample() in portgroup.py.","commit_id":"a3efc02e9cc757cc547e45ddaaf7d181357a4902"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9c29eae2a90653f2f4a0317de74ec37d07960156","unresolved":false,"context_lines":[{"line_number":182,"context_line":"               default\u003d\u0027active-backup\u0027,"},{"line_number":183,"context_line":"               help\u003d_(\u0027Default mode for portgroups. Allowed values can be \u0027"},{"line_number":184,"context_line":"                      \u0027found in the linux kernel documentation on bonding, \u0027"},{"line_number":185,"context_line":"                      \u0027referred to as bonding modes.\u0027)),"},{"line_number":186,"context_line":"]"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"service_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_f2796fc9","line":185,"in_reply_to":"1a6eadb0_a2e97be8","updated":"2016-12-15 12:25:35.000000000","message":"Sample in portgroup.py is a sample of the object that is possible to have in the api. on post request it is possible to have mode\u003dNone, it will be populated in the dbapi layer by the value of this config option. Subsequent reads will return the value that was written.\n\nThe value of this option can not be None, if specified in the config file, whatever is specified is converted to string, so if you add default_portgroup_mode \u003d \u003cNone\u003e to config file, it gets converted to \u0027\u003cNone\u003e\u0027 string. If it is not specified, the default is used.","commit_id":"a3efc02e9cc757cc547e45ddaaf7d181357a4902"}],"ironic/db/sqlalchemy/models.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5cafffccf596c66b7eb9c2c75c334999f9bccce6","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    extra \u003d Column(db_types.JsonEncodedDict)"},{"line_number":192,"context_line":"    internal_info \u003d Column(db_types.JsonEncodedDict)"},{"line_number":193,"context_line":"    standalone_ports_supported \u003d Column(Boolean, default\u003dTrue)"},{"line_number":194,"context_line":"    mode \u003d Column(String(255), default\u003dCONF.default_portgroup_mode)"},{"line_number":195,"context_line":"    properties \u003d Column(db_types.JsonEncodedDict)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_a05df37a","line":194,"updated":"2016-12-15 00:43:18.000000000","message":"is this nullable?\n\nI am a bit uneasy having a default value from the CONF here. It means that the default can change over time. I\u0027d rather this was set (using the config) at a higher level.","commit_id":"a3efc02e9cc757cc547e45ddaaf7d181357a4902"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9c29eae2a90653f2f4a0317de74ec37d07960156","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    extra \u003d Column(db_types.JsonEncodedDict)"},{"line_number":192,"context_line":"    internal_info \u003d Column(db_types.JsonEncodedDict)"},{"line_number":193,"context_line":"    standalone_ports_supported \u003d Column(Boolean, default\u003dTrue)"},{"line_number":194,"context_line":"    mode \u003d Column(String(255), default\u003dCONF.default_portgroup_mode)"},{"line_number":195,"context_line":"    properties \u003d Column(db_types.JsonEncodedDict)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_0d3a4ecc","line":194,"in_reply_to":"1a6eadb0_a05df37a","updated":"2016-12-15 12:25:35.000000000","message":"It is nullable, as when we add the column in the migration all the values for existing entries are null at the beginning. Then we update them all to the conf value during the migration. This default is going to be used to the newly added rows and will be re-read on every service restart. Why do you want it on a higher level? This is in-code thing, so can be changed over time. If it was specified as server_default during the column creation in the migration, that would be forever fixed.","commit_id":"a3efc02e9cc757cc547e45ddaaf7d181357a4902"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"55fb3f719422cb2c7cb4d8b9319f4c8caa909f25","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    extra \u003d Column(db_types.JsonEncodedDict)"},{"line_number":192,"context_line":"    internal_info \u003d Column(db_types.JsonEncodedDict)"},{"line_number":193,"context_line":"    standalone_ports_supported \u003d Column(Boolean, default\u003dTrue)"},{"line_number":194,"context_line":"    mode \u003d Column(String(255), default\u003dCONF.default_portgroup_mode)"},{"line_number":195,"context_line":"    properties \u003d Column(db_types.JsonEncodedDict)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1a6eadb0_d94485b8","line":194,"updated":"2016-12-15 15:26:55.000000000","message":"I don\u0027t know that we have consistency, but I\u0027d like it so that it makes (more) sense in the future, where to put code like this. I would have thought it would be at the objects layer but we don\u0027t do anything like this there. I see in sqlalchemy/api.py file, that in create_node() we do some field settings. So I\u0027d prefer if we moved this code to that file, create_portgroup(). (the uuid is set there too.) WDYT?","commit_id":"07b72588087c78a57bd5da46c0384151e625c6f3"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a5c81de6080a42f63e015359fa75b3fb7c65f876","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    extra \u003d Column(db_types.JsonEncodedDict)"},{"line_number":192,"context_line":"    internal_info \u003d Column(db_types.JsonEncodedDict)"},{"line_number":193,"context_line":"    standalone_ports_supported \u003d Column(Boolean, default\u003dTrue)"},{"line_number":194,"context_line":"    mode \u003d Column(String(255), default\u003dCONF.default_portgroup_mode)"},{"line_number":195,"context_line":"    properties \u003d Column(db_types.JsonEncodedDict)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1a6eadb0_dfec65f5","line":194,"in_reply_to":"1a6eadb0_d94485b8","updated":"2016-12-15 16:22:21.000000000","message":"Hmm, OK, will move there.","commit_id":"07b72588087c78a57bd5da46c0384151e625c6f3"}],"ironic/tests/unit/api/utils.py":[{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"2ed9180304d628fd3f3278d245b3249819accddc","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    # unless explicitly requested. Otherwise, these will cause tests using"},{"line_number":148,"context_line":"    # older API versions to fail."},{"line_number":149,"context_line":"    new_api_ver_arguments \u003d [\u0027mode\u0027, \u0027properties\u0027]"},{"line_number":150,"context_line":"    for arg in new_api_ver_arguments:"},{"line_number":151,"context_line":"        if arg not in kw:"},{"line_number":152,"context_line":"            portgroup.pop(arg)"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_a57721d3","line":150,"updated":"2016-12-13 12:15:39.000000000","message":"maybe it could be depending on allow_portgroup_mode_properties? \nIt would be more clear for users of new API to get all the supported fields. Return value of allow_portgroup_mode_properties could be then mocked.","commit_id":"7d248ffa63493db345e0c6b1354002d452669ed9"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"6ca5048ebb4ec5e5093c6783e759f312f6b26e21","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    # unless explicitly requested. Otherwise, these will cause tests using"},{"line_number":148,"context_line":"    # older API versions to fail."},{"line_number":149,"context_line":"    new_api_ver_arguments \u003d [\u0027mode\u0027, \u0027properties\u0027]"},{"line_number":150,"context_line":"    for arg in new_api_ver_arguments:"},{"line_number":151,"context_line":"        if arg not in kw:"},{"line_number":152,"context_line":"            portgroup.pop(arg)"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_60cbf21e","line":150,"in_reply_to":"1a6eadb0_a57721d3","updated":"2016-12-14 15:59:19.000000000","message":"allow_* methods generally only return true/false. Here we only need to maintain a single list per function of the fields that were introduced after the initial introduction of the object to API. Maybe it\u0027s better to fix the initial set of fields instead and ignore others. But I\u0027d prefer to change it along with the nodes method separately.","commit_id":"7d248ffa63493db345e0c6b1354002d452669ed9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5cafffccf596c66b7eb9c2c75c334999f9bccce6","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    \"\"\"Return a Portgroup object without internal attributes.\"\"\""},{"line_number":141,"context_line":"    portgroup \u003d utils.get_test_portgroup(**kw)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    # These values are not part of the API object"},{"line_number":144,"context_line":"    portgroup.pop(\u0027node_id\u0027)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    # NOTE(jroll): pop out fields that were introduced in later API versions,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_40f09f67","line":143,"updated":"2016-12-15 00:43:18.000000000","message":"it is just node_id, right?\n\nHow about \u0027The node_id is not part of the API object.\u0027","commit_id":"a3efc02e9cc757cc547e45ddaaf7d181357a4902"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9c29eae2a90653f2f4a0317de74ec37d07960156","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    \"\"\"Return a Portgroup object without internal attributes.\"\"\""},{"line_number":141,"context_line":"    portgroup \u003d utils.get_test_portgroup(**kw)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    # These values are not part of the API object"},{"line_number":144,"context_line":"    portgroup.pop(\u0027node_id\u0027)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    # NOTE(jroll): pop out fields that were introduced in later API versions,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_4d30c6e8","line":143,"in_reply_to":"1a6eadb0_40f09f67","updated":"2016-12-15 12:25:35.000000000","message":"Done","commit_id":"a3efc02e9cc757cc547e45ddaaf7d181357a4902"}],"releasenotes/notes/add-portgroup-config-fields-cd21e35e9c210733.yaml":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5cafffccf596c66b7eb9c2c75c334999f9bccce6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - This change adds ``mode`` and ``properties`` fields in the"},{"line_number":4,"context_line":"    portgroup object. Both of them are optional and writable"},{"line_number":5,"context_line":"    from the API. API microversion is bumped to 1.26. If a ``mode``"},{"line_number":6,"context_line":"    field of a portgroup is not set during POST request,"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a6eadb0_5bf08efe","line":3,"updated":"2016-12-15 00:43:18.000000000","message":"For the release notes, \u0027this change\u0027 doesn\u0027t make much sense. How about s/This change adds/Adds/","commit_id":"a3efc02e9cc757cc547e45ddaaf7d181357a4902"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9c29eae2a90653f2f4a0317de74ec37d07960156","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - This change adds ``mode`` and ``properties`` fields in the"},{"line_number":4,"context_line":"    portgroup object. Both of them are optional and writable"},{"line_number":5,"context_line":"    from the API. API microversion is bumped to 1.26. If a ``mode``"},{"line_number":6,"context_line":"    field of a portgroup is not set during POST request,"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a6eadb0_2dfaa575","line":3,"in_reply_to":"1a6eadb0_5bf08efe","updated":"2016-12-15 12:25:35.000000000","message":"Done","commit_id":"a3efc02e9cc757cc547e45ddaaf7d181357a4902"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5cafffccf596c66b7eb9c2c75c334999f9bccce6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - This change adds ``mode`` and ``properties`` fields in the"},{"line_number":4,"context_line":"    portgroup object. Both of them are optional and writable"},{"line_number":5,"context_line":"    from the API. API microversion is bumped to 1.26. If a ``mode``"},{"line_number":6,"context_line":"    field of a portgroup is not set during POST request,"},{"line_number":7,"context_line":"    ``[DEFAULT]default_portgroup_mode`` will be used as its value."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a6eadb0_3b3912a5","line":4,"updated":"2016-12-15 00:43:18.000000000","message":"by \u0027writable\u0027, you mean they can be set?","commit_id":"a3efc02e9cc757cc547e45ddaaf7d181357a4902"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9c29eae2a90653f2f4a0317de74ec37d07960156","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - This change adds ``mode`` and ``properties`` fields in the"},{"line_number":4,"context_line":"    portgroup object. Both of them are optional and writable"},{"line_number":5,"context_line":"    from the API. API microversion is bumped to 1.26. If a ``mode``"},{"line_number":6,"context_line":"    field of a portgroup is not set during POST request,"},{"line_number":7,"context_line":"    ``[DEFAULT]default_portgroup_mode`` will be used as its value."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a6eadb0_4df7e18a","line":4,"in_reply_to":"1a6eadb0_3b3912a5","updated":"2016-12-15 12:25:35.000000000","message":"Done","commit_id":"a3efc02e9cc757cc547e45ddaaf7d181357a4902"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5cafffccf596c66b7eb9c2c75c334999f9bccce6","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - This change adds ``mode`` and ``properties`` fields in the"},{"line_number":4,"context_line":"    portgroup object. Both of them are optional and writable"},{"line_number":5,"context_line":"    from the API. API microversion is bumped to 1.26. If a ``mode``"},{"line_number":6,"context_line":"    field of a portgroup is not set during POST request,"},{"line_number":7,"context_line":"    ``[DEFAULT]default_portgroup_mode`` will be used as its value."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a6eadb0_7b3f0a87","line":6,"updated":"2016-12-15 00:43:18.000000000","message":"s/set during/specified in a/","commit_id":"a3efc02e9cc757cc547e45ddaaf7d181357a4902"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9c29eae2a90653f2f4a0317de74ec37d07960156","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - This change adds ``mode`` and ``properties`` fields in the"},{"line_number":4,"context_line":"    portgroup object. Both of them are optional and writable"},{"line_number":5,"context_line":"    from the API. API microversion is bumped to 1.26. If a ``mode``"},{"line_number":6,"context_line":"    field of a portgroup is not set during POST request,"},{"line_number":7,"context_line":"    ``[DEFAULT]default_portgroup_mode`` will be used as its value."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a6eadb0_6df01d92","line":6,"in_reply_to":"1a6eadb0_7b3f0a87","updated":"2016-12-15 12:25:35.000000000","message":"Done","commit_id":"a3efc02e9cc757cc547e45ddaaf7d181357a4902"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5cafffccf596c66b7eb9c2c75c334999f9bccce6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    startup, to know which ``mode`` value to use when creating a portgroup"},{"line_number":16,"context_line":"    if it is not set."},{"line_number":17,"context_line":"  - |"},{"line_number":18,"context_line":"    ``address`` field of a portgroup is made optional for all API"},{"line_number":19,"context_line":"    microversions."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a6eadb0_dbc3be87","line":18,"updated":"2016-12-15 00:43:18.000000000","message":"s/made//","commit_id":"a3efc02e9cc757cc547e45ddaaf7d181357a4902"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9c29eae2a90653f2f4a0317de74ec37d07960156","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    startup, to know which ``mode`` value to use when creating a portgroup"},{"line_number":16,"context_line":"    if it is not set."},{"line_number":17,"context_line":"  - |"},{"line_number":18,"context_line":"    ``address`` field of a portgroup is made optional for all API"},{"line_number":19,"context_line":"    microversions."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1a6eadb0_2d41c5a9","line":18,"in_reply_to":"1a6eadb0_dbc3be87","updated":"2016-12-15 12:25:35.000000000","message":"Done","commit_id":"a3efc02e9cc757cc547e45ddaaf7d181357a4902"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5cafffccf596c66b7eb9c2c75c334999f9bccce6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1a6eadb0_7b562acf","line":20,"updated":"2016-12-15 00:43:18.000000000","message":"The release note can use some edit\u0027ing but I have to take off. Will suggest something tomorrow.","commit_id":"a3efc02e9cc757cc547e45ddaaf7d181357a4902"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f431b21aba1e95cb06fb481c314496a2edd8937f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds ``mode`` and ``properties`` fields in the portgroup object. Both of"},{"line_number":4,"context_line":"    them are optional and can be set from the API. API microversion is bumped"},{"line_number":5,"context_line":"    to 1.26. If a ``mode`` field of a portgroup is not specified in a POST"},{"line_number":6,"context_line":"    request, ``[DEFAULT]default_portgroup_mode`` will be used as its value."},{"line_number":7,"context_line":"upgrade:"},{"line_number":8,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1a6eadb0_da41d864","line":5,"updated":"2016-12-15 15:15:44.000000000","message":"Instead of \u0027API microversion..\u0027 sentence, how about \u0027They are available starting with API microversion 1.26.\u0027","commit_id":"07b72588087c78a57bd5da46c0384151e625c6f3"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a5c81de6080a42f63e015359fa75b3fb7c65f876","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds ``mode`` and ``properties`` fields in the portgroup object. Both of"},{"line_number":4,"context_line":"    them are optional and can be set from the API. API microversion is bumped"},{"line_number":5,"context_line":"    to 1.26. If a ``mode`` field of a portgroup is not specified in a POST"},{"line_number":6,"context_line":"    request, ``[DEFAULT]default_portgroup_mode`` will be used as its value."},{"line_number":7,"context_line":"upgrade:"},{"line_number":8,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1a6eadb0_c253aee0","line":5,"in_reply_to":"1a6eadb0_da41d864","updated":"2016-12-15 16:22:21.000000000","message":"Done","commit_id":"07b72588087c78a57bd5da46c0384151e625c6f3"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f431b21aba1e95cb06fb481c314496a2edd8937f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Adds ``mode`` and ``properties`` fields in the portgroup object. Both of"},{"line_number":4,"context_line":"    them are optional and can be set from the API. API microversion is bumped"},{"line_number":5,"context_line":"    to 1.26. If a ``mode`` field of a portgroup is not specified in a POST"},{"line_number":6,"context_line":"    request, ``[DEFAULT]default_portgroup_mode`` will be used as its value."},{"line_number":7,"context_line":"upgrade:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    ``[DEFAULT]default_portgroup_mode`` has a value of ``active-backup``"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1a6eadb0_95757399","line":6,"updated":"2016-12-15 15:15:44.000000000","message":"For this last sentence, how about:\n\nIf the ``mode`` field of a port group is not specified in a POST request, its value will be set to the value of the configuration option ``[DEFAULT]default_portgroup_mode``.","commit_id":"07b72588087c78a57bd5da46c0384151e625c6f3"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a5c81de6080a42f63e015359fa75b3fb7c65f876","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Adds ``mode`` and ``properties`` fields in the portgroup object. Both of"},{"line_number":4,"context_line":"    them are optional and can be set from the API. API microversion is bumped"},{"line_number":5,"context_line":"    to 1.26. If a ``mode`` field of a portgroup is not specified in a POST"},{"line_number":6,"context_line":"    request, ``[DEFAULT]default_portgroup_mode`` will be used as its value."},{"line_number":7,"context_line":"upgrade:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    ``[DEFAULT]default_portgroup_mode`` has a value of ``active-backup``"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1a6eadb0_82fb76c0","line":6,"in_reply_to":"1a6eadb0_95757399","updated":"2016-12-15 16:22:21.000000000","message":"Done","commit_id":"07b72588087c78a57bd5da46c0384151e625c6f3"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f431b21aba1e95cb06fb481c314496a2edd8937f","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    request, ``[DEFAULT]default_portgroup_mode`` will be used as its value."},{"line_number":7,"context_line":"upgrade:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    ``[DEFAULT]default_portgroup_mode`` has a value of ``active-backup``"},{"line_number":10,"context_line":"    by default. It might need to be customized to fit your deployment."},{"line_number":11,"context_line":"    This option value will be read from configuration file during"},{"line_number":12,"context_line":"    database migration to populate the ``mode`` field of portgroups"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1a6eadb0_d5da8b4a","line":9,"updated":"2016-12-15 15:15:44.000000000","message":"Add \u0027The configuration option \u0027 before this sentence.","commit_id":"07b72588087c78a57bd5da46c0384151e625c6f3"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a5c81de6080a42f63e015359fa75b3fb7c65f876","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    request, ``[DEFAULT]default_portgroup_mode`` will be used as its value."},{"line_number":7,"context_line":"upgrade:"},{"line_number":8,"context_line":"  - |"},{"line_number":9,"context_line":"    ``[DEFAULT]default_portgroup_mode`` has a value of ``active-backup``"},{"line_number":10,"context_line":"    by default. It might need to be customized to fit your deployment."},{"line_number":11,"context_line":"    This option value will be read from configuration file during"},{"line_number":12,"context_line":"    database migration to populate the ``mode`` field of portgroups"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1a6eadb0_42979e39","line":9,"in_reply_to":"1a6eadb0_d5da8b4a","updated":"2016-12-15 16:22:21.000000000","message":"Done","commit_id":"07b72588087c78a57bd5da46c0384151e625c6f3"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f431b21aba1e95cb06fb481c314496a2edd8937f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    startup, to know which ``mode`` value to use when creating a portgroup"},{"line_number":15,"context_line":"    if it is not set."},{"line_number":16,"context_line":"  - |"},{"line_number":17,"context_line":"    ``address`` field of a portgroup is optional for all API microversions."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1a6eadb0_3553bf6c","line":17,"updated":"2016-12-15 15:15:44.000000000","message":"I am wondering whether it makes sense to mention this in the upgrade part. Changing it from mandatory to optional wouldn\u0027t affect an upgrade, would it? Also, did we change this within the same release? Looks like yes [1], so I\u0027m not sure how we position this in the release notes, since they are all in the same release. Would it make more sense (if we want to mention it), to put it as a bug fix?\n\nSigh. After writing this, I wonder if it even makes sense to mention the mode part in the upgrade. We don\u0027t have a release of ironic yet, with portgroups in it.\n\n[1] http://docs.openstack.org/developer/ironic/dev/webapi-version-history.html","commit_id":"07b72588087c78a57bd5da46c0384151e625c6f3"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a5c81de6080a42f63e015359fa75b3fb7c65f876","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    startup, to know which ``mode`` value to use when creating a portgroup"},{"line_number":15,"context_line":"    if it is not set."},{"line_number":16,"context_line":"  - |"},{"line_number":17,"context_line":"    ``address`` field of a portgroup is optional for all API microversions."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1a6eadb0_42807ef7","line":17,"in_reply_to":"1a6eadb0_3553bf6c","updated":"2016-12-15 16:22:21.000000000","message":"It might be needed for people using other means to make portgroups work, like doing static configuration inside the instance image for example. I\u0027m not sure if both static configuration and config-drive are present, which one of them the OS will give preference to contain the actual info. So I\u0027d leave it.","commit_id":"07b72588087c78a57bd5da46c0384151e625c6f3"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b55dfaeee39d69820a76904a77664cf75bce469d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    startup, to know which ``mode`` value to use when creating a portgroup"},{"line_number":15,"context_line":"    if it is not set."},{"line_number":16,"context_line":"  - |"},{"line_number":17,"context_line":"    ``address`` field of a portgroup is optional for all API microversions."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1a6eadb0_d1753198","line":17,"in_reply_to":"1a6eadb0_3553bf6c","updated":"2016-12-15 20:11:15.000000000","message":"otoh, making this newly introduced mode to get to the instance depends on either changes to nova or on manual config drive generation. so yeah, i feel like i should remove it.","commit_id":"07b72588087c78a57bd5da46c0384151e625c6f3"}]}
