)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5d9995748d28d50742f7d5e441a1c8d0616ca317","unresolved":false,"context_lines":[{"line_number":16,"context_line":" * prepare_cleaning_ports"},{"line_number":17,"context_line":" * prepare_cleaning_ports"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The were deprecated in I0c26582b6b6e9d32650ff3e2b9a3269c3c2d5454"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I758e5b21028a4dfcca9c907c63020d0cfca4e37d"},{"line_number":22,"context_line":"Closes-Bug: #1642512"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a77a97e_9ddbf94e","line":19,"range":{"start_line":19,"start_character":23,"end_line":19,"end_character":64},"updated":"2016-11-17 10:32:33.000000000","message":"nit: would be better to use the git hash so one could do a \"git show \u003chash\u003e\". The Change-Id only works in gerrit.","commit_id":"b4cea8aeb52dacfc708c72dce8366ca79eb8e372"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"649952bd75af4cc0fa01afd11a3fe056c231f87b","unresolved":false,"context_lines":[{"line_number":16,"context_line":" * prepare_cleaning_ports"},{"line_number":17,"context_line":" * prepare_cleaning_ports"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The were deprecated in I0c26582b6b6e9d32650ff3e2b9a3269c3c2d5454"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I758e5b21028a4dfcca9c907c63020d0cfca4e37d"},{"line_number":22,"context_line":"Closes-Bug: #1642512"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a77a97e_6ad2c65d","line":19,"range":{"start_line":19,"start_character":23,"end_line":19,"end_character":64},"in_reply_to":"7a77a97e_9ddbf94e","updated":"2016-11-17 14:02:26.000000000","message":"Done","commit_id":"b4cea8aeb52dacfc708c72dce8366ca79eb8e372"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a9b1751e480b6245750163072a3f2eaa689fb419","unresolved":false,"context_lines":[{"line_number":18,"context_line":" * prepare_cleaning_ports"},{"line_number":19,"context_line":" * tear_down_cleaning_ports"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"The were deprecated in cde11611d93946a1c79e406dc429aa5e742da729"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I758e5b21028a4dfcca9c907c63020d0cfca4e37d"},{"line_number":24,"context_line":"Closes-Bug: #1642512"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a77a97e_1b4d183e","line":21,"updated":"2016-11-17 19:36:47.000000000","message":"nit s/The/They/\n\nWhy does that link also bring up this patch?","commit_id":"8295d3e7efada9679a044e75bfc871e7fa605dac"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bffdc982c60e202aa0f178f38dbb296c54e2569c","unresolved":false,"context_lines":[{"line_number":18,"context_line":" * prepare_cleaning_ports"},{"line_number":19,"context_line":" * tear_down_cleaning_ports"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"The were deprecated in cde11611d93946a1c79e406dc429aa5e742da729"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I758e5b21028a4dfcca9c907c63020d0cfca4e37d"},{"line_number":24,"context_line":"Closes-Bug: #1642512"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a77a97e_1e0c23ec","line":21,"in_reply_to":"7a77a97e_1b4d183e","updated":"2016-11-17 21:08:48.000000000","message":"Good catch, this should actually be the change id, not the commit hash.","commit_id":"8295d3e7efada9679a044e75bfc871e7fa605dac"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"188209b5c3b9a0602a946c9b89513ecbe53ea80c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"add_cleaning_network() and remove_cleaning_network() network interface"},{"line_number":22,"context_line":"methods."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"They were deprecated in I0c26582b6b6e9d32650ff3e2b9a3269c3c2d5454"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I758e5b21028a4dfcca9c907c63020d0cfca4e37d"},{"line_number":27,"context_line":"Closes-Bug: #1642512"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a77a97e_90544c22","line":24,"range":{"start_line":24,"start_character":24,"end_line":24,"end_character":65},"updated":"2016-11-21 09:37:51.000000000","message":"nit: it\u0027s better to use the git hash instead of Change-Id. Gerrit understands both, but git show only will work with the git hash.","commit_id":"96d0a2f0589999d7584f25090085863f3e9c2021"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"425a7d2c9388bbe6871db62685ca2c85185ab013","unresolved":false,"context_lines":[{"line_number":21,"context_line":"add_cleaning_network() and remove_cleaning_network() network interface"},{"line_number":22,"context_line":"methods."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"They were deprecated in I0c26582b6b6e9d32650ff3e2b9a3269c3c2d5454"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I758e5b21028a4dfcca9c907c63020d0cfca4e37d"},{"line_number":27,"context_line":"Closes-Bug: #1642512"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a77a97e_53e63017","line":24,"range":{"start_line":24,"start_character":24,"end_line":24,"end_character":65},"in_reply_to":"7a77a97e_90544c22","updated":"2016-11-21 22:58:39.000000000","message":"If you update, it would be better to move this after line 17 (because it doesn\u0027t make as much sense here -- the \u0027They were deprecated\u0027 could be confusing, since it doesn\u0027t refer to the add_cleaning_network() etc paragraph above.","commit_id":"96d0a2f0589999d7584f25090085863f3e9c2021"}],"releasenotes/notes/remove-deprecated-dhcp-provider-methods-582742f3000be3c7.yaml":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"96d867b0bcf439a75098e17d7078b8cbdbb202b5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Removed deprecated methods from DHCP provider:"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    * create_cleaning_ports"},{"line_number":7,"context_line":"    * delete_cleaning_ports"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a77a97e_c05ad929","line":4,"updated":"2016-11-17 14:40:49.000000000","message":"neutron DHCP provider","commit_id":"3a88b1d1096451c1ccdb7002a78dd1aaa89e50c5"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"96d867b0bcf439a75098e17d7078b8cbdbb202b5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"    Removed related methods from ironic.drivers.modules.deploy_utils:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    * prepare_cleaning_ports"},{"line_number":12,"context_line":"    * tear_down_cleaning_ports"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a77a97e_204aad55","line":11,"updated":"2016-11-17 14:40:49.000000000","message":"This means that now only network interface can manage cleaning ports, please mention this.","commit_id":"3a88b1d1096451c1ccdb7002a78dd1aaa89e50c5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a9b1751e480b6245750163072a3f2eaa689fb419","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7a77a97e_7b444cb6","line":15,"updated":"2016-11-17 19:36:47.000000000","message":"Julia has a good point. What do you think of adding something like this to the end:\n\nIf you have your own custom ironic DHCP provider that implements cleaning methods, you may need to update your code to use the add_cleaning_network() and remove_cleaning_network() network interface methods.","commit_id":"8295d3e7efada9679a044e75bfc871e7fa605dac"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"bffdc982c60e202aa0f178f38dbb296c54e2569c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7a77a97e_1eda634c","line":15,"in_reply_to":"7a77a97e_7b444cb6","updated":"2016-11-17 21:08:48.000000000","message":"++\n\nI think that makes much more sense, especially since I\u0027ve heard of a few operators that have implemented their own dhcp providers.","commit_id":"8295d3e7efada9679a044e75bfc871e7fa605dac"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f5947edd7e6a416ce7fb3bef6b9b934b5aaf0909","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Removed deprecated methods from Neutron DHCP provider:"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    * create_cleaning_ports"},{"line_number":7,"context_line":"    * delete_cleaning_ports"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7a77a97e_43ea0575","line":4,"updated":"2016-11-19 14:46:17.000000000","message":"nit: I think it might read a little better if s/from Neutron provider/from the neutron provider built into Ironic/","commit_id":"96d0a2f0589999d7584f25090085863f3e9c2021"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"425a7d2c9388bbe6871db62685ca2c85185ab013","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Removed deprecated methods from Neutron DHCP provider:"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    * create_cleaning_ports"},{"line_number":7,"context_line":"    * delete_cleaning_ports"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7a77a97e_8424ebaf","line":4,"in_reply_to":"7a77a97e_43ea0575","updated":"2016-11-21 22:58:39.000000000","message":"it should be s/Removed/Removes/","commit_id":"96d0a2f0589999d7584f25090085863f3e9c2021"}]}