)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"e826250e638a708ddd61f0c5efe9e37f1894ae2d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Extra problem is that this package does not exsit for earlier Ubuntu"},{"line_number":12,"context_line":"versions at all."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"More over, while in Trusy \u0027syslinux\u0027 package depends on"},{"line_number":15,"context_line":"\u0027syslinux-common\u0027, it only recommends it in Xenial, but we need it"},{"line_number":16,"context_line":"installed as it contains required for syslinux *.c32 modules."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a77a97e_6771aa77","line":14,"updated":"2016-11-21 13:47:02.000000000","message":"Typo: \"Trusty\"","commit_id":"fe47135ae73b9559b3608aeb5969aeda088b1fb3"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"afd616850be91eb22bf16f0939bc31152d389529","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Extra problem is that this package does not exsit for earlier Ubuntu"},{"line_number":12,"context_line":"versions at all."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"More over, while in Trusy \u0027syslinux\u0027 package depends on"},{"line_number":15,"context_line":"\u0027syslinux-common\u0027, it only recommends it in Xenial, but we need it"},{"line_number":16,"context_line":"installed as it contains required for syslinux *.c32 modules."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a77a97e_6de6eb17","line":14,"in_reply_to":"7a77a97e_6771aa77","updated":"2016-11-21 17:06:03.000000000","message":"Done","commit_id":"fe47135ae73b9559b3608aeb5969aeda088b1fb3"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"e826250e638a708ddd61f0c5efe9e37f1894ae2d","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"More over, while in Trusy \u0027syslinux\u0027 package depends on"},{"line_number":15,"context_line":"\u0027syslinux-common\u0027, it only recommends it in Xenial, but we need it"},{"line_number":16,"context_line":"installed as it contains required for syslinux *.c32 modules."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch adds \u0027syslinux-common\u0027 and \u0027pxelinux\u0027 to required deb packages"},{"line_number":19,"context_line":"list when distro is \u0027xenial\u0027 by using the distro pinning in package lists"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a77a97e_270ed2e5","line":16,"updated":"2016-11-21 13:47:02.000000000","message":"Nit: \"it contains requirements for\" or \"its contents are required for\"","commit_id":"fe47135ae73b9559b3608aeb5969aeda088b1fb3"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"afd616850be91eb22bf16f0939bc31152d389529","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"More over, while in Trusy \u0027syslinux\u0027 package depends on"},{"line_number":15,"context_line":"\u0027syslinux-common\u0027, it only recommends it in Xenial, but we need it"},{"line_number":16,"context_line":"installed as it contains required for syslinux *.c32 modules."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This patch adds \u0027syslinux-common\u0027 and \u0027pxelinux\u0027 to required deb packages"},{"line_number":19,"context_line":"list when distro is \u0027xenial\u0027 by using the distro pinning in package lists"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a77a97e_2ddcf345","line":16,"in_reply_to":"7a77a97e_270ed2e5","updated":"2016-11-21 17:06:03.000000000","message":"better then \"... as it provides *.c32 modules required by syslinux.\"","commit_id":"fe47135ae73b9559b3608aeb5969aeda088b1fb3"}],"devstack/files/debs/ironic":[{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"e826250e638a708ddd61f0c5efe9e37f1894ae2d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# Make sure syslinux-common is installed for those distros as it provides"},{"line_number":8,"context_line":"# *.c32 modules for syslinux"},{"line_number":9,"context_line":"# TODO remove distro pinning when Wheezy / Trusty are EOLed (May 2019)"},{"line_number":10,"context_line":"# or DevStack stops to support those."},{"line_number":11,"context_line":"# In the mean time, new Debian-based release codenames will have to be added"},{"line_number":12,"context_line":"# as distros can not be pinned with \u0027if-later-than\u0027 specified."},{"line_number":13,"context_line":"apparmor"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"7a77a97e_47b82ee6","line":10,"updated":"2016-11-21 13:47:02.000000000","message":"Nit: \"stops supporting\"","commit_id":"fe47135ae73b9559b3608aeb5969aeda088b1fb3"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"afd616850be91eb22bf16f0939bc31152d389529","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# Make sure syslinux-common is installed for those distros as it provides"},{"line_number":8,"context_line":"# *.c32 modules for syslinux"},{"line_number":9,"context_line":"# TODO remove distro pinning when Wheezy / Trusty are EOLed (May 2019)"},{"line_number":10,"context_line":"# or DevStack stops to support those."},{"line_number":11,"context_line":"# In the mean time, new Debian-based release codenames will have to be added"},{"line_number":12,"context_line":"# as distros can not be pinned with \u0027if-later-than\u0027 specified."},{"line_number":13,"context_line":"apparmor"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"7a77a97e_adf003cb","line":10,"in_reply_to":"7a77a97e_47b82ee6","updated":"2016-11-21 17:06:03.000000000","message":"Done","commit_id":"fe47135ae73b9559b3608aeb5969aeda088b1fb3"}],"devstack/lib/ironic":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"41f104a8508af4ceb82e4205302b8a0a16492e01","unresolved":false,"context_lines":[{"line_number":562,"context_line":"        sudo install -d -o $STACK_USER -g $LIBVIRT_GROUP $IRONIC_HTTP_DIR"},{"line_number":563,"context_line":"    fi"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    if [ -z $IRONIC_PXE_BOOT_IMAGE ] || [ ! -f $IRONIC_PXE_BOOT_IMAGE ]; then"},{"line_number":566,"context_line":"        die $LINENO \"PXE boot file $IRONIC_PXE_BOOT_IMAGE not found.\""},{"line_number":567,"context_line":"    fi"},{"line_number":568,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7a77a97e_2af867c4","line":565,"updated":"2016-11-21 08:13:56.000000000","message":"extra check not needed, need just to put variable into quotes:\n\nif [ ! -f \"$IRONIC_PXE_BOOT_IMAGE\" ]; then\n    ...\nfi","commit_id":"ff9daf97b491bd38a1ace8af80f1c5660f7f0d6c"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"b77b76d2396a0ad06c581bdbba6448a4f5bc4cb4","unresolved":false,"context_lines":[{"line_number":562,"context_line":"        sudo install -d -o $STACK_USER -g $LIBVIRT_GROUP $IRONIC_HTTP_DIR"},{"line_number":563,"context_line":"    fi"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    if [ -z $IRONIC_PXE_BOOT_IMAGE ] || [ ! -f $IRONIC_PXE_BOOT_IMAGE ]; then"},{"line_number":566,"context_line":"        die $LINENO \"PXE boot file $IRONIC_PXE_BOOT_IMAGE not found.\""},{"line_number":567,"context_line":"    fi"},{"line_number":568,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7a77a97e_c5028409","line":565,"in_reply_to":"7a77a97e_2af867c4","updated":"2016-11-21 08:36:06.000000000","message":"Done","commit_id":"ff9daf97b491bd38a1ace8af80f1c5660f7f0d6c"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"aaec5a6121dd2c0f7c18b5466eac53f3f1b24531","unresolved":false,"context_lines":[{"line_number":495,"context_line":"    # NOTE(pas-ha) since Ubuntu 15.04 \u0027pxelinux.0\u0027 file is provided by"},{"line_number":496,"context_line":"    # \u0027pxelinux\u0027 package instead of \u0027syslinux-common\u0027"},{"line_number":497,"context_line":"    if is_ubuntu \u0026\u0026 vercmp \"$os_RELEASE\" \"\u003e\u003d\" \"15.04\"; then"},{"line_number":498,"context_line":"        install_package \"pxelinux\""},{"line_number":499,"context_line":"    fi"},{"line_number":500,"context_line":"}"},{"line_number":501,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"7a77a97e_d37c0bee","line":498,"updated":"2016-11-21 11:11:21.000000000","message":"Have you considered using https://github.com/openstack-dev/devstack/blob/5dbb826a547195b3cc33ff4f30f6d79d0ae08045/functions-common#L1164-L1165 instead of this? ditto regarding the syslinux-common package, as it is not required by all supported distros.","commit_id":"bcab4a78938e0e201561351c3377bed74f3d1406"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"a94269823f3cb59fa67170752ac3e2033149bd5a","unresolved":false,"context_lines":[{"line_number":495,"context_line":"    # NOTE(pas-ha) since Ubuntu 15.04 \u0027pxelinux.0\u0027 file is provided by"},{"line_number":496,"context_line":"    # \u0027pxelinux\u0027 package instead of \u0027syslinux-common\u0027"},{"line_number":497,"context_line":"    if is_ubuntu \u0026\u0026 vercmp \"$os_RELEASE\" \"\u003e\u003d\" \"15.04\"; then"},{"line_number":498,"context_line":"        install_package \"pxelinux\""},{"line_number":499,"context_line":"    fi"},{"line_number":500,"context_line":"}"},{"line_number":501,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"7a77a97e_1602f16f","line":498,"in_reply_to":"7a77a97e_d37c0bee","updated":"2016-11-21 11:27:24.000000000","message":"Cool, I was not aware that package lists supported distro version pinning. I\u0027ll try it, but it will pin the version to specific distros that would have to be upgraded later with new releases.","commit_id":"bcab4a78938e0e201561351c3377bed74f3d1406"}]}
