)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7880294bdfe38cf07e37f128f3580d2100c31005","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Co-Authored-By: Aparna \u003caparnavtce@gmail.com\u003e"},{"line_number":15,"context_line":"Co-Authored-By: Shivanand Tendulker \u003cstendulker@gmail.com\u003e"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-On: I7898ff22800dedba73d7fbfb3801378867abe183"},{"line_number":18,"context_line":"Change-Id: I9b4c1278dc5fab7888fbfe586c15e31ed3958978"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":77,"id":"df87a7cf_3e283be0","line":17,"updated":"2017-12-19 22:27:27.000000000","message":"fwiw, this has merged, and can be removed.","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7582118339d8717569b08cc8effe0881a4265658","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Co-Authored-By: Aparna \u003caparnavtce@gmail.com\u003e"},{"line_number":15,"context_line":"Co-Authored-By: Shivanand Tendulker \u003cstendulker@gmail.com\u003e"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Depends-On: I7898ff22800dedba73d7fbfb3801378867abe183"},{"line_number":18,"context_line":"Change-Id: I9b4c1278dc5fab7888fbfe586c15e31ed3958978"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":77,"id":"bf8cb3f7_c0447eba","line":17,"in_reply_to":"df87a7cf_3e283be0","updated":"2017-12-20 14:07:08.000000000","message":"Done","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"}],"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":22931,"name":"Taku Izumi","email":"izumi.taku@jp.fujitsu.com","username":"izumi777"},"change_message_id":"58f27940e8c5930869e96ac7099e7c3eebc8c224","unresolved":false,"context_lines":[{"line_number":2070,"context_line":"# use post-boot (the tenant network). Required for \"flat\" or"},{"line_number":2071,"context_line":"# \"neutron\" network interface  if rescue mode is allowed."},{"line_number":2072,"context_line":"# (string value)"},{"line_number":2073,"context_line":"#rescue_network_uuid \u003d \u003cNone\u003e"},{"line_number":2074,"context_line":""},{"line_number":2075,"context_line":"# Client retries in the case of a failed request. (integer"},{"line_number":2076,"context_line":"# value)"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"1a6eadb0_346c899b","line":2073,"range":{"start_line":2073,"start_character":0,"end_line":2073,"end_character":29},"updated":"2016-12-16 11:07:34.000000000","message":"Not rescue_network_uuid but rescue_network ?","commit_id":"55847c4ca3cd299f03e182085e15248dfa7ccc1c"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"f6f89685da5f92465f6f95427e0ebc838c82df7c","unresolved":false,"context_lines":[{"line_number":2070,"context_line":"# use post-boot (the tenant network). Required for \"flat\" or"},{"line_number":2071,"context_line":"# \"neutron\" network interface  if rescue mode is allowed."},{"line_number":2072,"context_line":"# (string value)"},{"line_number":2073,"context_line":"#rescue_network_uuid \u003d \u003cNone\u003e"},{"line_number":2074,"context_line":""},{"line_number":2075,"context_line":"# Client retries in the case of a failed request. (integer"},{"line_number":2076,"context_line":"# value)"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"ba5201f7_4fd9b421","line":2073,"range":{"start_line":2073,"start_character":0,"end_line":2073,"end_character":29},"in_reply_to":"1a6eadb0_346c899b","updated":"2017-01-11 22:51:50.000000000","message":"Should be fixed now, had to rebase and regenerate config","commit_id":"55847c4ca3cd299f03e182085e15248dfa7ccc1c"}],"ironic/common/neutron.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"127e02427f89ace62c148e3b326d676d86f668d6","unresolved":false,"context_lines":[{"line_number":431,"context_line":"        client \u003d get_client()"},{"line_number":432,"context_line":"        port \u003d client.show_port(port_id).get(\u0027port\u0027, {})"},{"line_number":433,"context_line":"    except neutron_exceptions.NeutronClientException as exc:"},{"line_number":434,"context_line":"        raise exception.NetworkError(\u0027Could not retrieve neutron port: %s\u0027 %"},{"line_number":435,"context_line":"                                     exc)"},{"line_number":436,"context_line":"    return port.get(\u0027network_id\u0027)"},{"line_number":437,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"bff0334d_de96cff0","line":434,"range":{"start_line":434,"start_character":36,"end_line":434,"end_character":74},"updated":"2017-04-11 04:03:53.000000000","message":"Add port id into the message.","commit_id":"5ef3d8407525c9cefac8a1fbcb0173bc3c281d06"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"cb1f5230a97e2a986e0755e9d1bf9ee097989732","unresolved":false,"context_lines":[{"line_number":431,"context_line":"        client \u003d get_client()"},{"line_number":432,"context_line":"        port \u003d client.show_port(port_id).get(\u0027port\u0027, {})"},{"line_number":433,"context_line":"    except neutron_exceptions.NeutronClientException as exc:"},{"line_number":434,"context_line":"        raise exception.NetworkError(\u0027Could not retrieve neutron port: %s\u0027 %"},{"line_number":435,"context_line":"                                     exc)"},{"line_number":436,"context_line":"    return port.get(\u0027network_id\u0027)"},{"line_number":437,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"1f013ff3_f6894f26","line":434,"range":{"start_line":434,"start_character":36,"end_line":434,"end_character":74},"in_reply_to":"7ffa3b31_09fffcaa","updated":"2017-05-15 12:09:40.000000000","message":"Done","commit_id":"5ef3d8407525c9cefac8a1fbcb0173bc3c281d06"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"f696d933c1bf9919bed7d1a8b85df8ad520d0e57","unresolved":false,"context_lines":[{"line_number":431,"context_line":"        client \u003d get_client()"},{"line_number":432,"context_line":"        port \u003d client.show_port(port_id).get(\u0027port\u0027, {})"},{"line_number":433,"context_line":"    except neutron_exceptions.NeutronClientException as exc:"},{"line_number":434,"context_line":"        raise exception.NetworkError(\u0027Could not retrieve neutron port: %s\u0027 %"},{"line_number":435,"context_line":"                                     exc)"},{"line_number":436,"context_line":"    return port.get(\u0027network_id\u0027)"},{"line_number":437,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"7ffa3b31_09fffcaa","line":434,"range":{"start_line":434,"start_character":36,"end_line":434,"end_character":74},"in_reply_to":"bff0334d_de96cff0","updated":"2017-04-14 21:20:08.000000000","message":"+1","commit_id":"5ef3d8407525c9cefac8a1fbcb0173bc3c281d06"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"e131b5ded075751a089e07e1a1bfbd55ee2e3b34","unresolved":false,"context_lines":[{"line_number":414,"context_line":"def get_network_from_port(port_id):"},{"line_number":415,"context_line":"    \"\"\"Given a neutron port ID, return its network ID."},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"       :param port_uuid: port UUID"},{"line_number":418,"context_line":"       :returns: Neutron network UUID the VIF is associated with or None if"},{"line_number":419,"context_line":"                 unassociated."},{"line_number":420,"context_line":"       :raises: NetworkError if communication with neutron failed."}],"source_content_type":"text/x-python","patch_set":44,"id":"ff0f0b1f_89ccd06a","line":417,"range":{"start_line":417,"start_character":19,"end_line":417,"end_character":23},"updated":"2017-05-22 08:08:16.000000000","message":"s/uuid/id/","commit_id":"97a8c1120bf1def69a5f3bd7e66f9d464766a1a9"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"6eac8f78bd7d1f778b5f11d6823f9972d52ddb99","unresolved":false,"context_lines":[{"line_number":414,"context_line":"def get_network_from_port(port_id):"},{"line_number":415,"context_line":"    \"\"\"Given a neutron port ID, return its network ID."},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"       :param port_uuid: port UUID"},{"line_number":418,"context_line":"       :returns: Neutron network UUID the VIF is associated with or None if"},{"line_number":419,"context_line":"                 unassociated."},{"line_number":420,"context_line":"       :raises: NetworkError if communication with neutron failed."}],"source_content_type":"text/x-python","patch_set":44,"id":"df140735_f6aa9d6e","line":417,"range":{"start_line":417,"start_character":19,"end_line":417,"end_character":23},"in_reply_to":"ff0f0b1f_89ccd06a","updated":"2017-06-06 08:44:14.000000000","message":"Done","commit_id":"97a8c1120bf1def69a5f3bd7e66f9d464766a1a9"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"e131b5ded075751a089e07e1a1bfbd55ee2e3b34","unresolved":false,"context_lines":[{"line_number":422,"context_line":"    \"\"\""},{"line_number":423,"context_line":"    try:"},{"line_number":424,"context_line":"        client \u003d get_client()"},{"line_number":425,"context_line":"        port \u003d client.show_port(port_id).get(\u0027port\u0027, {})"},{"line_number":426,"context_line":"    except neutron_exceptions.NeutronClientException as exc:"},{"line_number":427,"context_line":"        raise exception.NetworkError(\u0027Could not retrieve neutron port \u0027"},{"line_number":428,"context_line":"                                     \u0027%(port)s: %(msg)s\u0027 %"}],"source_content_type":"text/x-python","patch_set":44,"id":"ff0f0b1f_e9e0ecce","line":425,"updated":"2017-05-22 08:08:16.000000000","message":"Should we handle the case  explicitly where port is not found in Neutron?\nThough not sure whether that case may occur or not.","commit_id":"97a8c1120bf1def69a5f3bd7e66f9d464766a1a9"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"6eac8f78bd7d1f778b5f11d6823f9972d52ddb99","unresolved":false,"context_lines":[{"line_number":422,"context_line":"    \"\"\""},{"line_number":423,"context_line":"    try:"},{"line_number":424,"context_line":"        client \u003d get_client()"},{"line_number":425,"context_line":"        port \u003d client.show_port(port_id).get(\u0027port\u0027, {})"},{"line_number":426,"context_line":"    except neutron_exceptions.NeutronClientException as exc:"},{"line_number":427,"context_line":"        raise exception.NetworkError(\u0027Could not retrieve neutron port \u0027"},{"line_number":428,"context_line":"                                     \u0027%(port)s: %(msg)s\u0027 %"}],"source_content_type":"text/x-python","patch_set":44,"id":"df140735_c5c0f9e3","line":425,"in_reply_to":"ff0f0b1f_e9e0ecce","updated":"2017-06-06 08:44:14.000000000","message":"Port not found in neutron exception is also handled as NeutronClientException.","commit_id":"97a8c1120bf1def69a5f3bd7e66f9d464766a1a9"}],"ironic/common/pxe_utils.py":[{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"7b5ac3178397fe62a2b93d283a065efe6bf90a26","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    )"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"def get_kr_info(node_uuid, driver_info, rescue\u003dFalse):"},{"line_number":144,"context_line":"    \"\"\"Get href and tftp path for deploy or rescue kernel and ramdisk."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    :param uuid: UUID of the node"}],"source_content_type":"text/x-python","patch_set":24,"id":"9a30ddce_5d62493f","line":143,"range":{"start_line":143,"start_character":4,"end_line":143,"end_character":15},"updated":"2017-03-09 19:44:51.000000000","message":"/s/get_kr_info/get_kernelrescue_info as it\u0027s not clear what it stands for","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"9c300868cdbbcceb3913129f87b47d20f7ab8671","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    )"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"def get_kr_info(node_uuid, driver_info, rescue\u003dFalse):"},{"line_number":144,"context_line":"    \"\"\"Get href and tftp path for deploy or rescue kernel and ramdisk."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    :param uuid: UUID of the node"}],"source_content_type":"text/x-python","patch_set":24,"id":"1a1ced50_1046977a","line":143,"range":{"start_line":143,"start_character":4,"end_line":143,"end_character":15},"in_reply_to":"9a30ddce_5d62493f","updated":"2017-03-23 17:23:15.000000000","message":"This can be used either during a deploy or rescue, so I don\u0027t think get_kernelrescue_info is accurate.\n\nHow about \"get_kernel_ramdisk_info\"? I\u0027ll also update the docstring to make the return value clearer.","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"8a2c5a42639dccb12e30ac995086e598eb915cd8","unresolved":false,"context_lines":[{"line_number":143,"context_line":"def get_kr_info(node_uuid, driver_info, rescue\u003dFalse):"},{"line_number":144,"context_line":"    \"\"\"Get href and tftp path for deploy or rescue kernel and ramdisk."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    :param uuid: UUID of the node"},{"line_number":147,"context_line":"    :param driver_info: Node\u0027s driver_info dict"},{"line_number":148,"context_line":"    :param rescue: Whether the paths for rescue ramdisk are being requested or"},{"line_number":149,"context_line":"                   not. Defaults to False, indicating deploy paths will be"}],"source_content_type":"text/x-python","patch_set":24,"id":"9a30ddce_ba45b443","line":146,"range":{"start_line":146,"start_character":11,"end_line":146,"end_character":16},"updated":"2017-03-13 10:45:28.000000000","message":"name doesn\u0027t match with the parameter in function definition. s/uuid/node_uuid","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"9c300868cdbbcceb3913129f87b47d20f7ab8671","unresolved":false,"context_lines":[{"line_number":143,"context_line":"def get_kr_info(node_uuid, driver_info, rescue\u003dFalse):"},{"line_number":144,"context_line":"    \"\"\"Get href and tftp path for deploy or rescue kernel and ramdisk."},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    :param uuid: UUID of the node"},{"line_number":147,"context_line":"    :param driver_info: Node\u0027s driver_info dict"},{"line_number":148,"context_line":"    :param rescue: Whether the paths for rescue ramdisk are being requested or"},{"line_number":149,"context_line":"                   not. Defaults to False, indicating deploy paths will be"}],"source_content_type":"text/x-python","patch_set":24,"id":"1a1ced50_f039fbf2","line":146,"range":{"start_line":146,"start_character":11,"end_line":146,"end_character":16},"in_reply_to":"9a30ddce_ba45b443","updated":"2017-03-23 17:23:15.000000000","message":"Done","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"e131b5ded075751a089e07e1a1bfbd55ee2e3b34","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    \"\"\""},{"line_number":157,"context_line":"    root_dir \u003d get_root_dir()"},{"line_number":158,"context_line":"    image_info \u003d {}"},{"line_number":159,"context_line":"    kernel_key \u003d \u0027rescue_kernel\u0027 if rescue else \u0027deploy_kernel\u0027"},{"line_number":160,"context_line":"    ramdisk_key \u003d \u0027rescue_ramdisk\u0027 if rescue else \u0027deploy_ramdisk\u0027"},{"line_number":161,"context_line":"    for label in (kernel_key, ramdisk_key):"},{"line_number":162,"context_line":"        image_info[label] \u003d ("},{"line_number":163,"context_line":"            str(driver_info[label]),"}],"source_content_type":"text/x-python","patch_set":44,"id":"ff0f0b1f_69ff3c34","line":160,"range":{"start_line":159,"start_character":4,"end_line":160,"end_character":66},"updated":"2017-05-22 08:08:16.000000000","message":"Better to merge these two statement like:\n\n  labels \u003d (\u0027rescue_kernel\u0027, \u0027rescue_ramdisk\u0027) if rescue else (\u0027deploy_kernel\u0027, \u0027deploy_ramdisk\u0027)","commit_id":"97a8c1120bf1def69a5f3bd7e66f9d464766a1a9"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"aa216d9faff066f6d221cff22fc5c3491949e165","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    \"\"\""},{"line_number":157,"context_line":"    root_dir \u003d get_root_dir()"},{"line_number":158,"context_line":"    image_info \u003d {}"},{"line_number":159,"context_line":"    kernel_key \u003d \u0027rescue_kernel\u0027 if rescue else \u0027deploy_kernel\u0027"},{"line_number":160,"context_line":"    ramdisk_key \u003d \u0027rescue_ramdisk\u0027 if rescue else \u0027deploy_ramdisk\u0027"},{"line_number":161,"context_line":"    for label in (kernel_key, ramdisk_key):"},{"line_number":162,"context_line":"        image_info[label] \u003d ("},{"line_number":163,"context_line":"            str(driver_info[label]),"}],"source_content_type":"text/x-python","patch_set":44,"id":"ff0f0b1f_42625bda","line":160,"range":{"start_line":159,"start_character":4,"end_line":160,"end_character":66},"in_reply_to":"ff0f0b1f_69ff3c34","updated":"2017-05-26 23:13:51.000000000","message":"+1","commit_id":"97a8c1120bf1def69a5f3bd7e66f9d464766a1a9"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"6eac8f78bd7d1f778b5f11d6823f9972d52ddb99","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    \"\"\""},{"line_number":157,"context_line":"    root_dir \u003d get_root_dir()"},{"line_number":158,"context_line":"    image_info \u003d {}"},{"line_number":159,"context_line":"    kernel_key \u003d \u0027rescue_kernel\u0027 if rescue else \u0027deploy_kernel\u0027"},{"line_number":160,"context_line":"    ramdisk_key \u003d \u0027rescue_ramdisk\u0027 if rescue else \u0027deploy_ramdisk\u0027"},{"line_number":161,"context_line":"    for label in (kernel_key, ramdisk_key):"},{"line_number":162,"context_line":"        image_info[label] \u003d ("},{"line_number":163,"context_line":"            str(driver_info[label]),"}],"source_content_type":"text/x-python","patch_set":44,"id":"df140735_d91a2ac4","line":160,"range":{"start_line":159,"start_character":4,"end_line":160,"end_character":66},"in_reply_to":"ff0f0b1f_69ff3c34","updated":"2017-06-06 08:44:14.000000000","message":"Done","commit_id":"97a8c1120bf1def69a5f3bd7e66f9d464766a1a9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6480163bc034276ee9b0ce674c90994fce9ace3e","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    root_dir \u003d get_root_dir()"},{"line_number":176,"context_line":"    image_info \u003d {}"},{"line_number":177,"context_line":"    labels \u003d ((\u0027rescue_kernel\u0027, \u0027rescue_ramdisk\u0027) if rescue else"},{"line_number":178,"context_line":"              (\u0027deploy_kernel\u0027, \u0027deploy_ramdisk\u0027))"},{"line_number":179,"context_line":"    for label in labels:"},{"line_number":180,"context_line":"        image_info[label] \u003d ("},{"line_number":181,"context_line":"            str(driver_info[label]),"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff82abbf_3ebfbbaa","line":178,"updated":"2017-11-28 21:56:09.000000000","message":"it seems to me that this is repeated in diff places; i guess it can be cleaned up later...","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"075da2894b98641ebc44f6508c7f9f4bff729cfb","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    root_dir \u003d get_root_dir()"},{"line_number":176,"context_line":"    image_info \u003d {}"},{"line_number":177,"context_line":"    labels \u003d ((\u0027rescue_kernel\u0027, \u0027rescue_ramdisk\u0027) if rescue else"},{"line_number":178,"context_line":"              (\u0027deploy_kernel\u0027, \u0027deploy_ramdisk\u0027))"},{"line_number":179,"context_line":"    for label in labels:"},{"line_number":180,"context_line":"        image_info[label] \u003d ("},{"line_number":181,"context_line":"            str(driver_info[label]),"}],"source_content_type":"text/x-python","patch_set":69,"id":"df87a7cf_de476bbc","line":178,"in_reply_to":"ff82abbf_3ebfbbaa","updated":"2017-12-03 16:40:27.000000000","message":"Done","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c7ca39ec5bdbb13f0642747215ecef08aa5bbc58","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    )"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"def get_kernel_ramdisk_info(node_uuid, driver_info, is_rescue\u003dFalse):"},{"line_number":164,"context_line":"    \"\"\"Get href and tftp path for deploy or rescue kernel and ramdisk."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    :param node_uuid: UUID of the node"}],"source_content_type":"text/x-python","patch_set":77,"id":"bf8cb3f7_f172a711","line":163,"updated":"2017-12-20 22:53:26.000000000","message":"this is probably a nit, but it seems to me that the default would be for deploy, not rescue, and is_deploy\u003dTrue is a better default (in my mind) than is_rescue\u003dFalse.\n\nMaybe not worth it, but if this was the \u0027mode\u0027 (a string \u0027deploy\u0027 or \u0027rescue\u0027), you could have a static dictionary that is keyed on the mode, to get the labels.","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3dec19f491aa2f384bbd9d40e31ab6766d682f7c","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    )"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"def get_kernel_ramdisk_info(node_uuid, driver_info, is_rescue\u003dFalse):"},{"line_number":164,"context_line":"    \"\"\"Get href and tftp path for deploy or rescue kernel and ramdisk."},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    :param node_uuid: UUID of the node"}],"source_content_type":"text/x-python","patch_set":77,"id":"9f91af0f_c27d2e1d","line":163,"in_reply_to":"bf8cb3f7_f172a711","updated":"2018-01-04 11:21:02.000000000","message":"Done","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5c6624dbf3a1813c7379ed74cd29bef2822b82a7","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    :returns: a dictionary whose keys are deploy_kernel and deploy_ramdisk or"},{"line_number":172,"context_line":"        rescue_kernel and rescue_ramdisk and whose values are the absolute"},{"line_number":173,"context_line":"        paths to them."},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    Note: driver_info should be validated outside of this method."},{"line_number":176,"context_line":"    \"\"\""},{"line_number":177,"context_line":"    root_dir \u003d get_root_dir()"}],"source_content_type":"text/x-python","patch_set":77,"id":"df87a7cf_7efc8371","line":174,"updated":"2017-12-19 22:24:29.000000000","message":"Thanks for the docstring!","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"}],"ironic/common/states.py":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"8e4b4f9d1ba6afdbbc65516e30d124a291a973d4","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"RESCUE_LIKE_STATES \u003d (RESCUING, RESCUEWAIT, RESCUEFAIL, UNRESCUING,"},{"line_number":228,"context_line":"                      UNRESCUEFAIL)"},{"line_number":229,"context_line":"\"\"\"States related to rescue mode.\"\"\""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"##############"},{"line_number":232,"context_line":"# Power states"}],"source_content_type":"text/x-python","patch_set":80,"id":"7f96bb07_9391c755","line":229,"updated":"2018-01-12 03:19:48.000000000","message":"This looks a little confusing because this doesn\u0027t contain RESCUE and UNRESCUE and there are similar groupings[1]. I prefer defining this tuple in ironic/drivers/modules/pxe.py locally.\n\n[1] https://review.openstack.org/#/c/400437/80/ironic/drivers/modules/agent.py@475","commit_id":"1d74d6dd34160d400edc2482b680d0520a598422"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"59e7f43c813937c8055a5464baff3d406e5bfd3d","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"RESCUE_LIKE_STATES \u003d (RESCUING, RESCUEWAIT, RESCUEFAIL, UNRESCUING,"},{"line_number":228,"context_line":"                      UNRESCUEFAIL)"},{"line_number":229,"context_line":"\"\"\"States related to rescue mode.\"\"\""},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"##############"},{"line_number":232,"context_line":"# Power states"}],"source_content_type":"text/x-python","patch_set":80,"id":"7f96bb07_160fe2e1","line":229,"in_reply_to":"7f96bb07_9391c755","updated":"2018-01-12 13:13:37.000000000","message":"Done","commit_id":"1d74d6dd34160d400edc2482b680d0520a598422"}],"ironic/conductor/utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c7ca39ec5bdbb13f0642747215ecef08aa5bbc58","unresolved":false,"context_lines":[{"line_number":717,"context_line":"        node.save()"},{"line_number":718,"context_line":""},{"line_number":719,"context_line":""},{"line_number":720,"context_line":"def rescuing_error_handler(task, msg):"},{"line_number":721,"context_line":"    \"\"\"Put a failed node in RESCUEFAIL.\"\"\""},{"line_number":722,"context_line":"    node \u003d task.node"},{"line_number":723,"context_line":"    node.last_error \u003d msg"}],"source_content_type":"text/x-python","patch_set":77,"id":"bf8cb3f7_1bdc0c73","line":720,"updated":"2017-12-20 22:53:26.000000000","message":"I was wondering how much of the stuff done in cleanup_rescuewait_timeout() is/should be done here, and if there is enough in common, maybe a helper function to handle the common parts.","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3dec19f491aa2f384bbd9d40e31ab6766d682f7c","unresolved":false,"context_lines":[{"line_number":717,"context_line":"        node.save()"},{"line_number":718,"context_line":""},{"line_number":719,"context_line":""},{"line_number":720,"context_line":"def rescuing_error_handler(task, msg):"},{"line_number":721,"context_line":"    \"\"\"Put a failed node in RESCUEFAIL.\"\"\""},{"line_number":722,"context_line":"    node \u003d task.node"},{"line_number":723,"context_line":"    node.last_error \u003d msg"}],"source_content_type":"text/x-python","patch_set":77,"id":"9f91af0f_980217b4","line":720,"in_reply_to":"bf8cb3f7_1bdc0c73","updated":"2018-01-04 11:21:02.000000000","message":"Done","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c7ca39ec5bdbb13f0642747215ecef08aa5bbc58","unresolved":false,"context_lines":[{"line_number":723,"context_line":"    node.last_error \u003d msg"},{"line_number":724,"context_line":"    node.save()"},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"    task.driver.rescue.clean_up(task)"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"    try:"},{"line_number":729,"context_line":"        task.process_event(\u0027fail\u0027)"}],"source_content_type":"text/x-python","patch_set":77,"id":"bf8cb3f7_fbecc8f4","line":726,"updated":"2017-12-20 22:53:26.000000000","message":"I think if this fails, we still want to do L729","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3dec19f491aa2f384bbd9d40e31ab6766d682f7c","unresolved":false,"context_lines":[{"line_number":723,"context_line":"    node.last_error \u003d msg"},{"line_number":724,"context_line":"    node.save()"},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"    task.driver.rescue.clean_up(task)"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"    try:"},{"line_number":729,"context_line":"        task.process_event(\u0027fail\u0027)"}],"source_content_type":"text/x-python","patch_set":77,"id":"9f91af0f_5dd32139","line":726,"in_reply_to":"bf8cb3f7_fbecc8f4","updated":"2018-01-04 11:21:02.000000000","message":"Done","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"8e4b4f9d1ba6afdbbc65516e30d124a291a973d4","unresolved":false,"context_lines":[{"line_number":439,"context_line":"            msg \u003d (\u0027Internal error. Node %(node)s in provision state \u0027"},{"line_number":440,"context_line":"                   \u0027\"%(state)s\" could not transition to a failed state.\u0027"},{"line_number":441,"context_line":"                   % {\u0027node\u0027: node.uuid, \u0027state\u0027: node.provision_state})"},{"line_number":442,"context_line":"            LOG.exception(msg)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"@task_manager.require_exclusive_lock"}],"source_content_type":"text/x-python","patch_set":80,"id":"7f96bb07_18a636c3","line":442,"updated":"2018-01-12 03:19:48.000000000","message":"LOG.error() is enough here.","commit_id":"1d74d6dd34160d400edc2482b680d0520a598422"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"59e7f43c813937c8055a5464baff3d406e5bfd3d","unresolved":false,"context_lines":[{"line_number":439,"context_line":"            msg \u003d (\u0027Internal error. Node %(node)s in provision state \u0027"},{"line_number":440,"context_line":"                   \u0027\"%(state)s\" could not transition to a failed state.\u0027"},{"line_number":441,"context_line":"                   % {\u0027node\u0027: node.uuid, \u0027state\u0027: node.provision_state})"},{"line_number":442,"context_line":"            LOG.exception(msg)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"@task_manager.require_exclusive_lock"}],"source_content_type":"text/x-python","patch_set":80,"id":"7f96bb07_d6217a4f","line":442,"in_reply_to":"7f96bb07_18a636c3","updated":"2018-01-12 13:13:37.000000000","message":"Done","commit_id":"1d74d6dd34160d400edc2482b680d0520a598422"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"bdd640a5bff37db3066afb5533956dc00ee9b9ed","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                           would be transitioned to a failed state."},{"line_number":409,"context_line":"    \"\"\""},{"line_number":410,"context_line":"    node \u003d task.node"},{"line_number":411,"context_line":"    errmsg \u003d msg + \u0027 %(node)s\u0027"},{"line_number":412,"context_line":"    LOG.error(errmsg, {\u0027node\u0027: node.uuid})"},{"line_number":413,"context_line":"    try:"},{"line_number":414,"context_line":"        node_power_action(task, states.POWER_OFF)"}],"source_content_type":"text/x-python","patch_set":85,"id":"7f96bb07_4e10cd57","line":411,"updated":"2018-01-18 06:33:03.000000000","message":"A message for IPA error[1] doesn\u0027t seem suitable for adding this parameter.\n\n[1] https://review.openstack.org/#/c/400437/85/ironic/drivers/modules/agent_base_vendor.py@350","commit_id":"142a29c21be377bd007bf6487970a1de77ee90a0"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"05825b3305665de135f0e76b649ad53b07751d4e","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                           would be transitioned to a failed state."},{"line_number":409,"context_line":"    \"\"\""},{"line_number":410,"context_line":"    node \u003d task.node"},{"line_number":411,"context_line":"    errmsg \u003d msg + \u0027 %(node)s\u0027"},{"line_number":412,"context_line":"    LOG.error(errmsg, {\u0027node\u0027: node.uuid})"},{"line_number":413,"context_line":"    try:"},{"line_number":414,"context_line":"        node_power_action(task, states.POWER_OFF)"}],"source_content_type":"text/x-python","patch_set":85,"id":"7f96bb07_54a36d00","line":411,"in_reply_to":"7f96bb07_4e10cd57","updated":"2018-01-19 09:21:46.000000000","message":"Done","commit_id":"142a29c21be377bd007bf6487970a1de77ee90a0"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"bdd640a5bff37db3066afb5533956dc00ee9b9ed","unresolved":false,"context_lines":[{"line_number":418,"context_line":"    except Exception as e:"},{"line_number":419,"context_line":"        if isinstance(e, exception.IronicException):"},{"line_number":420,"context_line":"            error_msg \u003d _(\u0027Cleanup failed for %(node_info)s after rescue \u0027"},{"line_number":421,"context_line":"                          \u0027timeout: %(error)s\u0027)"},{"line_number":422,"context_line":"            node_info \u003d (\u0027node\u0027)"},{"line_number":423,"context_line":"            node.last_error \u003d error_msg % {\u0027node_info\u0027: node_info, \u0027error\u0027: e}"},{"line_number":424,"context_line":"            node_info \u003d (\u0027node %s\u0027) % node.uuid"}],"source_content_type":"text/x-python","patch_set":85,"id":"7f96bb07_4915273f","line":421,"range":{"start_line":421,"start_character":27,"end_line":421,"end_character":34},"updated":"2018-01-18 06:33:03.000000000","message":"nit: This method is not only for rescue timeout.","commit_id":"142a29c21be377bd007bf6487970a1de77ee90a0"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"05825b3305665de135f0e76b649ad53b07751d4e","unresolved":false,"context_lines":[{"line_number":418,"context_line":"    except Exception as e:"},{"line_number":419,"context_line":"        if isinstance(e, exception.IronicException):"},{"line_number":420,"context_line":"            error_msg \u003d _(\u0027Cleanup failed for %(node_info)s after rescue \u0027"},{"line_number":421,"context_line":"                          \u0027timeout: %(error)s\u0027)"},{"line_number":422,"context_line":"            node_info \u003d (\u0027node\u0027)"},{"line_number":423,"context_line":"            node.last_error \u003d error_msg % {\u0027node_info\u0027: node_info, \u0027error\u0027: e}"},{"line_number":424,"context_line":"            node_info \u003d (\u0027node %s\u0027) % node.uuid"}],"source_content_type":"text/x-python","patch_set":85,"id":"7f96bb07_f152cb34","line":421,"range":{"start_line":421,"start_character":27,"end_line":421,"end_character":34},"in_reply_to":"7f96bb07_4915273f","updated":"2018-01-19 09:21:46.000000000","message":"Done","commit_id":"142a29c21be377bd007bf6487970a1de77ee90a0"}],"ironic/conf/neutron.py":[{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"bb745c52187f1226501112cd76d557eabf489846","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                       \u0027If not specified, default security group \u0027"},{"line_number":77,"context_line":"                       \u0027is used.\u0027)),"},{"line_number":78,"context_line":"    cfg.StrOpt(\u0027rescue_network\u0027,"},{"line_number":79,"context_line":"               help\u003d_(\u0027Neutron network UUID or name for booting the ramdisk \u0027"},{"line_number":80,"context_line":"                      \u0027for rescue mode. This is not the network that the \u0027"},{"line_number":81,"context_line":"                      \u0027rescue ramdisk will use post-boot (the tenant network).\u0027"},{"line_number":82,"context_line":"                      \u0027 Required for \"flat\" or \"neutron\" network interface\u0027"}],"source_content_type":"text/x-python","patch_set":24,"id":"3a1ff146_81006dac","line":79,"range":{"start_line":79,"start_character":39,"end_line":79,"end_character":51},"updated":"2017-03-14 18:09:13.000000000","message":"s/UUID or name/name or UUID/","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"9c300868cdbbcceb3913129f87b47d20f7ab8671","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                       \u0027If not specified, default security group \u0027"},{"line_number":77,"context_line":"                       \u0027is used.\u0027)),"},{"line_number":78,"context_line":"    cfg.StrOpt(\u0027rescue_network\u0027,"},{"line_number":79,"context_line":"               help\u003d_(\u0027Neutron network UUID or name for booting the ramdisk \u0027"},{"line_number":80,"context_line":"                      \u0027for rescue mode. This is not the network that the \u0027"},{"line_number":81,"context_line":"                      \u0027rescue ramdisk will use post-boot (the tenant network).\u0027"},{"line_number":82,"context_line":"                      \u0027 Required for \"flat\" or \"neutron\" network interface\u0027"}],"source_content_type":"text/x-python","patch_set":24,"id":"1a1ced50_935c511a","line":79,"range":{"start_line":79,"start_character":39,"end_line":79,"end_character":51},"in_reply_to":"3a1ff146_81006dac","updated":"2017-03-23 17:23:15.000000000","message":"Why?","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"abd1621ea37a8edb8200c71f0629d285e7bd435e","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                       \u0027is used.\u0027)),"},{"line_number":78,"context_line":"    cfg.StrOpt(\u0027rescue_network\u0027,"},{"line_number":79,"context_line":"               help\u003d_(\u0027Neutron network UUID or name for booting the ramdisk \u0027"},{"line_number":80,"context_line":"                      \u0027for rescue mode. This is not the network that the \u0027"},{"line_number":81,"context_line":"                      \u0027rescue ramdisk will use post-boot (the tenant network).\u0027"},{"line_number":82,"context_line":"                      \u0027 Required for \"flat\" or \"neutron\" network interface\u0027"},{"line_number":83,"context_line":"                      \u0027 if rescue mode will be used. If a name is\u0027"},{"line_number":84,"context_line":"                      \u0027 provided, it must be unique among all networks or\u0027"}],"source_content_type":"text/x-python","patch_set":24,"id":"9a30ddce_bffef435","line":81,"range":{"start_line":80,"start_character":40,"end_line":81,"end_character":77},"updated":"2017-03-09 10:49:26.000000000","message":"This sentence looks confusing...","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0d3bbf64848681dffa77a8a8e106cfa7929beffc","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                       \u0027is used.\u0027)),"},{"line_number":78,"context_line":"    cfg.StrOpt(\u0027rescue_network\u0027,"},{"line_number":79,"context_line":"               help\u003d_(\u0027Neutron network UUID or name for booting the ramdisk \u0027"},{"line_number":80,"context_line":"                      \u0027for rescue mode. This is not the network that the \u0027"},{"line_number":81,"context_line":"                      \u0027rescue ramdisk will use post-boot (the tenant network).\u0027"},{"line_number":82,"context_line":"                      \u0027 Required for \"flat\" or \"neutron\" network interface\u0027"},{"line_number":83,"context_line":"                      \u0027 if rescue mode will be used. If a name is\u0027"},{"line_number":84,"context_line":"                      \u0027 provided, it must be unique among all networks or\u0027"}],"source_content_type":"text/x-python","patch_set":24,"id":"ffe62b97_0c20a29a","line":81,"range":{"start_line":80,"start_character":40,"end_line":81,"end_character":77},"in_reply_to":"1a1ced50_1384e108","updated":"2017-09-27 16:31:32.000000000","message":"Upon re-reading, it looks fine to me:)","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"9c300868cdbbcceb3913129f87b47d20f7ab8671","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                       \u0027is used.\u0027)),"},{"line_number":78,"context_line":"    cfg.StrOpt(\u0027rescue_network\u0027,"},{"line_number":79,"context_line":"               help\u003d_(\u0027Neutron network UUID or name for booting the ramdisk \u0027"},{"line_number":80,"context_line":"                      \u0027for rescue mode. This is not the network that the \u0027"},{"line_number":81,"context_line":"                      \u0027rescue ramdisk will use post-boot (the tenant network).\u0027"},{"line_number":82,"context_line":"                      \u0027 Required for \"flat\" or \"neutron\" network interface\u0027"},{"line_number":83,"context_line":"                      \u0027 if rescue mode will be used. If a name is\u0027"},{"line_number":84,"context_line":"                      \u0027 provided, it must be unique among all networks or\u0027"}],"source_content_type":"text/x-python","patch_set":24,"id":"1a1ced50_1384e108","line":81,"range":{"start_line":80,"start_character":40,"end_line":81,"end_character":77},"in_reply_to":"3a1ff146_611a9119","updated":"2017-03-23 17:23:15.000000000","message":"What specifically is confusing about it?\n\nIs something like this clearer?\n\n\"This is not necessarily the network used to access rescued nodes following the rescue process; that is the tenant network.\"\n\nOr, I could remove it entirely, if that\u0027s clear already. I basically don\u0027t want deployers to mistake the rescue network for the network used to access the node after rescue is finalized.","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"bb745c52187f1226501112cd76d557eabf489846","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                       \u0027is used.\u0027)),"},{"line_number":78,"context_line":"    cfg.StrOpt(\u0027rescue_network\u0027,"},{"line_number":79,"context_line":"               help\u003d_(\u0027Neutron network UUID or name for booting the ramdisk \u0027"},{"line_number":80,"context_line":"                      \u0027for rescue mode. This is not the network that the \u0027"},{"line_number":81,"context_line":"                      \u0027rescue ramdisk will use post-boot (the tenant network).\u0027"},{"line_number":82,"context_line":"                      \u0027 Required for \"flat\" or \"neutron\" network interface\u0027"},{"line_number":83,"context_line":"                      \u0027 if rescue mode will be used. If a name is\u0027"},{"line_number":84,"context_line":"                      \u0027 provided, it must be unique among all networks or\u0027"}],"source_content_type":"text/x-python","patch_set":24,"id":"3a1ff146_611a9119","line":81,"range":{"start_line":80,"start_character":40,"end_line":81,"end_character":77},"in_reply_to":"9a30ddce_bffef435","updated":"2017-03-14 18:09:13.000000000","message":"++","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"7b5ac3178397fe62a2b93d283a065efe6bf90a26","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    cfg.StrOpt(\u0027rescue_network_security_groups\u0027,"},{"line_number":87,"context_line":"               default\u003d[],"},{"line_number":88,"context_line":"               help\u003d_(\u0027List of Neutron Security Group UUIDs to be \u0027"},{"line_number":89,"context_line":"                      \u0027applied during rescuing of the nodes. \u0027"},{"line_number":90,"context_line":"                      \u0027Optional for the \"neutron\" network interface and not \u0027"},{"line_number":91,"context_line":"                      \u0027used for the \"flat\" or \"noop\" network interfaces. \u0027"},{"line_number":92,"context_line":"                      \u0027If not specified, default security group \u0027"}],"source_content_type":"text/x-python","patch_set":24,"id":"9a30ddce_584fb76a","line":89,"range":{"start_line":89,"start_character":31,"end_line":89,"end_character":49},"updated":"2017-03-09 19:44:51.000000000","message":"s/during rescuing of/during the rescue process","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"9c300868cdbbcceb3913129f87b47d20f7ab8671","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    cfg.StrOpt(\u0027rescue_network_security_groups\u0027,"},{"line_number":87,"context_line":"               default\u003d[],"},{"line_number":88,"context_line":"               help\u003d_(\u0027List of Neutron Security Group UUIDs to be \u0027"},{"line_number":89,"context_line":"                      \u0027applied during rescuing of the nodes. \u0027"},{"line_number":90,"context_line":"                      \u0027Optional for the \"neutron\" network interface and not \u0027"},{"line_number":91,"context_line":"                      \u0027used for the \"flat\" or \"noop\" network interfaces. \u0027"},{"line_number":92,"context_line":"                      \u0027If not specified, default security group \u0027"}],"source_content_type":"text/x-python","patch_set":24,"id":"1a1ced50_53f6598f","line":89,"range":{"start_line":89,"start_character":31,"end_line":89,"end_character":49},"in_reply_to":"9a30ddce_584fb76a","updated":"2017-03-23 17:23:15.000000000","message":"Done","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"783c52b8e872f3f0461cc6862203ce517a1d51da","unresolved":false,"context_lines":[{"line_number":79,"context_line":"               help\u003d_(\u0027Neutron network UUID or name for booting the ramdisk \u0027"},{"line_number":80,"context_line":"                      \u0027for rescue mode. This is not the network that the \u0027"},{"line_number":81,"context_line":"                      \u0027rescue ramdisk will use post-boot (the tenant network).\u0027"},{"line_number":82,"context_line":"                      \u0027 Required for \"flat\" or \"neutron\" network interface\u0027"},{"line_number":83,"context_line":"                      \u0027 if rescue mode will be used. If a name is\u0027"},{"line_number":84,"context_line":"                      \u0027 provided, it must be unique among all networks or\u0027"},{"line_number":85,"context_line":"                      \u0027 rescue will fail.\u0027)),"}],"source_content_type":"text/x-python","patch_set":47,"id":"7f231b9d_df8b6265","line":82,"range":{"start_line":82,"start_character":23,"end_line":82,"end_character":24},"updated":"2017-06-16 01:04:04.000000000","message":"please put this space on previous line","commit_id":"88194bea53bbc6df4a304a1d3c9540094a121e98"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"5e473bc966e5448075f0bea2a54e6433a925a763","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                      \u0027applied during the node rescue process. \u0027"},{"line_number":90,"context_line":"                      \u0027Optional for the \"neutron\" network interface and not \u0027"},{"line_number":91,"context_line":"                      \u0027used for the \"flat\" or \"noop\" network interfaces. \u0027"},{"line_number":92,"context_line":"                      \u0027If not specified, default security group \u0027"},{"line_number":93,"context_line":"                      \u0027is used.\u0027)),"},{"line_number":94,"context_line":"]"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":55,"id":"5f2577a7_a821f4b6","line":92,"range":{"start_line":92,"start_character":41,"end_line":92,"end_character":63},"updated":"2017-09-12 08:11:13.000000000","message":"Which default security group is this? Is this the Neutron `default` named security group? There can exist multiple secgroups with name default.","commit_id":"d983b5033a30862b85e6b5d279030d7685f1c0ad"}],"ironic/drivers/base.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d9651c1752df759a48be9927edf3cc660b1a682b","unresolved":false,"context_lines":[{"line_number":418,"context_line":"    interface_type \u003d \u0027boot\u0027"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"    @abc.abstractmethod"},{"line_number":421,"context_line":"    def prepare_ramdisk(self, task, ramdisk_params, rescue\u003dFalse):"},{"line_number":422,"context_line":"        \"\"\"Prepares the boot of Ironic ramdisk."},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        This method prepares the boot of the deploy or rescue ramdisk after"}],"source_content_type":"text/x-python","patch_set":32,"id":"dfeb2761_cfe772e4","line":421,"range":{"start_line":421,"start_character":4,"end_line":421,"end_character":65},"updated":"2017-04-04 09:05:03.000000000","message":"This looks like an incompatible change in the base class method.\nAll the drivers that needs to implement rescue interface needs to change their boot interface methods as well.\nNeed to change the signature of all the in-tree drivers to accommodate this change.\nCould this have impact on out-of-tree drivers implementing boot interface?","commit_id":"5f7ab1fc99a21530aa40ffac3c61fbab68686b3f"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"227719ec8def4b709cf0780721325751993c90fb","unresolved":false,"context_lines":[{"line_number":418,"context_line":"    interface_type \u003d \u0027boot\u0027"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"    @abc.abstractmethod"},{"line_number":421,"context_line":"    def prepare_ramdisk(self, task, ramdisk_params, rescue\u003dFalse):"},{"line_number":422,"context_line":"        \"\"\"Prepares the boot of Ironic ramdisk."},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        This method prepares the boot of the deploy or rescue ramdisk after"}],"source_content_type":"text/x-python","patch_set":32,"id":"bff0334d_9ad7a4c0","line":421,"range":{"start_line":421,"start_character":4,"end_line":421,"end_character":65},"in_reply_to":"dfeb2761_5b1d640d","updated":"2017-04-10 16:15:17.000000000","message":"OK, I\u0027ll switch to checking node provision_state in the PXE driver implementation, instead.","commit_id":"5f7ab1fc99a21530aa40ffac3c61fbab68686b3f"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"3598f5351bf96abce41bf1c66918ccf04db52fd0","unresolved":false,"context_lines":[{"line_number":418,"context_line":"    interface_type \u003d \u0027boot\u0027"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"    @abc.abstractmethod"},{"line_number":421,"context_line":"    def prepare_ramdisk(self, task, ramdisk_params, rescue\u003dFalse):"},{"line_number":422,"context_line":"        \"\"\"Prepares the boot of Ironic ramdisk."},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        This method prepares the boot of the deploy or rescue ramdisk after"}],"source_content_type":"text/x-python","patch_set":32,"id":"dfeb2761_5b1d640d","line":421,"range":{"start_line":421,"start_character":4,"end_line":421,"end_character":65},"in_reply_to":"dfeb2761_cfe772e4","updated":"2017-04-04 11:39:10.000000000","message":"+1 this is not mentioned in spec \"Driver API impact\".","commit_id":"5f7ab1fc99a21530aa40ffac3c61fbab68686b3f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d9651c1752df759a48be9927edf3cc660b1a682b","unresolved":false,"context_lines":[{"line_number":441,"context_line":"        \"\"\""},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"    @abc.abstractmethod"},{"line_number":444,"context_line":"    def clean_up_ramdisk(self, task, rescue\u003dFalse):"},{"line_number":445,"context_line":"        \"\"\"Cleans up the boot of ironic ramdisk."},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        This method cleans up the environment that was setup for booting the"}],"source_content_type":"text/x-python","patch_set":32,"id":"dfeb2761_ef17d6a2","line":444,"range":{"start_line":444,"start_character":8,"end_line":444,"end_character":50},"updated":"2017-04-04 09:05:03.000000000","message":"This looks like an incompatible change in the base class method.\nAll the drivers that needs to implement rescue interface needs to change their boot interface methods as well.\nNeed to change the signature of all the in-tree drivers to accommodate this change.\nCould this have impact on out-of-tree drivers implementing boot interface?","commit_id":"5f7ab1fc99a21530aa40ffac3c61fbab68686b3f"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"227719ec8def4b709cf0780721325751993c90fb","unresolved":false,"context_lines":[{"line_number":441,"context_line":"        \"\"\""},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"    @abc.abstractmethod"},{"line_number":444,"context_line":"    def clean_up_ramdisk(self, task, rescue\u003dFalse):"},{"line_number":445,"context_line":"        \"\"\"Cleans up the boot of ironic ramdisk."},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        This method cleans up the environment that was setup for booting the"}],"source_content_type":"text/x-python","patch_set":32,"id":"bff0334d_1a9a7413","line":444,"range":{"start_line":444,"start_character":8,"end_line":444,"end_character":50},"in_reply_to":"dfeb2761_ef17d6a2","updated":"2017-04-10 16:15:17.000000000","message":"Yes, it would impact out of tree drivers. I will switch this to a provision_state check within the driver, instead.","commit_id":"5f7ab1fc99a21530aa40ffac3c61fbab68686b3f"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"3598f5351bf96abce41bf1c66918ccf04db52fd0","unresolved":false,"context_lines":[{"line_number":1153,"context_line":"        \"\"\""},{"line_number":1154,"context_line":""},{"line_number":1155,"context_line":"    @abc.abstractmethod"},{"line_number":1156,"context_line":"    def add_rescue_network(self, task):"},{"line_number":1157,"context_line":"        \"\"\"Add the rescue network from a node."},{"line_number":1158,"context_line":""},{"line_number":1159,"context_line":"        :param task: A TaskManager instance."}],"source_content_type":"text/x-python","patch_set":32,"id":"dfeb2761_71604902","line":1156,"updated":"2017-04-04 11:39:10.000000000","message":"1) These methods also not mentioned in \"Driver API impact\". 2) Make them abstract breaks 3-party network interfaces which do not have implementation (network interface is pluggable).","commit_id":"5f7ab1fc99a21530aa40ffac3c61fbab68686b3f"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"227719ec8def4b709cf0780721325751993c90fb","unresolved":false,"context_lines":[{"line_number":1153,"context_line":"        \"\"\""},{"line_number":1154,"context_line":""},{"line_number":1155,"context_line":"    @abc.abstractmethod"},{"line_number":1156,"context_line":"    def add_rescue_network(self, task):"},{"line_number":1157,"context_line":"        \"\"\"Add the rescue network from a node."},{"line_number":1158,"context_line":""},{"line_number":1159,"context_line":"        :param task: A TaskManager instance."}],"source_content_type":"text/x-python","patch_set":32,"id":"bff0334d_9850cd0c","line":1156,"in_reply_to":"dfeb2761_71604902","updated":"2017-04-10 16:15:17.000000000","message":"You\u0027re right, the spec didn\u0027t mention them. We did mention that a rescue network must be created, last bullet point here: https://specs.openstack.org/openstack/ironic-specs/specs/not-implemented/implement-rescue-mode.html#proposed-change\n\nI think the spec was probably landed before the network interfaces were split out.\n\nI could either:\n\n1. Implement these methods only in flat, neutron, and noop (in-tree network drivers)\n2. Do the above, but also add them here and make them no-op (\"pass\") by default\n\nWill do 2 for now, but let me know if you think this should just go inside in-tree drivers.","commit_id":"5f7ab1fc99a21530aa40ffac3c61fbab68686b3f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"127e02427f89ace62c148e3b326d676d86f668d6","unresolved":false,"context_lines":[{"line_number":573,"context_line":"        \"\"\"Clean up the node after a timeout during RESCUEWAIT."},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"        This is only useful for nodes that rescue asynchronously (nodes that"},{"line_number":576,"context_line":"        use the RESCUEWAIT state). Drivers may also override this and use it as"},{"line_number":577,"context_line":"        a general-purpose function for cleaning up after rescuing, but the"},{"line_number":578,"context_line":"        driver itself must invoke this method in that case."},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":581,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":37,"id":"bff0334d_e1c8d622","line":578,"range":{"start_line":576,"start_character":70,"end_line":578,"end_character":59},"updated":"2017-04-11 04:03:53.000000000","message":"I did not quiet get this statement. It gets called in agent_base_vendor.py:agent_base_vendor.py() after rescuing.","commit_id":"5ef3d8407525c9cefac8a1fbcb0173bc3c281d06"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"cb1f5230a97e2a986e0755e9d1bf9ee097989732","unresolved":false,"context_lines":[{"line_number":573,"context_line":"        \"\"\"Clean up the node after a timeout during RESCUEWAIT."},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"        This is only useful for nodes that rescue asynchronously (nodes that"},{"line_number":576,"context_line":"        use the RESCUEWAIT state). Drivers may also override this and use it as"},{"line_number":577,"context_line":"        a general-purpose function for cleaning up after rescuing, but the"},{"line_number":578,"context_line":"        driver itself must invoke this method in that case."},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":581,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":37,"id":"1f013ff3_0cc26c34","line":578,"range":{"start_line":576,"start_character":70,"end_line":578,"end_character":59},"in_reply_to":"bff0334d_e1c8d622","updated":"2017-05-15 12:09:40.000000000","message":"As per my understanding, the drivers can override this operation if the rescue is synchronous.","commit_id":"5ef3d8407525c9cefac8a1fbcb0173bc3c281d06"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"961257c0e38b053668aae3ee84abad5bc7cd54fe","unresolved":false,"context_lines":[{"line_number":559,"context_line":"        \"\"\"Boot the task\u0027s node into a rescue environment."},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":562,"context_line":"        :returns: states.RESCUEWAIT if rescue is in progress asynchronously"},{"line_number":563,"context_line":"            or None if it is complete."},{"line_number":564,"context_line":"        \"\"\""},{"line_number":565,"context_line":""}],"source_content_type":"text/x-python","patch_set":51,"id":"1f1a1f67_a36f2f26","line":562,"range":{"start_line":562,"start_character":25,"end_line":562,"end_character":35},"updated":"2017-07-21 22:07:04.000000000","message":"should this be RESCUEWAIT or RESCUING?","commit_id":"885d936ae5163ad000a0fabb7643f4b2d2fb3b60"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"797eac90108d1d0bee78320e222bbc52a0ddb55b","unresolved":false,"context_lines":[{"line_number":559,"context_line":"        \"\"\"Boot the task\u0027s node into a rescue environment."},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"        :param task: a TaskManager instance containing the node to act on."},{"line_number":562,"context_line":"        :returns: states.RESCUEWAIT if rescue is in progress asynchronously"},{"line_number":563,"context_line":"            or None if it is complete."},{"line_number":564,"context_line":"        \"\"\""},{"line_number":565,"context_line":""}],"source_content_type":"text/x-python","patch_set":51,"id":"df3967d1_872196b7","line":562,"range":{"start_line":562,"start_character":25,"end_line":562,"end_character":35},"in_reply_to":"1f1a1f67_a36f2f26","updated":"2017-07-31 11:44:27.000000000","message":"It has to be \"states.RESCUEWAIT\" as in https://review.openstack.org/#/c/400437/51/ironic/drivers/modules/agent.py@771","commit_id":"885d936ae5163ad000a0fabb7643f4b2d2fb3b60"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"ab4ff5fe59bcddd7948bbcdeced0894aef00079c","unresolved":false,"context_lines":[{"line_number":1088,"context_line":"        \"\"\""},{"line_number":1089,"context_line":""},{"line_number":1090,"context_line":"    def add_rescue_network(self, task):"},{"line_number":1091,"context_line":"        \"\"\"Add the rescue network from a node."},{"line_number":1092,"context_line":""},{"line_number":1093,"context_line":"        :param task: A TaskManager instance."},{"line_number":1094,"context_line":"        :raises: NetworkError"}],"source_content_type":"text/x-python","patch_set":56,"id":"7f515b1d_b2d96e84","line":1091,"range":{"start_line":1091,"start_character":34,"end_line":1091,"end_character":38},"updated":"2017-09-25 07:23:27.000000000","message":"nit: s/from/to/","commit_id":"4701e09b29e197c8637f72fd7ff49db4d1710154"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0d3bbf64848681dffa77a8a8e106cfa7929beffc","unresolved":false,"context_lines":[{"line_number":1088,"context_line":"        \"\"\""},{"line_number":1089,"context_line":""},{"line_number":1090,"context_line":"    def add_rescue_network(self, task):"},{"line_number":1091,"context_line":"        \"\"\"Add the rescue network from a node."},{"line_number":1092,"context_line":""},{"line_number":1093,"context_line":"        :param task: A TaskManager instance."},{"line_number":1094,"context_line":"        :raises: NetworkError"}],"source_content_type":"text/x-python","patch_set":56,"id":"7f515b1d_2e9bd2c9","line":1091,"range":{"start_line":1091,"start_character":34,"end_line":1091,"end_character":38},"in_reply_to":"7f515b1d_b2d96e84","updated":"2017-09-27 16:31:32.000000000","message":"Done","commit_id":"4701e09b29e197c8637f72fd7ff49db4d1710154"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6480163bc034276ee9b0ce674c90994fce9ace3e","unresolved":false,"context_lines":[{"line_number":417,"context_line":"    interface_type \u003d \u0027boot\u0027"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    @abc.abstractmethod"},{"line_number":420,"context_line":"    def prepare_ramdisk(self, task, ramdisk_params):"},{"line_number":421,"context_line":"        \"\"\"Prepares the boot of Ironic ramdisk."},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        This method prepares the boot of the deploy or rescue ramdisk after"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff82abbf_9e8287ff","line":420,"updated":"2017-11-28 21:56:09.000000000","message":"it feels like we should add an optional \u0027rescue\u0027 or \u0027deploy\u0027 parameter here. Well, I guess we can do that later...","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"075da2894b98641ebc44f6508c7f9f4bff729cfb","unresolved":false,"context_lines":[{"line_number":417,"context_line":"    interface_type \u003d \u0027boot\u0027"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"    @abc.abstractmethod"},{"line_number":420,"context_line":"    def prepare_ramdisk(self, task, ramdisk_params):"},{"line_number":421,"context_line":"        \"\"\"Prepares the boot of Ironic ramdisk."},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        This method prepares the boot of the deploy or rescue ramdisk after"}],"source_content_type":"text/x-python","patch_set":69,"id":"df87a7cf_bee147d3","line":420,"in_reply_to":"ff82abbf_9e8287ff","updated":"2017-12-03 16:40:27.000000000","message":"I think, it would be useful, but we can take it up later.","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c7ca39ec5bdbb13f0642747215ecef08aa5bbc58","unresolved":false,"context_lines":[{"line_number":422,"context_line":"        \"\"\"Prepares the boot of Ironic ramdisk."},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        This method prepares the boot of the deploy or rescue ramdisk after"},{"line_number":425,"context_line":"        reading relevant information from the node\u0027s database."},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"        :param task: a task from TaskManager."},{"line_number":428,"context_line":"        :param ramdisk_params: the options to be passed to the ironic ramdisk."}],"source_content_type":"text/x-python","patch_set":77,"id":"bf8cb3f7_fb9a886c","line":425,"updated":"2017-12-20 22:53:26.000000000","message":"how does this know whether it is handling the deploy or the rescue ramdisk?","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3dec19f491aa2f384bbd9d40e31ab6766d682f7c","unresolved":false,"context_lines":[{"line_number":422,"context_line":"        \"\"\"Prepares the boot of Ironic ramdisk."},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"        This method prepares the boot of the deploy or rescue ramdisk after"},{"line_number":425,"context_line":"        reading relevant information from the node\u0027s database."},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"        :param task: a task from TaskManager."},{"line_number":428,"context_line":"        :param ramdisk_params: the options to be passed to the ironic ramdisk."}],"source_content_type":"text/x-python","patch_set":77,"id":"9f91af0f_2abcecda","line":425,"in_reply_to":"bf8cb3f7_fb9a886c","updated":"2018-01-04 11:21:02.000000000","message":"Done","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1dac7d3c279c5b3a5677d8a8c15106f4d2f40cc0","unresolved":false,"context_lines":[{"line_number":419,"context_line":"    interface_type \u003d \u0027boot\u0027"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    @abc.abstractmethod"},{"line_number":422,"context_line":"    def prepare_ramdisk(self, task, ramdisk_params, mode\u003d\u0027deploy\u0027):"},{"line_number":423,"context_line":"        \"\"\"Prepares the boot of Ironic ramdisk."},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        This method prepares the boot of the deploy or rescue ramdisk after"}],"source_content_type":"text/x-python","patch_set":83,"id":"7f96bb07_a62e8a8f","line":422,"updated":"2018-01-16 22:20:28.000000000","message":"my only concern (and I think I asked for this), is what does this mean for existing, out-of-tree drivers. They may not be coded to handle this new mode parameter.\n\nI need to think about this.\n\nFor all in-tree drivers err BootInterfaces, we should make sure we add mode\u003d\u0027deploy\u0027 to the method, even though the method itself doesn\u0027t do anything with it.","commit_id":"bcb1f7edcf57d3ec8a5c6d7c21226a62c529b980"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2e273cc81aab67841c3a2327e951fb2692ca2cf5","unresolved":false,"context_lines":[{"line_number":419,"context_line":"    interface_type \u003d \u0027boot\u0027"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    @abc.abstractmethod"},{"line_number":422,"context_line":"    def prepare_ramdisk(self, task, ramdisk_params, mode\u003d\u0027deploy\u0027):"},{"line_number":423,"context_line":"        \"\"\"Prepares the boot of Ironic ramdisk."},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        This method prepares the boot of the deploy or rescue ramdisk after"}],"source_content_type":"text/x-python","patch_set":83,"id":"7f96bb07_de959641","line":422,"in_reply_to":"7f96bb07_a62e8a8f","updated":"2018-01-17 16:15:08.000000000","message":"Done","commit_id":"bcb1f7edcf57d3ec8a5c6d7c21226a62c529b980"}],"ironic/drivers/fake.py":[{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"cfb176264f516336f8d3cc56b5713e868bc6a520","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        self.management \u003d fake.FakeManagement()"},{"line_number":72,"context_line":"        self.inspect \u003d fake.FakeInspect()"},{"line_number":73,"context_line":"        self.raid \u003d fake.FakeRAID()"},{"line_number":74,"context_line":"        self.rescue \u003d fake.FakeRescue()"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"class FakeSoftPowerDriver(FakeDriver):"}],"source_content_type":"text/x-python","patch_set":44,"id":"df140735_073a0733","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":39},"updated":"2017-05-31 18:34:58.000000000","message":"Need to implement this for tempest test because they are using fake driver.","commit_id":"97a8c1120bf1def69a5f3bd7e66f9d464766a1a9"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"a35a1b45399748423d27af539e9703c4733294bd","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        self.management \u003d fake.FakeManagement()"},{"line_number":72,"context_line":"        self.inspect \u003d fake.FakeInspect()"},{"line_number":73,"context_line":"        self.raid \u003d fake.FakeRAID()"},{"line_number":74,"context_line":"        self.rescue \u003d fake.FakeRescue()"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"class FakeSoftPowerDriver(FakeDriver):"}],"source_content_type":"text/x-python","patch_set":44,"id":"df140735_3b36b552","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":39},"in_reply_to":"df140735_073a0733","updated":"2017-06-06 09:48:51.000000000","message":"FakeRescue implementation is available as part of the following patch. https://review.openstack.org/#/c/350831/43/ironic/drivers/modules/fake.py@193","commit_id":"97a8c1120bf1def69a5f3bd7e66f9d464766a1a9"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"ab4ff5fe59bcddd7948bbcdeced0894aef00079c","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        self.deploy \u003d agent.AgentDeploy()"},{"line_number":122,"context_line":"        self.raid \u003d agent.AgentRAID()"},{"line_number":123,"context_line":"        self.rescue \u003d agent.AgentRescue()"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"class FakeIloDriver(base.BaseDriver):"},{"line_number":127,"context_line":"    \"\"\"Fake iLO driver, used in testing.\"\"\""}],"source_content_type":"text/x-python","patch_set":56,"id":"7f515b1d_f213660c","line":124,"updated":"2017-09-25 07:23:27.000000000","message":"Let\u0027s move this support to fake_hardware","commit_id":"4701e09b29e197c8637f72fd7ff49db4d1710154"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0d3bbf64848681dffa77a8a8e106cfa7929beffc","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        self.deploy \u003d agent.AgentDeploy()"},{"line_number":122,"context_line":"        self.raid \u003d agent.AgentRAID()"},{"line_number":123,"context_line":"        self.rescue \u003d agent.AgentRescue()"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"class FakeIloDriver(base.BaseDriver):"},{"line_number":127,"context_line":"    \"\"\"Fake iLO driver, used in testing.\"\"\""}],"source_content_type":"text/x-python","patch_set":56,"id":"7f515b1d_edf360e6","line":124,"in_reply_to":"7f515b1d_f213660c","updated":"2017-09-27 16:31:32.000000000","message":"Done","commit_id":"4701e09b29e197c8637f72fd7ff49db4d1710154"}],"ironic/drivers/fake_hardware.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"56fa73bfa14097a52eb31f12e53df96073028577","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from ironic.drivers import hardware_type"},{"line_number":20,"context_line":"from ironic.drivers import modules"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class FakeHardware(hardware_type.AbstractHardwareType):"}],"source_content_type":"text/x-python","patch_set":57,"id":"7f515b1d_228fec75","line":20,"updated":"2017-09-28 14:55:48.000000000","message":"Looks like this was changed from \u0027.modules import fake\u0027 to \u0027import modules\u0027\n\nI guess I\u0027m okay with it, just seems different from what we\u0027ve done previously.","commit_id":"a7033f23e913faa265a61894e61c7304d4ed0bb8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"818c94b93113171584c943d591307a1ca23ed4d7","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from ironic.drivers import hardware_type"},{"line_number":20,"context_line":"from ironic.drivers import modules"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class FakeHardware(hardware_type.AbstractHardwareType):"}],"source_content_type":"text/x-python","patch_set":57,"id":"7f515b1d_591acccb","line":20,"in_reply_to":"7f515b1d_228fec75","updated":"2017-09-29 14:21:42.000000000","message":"Yes, I had to change it to avoid cyclic dependency getting introduced, if I were to add import statement for \u0027modules.agent\u0027.\n\nWe import \u0027fake_hardware\u0027 in driver_factory.py.  \n\ndriver_factory would pull modules.agent.py . \u0027agent\u0027 needs conductor.task_manager \n\nconductor.task_manager.py imports common.driver_factory\n\nhttps://github.com/openstack/ironic/blob/master/ironic/common/driver_factory.py#L26\nhttps://github.com/openstack/ironic/blob/master/ironic/drivers/modules/agent.py#L29\nhttps://github.com/openstack/ironic/blob/master/ironic/conductor/task_manager.py#L113","commit_id":"a7033f23e913faa265a61894e61c7304d4ed0bb8"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6480163bc034276ee9b0ce674c90994fce9ace3e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from ironic.drivers import hardware_type"},{"line_number":20,"context_line":"from ironic.drivers import modules"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class FakeHardware(hardware_type.AbstractHardwareType):"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff82abbf_5ed2bf29","line":20,"updated":"2017-11-28 21:56:09.000000000","message":"it seems like the code would be cleaner if we left the original, and added \u0027from ironic.drivers.modules import agent\u0027","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"075da2894b98641ebc44f6508c7f9f4bff729cfb","unresolved":false,"context_lines":[{"line_number":17,"context_line":"\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from ironic.drivers import hardware_type"},{"line_number":20,"context_line":"from ironic.drivers import modules"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class FakeHardware(hardware_type.AbstractHardwareType):"}],"source_content_type":"text/x-python","patch_set":69,"id":"df87a7cf_7ebadfde","line":20,"in_reply_to":"ff82abbf_5ed2bf29","updated":"2017-12-03 16:40:27.000000000","message":"Done","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6480163bc034276ee9b0ce674c90994fce9ace3e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    @property"},{"line_number":45,"context_line":"    def supported_deploy_interfaces(self):"},{"line_number":46,"context_line":"        \"\"\"List of classes of supported deploy interfaces.\"\"\""},{"line_number":47,"context_line":"        return [modules.fake.FakeDeploy, modules.agent.AgentDeploy]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @property"},{"line_number":50,"context_line":"    def supported_inspect_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff82abbf_fea633c1","line":47,"updated":"2017-11-28 21:56:09.000000000","message":"why are we adding agentdeploy and agentrescue? This is a FakeHardware class, i don\u0027t think we can use IPA with fake hardware?","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"075da2894b98641ebc44f6508c7f9f4bff729cfb","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    @property"},{"line_number":45,"context_line":"    def supported_deploy_interfaces(self):"},{"line_number":46,"context_line":"        \"\"\"List of classes of supported deploy interfaces.\"\"\""},{"line_number":47,"context_line":"        return [modules.fake.FakeDeploy, modules.agent.AgentDeploy]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @property"},{"line_number":50,"context_line":"    def supported_inspect_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":69,"id":"df87a7cf_de9d2b67","line":47,"in_reply_to":"ff82abbf_7f2c284a","updated":"2017-12-03 16:40:27.000000000","message":"This was done to create test nodes with driver being as hardware-type instead of classic driver. Using \u0027ipmi\u0027 hardware type instead.","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"43114e5b6d25a25035e99fb5914d792fc0321a4c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    @property"},{"line_number":45,"context_line":"    def supported_deploy_interfaces(self):"},{"line_number":46,"context_line":"        \"\"\"List of classes of supported deploy interfaces.\"\"\""},{"line_number":47,"context_line":"        return [modules.fake.FakeDeploy, modules.agent.AgentDeploy]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @property"},{"line_number":50,"context_line":"    def supported_inspect_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff82abbf_7f2c284a","line":47,"in_reply_to":"ff82abbf_fea633c1","updated":"2017-11-30 16:07:37.000000000","message":"Discussed on irc [1]; it turns out these were added for unit testing purposes. So they should be removed, and the unit tests changed.\n\n[1] http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2017-11-30.log.html#t2017-11-30T15:55:02","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"029e903e2ea6e696e03b27dd6e2d9fd573887ccd","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    @property"},{"line_number":70,"context_line":"    def supported_rescue_interfaces(self):"},{"line_number":71,"context_line":"        \"\"\"List of classes of supported rescue interfaces.\"\"\""},{"line_number":72,"context_line":"        return [modules.fake.FakeRescue, modules.agent.AgentRescue]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @property"},{"line_number":75,"context_line":"    def supported_storage_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff82abbf_df30d4eb","line":72,"range":{"start_line":72,"start_character":41,"end_line":72,"end_character":66},"updated":"2017-11-30 15:59:23.000000000","message":"Same here, fake interfaces should purely be that.","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"075da2894b98641ebc44f6508c7f9f4bff729cfb","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    @property"},{"line_number":70,"context_line":"    def supported_rescue_interfaces(self):"},{"line_number":71,"context_line":"        \"\"\"List of classes of supported rescue interfaces.\"\"\""},{"line_number":72,"context_line":"        return [modules.fake.FakeRescue, modules.agent.AgentRescue]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @property"},{"line_number":75,"context_line":"    def supported_storage_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":69,"id":"df87a7cf_3e7a1724","line":72,"range":{"start_line":72,"start_character":41,"end_line":72,"end_character":66},"in_reply_to":"ff82abbf_df30d4eb","updated":"2017-12-03 16:40:27.000000000","message":"Done","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"}],"ironic/drivers/generic.py":[{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"bb745c52187f1226501112cd76d557eabf489846","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class GenericHardware(hardware_type.AbstractHardwareType):"},{"line_number":32,"context_line":"    \"\"\"Abstract base class representing generic hardware."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    This class provides reasonable defaults for boot, deploy, inspect, network"},{"line_number":35,"context_line":"    raid, and rescue interfaces."},{"line_number":36,"context_line":"    \"\"\""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"3a1ff146_e10be17b","line":34,"range":{"start_line":34,"start_character":71,"end_line":34,"end_character":78},"updated":"2017-03-14 18:09:13.000000000","message":"nit: network,","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"9c300868cdbbcceb3913129f87b47d20f7ab8671","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class GenericHardware(hardware_type.AbstractHardwareType):"},{"line_number":32,"context_line":"    \"\"\"Abstract base class representing generic hardware."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    This class provides reasonable defaults for boot, deploy, inspect, network"},{"line_number":35,"context_line":"    raid, and rescue interfaces."},{"line_number":36,"context_line":"    \"\"\""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"1a1ced50_7348b5cc","line":34,"range":{"start_line":34,"start_character":71,"end_line":34,"end_character":78},"in_reply_to":"3a1ff146_e10be17b","updated":"2017-03-23 17:23:15.000000000","message":"Done","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"ab4ff5fe59bcddd7948bbcdeced0894aef00079c","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        # AgentRescue requires IPA with the rescue extension enabled, so"},{"line_number":79,"context_line":"        # NoRescue is the default"},{"line_number":80,"context_line":"        return [noop.NoRescue, agent.AgentRescue]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"class ManualManagementHardware(GenericHardware):"},{"line_number":84,"context_line":"    \"\"\"Hardware type that uses manual power and boot management."}],"source_content_type":"text/x-python","patch_set":56,"id":"7f515b1d_52d35a39","line":81,"updated":"2017-09-25 07:23:27.000000000","message":"The rescue interface is not defined in the hardware_type, is it intended so, or missing?","commit_id":"4701e09b29e197c8637f72fd7ff49db4d1710154"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0d3bbf64848681dffa77a8a8e106cfa7929beffc","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        # AgentRescue requires IPA with the rescue extension enabled, so"},{"line_number":79,"context_line":"        # NoRescue is the default"},{"line_number":80,"context_line":"        return [noop.NoRescue, agent.AgentRescue]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"class ManualManagementHardware(GenericHardware):"},{"line_number":84,"context_line":"    \"\"\"Hardware type that uses manual power and boot management."}],"source_content_type":"text/x-python","patch_set":56,"id":"7f515b1d_ce9d5e5a","line":81,"in_reply_to":"7f515b1d_52d35a39","updated":"2017-09-27 16:31:32.000000000","message":"Its done in patch https://review.openstack.org/#/c/350831","commit_id":"4701e09b29e197c8637f72fd7ff49db4d1710154"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"7fc19bb41f756ea20037e39a3c8374be0df50c81","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        \"\"\"List of supported storage interfaces.\"\"\""},{"line_number":73,"context_line":"        return [noop_storage.NoopStorage, cinder.CinderStorage]"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @property"},{"line_number":76,"context_line":"    def supported_rescue_interfaces(self):"},{"line_number":77,"context_line":"        \"\"\"List of supported rescue interfaces.\"\"\""},{"line_number":78,"context_line":"        # AgentRescue requires IPA with the rescue extension enabled, so"},{"line_number":79,"context_line":"        # NoRescue is the default"},{"line_number":80,"context_line":"        return [noop.NoRescue, agent.AgentRescue]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"class ManualManagementHardware(GenericHardware):"}],"source_content_type":"text/x-python","patch_set":62,"id":"3f4b6375_e3c090e3","line":80,"range":{"start_line":75,"start_character":0,"end_line":80,"end_character":49},"updated":"2017-12-20 12:22:54.000000000","message":"Should move this method to before the supported_storage_interfaces.","commit_id":"64b56828545c6d9cc2b84baf2925e72bc4ceb3ce"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7582118339d8717569b08cc8effe0881a4265658","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        \"\"\"List of supported storage interfaces.\"\"\""},{"line_number":73,"context_line":"        return [noop_storage.NoopStorage, cinder.CinderStorage]"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @property"},{"line_number":76,"context_line":"    def supported_rescue_interfaces(self):"},{"line_number":77,"context_line":"        \"\"\"List of supported rescue interfaces.\"\"\""},{"line_number":78,"context_line":"        # AgentRescue requires IPA with the rescue extension enabled, so"},{"line_number":79,"context_line":"        # NoRescue is the default"},{"line_number":80,"context_line":"        return [noop.NoRescue, agent.AgentRescue]"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"class ManualManagementHardware(GenericHardware):"}],"source_content_type":"text/x-python","patch_set":62,"id":"bf8cb3f7_8388c071","line":80,"range":{"start_line":75,"start_character":0,"end_line":80,"end_character":49},"in_reply_to":"3f4b6375_e3c090e3","updated":"2017-12-20 14:07:08.000000000","message":"Done","commit_id":"64b56828545c6d9cc2b84baf2925e72bc4ceb3ce"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6480163bc034276ee9b0ce674c90994fce9ace3e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \"\"\"Abstract base class representing generic hardware."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    This class provides reasonable defaults for boot, deploy, inspect, network,"},{"line_number":37,"context_line":"    raid, and rescue interfaces."},{"line_number":38,"context_line":"    \"\"\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff82abbf_3e157be5","line":37,"updated":"2017-11-28 21:56:09.000000000","message":"why don\u0027t we just say \u0027This class provides reasonable defaults for all the interfaces.\u0027 \n\ncuz it is missing \u0027storage\u0027 and it isn\u0027t worth updating all the time.","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"075da2894b98641ebc44f6508c7f9f4bff729cfb","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    \"\"\"Abstract base class representing generic hardware."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    This class provides reasonable defaults for boot, deploy, inspect, network,"},{"line_number":37,"context_line":"    raid, and rescue interfaces."},{"line_number":38,"context_line":"    \"\"\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":69,"id":"df87a7cf_d6d682f2","line":37,"in_reply_to":"ff82abbf_3e157be5","updated":"2017-12-03 16:40:27.000000000","message":"Done","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5c6624dbf3a1813c7379ed74cd29bef2822b82a7","unresolved":false,"context_lines":[{"line_number":34,"context_line":"class GenericHardware(hardware_type.AbstractHardwareType):"},{"line_number":35,"context_line":"    \"\"\"Abstract base class representing generic hardware."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    This class provides reasonable defaults for all the interfaces."},{"line_number":38,"context_line":"    \"\"\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":77,"id":"df87a7cf_1ea697ac","line":37,"updated":"2017-12-19 22:24:29.000000000","message":"nit: s/all/all of/","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7582118339d8717569b08cc8effe0881a4265658","unresolved":false,"context_lines":[{"line_number":34,"context_line":"class GenericHardware(hardware_type.AbstractHardwareType):"},{"line_number":35,"context_line":"    \"\"\"Abstract base class representing generic hardware."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    This class provides reasonable defaults for all the interfaces."},{"line_number":38,"context_line":"    \"\"\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":77,"id":"bf8cb3f7_c01d5ebe","line":37,"in_reply_to":"df87a7cf_1ea697ac","updated":"2017-12-20 14:07:08.000000000","message":"Done","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"}],"ironic/drivers/ipmi.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"ab4ff5fe59bcddd7948bbcdeced0894aef00079c","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        self.inspect \u003d inspector.Inspector.create_if_enabled("},{"line_number":117,"context_line":"            \u0027AgentAndIPMIToolDriver\u0027)"},{"line_number":118,"context_line":"        self.rescue \u003d agent.AgentRescue()"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"class AgentAndIPMIToolAndSocatDriver(AgentAndIPMIToolDriver):"},{"line_number":122,"context_line":"    \"\"\"Agent + IPMITool + socat driver."}],"source_content_type":"text/x-python","patch_set":56,"id":"7f515b1d_f245a618","line":119,"updated":"2017-09-25 07:23:27.000000000","message":"As we know, classic driver will be removed, I think we can just leave it, test with dynamic drivers would be enough.\nditto for other classic driver changes.","commit_id":"4701e09b29e197c8637f72fd7ff49db4d1710154"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0d3bbf64848681dffa77a8a8e106cfa7929beffc","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        self.inspect \u003d inspector.Inspector.create_if_enabled("},{"line_number":117,"context_line":"            \u0027AgentAndIPMIToolDriver\u0027)"},{"line_number":118,"context_line":"        self.rescue \u003d agent.AgentRescue()"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"class AgentAndIPMIToolAndSocatDriver(AgentAndIPMIToolDriver):"},{"line_number":122,"context_line":"    \"\"\"Agent + IPMITool + socat driver."}],"source_content_type":"text/x-python","patch_set":56,"id":"7f515b1d_4d0f14e1","line":119,"in_reply_to":"7f515b1d_f245a618","updated":"2017-09-27 16:31:32.000000000","message":"Done","commit_id":"4701e09b29e197c8637f72fd7ff49db4d1710154"}],"ironic/drivers/modules/agent.py":[{"author":{"_account_id":22931,"name":"Taku Izumi","email":"izumi.taku@jp.fujitsu.com","username":"izumi777"},"change_message_id":"5f1644558cdedf374aaf50f935f860e6dd0b4a5a","unresolved":false,"context_lines":[{"line_number":671,"context_line":"        task.node.save()"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"class AgentRescue(base.RescueInterface):"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"    @METRICS.timer(\u0027AgentRescue.rescue\u0027)"},{"line_number":677,"context_line":"    @task_manager.require_exclusive_lock"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_eb912e48","line":674,"range":{"start_line":674,"start_character":0,"end_line":674,"end_character":17},"updated":"2016-12-07 02:01:16.000000000","message":"get_properties() is missing","commit_id":"76ad460c60afdb84c2a4c5d6038154180d7d7866"},{"author":{"_account_id":22931,"name":"Taku Izumi","email":"izumi.taku@jp.fujitsu.com","username":"izumi777"},"change_message_id":"486636c6659a46aa470e446d6c1eddc05c5deec9","unresolved":false,"context_lines":[{"line_number":679,"context_line":"        try:"},{"line_number":680,"context_line":"            task.driver.network.unconfigure_tenant_networks(task)"},{"line_number":681,"context_line":"            task.driver.network.add_rescue_network(task)"},{"line_number":682,"context_line":"            if CONF.manage_agent_boot:"},{"line_number":683,"context_line":"                ramdisk_opts \u003d deploy_utils.build_agent_options("},{"line_number":684,"context_line":"                    task.node, {\u0027ipa-rescuing\u0027: 1})"},{"line_number":685,"context_line":"                task.driver.boot.prepare_ramdisk(task, ramdisk_opts,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_c560daa7","line":682,"range":{"start_line":682,"start_character":15,"end_line":682,"end_character":37},"updated":"2016-12-07 05:16:35.000000000","message":"Where is this configuration parameter mentioned?","commit_id":"76ad460c60afdb84c2a4c5d6038154180d7d7866"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"b7bc3eff5ca553740766658a42c659d90e460d0a","unresolved":false,"context_lines":[{"line_number":739,"context_line":"                        \"agent rescue.\") %"},{"line_number":740,"context_line":"                {\u0027node\u0027: task.node[\u0027uuid\u0027]})"},{"line_number":741,"context_line":""},{"line_number":742,"context_line":"        if (\u0027configdrive\u0027 not in task.node[\u0027instance_info\u0027] or"},{"line_number":743,"context_line":"                task.node[\u0027instance_info\u0027][\u0027configdrive\u0027] is None):"},{"line_number":744,"context_line":"            raise exception.MissingParameterValue("},{"line_number":745,"context_line":"                err\u003d_LE(\"Node %(node)s is missing configdrive in \""}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_bc939ef9","line":742,"updated":"2016-12-08 18:38:44.000000000","message":"forgot, i also need to verify rescue_password here","commit_id":"ebd35d548f235c9746b1497108a4fd87cb2b317d"},{"author":{"_account_id":22931,"name":"Taku Izumi","email":"izumi.taku@jp.fujitsu.com","username":"izumi777"},"change_message_id":"151c1f65faaff411ba5ac92a32c137bddc323005","unresolved":false,"context_lines":[{"line_number":701,"context_line":"        # networks"},{"line_number":702,"context_line":"        try:"},{"line_number":703,"context_line":"            task.driver.network.remove_rescue_network(task)"},{"line_number":704,"context_line":"            task.driver.network.configure_tenant_networks(task)"},{"line_number":705,"context_line":"            manager_utils.node_set_boot_device(task, \u0027disk\u0027, persistent\u003dTrue)"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"            manager_utils.node_power_action(task, states.REBOOT)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da4df55a_9b62003d","line":704,"range":{"start_line":704,"start_character":12,"end_line":704,"end_character":63},"updated":"2016-12-27 10:43:46.000000000","message":"In case of using flat network, configure_tenant_network() is nop, so tenant network will leave unconfigured, right ?","commit_id":"55847c4ca3cd299f03e182085e15248dfa7ccc1c"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"451f62c2eb9be4150a4e836c8081de39375fd066","unresolved":false,"context_lines":[{"line_number":701,"context_line":"        # networks"},{"line_number":702,"context_line":"        try:"},{"line_number":703,"context_line":"            task.driver.network.remove_rescue_network(task)"},{"line_number":704,"context_line":"            task.driver.network.configure_tenant_networks(task)"},{"line_number":705,"context_line":"            manager_utils.node_set_boot_device(task, \u0027disk\u0027, persistent\u003dTrue)"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"            manager_utils.node_power_action(task, states.REBOOT)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a3c09a3_3de326a5","line":704,"range":{"start_line":704,"start_character":12,"end_line":704,"end_character":63},"in_reply_to":"7a3c09a3_ab4b73af","updated":"2017-01-13 22:42:04.000000000","message":"In my understanding, in a flat network configuration, there\u0027s no real separation between a \"tenant network\" and the control plane network, and everything about the \"tenant network\" used when a node is provisioned is set up before the build even gets to ironic. Different tenants also get put on the same L2 segment after an instance is booted.\n\nThe point of cleaning and rescue networks in the flat case is to set up DHCP appropriately so that PXE booting happens. After unrescue, there\u0027s no point in booting up the rescue ramdisk anymore, so we remove that configuration with L703.\n\nBy \"won\u0027t do anything\", I meant that the call to \"configure_tenant_networks\" (L704) is a no-op.\n\nYou\u0027ll notice that \"unconfigure_tenant_networks\" in the flat case doesn\u0027t do anything, either, so we aren\u0027t destroying any networking configuration that was on the node before rescue happened, too. Thus, I think these are the appropriate actions to take during rescue/unrescue, for the flat or neutron cases.\n\nPlease correct me if this is wrong.","commit_id":"55847c4ca3cd299f03e182085e15248dfa7ccc1c"},{"author":{"_account_id":22931,"name":"Taku Izumi","email":"izumi.taku@jp.fujitsu.com","username":"izumi777"},"change_message_id":"ec9e6c5dd0cd1ab05653ac4bf80a3dc5dcaf05a2","unresolved":false,"context_lines":[{"line_number":701,"context_line":"        # networks"},{"line_number":702,"context_line":"        try:"},{"line_number":703,"context_line":"            task.driver.network.remove_rescue_network(task)"},{"line_number":704,"context_line":"            task.driver.network.configure_tenant_networks(task)"},{"line_number":705,"context_line":"            manager_utils.node_set_boot_device(task, \u0027disk\u0027, persistent\u003dTrue)"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"            manager_utils.node_power_action(task, states.REBOOT)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a3c09a3_ab4b73af","line":704,"range":{"start_line":704,"start_character":12,"end_line":704,"end_character":63},"in_reply_to":"ba5201f7_e72612cd","updated":"2017-01-13 09:38:42.000000000","message":"In case of flat network, \"won\u0027t do anything here\" is wrong, right ?\nremove_rescue_network() was invoked before, so I think all network configuration was lost. \n\nIs my understanding wrong ?","commit_id":"55847c4ca3cd299f03e182085e15248dfa7ccc1c"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"f6f89685da5f92465f6f95427e0ebc838c82df7c","unresolved":false,"context_lines":[{"line_number":701,"context_line":"        # networks"},{"line_number":702,"context_line":"        try:"},{"line_number":703,"context_line":"            task.driver.network.remove_rescue_network(task)"},{"line_number":704,"context_line":"            task.driver.network.configure_tenant_networks(task)"},{"line_number":705,"context_line":"            manager_utils.node_set_boot_device(task, \u0027disk\u0027, persistent\u003dTrue)"},{"line_number":706,"context_line":""},{"line_number":707,"context_line":"            manager_utils.node_power_action(task, states.REBOOT)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5201f7_e72612cd","line":704,"range":{"start_line":704,"start_character":12,"end_line":704,"end_character":63},"in_reply_to":"da4df55a_9b62003d","updated":"2017-01-11 22:51:50.000000000","message":"Yup. In the flat case, there\u0027s no distinction between different tenants in terms of network topology, so this won\u0027t do anything. This is useful for the neutron driver, though","commit_id":"55847c4ca3cd299f03e182085e15248dfa7ccc1c"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"928bc7c0b2883b75a2ffda4f41ea568d30682d83","unresolved":false,"context_lines":[{"line_number":674,"context_line":"            task.driver.network.add_rescue_network(task)"},{"line_number":675,"context_line":"            if CONF.agent.manage_agent_boot:"},{"line_number":676,"context_line":"                ramdisk_opts \u003d deploy_utils.build_agent_options("},{"line_number":677,"context_line":"                    task.node, {\u0027ipa-rescuing\u0027: 1})"},{"line_number":678,"context_line":"                # prepare_ramdisk will set the boot device"},{"line_number":679,"context_line":"                task.driver.boot.prepare_ramdisk(task, ramdisk_opts,"},{"line_number":680,"context_line":"                                                 rescue\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba5201f7_f27ecb68","line":677,"range":{"start_line":677,"start_character":31,"end_line":677,"end_character":50},"updated":"2017-01-11 22:58:50.000000000","message":"not sure if this is needed anymore, going to evaluate after IPA patch is more fleshed out","commit_id":"913ef52450daeb8633cb685c37fb485e81bb911d"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"0217360d1a78516b17b9779994b2b39116224c05","unresolved":false,"context_lines":[{"line_number":719,"context_line":"        :param task: a TaskManager instance with the node being checked"},{"line_number":720,"context_line":"        :raises: MissingParameterValue if node is missing a required parameter"},{"line_number":721,"context_line":"        \"\"\""},{"line_number":722,"context_line":"        required_in_driver_info \u003d [\u0027rescue_ramdisk\u0027, \u0027rescue_kernel\u0027]"},{"line_number":723,"context_line":"        for req in required_in_driver_info:"},{"line_number":724,"context_line":"            if task.node.driver_info.get(req) is None:"},{"line_number":725,"context_line":"                raise exception.MissingParameterValue("}],"source_content_type":"text/x-python","patch_set":10,"id":"9a57fde8_7a0ce994","line":722,"updated":"2017-01-12 20:16:31.000000000","message":"this should only be required if manage_agent_boot\u003dTrue - going to fix in next patch set","commit_id":"6658989cf656a3ac122f9b8298533cd766da3f3a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"abd1621ea37a8edb8200c71f0629d285e7bd435e","unresolved":false,"context_lines":[{"line_number":700,"context_line":"            # networks"},{"line_number":701,"context_line":"            task.driver.network.remove_rescue_network(task)"},{"line_number":702,"context_line":"            task.driver.network.configure_tenant_networks(task)"},{"line_number":703,"context_line":"            manager_utils.node_set_boot_device(task, \u0027disk\u0027, persistent\u003dTrue)"},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"            manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":706,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":24,"id":"9a30ddce_90b03f45","line":703,"range":{"start_line":703,"start_character":47,"end_line":703,"end_character":77},"updated":"2017-03-09 10:49:26.000000000","message":"This cannot be \u0027disk\u0027 always. Need to check if the instance image is of whole disk image or a partition image.\nif task.node.driver_internal_info.get(\u0027is_whole_disk_image\u0027):\n   manager_utils.node_set_boot_device(task, \u0027disk\u0027, persistent\u003dTrue)","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"55b4ff31a5200d0a54ac96928d8c3cff316ac27a","unresolved":false,"context_lines":[{"line_number":700,"context_line":"            # networks"},{"line_number":701,"context_line":"            task.driver.network.remove_rescue_network(task)"},{"line_number":702,"context_line":"            task.driver.network.configure_tenant_networks(task)"},{"line_number":703,"context_line":"            manager_utils.node_set_boot_device(task, \u0027disk\u0027, persistent\u003dTrue)"},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"            manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":706,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":24,"id":"ffe62b97_3f64e7b8","line":703,"range":{"start_line":703,"start_character":47,"end_line":703,"end_character":77},"in_reply_to":"1a1ced50_7716d8f2","updated":"2017-03-27 10:49:55.000000000","message":"It is also possible to have virtual media based boot as well.\nNot sure, if it has other implications, can we call task.driver.boot.prepare_instance()?","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"9c300868cdbbcceb3913129f87b47d20f7ab8671","unresolved":false,"context_lines":[{"line_number":700,"context_line":"            # networks"},{"line_number":701,"context_line":"            task.driver.network.remove_rescue_network(task)"},{"line_number":702,"context_line":"            task.driver.network.configure_tenant_networks(task)"},{"line_number":703,"context_line":"            manager_utils.node_set_boot_device(task, \u0027disk\u0027, persistent\u003dTrue)"},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"            manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":706,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":24,"id":"1a1ced50_7716d8f2","line":703,"range":{"start_line":703,"start_character":47,"end_line":703,"end_character":77},"in_reply_to":"9a30ddce_90b03f45","updated":"2017-03-23 17:23:15.000000000","message":"Interesting catch.... I think you mean in case of netboot vs. localboot, right?\n\nIronic does support local book with partition images, so I think your suggestion would exclude that case: https://docs.openstack.org/project-install-guide/baremetal/draft/advanced.html#local-boot-with-partition-images\n\nIf I switch to using this, then it\u0027ll solve the netboot problem, at least partially: https://github.com/openstack/ironic/blob/c6abd511599afcf5d823f092e24b2a4fd2863048/ironic/drivers/modules/pxe.py#L454\n\nThat way, if local boot isn\u0027t enabled for the node, the DHCP server will be updated with the correct info to netboot the node.\n\nThe only problem that I could think of with using that is that netboot + multitenant networking wouldn\u0027t work (aka this would only work in the flat case), since at this point, the node isn\u0027t going to be on the provisioning network unless tenant net \u003d\u003d provisioning net. I\u0027m not sure that netboot works with multitenant networking anyway, so this is probably fine.\n\nLet me know what you think.","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"2dd67568713b1c648afb0a936b54ae2bd92f3dbd","unresolved":false,"context_lines":[{"line_number":700,"context_line":"            # networks"},{"line_number":701,"context_line":"            task.driver.network.remove_rescue_network(task)"},{"line_number":702,"context_line":"            task.driver.network.configure_tenant_networks(task)"},{"line_number":703,"context_line":"            manager_utils.node_set_boot_device(task, \u0027disk\u0027, persistent\u003dTrue)"},{"line_number":704,"context_line":""},{"line_number":705,"context_line":"            manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":706,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":24,"id":"ffe62b97_87ff1a33","line":703,"range":{"start_line":703,"start_character":47,"end_line":703,"end_character":77},"in_reply_to":"ffe62b97_3f64e7b8","updated":"2017-03-27 15:17:37.000000000","message":"I think so. Added call to boot.prepare_instance in PS27.","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"b69c24e84edced631b5b6a90c4e04db6f9040be6","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from ironic.common import dhcp_factory"},{"line_number":22,"context_line":"from ironic.common import exception"},{"line_number":23,"context_line":"from ironic.common.glance_service import service_utils"},{"line_number":24,"context_line":"from ironic.common.i18n import _, _LI, _LW, _LE"},{"line_number":25,"context_line":"from ironic.common import images"},{"line_number":26,"context_line":"from ironic.common import raid"},{"line_number":27,"context_line":"from ironic.common import states"}],"source_content_type":"text/x-python","patch_set":27,"id":"ffe62b97_42322312","line":24,"range":{"start_line":24,"start_character":42,"end_line":24,"end_character":47},"updated":"2017-03-27 15:55:08.000000000","message":"i18n clean is in progress, so we don\u0027t need to add this now.","commit_id":"0f81050cf6ca173f504835611f1c65fe74b6fdd9"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"fc8b2c891c6e0d972220763c934e4993c94f616a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from ironic.common import dhcp_factory"},{"line_number":22,"context_line":"from ironic.common import exception"},{"line_number":23,"context_line":"from ironic.common.glance_service import service_utils"},{"line_number":24,"context_line":"from ironic.common.i18n import _, _LI, _LW, _LE"},{"line_number":25,"context_line":"from ironic.common import images"},{"line_number":26,"context_line":"from ironic.common import raid"},{"line_number":27,"context_line":"from ironic.common import states"}],"source_content_type":"text/x-python","patch_set":27,"id":"ffe62b97_ae296e37","line":24,"range":{"start_line":24,"start_character":42,"end_line":24,"end_character":47},"in_reply_to":"ffe62b97_42322312","updated":"2017-03-29 16:52:24.000000000","message":"There are other places in this module that require removal as well, unrelated to this patch: https://github.com/openstack/ironic/blob/c6abd511599afcf5d823f092e24b2a4fd2863048/ironic/drivers/modules/agent.py#L297\n\nI\u0027ll clean up in a follow up if other clean up of this module lands before this patch.","commit_id":"0f81050cf6ca173f504835611f1c65fe74b6fdd9"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"b69c24e84edced631b5b6a90c4e04db6f9040be6","unresolved":false,"context_lines":[{"line_number":744,"context_line":"                        \"agent rescue.\") %"},{"line_number":745,"context_line":"                {\u0027node\u0027: task.node[\u0027uuid\u0027]})"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"        if task.node.instance_info.get(\u0027rescue_password\u0027) is None:"},{"line_number":748,"context_line":"            raise exception.MissingParameterValue("},{"line_number":749,"context_line":"                err\u003d(_LE(\"Node %(node)s \""},{"line_number":750,"context_line":"                         \"is missing rescue_password parameter in \""}],"source_content_type":"text/x-python","patch_set":27,"id":"ffe62b97_24060cd0","line":747,"range":{"start_line":747,"start_character":40,"end_line":747,"end_character":55},"updated":"2017-03-27 15:55:08.000000000","message":"can we merge this param to Ln731?","commit_id":"0f81050cf6ca173f504835611f1c65fe74b6fdd9"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"ab4ff5fe59bcddd7948bbcdeced0894aef00079c","unresolved":false,"context_lines":[{"line_number":744,"context_line":"                        \"agent rescue.\") %"},{"line_number":745,"context_line":"                {\u0027node\u0027: task.node[\u0027uuid\u0027]})"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"        if task.node.instance_info.get(\u0027rescue_password\u0027) is None:"},{"line_number":748,"context_line":"            raise exception.MissingParameterValue("},{"line_number":749,"context_line":"                err\u003d(_LE(\"Node %(node)s \""},{"line_number":750,"context_line":"                         \"is missing rescue_password parameter in \""}],"source_content_type":"text/x-python","patch_set":27,"id":"dfeb2761_4912a35a","line":747,"range":{"start_line":747,"start_character":40,"end_line":747,"end_character":55},"in_reply_to":"ffe62b97_0ea4dab8","updated":"2017-09-25 07:23:27.000000000","message":"Agreed","commit_id":"0f81050cf6ca173f504835611f1c65fe74b6fdd9"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"fc8b2c891c6e0d972220763c934e4993c94f616a","unresolved":false,"context_lines":[{"line_number":744,"context_line":"                        \"agent rescue.\") %"},{"line_number":745,"context_line":"                {\u0027node\u0027: task.node[\u0027uuid\u0027]})"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"        if task.node.instance_info.get(\u0027rescue_password\u0027) is None:"},{"line_number":748,"context_line":"            raise exception.MissingParameterValue("},{"line_number":749,"context_line":"                err\u003d(_LE(\"Node %(node)s \""},{"line_number":750,"context_line":"                         \"is missing rescue_password parameter in \""}],"source_content_type":"text/x-python","patch_set":27,"id":"ffe62b97_0ea4dab8","line":747,"range":{"start_line":747,"start_character":40,"end_line":747,"end_character":55},"in_reply_to":"ffe62b97_24060cd0","updated":"2017-03-29 16:52:24.000000000","message":"No, because instance_info can be null (L741), so I\u0027d prefer to keep this check separate.\n\nI\u0027ve refactored this to print all missing parameters at the end of the method. Let me know what you think.","commit_id":"0f81050cf6ca173f504835611f1c65fe74b6fdd9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2b6d6522df3d8974294550013ae3ad71ba9c9401","unresolved":false,"context_lines":[{"line_number":718,"context_line":""},{"line_number":719,"context_line":"    @METRICS.timer(\u0027AgentRescue.get_properties\u0027)"},{"line_number":720,"context_line":"    def get_properties(self):"},{"line_number":721,"context_line":"        return {}"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"    @METRICS.timer(\u0027AgentRescue.validate\u0027)"},{"line_number":724,"context_line":"    def validate(self, task):"}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_fb6f7af9","line":721,"range":{"start_line":721,"start_character":8,"end_line":721,"end_character":17},"updated":"2017-03-28 11:36:52.000000000","message":"I think this should return \u0027rescue_ramdisk\u0027 and \u0027rescue_kernel\u0027","commit_id":"da600a852847e7845ce644ce61bdd2f63e843b8e"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"94dd83ec0a7e8311f38947cdf2806e6f049fa1bf","unresolved":false,"context_lines":[{"line_number":718,"context_line":""},{"line_number":719,"context_line":"    @METRICS.timer(\u0027AgentRescue.get_properties\u0027)"},{"line_number":720,"context_line":"    def get_properties(self):"},{"line_number":721,"context_line":"        return {}"},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"    @METRICS.timer(\u0027AgentRescue.validate\u0027)"},{"line_number":724,"context_line":"    def validate(self, task):"}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_26cfe956","line":721,"range":{"start_line":721,"start_character":8,"end_line":721,"end_character":17},"in_reply_to":"ffe62b97_fb6f7af9","updated":"2017-03-29 16:52:57.000000000","message":"Done. Also updated the descriptive string in OPTIONAL_PROPERTIES to indicate that validation will indeed pass if ironic isn\u0027t managing the rescue ramdisk boot.","commit_id":"da600a852847e7845ce644ce61bdd2f63e843b8e"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2b6d6522df3d8974294550013ae3ad71ba9c9401","unresolved":false,"context_lines":[{"line_number":731,"context_line":"            required_in_driver_info \u003d [\u0027rescue_ramdisk\u0027, \u0027rescue_kernel\u0027]"},{"line_number":732,"context_line":"            for req in required_in_driver_info:"},{"line_number":733,"context_line":"                if task.node.driver_info.get(req) is None:"},{"line_number":734,"context_line":"                    raise exception.MissingParameterValue("},{"line_number":735,"context_line":"                        err\u003d(_LE(\"Node %(node)s is missing parameter in \""},{"line_number":736,"context_line":"                                 \"driver_info %(param)s required for agent \""},{"line_number":737,"context_line":"                                 \"rescue\") %"},{"line_number":738,"context_line":"                             {\u0027node\u0027: task.node[\u0027uuid\u0027],"},{"line_number":739,"context_line":"                              \u0027param\u0027: req}))"},{"line_number":740,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_9b050e17","line":737,"range":{"start_line":734,"start_character":20,"end_line":737,"end_character":44},"updated":"2017-03-28 11:36:52.000000000","message":"Instead of raising the exception upon finding a first missing parameter, parse for all parameters and report a single exception listing all missing parameters.","commit_id":"da600a852847e7845ce644ce61bdd2f63e843b8e"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"94dd83ec0a7e8311f38947cdf2806e6f049fa1bf","unresolved":false,"context_lines":[{"line_number":731,"context_line":"            required_in_driver_info \u003d [\u0027rescue_ramdisk\u0027, \u0027rescue_kernel\u0027]"},{"line_number":732,"context_line":"            for req in required_in_driver_info:"},{"line_number":733,"context_line":"                if task.node.driver_info.get(req) is None:"},{"line_number":734,"context_line":"                    raise exception.MissingParameterValue("},{"line_number":735,"context_line":"                        err\u003d(_LE(\"Node %(node)s is missing parameter in \""},{"line_number":736,"context_line":"                                 \"driver_info %(param)s required for agent \""},{"line_number":737,"context_line":"                                 \"rescue\") %"},{"line_number":738,"context_line":"                             {\u0027node\u0027: task.node[\u0027uuid\u0027],"},{"line_number":739,"context_line":"                              \u0027param\u0027: req}))"},{"line_number":740,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_f98e4677","line":737,"range":{"start_line":734,"start_character":20,"end_line":737,"end_character":44},"in_reply_to":"ffe62b97_9b050e17","updated":"2017-03-29 16:52:57.000000000","message":"Done","commit_id":"da600a852847e7845ce644ce61bdd2f63e843b8e"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2b6d6522df3d8974294550013ae3ad71ba9c9401","unresolved":false,"context_lines":[{"line_number":752,"context_line":"                     {\u0027node\u0027: task.node[\u0027uuid\u0027]}))"},{"line_number":753,"context_line":""},{"line_number":754,"context_line":"    @METRICS.timer(\u0027AgentRescue.clean_up\u0027)"},{"line_number":755,"context_line":"    def clean_up(self, task):"},{"line_number":756,"context_line":"        \"\"\"Remove rescue password from the node on RESCUEWAIT timeout."},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"        :param task: a TaskManager instance with the node that timed out."}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_16b0b3dc","line":755,"range":{"start_line":755,"start_character":4,"end_line":755,"end_character":29},"updated":"2017-03-28 11:36:52.000000000","message":"Where is this method getting used?","commit_id":"da600a852847e7845ce644ce61bdd2f63e843b8e"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"b6d27bf48f55838d72ca4b464551732587e0fbf4","unresolved":false,"context_lines":[{"line_number":752,"context_line":"                     {\u0027node\u0027: task.node[\u0027uuid\u0027]}))"},{"line_number":753,"context_line":""},{"line_number":754,"context_line":"    @METRICS.timer(\u0027AgentRescue.clean_up\u0027)"},{"line_number":755,"context_line":"    def clean_up(self, task):"},{"line_number":756,"context_line":"        \"\"\"Remove rescue password from the node on RESCUEWAIT timeout."},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"        :param task: a TaskManager instance with the node that timed out."}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_3743ae15","line":755,"range":{"start_line":755,"start_character":4,"end_line":755,"end_character":29},"in_reply_to":"ffe62b97_16b0b3dc","updated":"2017-03-28 13:00:07.000000000","message":"Ignore this. This would get called upon resuewait timeout.","commit_id":"da600a852847e7845ce644ce61bdd2f63e843b8e"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"1044e44f85abefaf9cf8ed5bda23987137ed095b","unresolved":false,"context_lines":[{"line_number":767,"context_line":"            del instance_info[\u0027rescue_password\u0027]"},{"line_number":768,"context_line":"            task.node.instance_info \u003d instance_info"},{"line_number":769,"context_line":"            need_to_save_node \u003d True"},{"line_number":770,"context_line":"            task.node.save()"},{"line_number":771,"context_line":""},{"line_number":772,"context_line":"        driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":773,"context_line":"        if \u0027finalizing_rescue\u0027 in driver_internal_info:"}],"source_content_type":"text/x-python","patch_set":29,"id":"ffe62b97_353c862d","line":770,"updated":"2017-03-29 17:01:40.000000000","message":"Oops, this shouldn\u0027t be here","commit_id":"f0db2961167792bab0703c8913a1bcbebf7df2d9"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"3598f5351bf96abce41bf1c66918ccf04db52fd0","unresolved":false,"context_lines":[{"line_number":674,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":675,"context_line":"    def rescue(self, task):"},{"line_number":676,"context_line":"        try:"},{"line_number":677,"context_line":"            task.driver.network.unconfigure_tenant_networks(task)"},{"line_number":678,"context_line":"            task.driver.network.add_rescue_network(task)"},{"line_number":679,"context_line":"            if CONF.agent.manage_agent_boot:"},{"line_number":680,"context_line":"                ramdisk_opts \u003d deploy_utils.build_agent_options(task.node)"}],"source_content_type":"text/x-python","patch_set":32,"id":"dfeb2761_dbf3b472","line":677,"updated":"2017-04-04 11:39:10.000000000","message":"It\u0027s not very good that we switching node with unknown instance state to rescue network w/o power off. We should off here and on in l684.","commit_id":"5f7ab1fc99a21530aa40ffac3c61fbab68686b3f"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"227719ec8def4b709cf0780721325751993c90fb","unresolved":false,"context_lines":[{"line_number":674,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":675,"context_line":"    def rescue(self, task):"},{"line_number":676,"context_line":"        try:"},{"line_number":677,"context_line":"            task.driver.network.unconfigure_tenant_networks(task)"},{"line_number":678,"context_line":"            task.driver.network.add_rescue_network(task)"},{"line_number":679,"context_line":"            if CONF.agent.manage_agent_boot:"},{"line_number":680,"context_line":"                ramdisk_opts \u003d deploy_utils.build_agent_options(task.node)"}],"source_content_type":"text/x-python","patch_set":32,"id":"bff0334d_da2c0c49","line":677,"in_reply_to":"dfeb2761_dbf3b472","updated":"2017-04-10 16:15:17.000000000","message":"Done, and also updated during unrescue","commit_id":"5f7ab1fc99a21530aa40ffac3c61fbab68686b3f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d9651c1752df759a48be9927edf3cc660b1a682b","unresolved":false,"context_lines":[{"line_number":683,"context_line":"                                                 rescue\u003dTrue)"},{"line_number":684,"context_line":"            manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":685,"context_line":"        except Exception:"},{"line_number":686,"context_line":"            LOG.exception(_LE(\u0027Could not rescue node %(node)s\u0027),"},{"line_number":687,"context_line":"                          node\u003dtask.node.uuid)"},{"line_number":688,"context_line":"            return states.RESCUEFAIL"},{"line_number":689,"context_line":"        return states.RESCUEWAIT"}],"source_content_type":"text/x-python","patch_set":32,"id":"dfeb2761_8cddf871","line":686,"range":{"start_line":686,"start_character":32,"end_line":686,"end_character":62},"updated":"2017-04-04 09:05:03.000000000","message":"Need to log the error from exception as well.","commit_id":"5f7ab1fc99a21530aa40ffac3c61fbab68686b3f"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"227719ec8def4b709cf0780721325751993c90fb","unresolved":false,"context_lines":[{"line_number":683,"context_line":"                                                 rescue\u003dTrue)"},{"line_number":684,"context_line":"            manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":685,"context_line":"        except Exception:"},{"line_number":686,"context_line":"            LOG.exception(_LE(\u0027Could not rescue node %(node)s\u0027),"},{"line_number":687,"context_line":"                          node\u003dtask.node.uuid)"},{"line_number":688,"context_line":"            return states.RESCUEFAIL"},{"line_number":689,"context_line":"        return states.RESCUEWAIT"}],"source_content_type":"text/x-python","patch_set":32,"id":"bff0334d_1ad83451","line":686,"range":{"start_line":686,"start_character":32,"end_line":686,"end_character":62},"in_reply_to":"dfeb2761_8cddf871","updated":"2017-04-10 16:15:17.000000000","message":"Done","commit_id":"5f7ab1fc99a21530aa40ffac3c61fbab68686b3f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d9651c1752df759a48be9927edf3cc660b1a682b","unresolved":false,"context_lines":[{"line_number":711,"context_line":""},{"line_number":712,"context_line":"            manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":713,"context_line":"        except Exception:"},{"line_number":714,"context_line":"            LOG.exception(_LE(\u0027Could not unrescue node %(node)s\u0027),"},{"line_number":715,"context_line":"                          node\u003dtask.node.uuid)"},{"line_number":716,"context_line":"            return states.UNRESCUEFAIL"},{"line_number":717,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"dfeb2761_0cd32862","line":714,"range":{"start_line":714,"start_character":31,"end_line":714,"end_character":63},"updated":"2017-04-04 09:05:03.000000000","message":"Need to log the error from exception as well.","commit_id":"5f7ab1fc99a21530aa40ffac3c61fbab68686b3f"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"227719ec8def4b709cf0780721325751993c90fb","unresolved":false,"context_lines":[{"line_number":711,"context_line":""},{"line_number":712,"context_line":"            manager_utils.node_power_action(task, states.REBOOT)"},{"line_number":713,"context_line":"        except Exception:"},{"line_number":714,"context_line":"            LOG.exception(_LE(\u0027Could not unrescue node %(node)s\u0027),"},{"line_number":715,"context_line":"                          node\u003dtask.node.uuid)"},{"line_number":716,"context_line":"            return states.UNRESCUEFAIL"},{"line_number":717,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"bff0334d_fadc7047","line":714,"range":{"start_line":714,"start_character":31,"end_line":714,"end_character":63},"in_reply_to":"dfeb2761_0cd32862","updated":"2017-04-10 16:15:17.000000000","message":"Done","commit_id":"5f7ab1fc99a21530aa40ffac3c61fbab68686b3f"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"3598f5351bf96abce41bf1c66918ccf04db52fd0","unresolved":false,"context_lines":[{"line_number":737,"context_line":"                if task.node.driver_info.get(req) is None:"},{"line_number":738,"context_line":"                    missing_params.append(\u0027driver_info/\u0027 + req)"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"        if task.node.instance_info is None:"},{"line_number":741,"context_line":"            missing_params.append(\u0027instance_info\u0027)"},{"line_number":742,"context_line":"        elif task.node.instance_info.get(\u0027rescue_password\u0027) is None:"},{"line_number":743,"context_line":"            missing_params.append(\u0027instance_info/rescue_password\u0027)"}],"source_content_type":"text/x-python","patch_set":32,"id":"dfeb2761_5679bb2c","line":740,"updated":"2017-04-04 11:39:10.000000000","message":"This is DB JsonEncodedDict and is {} if empty.","commit_id":"5f7ab1fc99a21530aa40ffac3c61fbab68686b3f"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"227719ec8def4b709cf0780721325751993c90fb","unresolved":false,"context_lines":[{"line_number":737,"context_line":"                if task.node.driver_info.get(req) is None:"},{"line_number":738,"context_line":"                    missing_params.append(\u0027driver_info/\u0027 + req)"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"        if task.node.instance_info is None:"},{"line_number":741,"context_line":"            missing_params.append(\u0027instance_info\u0027)"},{"line_number":742,"context_line":"        elif task.node.instance_info.get(\u0027rescue_password\u0027) is None:"},{"line_number":743,"context_line":"            missing_params.append(\u0027instance_info/rescue_password\u0027)"}],"source_content_type":"text/x-python","patch_set":32,"id":"bff0334d_1ac15455","line":740,"in_reply_to":"dfeb2761_5679bb2c","updated":"2017-04-10 16:15:17.000000000","message":"Removed","commit_id":"5f7ab1fc99a21530aa40ffac3c61fbab68686b3f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d9651c1752df759a48be9927edf3cc660b1a682b","unresolved":false,"context_lines":[{"line_number":743,"context_line":"            missing_params.append(\u0027instance_info/rescue_password\u0027)"},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"        if missing_params:"},{"line_number":746,"context_line":"            msg \u003d (\u0027Node %(node)s is missing parameter(s): \u0027"},{"line_number":747,"context_line":"                   \u0027%(params)s. These are required for agent rescue\u0027)"},{"line_number":748,"context_line":"            raise exception.MissingParameterValue("},{"line_number":749,"context_line":"                msg % {\u0027node\u0027: task.node[\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":32,"id":"dfeb2761_ccb660fb","line":746,"range":{"start_line":746,"start_character":20,"end_line":746,"end_character":24},"updated":"2017-04-04 09:05:03.000000000","message":"s/ Node  %(node)s is missing parameter(s) / \nError validating agent rescue interface. Node  %(node)s is missing parameter(s) /","commit_id":"5f7ab1fc99a21530aa40ffac3c61fbab68686b3f"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"227719ec8def4b709cf0780721325751993c90fb","unresolved":false,"context_lines":[{"line_number":743,"context_line":"            missing_params.append(\u0027instance_info/rescue_password\u0027)"},{"line_number":744,"context_line":""},{"line_number":745,"context_line":"        if missing_params:"},{"line_number":746,"context_line":"            msg \u003d (\u0027Node %(node)s is missing parameter(s): \u0027"},{"line_number":747,"context_line":"                   \u0027%(params)s. These are required for agent rescue\u0027)"},{"line_number":748,"context_line":"            raise exception.MissingParameterValue("},{"line_number":749,"context_line":"                msg % {\u0027node\u0027: task.node[\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":32,"id":"bff0334d_7ac98076","line":746,"range":{"start_line":746,"start_character":20,"end_line":746,"end_character":24},"in_reply_to":"dfeb2761_ccb660fb","updated":"2017-04-10 16:15:17.000000000","message":"Done","commit_id":"5f7ab1fc99a21530aa40ffac3c61fbab68686b3f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d9651c1752df759a48be9927edf3cc660b1a682b","unresolved":false,"context_lines":[{"line_number":744,"context_line":""},{"line_number":745,"context_line":"        if missing_params:"},{"line_number":746,"context_line":"            msg \u003d (\u0027Node %(node)s is missing parameter(s): \u0027"},{"line_number":747,"context_line":"                   \u0027%(params)s. These are required for agent rescue\u0027)"},{"line_number":748,"context_line":"            raise exception.MissingParameterValue("},{"line_number":749,"context_line":"                msg % {\u0027node\u0027: task.node[\u0027uuid\u0027],"},{"line_number":750,"context_line":"                       \u0027params\u0027: \u0027, \u0027.join(missing_params)})"}],"source_content_type":"text/x-python","patch_set":32,"id":"dfeb2761_ec3124a4","line":747,"range":{"start_line":747,"start_character":20,"end_line":747,"end_character":30},"updated":"2017-04-04 09:05:03.000000000","message":"For clarity:\ns/ %(params)s / %(params)s in node\u0027s driver_info.\u0027","commit_id":"5f7ab1fc99a21530aa40ffac3c61fbab68686b3f"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"227719ec8def4b709cf0780721325751993c90fb","unresolved":false,"context_lines":[{"line_number":744,"context_line":""},{"line_number":745,"context_line":"        if missing_params:"},{"line_number":746,"context_line":"            msg \u003d (\u0027Node %(node)s is missing parameter(s): \u0027"},{"line_number":747,"context_line":"                   \u0027%(params)s. These are required for agent rescue\u0027)"},{"line_number":748,"context_line":"            raise exception.MissingParameterValue("},{"line_number":749,"context_line":"                msg % {\u0027node\u0027: task.node[\u0027uuid\u0027],"},{"line_number":750,"context_line":"                       \u0027params\u0027: \u0027, \u0027.join(missing_params)})"}],"source_content_type":"text/x-python","patch_set":32,"id":"bff0334d_daaf6c92","line":747,"range":{"start_line":747,"start_character":20,"end_line":747,"end_character":30},"in_reply_to":"dfeb2761_ec3124a4","updated":"2017-04-10 16:15:17.000000000","message":"We log \"driver_info/rescue_ramdisk\" or \"driver_info/rescue_kernel\". We can\u0027t always say driver_info because instance_info/rescue_password may also be missing.","commit_id":"5f7ab1fc99a21530aa40ffac3c61fbab68686b3f"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"3598f5351bf96abce41bf1c66918ccf04db52fd0","unresolved":false,"context_lines":[{"line_number":763,"context_line":""},{"line_number":764,"context_line":"        need_to_save_node \u003d False"},{"line_number":765,"context_line":"        instance_info \u003d task.node.instance_info"},{"line_number":766,"context_line":"        if instance_info is not None and \u0027rescue_password\u0027 in instance_info:"},{"line_number":767,"context_line":"            del instance_info[\u0027rescue_password\u0027]"},{"line_number":768,"context_line":"            task.node.instance_info \u003d instance_info"},{"line_number":769,"context_line":"            need_to_save_node \u003d True"}],"source_content_type":"text/x-python","patch_set":32,"id":"dfeb2761_76227f54","line":766,"range":{"start_line":766,"start_character":11,"end_line":766,"end_character":40},"updated":"2017-04-04 11:39:10.000000000","message":"This is not needed because JSONEncodedDict is {} if empty and it\u0027s covered by unit test.","commit_id":"5f7ab1fc99a21530aa40ffac3c61fbab68686b3f"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"227719ec8def4b709cf0780721325751993c90fb","unresolved":false,"context_lines":[{"line_number":763,"context_line":""},{"line_number":764,"context_line":"        need_to_save_node \u003d False"},{"line_number":765,"context_line":"        instance_info \u003d task.node.instance_info"},{"line_number":766,"context_line":"        if instance_info is not None and \u0027rescue_password\u0027 in instance_info:"},{"line_number":767,"context_line":"            del instance_info[\u0027rescue_password\u0027]"},{"line_number":768,"context_line":"            task.node.instance_info \u003d instance_info"},{"line_number":769,"context_line":"            need_to_save_node \u003d True"}],"source_content_type":"text/x-python","patch_set":32,"id":"bff0334d_7adaa017","line":766,"range":{"start_line":766,"start_character":11,"end_line":766,"end_character":40},"in_reply_to":"dfeb2761_76227f54","updated":"2017-04-10 16:15:17.000000000","message":"Done","commit_id":"5f7ab1fc99a21530aa40ffac3c61fbab68686b3f"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"3598f5351bf96abce41bf1c66918ccf04db52fd0","unresolved":false,"context_lines":[{"line_number":774,"context_line":"            task.node.driver_internal_info \u003d driver_internal_info"},{"line_number":775,"context_line":"            need_to_save_node \u003d True"},{"line_number":776,"context_line":""},{"line_number":777,"context_line":"        if need_to_save_node:"},{"line_number":778,"context_line":"            task.node.save()"}],"source_content_type":"text/x-python","patch_set":32,"id":"dfeb2761_d62b8b7f","line":777,"updated":"2017-04-04 11:39:10.000000000","message":"This is not needed because if no node changes (assignment values to field) ironic do not save node.","commit_id":"5f7ab1fc99a21530aa40ffac3c61fbab68686b3f"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"227719ec8def4b709cf0780721325751993c90fb","unresolved":false,"context_lines":[{"line_number":774,"context_line":"            task.node.driver_internal_info \u003d driver_internal_info"},{"line_number":775,"context_line":"            need_to_save_node \u003d True"},{"line_number":776,"context_line":""},{"line_number":777,"context_line":"        if need_to_save_node:"},{"line_number":778,"context_line":"            task.node.save()"}],"source_content_type":"text/x-python","patch_set":32,"id":"bff0334d_faffd064","line":777,"in_reply_to":"dfeb2761_d62b8b7f","updated":"2017-04-10 16:15:17.000000000","message":"Removed","commit_id":"5f7ab1fc99a21530aa40ffac3c61fbab68686b3f"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"e116ea434c351b8c7051c305b93144a651834e8d","unresolved":false,"context_lines":[{"line_number":714,"context_line":"                        node\u003dtask.node.uuid,"},{"line_number":715,"context_line":"                        reason\u003d\"Rescue network cannot be the same as tenant \""},{"line_number":716,"context_line":"                               \"network when neutron network interface.\")"},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"        return True"},{"line_number":719,"context_line":""},{"line_number":720,"context_line":"    @METRICS.timer(\u0027AgentRescue.rescue\u0027)"}],"source_content_type":"text/x-python","patch_set":34,"id":"bff0334d_4c8967c8","line":717,"updated":"2017-04-06 20:22:09.000000000","message":"else:\n    some failure","commit_id":"ae6c17b714962e40745d8be6829918524534fe29"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"65edfe995f79506d5b0c10546810a37855d51e3b","unresolved":false,"context_lines":[{"line_number":714,"context_line":"                        node\u003dtask.node.uuid,"},{"line_number":715,"context_line":"                        reason\u003d\"Rescue network cannot be the same as tenant \""},{"line_number":716,"context_line":"                               \"network when neutron network interface.\")"},{"line_number":717,"context_line":""},{"line_number":718,"context_line":"        return True"},{"line_number":719,"context_line":""},{"line_number":720,"context_line":"    @METRICS.timer(\u0027AgentRescue.rescue\u0027)"}],"source_content_type":"text/x-python","patch_set":34,"id":"bff0334d_4e334215","line":717,"in_reply_to":"bff0334d_4c8967c8","updated":"2017-04-10 16:15:04.000000000","message":"I think it\u0027s OK this way, actually.\n\nThis allows out of tree network drivers to implement whatever rescue logic they want within the driver methods with minimal patching here. This also lets the noop network driver proceed normally and do nothing, although I could just add another case to check for that.\n\nI\u0027m OK with switching it if there\u0027s a good reason we\u0027d want to fail out in unknown cases here, though. Or perhaps I should just move this into the network drivers, log a warning, and try to proceed if the method doesn\u0027t exist in out of tree network drivers.\n\nNot sure of the best path....","commit_id":"ae6c17b714962e40745d8be6829918524534fe29"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"7cca126f17da7a779d03f269ef7640390846a29e","unresolved":false,"context_lines":[{"line_number":719,"context_line":""},{"line_number":720,"context_line":"    @METRICS.timer(\u0027AgentRescue.rescue\u0027)"},{"line_number":721,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":722,"context_line":"    def rescue(self, task):"},{"line_number":723,"context_line":"        try:"},{"line_number":724,"context_line":"            manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":725,"context_line":"            if self._validate_network_topology(task):"}],"source_content_type":"text/x-python","patch_set":34,"id":"bff0334d_92820f4f","line":722,"range":{"start_line":722,"start_character":4,"end_line":722,"end_character":27},"updated":"2017-04-06 01:05:03.000000000","message":"Doc string is missing.","commit_id":"ae6c17b714962e40745d8be6829918524534fe29"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"65edfe995f79506d5b0c10546810a37855d51e3b","unresolved":false,"context_lines":[{"line_number":719,"context_line":""},{"line_number":720,"context_line":"    @METRICS.timer(\u0027AgentRescue.rescue\u0027)"},{"line_number":721,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":722,"context_line":"    def rescue(self, task):"},{"line_number":723,"context_line":"        try:"},{"line_number":724,"context_line":"            manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":725,"context_line":"            if self._validate_network_topology(task):"}],"source_content_type":"text/x-python","patch_set":34,"id":"bff0334d_2c0b6724","line":722,"range":{"start_line":722,"start_character":4,"end_line":722,"end_character":27},"in_reply_to":"bff0334d_92820f4f","updated":"2017-04-10 16:15:04.000000000","message":"Done","commit_id":"ae6c17b714962e40745d8be6829918524534fe29"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"7cca126f17da7a779d03f269ef7640390846a29e","unresolved":false,"context_lines":[{"line_number":741,"context_line":""},{"line_number":742,"context_line":"    @METRICS.timer(\u0027AgentRescue.unrescue\u0027)"},{"line_number":743,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":744,"context_line":"    def unrescue(self, task):"},{"line_number":745,"context_line":"        try:"},{"line_number":746,"context_line":"            if CONF.agent.manage_agent_boot:"},{"line_number":747,"context_line":"                task.driver.boot.clean_up_ramdisk(task, rescue\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":34,"id":"bff0334d_72978b92","line":744,"range":{"start_line":744,"start_character":8,"end_line":744,"end_character":16},"updated":"2017-04-06 01:05:03.000000000","message":"ditto","commit_id":"ae6c17b714962e40745d8be6829918524534fe29"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"65edfe995f79506d5b0c10546810a37855d51e3b","unresolved":false,"context_lines":[{"line_number":741,"context_line":""},{"line_number":742,"context_line":"    @METRICS.timer(\u0027AgentRescue.unrescue\u0027)"},{"line_number":743,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":744,"context_line":"    def unrescue(self, task):"},{"line_number":745,"context_line":"        try:"},{"line_number":746,"context_line":"            if CONF.agent.manage_agent_boot:"},{"line_number":747,"context_line":"                task.driver.boot.clean_up_ramdisk(task, rescue\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":34,"id":"bff0334d_0c142343","line":744,"range":{"start_line":744,"start_character":8,"end_line":744,"end_character":16},"in_reply_to":"bff0334d_72978b92","updated":"2017-04-10 16:15:04.000000000","message":"Done","commit_id":"ae6c17b714962e40745d8be6829918524534fe29"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"127e02427f89ace62c148e3b326d676d86f668d6","unresolved":false,"context_lines":[{"line_number":702,"context_line":"                elif task.node.network_interface \u003d\u003d \u0027neutron\u0027:"},{"line_number":703,"context_line":"                    raise exception.InstanceRescueFailure("},{"line_number":704,"context_line":"                        node\u003dtask.node.uuid,"},{"line_number":705,"context_line":"                        reason\u003d\"Rescue network cannot be the same as tenant \""},{"line_number":706,"context_line":"                               \"network when using neutron network interface.\")"},{"line_number":707,"context_line":"        return True"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"    @METRICS.timer(\u0027AgentRescue.rescue\u0027)"}],"source_content_type":"text/x-python","patch_set":37,"id":"bff0334d_21335ef8","line":706,"range":{"start_line":705,"start_character":31,"end_line":706,"end_character":78},"updated":"2017-04-11 04:03:53.000000000","message":"Add rescue and tenant network uuids in the message.","commit_id":"5ef3d8407525c9cefac8a1fbcb0173bc3c281d06"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"cb1f5230a97e2a986e0755e9d1bf9ee097989732","unresolved":false,"context_lines":[{"line_number":702,"context_line":"                elif task.node.network_interface \u003d\u003d \u0027neutron\u0027:"},{"line_number":703,"context_line":"                    raise exception.InstanceRescueFailure("},{"line_number":704,"context_line":"                        node\u003dtask.node.uuid,"},{"line_number":705,"context_line":"                        reason\u003d\"Rescue network cannot be the same as tenant \""},{"line_number":706,"context_line":"                               \"network when using neutron network interface.\")"},{"line_number":707,"context_line":"        return True"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"    @METRICS.timer(\u0027AgentRescue.rescue\u0027)"}],"source_content_type":"text/x-python","patch_set":37,"id":"1f013ff3_f68eef25","line":706,"range":{"start_line":705,"start_character":31,"end_line":706,"end_character":78},"in_reply_to":"bff0334d_21335ef8","updated":"2017-05-15 12:09:40.000000000","message":"Done","commit_id":"5ef3d8407525c9cefac8a1fbcb0173bc3c281d06"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"127e02427f89ace62c148e3b326d676d86f668d6","unresolved":false,"context_lines":[{"line_number":712,"context_line":"        \"\"\"Boot a rescue ramdisk on the node.\"\"\""},{"line_number":713,"context_line":"        try:"},{"line_number":714,"context_line":"            manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":715,"context_line":"            if self.validate_network_topology(task):"},{"line_number":716,"context_line":"                task.driver.network.unconfigure_tenant_networks(task)"},{"line_number":717,"context_line":"                task.driver.network.add_rescue_network(task)"},{"line_number":718,"context_line":"            if CONF.agent.manage_agent_boot:"}],"source_content_type":"text/x-python","patch_set":37,"id":"bff0334d_6123a657","line":715,"range":{"start_line":715,"start_character":12,"end_line":715,"end_character":52},"updated":"2017-04-11 04:03:53.000000000","message":"Need to perform instance clean-up before this.\ntask.driver.boot.clean_up_instance()","commit_id":"5ef3d8407525c9cefac8a1fbcb0173bc3c281d06"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"cb1f5230a97e2a986e0755e9d1bf9ee097989732","unresolved":false,"context_lines":[{"line_number":712,"context_line":"        \"\"\"Boot a rescue ramdisk on the node.\"\"\""},{"line_number":713,"context_line":"        try:"},{"line_number":714,"context_line":"            manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":715,"context_line":"            if self.validate_network_topology(task):"},{"line_number":716,"context_line":"                task.driver.network.unconfigure_tenant_networks(task)"},{"line_number":717,"context_line":"                task.driver.network.add_rescue_network(task)"},{"line_number":718,"context_line":"            if CONF.agent.manage_agent_boot:"}],"source_content_type":"text/x-python","patch_set":37,"id":"1f013ff3_4cccf488","line":715,"range":{"start_line":715,"start_character":12,"end_line":715,"end_character":52},"in_reply_to":"bff0334d_6123a657","updated":"2017-05-15 12:09:40.000000000","message":"Done","commit_id":"5ef3d8407525c9cefac8a1fbcb0173bc3c281d06"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"127e02427f89ace62c148e3b326d676d86f668d6","unresolved":false,"context_lines":[{"line_number":745,"context_line":"                    task.driver.network.remove_rescue_network(task)"},{"line_number":746,"context_line":"                    task.driver.network.configure_tenant_networks(task)"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"            iwdi \u003d task.node.driver_internal_info.get(\u0027is_whole_disk_image\u0027)"},{"line_number":749,"context_line":"            if iwdi or deploy_utils.get_boot_option(task.node) \u003d\u003d \u0027local\u0027:"},{"line_number":750,"context_line":"                manager_utils.node_set_boot_device("},{"line_number":751,"context_line":"                    task, \u0027disk\u0027, persistent\u003dTrue)"},{"line_number":752,"context_line":"            else:"},{"line_number":753,"context_line":"                # NOTE(mariojv) Unlike deploys, provisioning network is not"},{"line_number":754,"context_line":"                # always set on the node at this time (only tenant network)."},{"line_number":755,"context_line":"                # Boot drivers should appropriately switch networks within the"},{"line_number":756,"context_line":"                # boot interface if needed, e.g., for unrescue support with"},{"line_number":757,"context_line":"                # netboot-ed nodes."},{"line_number":758,"context_line":"                task.driver.boot.prepare_instance(task)"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"            manager_utils.node_power_action(task, states.POWER_ON)"}],"source_content_type":"text/x-python","patch_set":37,"id":"bff0334d_c195d234","line":757,"range":{"start_line":748,"start_character":12,"end_line":757,"end_character":35},"updated":"2017-04-11 04:03:53.000000000","message":"I think this is not required. This should be taken care in boot.prepare_instance().","commit_id":"5ef3d8407525c9cefac8a1fbcb0173bc3c281d06"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"cb1f5230a97e2a986e0755e9d1bf9ee097989732","unresolved":false,"context_lines":[{"line_number":745,"context_line":"                    task.driver.network.remove_rescue_network(task)"},{"line_number":746,"context_line":"                    task.driver.network.configure_tenant_networks(task)"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"            iwdi \u003d task.node.driver_internal_info.get(\u0027is_whole_disk_image\u0027)"},{"line_number":749,"context_line":"            if iwdi or deploy_utils.get_boot_option(task.node) \u003d\u003d \u0027local\u0027:"},{"line_number":750,"context_line":"                manager_utils.node_set_boot_device("},{"line_number":751,"context_line":"                    task, \u0027disk\u0027, persistent\u003dTrue)"},{"line_number":752,"context_line":"            else:"},{"line_number":753,"context_line":"                # NOTE(mariojv) Unlike deploys, provisioning network is not"},{"line_number":754,"context_line":"                # always set on the node at this time (only tenant network)."},{"line_number":755,"context_line":"                # Boot drivers should appropriately switch networks within the"},{"line_number":756,"context_line":"                # boot interface if needed, e.g., for unrescue support with"},{"line_number":757,"context_line":"                # netboot-ed nodes."},{"line_number":758,"context_line":"                task.driver.boot.prepare_instance(task)"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"            manager_utils.node_power_action(task, states.POWER_ON)"}],"source_content_type":"text/x-python","patch_set":37,"id":"1f013ff3_d693f34e","line":757,"range":{"start_line":748,"start_character":12,"end_line":757,"end_character":35},"in_reply_to":"7ffa3b31_89b66cd9","updated":"2017-05-15 12:09:40.000000000","message":"Done","commit_id":"5ef3d8407525c9cefac8a1fbcb0173bc3c281d06"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"f696d933c1bf9919bed7d1a8b85df8ad520d0e57","unresolved":false,"context_lines":[{"line_number":745,"context_line":"                    task.driver.network.remove_rescue_network(task)"},{"line_number":746,"context_line":"                    task.driver.network.configure_tenant_networks(task)"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"            iwdi \u003d task.node.driver_internal_info.get(\u0027is_whole_disk_image\u0027)"},{"line_number":749,"context_line":"            if iwdi or deploy_utils.get_boot_option(task.node) \u003d\u003d \u0027local\u0027:"},{"line_number":750,"context_line":"                manager_utils.node_set_boot_device("},{"line_number":751,"context_line":"                    task, \u0027disk\u0027, persistent\u003dTrue)"},{"line_number":752,"context_line":"            else:"},{"line_number":753,"context_line":"                # NOTE(mariojv) Unlike deploys, provisioning network is not"},{"line_number":754,"context_line":"                # always set on the node at this time (only tenant network)."},{"line_number":755,"context_line":"                # Boot drivers should appropriately switch networks within the"},{"line_number":756,"context_line":"                # boot interface if needed, e.g., for unrescue support with"},{"line_number":757,"context_line":"                # netboot-ed nodes."},{"line_number":758,"context_line":"                task.driver.boot.prepare_instance(task)"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"            manager_utils.node_power_action(task, states.POWER_ON)"}],"source_content_type":"text/x-python","patch_set":37,"id":"7ffa3b31_89b66cd9","line":757,"range":{"start_line":748,"start_character":12,"end_line":757,"end_character":35},"in_reply_to":"bff0334d_c195d234","updated":"2017-04-14 21:20:08.000000000","message":"+1","commit_id":"5ef3d8407525c9cefac8a1fbcb0173bc3c281d06"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"97fc40a790e334eb8d69e065929639af2bf87daf","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                        \u0027a dot to prefix the domain name. This value will be \u0027"},{"line_number":58,"context_line":"                        \u0027ignored if ``image_http_proxy`` and \u0027"},{"line_number":59,"context_line":"                        \u0027``image_https_proxy`` are not specified. Optional.\u0027),"},{"line_number":60,"context_line":"    \u0027rescue_kernel\u0027: _(\u0027UUID (from Glance) of the rescue kernel. Only \u0027"},{"line_number":61,"context_line":"                       \u0027required if rescue mode is being used and ironic is \u0027"},{"line_number":62,"context_line":"                       \u0027managing booting the rescue ramdisk.\u0027),"},{"line_number":63,"context_line":"    \u0027rescue_ramdisk\u0027: _(\u0027UUID (from Glance) of the rescue ramdisk. Only \u0027"},{"line_number":64,"context_line":"                        \u0027required if rescue mode is being used and ironic is \u0027"},{"line_number":65,"context_line":"                        \u0027managing booting the rescue ramdisk.\u0027)"}],"source_content_type":"text/x-python","patch_set":40,"id":"1f013ff3_f980f78d","line":62,"range":{"start_line":60,"start_character":65,"end_line":62,"end_character":60},"updated":"2017-05-16 15:14:05.000000000","message":"nit: s/Only ../Optional.","commit_id":"a28c805aee518e10a41a093cb5413cb7a249459f"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"9c189cba56f3ae6e3ca0b50e5da24a0ab362503b","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                        \u0027a dot to prefix the domain name. This value will be \u0027"},{"line_number":58,"context_line":"                        \u0027ignored if ``image_http_proxy`` and \u0027"},{"line_number":59,"context_line":"                        \u0027``image_https_proxy`` are not specified. Optional.\u0027),"},{"line_number":60,"context_line":"    \u0027rescue_kernel\u0027: _(\u0027UUID (from Glance) of the rescue kernel. Only \u0027"},{"line_number":61,"context_line":"                       \u0027required if rescue mode is being used and ironic is \u0027"},{"line_number":62,"context_line":"                       \u0027managing booting the rescue ramdisk.\u0027),"},{"line_number":63,"context_line":"    \u0027rescue_ramdisk\u0027: _(\u0027UUID (from Glance) of the rescue ramdisk. Only \u0027"},{"line_number":64,"context_line":"                        \u0027required if rescue mode is being used and ironic is \u0027"},{"line_number":65,"context_line":"                        \u0027managing booting the rescue ramdisk.\u0027)"}],"source_content_type":"text/x-python","patch_set":40,"id":"ff0f0b1f_9eb7c487","line":62,"range":{"start_line":60,"start_character":65,"end_line":62,"end_character":60},"in_reply_to":"1f013ff3_f980f78d","updated":"2017-05-18 07:04:43.000000000","message":"Done","commit_id":"a28c805aee518e10a41a093cb5413cb7a249459f"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"97fc40a790e334eb8d69e065929639af2bf87daf","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                       \u0027managing booting the rescue ramdisk.\u0027),"},{"line_number":63,"context_line":"    \u0027rescue_ramdisk\u0027: _(\u0027UUID (from Glance) of the rescue ramdisk. Only \u0027"},{"line_number":64,"context_line":"                        \u0027required if rescue mode is being used and ironic is \u0027"},{"line_number":65,"context_line":"                        \u0027managing booting the rescue ramdisk.\u0027)"},{"line_number":66,"context_line":"}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"COMMON_PROPERTIES \u003d REQUIRED_PROPERTIES.copy()"}],"source_content_type":"text/x-python","patch_set":40,"id":"1f013ff3_d97bfbbb","line":65,"updated":"2017-05-16 15:14:05.000000000","message":"ditto","commit_id":"a28c805aee518e10a41a093cb5413cb7a249459f"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"9c189cba56f3ae6e3ca0b50e5da24a0ab362503b","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                       \u0027managing booting the rescue ramdisk.\u0027),"},{"line_number":63,"context_line":"    \u0027rescue_ramdisk\u0027: _(\u0027UUID (from Glance) of the rescue ramdisk. Only \u0027"},{"line_number":64,"context_line":"                        \u0027required if rescue mode is being used and ironic is \u0027"},{"line_number":65,"context_line":"                        \u0027managing booting the rescue ramdisk.\u0027)"},{"line_number":66,"context_line":"}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"COMMON_PROPERTIES \u003d REQUIRED_PROPERTIES.copy()"}],"source_content_type":"text/x-python","patch_set":40,"id":"ff0f0b1f_7ebcf068","line":65,"in_reply_to":"1f013ff3_d97bfbbb","updated":"2017-05-18 07:04:43.000000000","message":"Done","commit_id":"a28c805aee518e10a41a093cb5413cb7a249459f"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"97fc40a790e334eb8d69e065929639af2bf87daf","unresolved":false,"context_lines":[{"line_number":693,"context_line":"        vifs \u003d [vif[\u0027id\u0027] for vif in task.driver.network.vif_list(task)]"},{"line_number":694,"context_line":"        if not vifs:"},{"line_number":695,"context_line":"            return True"},{"line_number":696,"context_line":"        rescue_network_uuid \u003d task.driver.network.get_rescue_network_uuid()"},{"line_number":697,"context_line":"        for vif in vifs:"},{"line_number":698,"context_line":"            network_for_vif \u003d neutron.get_network_from_port(vif)"},{"line_number":699,"context_line":"            if network_for_vif \u003d\u003d rescue_network_uuid:"}],"source_content_type":"text/x-python","patch_set":40,"id":"1f013ff3_27aabad1","line":696,"range":{"start_line":696,"start_character":50,"end_line":696,"end_character":73},"updated":"2017-05-16 15:14:05.000000000","message":"This method is neutron related, direct usage in common agent rescue code can break 3-party network interfaces (they can implement own vif_list() method from base).","commit_id":"a28c805aee518e10a41a093cb5413cb7a249459f"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"9c189cba56f3ae6e3ca0b50e5da24a0ab362503b","unresolved":false,"context_lines":[{"line_number":693,"context_line":"        vifs \u003d [vif[\u0027id\u0027] for vif in task.driver.network.vif_list(task)]"},{"line_number":694,"context_line":"        if not vifs:"},{"line_number":695,"context_line":"            return True"},{"line_number":696,"context_line":"        rescue_network_uuid \u003d task.driver.network.get_rescue_network_uuid()"},{"line_number":697,"context_line":"        for vif in vifs:"},{"line_number":698,"context_line":"            network_for_vif \u003d neutron.get_network_from_port(vif)"},{"line_number":699,"context_line":"            if network_for_vif \u003d\u003d rescue_network_uuid:"}],"source_content_type":"text/x-python","patch_set":40,"id":"ff0f0b1f_347337ea","line":696,"range":{"start_line":696,"start_character":50,"end_line":696,"end_character":73},"in_reply_to":"1f013ff3_27aabad1","updated":"2017-05-18 07:04:43.000000000","message":"I didn\u0027t quite get the comment. \nDo you mean to say the vif_list may return networks other than the tenant network? If that is the case, we are throwing an error if the rescue network id is same as network vif @699.","commit_id":"a28c805aee518e10a41a093cb5413cb7a249459f"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"97fc40a790e334eb8d69e065929639af2bf87daf","unresolved":false,"context_lines":[{"line_number":695,"context_line":"            return True"},{"line_number":696,"context_line":"        rescue_network_uuid \u003d task.driver.network.get_rescue_network_uuid()"},{"line_number":697,"context_line":"        for vif in vifs:"},{"line_number":698,"context_line":"            network_for_vif \u003d neutron.get_network_from_port(vif)"},{"line_number":699,"context_line":"            if network_for_vif \u003d\u003d rescue_network_uuid:"},{"line_number":700,"context_line":"                if task.node.network_interface \u003d\u003d \u0027flat\u0027:"},{"line_number":701,"context_line":"                    return False"}],"source_content_type":"text/x-python","patch_set":40,"id":"1f013ff3_a7ec8a29","line":698,"range":{"start_line":698,"start_character":30,"end_line":698,"end_character":59},"updated":"2017-05-16 15:14:05.000000000","message":"Ditto, this is neutron related.","commit_id":"a28c805aee518e10a41a093cb5413cb7a249459f"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"97fc40a790e334eb8d69e065929639af2bf87daf","unresolved":false,"context_lines":[{"line_number":730,"context_line":"                      {\u0027node\u0027: task.node.uuid,"},{"line_number":731,"context_line":"                       \u0027error\u0027: exc})"},{"line_number":732,"context_line":"            return states.RESCUEFAIL"},{"line_number":733,"context_line":"        return states.RESCUEWAIT"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"    @METRICS.timer(\u0027AgentRescue.unrescue\u0027)"},{"line_number":736,"context_line":"    @task_manager.require_exclusive_lock"}],"source_content_type":"text/x-python","patch_set":40,"id":"1f013ff3_e78df2d3","line":733,"updated":"2017-05-16 15:14:05.000000000","message":"These return values are not documented in the base interface docstrings.","commit_id":"a28c805aee518e10a41a093cb5413cb7a249459f"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"9c189cba56f3ae6e3ca0b50e5da24a0ab362503b","unresolved":false,"context_lines":[{"line_number":730,"context_line":"                      {\u0027node\u0027: task.node.uuid,"},{"line_number":731,"context_line":"                       \u0027error\u0027: exc})"},{"line_number":732,"context_line":"            return states.RESCUEFAIL"},{"line_number":733,"context_line":"        return states.RESCUEWAIT"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"    @METRICS.timer(\u0027AgentRescue.unrescue\u0027)"},{"line_number":736,"context_line":"    @task_manager.require_exclusive_lock"}],"source_content_type":"text/x-python","patch_set":40,"id":"ff0f0b1f_d99af6c3","line":733,"in_reply_to":"1f013ff3_e78df2d3","updated":"2017-05-18 07:04:43.000000000","message":"Done","commit_id":"a28c805aee518e10a41a093cb5413cb7a249459f"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"97fc40a790e334eb8d69e065929639af2bf87daf","unresolved":false,"context_lines":[{"line_number":759,"context_line":"                       \u0027error\u0027: exc})"},{"line_number":760,"context_line":"            return states.UNRESCUEFAIL"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"        return states.ACTIVE"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"    @METRICS.timer(\u0027AgentRescue.get_properties\u0027)"},{"line_number":765,"context_line":"    def get_properties(self):"}],"source_content_type":"text/x-python","patch_set":40,"id":"1f013ff3_47b26696","line":762,"updated":"2017-05-16 15:14:05.000000000","message":"ditto l733","commit_id":"a28c805aee518e10a41a093cb5413cb7a249459f"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"9c189cba56f3ae6e3ca0b50e5da24a0ab362503b","unresolved":false,"context_lines":[{"line_number":759,"context_line":"                       \u0027error\u0027: exc})"},{"line_number":760,"context_line":"            return states.UNRESCUEFAIL"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":"        return states.ACTIVE"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":"    @METRICS.timer(\u0027AgentRescue.get_properties\u0027)"},{"line_number":765,"context_line":"    def get_properties(self):"}],"source_content_type":"text/x-python","patch_set":40,"id":"ff0f0b1f_3994528b","line":762,"in_reply_to":"1f013ff3_47b26696","updated":"2017-05-18 07:04:43.000000000","message":"Done","commit_id":"a28c805aee518e10a41a093cb5413cb7a249459f"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"97fc40a790e334eb8d69e065929639af2bf87daf","unresolved":false,"context_lines":[{"line_number":789,"context_line":"                   \u0027Node %(node)s is missing parameter(s): \u0027"},{"line_number":790,"context_line":"                   \u0027%(params)s. These are required for agent rescue.\u0027)"},{"line_number":791,"context_line":"            raise exception.MissingParameterValue("},{"line_number":792,"context_line":"                msg % {\u0027node\u0027: task.node[\u0027uuid\u0027],"},{"line_number":793,"context_line":"                       \u0027params\u0027: \u0027, \u0027.join(missing_params)})"},{"line_number":794,"context_line":""},{"line_number":795,"context_line":"    @METRICS.timer(\u0027AgentRescue.clean_up\u0027)"}],"source_content_type":"text/x-python","patch_set":40,"id":"1f013ff3_2279882e","line":792,"updated":"2017-05-16 15:14:05.000000000","message":"Please use task.node.uuid, \"getitem\" access deprecated.","commit_id":"a28c805aee518e10a41a093cb5413cb7a249459f"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"9c189cba56f3ae6e3ca0b50e5da24a0ab362503b","unresolved":false,"context_lines":[{"line_number":789,"context_line":"                   \u0027Node %(node)s is missing parameter(s): \u0027"},{"line_number":790,"context_line":"                   \u0027%(params)s. These are required for agent rescue.\u0027)"},{"line_number":791,"context_line":"            raise exception.MissingParameterValue("},{"line_number":792,"context_line":"                msg % {\u0027node\u0027: task.node[\u0027uuid\u0027],"},{"line_number":793,"context_line":"                       \u0027params\u0027: \u0027, \u0027.join(missing_params)})"},{"line_number":794,"context_line":""},{"line_number":795,"context_line":"    @METRICS.timer(\u0027AgentRescue.clean_up\u0027)"}],"source_content_type":"text/x-python","patch_set":40,"id":"ff0f0b1f_be1e086e","line":792,"in_reply_to":"1f013ff3_2279882e","updated":"2017-05-18 07:04:43.000000000","message":"Done","commit_id":"a28c805aee518e10a41a093cb5413cb7a249459f"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"aa216d9faff066f6d221cff22fc5c3491949e165","unresolved":false,"context_lines":[{"line_number":678,"context_line":""},{"line_number":679,"context_line":"           :param task: a TaskManager instance."},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"           :returns: True if network configuration should be updated during"},{"line_number":682,"context_line":"                     rescue/unrescue. False otherwise."},{"line_number":683,"context_line":"           :raises: InstanceRescueFailure if rescue network is the same as a"},{"line_number":684,"context_line":"                    tenant network when using the \"neutron\" network interface."}],"source_content_type":"text/x-python","patch_set":44,"id":"ff0f0b1f_8773e24d","line":681,"range":{"start_line":681,"start_character":21,"end_line":681,"end_character":68},"updated":"2017-05-26 23:13:51.000000000","message":"What network configuration will be updated, or does it just means the network will be switched? i.e. for rescuing process rescue network would be launched. Just unclear with the sentence updating network configuration.","commit_id":"97a8c1120bf1def69a5f3bd7e66f9d464766a1a9"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"6eac8f78bd7d1f778b5f11d6823f9972d52ddb99","unresolved":false,"context_lines":[{"line_number":678,"context_line":""},{"line_number":679,"context_line":"           :param task: a TaskManager instance."},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"           :returns: True if network configuration should be updated during"},{"line_number":682,"context_line":"                     rescue/unrescue. False otherwise."},{"line_number":683,"context_line":"           :raises: InstanceRescueFailure if rescue network is the same as a"},{"line_number":684,"context_line":"                    tenant network when using the \"neutron\" network interface."}],"source_content_type":"text/x-python","patch_set":44,"id":"df140735_ac861265","line":681,"range":{"start_line":681,"start_character":21,"end_line":681,"end_character":68},"in_reply_to":"ff0f0b1f_8773e24d","updated":"2017-06-06 08:44:14.000000000","message":"Yes, return true if the rescue network has to be launched during rescue/unrescue. \nI have reframed the sentence.","commit_id":"97a8c1120bf1def69a5f3bd7e66f9d464766a1a9"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"aa216d9faff066f6d221cff22fc5c3491949e165","unresolved":false,"context_lines":[{"line_number":689,"context_line":"        # NOTE(mariojv) vif_list returns only tenant VIFs, which is what should"},{"line_number":690,"context_line":"        # be checked here"},{"line_number":691,"context_line":"        vifs \u003d [vif[\u0027id\u0027] for vif in task.driver.network.vif_list(task)]"},{"line_number":692,"context_line":"        if not vifs:"},{"line_number":693,"context_line":"            return True"},{"line_number":694,"context_line":"        rescue_network_uuid \u003d task.driver.network.get_rescue_network_uuid()"},{"line_number":695,"context_line":"        for vif in vifs:"},{"line_number":696,"context_line":"            network_for_vif \u003d neutron.get_network_from_port(vif)"}],"source_content_type":"text/x-python","patch_set":44,"id":"ff0f0b1f_e7ca9e4d","line":693,"range":{"start_line":692,"start_character":8,"end_line":693,"end_character":23},"updated":"2017-05-26 23:13:51.000000000","message":"Since I am unclear on what network updating is done, a follow up concern, when no tenant vifs are present then what will network update do as we are returning true in this case. Is this check mentioned for backward compatibility when attach/detach was not supported? I understand return true makes sense if network updating just means appropriate for network change to rescue.","commit_id":"97a8c1120bf1def69a5f3bd7e66f9d464766a1a9"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"6eac8f78bd7d1f778b5f11d6823f9972d52ddb99","unresolved":false,"context_lines":[{"line_number":689,"context_line":"        # NOTE(mariojv) vif_list returns only tenant VIFs, which is what should"},{"line_number":690,"context_line":"        # be checked here"},{"line_number":691,"context_line":"        vifs \u003d [vif[\u0027id\u0027] for vif in task.driver.network.vif_list(task)]"},{"line_number":692,"context_line":"        if not vifs:"},{"line_number":693,"context_line":"            return True"},{"line_number":694,"context_line":"        rescue_network_uuid \u003d task.driver.network.get_rescue_network_uuid()"},{"line_number":695,"context_line":"        for vif in vifs:"},{"line_number":696,"context_line":"            network_for_vif \u003d neutron.get_network_from_port(vif)"}],"source_content_type":"text/x-python","patch_set":44,"id":"df140735_ece40a3e","line":693,"range":{"start_line":692,"start_character":8,"end_line":693,"end_character":23},"in_reply_to":"ff0f0b1f_e7ca9e4d","updated":"2017-06-06 08:44:14.000000000","message":"yes you are right. Network updating is network change for rescue.\nIf no tenants are present we have to return true to configure the rescue network for rescue/unrescue else we are adding a check for tenent network port id with rescue network id as mentioned @673.","commit_id":"97a8c1120bf1def69a5f3bd7e66f9d464766a1a9"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"aa216d9faff066f6d221cff22fc5c3491949e165","unresolved":false,"context_lines":[{"line_number":698,"context_line":"                if task.node.network_interface \u003d\u003d \u0027flat\u0027:"},{"line_number":699,"context_line":"                    return False"},{"line_number":700,"context_line":"                elif task.node.network_interface \u003d\u003d \u0027neutron\u0027:"},{"line_number":701,"context_line":"                    msg \u003d (\"Rescue network %(rescue)s cannot be the same as \""},{"line_number":702,"context_line":"                           \"tenant network %(tenant)s when using neutron \""},{"line_number":703,"context_line":"                           \"network interface.\""},{"line_number":704,"context_line":"                           % {\u0027rescue\u0027: rescue_network_uuid,"}],"source_content_type":"text/x-python","patch_set":44,"id":"ff0f0b1f_c7c79a45","line":701,"range":{"start_line":701,"start_character":20,"end_line":701,"end_character":23},"updated":"2017-05-26 23:13:51.000000000","message":"Should be translated as it is user facing","commit_id":"97a8c1120bf1def69a5f3bd7e66f9d464766a1a9"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"6eac8f78bd7d1f778b5f11d6823f9972d52ddb99","unresolved":false,"context_lines":[{"line_number":698,"context_line":"                if task.node.network_interface \u003d\u003d \u0027flat\u0027:"},{"line_number":699,"context_line":"                    return False"},{"line_number":700,"context_line":"                elif task.node.network_interface \u003d\u003d \u0027neutron\u0027:"},{"line_number":701,"context_line":"                    msg \u003d (\"Rescue network %(rescue)s cannot be the same as \""},{"line_number":702,"context_line":"                           \"tenant network %(tenant)s when using neutron \""},{"line_number":703,"context_line":"                           \"network interface.\""},{"line_number":704,"context_line":"                           % {\u0027rescue\u0027: rescue_network_uuid,"}],"source_content_type":"text/x-python","patch_set":44,"id":"df140735_59a05a42","line":701,"range":{"start_line":701,"start_character":20,"end_line":701,"end_character":23},"in_reply_to":"ff0f0b1f_c7c79a45","updated":"2017-06-06 08:44:14.000000000","message":"Done","commit_id":"97a8c1120bf1def69a5f3bd7e66f9d464766a1a9"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"e131b5ded075751a089e07e1a1bfbd55ee2e3b34","unresolved":false,"context_lines":[{"line_number":711,"context_line":"    @METRICS.timer(\u0027AgentRescue.rescue\u0027)"},{"line_number":712,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":713,"context_line":"    def rescue(self, task):"},{"line_number":714,"context_line":"        \"\"\"Boot a rescue ramdisk on the node.\"\"\""},{"line_number":715,"context_line":"        try:"},{"line_number":716,"context_line":"            manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":717,"context_line":"            task.driver.boot.clean_up_instance(task)"}],"source_content_type":"text/x-python","patch_set":44,"id":"ff0f0b1f_c9140851","line":714,"updated":"2017-05-22 08:08:16.000000000","message":"Missing param definition.","commit_id":"97a8c1120bf1def69a5f3bd7e66f9d464766a1a9"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"6eac8f78bd7d1f778b5f11d6823f9972d52ddb99","unresolved":false,"context_lines":[{"line_number":711,"context_line":"    @METRICS.timer(\u0027AgentRescue.rescue\u0027)"},{"line_number":712,"context_line":"    @task_manager.require_exclusive_lock"},{"line_number":713,"context_line":"    def rescue(self, task):"},{"line_number":714,"context_line":"        \"\"\"Boot a rescue ramdisk on the node.\"\"\""},{"line_number":715,"context_line":"        try:"},{"line_number":716,"context_line":"            manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":717,"context_line":"            task.driver.boot.clean_up_instance(task)"}],"source_content_type":"text/x-python","patch_set":44,"id":"df140735_39dda6df","line":714,"in_reply_to":"ff0f0b1f_c9140851","updated":"2017-06-06 08:44:14.000000000","message":"Done","commit_id":"97a8c1120bf1def69a5f3bd7e66f9d464766a1a9"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"aa216d9faff066f6d221cff22fc5c3491949e165","unresolved":false,"context_lines":[{"line_number":713,"context_line":"    def rescue(self, task):"},{"line_number":714,"context_line":"        \"\"\"Boot a rescue ramdisk on the node.\"\"\""},{"line_number":715,"context_line":"        try:"},{"line_number":716,"context_line":"            manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":717,"context_line":"            task.driver.boot.clean_up_instance(task)"},{"line_number":718,"context_line":"            if self.validate_network_topology(task):"},{"line_number":719,"context_line":"                task.driver.network.unconfigure_tenant_networks(task)"}],"source_content_type":"text/x-python","patch_set":44,"id":"ff0f0b1f_87a76250","line":716,"range":{"start_line":716,"start_character":12,"end_line":716,"end_character":67},"updated":"2017-05-26 23:13:51.000000000","message":"I think there should be a check to see if node is in Active state before putting it into rescue, wdyt?","commit_id":"97a8c1120bf1def69a5f3bd7e66f9d464766a1a9"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"6eac8f78bd7d1f778b5f11d6823f9972d52ddb99","unresolved":false,"context_lines":[{"line_number":713,"context_line":"    def rescue(self, task):"},{"line_number":714,"context_line":"        \"\"\"Boot a rescue ramdisk on the node.\"\"\""},{"line_number":715,"context_line":"        try:"},{"line_number":716,"context_line":"            manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":717,"context_line":"            task.driver.boot.clean_up_instance(task)"},{"line_number":718,"context_line":"            if self.validate_network_topology(task):"},{"line_number":719,"context_line":"                task.driver.network.unconfigure_tenant_networks(task)"}],"source_content_type":"text/x-python","patch_set":44,"id":"df140735_2f2af4d9","line":716,"range":{"start_line":716,"start_character":12,"end_line":716,"end_character":67},"in_reply_to":"ff0f0b1f_87a76250","updated":"2017-06-06 08:44:14.000000000","message":"The check will be done as part of https://github.com/openstack/ironic/blob/master/ironic/api/controllers/v1/node.py#L605. It will return back the error if the state is not active before starting rescue operation.","commit_id":"97a8c1120bf1def69a5f3bd7e66f9d464766a1a9"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"aa216d9faff066f6d221cff22fc5c3491949e165","unresolved":false,"context_lines":[{"line_number":714,"context_line":"        \"\"\"Boot a rescue ramdisk on the node.\"\"\""},{"line_number":715,"context_line":"        try:"},{"line_number":716,"context_line":"            manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":717,"context_line":"            task.driver.boot.clean_up_instance(task)"},{"line_number":718,"context_line":"            if self.validate_network_topology(task):"},{"line_number":719,"context_line":"                task.driver.network.unconfigure_tenant_networks(task)"},{"line_number":720,"context_line":"                task.driver.network.add_rescue_network(task)"}],"source_content_type":"text/x-python","patch_set":44,"id":"ff0f0b1f_6719ee86","line":717,"range":{"start_line":717,"start_character":29,"end_line":717,"end_character":47},"updated":"2017-05-26 23:13:51.000000000","message":"I am not sure, but just came to my mind is there a need to clean up ramdisk? As we will be preparing ramdisk again during the rescue process","commit_id":"97a8c1120bf1def69a5f3bd7e66f9d464766a1a9"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"6eac8f78bd7d1f778b5f11d6823f9972d52ddb99","unresolved":false,"context_lines":[{"line_number":714,"context_line":"        \"\"\"Boot a rescue ramdisk on the node.\"\"\""},{"line_number":715,"context_line":"        try:"},{"line_number":716,"context_line":"            manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":717,"context_line":"            task.driver.boot.clean_up_instance(task)"},{"line_number":718,"context_line":"            if self.validate_network_topology(task):"},{"line_number":719,"context_line":"                task.driver.network.unconfigure_tenant_networks(task)"},{"line_number":720,"context_line":"                task.driver.network.add_rescue_network(task)"}],"source_content_type":"text/x-python","patch_set":44,"id":"df140735_ac6292ac","line":717,"range":{"start_line":717,"start_character":29,"end_line":717,"end_character":47},"in_reply_to":"ff0f0b1f_6719ee86","updated":"2017-06-06 08:44:14.000000000","message":"We are cleaning up the instance related information because we will be using different ramdisk for rescuing.","commit_id":"97a8c1120bf1def69a5f3bd7e66f9d464766a1a9"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"bbd931ed8fff3a1dc4dde7b4c057d5efcf9f4c26","unresolved":false,"context_lines":[{"line_number":729,"context_line":"        for vif in vifs:"},{"line_number":730,"context_line":"            network_for_vif \u003d neutron.get_network_from_port(vif)"},{"line_number":731,"context_line":"            if network_for_vif \u003d\u003d rescue_network_uuid:"},{"line_number":732,"context_line":"                if task.node.network_interface \u003d\u003d \u0027flat\u0027:"},{"line_number":733,"context_line":"                    return False"},{"line_number":734,"context_line":"                elif task.node.network_interface \u003d\u003d \u0027neutron\u0027:"},{"line_number":735,"context_line":"                    msg \u003d (_(\"Rescue network %(rescue)s cannot be the same as \""}],"source_content_type":"text/x-python","patch_set":49,"id":"3f1d235d_3d06fe1e","line":732,"updated":"2017-07-05 06:11:23.000000000","message":"Rather than see names of network interface here, I prefer adding a method to ask if separate network is necessary or not to each network interface for adding a new network interface later.","commit_id":"70bc03c359c27c8c199dda79bf9b159ce88c0ee6"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"bbd931ed8fff3a1dc4dde7b4c057d5efcf9f4c26","unresolved":false,"context_lines":[{"line_number":825,"context_line":"            missing_params.append(\u0027instance_info/rescue_password\u0027)"},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"        if missing_params:"},{"line_number":828,"context_line":"            msg \u003d (\u0027Error validating agent rescue interface. \u0027"},{"line_number":829,"context_line":"                   \u0027Node %(node)s is missing parameter(s): \u0027"},{"line_number":830,"context_line":"                   \u0027%(params)s. These are required for agent rescue.\u0027)"},{"line_number":831,"context_line":"            raise exception.MissingParameterValue("}],"source_content_type":"text/x-python","patch_set":49,"id":"3f1d235d_e0969d4c","line":828,"updated":"2017-07-05 06:11:23.000000000","message":"_() is necessary for an error message.","commit_id":"70bc03c359c27c8c199dda79bf9b159ce88c0ee6"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"922ded665131ec44fa3cc8294b59460f4bace98d","unresolved":false,"context_lines":[{"line_number":825,"context_line":"            missing_params.append(\u0027instance_info/rescue_password\u0027)"},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"        if missing_params:"},{"line_number":828,"context_line":"            msg \u003d (\u0027Error validating agent rescue interface. \u0027"},{"line_number":829,"context_line":"                   \u0027Node %(node)s is missing parameter(s): \u0027"},{"line_number":830,"context_line":"                   \u0027%(params)s. These are required for agent rescue.\u0027)"},{"line_number":831,"context_line":"            raise exception.MissingParameterValue("}],"source_content_type":"text/x-python","patch_set":49,"id":"1f1a1f67_0f4b6f84","line":828,"in_reply_to":"3f1d235d_e0969d4c","updated":"2017-07-13 11:25:23.000000000","message":"Done","commit_id":"70bc03c359c27c8c199dda79bf9b159ce88c0ee6"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"961257c0e38b053668aae3ee84abad5bc7cd54fe","unresolved":false,"context_lines":[{"line_number":725,"context_line":"        # NOTE(mariojv) vif_list returns only tenant VIFs, which is what should"},{"line_number":726,"context_line":"        # be checked here"},{"line_number":727,"context_line":"        vifs \u003d [vif[\u0027id\u0027] for vif in task.driver.network.vif_list(task)]"},{"line_number":728,"context_line":"        if not vifs:"},{"line_number":729,"context_line":"            return True"},{"line_number":730,"context_line":"        rescue_network_uuid \u003d task.driver.network.get_rescue_network_uuid()"},{"line_number":731,"context_line":"        for vif in vifs:"}],"source_content_type":"text/x-python","patch_set":51,"id":"ff346bd7_f8a14997","line":728,"range":{"start_line":728,"start_character":11,"end_line":728,"end_character":19},"updated":"2017-07-21 22:07:04.000000000","message":"shouldn\u0027t here be a check to see if interface is flat or not before returning true? It may happen that interface is flat but the internal_info of port does not have vif_port_id. In that case this will return true when interface is flat","commit_id":"885d936ae5163ad000a0fabb7643f4b2d2fb3b60"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"797eac90108d1d0bee78320e222bbc52a0ddb55b","unresolved":false,"context_lines":[{"line_number":725,"context_line":"        # NOTE(mariojv) vif_list returns only tenant VIFs, which is what should"},{"line_number":726,"context_line":"        # be checked here"},{"line_number":727,"context_line":"        vifs \u003d [vif[\u0027id\u0027] for vif in task.driver.network.vif_list(task)]"},{"line_number":728,"context_line":"        if not vifs:"},{"line_number":729,"context_line":"            return True"},{"line_number":730,"context_line":"        rescue_network_uuid \u003d task.driver.network.get_rescue_network_uuid()"},{"line_number":731,"context_line":"        for vif in vifs:"}],"source_content_type":"text/x-python","patch_set":51,"id":"df3967d1_d6275664","line":728,"range":{"start_line":728,"start_character":11,"end_line":728,"end_character":19},"in_reply_to":"ff346bd7_f8a14997","updated":"2017-07-31 11:44:27.000000000","message":"If the vif is empty, then there is no port attached to that particular node. So we have to configure the network irrespective of the network interface.","commit_id":"885d936ae5163ad000a0fabb7643f4b2d2fb3b60"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"961257c0e38b053668aae3ee84abad5bc7cd54fe","unresolved":false,"context_lines":[{"line_number":733,"context_line":"            if network_for_vif \u003d\u003d rescue_network_uuid:"},{"line_number":734,"context_line":"                if task.node.network_interface \u003d\u003d \u0027flat\u0027:"},{"line_number":735,"context_line":"                    return False"},{"line_number":736,"context_line":"                elif task.node.network_interface \u003d\u003d \u0027neutron\u0027:"},{"line_number":737,"context_line":"                    msg \u003d (_(\"Rescue network %(rescue)s cannot be the same as \""},{"line_number":738,"context_line":"                             \"tenant network %(tenant)s when using neutron \""},{"line_number":739,"context_line":"                             \"network interface.\")"}],"source_content_type":"text/x-python","patch_set":51,"id":"ff346bd7_5b7a8f88","line":736,"range":{"start_line":736,"start_character":31,"end_line":736,"end_character":48},"updated":"2017-07-21 22:07:04.000000000","message":"not sure, but just wondering do you think a need to check for noop interface as well? Or let me put it this way, it will return true when noop interface, is that what is acceptable?","commit_id":"885d936ae5163ad000a0fabb7643f4b2d2fb3b60"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"797eac90108d1d0bee78320e222bbc52a0ddb55b","unresolved":false,"context_lines":[{"line_number":733,"context_line":"            if network_for_vif \u003d\u003d rescue_network_uuid:"},{"line_number":734,"context_line":"                if task.node.network_interface \u003d\u003d \u0027flat\u0027:"},{"line_number":735,"context_line":"                    return False"},{"line_number":736,"context_line":"                elif task.node.network_interface \u003d\u003d \u0027neutron\u0027:"},{"line_number":737,"context_line":"                    msg \u003d (_(\"Rescue network %(rescue)s cannot be the same as \""},{"line_number":738,"context_line":"                             \"tenant network %(tenant)s when using neutron \""},{"line_number":739,"context_line":"                             \"network interface.\")"}],"source_content_type":"text/x-python","patch_set":51,"id":"df3967d1_a1c5aa90","line":736,"range":{"start_line":736,"start_character":31,"end_line":736,"end_character":48},"in_reply_to":"ff346bd7_5b7a8f88","updated":"2017-07-31 11:44:27.000000000","message":"If it is noop network interface, the operator is choosing that no network configuration is needed. So we don\u0027t have to raise the exception. We can silently return True.","commit_id":"885d936ae5163ad000a0fabb7643f4b2d2fb3b60"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"961257c0e38b053668aae3ee84abad5bc7cd54fe","unresolved":false,"context_lines":[{"line_number":750,"context_line":"        \"\"\"Boot a rescue ramdisk on the node."},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"        :param task: a TaskManager instance."},{"line_number":753,"context_line":"        :raises: Exception if there is a failure while resucing a node."},{"line_number":754,"context_line":"        \"\"\""},{"line_number":755,"context_line":"        try:"},{"line_number":756,"context_line":"            manager_utils.node_power_action(task, states.POWER_OFF)"}],"source_content_type":"text/x-python","patch_set":51,"id":"ff346bd7_c1068c21","line":753,"range":{"start_line":753,"start_character":9,"end_line":753,"end_character":26},"updated":"2017-07-21 22:07:04.000000000","message":"nit: must state what type of exception","commit_id":"885d936ae5163ad000a0fabb7643f4b2d2fb3b60"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"797eac90108d1d0bee78320e222bbc52a0ddb55b","unresolved":false,"context_lines":[{"line_number":750,"context_line":"        \"\"\"Boot a rescue ramdisk on the node."},{"line_number":751,"context_line":""},{"line_number":752,"context_line":"        :param task: a TaskManager instance."},{"line_number":753,"context_line":"        :raises: Exception if there is a failure while resucing a node."},{"line_number":754,"context_line":"        \"\"\""},{"line_number":755,"context_line":"        try:"},{"line_number":756,"context_line":"            manager_utils.node_power_action(task, states.POWER_OFF)"}],"source_content_type":"text/x-python","patch_set":51,"id":"df3967d1_c13f8ed4","line":753,"range":{"start_line":753,"start_character":9,"end_line":753,"end_character":26},"in_reply_to":"ff346bd7_c1068c21","updated":"2017-07-31 11:44:27.000000000","message":"Removed the statement since this method is not raising any exception.","commit_id":"885d936ae5163ad000a0fabb7643f4b2d2fb3b60"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"961257c0e38b053668aae3ee84abad5bc7cd54fe","unresolved":false,"context_lines":[{"line_number":764,"context_line":"                task.driver.boot.prepare_ramdisk(task, ramdisk_opts)"},{"line_number":765,"context_line":"            manager_utils.node_power_action(task, states.POWER_ON)"},{"line_number":766,"context_line":"        except Exception as exc:"},{"line_number":767,"context_line":"            LOG.error(\u0027Could not rescue node %(node)s: %(error)s\u0027,"},{"line_number":768,"context_line":"                      {\u0027node\u0027: task.node.uuid,"},{"line_number":769,"context_line":"                       \u0027error\u0027: exc})"},{"line_number":770,"context_line":"            return states.RESCUEFAIL"}],"source_content_type":"text/x-python","patch_set":51,"id":"ff346bd7_67881071","line":767,"range":{"start_line":767,"start_character":12,"end_line":767,"end_character":21},"updated":"2017-07-21 22:07:04.000000000","message":"nit: needs a translation as well","commit_id":"885d936ae5163ad000a0fabb7643f4b2d2fb3b60"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"797eac90108d1d0bee78320e222bbc52a0ddb55b","unresolved":false,"context_lines":[{"line_number":764,"context_line":"                task.driver.boot.prepare_ramdisk(task, ramdisk_opts)"},{"line_number":765,"context_line":"            manager_utils.node_power_action(task, states.POWER_ON)"},{"line_number":766,"context_line":"        except Exception as exc:"},{"line_number":767,"context_line":"            LOG.error(\u0027Could not rescue node %(node)s: %(error)s\u0027,"},{"line_number":768,"context_line":"                      {\u0027node\u0027: task.node.uuid,"},{"line_number":769,"context_line":"                       \u0027error\u0027: exc})"},{"line_number":770,"context_line":"            return states.RESCUEFAIL"}],"source_content_type":"text/x-python","patch_set":51,"id":"df3967d1_274c2a9d","line":767,"range":{"start_line":767,"start_character":12,"end_line":767,"end_character":21},"in_reply_to":"ff346bd7_67881071","updated":"2017-07-31 11:44:27.000000000","message":"I think we are using translation only for \u0027exception\u0027.","commit_id":"885d936ae5163ad000a0fabb7643f4b2d2fb3b60"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"f8420bdfc0808ced4c2ce23aeb97609ddbc4c064","unresolved":false,"context_lines":[{"line_number":804,"context_line":""},{"line_number":805,"context_line":"    @METRICS.timer(\u0027AgentRescue.validate\u0027)"},{"line_number":806,"context_line":"    def validate(self, task):"},{"line_number":807,"context_line":"        \"\"\"Validate that node has required properties for agent rescue."},{"line_number":808,"context_line":""},{"line_number":809,"context_line":"        :param task: a TaskManager instance with the node being checked"},{"line_number":810,"context_line":"        :raises: MissingParameterValue if node is missing one or more required"}],"source_content_type":"text/x-python","patch_set":52,"id":"df3967d1_ea6470e7","line":807,"range":{"start_line":807,"start_character":25,"end_line":807,"end_character":29},"updated":"2017-08-01 21:42:12.000000000","message":"nit: s/the node/node","commit_id":"1c05f9a6a09e041be7aec72186fa91e1aeca4a0c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4c87c0b4843b158587225810f4a65c4c1565a050","unresolved":false,"context_lines":[{"line_number":804,"context_line":""},{"line_number":805,"context_line":"    @METRICS.timer(\u0027AgentRescue.validate\u0027)"},{"line_number":806,"context_line":"    def validate(self, task):"},{"line_number":807,"context_line":"        \"\"\"Validate that node has required properties for agent rescue."},{"line_number":808,"context_line":""},{"line_number":809,"context_line":"        :param task: a TaskManager instance with the node being checked"},{"line_number":810,"context_line":"        :raises: MissingParameterValue if node is missing one or more required"}],"source_content_type":"text/x-python","patch_set":52,"id":"7f287b81_d98a5d68","line":807,"range":{"start_line":807,"start_character":25,"end_line":807,"end_character":29},"in_reply_to":"df3967d1_ea6470e7","updated":"2017-08-29 08:12:10.000000000","message":"Done","commit_id":"1c05f9a6a09e041be7aec72186fa91e1aeca4a0c"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"5e473bc966e5448075f0bea2a54e6433a925a763","unresolved":false,"context_lines":[{"line_number":743,"context_line":"                              \u0027tenant\u0027: network_for_vif})"},{"line_number":744,"context_line":"                    raise exception.InstanceRescueFailure("},{"line_number":745,"context_line":"                        node\u003dtask.node.uuid,"},{"line_number":746,"context_line":"                        reason\u003dmsg)"},{"line_number":747,"context_line":"        return True"},{"line_number":748,"context_line":""},{"line_number":749,"context_line":"    @METRICS.timer(\u0027AgentRescue.rescue\u0027)"}],"source_content_type":"text/x-python","patch_set":55,"id":"5f2577a7_2bee1e22","line":746,"updated":"2017-09-12 08:11:13.000000000","message":"What would be the else case of L735. I think one case is missing here:\n\nWhen network_for_vif is not equal to rescue_network_uuid and network_interface is neutron, we should return false here. Right?\n\nNot sure if this case is valid or not.","commit_id":"d983b5033a30862b85e6b5d279030d7685f1c0ad"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"7fc19bb41f756ea20037e39a3c8374be0df50c81","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    \u0027rescue_kernel\u0027: _(\u0027UUID (from Glance) of the rescue kernel. This value \u0027"},{"line_number":61,"context_line":"                       \u0027is required for rescue mode. Optional.\u0027),"},{"line_number":62,"context_line":"    \u0027rescue_ramdisk\u0027: _(\u0027UUID (from Glance) of the rescue ramdisk. This value \u0027"},{"line_number":63,"context_line":"                        \u0027is required for rescue mode. Optional.\u0027)"},{"line_number":64,"context_line":"}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"COMMON_PROPERTIES \u003d REQUIRED_PROPERTIES.copy()"}],"source_content_type":"text/x-python","patch_set":62,"id":"3f4b6375_637940c6","line":63,"range":{"start_line":63,"start_character":64,"end_line":63,"end_character":65},"updated":"2017-12-20 12:22:54.000000000","message":"nit: append a comma","commit_id":"64b56828545c6d9cc2b84baf2925e72bc4ceb3ce"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7582118339d8717569b08cc8effe0881a4265658","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    \u0027rescue_kernel\u0027: _(\u0027UUID (from Glance) of the rescue kernel. This value \u0027"},{"line_number":61,"context_line":"                       \u0027is required for rescue mode. Optional.\u0027),"},{"line_number":62,"context_line":"    \u0027rescue_ramdisk\u0027: _(\u0027UUID (from Glance) of the rescue ramdisk. This value \u0027"},{"line_number":63,"context_line":"                        \u0027is required for rescue mode. Optional.\u0027)"},{"line_number":64,"context_line":"}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"COMMON_PROPERTIES \u003d REQUIRED_PROPERTIES.copy()"}],"source_content_type":"text/x-python","patch_set":62,"id":"bf8cb3f7_2398d468","line":63,"range":{"start_line":63,"start_character":64,"end_line":63,"end_character":65},"in_reply_to":"3f4b6375_637940c6","updated":"2017-12-20 14:07:08.000000000","message":"Done","commit_id":"64b56828545c6d9cc2b84baf2925e72bc4ceb3ce"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"c5af1cd0d67c914ff73ef7f3d630b9ac0479fb26","unresolved":false,"context_lines":[{"line_number":700,"context_line":"class AgentRescue(base.RescueInterface):"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"    @METRICS.timer(\u0027AgentRescue.validate_network_topology\u0027)"},{"line_number":703,"context_line":"    def validate_network_topology(self, task):"},{"line_number":704,"context_line":"        \"\"\"Ensure that proposed network config is appropriate for rescue."},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"           In the flat network case, if the tenant network on this node\u0027s ports"}],"source_content_type":"text/x-python","patch_set":65,"id":"1f485f77_0a0688cf","line":703,"updated":"2017-11-15 07:11:43.000000000","message":"nit: This name is slightly confusing because returning false doesn\u0027t mean an error.","commit_id":"f2c85cafb0e6e881b22392e26cb74f1a02fee702"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1c2233241c3a7bba8740ce4578ad55461776f846","unresolved":false,"context_lines":[{"line_number":700,"context_line":"class AgentRescue(base.RescueInterface):"},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"    @METRICS.timer(\u0027AgentRescue.validate_network_topology\u0027)"},{"line_number":703,"context_line":"    def validate_network_topology(self, task):"},{"line_number":704,"context_line":"        \"\"\"Ensure that proposed network config is appropriate for rescue."},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"           In the flat network case, if the tenant network on this node\u0027s ports"}],"source_content_type":"text/x-python","patch_set":65,"id":"1f485f77_48aa3b71","line":703,"in_reply_to":"1f485f77_0a0688cf","updated":"2017-11-15 17:47:52.000000000","message":"This method is not required.","commit_id":"f2c85cafb0e6e881b22392e26cb74f1a02fee702"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"7af929aa11dcc4a6d7740e2fe0cce5701a27a7d3","unresolved":false,"context_lines":[{"line_number":729,"context_line":"        vifs \u003d [vif[\u0027id\u0027] for vif in task.driver.network.vif_list(task)]"},{"line_number":730,"context_line":"        if not vifs:"},{"line_number":731,"context_line":"            return True"},{"line_number":732,"context_line":"        rescue_network_uuid \u003d task.driver.network.get_rescue_network_uuid()"},{"line_number":733,"context_line":"        for vif in vifs:"},{"line_number":734,"context_line":"            network_for_vif \u003d neutron.get_network_from_port(vif)"},{"line_number":735,"context_line":"            if network_for_vif \u003d\u003d rescue_network_uuid:"}],"source_content_type":"text/x-python","patch_set":65,"id":"1f485f77_2a7ca4b3","line":732,"updated":"2017-11-15 07:35:06.000000000","message":"It doesn\u0027t look very good to call this method because this is not defined in base.NetworkInterface though this line is unreachable for the noop interface, whose vif_list() returns [].","commit_id":"f2c85cafb0e6e881b22392e26cb74f1a02fee702"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"c5af1cd0d67c914ff73ef7f3d630b9ac0479fb26","unresolved":false,"context_lines":[{"line_number":733,"context_line":"        for vif in vifs:"},{"line_number":734,"context_line":"            network_for_vif \u003d neutron.get_network_from_port(vif)"},{"line_number":735,"context_line":"            if network_for_vif \u003d\u003d rescue_network_uuid:"},{"line_number":736,"context_line":"                if task.node.network_interface \u003d\u003d \u0027flat\u0027:"},{"line_number":737,"context_line":"                    return False"},{"line_number":738,"context_line":"                elif task.node.network_interface \u003d\u003d \u0027neutron\u0027:"},{"line_number":739,"context_line":"                    msg \u003d (_(\"Rescue network %(rescue)s cannot be the same as \""}],"source_content_type":"text/x-python","patch_set":65,"id":"1f485f77_2ae26430","line":736,"updated":"2017-11-15 07:11:43.000000000","message":"Rather than seeing the name of a network interface here, I prefer defining a method to ask if separate network is necessary or not to the network interface. This would be helpful when adding a new network interface not to forget to consider here.","commit_id":"f2c85cafb0e6e881b22392e26cb74f1a02fee702"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"a32f6867507042a71f7fdaf350ed1f81a58a4186","unresolved":false,"context_lines":[{"line_number":822,"context_line":"                if task.node.driver_info.get(req) is None:"},{"line_number":823,"context_line":"                    missing_params.append(\u0027driver_info/\u0027 + req)"},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"        if task.node.instance_info.get(\u0027rescue_password\u0027) is None:"},{"line_number":826,"context_line":"            missing_params.append(\u0027instance_info/rescue_password\u0027)"},{"line_number":827,"context_line":""},{"line_number":828,"context_line":"        if missing_params:"}],"source_content_type":"text/x-python","patch_set":65,"id":"3f4b6375_16fbdd46","line":825,"updated":"2017-11-07 13:30:58.000000000","message":"I don\u0027t think rescue_password should be checked here. A rescue password is passed as an argument of the rescue API (changing provision state). A node validation API may be called before the rescue request. In this case, this check always fails since a rescue password is not set yet.","commit_id":"f2c85cafb0e6e881b22392e26cb74f1a02fee702"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1c2233241c3a7bba8740ce4578ad55461776f846","unresolved":false,"context_lines":[{"line_number":822,"context_line":"                if task.node.driver_info.get(req) is None:"},{"line_number":823,"context_line":"                    missing_params.append(\u0027driver_info/\u0027 + req)"},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"        if task.node.instance_info.get(\u0027rescue_password\u0027) is None:"},{"line_number":826,"context_line":"            missing_params.append(\u0027instance_info/rescue_password\u0027)"},{"line_number":827,"context_line":""},{"line_number":828,"context_line":"        if missing_params:"}],"source_content_type":"text/x-python","patch_set":65,"id":"3f4b6375_5e1efc6f","line":825,"in_reply_to":"3f4b6375_16fbdd46","updated":"2017-11-15 17:47:52.000000000","message":"Yes, you are right. This check is not required. It would be checked in API call.","commit_id":"f2c85cafb0e6e881b22392e26cb74f1a02fee702"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"8a89b7d1ca8677ff0885323f75105072769687df","unresolved":false,"context_lines":[{"line_number":797,"context_line":"        if CONF.agent.manage_agent_boot:"},{"line_number":798,"context_line":"            task.driver.boot.clean_up_ramdisk(task)"},{"line_number":799,"context_line":""},{"line_number":800,"context_line":"        manager_utils.remove_node_rescue_password(task, save\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":66,"id":"1f485f77_7f90fded","line":800,"updated":"2017-11-16 03:22:05.000000000","message":"Referring to code of cleaning[1], we would need to switch networks from the rescue network to the tenant network here.\n\nI also wonder if we would power off the node when rescue fails. If powering off, this method will get unavailable when rescue succeeds.\n\n[1] https://github.com/openstack/ironic/blob/308e414a57941675acf6cd825daafc653cf5927e/ironic/drivers/modules/deploy_utils.py#L996","commit_id":"92e09b8ce62c1481af6b12aca68a9f8cfe27d05f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"c2066d9b01808feabc5ce8ccd151449fcb935dfe","unresolved":false,"context_lines":[{"line_number":797,"context_line":"        if CONF.agent.manage_agent_boot:"},{"line_number":798,"context_line":"            task.driver.boot.clean_up_ramdisk(task)"},{"line_number":799,"context_line":""},{"line_number":800,"context_line":"        manager_utils.remove_node_rescue_password(task, save\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":66,"id":"1f485f77_854eb56c","line":800,"in_reply_to":"1f485f77_7f90fded","updated":"2017-11-21 06:05:07.000000000","message":"We dont switch networks here, instead we do it at all the places where this method is being called. \nAlso we donot want to power off the node, as you rightly pointed out. Its required to be in power on state in rescue success. I think we should switch off in case of timeout/failure. We can handle that in a later patch.","commit_id":"92e09b8ce62c1481af6b12aca68a9f8cfe27d05f"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"a15de37ef022e76e362ae56b1eea6076b0a029f8","unresolved":false,"context_lines":[{"line_number":773,"context_line":""},{"line_number":774,"context_line":"    @METRICS.timer(\u0027AgentRescue.validate\u0027)"},{"line_number":775,"context_line":"    def validate(self, task):"},{"line_number":776,"context_line":"        \"\"\"Validate the node has required properties for agent rescue."},{"line_number":777,"context_line":""},{"line_number":778,"context_line":"        :param task: a TaskManager instance with the node being checked"},{"line_number":779,"context_line":"        :raises: MissingParameterValue if node is missing one or more required"}],"source_content_type":"text/x-python","patch_set":68,"id":"ff82abbf_0f6d8303","line":776,"range":{"start_line":776,"start_character":11,"end_line":776,"end_character":19},"updated":"2017-11-21 16:10:55.000000000","message":"s/Validate/Validate that","commit_id":"205926b739f9f9d6e2135090677aeafa7f75f147"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"075da2894b98641ebc44f6508c7f9f4bff729cfb","unresolved":false,"context_lines":[{"line_number":773,"context_line":""},{"line_number":774,"context_line":"    @METRICS.timer(\u0027AgentRescue.validate\u0027)"},{"line_number":775,"context_line":"    def validate(self, task):"},{"line_number":776,"context_line":"        \"\"\"Validate the node has required properties for agent rescue."},{"line_number":777,"context_line":""},{"line_number":778,"context_line":"        :param task: a TaskManager instance with the node being checked"},{"line_number":779,"context_line":"        :raises: MissingParameterValue if node is missing one or more required"}],"source_content_type":"text/x-python","patch_set":68,"id":"ff82abbf_612650d1","line":776,"range":{"start_line":776,"start_character":11,"end_line":776,"end_character":19},"in_reply_to":"ff82abbf_0f6d8303","updated":"2017-12-03 16:40:27.000000000","message":"Done","commit_id":"205926b739f9f9d6e2135090677aeafa7f75f147"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"a15de37ef022e76e362ae56b1eea6076b0a029f8","unresolved":false,"context_lines":[{"line_number":799,"context_line":"        \"\"\"Clean up after RESCUEWAIT timeout/failure or finishing rescue."},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"        Rescue password should be removed from the node and ramdisk boot"},{"line_number":802,"context_line":"        environment should be cleaned if ironic\u0027s managing the ramdisk boot."},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"        :param task: a TaskManager instance with the node that timed out."},{"line_number":805,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":68,"id":"ff82abbf_cf76bbd9","line":802,"range":{"start_line":802,"start_character":41,"end_line":802,"end_character":47},"updated":"2017-11-21 16:10:55.000000000","message":"s/ironic/Ironic","commit_id":"205926b739f9f9d6e2135090677aeafa7f75f147"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"075da2894b98641ebc44f6508c7f9f4bff729cfb","unresolved":false,"context_lines":[{"line_number":799,"context_line":"        \"\"\"Clean up after RESCUEWAIT timeout/failure or finishing rescue."},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"        Rescue password should be removed from the node and ramdisk boot"},{"line_number":802,"context_line":"        environment should be cleaned if ironic\u0027s managing the ramdisk boot."},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"        :param task: a TaskManager instance with the node that timed out."},{"line_number":805,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":68,"id":"ff82abbf_41546c21","line":802,"range":{"start_line":802,"start_character":41,"end_line":802,"end_character":47},"in_reply_to":"ff82abbf_cf76bbd9","updated":"2017-12-03 16:40:27.000000000","message":"Done","commit_id":"205926b739f9f9d6e2135090677aeafa7f75f147"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6480163bc034276ee9b0ce674c90994fce9ace3e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    \u0027rescue_kernel\u0027: _(\u0027UUID (from Glance) of the rescue kernel. This value \u0027"},{"line_number":63,"context_line":"                       \u0027is required for rescue mode. Optional.\u0027),"},{"line_number":64,"context_line":"    \u0027rescue_ramdisk\u0027: _(\u0027UUID (from Glance) of the rescue ramdisk. This value \u0027"},{"line_number":65,"context_line":"                        \u0027is required for rescue mode. Optional.\u0027),"},{"line_number":66,"context_line":"}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"COMMON_PROPERTIES \u003d REQUIRED_PROPERTIES.copy()"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff82abbf_de4faf68","line":65,"updated":"2017-11-28 21:56:09.000000000","message":"We should delete the \u0027Optional.\u0027 part in both of these strings, because they are required for rescue mode. Putting \u0027Optional\u0027 makes it confusing.","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"075da2894b98641ebc44f6508c7f9f4bff729cfb","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    \u0027rescue_kernel\u0027: _(\u0027UUID (from Glance) of the rescue kernel. This value \u0027"},{"line_number":63,"context_line":"                       \u0027is required for rescue mode. Optional.\u0027),"},{"line_number":64,"context_line":"    \u0027rescue_ramdisk\u0027: _(\u0027UUID (from Glance) of the rescue ramdisk. This value \u0027"},{"line_number":65,"context_line":"                        \u0027is required for rescue mode. Optional.\u0027),"},{"line_number":66,"context_line":"}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"COMMON_PROPERTIES \u003d REQUIRED_PROPERTIES.copy()"}],"source_content_type":"text/x-python","patch_set":69,"id":"df87a7cf_36ffae68","line":65,"in_reply_to":"ff82abbf_de4faf68","updated":"2017-12-03 16:40:27.000000000","message":"Done","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6480163bc034276ee9b0ce674c90994fce9ace3e","unresolved":false,"context_lines":[{"line_number":468,"context_line":"                # as we do not need to boot the agent to deploy."},{"line_number":469,"context_line":"                return"},{"line_number":470,"context_line":"        if node.provision_state \u003d\u003d states.ACTIVE:"},{"line_number":471,"context_line":"            # Call is due to conductor takeover"},{"line_number":472,"context_line":"            task.driver.boot.prepare_instance(task)"},{"line_number":473,"context_line":"        elif node.provision_state !\u003d states.ADOPTING:"},{"line_number":474,"context_line":"            node.instance_info \u003d deploy_utils.build_instance_info_for_deploy("}],"source_content_type":"text/x-python","patch_set":69,"id":"ff82abbf_01a7f6be","line":471,"updated":"2017-11-28 21:56:09.000000000","message":"hmm. have we taken care of the case of conductor takeover when the node is in one of the rescue states?","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"075da2894b98641ebc44f6508c7f9f4bff729cfb","unresolved":false,"context_lines":[{"line_number":468,"context_line":"                # as we do not need to boot the agent to deploy."},{"line_number":469,"context_line":"                return"},{"line_number":470,"context_line":"        if node.provision_state \u003d\u003d states.ACTIVE:"},{"line_number":471,"context_line":"            # Call is due to conductor takeover"},{"line_number":472,"context_line":"            task.driver.boot.prepare_instance(task)"},{"line_number":473,"context_line":"        elif node.provision_state !\u003d states.ADOPTING:"},{"line_number":474,"context_line":"            node.instance_info \u003d deploy_utils.build_instance_info_for_deploy("}],"source_content_type":"text/x-python","patch_set":69,"id":"df87a7cf_c31eb46f","line":471,"in_reply_to":"ff82abbf_01a7f6be","updated":"2017-12-03 16:40:27.000000000","message":"Done","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6480163bc034276ee9b0ce674c90994fce9ace3e","unresolved":false,"context_lines":[{"line_number":758,"context_line":"        # If a node never entered RESCUE state, there might still be a"},{"line_number":759,"context_line":"        # ramdisk configuration set up. Clean up ramdisk config on"},{"line_number":760,"context_line":"        # conductor and make sure networks are appropriately switched back"},{"line_number":761,"context_line":"        # to tenant in this case."},{"line_number":762,"context_line":"        node_state \u003d task.node.provision_state"},{"line_number":763,"context_line":"        if node_state !\u003d states.RESCUE and CONF.agent.manage_agent_boot:"},{"line_number":764,"context_line":"            task.driver.boot.clean_up_ramdisk(task)"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff82abbf_614da23c","line":761,"updated":"2017-11-28 21:56:09.000000000","message":"this comment doesn\u0027t jive with the code below. Are you only cleaning up the ramdisk if node is not in RESCUE, and you do the remove_rescue_network \u0026 add tenant network regardless, or did you only want to do the network stuff if node is not in RESCUE state?","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"075da2894b98641ebc44f6508c7f9f4bff729cfb","unresolved":false,"context_lines":[{"line_number":758,"context_line":"        # If a node never entered RESCUE state, there might still be a"},{"line_number":759,"context_line":"        # ramdisk configuration set up. Clean up ramdisk config on"},{"line_number":760,"context_line":"        # conductor and make sure networks are appropriately switched back"},{"line_number":761,"context_line":"        # to tenant in this case."},{"line_number":762,"context_line":"        node_state \u003d task.node.provision_state"},{"line_number":763,"context_line":"        if node_state !\u003d states.RESCUE and CONF.agent.manage_agent_boot:"},{"line_number":764,"context_line":"            task.driver.boot.clean_up_ramdisk(task)"}],"source_content_type":"text/x-python","patch_set":69,"id":"df87a7cf_2fcf4780","line":761,"in_reply_to":"ff82abbf_614da23c","updated":"2017-12-03 16:40:27.000000000","message":"Done. When node moves into the RESCUE state, _finalize_rescue() would call boot.clean_up_ramdisk() rescue network is removed and tenant network configured. In RESCUEWAIT or RESCUEFAIL state, node would have rescue ramdisk and rescue network configured.","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6480163bc034276ee9b0ce674c90994fce9ace3e","unresolved":false,"context_lines":[{"line_number":782,"context_line":"        \"\"\""},{"line_number":783,"context_line":"        missing_params \u003d []"},{"line_number":784,"context_line":"        if CONF.agent.manage_agent_boot:"},{"line_number":785,"context_line":"            required_in_driver_info \u003d [\u0027rescue_ramdisk\u0027, \u0027rescue_kernel\u0027]"},{"line_number":786,"context_line":"            for req in required_in_driver_info:"},{"line_number":787,"context_line":"                if task.node.driver_info.get(req) is None:"},{"line_number":788,"context_line":"                    missing_params.append(\u0027driver_info/\u0027 + req)"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff82abbf_3e67bbb9","line":785,"updated":"2017-11-28 21:56:09.000000000","message":"these are above in RESCUE_PROPERTIES.","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"075da2894b98641ebc44f6508c7f9f4bff729cfb","unresolved":false,"context_lines":[{"line_number":782,"context_line":"        \"\"\""},{"line_number":783,"context_line":"        missing_params \u003d []"},{"line_number":784,"context_line":"        if CONF.agent.manage_agent_boot:"},{"line_number":785,"context_line":"            required_in_driver_info \u003d [\u0027rescue_ramdisk\u0027, \u0027rescue_kernel\u0027]"},{"line_number":786,"context_line":"            for req in required_in_driver_info:"},{"line_number":787,"context_line":"                if task.node.driver_info.get(req) is None:"},{"line_number":788,"context_line":"                    missing_params.append(\u0027driver_info/\u0027 + req)"}],"source_content_type":"text/x-python","patch_set":69,"id":"df87a7cf_4f940b8c","line":785,"in_reply_to":"ff82abbf_3e67bbb9","updated":"2017-12-03 16:40:27.000000000","message":"Done","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6480163bc034276ee9b0ce674c90994fce9ace3e","unresolved":false,"context_lines":[{"line_number":788,"context_line":"                    missing_params.append(\u0027driver_info/\u0027 + req)"},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"        if missing_params:"},{"line_number":791,"context_line":"            msg \u003d _(\u0027Error validating agent rescue interface. \u0027"},{"line_number":792,"context_line":"                    \u0027Node %(node)s is missing parameter(s): \u0027"},{"line_number":793,"context_line":"                    \u0027%(params)s. These are required for agent rescue.\u0027)"},{"line_number":794,"context_line":"            raise exception.MissingParameterValue("}],"source_content_type":"text/x-python","patch_set":69,"id":"ff82abbf_fe65d3b5","line":791,"updated":"2017-11-28 21:56:09.000000000","message":"I don\u0027t recall any error msgs mentioning that the error is in validating... but then, I am not going to go through the code to verify whether there are or aren\u0027t.\n\nI think it might be sufficient to just say \u0027Node .. is missing parameters .. They are required for rescuing the node.\u0027","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"075da2894b98641ebc44f6508c7f9f4bff729cfb","unresolved":false,"context_lines":[{"line_number":788,"context_line":"                    missing_params.append(\u0027driver_info/\u0027 + req)"},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"        if missing_params:"},{"line_number":791,"context_line":"            msg \u003d _(\u0027Error validating agent rescue interface. \u0027"},{"line_number":792,"context_line":"                    \u0027Node %(node)s is missing parameter(s): \u0027"},{"line_number":793,"context_line":"                    \u0027%(params)s. These are required for agent rescue.\u0027)"},{"line_number":794,"context_line":"            raise exception.MissingParameterValue("}],"source_content_type":"text/x-python","patch_set":69,"id":"df87a7cf_ef907f98","line":791,"in_reply_to":"ff82abbf_fe65d3b5","updated":"2017-12-03 16:40:27.000000000","message":"Done","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6480163bc034276ee9b0ce674c90994fce9ace3e","unresolved":false,"context_lines":[{"line_number":793,"context_line":"                    \u0027%(params)s. These are required for agent rescue.\u0027)"},{"line_number":794,"context_line":"            raise exception.MissingParameterValue("},{"line_number":795,"context_line":"                msg % {\u0027node\u0027: task.node.uuid,"},{"line_number":796,"context_line":"                       \u0027params\u0027: \u0027, \u0027.join(missing_params)})"},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"    @METRICS.timer(\u0027AgentRescue.clean_up\u0027)"},{"line_number":799,"context_line":"    def clean_up(self, task):"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff82abbf_1eaaf717","line":796,"updated":"2017-11-28 21:56:09.000000000","message":"I thought i saw some code somewhere, that assumed that the password had to be in node.instance_info[\u0027password\u0027]. If so, maybe that should be checked here?","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"075da2894b98641ebc44f6508c7f9f4bff729cfb","unresolved":false,"context_lines":[{"line_number":793,"context_line":"                    \u0027%(params)s. These are required for agent rescue.\u0027)"},{"line_number":794,"context_line":"            raise exception.MissingParameterValue("},{"line_number":795,"context_line":"                msg % {\u0027node\u0027: task.node.uuid,"},{"line_number":796,"context_line":"                       \u0027params\u0027: \u0027, \u0027.join(missing_params)})"},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"    @METRICS.timer(\u0027AgentRescue.clean_up\u0027)"},{"line_number":799,"context_line":"    def clean_up(self, task):"}],"source_content_type":"text/x-python","patch_set":69,"id":"df87a7cf_0f8e0378","line":796,"in_reply_to":"ff82abbf_1eaaf717","updated":"2017-12-03 16:40:27.000000000","message":"Done","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6480163bc034276ee9b0ce674c90994fce9ace3e","unresolved":false,"context_lines":[{"line_number":802,"context_line":"        Rescue password should be removed from the node and ramdisk boot"},{"line_number":803,"context_line":"        environment should be cleaned if Ironic is managing the ramdisk boot."},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"        :param task: a TaskManager instance with the node that timed out."},{"line_number":806,"context_line":"        \"\"\""},{"line_number":807,"context_line":"        if CONF.agent.manage_agent_boot:"},{"line_number":808,"context_line":"            task.driver.boot.clean_up_ramdisk(task)"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff82abbf_be10ab01","line":805,"updated":"2017-11-28 21:56:09.000000000","message":"s/node that timed out/node/\n\nbecause it may not have timed out.","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"075da2894b98641ebc44f6508c7f9f4bff729cfb","unresolved":false,"context_lines":[{"line_number":802,"context_line":"        Rescue password should be removed from the node and ramdisk boot"},{"line_number":803,"context_line":"        environment should be cleaned if Ironic is managing the ramdisk boot."},{"line_number":804,"context_line":""},{"line_number":805,"context_line":"        :param task: a TaskManager instance with the node that timed out."},{"line_number":806,"context_line":"        \"\"\""},{"line_number":807,"context_line":"        if CONF.agent.manage_agent_boot:"},{"line_number":808,"context_line":"            task.driver.boot.clean_up_ramdisk(task)"}],"source_content_type":"text/x-python","patch_set":69,"id":"df87a7cf_6ff22f09","line":805,"in_reply_to":"ff82abbf_be10ab01","updated":"2017-12-03 16:40:27.000000000","message":"Done","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"05c4ce78b52bbb7b40e4b89d32081e9600cb7639","unresolved":false,"context_lines":[{"line_number":788,"context_line":"                    missing_params.append(\u0027driver_info/\u0027 + req)"},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"        if task.node.instance_info.get(\u0027rescue_password\u0027) is None:"},{"line_number":791,"context_line":"            missing_params.append(\u0027instance_info/rescue_password\u0027)"},{"line_number":792,"context_line":""},{"line_number":793,"context_line":"        if missing_params:"},{"line_number":794,"context_line":"            msg \u003d _(\u0027Node %(node)s is missing parameter(s): \u0027"}],"source_content_type":"text/x-python","patch_set":72,"id":"df87a7cf_4996f5f2","line":791,"updated":"2017-12-06 06:54:43.000000000","message":"As far as the rescue password is passed at the same time when the rescue is required by changing provision state, an independent nova validation request (GET /v1/nodes/{node_ident}/validate) doesn\u0027t succeed. Is it acceptable?","commit_id":"31a2d83f23b5fbfbed7028a366e95721d61afa90"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d042c7cecae5000b7b6653fa18fea9678cd671a0","unresolved":false,"context_lines":[{"line_number":788,"context_line":"                    missing_params.append(\u0027driver_info/\u0027 + req)"},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"        if task.node.instance_info.get(\u0027rescue_password\u0027) is None:"},{"line_number":791,"context_line":"            missing_params.append(\u0027instance_info/rescue_password\u0027)"},{"line_number":792,"context_line":""},{"line_number":793,"context_line":"        if missing_params:"},{"line_number":794,"context_line":"            msg \u003d _(\u0027Node %(node)s is missing parameter(s): \u0027"}],"source_content_type":"text/x-python","patch_set":72,"id":"df87a7cf_6cbbb90d","line":791,"in_reply_to":"df87a7cf_4996f5f2","updated":"2017-12-06 15:44:03.000000000","message":"Yes that is true. We do not differentiate validate call based on provision state. It is true for deploy and boot interfaces where we check for the instance_info data for images in validate() call which may not present if node is not being provisioned.\nhttps://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L449","commit_id":"31a2d83f23b5fbfbed7028a366e95721d61afa90"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"05c4ce78b52bbb7b40e4b89d32081e9600cb7639","unresolved":false,"context_lines":[{"line_number":799,"context_line":""},{"line_number":800,"context_line":"    @METRICS.timer(\u0027AgentRescue.clean_up\u0027)"},{"line_number":801,"context_line":"    def clean_up(self, task):"},{"line_number":802,"context_line":"        \"\"\"Clean up after RESCUEWAIT timeout/failure or finishing rescue."},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"        Rescue password should be removed from the node and ramdisk boot"},{"line_number":805,"context_line":"        environment should be cleaned if Ironic is managing the ramdisk boot."}],"source_content_type":"text/x-python","patch_set":72,"id":"df87a7cf_a92a218d","line":802,"updated":"2017-12-06 06:54:43.000000000","message":"It would be better to power off the node in cases of error to prevent the node from an unexpected behavior. I prefer adding another method for finishing rescue normally with sharing codes.","commit_id":"31a2d83f23b5fbfbed7028a366e95721d61afa90"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d042c7cecae5000b7b6653fa18fea9678cd671a0","unresolved":false,"context_lines":[{"line_number":799,"context_line":""},{"line_number":800,"context_line":"    @METRICS.timer(\u0027AgentRescue.clean_up\u0027)"},{"line_number":801,"context_line":"    def clean_up(self, task):"},{"line_number":802,"context_line":"        \"\"\"Clean up after RESCUEWAIT timeout/failure or finishing rescue."},{"line_number":803,"context_line":""},{"line_number":804,"context_line":"        Rescue password should be removed from the node and ramdisk boot"},{"line_number":805,"context_line":"        environment should be cleaned if Ironic is managing the ramdisk boot."}],"source_content_type":"text/x-python","patch_set":72,"id":"df87a7cf_d7285b35","line":802,"in_reply_to":"df87a7cf_a92a218d","updated":"2017-12-06 15:44:03.000000000","message":"Its not being done here and caller would perform the power off if required.","commit_id":"31a2d83f23b5fbfbed7028a366e95721d61afa90"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"10904c17e8bfb21df6e4d4fac23285fac9e93680","unresolved":false,"context_lines":[{"line_number":732,"context_line":"        manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":733,"context_line":"        task.driver.boot.clean_up_instance(task)"},{"line_number":734,"context_line":"        task.driver.network.unconfigure_tenant_networks(task)"},{"line_number":735,"context_line":"        task.driver.network.add_rescue_network(task)"},{"line_number":736,"context_line":"        if CONF.agent.manage_agent_boot:"},{"line_number":737,"context_line":"            ramdisk_opts \u003d deploy_utils.build_agent_options(task.node)"},{"line_number":738,"context_line":"            # prepare_ramdisk will set the boot device"}],"source_content_type":"text/x-python","patch_set":76,"id":"df87a7cf_8e7e1a17","line":735,"range":{"start_line":735,"start_character":27,"end_line":735,"end_character":46},"updated":"2017-12-18 16:53:48.000000000","message":"This method was renamed to add_rescuing_network.","commit_id":"b7bf4204f5b3c54e58079598c095e021188d0780"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c7ca39ec5bdbb13f0642747215ecef08aa5bbc58","unresolved":false,"context_lines":[{"line_number":61,"context_line":"RESCUE_PROPERTIES \u003d {"},{"line_number":62,"context_line":"    \u0027rescue_kernel\u0027: _(\u0027UUID (from Glance) of the rescue kernel. This value \u0027"},{"line_number":63,"context_line":"                       \u0027is required for rescue mode.\u0027),"},{"line_number":64,"context_line":"    \u0027rescue_ramdisk\u0027: _(\u0027UUID (from Glance) of the rescue ramdisk. This value \u0027"},{"line_number":65,"context_line":"                        \u0027is required for rescue mode.\u0027),"},{"line_number":66,"context_line":"}"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":77,"id":"bf8cb3f7_fb44c8b9","line":64,"updated":"2017-12-20 22:53:26.000000000","message":"nit, don\u0027t know if you want to mention that this ramdisk should have IPA (see L44)","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3dec19f491aa2f384bbd9d40e31ab6766d682f7c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"RESCUE_PROPERTIES \u003d {"},{"line_number":62,"context_line":"    \u0027rescue_kernel\u0027: _(\u0027UUID (from Glance) of the rescue kernel. This value \u0027"},{"line_number":63,"context_line":"                       \u0027is required for rescue mode.\u0027),"},{"line_number":64,"context_line":"    \u0027rescue_ramdisk\u0027: _(\u0027UUID (from Glance) of the rescue ramdisk. This value \u0027"},{"line_number":65,"context_line":"                        \u0027is required for rescue mode.\u0027),"},{"line_number":66,"context_line":"}"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":77,"id":"9f91af0f_2f7067a5","line":64,"in_reply_to":"bf8cb3f7_fb44c8b9","updated":"2018-01-04 11:21:02.000000000","message":"Done","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c7ca39ec5bdbb13f0642747215ecef08aa5bbc58","unresolved":false,"context_lines":[{"line_number":468,"context_line":"                # as we do not need to boot the agent to deploy."},{"line_number":469,"context_line":"                return"},{"line_number":470,"context_line":"        if node.provision_state in (states.ACTIVE, states.UNRESCUING,"},{"line_number":471,"context_line":"                                    states.UNRESCUEFAIL):"},{"line_number":472,"context_line":"            # Call is due to conductor takeover"},{"line_number":473,"context_line":"            task.driver.boot.prepare_instance(task)"},{"line_number":474,"context_line":"        elif node.provision_state !\u003d states.ADOPTING:"}],"source_content_type":"text/x-python","patch_set":77,"id":"bf8cb3f7_1612a159","line":471,"updated":"2017-12-20 22:53:26.000000000","message":"why UNRESCUEFAIL?","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3dec19f491aa2f384bbd9d40e31ab6766d682f7c","unresolved":false,"context_lines":[{"line_number":468,"context_line":"                # as we do not need to boot the agent to deploy."},{"line_number":469,"context_line":"                return"},{"line_number":470,"context_line":"        if node.provision_state in (states.ACTIVE, states.UNRESCUING,"},{"line_number":471,"context_line":"                                    states.UNRESCUEFAIL):"},{"line_number":472,"context_line":"            # Call is due to conductor takeover"},{"line_number":473,"context_line":"            task.driver.boot.prepare_instance(task)"},{"line_number":474,"context_line":"        elif node.provision_state !\u003d states.ADOPTING:"}],"source_content_type":"text/x-python","patch_set":77,"id":"9f91af0f_6f9bcfc8","line":471,"in_reply_to":"bf8cb3f7_1612a159","updated":"2018-01-04 11:21:02.000000000","message":"Done","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5c6624dbf3a1813c7379ed74cd29bef2822b82a7","unresolved":false,"context_lines":[{"line_number":763,"context_line":"        # conductor and make sure networks are appropriately switched back"},{"line_number":764,"context_line":"        # to tenant in this case."},{"line_number":765,"context_line":"        node_state \u003d task.node.provision_state"},{"line_number":766,"context_line":"        if node_state !\u003d states.RESCUE:"},{"line_number":767,"context_line":"            self.clean_up(task)"},{"line_number":768,"context_line":"            task.driver.network.configure_tenant_networks(task)"},{"line_number":769,"context_line":""}],"source_content_type":"text/x-python","patch_set":77,"id":"df87a7cf_be8f6b21","line":766,"updated":"2017-12-19 22:24:29.000000000","message":"nit: Seems like assigning node_state is not required.","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7582118339d8717569b08cc8effe0881a4265658","unresolved":false,"context_lines":[{"line_number":763,"context_line":"        # conductor and make sure networks are appropriately switched back"},{"line_number":764,"context_line":"        # to tenant in this case."},{"line_number":765,"context_line":"        node_state \u003d task.node.provision_state"},{"line_number":766,"context_line":"        if node_state !\u003d states.RESCUE:"},{"line_number":767,"context_line":"            self.clean_up(task)"},{"line_number":768,"context_line":"            task.driver.network.configure_tenant_networks(task)"},{"line_number":769,"context_line":""}],"source_content_type":"text/x-python","patch_set":77,"id":"bf8cb3f7_a04e1abf","line":766,"in_reply_to":"df87a7cf_be8f6b21","updated":"2017-12-20 14:07:08.000000000","message":"Done","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c7ca39ec5bdbb13f0642747215ecef08aa5bbc58","unresolved":false,"context_lines":[{"line_number":765,"context_line":"        node_state \u003d task.node.provision_state"},{"line_number":766,"context_line":"        if node_state !\u003d states.RESCUE:"},{"line_number":767,"context_line":"            self.clean_up(task)"},{"line_number":768,"context_line":"            task.driver.network.configure_tenant_networks(task)"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"        task.driver.boot.prepare_instance(task)"},{"line_number":771,"context_line":""}],"source_content_type":"text/x-python","patch_set":77,"id":"bf8cb3f7_769d2d58","line":768,"updated":"2017-12-20 22:53:26.000000000","message":"I think I need to take a break, because if the node IS in states.rescue (which I would think is the normal case), don\u0027t we want to remove rescue network and add tenant network?","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3dec19f491aa2f384bbd9d40e31ab6766d682f7c","unresolved":false,"context_lines":[{"line_number":765,"context_line":"        node_state \u003d task.node.provision_state"},{"line_number":766,"context_line":"        if node_state !\u003d states.RESCUE:"},{"line_number":767,"context_line":"            self.clean_up(task)"},{"line_number":768,"context_line":"            task.driver.network.configure_tenant_networks(task)"},{"line_number":769,"context_line":""},{"line_number":770,"context_line":"        task.driver.boot.prepare_instance(task)"},{"line_number":771,"context_line":""}],"source_content_type":"text/x-python","patch_set":77,"id":"9f91af0f_8032b9f0","line":768,"in_reply_to":"bf8cb3f7_769d2d58","updated":"2018-01-04 11:21:02.000000000","message":"No, we do not need to perform those operations in normal case. We use the rescue network only to set the password for the \u0027rescue\u0027 user on the ramdisk and then switch to tenant network in _finalize_rescue() https://review.openstack.org/#/c/400437/77/ironic/drivers/modules/agent_base_vendor.py@372","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"8e4b4f9d1ba6afdbbc65516e30d124a291a973d4","unresolved":false,"context_lines":[{"line_number":762,"context_line":"        # ramdisk configuration set up. Clean up ramdisk config on"},{"line_number":763,"context_line":"        # conductor and make sure networks are appropriately switched back"},{"line_number":764,"context_line":"        # to tenant in this case."},{"line_number":765,"context_line":"        if task.node.provision_state !\u003d states.RESCUE:"},{"line_number":766,"context_line":"            self.clean_up(task)"},{"line_number":767,"context_line":"            task.driver.network.configure_tenant_networks(task)"},{"line_number":768,"context_line":""}],"source_content_type":"text/x-python","patch_set":80,"id":"7f96bb07_9300e736","line":765,"updated":"2018-01-12 03:19:48.000000000","message":"provsion_state is always UNRESCUING here.","commit_id":"1d74d6dd34160d400edc2482b680d0520a598422"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"59e7f43c813937c8055a5464baff3d406e5bfd3d","unresolved":false,"context_lines":[{"line_number":762,"context_line":"        # ramdisk configuration set up. Clean up ramdisk config on"},{"line_number":763,"context_line":"        # conductor and make sure networks are appropriately switched back"},{"line_number":764,"context_line":"        # to tenant in this case."},{"line_number":765,"context_line":"        if task.node.provision_state !\u003d states.RESCUE:"},{"line_number":766,"context_line":"            self.clean_up(task)"},{"line_number":767,"context_line":"            task.driver.network.configure_tenant_networks(task)"},{"line_number":768,"context_line":""}],"source_content_type":"text/x-python","patch_set":80,"id":"7f96bb07_56b80ac7","line":765,"in_reply_to":"7f96bb07_9300e736","updated":"2018-01-12 13:13:37.000000000","message":"Done","commit_id":"1d74d6dd34160d400edc2482b680d0520a598422"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"cf611a412ab949ac6b5a4411578fd684ba50aa5b","unresolved":false,"context_lines":[{"line_number":794,"context_line":"                     \"for node %s. The \u0027rescue_password\u0027 must be a non-empty \""},{"line_number":795,"context_line":"                     \"string value.\") % node.uuid)"},{"line_number":796,"context_line":"            raise exception.InvalidParameterValue(msg)"},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"    @METRICS.timer(\u0027AgentRescue.clean_up\u0027)"},{"line_number":799,"context_line":"    def clean_up(self, task):"},{"line_number":800,"context_line":"        \"\"\"Clean up after RESCUEWAIT timeout/failure or finishing rescue."}],"source_content_type":"text/x-python","patch_set":83,"id":"7f96bb07_0633b0f7","line":797,"updated":"2018-01-17 09:16:37.000000000","message":"Do we need to validate boot interface like line 337? I\u0027m not sure if boot.validate() can be used for rescue, though. Would it better to add a new method to validate for rescue to boot interfaces?\n\nNow that only pxe boot interface supports rescue mode, it would be necessary to see if a boot interface supports rescue. I think interface capabilities can be used like capabilities for boot from volume[1][2].\n\n[1] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/pxe.py#L389\n[2] https://github.com/openstack/ironic/blob/master/ironic/drivers/modules/deploy_utils.py#L1280","commit_id":"bcb1f7edcf57d3ec8a5c6d7c21226a62c529b980"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2e273cc81aab67841c3a2327e951fb2692ca2cf5","unresolved":false,"context_lines":[{"line_number":794,"context_line":"                     \"for node %s. The \u0027rescue_password\u0027 must be a non-empty \""},{"line_number":795,"context_line":"                     \"string value.\") % node.uuid)"},{"line_number":796,"context_line":"            raise exception.InvalidParameterValue(msg)"},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"    @METRICS.timer(\u0027AgentRescue.clean_up\u0027)"},{"line_number":799,"context_line":"    def clean_up(self, task):"},{"line_number":800,"context_line":"        \"\"\"Clean up after RESCUEWAIT timeout/failure or finishing rescue."}],"source_content_type":"text/x-python","patch_set":83,"id":"7f96bb07_ba90cf44","line":797,"in_reply_to":"7f96bb07_0633b0f7","updated":"2018-01-17 16:15:08.000000000","message":"Added check for boot.validate(). I don\u0027t think we need a capability indicating rescue support in boot interface. When a hardware type adds rescue support, it would have to ensure that the required changes are done to its supported boot interface to ensure rescue operations happen.","commit_id":"bcb1f7edcf57d3ec8a5c6d7c21226a62c529b980"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1dac7d3c279c5b3a5677d8a8c15106f4d2f40cc0","unresolved":false,"context_lines":[{"line_number":806,"context_line":"        :raises: NetworkError if the rescue ports cannot be removed."},{"line_number":807,"context_line":"        \"\"\""},{"line_number":808,"context_line":"        if CONF.agent.manage_agent_boot:"},{"line_number":809,"context_line":"            task.driver.boot.clean_up_ramdisk(task, mode\u003d\u0027rescue\u0027)"},{"line_number":810,"context_line":"        manager_utils.remove_node_rescue_password(task.node, save\u003dTrue)"},{"line_number":811,"context_line":"        task.driver.network.remove_rescuing_network(task)"}],"source_content_type":"text/x-python","patch_set":83,"id":"7f96bb07_7bf1ff6a","line":809,"updated":"2018-01-16 22:20:28.000000000","message":"what if this is an out of tree driver. can we assume that they updated it to have clean_up_ramdisk(.., mode\u003d..) ?","commit_id":"bcb1f7edcf57d3ec8a5c6d7c21226a62c529b980"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2e273cc81aab67841c3a2327e951fb2692ca2cf5","unresolved":false,"context_lines":[{"line_number":806,"context_line":"        :raises: NetworkError if the rescue ports cannot be removed."},{"line_number":807,"context_line":"        \"\"\""},{"line_number":808,"context_line":"        if CONF.agent.manage_agent_boot:"},{"line_number":809,"context_line":"            task.driver.boot.clean_up_ramdisk(task, mode\u003d\u0027rescue\u0027)"},{"line_number":810,"context_line":"        manager_utils.remove_node_rescue_password(task.node, save\u003dTrue)"},{"line_number":811,"context_line":"        task.driver.network.remove_rescuing_network(task)"}],"source_content_type":"text/x-python","patch_set":83,"id":"7f96bb07_7a0c87eb","line":809,"in_reply_to":"7f96bb07_7bf1ff6a","updated":"2018-01-17 16:15:08.000000000","message":"Last time we updated the signature of methods as part of soft power off feature. Added timeout parameter to set_power_state() and reboot(). Did not find any additional steps taken that time for out of tree drivers.","commit_id":"bcb1f7edcf57d3ec8a5c6d7c21226a62c529b980"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1dac7d3c279c5b3a5677d8a8c15106f4d2f40cc0","unresolved":false,"context_lines":[{"line_number":807,"context_line":"        \"\"\""},{"line_number":808,"context_line":"        if CONF.agent.manage_agent_boot:"},{"line_number":809,"context_line":"            task.driver.boot.clean_up_ramdisk(task, mode\u003d\u0027rescue\u0027)"},{"line_number":810,"context_line":"        manager_utils.remove_node_rescue_password(task.node, save\u003dTrue)"},{"line_number":811,"context_line":"        task.driver.network.remove_rescuing_network(task)"}],"source_content_type":"text/x-python","patch_set":83,"id":"7f96bb07_7b4d7f98","line":810,"updated":"2018-01-16 22:20:28.000000000","message":"i wonder if we should do this first, before clean_up_ramdisk(). In case clean_up_ramdisk() fails.","commit_id":"bcb1f7edcf57d3ec8a5c6d7c21226a62c529b980"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2e273cc81aab67841c3a2327e951fb2692ca2cf5","unresolved":false,"context_lines":[{"line_number":807,"context_line":"        \"\"\""},{"line_number":808,"context_line":"        if CONF.agent.manage_agent_boot:"},{"line_number":809,"context_line":"            task.driver.boot.clean_up_ramdisk(task, mode\u003d\u0027rescue\u0027)"},{"line_number":810,"context_line":"        manager_utils.remove_node_rescue_password(task.node, save\u003dTrue)"},{"line_number":811,"context_line":"        task.driver.network.remove_rescuing_network(task)"}],"source_content_type":"text/x-python","patch_set":83,"id":"7f96bb07_238d7ed2","line":810,"in_reply_to":"7f96bb07_7b4d7f98","updated":"2018-01-17 16:15:08.000000000","message":"Done","commit_id":"bcb1f7edcf57d3ec8a5c6d7c21226a62c529b980"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3f98e817122c0c90c16d93a1da13982451ff729c","unresolved":false,"context_lines":[{"line_number":810,"context_line":"        \"\"\""},{"line_number":811,"context_line":"        manager_utils.remove_node_rescue_password(task.node, save\u003dTrue)"},{"line_number":812,"context_line":"        if CONF.agent.manage_agent_boot:"},{"line_number":813,"context_line":"            task.driver.boot.clean_up_ramdisk(task, mode\u003d\u0027rescue\u0027)"},{"line_number":814,"context_line":"        task.driver.network.remove_rescuing_network(task)"}],"source_content_type":"text/x-python","patch_set":85,"id":"7f96bb07_c1b11949","line":813,"updated":"2018-01-18 00:20:11.000000000","message":"wrt whether we can assume or not that an out-of-tree driver supports this new mode parameter, this is what we did when we added the timeout parameter to set_power_state() [1]. \n\nWe could change this code to do a similar thing, the problem is that if it doesn\u0027t support the mode parameter, then what? It is probably more important @ L739.\n\nWhat do you think about putting code in validate(), something like:\n\nif CONF.agent.manage_agent_boot:\n    if (\u0027mode\u0027 not in reflection.get_signature(task.driver.boot.clean_up_ramdisk).parameters or \u0027mode\u0027 not in reflection.get_signature(task_driver.boot.prepare_ramdisk).parameters) raise exception.IncompatibleInterface(some useful msg here)?\n\n[1] \nhttps://github.com/openstack/ironic/blob/8ceaad42ff363581efd2f43737456d479ea980d7/ironic/conductor/utils.py#L229","commit_id":"142a29c21be377bd007bf6487970a1de77ee90a0"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"05825b3305665de135f0e76b649ad53b07751d4e","unresolved":false,"context_lines":[{"line_number":810,"context_line":"        \"\"\""},{"line_number":811,"context_line":"        manager_utils.remove_node_rescue_password(task.node, save\u003dTrue)"},{"line_number":812,"context_line":"        if CONF.agent.manage_agent_boot:"},{"line_number":813,"context_line":"            task.driver.boot.clean_up_ramdisk(task, mode\u003d\u0027rescue\u0027)"},{"line_number":814,"context_line":"        task.driver.network.remove_rescuing_network(task)"}],"source_content_type":"text/x-python","patch_set":85,"id":"7f96bb07_4acae4a0","line":813,"in_reply_to":"7f96bb07_c1b11949","updated":"2018-01-19 09:21:46.000000000","message":"Done","commit_id":"142a29c21be377bd007bf6487970a1de77ee90a0"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"62cc27d2cec48a4854324ac56790e104ee773bf9","unresolved":false,"context_lines":[{"line_number":771,"context_line":"        :param task: a TaskManager instance with the node being checked"},{"line_number":772,"context_line":"        :raises: MissingParameterValue if node is missing one or more required"},{"line_number":773,"context_line":"                                       parameters"},{"line_number":774,"context_line":"        \"\"\""},{"line_number":775,"context_line":"        node \u003d task.node"},{"line_number":776,"context_line":"        missing_params \u003d []"},{"line_number":777,"context_line":"        if CONF.agent.manage_agent_boot:"}],"source_content_type":"text/x-python","patch_set":86,"id":"7f96bb07_ec771008","line":774,"updated":"2018-01-22 04:09:56.000000000","message":"nit: InvalidParameterValue is missing.","commit_id":"2f44114aa649e62c70f8a00677fac084ba06fe75"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"326fce97a92feb9973de7eb4b9017c1e92da9202","unresolved":false,"context_lines":[{"line_number":771,"context_line":"        :param task: a TaskManager instance with the node being checked"},{"line_number":772,"context_line":"        :raises: MissingParameterValue if node is missing one or more required"},{"line_number":773,"context_line":"                                       parameters"},{"line_number":774,"context_line":"        \"\"\""},{"line_number":775,"context_line":"        node \u003d task.node"},{"line_number":776,"context_line":"        missing_params \u003d []"},{"line_number":777,"context_line":"        if CONF.agent.manage_agent_boot:"}],"source_content_type":"text/x-python","patch_set":86,"id":"7f96bb07_fdba5cdf","line":774,"in_reply_to":"7f96bb07_ec771008","updated":"2018-01-22 05:18:11.000000000","message":"Yes will add IncompatibleInterface here.","commit_id":"2f44114aa649e62c70f8a00677fac084ba06fe75"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"62cc27d2cec48a4854324ac56790e104ee773bf9","unresolved":false,"context_lines":[{"line_number":783,"context_line":"                    interface_type\u003d\u0027boot\u0027,"},{"line_number":784,"context_line":"                    interface_impl\u003d\"of \u0027prepare_ramdisk\u0027 and/or \""},{"line_number":785,"context_line":"                                   \"\u0027clean_up_ramdisk\u0027 with \u0027mode\u0027 argument\","},{"line_number":786,"context_line":"                    hardware_type\u003dnode.driver)"},{"line_number":787,"context_line":"            for req in RESCUE_PROPERTIES:"},{"line_number":788,"context_line":"                if node.driver_info.get(req) is None:"},{"line_number":789,"context_line":"                    missing_params.append(\u0027driver_info/\u0027 + req)"}],"source_content_type":"text/x-python","patch_set":86,"id":"7f96bb07_2cfc183d","line":786,"updated":"2018-01-22 04:09:56.000000000","message":"I\u0027m not sure this message would be useful for users. I prefer just telling that the boot interface doesn\u0027t support rescue with InvalidParameterValue.","commit_id":"2f44114aa649e62c70f8a00677fac084ba06fe75"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"326fce97a92feb9973de7eb4b9017c1e92da9202","unresolved":false,"context_lines":[{"line_number":783,"context_line":"                    interface_type\u003d\u0027boot\u0027,"},{"line_number":784,"context_line":"                    interface_impl\u003d\"of \u0027prepare_ramdisk\u0027 and/or \""},{"line_number":785,"context_line":"                                   \"\u0027clean_up_ramdisk\u0027 with \u0027mode\u0027 argument\","},{"line_number":786,"context_line":"                    hardware_type\u003dnode.driver)"},{"line_number":787,"context_line":"            for req in RESCUE_PROPERTIES:"},{"line_number":788,"context_line":"                if node.driver_info.get(req) is None:"},{"line_number":789,"context_line":"                    missing_params.append(\u0027driver_info/\u0027 + req)"}],"source_content_type":"text/x-python","patch_set":86,"id":"7f96bb07_7dce4c84","line":786,"in_reply_to":"7f96bb07_2cfc183d","updated":"2018-01-22 05:18:11.000000000","message":"Here we wanted to explicit about the interface signature mismatch and hence raising IncompatibleInterface instead of suggesting it as an invalid parameter. Will wait for more comments on this.","commit_id":"2f44114aa649e62c70f8a00677fac084ba06fe75"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"647465e37288b93cdb1b18c3013c633a990ecb71","unresolved":false,"context_lines":[{"line_number":795,"context_line":"                if node.driver_info.get(req) is None:"},{"line_number":796,"context_line":"                    missing_params.append(\u0027driver_info/\u0027 + req)"},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"        rescue_pass \u003d node.instance_info.get(\u0027rescue_password\u0027)"},{"line_number":799,"context_line":"        if rescue_pass is None:"},{"line_number":800,"context_line":"            missing_params.append(\u0027instance_info/rescue_password\u0027)"},{"line_number":801,"context_line":""},{"line_number":802,"context_line":"        if missing_params:"},{"line_number":803,"context_line":"            msg \u003d _(\u0027Node %(node)s is missing parameter(s): \u0027"},{"line_number":804,"context_line":"                    \u0027%(params)s. These are required for rescuing node.\u0027)"},{"line_number":805,"context_line":"            raise exception.MissingParameterValue("},{"line_number":806,"context_line":"                msg % {\u0027node\u0027: node.uuid,"},{"line_number":807,"context_line":"                       \u0027params\u0027: \u0027, \u0027.join(missing_params)})"},{"line_number":808,"context_line":""},{"line_number":809,"context_line":"        if not rescue_pass.strip():"},{"line_number":810,"context_line":"            msg \u003d (_(\"The \u0027instance_info/rescue_password\u0027 is an empty string \""},{"line_number":811,"context_line":"                     \"for node %s. The \u0027rescue_password\u0027 must be a non-empty \""},{"line_number":812,"context_line":"                     \"string value.\") % node.uuid)"},{"line_number":813,"context_line":"            raise exception.InvalidParameterValue(msg)"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"        if CONF.agent.manage_agent_boot:"},{"line_number":816,"context_line":"            # TODO(stendulker): boot.validate() performs validation of"}],"source_content_type":"text/x-python","patch_set":87,"id":"7f96bb07_f7623016","line":813,"range":{"start_line":798,"start_character":0,"end_line":813,"end_character":54},"updated":"2018-01-24 02:23:47.000000000","message":"Why don\u0027t we move this validation of rescue password to the end of this method? This validation never succeeds when called from node validation API since rescue password is set when rescuing is requested. It would be better to validate others which can be detected at the stage of node validation.","commit_id":"dc264e21d1e927cc62e817144b98060bb150de5d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e5ab3033185617bcb9f6b0105417c36eae1642fa","unresolved":false,"context_lines":[{"line_number":795,"context_line":"                if node.driver_info.get(req) is None:"},{"line_number":796,"context_line":"                    missing_params.append(\u0027driver_info/\u0027 + req)"},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"        rescue_pass \u003d node.instance_info.get(\u0027rescue_password\u0027)"},{"line_number":799,"context_line":"        if rescue_pass is None:"},{"line_number":800,"context_line":"            missing_params.append(\u0027instance_info/rescue_password\u0027)"},{"line_number":801,"context_line":""},{"line_number":802,"context_line":"        if missing_params:"},{"line_number":803,"context_line":"            msg \u003d _(\u0027Node %(node)s is missing parameter(s): \u0027"},{"line_number":804,"context_line":"                    \u0027%(params)s. These are required for rescuing node.\u0027)"},{"line_number":805,"context_line":"            raise exception.MissingParameterValue("},{"line_number":806,"context_line":"                msg % {\u0027node\u0027: node.uuid,"},{"line_number":807,"context_line":"                       \u0027params\u0027: \u0027, \u0027.join(missing_params)})"},{"line_number":808,"context_line":""},{"line_number":809,"context_line":"        if not rescue_pass.strip():"},{"line_number":810,"context_line":"            msg \u003d (_(\"The \u0027instance_info/rescue_password\u0027 is an empty string \""},{"line_number":811,"context_line":"                     \"for node %s. The \u0027rescue_password\u0027 must be a non-empty \""},{"line_number":812,"context_line":"                     \"string value.\") % node.uuid)"},{"line_number":813,"context_line":"            raise exception.InvalidParameterValue(msg)"},{"line_number":814,"context_line":""},{"line_number":815,"context_line":"        if CONF.agent.manage_agent_boot:"},{"line_number":816,"context_line":"            # TODO(stendulker): boot.validate() performs validation of"}],"source_content_type":"text/x-python","patch_set":87,"id":"7f96bb07_635f3b41","line":813,"range":{"start_line":798,"start_character":0,"end_line":813,"end_character":54},"in_reply_to":"7f96bb07_f7623016","updated":"2018-01-24 06:40:21.000000000","message":"Done","commit_id":"dc264e21d1e927cc62e817144b98060bb150de5d"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"647465e37288b93cdb1b18c3013c633a990ecb71","unresolved":false,"context_lines":[{"line_number":820,"context_line":""},{"line_number":821,"context_line":"        # Validate rescuing network if node is using \u0027neutron\u0027 network"},{"line_number":822,"context_line":"        if isinstance(task.driver.network, neutron.NeutronNetwork):"},{"line_number":823,"context_line":"            task.driver.network.get_rescuing_network_uuid(context\u003dtask.context)"},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"    @METRICS.timer(\u0027AgentRescue.clean_up\u0027)"},{"line_number":826,"context_line":"    def clean_up(self, task):"}],"source_content_type":"text/x-python","patch_set":87,"id":"7f96bb07_6245fc42","line":823,"updated":"2018-01-24 02:23:47.000000000","message":"IMHO, I prefer adding validate_rescuing_network() to base.NetworkInterface and implementing it in NeutronNetwork like add_rescuing_network(). But, I don\u0027t insist it because the network change was already merged. This is not a reason for -1.","commit_id":"dc264e21d1e927cc62e817144b98060bb150de5d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e5ab3033185617bcb9f6b0105417c36eae1642fa","unresolved":false,"context_lines":[{"line_number":820,"context_line":""},{"line_number":821,"context_line":"        # Validate rescuing network if node is using \u0027neutron\u0027 network"},{"line_number":822,"context_line":"        if isinstance(task.driver.network, neutron.NeutronNetwork):"},{"line_number":823,"context_line":"            task.driver.network.get_rescuing_network_uuid(context\u003dtask.context)"},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"    @METRICS.timer(\u0027AgentRescue.clean_up\u0027)"},{"line_number":826,"context_line":"    def clean_up(self, task):"}],"source_content_type":"text/x-python","patch_set":87,"id":"7f96bb07_033437fa","line":823,"in_reply_to":"7f96bb07_6245fc42","updated":"2018-01-24 06:40:21.000000000","message":"May be. but this is one off case. We can add if we see more interfaces needs this kind of treatment.","commit_id":"dc264e21d1e927cc62e817144b98060bb150de5d"}],"ironic/drivers/modules/agent_base_vendor.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"90a947057d4d787aa63a43060c4e6cec630132b4","unresolved":false,"context_lines":[{"line_number":522,"context_line":"        # Avoid duplicate RESCUEWAIT heartbeats causing attempts to finalize"},{"line_number":523,"context_line":"        # rescue twice"},{"line_number":524,"context_line":"        driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":525,"context_line":"        driver_internal_info[\u0027finalizing_rescue\u0027] \u003d True"},{"line_number":526,"context_line":"        task.node.driver_internal_info \u003d driver_internal_info"},{"line_number":527,"context_line":"        task.node.save()"},{"line_number":528,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"5a3905b3_85da2d16","line":525,"updated":"2017-01-24 22:02:34.000000000","message":"gotta clean this up on fail too","commit_id":"fed88354809b6725839f8a85c9e306653236e5b7"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"6c5f1f9a63b41d84794d5a6cd6ee5790514f6e90","unresolved":false,"context_lines":[{"line_number":522,"context_line":"        # Avoid duplicate RESCUEWAIT heartbeats causing attempts to finalize"},{"line_number":523,"context_line":"        # rescue twice"},{"line_number":524,"context_line":"        driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":525,"context_line":"        driver_internal_info[\u0027finalizing_rescue\u0027] \u003d True"},{"line_number":526,"context_line":"        task.node.driver_internal_info \u003d driver_internal_info"},{"line_number":527,"context_line":"        task.node.save()"},{"line_number":528,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3a461143_c8aa8219","line":525,"in_reply_to":"5a3905b3_85da2d16","updated":"2017-01-25 21:33:14.000000000","message":"that should be happening in deploy_utils already, in the error handler - L512","commit_id":"fed88354809b6725839f8a85c9e306653236e5b7"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"cb41135ef163266dc2fd94f57644caff02963a5f","unresolved":false,"context_lines":[{"line_number":540,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":541,"context_line":"        task.driver.network.remove_rescue_network(task)"},{"line_number":542,"context_line":"        task.driver.network.configure_tenant_networks(task)"},{"line_number":543,"context_line":"        task.process_event(\u0027done\u0027)"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"    @METRICS.timer(\u0027AgentDeployMixin.reboot_and_finish_deploy\u0027)"},{"line_number":546,"context_line":"    def reboot_and_finish_deploy(self, task):"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a3905b3_6afeee39","line":543,"updated":"2017-01-24 21:39:25.000000000","message":"need to remove finalizing_rescue here","commit_id":"fed88354809b6725839f8a85c9e306653236e5b7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2b6d6522df3d8974294550013ae3ad71ba9c9401","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                                                  reason\u003dfail_reason)"},{"line_number":363,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":364,"context_line":"        task.driver.network.remove_rescue_network(task)"},{"line_number":365,"context_line":"        task.driver.network.configure_tenant_networks(task)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"        driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":368,"context_line":"        del driver_internal_info[\u0027finalizing_rescue\u0027]"}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_f19b1963","line":365,"range":{"start_line":365,"start_character":8,"end_line":365,"end_character":59},"updated":"2017-03-28 11:36:52.000000000","message":"Should we also call task.driver.boot.clean_up_ramdisk(task, rescue\u003dTrue) ?","commit_id":"da600a852847e7845ce644ce61bdd2f63e843b8e"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"94dd83ec0a7e8311f38947cdf2806e6f049fa1bf","unresolved":false,"context_lines":[{"line_number":362,"context_line":"                                                  reason\u003dfail_reason)"},{"line_number":363,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":364,"context_line":"        task.driver.network.remove_rescue_network(task)"},{"line_number":365,"context_line":"        task.driver.network.configure_tenant_networks(task)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"        driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":368,"context_line":"        del driver_internal_info[\u0027finalizing_rescue\u0027]"}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_99661ac1","line":365,"range":{"start_line":365,"start_character":8,"end_line":365,"end_character":59},"in_reply_to":"ffe62b97_f19b1963","updated":"2017-03-29 16:52:57.000000000","message":"Yes, good point. \n\nPXE info would get overwritten whenever next PXE boot happens, but we shouldn\u0027t leave it hanging around.\n\nWe should also do this on a RESCUEWAIT timeout, so I\u0027ll add it to task.driver.rescue.clean_up as well and call that from here.","commit_id":"da600a852847e7845ce644ce61bdd2f63e843b8e"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2b6d6522df3d8974294550013ae3ad71ba9c9401","unresolved":false,"context_lines":[{"line_number":364,"context_line":"        task.driver.network.remove_rescue_network(task)"},{"line_number":365,"context_line":"        task.driver.network.configure_tenant_networks(task)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"        driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":368,"context_line":"        del driver_internal_info[\u0027finalizing_rescue\u0027]"},{"line_number":369,"context_line":"        task.node.driver_internal_info \u003d driver_internal_info"},{"line_number":370,"context_line":"        task.node.save()"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"        task.process_event(\u0027done\u0027)"},{"line_number":373,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_31bf41b1","line":370,"range":{"start_line":367,"start_character":8,"end_line":370,"end_character":24},"updated":"2017-03-28 11:36:52.000000000","message":"This code could go into\ntask.driver.boot.clean_up_ramdisk()","commit_id":"da600a852847e7845ce644ce61bdd2f63e843b8e"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"b6d27bf48f55838d72ca4b464551732587e0fbf4","unresolved":false,"context_lines":[{"line_number":364,"context_line":"        task.driver.network.remove_rescue_network(task)"},{"line_number":365,"context_line":"        task.driver.network.configure_tenant_networks(task)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"        driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":368,"context_line":"        del driver_internal_info[\u0027finalizing_rescue\u0027]"},{"line_number":369,"context_line":"        task.node.driver_internal_info \u003d driver_internal_info"},{"line_number":370,"context_line":"        task.node.save()"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"        task.process_event(\u0027done\u0027)"},{"line_number":373,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_375cceeb","line":370,"range":{"start_line":367,"start_character":8,"end_line":370,"end_character":24},"in_reply_to":"ffe62b97_31bf41b1","updated":"2017-03-28 13:00:07.000000000","message":"Maybe task.driver.rescue.clean_up(task) is a better place.","commit_id":"da600a852847e7845ce644ce61bdd2f63e843b8e"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"94dd83ec0a7e8311f38947cdf2806e6f049fa1bf","unresolved":false,"context_lines":[{"line_number":364,"context_line":"        task.driver.network.remove_rescue_network(task)"},{"line_number":365,"context_line":"        task.driver.network.configure_tenant_networks(task)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"        driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":368,"context_line":"        del driver_internal_info[\u0027finalizing_rescue\u0027]"},{"line_number":369,"context_line":"        task.node.driver_internal_info \u003d driver_internal_info"},{"line_number":370,"context_line":"        task.node.save()"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"        task.process_event(\u0027done\u0027)"},{"line_number":373,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_f39ac111","line":370,"range":{"start_line":367,"start_character":8,"end_line":370,"end_character":24},"in_reply_to":"ffe62b97_375cceeb","updated":"2017-03-29 16:52:57.000000000","message":"Yeah, I think that\u0027s a better place for it. We can make that a general-purpose function for cleaning up after rescue, not just for RESCUEWAIT timeout, since what\u0027s necessary is almost exactly the same.\n\nI\u0027ll leave network handling outside of there, though.","commit_id":"da600a852847e7845ce644ce61bdd2f63e843b8e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"3598f5351bf96abce41bf1c66918ccf04db52fd0","unresolved":false,"context_lines":[{"line_number":343,"context_line":""},{"line_number":344,"context_line":"           :raises: InstanceRescueFailure, if rescuing failed"},{"line_number":345,"context_line":"        \"\"\""},{"line_number":346,"context_line":"        # Avoid duplicate RESCUEWAIT heartbeats causing attempts to finalize"},{"line_number":347,"context_line":"        # rescue twice"},{"line_number":348,"context_line":"        driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":349,"context_line":"        driver_internal_info[\u0027finalizing_rescue\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":32,"id":"dfeb2761_91a86ddb","line":346,"updated":"2017-04-04 11:39:10.000000000","message":"Sorry, I don\u0027t understand why this needed. We got exclusive node lock l266 and looks like should leave RESCUEWAIT state before thread finishes.","commit_id":"5f7ab1fc99a21530aa40ffac3c61fbab68686b3f"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"227719ec8def4b709cf0780721325751993c90fb","unresolved":false,"context_lines":[{"line_number":343,"context_line":""},{"line_number":344,"context_line":"           :raises: InstanceRescueFailure, if rescuing failed"},{"line_number":345,"context_line":"        \"\"\""},{"line_number":346,"context_line":"        # Avoid duplicate RESCUEWAIT heartbeats causing attempts to finalize"},{"line_number":347,"context_line":"        # rescue twice"},{"line_number":348,"context_line":"        driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":349,"context_line":"        driver_internal_info[\u0027finalizing_rescue\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":32,"id":"bff0334d_fa0d9090","line":346,"in_reply_to":"dfeb2761_91a86ddb","updated":"2017-04-10 16:15:17.000000000","message":"Ah, you\u0027re right, duplicate heartbeats won\u0027t get to this point because the lock upgrade will fail. Will remove, thanks","commit_id":"5f7ab1fc99a21530aa40ffac3c61fbab68686b3f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"127e02427f89ace62c148e3b326d676d86f668d6","unresolved":false,"context_lines":[{"line_number":342,"context_line":"    def _finalize_rescue(self, task):"},{"line_number":343,"context_line":"        \"\"\"Call ramdisk to prepare rescue mode and verify result."},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"           :param task: A TaskManager instance"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"           :raises: InstanceRescueFailure, if rescuing failed"},{"line_number":348,"context_line":"        \"\"\""},{"line_number":349,"context_line":"        result \u003d self._client.finalize_rescue(task.node)"},{"line_number":350,"context_line":"        if ((not result.get(\u0027command_status\u0027)) or"}],"source_content_type":"text/x-python","patch_set":37,"id":"bff0334d_21e23ea1","line":347,"range":{"start_line":345,"start_character":7,"end_line":347,"end_character":61},"updated":"2017-04-11 04:03:53.000000000","message":"nit: This is over-indented.","commit_id":"5ef3d8407525c9cefac8a1fbcb0173bc3c281d06"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"cb1f5230a97e2a986e0755e9d1bf9ee097989732","unresolved":false,"context_lines":[{"line_number":342,"context_line":"    def _finalize_rescue(self, task):"},{"line_number":343,"context_line":"        \"\"\"Call ramdisk to prepare rescue mode and verify result."},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"           :param task: A TaskManager instance"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"           :raises: InstanceRescueFailure, if rescuing failed"},{"line_number":348,"context_line":"        \"\"\""},{"line_number":349,"context_line":"        result \u003d self._client.finalize_rescue(task.node)"},{"line_number":350,"context_line":"        if ((not result.get(\u0027command_status\u0027)) or"}],"source_content_type":"text/x-python","patch_set":37,"id":"1f013ff3_96afab93","line":347,"range":{"start_line":345,"start_character":7,"end_line":347,"end_character":61},"in_reply_to":"bff0334d_21e23ea1","updated":"2017-05-15 12:09:40.000000000","message":"Done","commit_id":"5ef3d8407525c9cefac8a1fbcb0173bc3c281d06"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"f8420bdfc0808ced4c2ce23aeb97609ddbc4c064","unresolved":false,"context_lines":[{"line_number":321,"context_line":"                    msg \u003d _(\u0027Node failed to check cleaning progress.\u0027)"},{"line_number":322,"context_line":"                    self.continue_cleaning(task)"},{"line_number":323,"context_line":"            elif (node.provision_state \u003d\u003d states.RESCUEWAIT and not"},{"line_number":324,"context_line":"                  node.driver_internal_info.get(\u0027finalizing_rescue\u0027)):"},{"line_number":325,"context_line":"                self._finalize_rescue(task)"},{"line_number":326,"context_line":"        except Exception as e:"},{"line_number":327,"context_line":"            err_info \u003d {\u0027node\u0027: node.uuid, \u0027msg\u0027: msg, \u0027e\u0027: e}"}],"source_content_type":"text/x-python","patch_set":52,"id":"df3967d1_ead590b8","line":324,"range":{"start_line":324,"start_character":49,"end_line":324,"end_character":66},"updated":"2017-08-01 21:42:12.000000000","message":"may be i am missing something, but where is this added in driver internal info?","commit_id":"1c05f9a6a09e041be7aec72186fa91e1aeca4a0c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4c87c0b4843b158587225810f4a65c4c1565a050","unresolved":false,"context_lines":[{"line_number":321,"context_line":"                    msg \u003d _(\u0027Node failed to check cleaning progress.\u0027)"},{"line_number":322,"context_line":"                    self.continue_cleaning(task)"},{"line_number":323,"context_line":"            elif (node.provision_state \u003d\u003d states.RESCUEWAIT and not"},{"line_number":324,"context_line":"                  node.driver_internal_info.get(\u0027finalizing_rescue\u0027)):"},{"line_number":325,"context_line":"                self._finalize_rescue(task)"},{"line_number":326,"context_line":"        except Exception as e:"},{"line_number":327,"context_line":"            err_info \u003d {\u0027node\u0027: node.uuid, \u0027msg\u0027: msg, \u0027e\u0027: e}"}],"source_content_type":"text/x-python","patch_set":52,"id":"7f287b81_99805548","line":324,"range":{"start_line":324,"start_character":49,"end_line":324,"end_character":66},"in_reply_to":"df3967d1_ead590b8","updated":"2017-08-29 08:12:10.000000000","message":"Fixed. It was residue left when this field was removed.","commit_id":"1c05f9a6a09e041be7aec72186fa91e1aeca4a0c"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"ab4ff5fe59bcddd7948bbcdeced0894aef00079c","unresolved":false,"context_lines":[{"line_number":339,"context_line":"            elif node.provision_state \u003d\u003d states.RESCUEWAIT:"},{"line_number":340,"context_line":"                task.driver.rescue.clean_up(task)"},{"line_number":341,"context_line":"                try:"},{"line_number":342,"context_line":"                    task.process_event(\u0027fail\u0027)"},{"line_number":343,"context_line":"                except exception.InvalidState:"},{"line_number":344,"context_line":"                    LOG.exception(\u0027Internal error. Node %(node)s in provision \u0027"},{"line_number":345,"context_line":"                                  \u0027state RESCUEWAIT could not transition to \u0027"}],"source_content_type":"text/x-python","patch_set":56,"id":"7f515b1d_ad910f55","line":342,"updated":"2017-09-25 07:23:27.000000000","message":"I think we need to update last_error field before go to fail state.","commit_id":"4701e09b29e197c8637f72fd7ff49db4d1710154"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0d3bbf64848681dffa77a8a8e106cfa7929beffc","unresolved":false,"context_lines":[{"line_number":339,"context_line":"            elif node.provision_state \u003d\u003d states.RESCUEWAIT:"},{"line_number":340,"context_line":"                task.driver.rescue.clean_up(task)"},{"line_number":341,"context_line":"                try:"},{"line_number":342,"context_line":"                    task.process_event(\u0027fail\u0027)"},{"line_number":343,"context_line":"                except exception.InvalidState:"},{"line_number":344,"context_line":"                    LOG.exception(\u0027Internal error. Node %(node)s in provision \u0027"},{"line_number":345,"context_line":"                                  \u0027state RESCUEWAIT could not transition to \u0027"}],"source_content_type":"text/x-python","patch_set":56,"id":"7f515b1d_ed9da057","line":342,"in_reply_to":"7f515b1d_ad910f55","updated":"2017-09-27 16:31:32.000000000","message":"Done","commit_id":"4701e09b29e197c8637f72fd7ff49db4d1710154"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6480163bc034276ee9b0ce674c90994fce9ace3e","unresolved":false,"context_lines":[{"line_number":345,"context_line":"                deploy_utils.set_failed_state("},{"line_number":346,"context_line":"                    task, last_error, collect_logs\u003dbool(self._client))"},{"line_number":347,"context_line":"            elif node.provision_state \u003d\u003d states.RESCUEWAIT:"},{"line_number":348,"context_line":"                task.driver.rescue.clean_up(task)"},{"line_number":349,"context_line":"                try:"},{"line_number":350,"context_line":"                    task.node.last_error \u003d last_error"},{"line_number":351,"context_line":"                    task.process_event(\u0027fail\u0027)"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff82abbf_1bc4493f","line":348,"updated":"2017-11-28 21:56:09.000000000","message":"for symmetry, i wonder if we should put this all in a method, eg manager_utils.rescue_error_handler(), but that\u0027s just a thought.\n\nI am wondering why the other ifs also include the CLEANING/DEPLOYING states. Should we include RESCUING here? Yup, just looked at _finalize_rescue(), and the node could be in RESCUING when it fails.","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"075da2894b98641ebc44f6508c7f9f4bff729cfb","unresolved":false,"context_lines":[{"line_number":345,"context_line":"                deploy_utils.set_failed_state("},{"line_number":346,"context_line":"                    task, last_error, collect_logs\u003dbool(self._client))"},{"line_number":347,"context_line":"            elif node.provision_state \u003d\u003d states.RESCUEWAIT:"},{"line_number":348,"context_line":"                task.driver.rescue.clean_up(task)"},{"line_number":349,"context_line":"                try:"},{"line_number":350,"context_line":"                    task.node.last_error \u003d last_error"},{"line_number":351,"context_line":"                    task.process_event(\u0027fail\u0027)"}],"source_content_type":"text/x-python","patch_set":69,"id":"df87a7cf_76621619","line":348,"in_reply_to":"ff82abbf_1bc4493f","updated":"2017-12-03 16:40:27.000000000","message":"Done","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6480163bc034276ee9b0ce674c90994fce9ace3e","unresolved":false,"context_lines":[{"line_number":348,"context_line":"                task.driver.rescue.clean_up(task)"},{"line_number":349,"context_line":"                try:"},{"line_number":350,"context_line":"                    task.node.last_error \u003d last_error"},{"line_number":351,"context_line":"                    task.process_event(\u0027fail\u0027)"},{"line_number":352,"context_line":"                except exception.InvalidState:"},{"line_number":353,"context_line":"                    LOG.exception(\u0027Internal error. Node %(node)s in provision \u0027"},{"line_number":354,"context_line":"                                  \u0027state RESCUEWAIT could not transition to \u0027"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff82abbf_7b6a351a","line":351,"updated":"2017-11-28 21:56:09.000000000","message":"do you know whether it is useful (I haven\u0027t actually looked at agent code) to collect the logs from the ramdisk, similar to what deploy_utils.set_failed_state() does? (Or maybe that can be done later, looks like it would need a new config option.)","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"075da2894b98641ebc44f6508c7f9f4bff729cfb","unresolved":false,"context_lines":[{"line_number":348,"context_line":"                task.driver.rescue.clean_up(task)"},{"line_number":349,"context_line":"                try:"},{"line_number":350,"context_line":"                    task.node.last_error \u003d last_error"},{"line_number":351,"context_line":"                    task.process_event(\u0027fail\u0027)"},{"line_number":352,"context_line":"                except exception.InvalidState:"},{"line_number":353,"context_line":"                    LOG.exception(\u0027Internal error. Node %(node)s in provision \u0027"},{"line_number":354,"context_line":"                                  \u0027state RESCUEWAIT could not transition to \u0027"}],"source_content_type":"text/x-python","patch_set":69,"id":"df87a7cf_a34b7085","line":351,"in_reply_to":"ff82abbf_7b6a351a","updated":"2017-12-03 16:40:27.000000000","message":"Not sure if we really need it as we do very limited work of setting the rescue password on the ramdisk. If required, we can add it later.","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6480163bc034276ee9b0ce674c90994fce9ace3e","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                try:"},{"line_number":350,"context_line":"                    task.node.last_error \u003d last_error"},{"line_number":351,"context_line":"                    task.process_event(\u0027fail\u0027)"},{"line_number":352,"context_line":"                except exception.InvalidState:"},{"line_number":353,"context_line":"                    LOG.exception(\u0027Internal error. Node %(node)s in provision \u0027"},{"line_number":354,"context_line":"                                  \u0027state RESCUEWAIT could not transition to \u0027"},{"line_number":355,"context_line":"                                  \u0027fail state.\u0027)"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff82abbf_7bceb55a","line":352,"updated":"2017-11-28 21:56:09.000000000","message":"if you think there might be an exception from task.process_event(), we should take the code for .last_error out of the try and save it, before task.process_event()","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"075da2894b98641ebc44f6508c7f9f4bff729cfb","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                try:"},{"line_number":350,"context_line":"                    task.node.last_error \u003d last_error"},{"line_number":351,"context_line":"                    task.process_event(\u0027fail\u0027)"},{"line_number":352,"context_line":"                except exception.InvalidState:"},{"line_number":353,"context_line":"                    LOG.exception(\u0027Internal error. Node %(node)s in provision \u0027"},{"line_number":354,"context_line":"                                  \u0027state RESCUEWAIT could not transition to \u0027"},{"line_number":355,"context_line":"                                  \u0027fail state.\u0027)"}],"source_content_type":"text/x-python","patch_set":69,"id":"df87a7cf_d5098edd","line":352,"in_reply_to":"ff82abbf_7bceb55a","updated":"2017-12-03 16:40:27.000000000","message":"Done","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6480163bc034276ee9b0ce674c90994fce9ace3e","unresolved":false,"context_lines":[{"line_number":354,"context_line":"                                  \u0027state RESCUEWAIT could not transition to \u0027"},{"line_number":355,"context_line":"                                  \u0027fail state.\u0027)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    @METRICS.timer(\u0027HeartbeatMixin._finalize_rescue\u0027)"},{"line_number":358,"context_line":"    def _finalize_rescue(self, task):"},{"line_number":359,"context_line":"        \"\"\"Call ramdisk to prepare rescue mode and verify result."},{"line_number":360,"context_line":""}],"source_content_type":"text/x-python","patch_set":69,"id":"ff82abbf_fbcc0536","line":357,"updated":"2017-11-28 21:56:09.000000000","message":"I don\u0027t think we want to capture metrics for internal methods like this. The timing for this is included in heartbeat() above. If we think we do want to collect this, then I suggest we change the method name to \u0027finalize_rescue\u0027.","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"075da2894b98641ebc44f6508c7f9f4bff729cfb","unresolved":false,"context_lines":[{"line_number":354,"context_line":"                                  \u0027state RESCUEWAIT could not transition to \u0027"},{"line_number":355,"context_line":"                                  \u0027fail state.\u0027)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    @METRICS.timer(\u0027HeartbeatMixin._finalize_rescue\u0027)"},{"line_number":358,"context_line":"    def _finalize_rescue(self, task):"},{"line_number":359,"context_line":"        \"\"\"Call ramdisk to prepare rescue mode and verify result."},{"line_number":360,"context_line":""}],"source_content_type":"text/x-python","patch_set":69,"id":"df87a7cf_b6065e20","line":357,"in_reply_to":"ff82abbf_fbcc0536","updated":"2017-12-03 16:40:27.000000000","message":"Done","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6480163bc034276ee9b0ce674c90994fce9ace3e","unresolved":false,"context_lines":[{"line_number":368,"context_line":"            # NOTE(mariojv) Caller will clean up failed rescue in exception"},{"line_number":369,"context_line":"            # handler."},{"line_number":370,"context_line":"            fail_reason \u003d (_(\u0027Agent returned bad command result for \u0027"},{"line_number":371,"context_line":"                             \u0027finalize_rescue: %(result)s\u0027) %"},{"line_number":372,"context_line":"                           {\u0027result\u0027: result.get(\u0027command_error\u0027)})"},{"line_number":373,"context_line":"            raise exception.InstanceRescueFailure(node\u003dnode.uuid,"},{"line_number":374,"context_line":"                                                  instance\u003dnode.instance_uuid,"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff82abbf_db97c1eb","line":371,"updated":"2017-11-28 21:56:09.000000000","message":"maybe \u0027Agent returned bad result for command finalize_rescue():... \u0027","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"075da2894b98641ebc44f6508c7f9f4bff729cfb","unresolved":false,"context_lines":[{"line_number":368,"context_line":"            # NOTE(mariojv) Caller will clean up failed rescue in exception"},{"line_number":369,"context_line":"            # handler."},{"line_number":370,"context_line":"            fail_reason \u003d (_(\u0027Agent returned bad command result for \u0027"},{"line_number":371,"context_line":"                             \u0027finalize_rescue: %(result)s\u0027) %"},{"line_number":372,"context_line":"                           {\u0027result\u0027: result.get(\u0027command_error\u0027)})"},{"line_number":373,"context_line":"            raise exception.InstanceRescueFailure(node\u003dnode.uuid,"},{"line_number":374,"context_line":"                                                  instance\u003dnode.instance_uuid,"}],"source_content_type":"text/x-python","patch_set":69,"id":"df87a7cf_4a088227","line":371,"in_reply_to":"ff82abbf_db97c1eb","updated":"2017-12-03 16:40:27.000000000","message":"Done","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"8e4b4f9d1ba6afdbbc65516e30d124a291a973d4","unresolved":false,"context_lines":[{"line_number":335,"context_line":"                    msg \u003d _(\u0027Node failed to check cleaning progress.\u0027)"},{"line_number":336,"context_line":"                    self.continue_cleaning(task)"},{"line_number":337,"context_line":"            elif (node.provision_state \u003d\u003d states.RESCUEWAIT):"},{"line_number":338,"context_line":"                self._finalize_rescue(task)"},{"line_number":339,"context_line":"        except Exception as e:"},{"line_number":340,"context_line":"            err_info \u003d {\u0027node\u0027: node.uuid, \u0027msg\u0027: msg, \u0027e\u0027: e}"},{"line_number":341,"context_line":"            last_error \u003d _(\u0027Asynchronous exception for node %(node)s: \u0027"}],"source_content_type":"text/x-python","patch_set":80,"id":"7f96bb07_2e1ba81b","line":338,"updated":"2018-01-12 03:19:48.000000000","message":"I wonder if we should see the agent_version. However, it might be fine to do it later with follow-up because rescuing fails anyway if the agent is old.","commit_id":"1d74d6dd34160d400edc2482b680d0520a598422"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"59e7f43c813937c8055a5464baff3d406e5bfd3d","unresolved":false,"context_lines":[{"line_number":335,"context_line":"                    msg \u003d _(\u0027Node failed to check cleaning progress.\u0027)"},{"line_number":336,"context_line":"                    self.continue_cleaning(task)"},{"line_number":337,"context_line":"            elif (node.provision_state \u003d\u003d states.RESCUEWAIT):"},{"line_number":338,"context_line":"                self._finalize_rescue(task)"},{"line_number":339,"context_line":"        except Exception as e:"},{"line_number":340,"context_line":"            err_info \u003d {\u0027node\u0027: node.uuid, \u0027msg\u0027: msg, \u0027e\u0027: e}"},{"line_number":341,"context_line":"            last_error \u003d _(\u0027Asynchronous exception for node %(node)s: \u0027"}],"source_content_type":"text/x-python","patch_set":80,"id":"7f96bb07_6659c958","line":338,"in_reply_to":"7f96bb07_2e1ba81b","updated":"2018-01-12 13:13:37.000000000","message":"It may not fail as IPA change for the rescue has merged prior to agent version feature.","commit_id":"1d74d6dd34160d400edc2482b680d0520a598422"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"01e15b2febb00d171379d7237235ee935246c97a","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                                                  instance\u003dnode.instance_uuid,"},{"line_number":369,"context_line":"                                                  reason\u003dfail_reason)"},{"line_number":370,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":371,"context_line":"        task.driver.rescue.clean_up(task)"},{"line_number":372,"context_line":"        task.driver.network.configure_tenant_networks(task)"},{"line_number":373,"context_line":"        task.process_event(\u0027done\u0027)"},{"line_number":374,"context_line":""}],"source_content_type":"text/x-python","patch_set":80,"id":"9f91af0f_a255eefb","line":371,"updated":"2018-01-10 13:26:08.000000000","message":"This clean up causes the unrescue to fail. After rescuing, this clean up remove the rescuing network. However rescuing network is required when unrescue. See L747 of:\n\nhttps://review.openstack.org/#/c/400437/80/ironic/drivers/modules/agent.py\n\nI encounter error \"No VIFs for node ...\".\nI think we may need to re-add rescuing network before unrescuing.","commit_id":"1d74d6dd34160d400edc2482b680d0520a598422"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"312cc928e93d5f9299d348fbd63197e0e9901a74","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                                                  instance\u003dnode.instance_uuid,"},{"line_number":369,"context_line":"                                                  reason\u003dfail_reason)"},{"line_number":370,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":371,"context_line":"        task.driver.rescue.clean_up(task)"},{"line_number":372,"context_line":"        task.driver.network.configure_tenant_networks(task)"},{"line_number":373,"context_line":"        task.process_event(\u0027done\u0027)"},{"line_number":374,"context_line":""}],"source_content_type":"text/x-python","patch_set":80,"id":"7f96bb07_bcccc489","line":371,"in_reply_to":"7f96bb07_07f023c9","updated":"2018-01-12 14:12:46.000000000","message":"Thanks for your help. The fix works.","commit_id":"1d74d6dd34160d400edc2482b680d0520a598422"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"fe37e44f35f49e7577d9986bdc525171b52f8c59","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                                                  instance\u003dnode.instance_uuid,"},{"line_number":369,"context_line":"                                                  reason\u003dfail_reason)"},{"line_number":370,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":371,"context_line":"        task.driver.rescue.clean_up(task)"},{"line_number":372,"context_line":"        task.driver.network.configure_tenant_networks(task)"},{"line_number":373,"context_line":"        task.process_event(\u0027done\u0027)"},{"line_number":374,"context_line":""}],"source_content_type":"text/x-python","patch_set":80,"id":"7f96bb07_6198fa69","line":371,"in_reply_to":"7f96bb07_24f21608","updated":"2018-01-11 10:14:22.000000000","message":"Here is the log of the error. Could you please have a look and investigate it. Thanks.\n\nhttp://paste.openstack.org/show/642544/","commit_id":"1d74d6dd34160d400edc2482b680d0520a598422"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"59e7f43c813937c8055a5464baff3d406e5bfd3d","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                                                  instance\u003dnode.instance_uuid,"},{"line_number":369,"context_line":"                                                  reason\u003dfail_reason)"},{"line_number":370,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":371,"context_line":"        task.driver.rescue.clean_up(task)"},{"line_number":372,"context_line":"        task.driver.network.configure_tenant_networks(task)"},{"line_number":373,"context_line":"        task.process_event(\u0027done\u0027)"},{"line_number":374,"context_line":""}],"source_content_type":"text/x-python","patch_set":80,"id":"7f96bb07_07f023c9","line":371,"in_reply_to":"7f96bb07_6198fa69","updated":"2018-01-12 13:13:37.000000000","message":"The fix required in network patch. You might have used same network for tenant and rescuing. Have removed add/remove_rescuing_network methods for flat network thereby rescue operation would be done on the tenant network itself. Please test and confirm in your environment using these new patches.","commit_id":"1d74d6dd34160d400edc2482b680d0520a598422"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"2f6b026f572cd475a7fde894b0bcf0d8c8b665bc","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                                                  instance\u003dnode.instance_uuid,"},{"line_number":369,"context_line":"                                                  reason\u003dfail_reason)"},{"line_number":370,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":371,"context_line":"        task.driver.rescue.clean_up(task)"},{"line_number":372,"context_line":"        task.driver.network.configure_tenant_networks(task)"},{"line_number":373,"context_line":"        task.process_event(\u0027done\u0027)"},{"line_number":374,"context_line":""}],"source_content_type":"text/x-python","patch_set":80,"id":"7f96bb07_24f21608","line":371,"in_reply_to":"9f91af0f_0dbe4bfe","updated":"2018-01-10 16:35:41.000000000","message":"Yes, my rescue succeeded, but unrescue.\nWhen unrescue, the line:\ntask.driver.boot.prepare_instance(task)\nwill eventually get the node VIF(s) to update DHCP opts, but at that time, there is no network associated with the node. That causes the error.","commit_id":"1d74d6dd34160d400edc2482b680d0520a598422"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7bd7af06e6317966ea1c950b3c8f82005b51f26b","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                                                  instance\u003dnode.instance_uuid,"},{"line_number":369,"context_line":"                                                  reason\u003dfail_reason)"},{"line_number":370,"context_line":"        task.process_event(\u0027resume\u0027)"},{"line_number":371,"context_line":"        task.driver.rescue.clean_up(task)"},{"line_number":372,"context_line":"        task.driver.network.configure_tenant_networks(task)"},{"line_number":373,"context_line":"        task.process_event(\u0027done\u0027)"},{"line_number":374,"context_line":""}],"source_content_type":"text/x-python","patch_set":80,"id":"9f91af0f_0dbe4bfe","line":371,"in_reply_to":"9f91af0f_a255eefb","updated":"2018-01-10 14:19:29.000000000","message":"We do not need rescuing network for unrescue(). We perform rescue.clean_up() [1], if node is not in RESCUE state to ensure that rescue network is cleaned up in case rescue operation had failed. Was your rescue operation was successful?\n[1] https://review.openstack.org/#/c/400437/80/ironic/drivers/modules/agent.py@766","commit_id":"1d74d6dd34160d400edc2482b680d0520a598422"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1dac7d3c279c5b3a5677d8a8c15106f4d2f40cc0","unresolved":false,"context_lines":[{"line_number":356,"context_line":"        :raises: InstanceRescueFailure, if rescuing failed"},{"line_number":357,"context_line":"        \"\"\""},{"line_number":358,"context_line":"        node \u003d task.node"},{"line_number":359,"context_line":"        result \u003d self._client.finalize_rescue(node)"},{"line_number":360,"context_line":"        if ((not result.get(\u0027command_status\u0027)) or"},{"line_number":361,"context_line":"                result.get(\u0027command_status\u0027) !\u003d \u0027SUCCEEDED\u0027):"},{"line_number":362,"context_line":"            # NOTE(mariojv) Caller will clean up failed rescue in exception"}],"source_content_type":"text/x-python","patch_set":83,"id":"7f96bb07_3b0cd7ea","line":359,"updated":"2018-01-16 22:20:28.000000000","message":"IronicException can be raised here. Do you want to raise InstanceRescueFailure instead? (Or update docstring.) Well, we should probably raise InstanceRescueFailure from here.","commit_id":"bcb1f7edcf57d3ec8a5c6d7c21226a62c529b980"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2e273cc81aab67841c3a2327e951fb2692ca2cf5","unresolved":false,"context_lines":[{"line_number":356,"context_line":"        :raises: InstanceRescueFailure, if rescuing failed"},{"line_number":357,"context_line":"        \"\"\""},{"line_number":358,"context_line":"        node \u003d task.node"},{"line_number":359,"context_line":"        result \u003d self._client.finalize_rescue(node)"},{"line_number":360,"context_line":"        if ((not result.get(\u0027command_status\u0027)) or"},{"line_number":361,"context_line":"                result.get(\u0027command_status\u0027) !\u003d \u0027SUCCEEDED\u0027):"},{"line_number":362,"context_line":"            # NOTE(mariojv) Caller will clean up failed rescue in exception"}],"source_content_type":"text/x-python","patch_set":83,"id":"7f96bb07_a3866e12","line":359,"in_reply_to":"7f96bb07_3b0cd7ea","updated":"2018-01-17 16:15:08.000000000","message":"Done","commit_id":"bcb1f7edcf57d3ec8a5c6d7c21226a62c529b980"}],"ironic/drivers/modules/agent_client.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1a9b0aea217f939a5f90b31387db826d0e793c04","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        \"\"\"Instruct the ramdisk to finalize entering of rescue mode.\"\"\""},{"line_number":209,"context_line":"        rescue_password \u003d node.instance_info[\u0027rescue_password\u0027]"},{"line_number":210,"context_line":"        params \u003d {\u0027rescue_password\u0027: rescue_password}"},{"line_number":211,"context_line":"        if node.instance_info.get(\u0027configdrive\u0027):"},{"line_number":212,"context_line":"            params.update({\u0027configdrive\u0027: node.instance_info[\u0027configdrive\u0027]})"},{"line_number":213,"context_line":"        return self._command(node, method\u003d\u0027rescue.finalize_rescue\u0027,"},{"line_number":214,"context_line":"                             params\u003dparams)"}],"source_content_type":"text/x-python","patch_set":24,"id":"9a30ddce_72180576","line":212,"range":{"start_line":211,"start_character":8,"end_line":212,"end_character":77},"updated":"2017-03-10 06:29:34.000000000","message":"I think this is not part of rescue feature and better be done through a separate feature patch where we would have appropriate usecase to pass data through config drive.","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"9c300868cdbbcceb3913129f87b47d20f7ab8671","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        \"\"\"Instruct the ramdisk to finalize entering of rescue mode.\"\"\""},{"line_number":209,"context_line":"        rescue_password \u003d node.instance_info[\u0027rescue_password\u0027]"},{"line_number":210,"context_line":"        params \u003d {\u0027rescue_password\u0027: rescue_password}"},{"line_number":211,"context_line":"        if node.instance_info.get(\u0027configdrive\u0027):"},{"line_number":212,"context_line":"            params.update({\u0027configdrive\u0027: node.instance_info[\u0027configdrive\u0027]})"},{"line_number":213,"context_line":"        return self._command(node, method\u003d\u0027rescue.finalize_rescue\u0027,"},{"line_number":214,"context_line":"                             params\u003dparams)"}],"source_content_type":"text/x-python","patch_set":24,"id":"1a1ced50_1253f26d","line":212,"range":{"start_line":211,"start_character":8,"end_line":212,"end_character":77},"in_reply_to":"9a30ddce_72180576","updated":"2017-03-23 17:23:15.000000000","message":"It is a part of the rescue feature and will be used soon, but you\u0027re right that this won\u0027t do anything until the agent can handle applying it. I\u0027ll remove it for now.","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"e131b5ded075751a089e07e1a1bfbd55ee2e3b34","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    @METRICS.timer(\u0027AgentClient.finalize_rescue\u0027)"},{"line_number":207,"context_line":"    def finalize_rescue(self, node):"},{"line_number":208,"context_line":"        \"\"\"Instruct the ramdisk to finalize entering of rescue mode.\"\"\""},{"line_number":209,"context_line":"        rescue_password \u003d node.instance_info[\u0027rescue_password\u0027]"},{"line_number":210,"context_line":"        params \u003d {\u0027rescue_password\u0027: rescue_password}"},{"line_number":211,"context_line":"        return self._command(node, method\u003d\u0027rescue.finalize_rescue\u0027,"},{"line_number":212,"context_line":"                             params\u003dparams)"}],"source_content_type":"text/x-python","patch_set":44,"id":"ff0f0b1f_aca8c2da","line":210,"range":{"start_line":209,"start_character":8,"end_line":210,"end_character":53},"updated":"2017-05-22 08:08:16.000000000","message":"This two line can be merged:\n\n  params \u003d {\u0027rescue_password\u0027: node.instance_info[\u0027rescue_password\u0027]}","commit_id":"97a8c1120bf1def69a5f3bd7e66f9d464766a1a9"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"6eac8f78bd7d1f778b5f11d6823f9972d52ddb99","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    @METRICS.timer(\u0027AgentClient.finalize_rescue\u0027)"},{"line_number":207,"context_line":"    def finalize_rescue(self, node):"},{"line_number":208,"context_line":"        \"\"\"Instruct the ramdisk to finalize entering of rescue mode.\"\"\""},{"line_number":209,"context_line":"        rescue_password \u003d node.instance_info[\u0027rescue_password\u0027]"},{"line_number":210,"context_line":"        params \u003d {\u0027rescue_password\u0027: rescue_password}"},{"line_number":211,"context_line":"        return self._command(node, method\u003d\u0027rescue.finalize_rescue\u0027,"},{"line_number":212,"context_line":"                             params\u003dparams)"}],"source_content_type":"text/x-python","patch_set":44,"id":"df140735_99f5d259","line":210,"range":{"start_line":209,"start_character":8,"end_line":210,"end_character":53},"in_reply_to":"ff0f0b1f_aca8c2da","updated":"2017-06-06 08:44:14.000000000","message":"Done","commit_id":"97a8c1120bf1def69a5f3bd7e66f9d464766a1a9"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6480163bc034276ee9b0ce674c90994fce9ace3e","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    @METRICS.timer(\u0027AgentClient.finalize_rescue\u0027)"},{"line_number":218,"context_line":"    def finalize_rescue(self, node):"},{"line_number":219,"context_line":"        \"\"\"Instruct the ramdisk to finalize entering of rescue mode.\"\"\""},{"line_number":220,"context_line":"        params \u003d {\u0027rescue_password\u0027: node.instance_info[\u0027rescue_password\u0027]}"},{"line_number":221,"context_line":"        return self._command(node, method\u003d\u0027rescue.finalize_rescue\u0027,"},{"line_number":222,"context_line":"                             params\u003dparams)"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff82abbf_018a9668","line":220,"updated":"2017-11-28 21:56:09.000000000","message":"do we know for sure that node.instance_info[\u0027rescue_password\u0027] exists?","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"075da2894b98641ebc44f6508c7f9f4bff729cfb","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    @METRICS.timer(\u0027AgentClient.finalize_rescue\u0027)"},{"line_number":218,"context_line":"    def finalize_rescue(self, node):"},{"line_number":219,"context_line":"        \"\"\"Instruct the ramdisk to finalize entering of rescue mode.\"\"\""},{"line_number":220,"context_line":"        params \u003d {\u0027rescue_password\u0027: node.instance_info[\u0027rescue_password\u0027]}"},{"line_number":221,"context_line":"        return self._command(node, method\u003d\u0027rescue.finalize_rescue\u0027,"},{"line_number":222,"context_line":"                             params\u003dparams)"}],"source_content_type":"text/x-python","patch_set":69,"id":"df87a7cf_6af786f7","line":220,"in_reply_to":"ff82abbf_018a9668","updated":"2017-12-03 16:40:27.000000000","message":"Done","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6480163bc034276ee9b0ce674c90994fce9ace3e","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    def finalize_rescue(self, node):"},{"line_number":219,"context_line":"        \"\"\"Instruct the ramdisk to finalize entering of rescue mode.\"\"\""},{"line_number":220,"context_line":"        params \u003d {\u0027rescue_password\u0027: node.instance_info[\u0027rescue_password\u0027]}"},{"line_number":221,"context_line":"        return self._command(node, method\u003d\u0027rescue.finalize_rescue\u0027,"},{"line_number":222,"context_line":"                             params\u003dparams)"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff82abbf_fb33a5a9","line":221,"updated":"2017-11-28 21:56:09.000000000","message":"if I look above at other calls to self._command(), I see node\u003dnode, so maybe we should do the same here.","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"075da2894b98641ebc44f6508c7f9f4bff729cfb","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    def finalize_rescue(self, node):"},{"line_number":219,"context_line":"        \"\"\"Instruct the ramdisk to finalize entering of rescue mode.\"\"\""},{"line_number":220,"context_line":"        params \u003d {\u0027rescue_password\u0027: node.instance_info[\u0027rescue_password\u0027]}"},{"line_number":221,"context_line":"        return self._command(node, method\u003d\u0027rescue.finalize_rescue\u0027,"},{"line_number":222,"context_line":"                             params\u003dparams)"}],"source_content_type":"text/x-python","patch_set":69,"id":"df87a7cf_eae2b62f","line":221,"in_reply_to":"ff82abbf_fb33a5a9","updated":"2017-12-03 16:40:27.000000000","message":"Done","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c7ca39ec5bdbb13f0642747215ecef08aa5bbc58","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    def finalize_rescue(self, node):"},{"line_number":219,"context_line":"        \"\"\"Instruct the ramdisk to finalize entering of rescue mode.\"\"\""},{"line_number":220,"context_line":"        rescue_pass \u003d node.instance_info.get(\u0027rescue_password\u0027)"},{"line_number":221,"context_line":"        if not rescue_pass:"},{"line_number":222,"context_line":"            raise exception.IronicException(_(\u0027Agent rescue requires \u0027"},{"line_number":223,"context_line":"                                              \u0027rescue_password in \u0027"},{"line_number":224,"context_line":"                                              \u0027instance_info\u0027))"}],"source_content_type":"text/x-python","patch_set":77,"id":"bf8cb3f7_b135fff9","line":221,"updated":"2017-12-20 22:53:26.000000000","message":"i have wondered this. Do we allow the password to be an empty string? If so, this won\u0027t work.","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3dec19f491aa2f384bbd9d40e31ab6766d682f7c","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    def finalize_rescue(self, node):"},{"line_number":219,"context_line":"        \"\"\"Instruct the ramdisk to finalize entering of rescue mode.\"\"\""},{"line_number":220,"context_line":"        rescue_pass \u003d node.instance_info.get(\u0027rescue_password\u0027)"},{"line_number":221,"context_line":"        if not rescue_pass:"},{"line_number":222,"context_line":"            raise exception.IronicException(_(\u0027Agent rescue requires \u0027"},{"line_number":223,"context_line":"                                              \u0027rescue_password in \u0027"},{"line_number":224,"context_line":"                                              \u0027instance_info\u0027))"}],"source_content_type":"text/x-python","patch_set":77,"id":"9f91af0f_a99eb760","line":221,"in_reply_to":"bf8cb3f7_b135fff9","updated":"2018-01-04 11:21:02.000000000","message":"Done","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"0d6188d014863071203160975548c317e4a98b2a","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    def finalize_rescue(self, node):"},{"line_number":219,"context_line":"        \"\"\"Instruct the ramdisk to finalize entering of rescue mode.\"\"\""},{"line_number":220,"context_line":"        rescue_pass \u003d node.instance_info.get(\u0027rescue_password\u0027)"},{"line_number":221,"context_line":"        if not (rescue_pass and rescue_pass.strip()):"},{"line_number":222,"context_line":"            raise exception.IronicException(_(\u0027Agent rescue requires \u0027"},{"line_number":223,"context_line":"                                              \u0027non-empty rescue_password in \u0027"},{"line_number":224,"context_line":"                                              \u0027instance_info\u0027))"}],"source_content_type":"text/x-python","patch_set":79,"id":"9f91af0f_48022a71","line":221,"range":{"start_line":221,"start_character":32,"end_line":221,"end_character":51},"updated":"2018-01-09 07:18:38.000000000","message":"Shouln\u0027t this validation be done in validate() of agent rescue interface or API for early detection?","commit_id":"57919485181626517143457f5375bb23887b4bd6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7bd7af06e6317966ea1c950b3c8f82005b51f26b","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    def finalize_rescue(self, node):"},{"line_number":219,"context_line":"        \"\"\"Instruct the ramdisk to finalize entering of rescue mode.\"\"\""},{"line_number":220,"context_line":"        rescue_pass \u003d node.instance_info.get(\u0027rescue_password\u0027)"},{"line_number":221,"context_line":"        if not (rescue_pass and rescue_pass.strip()):"},{"line_number":222,"context_line":"            raise exception.IronicException(_(\u0027Agent rescue requires \u0027"},{"line_number":223,"context_line":"                                              \u0027non-empty rescue_password in \u0027"},{"line_number":224,"context_line":"                                              \u0027instance_info\u0027))"}],"source_content_type":"text/x-python","patch_set":79,"id":"9f91af0f_a453c338","line":221,"range":{"start_line":221,"start_character":32,"end_line":221,"end_character":51},"in_reply_to":"9f91af0f_48022a71","updated":"2018-01-10 14:19:29.000000000","message":"Done","commit_id":"57919485181626517143457f5375bb23887b4bd6"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1dac7d3c279c5b3a5677d8a8c15106f4d2f40cc0","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    def finalize_rescue(self, node):"},{"line_number":219,"context_line":"        \"\"\"Instruct the ramdisk to finalize entering of rescue mode.\"\"\""},{"line_number":220,"context_line":"        rescue_pass \u003d node.instance_info.get(\u0027rescue_password\u0027)"},{"line_number":221,"context_line":"        if not rescue_pass:"},{"line_number":222,"context_line":"            raise exception.IronicException(_(\u0027Agent rescue requires \u0027"},{"line_number":223,"context_line":"                                              \u0027rescue_password in \u0027"},{"line_number":224,"context_line":"                                              \u0027instance_info\u0027))"}],"source_content_type":"text/x-python","patch_set":83,"id":"7f96bb07_1bad5be8","line":221,"updated":"2018-01-16 22:20:28.000000000","message":"I don\u0027t know if I asked this before, can rescue_pass be an empty string?\n\nOh, looks like it cannot.","commit_id":"bcb1f7edcf57d3ec8a5c6d7c21226a62c529b980"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2e273cc81aab67841c3a2327e951fb2692ca2cf5","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    def finalize_rescue(self, node):"},{"line_number":219,"context_line":"        \"\"\"Instruct the ramdisk to finalize entering of rescue mode.\"\"\""},{"line_number":220,"context_line":"        rescue_pass \u003d node.instance_info.get(\u0027rescue_password\u0027)"},{"line_number":221,"context_line":"        if not rescue_pass:"},{"line_number":222,"context_line":"            raise exception.IronicException(_(\u0027Agent rescue requires \u0027"},{"line_number":223,"context_line":"                                              \u0027rescue_password in \u0027"},{"line_number":224,"context_line":"                                              \u0027instance_info\u0027))"}],"source_content_type":"text/x-python","patch_set":83,"id":"7f96bb07_43dc4ae3","line":221,"in_reply_to":"7f96bb07_1bad5be8","updated":"2018-01-17 16:15:08.000000000","message":"Yes, handled in agent.AgentRescue.validate() as it will cause early failure if password is empty.","commit_id":"bcb1f7edcf57d3ec8a5c6d7c21226a62c529b980"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"abd1621ea37a8edb8200c71f0629d285e7bd435e","unresolved":false,"context_lines":[{"line_number":510,"context_line":"    if task.node.driver_internal_info.get(\u0027finalizing_rescue\u0027):"},{"line_number":511,"context_line":"        driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":512,"context_line":"        del driver_internal_info[\u0027finalizing_rescue\u0027]"},{"line_number":513,"context_line":"        task.node.driver_internal_info \u003d driver_internal_info"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"    try:"},{"line_number":516,"context_line":"        task.process_event(\u0027fail\u0027)"}],"source_content_type":"text/x-python","patch_set":24,"id":"9a30ddce_5a10a601","line":513,"range":{"start_line":513,"start_character":8,"end_line":513,"end_character":61},"updated":"2017-03-09 10:49:26.000000000","message":"Need to save node\n task.node.save()","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"7b5ac3178397fe62a2b93d283a065efe6bf90a26","unresolved":false,"context_lines":[{"line_number":510,"context_line":"    if task.node.driver_internal_info.get(\u0027finalizing_rescue\u0027):"},{"line_number":511,"context_line":"        driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":512,"context_line":"        del driver_internal_info[\u0027finalizing_rescue\u0027]"},{"line_number":513,"context_line":"        task.node.driver_internal_info \u003d driver_internal_info"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"    try:"},{"line_number":516,"context_line":"        task.process_event(\u0027fail\u0027)"}],"source_content_type":"text/x-python","patch_set":24,"id":"9a30ddce_98976f39","line":513,"range":{"start_line":513,"start_character":8,"end_line":513,"end_character":61},"in_reply_to":"9a30ddce_5a10a601","updated":"2017-03-09 19:44:51.000000000","message":"+1","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"9c300868cdbbcceb3913129f87b47d20f7ab8671","unresolved":false,"context_lines":[{"line_number":510,"context_line":"    if task.node.driver_internal_info.get(\u0027finalizing_rescue\u0027):"},{"line_number":511,"context_line":"        driver_internal_info \u003d task.node.driver_internal_info"},{"line_number":512,"context_line":"        del driver_internal_info[\u0027finalizing_rescue\u0027]"},{"line_number":513,"context_line":"        task.node.driver_internal_info \u003d driver_internal_info"},{"line_number":514,"context_line":""},{"line_number":515,"context_line":"    try:"},{"line_number":516,"context_line":"        task.process_event(\u0027fail\u0027)"}],"source_content_type":"text/x-python","patch_set":24,"id":"1a1ced50_f2b9f67a","line":513,"range":{"start_line":513,"start_character":8,"end_line":513,"end_character":61},"in_reply_to":"9a30ddce_98976f39","updated":"2017-03-23 17:23:15.000000000","message":"This will happen during task.process_event on L516 or at the end of this method (L535)","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"1044e44f85abefaf9cf8ed5bda23987137ed095b","unresolved":false,"context_lines":[{"line_number":954,"context_line":"    \"\"\"Build the options to be passed to the agent ramdisk."},{"line_number":955,"context_line":""},{"line_number":956,"context_line":"    :param node: an ironic node object"},{"line_number":957,"context_line":"    :param extra: (optional) dict of additional options to pass to the agent"},{"line_number":958,"context_line":"                  ramdisk"},{"line_number":959,"context_line":"    :returns: a dictionary containing the parameters to be passed to"},{"line_number":960,"context_line":"        agent ramdisk."}],"source_content_type":"text/x-python","patch_set":29,"id":"ffe62b97_f56f3e25","line":957,"updated":"2017-03-29 17:01:40.000000000","message":"Oops, missed removing this","commit_id":"f0db2961167792bab0703c8913a1bcbebf7df2d9"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"3598f5351bf96abce41bf1c66918ccf04db52fd0","unresolved":false,"context_lines":[{"line_number":523,"context_line":"            CONF.agent.deploy_logs_collect in (\u0027on_failure\u0027, \u0027always\u0027)):"},{"line_number":524,"context_line":"        driver_utils.collect_ramdisk_logs(node)"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"    if node.provision_state \u003d\u003d states.RESCUEWAIT:"},{"line_number":527,"context_line":"        task.driver.rescue.clean_up(task)"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":32,"id":"dfeb2761_3103e1ba","line":526,"updated":"2017-04-04 11:39:10.000000000","message":"I prefer move this code from here to exception handle.","commit_id":"5f7ab1fc99a21530aa40ffac3c61fbab68686b3f"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"227719ec8def4b709cf0780721325751993c90fb","unresolved":false,"context_lines":[{"line_number":523,"context_line":"            CONF.agent.deploy_logs_collect in (\u0027on_failure\u0027, \u0027always\u0027)):"},{"line_number":524,"context_line":"        driver_utils.collect_ramdisk_logs(node)"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"    if node.provision_state \u003d\u003d states.RESCUEWAIT:"},{"line_number":527,"context_line":"        task.driver.rescue.clean_up(task)"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":32,"id":"bff0334d_f89eb961","line":526,"in_reply_to":"dfeb2761_3103e1ba","updated":"2017-04-10 16:15:17.000000000","message":"Done","commit_id":"5f7ab1fc99a21530aa40ffac3c61fbab68686b3f"}],"ironic/drivers/modules/ilo/boot.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3f98e817122c0c90c16d93a1da13982451ff729c","unresolved":false,"context_lines":[{"line_number":413,"context_line":"        :param mode: Label indicating a deploy or rescue operation"},{"line_number":414,"context_line":"            being carried out on the node. Supported values are"},{"line_number":415,"context_line":"            \u0027deploy\u0027 and \u0027rescue\u0027. Defaults to \u0027deploy\u0027, indicating"},{"line_number":416,"context_line":"            deploy operation is being carried out."},{"line_number":417,"context_line":"        :returns: None"},{"line_number":418,"context_line":"        :raises: MissingParameterValue, if some information is missing in"},{"line_number":419,"context_line":"            node\u0027s driver_info or instance_info."}],"source_content_type":"text/x-python","patch_set":85,"id":"7f96bb07_a1e08d27","line":416,"updated":"2018-01-18 00:20:11.000000000","message":"This doesn\u0027t support rescue now. Should we put a TODO, or add code so that if it is \u0027rescue\u0027 it raises an exception? OR (sorry because I suggested this) maybe that code I suggested to put in the validate() is sufficient and we don\u0027t do this.\n\nMight be worth asking others; if I remember, I can ask tomorrow.","commit_id":"142a29c21be377bd007bf6487970a1de77ee90a0"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"05825b3305665de135f0e76b649ad53b07751d4e","unresolved":false,"context_lines":[{"line_number":413,"context_line":"        :param mode: Label indicating a deploy or rescue operation"},{"line_number":414,"context_line":"            being carried out on the node. Supported values are"},{"line_number":415,"context_line":"            \u0027deploy\u0027 and \u0027rescue\u0027. Defaults to \u0027deploy\u0027, indicating"},{"line_number":416,"context_line":"            deploy operation is being carried out."},{"line_number":417,"context_line":"        :returns: None"},{"line_number":418,"context_line":"        :raises: MissingParameterValue, if some information is missing in"},{"line_number":419,"context_line":"            node\u0027s driver_info or instance_info."}],"source_content_type":"text/x-python","patch_set":85,"id":"7f96bb07_c5526513","line":416,"in_reply_to":"7f96bb07_a1e08d27","updated":"2018-01-19 09:21:46.000000000","message":"Yes, I think we can do away with this. The suggested check in rescue.validate() to ensure that prepare_ramdisk and clean_up_ramdisk must have \u0027mode\u0027 in its arglist should be good enough.","commit_id":"142a29c21be377bd007bf6487970a1de77ee90a0"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"62cc27d2cec48a4854324ac56790e104ee773bf9","unresolved":false,"context_lines":[{"line_number":569,"context_line":"class IloPXEBoot(pxe.PXEBoot):"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"    @METRICS.timer(\u0027IloPXEBoot.prepare_ramdisk\u0027)"},{"line_number":572,"context_line":"    def prepare_ramdisk(self, task, ramdisk_params):"},{"line_number":573,"context_line":"        \"\"\"Prepares the boot of Ironic ramdisk using PXE."},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"        This method prepares the boot of the deploy ramdisk after"}],"source_content_type":"text/x-python","patch_set":86,"id":"7f96bb07_4c188474","line":572,"updated":"2018-01-22 04:09:56.000000000","message":"I think this interface can support rescue by adding mode parameter because this is a subclass of PXEBoot interface.","commit_id":"2f44114aa649e62c70f8a00677fac084ba06fe75"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"326fce97a92feb9973de7eb4b9017c1e92da9202","unresolved":false,"context_lines":[{"line_number":569,"context_line":"class IloPXEBoot(pxe.PXEBoot):"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"    @METRICS.timer(\u0027IloPXEBoot.prepare_ramdisk\u0027)"},{"line_number":572,"context_line":"    def prepare_ramdisk(self, task, ramdisk_params):"},{"line_number":573,"context_line":"        \"\"\"Prepares the boot of Ironic ramdisk using PXE."},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"        This method prepares the boot of the deploy ramdisk after"}],"source_content_type":"text/x-python","patch_set":86,"id":"7f96bb07_fdd1fc30","line":572,"in_reply_to":"7f96bb07_4c188474","updated":"2018-01-22 05:18:11.000000000","message":"May be that can be done as a separate patch for enabling rescue for the vendor interfaces.","commit_id":"2f44114aa649e62c70f8a00677fac084ba06fe75"}],"ironic/drivers/modules/irmc/boot.py":[{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"62cc27d2cec48a4854324ac56790e104ee773bf9","unresolved":false,"context_lines":[{"line_number":1040,"context_line":"    \"\"\"iRMC PXE boot.\"\"\""},{"line_number":1041,"context_line":""},{"line_number":1042,"context_line":"    @METRICS.timer(\u0027IRMCPXEBoot.prepare_ramdisk\u0027)"},{"line_number":1043,"context_line":"    def prepare_ramdisk(self, task, ramdisk_params):"},{"line_number":1044,"context_line":"        \"\"\"Prepares the boot of Ironic ramdisk using PXE."},{"line_number":1045,"context_line":""},{"line_number":1046,"context_line":"        This method prepares the boot of the deploy kernel/ramdisk after"}],"source_content_type":"text/x-python","patch_set":86,"id":"7f96bb07_ac20289d","line":1043,"updated":"2018-01-22 04:09:56.000000000","message":"I think this interface can support rescue by adding mode parameter because this is a subclass of PXEBoot interface.","commit_id":"2f44114aa649e62c70f8a00677fac084ba06fe75"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"577bf4e4bc2af950b62f5d276cad129b143a54b4","unresolved":false,"context_lines":[{"line_number":1040,"context_line":"    \"\"\"iRMC PXE boot.\"\"\""},{"line_number":1041,"context_line":""},{"line_number":1042,"context_line":"    @METRICS.timer(\u0027IRMCPXEBoot.prepare_ramdisk\u0027)"},{"line_number":1043,"context_line":"    def prepare_ramdisk(self, task, ramdisk_params):"},{"line_number":1044,"context_line":"        \"\"\"Prepares the boot of Ironic ramdisk using PXE."},{"line_number":1045,"context_line":""},{"line_number":1046,"context_line":"        This method prepares the boot of the deploy kernel/ramdisk after"}],"source_content_type":"text/x-python","patch_set":86,"id":"7f96bb07_5d9a706e","line":1043,"in_reply_to":"7f96bb07_ac20289d","updated":"2018-01-22 05:20:44.000000000","message":"May be that can be done as a separate patch for enabling rescue for the vendor interfaces.","commit_id":"2f44114aa649e62c70f8a00677fac084ba06fe75"}],"ironic/drivers/modules/network/common.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"ab4ff5fe59bcddd7948bbcdeced0894aef00079c","unresolved":false,"context_lines":[{"line_number":373,"context_line":"                p_obj.internal_info.get(\u0027provisioning_vif_port_id\u0027) or"},{"line_number":374,"context_line":"                p_obj.internal_info.get(\u0027rescue_vif_port_id\u0027) or"},{"line_number":375,"context_line":"                self._get_vif_id_by_port_like_obj(p_obj) or None)"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"class NeutronVIFPortIDMixin(VIFPortIDMixin):"},{"line_number":379,"context_line":"    \"\"\"VIF port ID mixin class for neutron network interfaces."}],"source_content_type":"text/x-python","patch_set":56,"id":"7f515b1d_72c6566a","line":376,"updated":"2017-09-25 07:23:27.000000000","message":"the docstring needs an update","commit_id":"4701e09b29e197c8637f72fd7ff49db4d1710154"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0d3bbf64848681dffa77a8a8e106cfa7929beffc","unresolved":false,"context_lines":[{"line_number":373,"context_line":"                p_obj.internal_info.get(\u0027provisioning_vif_port_id\u0027) or"},{"line_number":374,"context_line":"                p_obj.internal_info.get(\u0027rescue_vif_port_id\u0027) or"},{"line_number":375,"context_line":"                self._get_vif_id_by_port_like_obj(p_obj) or None)"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"class NeutronVIFPortIDMixin(VIFPortIDMixin):"},{"line_number":379,"context_line":"    \"\"\"VIF port ID mixin class for neutron network interfaces."}],"source_content_type":"text/x-python","patch_set":56,"id":"7f515b1d_edc6c049","line":376,"in_reply_to":"7f515b1d_72c6566a","updated":"2017-09-27 16:31:32.000000000","message":"Done","commit_id":"4701e09b29e197c8637f72fd7ff49db4d1710154"}],"ironic/drivers/modules/network/flat.py":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"46e53661fe8cd902a83da0535e1eeb33a3ea320a","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        for port in task.ports:"},{"line_number":144,"context_line":"            # TODO Should we raise an error here if provisioning or cleaning"},{"line_number":145,"context_line":"            # VIF port IDs are present here? We\u0027d check for the key name, not"},{"line_number":146,"context_line":"            # UUID, in case cleaning and rescue nets are the same."},{"line_number":147,"context_line":"            if port.uuid in vifs:"},{"line_number":148,"context_line":"                internal_info \u003d port.internal_info"},{"line_number":149,"context_line":"                internal_info[\u0027rescue_vif_port_id\u0027] \u003d vifs[port.uuid]"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_da01d707","line":146,"updated":"2016-12-05 22:40:06.000000000","message":"note to self, they *have* to be the same","commit_id":"c272f7d59f62be0615d6b4a4ceeef878a539fd14"},{"author":{"_account_id":22931,"name":"Taku Izumi","email":"izumi.taku@jp.fujitsu.com","username":"izumi777"},"change_message_id":"5f1644558cdedf374aaf50f935f860e6dd0b4a5a","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        :returns: a dictionary in the form {port.uuid: neutron_port[\u0027id\u0027]}"},{"line_number":131,"context_line":"        :raises: NetworkError, InvalidParameterValue"},{"line_number":132,"context_line":"        \"\"\""},{"line_number":133,"context_line":"        if not uuidutils.is_uuid_like(CONF.neutron.rescue_network_uuid):"},{"line_number":134,"context_line":"            raise exception.InvalidParameterValue(_("},{"line_number":135,"context_line":"                \u0027You must provide a valid rescue network UUID in \u0027"},{"line_number":136,"context_line":"                \u0027[neutron]rescue_network_uuid configuration option.\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_8bc8ba56","line":133,"range":{"start_line":133,"start_character":15,"end_line":133,"end_character":24},"updated":"2016-12-07 02:01:16.000000000","message":"uuidutils is not imported here","commit_id":"76ad460c60afdb84c2a4c5d6038154180d7d7866"},{"author":{"_account_id":22931,"name":"Taku Izumi","email":"izumi.taku@jp.fujitsu.com","username":"izumi777"},"change_message_id":"486636c6659a46aa470e446d6c1eddc05c5deec9","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            # UUID, in case cleaning and rescue nets are the same."},{"line_number":147,"context_line":"            if port.uuid in vifs:"},{"line_number":148,"context_line":"                internal_info \u003d port.internal_info"},{"line_number":149,"context_line":"                internal_info[\u0027rescue_vif_port_id\u0027] \u003d vifs[port.uuid]"},{"line_number":150,"context_line":"                port.internal_info \u003d internal_info"},{"line_number":151,"context_line":"                port.save()"},{"line_number":152,"context_line":"        return vifs"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_e5eeb620","line":149,"range":{"start_line":149,"start_character":30,"end_line":149,"end_character":50},"updated":"2016-12-07 05:16:35.000000000","message":"You should also modify get_node_vif_ids() in ironic/common/network.py to support \u0027rescue_vif_port_id\u0027, right ?","commit_id":"76ad460c60afdb84c2a4c5d6038154180d7d7866"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"8a2c5a42639dccb12e30ac995086e598eb915cd8","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        neutron.rollback_ports(task, self.get_rescue_network_uuid())"},{"line_number":158,"context_line":"        LOG.info(_LI(\u0027Adding rescue network to node %s\u0027), task.node.uuid)"},{"line_number":159,"context_line":"        vifs \u003d neutron.add_ports_to_network("},{"line_number":160,"context_line":"            task, self.get_rescue_network_uuid(), is_flat\u003dTrue)"},{"line_number":161,"context_line":"        for port in task.ports:"},{"line_number":162,"context_line":"            if port.uuid in vifs:"},{"line_number":163,"context_line":"                internal_info \u003d port.internal_info"}],"source_content_type":"text/x-python","patch_set":24,"id":"9a30ddce_1a25e05a","line":160,"range":{"start_line":160,"start_character":50,"end_line":160,"end_character":62},"updated":"2017-03-13 10:45:28.000000000","message":"How is it getting used? I couldn\u0027t find the related changes at https://review.openstack.org/#/c/400437/24/ironic/common/neutron.py@163","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"9c300868cdbbcceb3913129f87b47d20f7ab8671","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        neutron.rollback_ports(task, self.get_rescue_network_uuid())"},{"line_number":158,"context_line":"        LOG.info(_LI(\u0027Adding rescue network to node %s\u0027), task.node.uuid)"},{"line_number":159,"context_line":"        vifs \u003d neutron.add_ports_to_network("},{"line_number":160,"context_line":"            task, self.get_rescue_network_uuid(), is_flat\u003dTrue)"},{"line_number":161,"context_line":"        for port in task.ports:"},{"line_number":162,"context_line":"            if port.uuid in vifs:"},{"line_number":163,"context_line":"                internal_info \u003d port.internal_info"}],"source_content_type":"text/x-python","patch_set":24,"id":"1a1ced50_125db248","line":160,"range":{"start_line":160,"start_character":50,"end_line":160,"end_character":62},"in_reply_to":"9a30ddce_1a25e05a","updated":"2017-03-23 17:23:15.000000000","message":"Ah, it\u0027s not. Must have missed this during a rebase. Thanks","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"b69c24e84edced631b5b6a90c4e04db6f9040be6","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        # If we have left over ports from a previous rescue (aka if this is a"},{"line_number":156,"context_line":"        # re-rescue), remove them"},{"line_number":157,"context_line":"        neutron.rollback_ports(task, self.get_rescue_network_uuid())"},{"line_number":158,"context_line":"        LOG.info(_LI(\u0027Adding rescue network to node %s\u0027), task.node.uuid)"},{"line_number":159,"context_line":"        vifs \u003d neutron.add_ports_to_network("},{"line_number":160,"context_line":"            task, self.get_rescue_network_uuid())"},{"line_number":161,"context_line":"        for port in task.ports:"}],"source_content_type":"text/x-python","patch_set":27,"id":"ffe62b97_274e0e6f","line":158,"range":{"start_line":158,"start_character":17,"end_line":158,"end_character":20},"updated":"2017-03-27 15:55:08.000000000","message":"this is not required now.","commit_id":"0f81050cf6ca173f504835611f1c65fe74b6fdd9"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"fc8b2c891c6e0d972220763c934e4993c94f616a","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        # If we have left over ports from a previous rescue (aka if this is a"},{"line_number":156,"context_line":"        # re-rescue), remove them"},{"line_number":157,"context_line":"        neutron.rollback_ports(task, self.get_rescue_network_uuid())"},{"line_number":158,"context_line":"        LOG.info(_LI(\u0027Adding rescue network to node %s\u0027), task.node.uuid)"},{"line_number":159,"context_line":"        vifs \u003d neutron.add_ports_to_network("},{"line_number":160,"context_line":"            task, self.get_rescue_network_uuid())"},{"line_number":161,"context_line":"        for port in task.ports:"}],"source_content_type":"text/x-python","patch_set":27,"id":"ffe62b97_2e71de44","line":158,"range":{"start_line":158,"start_character":17,"end_line":158,"end_character":20},"in_reply_to":"ffe62b97_274e0e6f","updated":"2017-03-29 16:52:24.000000000","message":"There are other places in this module that require clean-up: https://github.com/openstack/ironic/blob/c6abd511599afcf5d823f092e24b2a4fd2863048/ironic/drivers/modules/network/flat.py#L137\n\nI\u0027ll clean in a follow up (or here) if clean up of this file lands before this patch.","commit_id":"0f81050cf6ca173f504835611f1c65fe74b6fdd9"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"b69c24e84edced631b5b6a90c4e04db6f9040be6","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        vifs \u003d neutron.add_ports_to_network("},{"line_number":160,"context_line":"            task, self.get_rescue_network_uuid())"},{"line_number":161,"context_line":"        for port in task.ports:"},{"line_number":162,"context_line":"            if port.uuid in vifs:"},{"line_number":163,"context_line":"                internal_info \u003d port.internal_info"},{"line_number":164,"context_line":"                internal_info[\u0027rescue_vif_port_id\u0027] \u003d vifs[port.uuid]"},{"line_number":165,"context_line":"                port.internal_info \u003d internal_info"}],"source_content_type":"text/x-python","patch_set":27,"id":"ffe62b97_07354af7","line":162,"range":{"start_line":162,"start_character":12,"end_line":162,"end_character":33},"updated":"2017-03-27 15:55:08.000000000","message":"would we have multiple port in the rescue network? if not, why not break the loop to ignore useless iteration when hit. not sure if we can improve it, for i see other interfaces doing the same full loop.","commit_id":"0f81050cf6ca173f504835611f1c65fe74b6fdd9"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"fc8b2c891c6e0d972220763c934e4993c94f616a","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        vifs \u003d neutron.add_ports_to_network("},{"line_number":160,"context_line":"            task, self.get_rescue_network_uuid())"},{"line_number":161,"context_line":"        for port in task.ports:"},{"line_number":162,"context_line":"            if port.uuid in vifs:"},{"line_number":163,"context_line":"                internal_info \u003d port.internal_info"},{"line_number":164,"context_line":"                internal_info[\u0027rescue_vif_port_id\u0027] \u003d vifs[port.uuid]"},{"line_number":165,"context_line":"                port.internal_info \u003d internal_info"}],"source_content_type":"text/x-python","patch_set":27,"id":"ffe62b97_6ef7e68c","line":162,"range":{"start_line":162,"start_character":12,"end_line":162,"end_character":33},"in_reply_to":"ffe62b97_07354af7","updated":"2017-03-29 16:52:24.000000000","message":"This is iterating through node ports, not neutron ports, so I think it\u0027s useful. Imagine someone has some hardware with flaky NICs and wanted all NICs to attempt to PXE.","commit_id":"0f81050cf6ca173f504835611f1c65fe74b6fdd9"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"b69c24e84edced631b5b6a90c4e04db6f9040be6","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        :param task: A TaskManager instance."},{"line_number":173,"context_line":"        :raises: NetworkError"},{"line_number":174,"context_line":"        \"\"\""},{"line_number":175,"context_line":"        LOG.info(_LI(\u0027Removing ports from rescue network for node %s\u0027),"},{"line_number":176,"context_line":"                 task.node.uuid)"},{"line_number":177,"context_line":"        neutron.remove_ports_from_network("},{"line_number":178,"context_line":"            task, self.get_rescue_network_uuid())"}],"source_content_type":"text/x-python","patch_set":27,"id":"ffe62b97_07e1cad0","line":175,"range":{"start_line":175,"start_character":17,"end_line":175,"end_character":20},"updated":"2017-03-27 15:55:08.000000000","message":"dito","commit_id":"0f81050cf6ca173f504835611f1c65fe74b6fdd9"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"fc8b2c891c6e0d972220763c934e4993c94f616a","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        :param task: A TaskManager instance."},{"line_number":173,"context_line":"        :raises: NetworkError"},{"line_number":174,"context_line":"        \"\"\""},{"line_number":175,"context_line":"        LOG.info(_LI(\u0027Removing ports from rescue network for node %s\u0027),"},{"line_number":176,"context_line":"                 task.node.uuid)"},{"line_number":177,"context_line":"        neutron.remove_ports_from_network("},{"line_number":178,"context_line":"            task, self.get_rescue_network_uuid())"}],"source_content_type":"text/x-python","patch_set":27,"id":"ffe62b97_ee941639","line":175,"range":{"start_line":175,"start_character":17,"end_line":175,"end_character":20},"in_reply_to":"ffe62b97_07e1cad0","updated":"2017-03-29 16:52:24.000000000","message":"See L158.","commit_id":"0f81050cf6ca173f504835611f1c65fe74b6fdd9"}],"ironic/drivers/modules/network/neutron.py":[{"author":{"_account_id":22931,"name":"Taku Izumi","email":"izumi.taku@jp.fujitsu.com","username":"izumi777"},"change_message_id":"58f27940e8c5930869e96ac7099e7c3eebc8c224","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        for port in task.ports:"},{"line_number":153,"context_line":"            if port.uuid in vifs:"},{"line_number":154,"context_line":"                internal_info \u003d port.internal_info"},{"line_number":155,"context_line":"                internal_info[\u0027rescue_vif_port_id\u0027] \u003d vifs[port.uuid]"},{"line_number":156,"context_line":"                port.internal_info \u003d internal_info"},{"line_number":157,"context_line":"                port.save()"},{"line_number":158,"context_line":"        return vifs"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_b48259c6","line":155,"range":{"start_line":155,"start_character":30,"end_line":155,"end_character":50},"updated":"2016-12-16 11:07:34.000000000","message":"You also have to revise get_node_vif_ids() ?\n\ndiff --git a/ironic/common/network.py b/ironic/common/network.py\nindex db814fc..fe05938 100644\n--- a/ironic/common/network.py\n+++ b/ironic/common/network.py\n@@ -41,6 +41,7 @@ def get_node_vif_ids(task):\n         # network\n         vif \u003d (portgroup.internal_info.get(\u0027cleaning_vif_port_id\u0027) or\n                portgroup.internal_info.get(\u0027provisioning_vif_port_id\u0027) or\n+              portgroup.internal_info.get(\u0027rescue_vif_port_id\u0027) or\n                portgroup.extra.get(\u0027vif_port_id\u0027))\n         if vif:\n             portgroup_vifs[portgroup.uuid] \u003d vif\n@@ -48,6 +49,7 @@ def get_node_vif_ids(task):\n     for port in task.ports:\n         vif \u003d (port.internal_info.get(\u0027cleaning_vif_port_id\u0027) or\n                port.internal_info.get(\u0027provisioning_vif_port_id\u0027) or\n+              port.internal_info.get(\u0027rescue_vif_port_id\u0027) or\n                port.extra.get(\u0027vif_port_id\u0027))\n         if vif:\n             port_vifs[port.uuid] \u003d vif","commit_id":"55847c4ca3cd299f03e182085e15248dfa7ccc1c"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"7b42cf8ad1ebac30a4311f803e3f90f0af2dbc72","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        for port in task.ports:"},{"line_number":153,"context_line":"            if port.uuid in vifs:"},{"line_number":154,"context_line":"                internal_info \u003d port.internal_info"},{"line_number":155,"context_line":"                internal_info[\u0027rescue_vif_port_id\u0027] \u003d vifs[port.uuid]"},{"line_number":156,"context_line":"                port.internal_info \u003d internal_info"},{"line_number":157,"context_line":"                port.save()"},{"line_number":158,"context_line":"        return vifs"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_282f5ca2","line":155,"range":{"start_line":155,"start_character":30,"end_line":155,"end_character":50},"in_reply_to":"1a6eadb0_b48259c6","updated":"2016-12-19 21:30:33.000000000","message":"You\u0027re right, otherwise setting DHCP options would fail. Unit tests wouldn\u0027t have caught this because of the way mocks are set up.\n\nWill fix in next patch set, thanks.","commit_id":"55847c4ca3cd299f03e182085e15248dfa7ccc1c"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"b69c24e84edced631b5b6a90c4e04db6f9040be6","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        \"\"\""},{"line_number":149,"context_line":"        # If we have left over ports from a previous rescue, remove them"},{"line_number":150,"context_line":"        neutron.rollback_ports(task, self.get_rescue_network_uuid())"},{"line_number":151,"context_line":"        LOG.info(_LI(\u0027Adding rescue network to node %s\u0027), task.node.uuid)"},{"line_number":152,"context_line":"        security_groups \u003d CONF.neutron.rescue_network_security_groups"},{"line_number":153,"context_line":"        vifs \u003d neutron.add_ports_to_network(task,"},{"line_number":154,"context_line":"                                            self.get_rescue_network_uuid(),"}],"source_content_type":"text/x-python","patch_set":27,"id":"ffe62b97_47efd2af","line":151,"range":{"start_line":151,"start_character":17,"end_line":151,"end_character":20},"updated":"2017-03-27 15:55:08.000000000","message":"dito","commit_id":"0f81050cf6ca173f504835611f1c65fe74b6fdd9"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"fc8b2c891c6e0d972220763c934e4993c94f616a","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        \"\"\""},{"line_number":149,"context_line":"        # If we have left over ports from a previous rescue, remove them"},{"line_number":150,"context_line":"        neutron.rollback_ports(task, self.get_rescue_network_uuid())"},{"line_number":151,"context_line":"        LOG.info(_LI(\u0027Adding rescue network to node %s\u0027), task.node.uuid)"},{"line_number":152,"context_line":"        security_groups \u003d CONF.neutron.rescue_network_security_groups"},{"line_number":153,"context_line":"        vifs \u003d neutron.add_ports_to_network(task,"},{"line_number":154,"context_line":"                                            self.get_rescue_network_uuid(),"}],"source_content_type":"text/x-python","patch_set":27,"id":"ffe62b97_2e42feab","line":151,"range":{"start_line":151,"start_character":17,"end_line":151,"end_character":20},"in_reply_to":"ffe62b97_47efd2af","updated":"2017-03-29 16:52:24.000000000","message":"https://github.com/openstack/ironic/blob/c6abd511599afcf5d823f092e24b2a4fd2863048/ironic/drivers/modules/network/neutron.py#L74\n\nSame as other places, will clean up if cleanup lands before this","commit_id":"0f81050cf6ca173f504835611f1c65fe74b6fdd9"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"b69c24e84edced631b5b6a90c4e04db6f9040be6","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        :param task: a TaskManager instance."},{"line_number":168,"context_line":"        :raises: NetworkError"},{"line_number":169,"context_line":"        \"\"\""},{"line_number":170,"context_line":"        LOG.info(_LI(\u0027Removing rescue network from node %s\u0027),"},{"line_number":171,"context_line":"                 task.node.uuid)"},{"line_number":172,"context_line":"        neutron.remove_ports_from_network("},{"line_number":173,"context_line":"            task, self.get_rescue_network_uuid())"}],"source_content_type":"text/x-python","patch_set":27,"id":"ffe62b97_873a7a31","line":170,"range":{"start_line":170,"start_character":17,"end_line":170,"end_character":20},"updated":"2017-03-27 15:55:08.000000000","message":"dito","commit_id":"0f81050cf6ca173f504835611f1c65fe74b6fdd9"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"fc8b2c891c6e0d972220763c934e4993c94f616a","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        :param task: a TaskManager instance."},{"line_number":168,"context_line":"        :raises: NetworkError"},{"line_number":169,"context_line":"        \"\"\""},{"line_number":170,"context_line":"        LOG.info(_LI(\u0027Removing rescue network from node %s\u0027),"},{"line_number":171,"context_line":"                 task.node.uuid)"},{"line_number":172,"context_line":"        neutron.remove_ports_from_network("},{"line_number":173,"context_line":"            task, self.get_rescue_network_uuid())"}],"source_content_type":"text/x-python","patch_set":27,"id":"ffe62b97_ce0cb295","line":170,"range":{"start_line":170,"start_character":17,"end_line":170,"end_character":20},"in_reply_to":"ffe62b97_873a7a31","updated":"2017-03-29 16:52:24.000000000","message":"See L151.","commit_id":"0f81050cf6ca173f504835611f1c65fe74b6fdd9"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"961257c0e38b053668aae3ee84abad5bc7cd54fe","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        \"\"\"Create neutron ports for each port to boot the rescue ramdisk."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        :param task: a TaskManager instance."},{"line_number":144,"context_line":"        :raises: NetworkError"},{"line_number":145,"context_line":"        :returns: a dictionary in the form {port.uuid: neutron_port[\u0027id\u0027]}"},{"line_number":146,"context_line":"        \"\"\""},{"line_number":147,"context_line":"        # If we have left over ports from a previous rescue, remove them"}],"source_content_type":"text/x-python","patch_set":51,"id":"ff346bd7_672c9099","line":144,"range":{"start_line":144,"start_character":9,"end_line":144,"end_character":29},"updated":"2017-07-21 22:07:04.000000000","message":"I see that add_ports_to_network() already raise this exception, is there any other method catching the exception NetworkError?","commit_id":"885d936ae5163ad000a0fabb7643f4b2d2fb3b60"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"797eac90108d1d0bee78320e222bbc52a0ddb55b","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        \"\"\"Create neutron ports for each port to boot the rescue ramdisk."},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        :param task: a TaskManager instance."},{"line_number":144,"context_line":"        :raises: NetworkError"},{"line_number":145,"context_line":"        :returns: a dictionary in the form {port.uuid: neutron_port[\u0027id\u0027]}"},{"line_number":146,"context_line":"        \"\"\""},{"line_number":147,"context_line":"        # If we have left over ports from a previous rescue, remove them"}],"source_content_type":"text/x-python","patch_set":51,"id":"df3967d1_c718be82","line":144,"range":{"start_line":144,"start_character":9,"end_line":144,"end_character":29},"in_reply_to":"ff346bd7_672c9099","updated":"2017-07-31 11:44:27.000000000","message":"Removed","commit_id":"885d936ae5163ad000a0fabb7643f4b2d2fb3b60"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"ab4ff5fe59bcddd7948bbcdeced0894aef00079c","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                del internal_info[\u0027rescue_vif_port_id\u0027]"},{"line_number":175,"context_line":"                port.internal_info \u003d internal_info"},{"line_number":176,"context_line":"                port.save()"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def configure_tenant_networks(self, task):"},{"line_number":179,"context_line":"        \"\"\"Configure tenant networks for a node."},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":56,"id":"7f515b1d_3f0546c3","line":177,"updated":"2017-09-25 07:23:27.000000000","message":"any thoughts about removing duplicated code with cleaning and provisioning network operation? they share the same process, only vif key name, security group and network uuid are different.","commit_id":"4701e09b29e197c8637f72fd7ff49db4d1710154"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0d3bbf64848681dffa77a8a8e106cfa7929beffc","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                del internal_info[\u0027rescue_vif_port_id\u0027]"},{"line_number":175,"context_line":"                port.internal_info \u003d internal_info"},{"line_number":176,"context_line":"                port.save()"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def configure_tenant_networks(self, task):"},{"line_number":179,"context_line":"        \"\"\"Configure tenant networks for a node."},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":56,"id":"7f515b1d_edcb6047","line":177,"in_reply_to":"7f515b1d_3f0546c3","updated":"2017-09-27 16:31:32.000000000","message":"Yes, that needs to be done, but should be done as a separate patch outside this feature.","commit_id":"4701e09b29e197c8637f72fd7ff49db4d1710154"}],"ironic/drivers/modules/pxe.py":[{"author":{"_account_id":22931,"name":"Taku Izumi","email":"izumi.taku@jp.fujitsu.com","username":"izumi777"},"change_message_id":"978451fa93df106348352de0ab39ca956bf0917a","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    :raises: MissingParameterValue"},{"line_number":64,"context_line":"    \"\"\""},{"line_number":65,"context_line":"    info \u003d node.driver_info"},{"line_number":66,"context_line":"    d_info \u003d {k: info.get(k) for k in (\u0027deploy_kernel\u0027, \u0027deploy_ramdisk\u0027)}"},{"line_number":67,"context_line":"    error_msg \u003d _(\"Cannot validate PXE bootloader. Some parameters were\""},{"line_number":68,"context_line":"                  \" missing in node\u0027s driver_info\")"},{"line_number":69,"context_line":"    deploy_utils.check_for_missing_params(d_info, error_msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_de054e10","line":66,"range":{"start_line":66,"start_character":39,"end_line":66,"end_character":72},"updated":"2016-12-12 10:15:08.000000000","message":"for k in (\u0027deploy_kernel\u0027, \u0027deploy_ramdisk\u0027, \u0027rescue_kernel\u0027, \u0027rescue_ramdisk\u0027)  ?","commit_id":"ebd35d548f235c9746b1497108a4fd87cb2b317d"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"0b44b675dffb8274cfd34724343a91690b2b5d29","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    :raises: MissingParameterValue"},{"line_number":64,"context_line":"    \"\"\""},{"line_number":65,"context_line":"    info \u003d node.driver_info"},{"line_number":66,"context_line":"    d_info \u003d {k: info.get(k) for k in (\u0027deploy_kernel\u0027, \u0027deploy_ramdisk\u0027)}"},{"line_number":67,"context_line":"    error_msg \u003d _(\"Cannot validate PXE bootloader. Some parameters were\""},{"line_number":68,"context_line":"                  \" missing in node\u0027s driver_info\")"},{"line_number":69,"context_line":"    deploy_utils.check_for_missing_params(d_info, error_msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_4baf60e3","line":66,"range":{"start_line":66,"start_character":39,"end_line":66,"end_character":72},"in_reply_to":"3a71b18c_de054e10","updated":"2016-12-12 19:32:00.000000000","message":"Done","commit_id":"ebd35d548f235c9746b1497108a4fd87cb2b317d"},{"author":{"_account_id":22931,"name":"Taku Izumi","email":"izumi.taku@jp.fujitsu.com","username":"izumi777"},"change_message_id":"a5b9ca324cdfeb3e9a0417b6fc7d9cf757a4b1b1","unresolved":false,"context_lines":[{"line_number":433,"context_line":"        if CONF.pxe.ipxe_enabled and CONF.pxe.ipxe_use_swift:"},{"line_number":434,"context_line":"            pxe_info.pop(\u0027deploy_kernel\u0027, None)"},{"line_number":435,"context_line":"            pxe_info.pop(\u0027deploy_ramdisk\u0027, None)"},{"line_number":436,"context_line":"        if pxe_info and not rescue:"},{"line_number":437,"context_line":"            _cache_ramdisk_kernel(task.context, node, pxe_info)"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    @METRICS.timer(\u0027PXEBoot.clean_up_ramdisk\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_63442974","line":436,"range":{"start_line":436,"start_character":20,"end_line":436,"end_character":35},"updated":"2016-12-13 10:20:14.000000000","message":"Why \"and not rescue\" ?\nWhy don\u0027t we have to invoke _cache_ramdisk_kernel() in case of reacue \u003d True ?","commit_id":"93c54528d51318e6fd4a2b23bca490556f5d59c9"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"8c86f02d383d95e297c9ca5681cae7464fbdfae9","unresolved":false,"context_lines":[{"line_number":433,"context_line":"        if CONF.pxe.ipxe_enabled and CONF.pxe.ipxe_use_swift:"},{"line_number":434,"context_line":"            pxe_info.pop(\u0027deploy_kernel\u0027, None)"},{"line_number":435,"context_line":"            pxe_info.pop(\u0027deploy_ramdisk\u0027, None)"},{"line_number":436,"context_line":"        if pxe_info and not rescue:"},{"line_number":437,"context_line":"            _cache_ramdisk_kernel(task.context, node, pxe_info)"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    @METRICS.timer(\u0027PXEBoot.clean_up_ramdisk\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a6eadb0_38448a19","line":436,"range":{"start_line":436,"start_character":20,"end_line":436,"end_character":35},"in_reply_to":"1a6eadb0_63442974","updated":"2016-12-15 18:47:55.000000000","message":"We don\u0027t want to cache the ramdisk and kernel so that the rescue ramdisk doesn\u0027t get used when cleaning a node, in case a node in RESCUE gets cleaned.","commit_id":"93c54528d51318e6fd4a2b23bca490556f5d59c9"},{"author":{"_account_id":22931,"name":"Taku Izumi","email":"izumi.taku@jp.fujitsu.com","username":"izumi777"},"change_message_id":"58f27940e8c5930869e96ac7099e7c3eebc8c224","unresolved":false,"context_lines":[{"line_number":433,"context_line":"        if CONF.pxe.ipxe_enabled and CONF.pxe.ipxe_use_swift:"},{"line_number":434,"context_line":"            pxe_info.pop(\u0027deploy_kernel\u0027, None)"},{"line_number":435,"context_line":"            pxe_info.pop(\u0027deploy_ramdisk\u0027, None)"},{"line_number":436,"context_line":"        if pxe_info and not rescue:"},{"line_number":437,"context_line":"            _cache_ramdisk_kernel(task.context, node, pxe_info)"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    @METRICS.timer(\u0027PXEBoot.clean_up_ramdisk\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_5759fa8c","line":436,"range":{"start_line":436,"start_character":19,"end_line":436,"end_character":35},"updated":"2016-12-16 11:07:34.000000000","message":"In case of rescue\u003dTrue, calling _cache_ramdisk_kernel() method will be skipped.\nIn this case, how does a baremetal node get rescue_kernel and rescue_ramdisk when PXE booting ?","commit_id":"55847c4ca3cd299f03e182085e15248dfa7ccc1c"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"f6f89685da5f92465f6f95427e0ebc838c82df7c","unresolved":false,"context_lines":[{"line_number":433,"context_line":"        if CONF.pxe.ipxe_enabled and CONF.pxe.ipxe_use_swift:"},{"line_number":434,"context_line":"            pxe_info.pop(\u0027deploy_kernel\u0027, None)"},{"line_number":435,"context_line":"            pxe_info.pop(\u0027deploy_ramdisk\u0027, None)"},{"line_number":436,"context_line":"        if pxe_info and not rescue:"},{"line_number":437,"context_line":"            _cache_ramdisk_kernel(task.context, node, pxe_info)"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"    @METRICS.timer(\u0027PXEBoot.clean_up_ramdisk\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba5201f7_d8a1f347","line":436,"range":{"start_line":436,"start_character":19,"end_line":436,"end_character":35},"in_reply_to":"1a6eadb0_5759fa8c","updated":"2017-01-11 22:51:50.000000000","message":"You\u0027re right, I misunderstood the full flow of prepare_ramdisk and thought that the image would be loaded in the right place elsewhere. Changed to just checking \"if pxe_info\" and added a short comment above explaining a little better","commit_id":"55847c4ca3cd299f03e182085e15248dfa7ccc1c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"abd1621ea37a8edb8200c71f0629d285e7bd435e","unresolved":false,"context_lines":[{"line_number":382,"context_line":"        deploy_utils.validate_image_properties(task.context, d_info, props)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    @METRICS.timer(\u0027PXEBoot.prepare_ramdisk\u0027)"},{"line_number":385,"context_line":"    def prepare_ramdisk(self, task, ramdisk_params, rescue\u003dFalse):"},{"line_number":386,"context_line":"        \"\"\"Prepares the boot of Ironic ramdisk using PXE."},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        This method prepares the boot of the deploy or rescue kernel/ramdisk"}],"source_content_type":"text/x-python","patch_set":24,"id":"9a30ddce_fa54fa21","line":385,"range":{"start_line":385,"start_character":51,"end_line":385,"end_character":64},"updated":"2017-03-09 10:49:26.000000000","message":"Need to make this change in base.py:BootInterface.prepare_ramdisk()?","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"9c300868cdbbcceb3913129f87b47d20f7ab8671","unresolved":false,"context_lines":[{"line_number":382,"context_line":"        deploy_utils.validate_image_properties(task.context, d_info, props)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    @METRICS.timer(\u0027PXEBoot.prepare_ramdisk\u0027)"},{"line_number":385,"context_line":"    def prepare_ramdisk(self, task, ramdisk_params, rescue\u003dFalse):"},{"line_number":386,"context_line":"        \"\"\"Prepares the boot of Ironic ramdisk using PXE."},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        This method prepares the boot of the deploy or rescue kernel/ramdisk"}],"source_content_type":"text/x-python","patch_set":24,"id":"1a1ced50_3d643fe4","line":385,"range":{"start_line":385,"start_character":51,"end_line":385,"end_character":64},"in_reply_to":"3a1ff146_3f6d1033","updated":"2017-03-23 17:23:15.000000000","message":"Done","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"bb745c52187f1226501112cd76d557eabf489846","unresolved":false,"context_lines":[{"line_number":382,"context_line":"        deploy_utils.validate_image_properties(task.context, d_info, props)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"    @METRICS.timer(\u0027PXEBoot.prepare_ramdisk\u0027)"},{"line_number":385,"context_line":"    def prepare_ramdisk(self, task, ramdisk_params, rescue\u003dFalse):"},{"line_number":386,"context_line":"        \"\"\"Prepares the boot of Ironic ramdisk using PXE."},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        This method prepares the boot of the deploy or rescue kernel/ramdisk"}],"source_content_type":"text/x-python","patch_set":24,"id":"3a1ff146_3f6d1033","line":385,"range":{"start_line":385,"start_character":51,"end_line":385,"end_character":64},"in_reply_to":"9a30ddce_fa54fa21","updated":"2017-03-14 18:09:13.000000000","message":"++","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"abd1621ea37a8edb8200c71f0629d285e7bd435e","unresolved":false,"context_lines":[{"line_number":455,"context_line":"            _cache_ramdisk_kernel(task.context, node, pxe_info)"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"    @METRICS.timer(\u0027PXEBoot.clean_up_ramdisk\u0027)"},{"line_number":458,"context_line":"    def clean_up_ramdisk(self, task, rescue\u003dFalse):"},{"line_number":459,"context_line":"        \"\"\"Cleans up the boot of ironic ramdisk."},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"        This method cleans up the PXE environment that was setup for booting"}],"source_content_type":"text/x-python","patch_set":24,"id":"9a30ddce_f5b5ed30","line":458,"range":{"start_line":458,"start_character":37,"end_line":458,"end_character":49},"updated":"2017-03-09 10:49:26.000000000","message":"Need to make this change in base.py:BootInterface.clean_up_ramdisk()?","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"9c300868cdbbcceb3913129f87b47d20f7ab8671","unresolved":false,"context_lines":[{"line_number":455,"context_line":"            _cache_ramdisk_kernel(task.context, node, pxe_info)"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"    @METRICS.timer(\u0027PXEBoot.clean_up_ramdisk\u0027)"},{"line_number":458,"context_line":"    def clean_up_ramdisk(self, task, rescue\u003dFalse):"},{"line_number":459,"context_line":"        \"\"\"Cleans up the boot of ironic ramdisk."},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"        This method cleans up the PXE environment that was setup for booting"}],"source_content_type":"text/x-python","patch_set":24,"id":"1a1ced50_fd7f0764","line":458,"range":{"start_line":458,"start_character":37,"end_line":458,"end_character":49},"in_reply_to":"3a1ff146_9f2c44ad","updated":"2017-03-23 17:23:15.000000000","message":"Done","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"bb745c52187f1226501112cd76d557eabf489846","unresolved":false,"context_lines":[{"line_number":455,"context_line":"            _cache_ramdisk_kernel(task.context, node, pxe_info)"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"    @METRICS.timer(\u0027PXEBoot.clean_up_ramdisk\u0027)"},{"line_number":458,"context_line":"    def clean_up_ramdisk(self, task, rescue\u003dFalse):"},{"line_number":459,"context_line":"        \"\"\"Cleans up the boot of ironic ramdisk."},{"line_number":460,"context_line":""},{"line_number":461,"context_line":"        This method cleans up the PXE environment that was setup for booting"}],"source_content_type":"text/x-python","patch_set":24,"id":"3a1ff146_9f2c44ad","line":458,"range":{"start_line":458,"start_character":37,"end_line":458,"end_character":49},"in_reply_to":"9a30ddce_f5b5ed30","updated":"2017-03-14 18:09:13.000000000","message":"++","commit_id":"079173cb9a3f8336891669a49b3d3d3bea0a3c84"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"b69c24e84edced631b5b6a90c4e04db6f9040be6","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    info \u003d node.driver_info"},{"line_number":66,"context_line":"    params_to_check \u003d [\u0027deploy_kernel\u0027, \u0027deploy_ramdisk\u0027]"},{"line_number":67,"context_line":"    if rescue:"},{"line_number":68,"context_line":"        params_to_check.extend([\u0027rescue_kernel\u0027, \u0027rescue_ramdisk\u0027])"},{"line_number":69,"context_line":"    d_info \u003d {k: info.get(k) for k in params_to_check}"},{"line_number":70,"context_line":"    error_msg \u003d _(\"Cannot validate PXE bootloader. Some parameters were\""},{"line_number":71,"context_line":"                  \" missing in node\u0027s driver_info\")"}],"source_content_type":"text/x-python","patch_set":27,"id":"ffe62b97_caae4997","line":68,"range":{"start_line":68,"start_character":24,"end_line":68,"end_character":30},"updated":"2017-03-27 15:55:08.000000000","message":"i don\u0027t think we should check deploy_kernel and deploy_ramdisk when performing rescue, this is not the same way like get_kernel_ramdisk_info, or _build_deploy_pxe_options.","commit_id":"0f81050cf6ca173f504835611f1c65fe74b6fdd9"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"fc8b2c891c6e0d972220763c934e4993c94f616a","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    info \u003d node.driver_info"},{"line_number":66,"context_line":"    params_to_check \u003d [\u0027deploy_kernel\u0027, \u0027deploy_ramdisk\u0027]"},{"line_number":67,"context_line":"    if rescue:"},{"line_number":68,"context_line":"        params_to_check.extend([\u0027rescue_kernel\u0027, \u0027rescue_ramdisk\u0027])"},{"line_number":69,"context_line":"    d_info \u003d {k: info.get(k) for k in params_to_check}"},{"line_number":70,"context_line":"    error_msg \u003d _(\"Cannot validate PXE bootloader. Some parameters were\""},{"line_number":71,"context_line":"                  \" missing in node\u0027s driver_info\")"}],"source_content_type":"text/x-python","patch_set":27,"id":"ffe62b97_4e20a2f7","line":68,"range":{"start_line":68,"start_character":24,"end_line":68,"end_character":30},"in_reply_to":"ffe62b97_caae4997","updated":"2017-03-29 16:52:24.000000000","message":"Done","commit_id":"0f81050cf6ca173f504835611f1c65fe74b6fdd9"},{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"b69c24e84edced631b5b6a90c4e04db6f9040be6","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    # TODO(mariojv) Is this needed? Maybe if deploy ramdisk and rescue ramdisk"},{"line_number":201,"context_line":"    # are the same"},{"line_number":202,"context_line":"    if rescue:"},{"line_number":203,"context_line":"        pxe_append_params +\u003d \u0027 ipa-rescuing\u003d1\u0027"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    return {\u0027pxe_append_params\u0027: pxe_append_params,"},{"line_number":206,"context_line":"            \u0027tftp_server\u0027: CONF.pxe.tftp_server,"}],"source_content_type":"text/x-python","patch_set":27,"id":"ffe62b97_0d7a0b87","line":203,"range":{"start_line":203,"start_character":8,"end_line":203,"end_character":46},"updated":"2017-03-27 15:55:08.000000000","message":"isn\u0027t it already added at prepare_ramdisk?","commit_id":"0f81050cf6ca173f504835611f1c65fe74b6fdd9"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"fc8b2c891c6e0d972220763c934e4993c94f616a","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    # TODO(mariojv) Is this needed? Maybe if deploy ramdisk and rescue ramdisk"},{"line_number":201,"context_line":"    # are the same"},{"line_number":202,"context_line":"    if rescue:"},{"line_number":203,"context_line":"        pxe_append_params +\u003d \u0027 ipa-rescuing\u003d1\u0027"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    return {\u0027pxe_append_params\u0027: pxe_append_params,"},{"line_number":206,"context_line":"            \u0027tftp_server\u0027: CONF.pxe.tftp_server,"}],"source_content_type":"text/x-python","patch_set":27,"id":"ffe62b97_8eb46a81","line":203,"range":{"start_line":203,"start_character":8,"end_line":203,"end_character":46},"in_reply_to":"ffe62b97_0d7a0b87","updated":"2017-03-29 16:52:24.000000000","message":"Oh, you\u0027re right.\n\nI don\u0027t think this is even necessary anymore, given the way rescue\u0027s being implemented in the IPA patches. Will remove everywhere until there\u0027s a ramdisk implementation that needs it.","commit_id":"0f81050cf6ca173f504835611f1c65fe74b6fdd9"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2b6d6522df3d8974294550013ae3ad71ba9c9401","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    info \u003d node.driver_info"},{"line_number":66,"context_line":"    params_to_check \u003d [\u0027deploy_kernel\u0027, \u0027deploy_ramdisk\u0027]"},{"line_number":67,"context_line":"    if rescue:"},{"line_number":68,"context_line":"        params_to_check.extend([\u0027rescue_kernel\u0027, \u0027rescue_ramdisk\u0027])"},{"line_number":69,"context_line":"    d_info \u003d {k: info.get(k) for k in params_to_check}"},{"line_number":70,"context_line":"    error_msg \u003d _(\"Cannot validate PXE bootloader. Some parameters were\""},{"line_number":71,"context_line":"                  \" missing in node\u0027s driver_info\")"}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_31ce212e","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":30},"updated":"2017-03-28 11:36:52.000000000","message":"In rescue mode, why do we need to parse for \u0027deploy_kernel\u0027 and \u0027deploy_ramdisk\u0027?","commit_id":"da600a852847e7845ce644ce61bdd2f63e843b8e"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"94dd83ec0a7e8311f38947cdf2806e6f049fa1bf","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    info \u003d node.driver_info"},{"line_number":66,"context_line":"    params_to_check \u003d [\u0027deploy_kernel\u0027, \u0027deploy_ramdisk\u0027]"},{"line_number":67,"context_line":"    if rescue:"},{"line_number":68,"context_line":"        params_to_check.extend([\u0027rescue_kernel\u0027, \u0027rescue_ramdisk\u0027])"},{"line_number":69,"context_line":"    d_info \u003d {k: info.get(k) for k in params_to_check}"},{"line_number":70,"context_line":"    error_msg \u003d _(\"Cannot validate PXE bootloader. Some parameters were\""},{"line_number":71,"context_line":"                  \" missing in node\u0027s driver_info\")"}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_d89d9c0a","line":68,"range":{"start_line":68,"start_character":8,"end_line":68,"end_character":30},"in_reply_to":"ffe62b97_31ce212e","updated":"2017-03-29 16:52:57.000000000","message":"We don\u0027t at the stage this is called, although it would be necessary to unrescue. Will remove.","commit_id":"da600a852847e7845ce644ce61bdd2f63e843b8e"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"1044e44f85abefaf9cf8ed5bda23987137ed095b","unresolved":false,"context_lines":[{"line_number":190,"context_line":"    return pxe_opts"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"def _build_extra_pxe_options(rescue\u003dFalse):"},{"line_number":194,"context_line":"    # Enable debug in IPA according to CONF.debug if it was not"},{"line_number":195,"context_line":"    # specified yet"},{"line_number":196,"context_line":"    pxe_append_params \u003d CONF.pxe.pxe_append_params"}],"source_content_type":"text/x-python","patch_set":29,"id":"ffe62b97_d5c0bae3","line":193,"updated":"2017-03-29 17:01:40.000000000","message":"Changes to this method are now unneeded, removing.","commit_id":"f0db2961167792bab0703c8913a1bcbebf7df2d9"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"3270d3032501c6df988eb069dd097134c2091f80","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        deploy_utils.validate_image_properties(task.context, d_info, props)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    @METRICS.timer(\u0027PXEBoot.prepare_ramdisk\u0027)"},{"line_number":380,"context_line":"    def prepare_ramdisk(self, task, ramdisk_params):"},{"line_number":381,"context_line":"        \"\"\"Prepares the boot of Ironic ramdisk using PXE."},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        This method prepares the boot of the deploy or rescue kernel/ramdisk"}],"source_content_type":"text/x-python","patch_set":35,"id":"bff0334d_d000336a","line":380,"range":{"start_line":380,"start_character":8,"end_line":380,"end_character":23},"updated":"2017-04-09 19:28:53.000000000","message":"missing rescue param","commit_id":"e7f0d6e46e9ddb9efa7c77281a49867771b817ed"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"c8cf2152d8fed1bdf524e4652e38ba79a3c98578","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        deploy_utils.validate_image_properties(task.context, d_info, props)"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"    @METRICS.timer(\u0027PXEBoot.prepare_ramdisk\u0027)"},{"line_number":380,"context_line":"    def prepare_ramdisk(self, task, ramdisk_params):"},{"line_number":381,"context_line":"        \"\"\"Prepares the boot of Ironic ramdisk using PXE."},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        This method prepares the boot of the deploy or rescue kernel/ramdisk"}],"source_content_type":"text/x-python","patch_set":35,"id":"bff0334d_8c4ef36c","line":380,"range":{"start_line":380,"start_character":8,"end_line":380,"end_character":23},"in_reply_to":"bff0334d_d000336a","updated":"2017-04-10 16:14:52.000000000","message":"To avoid changes to the base class method signature, I had to switch around the logic to work based on provision states instead of passing around a parameter. See Yuriy and Shivanand\u0027s comments on PS32. This should be clearer now that unit tests are updated to reflect the new code.","commit_id":"e7f0d6e46e9ddb9efa7c77281a49867771b817ed"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"3270d3032501c6df988eb069dd097134c2091f80","unresolved":false,"context_lines":[{"line_number":418,"context_line":"        provider \u003d dhcp_factory.DHCPFactory()"},{"line_number":419,"context_line":"        provider.update_dhcp(task, dhcp_opts)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        pxe_info \u003d _get_image_info(node)"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        # NODE: Try to validate and fetch instance images only"},{"line_number":424,"context_line":"        # if we are in DEPLOYING state."}],"source_content_type":"text/x-python","patch_set":35,"id":"bff0334d_d046f37c","line":421,"range":{"start_line":421,"start_character":20,"end_line":421,"end_character":40},"updated":"2017-04-09 19:28:53.000000000","message":"We get rescue param to this method, we can pass that directly to \u0027_get_image_info\u0027 to avoid checking of the provision state at L134 and even at L66.","commit_id":"e7f0d6e46e9ddb9efa7c77281a49867771b817ed"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"c8cf2152d8fed1bdf524e4652e38ba79a3c98578","unresolved":false,"context_lines":[{"line_number":418,"context_line":"        provider \u003d dhcp_factory.DHCPFactory()"},{"line_number":419,"context_line":"        provider.update_dhcp(task, dhcp_opts)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        pxe_info \u003d _get_image_info(node)"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        # NODE: Try to validate and fetch instance images only"},{"line_number":424,"context_line":"        # if we are in DEPLOYING state."}],"source_content_type":"text/x-python","patch_set":35,"id":"bff0334d_cc475b4c","line":421,"range":{"start_line":421,"start_character":20,"end_line":421,"end_character":40},"in_reply_to":"bff0334d_d046f37c","updated":"2017-04-10 16:14:52.000000000","message":"See L380. I personally think the new way of checking is cleaner, but take a look and let me know what you think.","commit_id":"e7f0d6e46e9ddb9efa7c77281a49867771b817ed"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"97fc40a790e334eb8d69e065929639af2bf87daf","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    :raises: MissingParameterValue"},{"line_number":64,"context_line":"    \"\"\""},{"line_number":65,"context_line":"    info \u003d node.driver_info"},{"line_number":66,"context_line":"    rescuing \u003d (node.provision_state \u003d\u003d states.RESCUING or"},{"line_number":67,"context_line":"                node.provision_state \u003d\u003d states.RESCUEWAIT or"},{"line_number":68,"context_line":"                node.provision_state \u003d\u003d states.RESCUEFAIL or"},{"line_number":69,"context_line":"                node.provision_state \u003d\u003d states.UNRESCUING or"}],"source_content_type":"text/x-python","patch_set":40,"id":"1f013ff3_22098830","line":66,"updated":"2017-05-16 15:14:05.000000000","message":"Please use node.provision_state in ... syntax.","commit_id":"a28c805aee518e10a41a093cb5413cb7a249459f"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"9c189cba56f3ae6e3ca0b50e5da24a0ab362503b","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    :raises: MissingParameterValue"},{"line_number":64,"context_line":"    \"\"\""},{"line_number":65,"context_line":"    info \u003d node.driver_info"},{"line_number":66,"context_line":"    rescuing \u003d (node.provision_state \u003d\u003d states.RESCUING or"},{"line_number":67,"context_line":"                node.provision_state \u003d\u003d states.RESCUEWAIT or"},{"line_number":68,"context_line":"                node.provision_state \u003d\u003d states.RESCUEFAIL or"},{"line_number":69,"context_line":"                node.provision_state \u003d\u003d states.UNRESCUING or"}],"source_content_type":"text/x-python","patch_set":40,"id":"ff0f0b1f_594a6627","line":66,"in_reply_to":"1f013ff3_22098830","updated":"2017-05-18 07:04:43.000000000","message":"Done","commit_id":"a28c805aee518e10a41a093cb5413cb7a249459f"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"97fc40a790e334eb8d69e065929639af2bf87daf","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        rescue_kernel/rescue_ramdisk is missing in node\u0027s driver_info."},{"line_number":139,"context_line":"    \"\"\""},{"line_number":140,"context_line":"    d_info \u003d _parse_driver_info(node)"},{"line_number":141,"context_line":"    rescuing \u003d (node.provision_state \u003d\u003d states.RESCUING or"},{"line_number":142,"context_line":"                node.provision_state \u003d\u003d states.RESCUEWAIT or"},{"line_number":143,"context_line":"                node.provision_state \u003d\u003d states.RESCUEFAIL or"},{"line_number":144,"context_line":"                node.provision_state \u003d\u003d states.UNRESCUING or"}],"source_content_type":"text/x-python","patch_set":40,"id":"1f013ff3_4d416539","line":141,"updated":"2017-05-16 15:14:05.000000000","message":"Please use helper function instead of copy the same 4 times.","commit_id":"a28c805aee518e10a41a093cb5413cb7a249459f"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"9c189cba56f3ae6e3ca0b50e5da24a0ab362503b","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        rescue_kernel/rescue_ramdisk is missing in node\u0027s driver_info."},{"line_number":139,"context_line":"    \"\"\""},{"line_number":140,"context_line":"    d_info \u003d _parse_driver_info(node)"},{"line_number":141,"context_line":"    rescuing \u003d (node.provision_state \u003d\u003d states.RESCUING or"},{"line_number":142,"context_line":"                node.provision_state \u003d\u003d states.RESCUEWAIT or"},{"line_number":143,"context_line":"                node.provision_state \u003d\u003d states.RESCUEFAIL or"},{"line_number":144,"context_line":"                node.provision_state \u003d\u003d states.UNRESCUING or"}],"source_content_type":"text/x-python","patch_set":40,"id":"ff0f0b1f_59cb8652","line":141,"in_reply_to":"1f013ff3_4d416539","updated":"2017-05-18 07:04:43.000000000","message":"Done","commit_id":"a28c805aee518e10a41a093cb5413cb7a249459f"},{"author":{"_account_id":22931,"name":"Taku Izumi","email":"izumi.taku@jp.fujitsu.com","username":"izumi777"},"change_message_id":"262a4055543e23883f9a0c82e269ba13c83936a6","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    # NOTE(pas-ha) if it is takeover of ACTIVE node,"},{"line_number":254,"context_line":"    # first ensure that basic PXE configs and links"},{"line_number":255,"context_line":"    # are in place before switching pxe config"},{"line_number":256,"context_line":"    if (node.provision_state \u003d\u003d states.ACTIVE and"},{"line_number":257,"context_line":"            not os.path.isfile(pxe_config_path)):"},{"line_number":258,"context_line":"        pxe_options \u003d _build_pxe_config_options(task, instance_image_info,"},{"line_number":259,"context_line":"                                                service\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":45,"id":"df140735_3b269118","line":256,"range":{"start_line":256,"start_character":1,"end_line":256,"end_character":49},"updated":"2017-06-07 06:34:41.000000000","message":"In my test environment, I have to change this into the following code:\n  if (node.provision_state in [states.ACTIVE, states.UNRESCUING] and\n\nOtherwise, doing unrescue() always failed because of lack of \n...httpboot/\u003cNODE-ID\u003e/config file.","commit_id":"f6aa78d302af62eefad6cd1d775b153e1a0e16af"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"4cdfad0407b125218d5377768704dc69091b9e62","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    # NOTE(pas-ha) if it is takeover of ACTIVE node,"},{"line_number":254,"context_line":"    # first ensure that basic PXE configs and links"},{"line_number":255,"context_line":"    # are in place before switching pxe config"},{"line_number":256,"context_line":"    if (node.provision_state \u003d\u003d states.ACTIVE and"},{"line_number":257,"context_line":"            not os.path.isfile(pxe_config_path)):"},{"line_number":258,"context_line":"        pxe_options \u003d _build_pxe_config_options(task, instance_image_info,"},{"line_number":259,"context_line":"                                                service\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":45,"id":"7f231b9d_1576e7a5","line":256,"range":{"start_line":256,"start_character":1,"end_line":256,"end_character":49},"in_reply_to":"df140735_3b269118","updated":"2017-06-12 12:57:42.000000000","message":"Done","commit_id":"f6aa78d302af62eefad6cd1d775b153e1a0e16af"},{"author":{"_account_id":19593,"name":"Anup Navare","email":"anup.d.navare@intel.com","username":"anup"},"change_message_id":"9c645520a6b788cf417fa78cdd9083323c472cd3","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    # NOTE(pas-ha) if it is takeover of ACTIVE node,"},{"line_number":254,"context_line":"    # first ensure that basic PXE configs and links"},{"line_number":255,"context_line":"    # are in place before switching pxe config"},{"line_number":256,"context_line":"    if (node.provision_state \u003d\u003d states.ACTIVE and"},{"line_number":257,"context_line":"            not os.path.isfile(pxe_config_path)):"},{"line_number":258,"context_line":"        pxe_options \u003d _build_pxe_config_options(task, instance_image_info,"},{"line_number":259,"context_line":"                                                service\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":45,"id":"7f231b9d_40af1f94","line":256,"range":{"start_line":256,"start_character":1,"end_line":256,"end_character":49},"in_reply_to":"df140735_3b269118","updated":"2017-06-09 22:20:15.000000000","message":"Nice catch.","commit_id":"f6aa78d302af62eefad6cd1d775b153e1a0e16af"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"a15de37ef022e76e362ae56b1eea6076b0a029f8","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    \"\"\""},{"line_number":80,"context_line":"    info \u003d node.driver_info"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    if _is_rescuing(node.provision_state):"},{"line_number":83,"context_line":"        params_to_check \u003d [\u0027rescue_kernel\u0027, \u0027rescue_ramdisk\u0027]"},{"line_number":84,"context_line":"    else:"},{"line_number":85,"context_line":"        params_to_check \u003d [\u0027deploy_kernel\u0027, \u0027deploy_ramdisk\u0027]"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    d_info \u003d {k: info.get(k) for k in params_to_check}"},{"line_number":88,"context_line":"    error_msg \u003d _(\"Cannot validate PXE bootloader. Some parameters were\""}],"source_content_type":"text/x-python","patch_set":68,"id":"ff82abbf_6f0a0fd3","line":85,"range":{"start_line":82,"start_character":4,"end_line":85,"end_character":61},"updated":"2017-11-21 16:10:55.000000000","message":"This can be changed to \"params_to_check \u003d [\u0027rescue_kernel\u0027, \u0027rescue_ramdisk\u0027] if _is_rescuing(node.provision_state) else [\u0027deploy_kernel\u0027, \u0027deploy_ramdisk\u0027]\"","commit_id":"205926b739f9f9d6e2135090677aeafa7f75f147"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6480163bc034276ee9b0ce674c90994fce9ace3e","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"def _is_rescuing(provision_state):"},{"line_number":63,"context_line":"    \"\"\"Returns whether rescue is in progress or not\"\"\""},{"line_number":64,"context_line":"    return (provision_state in [states.RESCUING, states.RESCUEWAIT,"},{"line_number":65,"context_line":"                                states.RESCUEFAIL, states.UNRESCUING,"},{"line_number":66,"context_line":"                                states.UNRESCUEFAIL])"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff82abbf_78cebb5a","line":63,"updated":"2017-11-28 21:56:09.000000000","message":"well, rescue or unrescue.","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"075da2894b98641ebc44f6508c7f9f4bff729cfb","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"def _is_rescuing(provision_state):"},{"line_number":63,"context_line":"    \"\"\"Returns whether rescue is in progress or not\"\"\""},{"line_number":64,"context_line":"    return (provision_state in [states.RESCUING, states.RESCUEWAIT,"},{"line_number":65,"context_line":"                                states.RESCUEFAIL, states.UNRESCUING,"},{"line_number":66,"context_line":"                                states.UNRESCUEFAIL])"}],"source_content_type":"text/x-python","patch_set":69,"id":"df87a7cf_8ad1aa5a","line":63,"in_reply_to":"ff82abbf_78cebb5a","updated":"2017-12-03 16:40:27.000000000","message":"Done","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6480163bc034276ee9b0ce674c90994fce9ace3e","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                                states.UNRESCUEFAIL])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def _parse_driver_info(node):"},{"line_number":70,"context_line":"    \"\"\"Gets the driver specific Node deployment info."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    This method validates whether the \u0027driver_info\u0027 property of the"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff82abbf_78223bbb","line":69,"updated":"2017-11-28 21:56:09.000000000","message":"might consider passing in some boolean or string to indicate whether we\u0027re interested in rescue or deploy.","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"075da2894b98641ebc44f6508c7f9f4bff729cfb","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                                states.UNRESCUEFAIL])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def _parse_driver_info(node):"},{"line_number":70,"context_line":"    \"\"\"Gets the driver specific Node deployment info."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    This method validates whether the \u0027driver_info\u0027 property of the"}],"source_content_type":"text/x-python","patch_set":69,"id":"df87a7cf_2af65e91","line":69,"in_reply_to":"ff82abbf_78223bbb","updated":"2017-12-03 16:40:27.000000000","message":"Done","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6480163bc034276ee9b0ce674c90994fce9ace3e","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    This method validates whether the \u0027driver_info\u0027 property of the"},{"line_number":73,"context_line":"    supplied node contains the required information for this driver to"},{"line_number":74,"context_line":"    deploy images to or rescue the node."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    :param node: a single Node."},{"line_number":77,"context_line":"    :returns: A dict with the driver_info values."}],"source_content_type":"text/x-python","patch_set":69,"id":"ff82abbf_d8dfc70a","line":74,"updated":"2017-11-28 21:56:09.000000000","message":"nit s/to or rescue/to, or rescue,/","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"075da2894b98641ebc44f6508c7f9f4bff729cfb","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    This method validates whether the \u0027driver_info\u0027 property of the"},{"line_number":73,"context_line":"    supplied node contains the required information for this driver to"},{"line_number":74,"context_line":"    deploy images to or rescue the node."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    :param node: a single Node."},{"line_number":77,"context_line":"    :returns: A dict with the driver_info values."}],"source_content_type":"text/x-python","patch_set":69,"id":"df87a7cf_0ad03af7","line":74,"in_reply_to":"ff82abbf_d8dfc70a","updated":"2017-12-03 16:40:27.000000000","message":"Done","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6480163bc034276ee9b0ce674c90994fce9ace3e","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    \"\"\""},{"line_number":150,"context_line":"    d_info \u003d _parse_driver_info(node)"},{"line_number":151,"context_line":"    return pxe_utils.get_kernel_ramdisk_info("},{"line_number":152,"context_line":"        node.uuid, d_info, rescue\u003d_is_rescuing(node.provision_state))"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"def _build_deploy_pxe_options(task, pxe_info):"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff82abbf_387a73b9","line":152,"updated":"2017-11-28 21:56:09.000000000","message":"I\u0027m still reviewing the code, but it seems like this would be less messy if we passed in eg \u0027is_rescue\u0027 \u003d True/False or \u0027image_type\u0027\u003d \u0027deploy\u0027/\u0027rescue\u0027 as a parameter to this method.","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"075da2894b98641ebc44f6508c7f9f4bff729cfb","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    \"\"\""},{"line_number":150,"context_line":"    d_info \u003d _parse_driver_info(node)"},{"line_number":151,"context_line":"    return pxe_utils.get_kernel_ramdisk_info("},{"line_number":152,"context_line":"        node.uuid, d_info, rescue\u003d_is_rescuing(node.provision_state))"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"def _build_deploy_pxe_options(task, pxe_info):"}],"source_content_type":"text/x-python","patch_set":69,"id":"df87a7cf_cfe33ca4","line":152,"in_reply_to":"ff82abbf_387a73b9","updated":"2017-12-03 16:40:27.000000000","message":"Done","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6480163bc034276ee9b0ce674c90994fce9ace3e","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        node.uuid, d_info, rescue\u003d_is_rescuing(node.provision_state))"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"def _build_deploy_pxe_options(task, pxe_info):"},{"line_number":156,"context_line":"    pxe_opts \u003d {}"},{"line_number":157,"context_line":"    node \u003d task.node"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":69,"id":"ff82abbf_9b55b9fc","line":155,"updated":"2017-11-28 21:56:09.000000000","message":"maybe add a parameter to indicate deploy or rescue.","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"075da2894b98641ebc44f6508c7f9f4bff729cfb","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        node.uuid, d_info, rescue\u003d_is_rescuing(node.provision_state))"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"def _build_deploy_pxe_options(task, pxe_info):"},{"line_number":156,"context_line":"    pxe_opts \u003d {}"},{"line_number":157,"context_line":"    node \u003d task.node"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":69,"id":"df87a7cf_2f8508ae","line":155,"in_reply_to":"ff82abbf_9b55b9fc","updated":"2017-12-03 16:40:27.000000000","message":"Done","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6480163bc034276ee9b0ce674c90994fce9ace3e","unresolved":false,"context_lines":[{"line_number":250,"context_line":"    # will not be regenerated anew, but instead edited as-is."},{"line_number":251,"context_line":"    # This can be changed later if/when switching PXE config will also use"},{"line_number":252,"context_line":"    # proper templating instead of editing existing files on disk."},{"line_number":253,"context_line":"    if not _is_rescuing(task.node.provision_state):"},{"line_number":254,"context_line":"        pxe_options.update(_build_instance_pxe_options(task, pxe_info))"},{"line_number":255,"context_line":"    pxe_options.update(_build_extra_pxe_options())"},{"line_number":256,"context_line":""}],"source_content_type":"text/x-python","patch_set":69,"id":"ff82abbf_fb896574","line":253,"updated":"2017-11-28 21:56:09.000000000","message":"this if should be before L248, because the comment only applies for deploy, right?","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"075da2894b98641ebc44f6508c7f9f4bff729cfb","unresolved":false,"context_lines":[{"line_number":250,"context_line":"    # will not be regenerated anew, but instead edited as-is."},{"line_number":251,"context_line":"    # This can be changed later if/when switching PXE config will also use"},{"line_number":252,"context_line":"    # proper templating instead of editing existing files on disk."},{"line_number":253,"context_line":"    if not _is_rescuing(task.node.provision_state):"},{"line_number":254,"context_line":"        pxe_options.update(_build_instance_pxe_options(task, pxe_info))"},{"line_number":255,"context_line":"    pxe_options.update(_build_extra_pxe_options())"},{"line_number":256,"context_line":""}],"source_content_type":"text/x-python","patch_set":69,"id":"df87a7cf_cf91fcf3","line":253,"in_reply_to":"ff82abbf_fb896574","updated":"2017-12-03 16:40:27.000000000","message":"Done","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6480163bc034276ee9b0ce674c90994fce9ace3e","unresolved":false,"context_lines":[{"line_number":551,"context_line":"        try:"},{"line_number":552,"context_line":"            images_info \u003d _get_image_info(node)"},{"line_number":553,"context_line":"        except exception.MissingParameterValue as e:"},{"line_number":554,"context_line":"            LOG.warning(\u0027Could not get deploy image info \u0027"},{"line_number":555,"context_line":"                        \u0027to clean up images for node %(node)s: %(err)s\u0027,"},{"line_number":556,"context_line":"                        {\u0027node\u0027: node.uuid, \u0027err\u0027: e})"},{"line_number":557,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":69,"id":"ff82abbf_3b4eed37","line":554,"updated":"2017-11-28 21:56:09.000000000","message":"not necessarily deploy, could be rescue image info.","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"075da2894b98641ebc44f6508c7f9f4bff729cfb","unresolved":false,"context_lines":[{"line_number":551,"context_line":"        try:"},{"line_number":552,"context_line":"            images_info \u003d _get_image_info(node)"},{"line_number":553,"context_line":"        except exception.MissingParameterValue as e:"},{"line_number":554,"context_line":"            LOG.warning(\u0027Could not get deploy image info \u0027"},{"line_number":555,"context_line":"                        \u0027to clean up images for node %(node)s: %(err)s\u0027,"},{"line_number":556,"context_line":"                        {\u0027node\u0027: node.uuid, \u0027err\u0027: e})"},{"line_number":557,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":69,"id":"df87a7cf_8f621416","line":554,"in_reply_to":"ff82abbf_3b4eed37","updated":"2017-12-03 16:40:27.000000000","message":"Done","commit_id":"ec36e0162b26c39d321dc23ee36804b5464dc617"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c7ca39ec5bdbb13f0642747215ecef08aa5bbc58","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"def _is_rescuing(provision_state):"},{"line_number":63,"context_line":"    \"\"\"Returns whether rescue or unerscue is in progress or not\"\"\""},{"line_number":64,"context_line":"    return (provision_state in [states.RESCUING, states.RESCUEWAIT,"},{"line_number":65,"context_line":"                                states.RESCUEFAIL, states.UNRESCUING,"},{"line_number":66,"context_line":"                                states.UNRESCUEFAIL])"}],"source_content_type":"text/x-python","patch_set":77,"id":"bf8cb3f7_31948f8b","line":63,"updated":"2017-12-20 22:53:26.000000000","message":"nit s/unerscue/unrescue/","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"5c6624dbf3a1813c7379ed74cd29bef2822b82a7","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    \"\"\"Returns whether rescue or unerscue is in progress or not\"\"\""},{"line_number":64,"context_line":"    return (provision_state in [states.RESCUING, states.RESCUEWAIT,"},{"line_number":65,"context_line":"                                states.RESCUEFAIL, states.UNRESCUING,"},{"line_number":66,"context_line":"                                states.UNRESCUEFAIL])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def _parse_driver_info(node, is_rescue):"}],"source_content_type":"text/x-python","patch_set":77,"id":"df87a7cf_bebc4bdc","line":66,"updated":"2017-12-19 22:24:29.000000000","message":"Could this be useful in utils?","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c7ca39ec5bdbb13f0642747215ecef08aa5bbc58","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    \"\"\"Returns whether rescue or unerscue is in progress or not\"\"\""},{"line_number":64,"context_line":"    return (provision_state in [states.RESCUING, states.RESCUEWAIT,"},{"line_number":65,"context_line":"                                states.RESCUEFAIL, states.UNRESCUING,"},{"line_number":66,"context_line":"                                states.UNRESCUEFAIL])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def _parse_driver_info(node, is_rescue):"}],"source_content_type":"text/x-python","patch_set":77,"id":"bf8cb3f7_31c24f87","line":66,"in_reply_to":"bf8cb3f7_005ca649","updated":"2017-12-20 22:53:26.000000000","message":"what do you think about having a variable, eg RESCUE_LIKE_STATES \u003d  (RESCUING, ... UNRESCUEFAIL) in the common/states.py file?\n\nAlso, I\u0027m not crazy about _is_rescuing() because that is too close to states.RESCUING. What about something like _in_rescue_like_state(), _in_rescue_type_state(), _in_rescue_state(). or _in_rescue_mode()\n\nLooking at the code, it really looks like you want to distinguish \u0027deploy\u0027 vs \u0027rescue\u0027 mode?","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3dec19f491aa2f384bbd9d40e31ab6766d682f7c","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    \"\"\"Returns whether rescue or unerscue is in progress or not\"\"\""},{"line_number":64,"context_line":"    return (provision_state in [states.RESCUING, states.RESCUEWAIT,"},{"line_number":65,"context_line":"                                states.RESCUEFAIL, states.UNRESCUING,"},{"line_number":66,"context_line":"                                states.UNRESCUEFAIL])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def _parse_driver_info(node, is_rescue):"}],"source_content_type":"text/x-python","patch_set":77,"id":"9f91af0f_2c4dec71","line":66,"in_reply_to":"bf8cb3f7_31c24f87","updated":"2018-01-04 11:21:02.000000000","message":"Done","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"7582118339d8717569b08cc8effe0881a4265658","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    \"\"\"Returns whether rescue or unerscue is in progress or not\"\"\""},{"line_number":64,"context_line":"    return (provision_state in [states.RESCUING, states.RESCUEWAIT,"},{"line_number":65,"context_line":"                                states.RESCUEFAIL, states.UNRESCUING,"},{"line_number":66,"context_line":"                                states.UNRESCUEFAIL])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def _parse_driver_info(node, is_rescue):"}],"source_content_type":"text/x-python","patch_set":77,"id":"bf8cb3f7_005ca649","line":66,"in_reply_to":"df87a7cf_bebc4bdc","updated":"2017-12-20 14:07:08.000000000","message":"Done","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c7ca39ec5bdbb13f0642747215ecef08aa5bbc58","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                                states.UNRESCUEFAIL])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def _parse_driver_info(node, is_rescue):"},{"line_number":70,"context_line":"    \"\"\"Gets the driver specific Node deployment info."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    This method validates whether the \u0027driver_info\u0027 property of the"}],"source_content_type":"text/x-python","patch_set":77,"id":"bf8cb3f7_51e9137e","line":69,"updated":"2017-12-20 22:53:26.000000000","message":"i think that if you pass the provision mode (\u0027deploy\u0027 or \u0027rescue\u0027, with \u0027deploy\u0027 the default) it might make it a bit cleaner (fewer if/else). But not a big deal.","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3dec19f491aa2f384bbd9d40e31ab6766d682f7c","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                                states.UNRESCUEFAIL])"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def _parse_driver_info(node, is_rescue):"},{"line_number":70,"context_line":"    \"\"\"Gets the driver specific Node deployment info."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    This method validates whether the \u0027driver_info\u0027 property of the"}],"source_content_type":"text/x-python","patch_set":77,"id":"9f91af0f_6c3534da","line":69,"in_reply_to":"bf8cb3f7_51e9137e","updated":"2018-01-04 11:21:02.000000000","message":"Done","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c7ca39ec5bdbb13f0642747215ecef08aa5bbc58","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    deploy images to, or rescue, the node."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    :param node: a single Node."},{"line_number":77,"context_line":"    :param is_rescue: Boolean flag indicating if the rescue/unrescue"},{"line_number":78,"context_line":"                      operation being carried out on the node."},{"line_number":79,"context_line":"    :returns: A dict with the driver_info values."},{"line_number":80,"context_line":"    :raises: MissingParameterValue"}],"source_content_type":"text/x-python","patch_set":77,"id":"bf8cb3f7_31cc8f88","line":77,"updated":"2017-12-20 22:53:26.000000000","message":"s/the/a/","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3dec19f491aa2f384bbd9d40e31ab6766d682f7c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    deploy images to, or rescue, the node."},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    :param node: a single Node."},{"line_number":77,"context_line":"    :param is_rescue: Boolean flag indicating if the rescue/unrescue"},{"line_number":78,"context_line":"                      operation being carried out on the node."},{"line_number":79,"context_line":"    :returns: A dict with the driver_info values."},{"line_number":80,"context_line":"    :raises: MissingParameterValue"}],"source_content_type":"text/x-python","patch_set":77,"id":"9f91af0f_8c32f8f0","line":77,"in_reply_to":"bf8cb3f7_31cc8f88","updated":"2018-01-04 11:21:02.000000000","message":"Done","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c7ca39ec5bdbb13f0642747215ecef08aa5bbc58","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    :param node: a single Node."},{"line_number":77,"context_line":"    :param is_rescue: Boolean flag indicating if the rescue/unrescue"},{"line_number":78,"context_line":"                      operation being carried out on the node."},{"line_number":79,"context_line":"    :returns: A dict with the driver_info values."},{"line_number":80,"context_line":"    :raises: MissingParameterValue"},{"line_number":81,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":77,"id":"bf8cb3f7_d1c8c375","line":78,"updated":"2017-12-20 22:53:26.000000000","message":"nit s/being/is being/","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3dec19f491aa2f384bbd9d40e31ab6766d682f7c","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    :param node: a single Node."},{"line_number":77,"context_line":"    :param is_rescue: Boolean flag indicating if the rescue/unrescue"},{"line_number":78,"context_line":"                      operation being carried out on the node."},{"line_number":79,"context_line":"    :returns: A dict with the driver_info values."},{"line_number":80,"context_line":"    :raises: MissingParameterValue"},{"line_number":81,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":77,"id":"9f91af0f_cc3800d5","line":78,"in_reply_to":"bf8cb3f7_d1c8c375","updated":"2018-01-04 11:21:02.000000000","message":"Done","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c7ca39ec5bdbb13f0642747215ecef08aa5bbc58","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    return image_info"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"def _get_image_info(node):"},{"line_number":140,"context_line":"    \"\"\"Generate the paths for TFTP files for deploy or rescue images."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    This method generates the paths for the deploy (or rescue) kernel and"}],"source_content_type":"text/x-python","patch_set":77,"id":"bf8cb3f7_718777d9","line":139,"updated":"2017-12-20 22:53:26.000000000","message":"i feel like it\u0027d be better to  have a parameter indicating whether it is deploy mode or rescue mode (deploy mode being the default since that is what is most likely going to happen most of the time.)","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3dec19f491aa2f384bbd9d40e31ab6766d682f7c","unresolved":false,"context_lines":[{"line_number":136,"context_line":"    return image_info"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"def _get_image_info(node):"},{"line_number":140,"context_line":"    \"\"\"Generate the paths for TFTP files for deploy or rescue images."},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    This method generates the paths for the deploy (or rescue) kernel and"}],"source_content_type":"text/x-python","patch_set":77,"id":"9f91af0f_ccc24086","line":139,"in_reply_to":"bf8cb3f7_718777d9","updated":"2018-01-04 11:21:02.000000000","message":"Done","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c7ca39ec5bdbb13f0642747215ecef08aa5bbc58","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    pxe_opts \u003d {}"},{"line_number":161,"context_line":"    node \u003d task.node"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    kernel_label \u003d \u0027rescue_kernel\u0027 if is_rescue else \u0027deploy_kernel\u0027"},{"line_number":164,"context_line":"    ramdisk_label \u003d \u0027rescue_ramdisk\u0027 if is_rescue else \u0027deploy_ramdisk\u0027"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    for label, option in ((kernel_label, \u0027deployment_aki_path\u0027),"}],"source_content_type":"text/x-python","patch_set":77,"id":"bf8cb3f7_711217b4","line":163,"updated":"2017-12-20 22:53:26.000000000","message":"most of the time, we\u0027re going to be dealing with deploy, not rescue, so it makes more sense to me if the parameter was \u0027is_deploy\u0027. In fact, I think it\u0027d be easier if instead of the Boolean, it was a string that was the \u0027mode\u0027. Then this could be kernel_label \u003d \u0027%s_label\u0027 % mode. Although maybe execution-wise, the if/else is faster, not sure.","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3dec19f491aa2f384bbd9d40e31ab6766d682f7c","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    pxe_opts \u003d {}"},{"line_number":161,"context_line":"    node \u003d task.node"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    kernel_label \u003d \u0027rescue_kernel\u0027 if is_rescue else \u0027deploy_kernel\u0027"},{"line_number":164,"context_line":"    ramdisk_label \u003d \u0027rescue_ramdisk\u0027 if is_rescue else \u0027deploy_ramdisk\u0027"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    for label, option in ((kernel_label, \u0027deployment_aki_path\u0027),"}],"source_content_type":"text/x-python","patch_set":77,"id":"9f91af0f_ac557c52","line":163,"in_reply_to":"bf8cb3f7_711217b4","updated":"2018-01-04 11:21:02.000000000","message":"Done","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c7ca39ec5bdbb13f0642747215ecef08aa5bbc58","unresolved":false,"context_lines":[{"line_number":266,"context_line":"                              root_uuid_or_disk_id):"},{"line_number":267,"context_line":"    node \u003d task.node"},{"line_number":268,"context_line":"    pxe_config_path \u003d pxe_utils.get_pxe_config_file_path(node.uuid)"},{"line_number":269,"context_line":"    # NOTE(pas-ha) if it is takeover of ACTIVE node,"},{"line_number":270,"context_line":"    # first ensure that basic PXE configs and links"},{"line_number":271,"context_line":"    # are in place before switching pxe config"},{"line_number":272,"context_line":"    if (node.provision_state in [states.ACTIVE, states.UNRESCUING] and"}],"source_content_type":"text/x-python","patch_set":77,"id":"bf8cb3f7_31aecf2e","line":269,"updated":"2017-12-20 22:53:26.000000000","message":"might want to update this NOTE.","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3dec19f491aa2f384bbd9d40e31ab6766d682f7c","unresolved":false,"context_lines":[{"line_number":266,"context_line":"                              root_uuid_or_disk_id):"},{"line_number":267,"context_line":"    node \u003d task.node"},{"line_number":268,"context_line":"    pxe_config_path \u003d pxe_utils.get_pxe_config_file_path(node.uuid)"},{"line_number":269,"context_line":"    # NOTE(pas-ha) if it is takeover of ACTIVE node,"},{"line_number":270,"context_line":"    # first ensure that basic PXE configs and links"},{"line_number":271,"context_line":"    # are in place before switching pxe config"},{"line_number":272,"context_line":"    if (node.provision_state in [states.ACTIVE, states.UNRESCUING] and"}],"source_content_type":"text/x-python","patch_set":77,"id":"9f91af0f_ec9e2406","line":269,"in_reply_to":"bf8cb3f7_31aecf2e","updated":"2018-01-04 11:21:02.000000000","message":"Done","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c7ca39ec5bdbb13f0642747215ecef08aa5bbc58","unresolved":false,"context_lines":[{"line_number":507,"context_line":"        provider \u003d dhcp_factory.DHCPFactory()"},{"line_number":508,"context_line":"        provider.update_dhcp(task, dhcp_opts)"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"        pxe_info \u003d _get_image_info(node)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        # NODE: Try to validate and fetch instance images only"},{"line_number":513,"context_line":"        # if we are in DEPLOYING state."}],"source_content_type":"text/x-python","patch_set":77,"id":"bf8cb3f7_7171b7e0","line":510,"updated":"2017-12-20 22:53:26.000000000","message":"if you knew which mode is in effect, you could pass it to _get_image_info() and then below @L530, you could pop the ones that are relevant.","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3dec19f491aa2f384bbd9d40e31ab6766d682f7c","unresolved":false,"context_lines":[{"line_number":507,"context_line":"        provider \u003d dhcp_factory.DHCPFactory()"},{"line_number":508,"context_line":"        provider.update_dhcp(task, dhcp_opts)"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"        pxe_info \u003d _get_image_info(node)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        # NODE: Try to validate and fetch instance images only"},{"line_number":513,"context_line":"        # if we are in DEPLOYING state."}],"source_content_type":"text/x-python","patch_set":77,"id":"9f91af0f_cfc0db2d","line":510,"in_reply_to":"bf8cb3f7_7171b7e0","updated":"2018-01-04 11:21:02.000000000","message":"Done","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c7ca39ec5bdbb13f0642747215ecef08aa5bbc58","unresolved":false,"context_lines":[{"line_number":531,"context_line":"            pxe_info.pop(\u0027deploy_kernel\u0027, None)"},{"line_number":532,"context_line":"            pxe_info.pop(\u0027deploy_ramdisk\u0027, None)"},{"line_number":533,"context_line":"            pxe_info.pop(\u0027rescue_kernel\u0027, None)"},{"line_number":534,"context_line":"            pxe_info.pop(\u0027rescue_ramdisk\u0027, None)"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"        if pxe_info:"},{"line_number":537,"context_line":"            _cache_ramdisk_kernel(task.context, node, pxe_info)"}],"source_content_type":"text/x-python","patch_set":77,"id":"bf8cb3f7_b12f3ff5","line":534,"updated":"2017-12-20 22:53:26.000000000","message":"We don\u0027t have to do all four of these, right? Just two, depending on whether the node is being deployed or rescued?","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3dec19f491aa2f384bbd9d40e31ab6766d682f7c","unresolved":false,"context_lines":[{"line_number":531,"context_line":"            pxe_info.pop(\u0027deploy_kernel\u0027, None)"},{"line_number":532,"context_line":"            pxe_info.pop(\u0027deploy_ramdisk\u0027, None)"},{"line_number":533,"context_line":"            pxe_info.pop(\u0027rescue_kernel\u0027, None)"},{"line_number":534,"context_line":"            pxe_info.pop(\u0027rescue_ramdisk\u0027, None)"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"        if pxe_info:"},{"line_number":537,"context_line":"            _cache_ramdisk_kernel(task.context, node, pxe_info)"}],"source_content_type":"text/x-python","patch_set":77,"id":"9f91af0f_0c4b4884","line":534,"in_reply_to":"bf8cb3f7_b12f3ff5","updated":"2018-01-04 11:21:02.000000000","message":"Done","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c7ca39ec5bdbb13f0642747215ecef08aa5bbc58","unresolved":false,"context_lines":[{"line_number":550,"context_line":"        \"\"\""},{"line_number":551,"context_line":"        node \u003d task.node"},{"line_number":552,"context_line":"        try:"},{"line_number":553,"context_line":"            images_info \u003d _get_image_info(node)"},{"line_number":554,"context_line":"        except exception.MissingParameterValue as e:"},{"line_number":555,"context_line":"            mode \u003d (\u0027rescue\u0027 if _is_rescuing(node.provision_state) else"},{"line_number":556,"context_line":"                    \u0027deploy\u0027)"}],"source_content_type":"text/x-python","patch_set":77,"id":"bf8cb3f7_71ebf7af","line":553,"updated":"2017-12-20 22:53:26.000000000","message":"I think the code might be clearer if we got in_deploy_mode \u003d not _is_rescuing(...) before this, then passed in_deploy_mode to _get_image_info().","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3dec19f491aa2f384bbd9d40e31ab6766d682f7c","unresolved":false,"context_lines":[{"line_number":550,"context_line":"        \"\"\""},{"line_number":551,"context_line":"        node \u003d task.node"},{"line_number":552,"context_line":"        try:"},{"line_number":553,"context_line":"            images_info \u003d _get_image_info(node)"},{"line_number":554,"context_line":"        except exception.MissingParameterValue as e:"},{"line_number":555,"context_line":"            mode \u003d (\u0027rescue\u0027 if _is_rescuing(node.provision_state) else"},{"line_number":556,"context_line":"                    \u0027deploy\u0027)"}],"source_content_type":"text/x-python","patch_set":77,"id":"9f91af0f_8aedf8f0","line":553,"in_reply_to":"bf8cb3f7_71ebf7af","updated":"2018-01-04 11:21:02.000000000","message":"Done","commit_id":"5b907ad96774a52b1b4c5c16996804519504bed5"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"cf611a412ab949ac6b5a4411578fd684ba50aa5b","unresolved":false,"context_lines":[{"line_number":454,"context_line":""},{"line_number":455,"context_line":"        mode \u003d ("},{"line_number":456,"context_line":"            \u0027rescue\u0027 if node.provision_state in deploy_utils.RESCUE_LIKE_STATES"},{"line_number":457,"context_line":"            else \u0027deploy\u0027)"},{"line_number":458,"context_line":"        _parse_driver_info(node, mode\u003dmode)"},{"line_number":459,"context_line":"        # NOTE(TheJulia): If we\u0027re not writing an image, we can skip"},{"line_number":460,"context_line":"        # the remainder of this method."}],"source_content_type":"text/x-python","patch_set":83,"id":"7f96bb07_2399fe77","line":457,"updated":"2018-01-17 09:16:37.000000000","message":"It seems that boot.validate() is not called for rescue now. I\u0027m not sure if this condition is necessary because validate() is usually called before state transition, then the provision state is ACTIVE when starting rescue.","commit_id":"bcb1f7edcf57d3ec8a5c6d7c21226a62c529b980"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2e273cc81aab67841c3a2327e951fb2692ca2cf5","unresolved":false,"context_lines":[{"line_number":454,"context_line":""},{"line_number":455,"context_line":"        mode \u003d ("},{"line_number":456,"context_line":"            \u0027rescue\u0027 if node.provision_state in deploy_utils.RESCUE_LIKE_STATES"},{"line_number":457,"context_line":"            else \u0027deploy\u0027)"},{"line_number":458,"context_line":"        _parse_driver_info(node, mode\u003dmode)"},{"line_number":459,"context_line":"        # NOTE(TheJulia): If we\u0027re not writing an image, we can skip"},{"line_number":460,"context_line":"        # the remainder of this method."}],"source_content_type":"text/x-python","patch_set":83,"id":"7f96bb07_bd53e616","line":457,"in_reply_to":"7f96bb07_2399fe77","updated":"2018-01-17 16:15:08.000000000","message":"boot.validate() is being added to rescue.validate()","commit_id":"bcb1f7edcf57d3ec8a5c6d7c21226a62c529b980"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"bdd640a5bff37db3066afb5533956dc00ee9b9ed","unresolved":false,"context_lines":[{"line_number":454,"context_line":""},{"line_number":455,"context_line":"        mode \u003d ("},{"line_number":456,"context_line":"            \u0027rescue\u0027 if node.provision_state in deploy_utils.RESCUE_LIKE_STATES"},{"line_number":457,"context_line":"            else \u0027deploy\u0027)"},{"line_number":458,"context_line":"        _parse_driver_info(node, mode\u003dmode)"},{"line_number":459,"context_line":"        # NOTE(TheJulia): If we\u0027re not writing an image, we can skip"},{"line_number":460,"context_line":"        # the remainder of this method."}],"source_content_type":"text/x-python","patch_set":83,"id":"7f96bb07_498be7c1","line":457,"in_reply_to":"7f96bb07_bd53e616","updated":"2018-01-18 06:33:03.000000000","message":"When rescue.validate() is called, the provision state is still ACTIVE. However, this is not a problem because AgentRescue.validate() also see if there are \u0027kernel_ramdisk\u0027 and \u0027kernel_ramdisk\u0027 in driver_info.\n\n[1] https://review.openstack.org/#/c/509336/31/ironic/conductor/manager.py@581","commit_id":"bcb1f7edcf57d3ec8a5c6d7c21226a62c529b980"},{"author":{"_account_id":13689,"name":"Hironori Shiina","email":"Hironori.Shiina@fujitsu.com","username":"shiina"},"change_message_id":"cf611a412ab949ac6b5a4411578fd684ba50aa5b","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        mode \u003d ("},{"line_number":456,"context_line":"            \u0027rescue\u0027 if node.provision_state in deploy_utils.RESCUE_LIKE_STATES"},{"line_number":457,"context_line":"            else \u0027deploy\u0027)"},{"line_number":458,"context_line":"        _parse_driver_info(node, mode\u003dmode)"},{"line_number":459,"context_line":"        # NOTE(TheJulia): If we\u0027re not writing an image, we can skip"},{"line_number":460,"context_line":"        # the remainder of this method."},{"line_number":461,"context_line":"        if not task.driver.storage.should_write_image(task):"}],"source_content_type":"text/x-python","patch_set":83,"id":"7f96bb07_06bdf000","line":458,"updated":"2018-01-17 09:16:37.000000000","message":"If we use this validation for rescue, we can return here.","commit_id":"bcb1f7edcf57d3ec8a5c6d7c21226a62c529b980"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2e273cc81aab67841c3a2327e951fb2692ca2cf5","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        mode \u003d ("},{"line_number":456,"context_line":"            \u0027rescue\u0027 if node.provision_state in deploy_utils.RESCUE_LIKE_STATES"},{"line_number":457,"context_line":"            else \u0027deploy\u0027)"},{"line_number":458,"context_line":"        _parse_driver_info(node, mode\u003dmode)"},{"line_number":459,"context_line":"        # NOTE(TheJulia): If we\u0027re not writing an image, we can skip"},{"line_number":460,"context_line":"        # the remainder of this method."},{"line_number":461,"context_line":"        if not task.driver.storage.should_write_image(task):"}],"source_content_type":"text/x-python","patch_set":83,"id":"7f96bb07_0abace08","line":458,"in_reply_to":"7f96bb07_06bdf000","updated":"2018-01-17 16:15:08.000000000","message":"Done","commit_id":"bcb1f7edcf57d3ec8a5c6d7c21226a62c529b980"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3f98e817122c0c90c16d93a1da13982451ff729c","unresolved":false,"context_lines":[{"line_number":457,"context_line":"            else \u0027deploy\u0027)"},{"line_number":458,"context_line":"        _parse_driver_info(node, mode\u003dmode)"},{"line_number":459,"context_line":"        # NOTE(TheJulia): If we\u0027re not writing an image, we can skip"},{"line_number":460,"context_line":"        # the remainder of this method."},{"line_number":461,"context_line":"        if ((node.provision_state in deploy_utils.RESCUE_LIKE_STATES) or"},{"line_number":462,"context_line":"            (not task.driver.storage.should_write_image(task))):"},{"line_number":463,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":85,"id":"7f96bb07_01406106","line":460,"updated":"2018-01-18 00:20:11.000000000","message":"you should update this comment.","commit_id":"142a29c21be377bd007bf6487970a1de77ee90a0"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"05825b3305665de135f0e76b649ad53b07751d4e","unresolved":false,"context_lines":[{"line_number":457,"context_line":"            else \u0027deploy\u0027)"},{"line_number":458,"context_line":"        _parse_driver_info(node, mode\u003dmode)"},{"line_number":459,"context_line":"        # NOTE(TheJulia): If we\u0027re not writing an image, we can skip"},{"line_number":460,"context_line":"        # the remainder of this method."},{"line_number":461,"context_line":"        if ((node.provision_state in deploy_utils.RESCUE_LIKE_STATES) or"},{"line_number":462,"context_line":"            (not task.driver.storage.should_write_image(task))):"},{"line_number":463,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":85,"id":"7f96bb07_6ab9e076","line":460,"in_reply_to":"7f96bb07_01406106","updated":"2018-01-19 09:21:46.000000000","message":"This rescue related check is not required as when validate() is called its in \u0027active\u0027 mode.","commit_id":"142a29c21be377bd007bf6487970a1de77ee90a0"}],"ironic/tests/unit/common/test_pxe_utils.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"ab4ff5fe59bcddd7948bbcdeced0894aef00079c","unresolved":false,"context_lines":[{"line_number":673,"context_line":"                                                    driver_info, rescue\u003drescue)"},{"line_number":674,"context_line":"        self.assertEqual(expected, kr_info)"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"    def test_get_deploy_kr_info(self):"},{"line_number":677,"context_line":"        expected_dir \u003d \u0027/tftp\u0027"},{"line_number":678,"context_line":"        self.config(tftp_root\u003dexpected_dir, group\u003d\u0027pxe\u0027)"},{"line_number":679,"context_line":"        self._test_get_kernel_ramdisk_info(expected_dir)"}],"source_content_type":"text/x-python","patch_set":56,"id":"7f515b1d_df2cf248","line":676,"range":{"start_line":676,"start_character":8,"end_line":676,"end_character":31},"updated":"2017-09-25 07:23:27.000000000","message":"let\u0027s change the name to match the method being tested.","commit_id":"4701e09b29e197c8637f72fd7ff49db4d1710154"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0d3bbf64848681dffa77a8a8e106cfa7929beffc","unresolved":false,"context_lines":[{"line_number":673,"context_line":"                                                    driver_info, rescue\u003drescue)"},{"line_number":674,"context_line":"        self.assertEqual(expected, kr_info)"},{"line_number":675,"context_line":""},{"line_number":676,"context_line":"    def test_get_deploy_kr_info(self):"},{"line_number":677,"context_line":"        expected_dir \u003d \u0027/tftp\u0027"},{"line_number":678,"context_line":"        self.config(tftp_root\u003dexpected_dir, group\u003d\u0027pxe\u0027)"},{"line_number":679,"context_line":"        self._test_get_kernel_ramdisk_info(expected_dir)"}],"source_content_type":"text/x-python","patch_set":56,"id":"7f515b1d_8d2bcce9","line":676,"range":{"start_line":676,"start_character":8,"end_line":676,"end_character":31},"in_reply_to":"7f515b1d_df2cf248","updated":"2017-09-27 16:31:32.000000000","message":"Done","commit_id":"4701e09b29e197c8637f72fd7ff49db4d1710154"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3f98e817122c0c90c16d93a1da13982451ff729c","unresolved":false,"context_lines":[{"line_number":669,"context_line":"                                  expected_dir + \u0027/fake-node/rescue_kernel\u0027),"},{"line_number":670,"context_line":"                \u0027rescue_ramdisk\u0027: (\u0027glance://rescue-ramdisk\u0027,"},{"line_number":671,"context_line":"                                   expected_dir + \u0027/fake-node/rescue_ramdisk\u0027),"},{"line_number":672,"context_line":"            }"},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"        kr_info \u003d pxe_utils.get_kernel_ramdisk_info(node_uuid,"},{"line_number":675,"context_line":"                                                    driver_info,"}],"source_content_type":"text/x-python","patch_set":85,"id":"7f96bb07_6190454b","line":672,"updated":"2018-01-18 00:20:11.000000000","message":"probably doesn\u0027t matter much but this can be shortened, eg:\n\n    driver_info \u003d { \u0027%s_kernel\u0027%mode: \u0027glance://%s-kernel\u0027%mode, \n                            \u0027%s_ramdisk\u0027%mode: \u0027glance://%s-ramdisk\u0027%mode}\n\n    expected \u003d {}\n    for k, v in driver_info.items():\n        expected[k] \u003d (v, expected_dir + \u0027/fake-node/%s\u0027 % k)\n\nOr maybe this is too cryptic for a test.","commit_id":"142a29c21be377bd007bf6487970a1de77ee90a0"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"05825b3305665de135f0e76b649ad53b07751d4e","unresolved":false,"context_lines":[{"line_number":669,"context_line":"                                  expected_dir + \u0027/fake-node/rescue_kernel\u0027),"},{"line_number":670,"context_line":"                \u0027rescue_ramdisk\u0027: (\u0027glance://rescue-ramdisk\u0027,"},{"line_number":671,"context_line":"                                   expected_dir + \u0027/fake-node/rescue_ramdisk\u0027),"},{"line_number":672,"context_line":"            }"},{"line_number":673,"context_line":""},{"line_number":674,"context_line":"        kr_info \u003d pxe_utils.get_kernel_ramdisk_info(node_uuid,"},{"line_number":675,"context_line":"                                                    driver_info,"}],"source_content_type":"text/x-python","patch_set":85,"id":"7f96bb07_25e9c9e4","line":672,"in_reply_to":"7f96bb07_6190454b","updated":"2018-01-19 09:21:46.000000000","message":"Done","commit_id":"142a29c21be377bd007bf6487970a1de77ee90a0"}],"ironic/tests/unit/conductor/test_utils.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3f98e817122c0c90c16d93a1da13982451ff729c","unresolved":false,"context_lines":[{"line_number":1290,"context_line":"        conductor_utils.rescuing_error_handler(self.task, \u0027some exception\u0027)"},{"line_number":1291,"context_line":"        node_power_mock.assert_called_once_with(mock.ANY, states.POWER_OFF)"},{"line_number":1292,"context_line":"        self.task.driver.rescue.clean_up.assert_called_once_with(self.task)"},{"line_number":1293,"context_line":"        self.node.save.assert_called_once_with()"},{"line_number":1294,"context_line":""},{"line_number":1295,"context_line":"    @mock.patch.object(conductor_utils, \u0027LOG\u0027)"},{"line_number":1296,"context_line":"    @mock.patch.object(conductor_utils, \u0027node_power_action\u0027)"}],"source_content_type":"text/x-python","patch_set":85,"id":"7f96bb07_3ca4a6b9","line":1293,"updated":"2018-01-18 00:20:11.000000000","message":"apart from this, and adding a clean_up_mock, I don\u0027t see any other diffs with the test at L1279. Both of them cause node.save() to be called.\n\nMaybe you should check that LOG.exception (or error) was called?","commit_id":"142a29c21be377bd007bf6487970a1de77ee90a0"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"05825b3305665de135f0e76b649ad53b07751d4e","unresolved":false,"context_lines":[{"line_number":1290,"context_line":"        conductor_utils.rescuing_error_handler(self.task, \u0027some exception\u0027)"},{"line_number":1291,"context_line":"        node_power_mock.assert_called_once_with(mock.ANY, states.POWER_OFF)"},{"line_number":1292,"context_line":"        self.task.driver.rescue.clean_up.assert_called_once_with(self.task)"},{"line_number":1293,"context_line":"        self.node.save.assert_called_once_with()"},{"line_number":1294,"context_line":""},{"line_number":1295,"context_line":"    @mock.patch.object(conductor_utils, \u0027LOG\u0027)"},{"line_number":1296,"context_line":"    @mock.patch.object(conductor_utils, \u0027node_power_action\u0027)"}],"source_content_type":"text/x-python","patch_set":85,"id":"7f96bb07_c02d7395","line":1293,"in_reply_to":"7f96bb07_3ca4a6b9","updated":"2018-01-19 09:21:46.000000000","message":"Done","commit_id":"142a29c21be377bd007bf6487970a1de77ee90a0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3f98e817122c0c90c16d93a1da13982451ff729c","unresolved":false,"context_lines":[{"line_number":1301,"context_line":"        clean_up_mock \u003d self.task.driver.rescue.clean_up"},{"line_number":1302,"context_line":"        clean_up_mock.side_effect \u003d exception.IronicException(\u0027moocow\u0027)"},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"        conductor_utils.rescuing_error_handler(self.task, \u0027some exception\u0027)"},{"line_number":1305,"context_line":""},{"line_number":1306,"context_line":"        node_power_mock.assert_called_once_with(mock.ANY, states.POWER_OFF)"},{"line_number":1307,"context_line":"        self.task.driver.rescue.clean_up.assert_called_once_with(self.task)"}],"source_content_type":"text/x-python","patch_set":85,"id":"7f96bb07_bcd3d603","line":1304,"updated":"2018-01-18 00:20:11.000000000","message":"what about a test for set_fail_state\u003dFalse? On the other hand, maybe it doesn\u0027t matter. Seems obvious.","commit_id":"142a29c21be377bd007bf6487970a1de77ee90a0"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"05825b3305665de135f0e76b649ad53b07751d4e","unresolved":false,"context_lines":[{"line_number":1301,"context_line":"        clean_up_mock \u003d self.task.driver.rescue.clean_up"},{"line_number":1302,"context_line":"        clean_up_mock.side_effect \u003d exception.IronicException(\u0027moocow\u0027)"},{"line_number":1303,"context_line":""},{"line_number":1304,"context_line":"        conductor_utils.rescuing_error_handler(self.task, \u0027some exception\u0027)"},{"line_number":1305,"context_line":""},{"line_number":1306,"context_line":"        node_power_mock.assert_called_once_with(mock.ANY, states.POWER_OFF)"},{"line_number":1307,"context_line":"        self.task.driver.rescue.clean_up.assert_called_once_with(self.task)"}],"source_content_type":"text/x-python","patch_set":85,"id":"7f96bb07_20769771","line":1304,"in_reply_to":"7f96bb07_bcd3d603","updated":"2018-01-19 09:21:46.000000000","message":"Done","commit_id":"142a29c21be377bd007bf6487970a1de77ee90a0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3f98e817122c0c90c16d93a1da13982451ff729c","unresolved":false,"context_lines":[{"line_number":1305,"context_line":""},{"line_number":1306,"context_line":"        node_power_mock.assert_called_once_with(mock.ANY, states.POWER_OFF)"},{"line_number":1307,"context_line":"        self.task.driver.rescue.clean_up.assert_called_once_with(self.task)"},{"line_number":1308,"context_line":"        self.assertTrue(log_mock.error.called)"},{"line_number":1309,"context_line":""},{"line_number":1310,"context_line":""},{"line_number":1311,"context_line":"class ValidatePortPhysnetTestCase(db_base.DbTestCase):"}],"source_content_type":"text/x-python","patch_set":85,"id":"7f96bb07_fce5dedc","line":1308,"updated":"2018-01-18 00:20:11.000000000","message":"I don\u0027t feel like this tests definitely the process_event() call -- I\u0027m assuming that\u0027s what you want to do here.","commit_id":"142a29c21be377bd007bf6487970a1de77ee90a0"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"05825b3305665de135f0e76b649ad53b07751d4e","unresolved":false,"context_lines":[{"line_number":1305,"context_line":""},{"line_number":1306,"context_line":"        node_power_mock.assert_called_once_with(mock.ANY, states.POWER_OFF)"},{"line_number":1307,"context_line":"        self.task.driver.rescue.clean_up.assert_called_once_with(self.task)"},{"line_number":1308,"context_line":"        self.assertTrue(log_mock.error.called)"},{"line_number":1309,"context_line":""},{"line_number":1310,"context_line":""},{"line_number":1311,"context_line":"class ValidatePortPhysnetTestCase(db_base.DbTestCase):"}],"source_content_type":"text/x-python","patch_set":85,"id":"7f96bb07_40716375","line":1308,"in_reply_to":"7f96bb07_fce5dedc","updated":"2018-01-19 09:21:46.000000000","message":"Done","commit_id":"142a29c21be377bd007bf6487970a1de77ee90a0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3f98e817122c0c90c16d93a1da13982451ff729c","unresolved":false,"context_lines":[{"line_number":1306,"context_line":"        node_power_mock.assert_called_once_with(mock.ANY, states.POWER_OFF)"},{"line_number":1307,"context_line":"        self.task.driver.rescue.clean_up.assert_called_once_with(self.task)"},{"line_number":1308,"context_line":"        self.assertTrue(log_mock.error.called)"},{"line_number":1309,"context_line":""},{"line_number":1310,"context_line":""},{"line_number":1311,"context_line":"class ValidatePortPhysnetTestCase(db_base.DbTestCase):"},{"line_number":1312,"context_line":""}],"source_content_type":"text/x-python","patch_set":85,"id":"7f96bb07_fcfe3e69","line":1309,"updated":"2018-01-18 00:20:11.000000000","message":"If anything, it seems like the most difficult part of this method being tested, is getting the error strings correct.","commit_id":"142a29c21be377bd007bf6487970a1de77ee90a0"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"05825b3305665de135f0e76b649ad53b07751d4e","unresolved":false,"context_lines":[{"line_number":1306,"context_line":"        node_power_mock.assert_called_once_with(mock.ANY, states.POWER_OFF)"},{"line_number":1307,"context_line":"        self.task.driver.rescue.clean_up.assert_called_once_with(self.task)"},{"line_number":1308,"context_line":"        self.assertTrue(log_mock.error.called)"},{"line_number":1309,"context_line":""},{"line_number":1310,"context_line":""},{"line_number":1311,"context_line":"class ValidatePortPhysnetTestCase(db_base.DbTestCase):"},{"line_number":1312,"context_line":""}],"source_content_type":"text/x-python","patch_set":85,"id":"7f96bb07_6e89e272","line":1309,"in_reply_to":"7f96bb07_fcfe3e69","updated":"2018-01-19 09:21:46.000000000","message":"Done","commit_id":"142a29c21be377bd007bf6487970a1de77ee90a0"}],"ironic/tests/unit/drivers/modules/test_agent.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3f98e817122c0c90c16d93a1da13982451ff729c","unresolved":false,"context_lines":[{"line_number":405,"context_line":"            pxe_prepare_ramdisk_mock.assert_called_once_with("},{"line_number":406,"context_line":"                task, {\u0027a\u0027: \u0027b\u0027})"},{"line_number":407,"context_line":"            build_options_mock.assert_called_once_with(task.node)"},{"line_number":408,"context_line":"            self.assertFalse(build_instance_info_mock.called)"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    def test_prepare_rescue_states(self):"},{"line_number":411,"context_line":"        for state in (states.RESCUING, states.RESCUEWAIT,"}],"source_content_type":"text/x-python","patch_set":85,"id":"7f96bb07_fc6b9eed","line":408,"updated":"2018-01-18 00:20:11.000000000","message":"i made a comment before about how odd it is that the oder of the asserts here is not the same order in the actual code. makes it hard to review :-(","commit_id":"142a29c21be377bd007bf6487970a1de77ee90a0"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"05825b3305665de135f0e76b649ad53b07751d4e","unresolved":false,"context_lines":[{"line_number":405,"context_line":"            pxe_prepare_ramdisk_mock.assert_called_once_with("},{"line_number":406,"context_line":"                task, {\u0027a\u0027: \u0027b\u0027})"},{"line_number":407,"context_line":"            build_options_mock.assert_called_once_with(task.node)"},{"line_number":408,"context_line":"            self.assertFalse(build_instance_info_mock.called)"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"    def test_prepare_rescue_states(self):"},{"line_number":411,"context_line":"        for state in (states.RESCUING, states.RESCUEWAIT,"}],"source_content_type":"text/x-python","patch_set":85,"id":"7f96bb07_2eb3daea","line":408,"in_reply_to":"7f96bb07_fc6b9eed","updated":"2018-01-19 09:21:46.000000000","message":"Done","commit_id":"142a29c21be377bd007bf6487970a1de77ee90a0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3f98e817122c0c90c16d93a1da13982451ff729c","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                       spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":426,"context_line":"    @mock.patch.object(deploy_utils, \u0027build_instance_info_for_deploy\u0027,"},{"line_number":427,"context_line":"                       spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":428,"context_line":"    def _test_prepare_active_and_unrescue_states("},{"line_number":429,"context_line":"            self, build_instance_info_mock, build_options_mock,"},{"line_number":430,"context_line":"            pxe_prepare_ramdisk_mock, pxe_prepare_instance_mock,"},{"line_number":431,"context_line":"            add_provisioning_net_mock, storage_driver_info_mock,"}],"source_content_type":"text/x-python","patch_set":85,"id":"7f96bb07_9c537a39","line":428,"updated":"2018-01-18 00:20:11.000000000","message":"maybe _test_prepare_conductor_takeover()","commit_id":"142a29c21be377bd007bf6487970a1de77ee90a0"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"05825b3305665de135f0e76b649ad53b07751d4e","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                       spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":426,"context_line":"    @mock.patch.object(deploy_utils, \u0027build_instance_info_for_deploy\u0027,"},{"line_number":427,"context_line":"                       spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":428,"context_line":"    def _test_prepare_active_and_unrescue_states("},{"line_number":429,"context_line":"            self, build_instance_info_mock, build_options_mock,"},{"line_number":430,"context_line":"            pxe_prepare_ramdisk_mock, pxe_prepare_instance_mock,"},{"line_number":431,"context_line":"            add_provisioning_net_mock, storage_driver_info_mock,"}],"source_content_type":"text/x-python","patch_set":85,"id":"7f96bb07_0eb05edc","line":428,"in_reply_to":"7f96bb07_9c537a39","updated":"2018-01-19 09:21:46.000000000","message":"Done","commit_id":"142a29c21be377bd007bf6487970a1de77ee90a0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3f98e817122c0c90c16d93a1da13982451ff729c","unresolved":false,"context_lines":[{"line_number":1276,"context_line":"            mock_build_agent_opts.assert_called_once_with(task.node)"},{"line_number":1277,"context_line":"            mock_clean_up_instance.assert_called_once_with(mock.ANY, task)"},{"line_number":1278,"context_line":"            mock_prepare_ramdisk.assert_called_once_with("},{"line_number":1279,"context_line":"                mock.ANY, task, {\u0027ipa-api-url\u0027: \u0027fake-api\u0027}, mode\u003d\u0027rescue\u0027)"},{"line_number":1280,"context_line":"            mock_node_power_action.assert_has_calls("},{"line_number":1281,"context_line":"                [mock.call(task, states.POWER_OFF),"},{"line_number":1282,"context_line":"                 mock.call(task, states.POWER_ON)])"}],"source_content_type":"text/x-python","patch_set":85,"id":"7f96bb07_773487de","line":1279,"updated":"2018-01-18 00:20:11.000000000","message":"it is taking me too much time to review this, trying to match the asserts with the code. please reorder them in the same order as the code is invoked.","commit_id":"142a29c21be377bd007bf6487970a1de77ee90a0"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"05825b3305665de135f0e76b649ad53b07751d4e","unresolved":false,"context_lines":[{"line_number":1276,"context_line":"            mock_build_agent_opts.assert_called_once_with(task.node)"},{"line_number":1277,"context_line":"            mock_clean_up_instance.assert_called_once_with(mock.ANY, task)"},{"line_number":1278,"context_line":"            mock_prepare_ramdisk.assert_called_once_with("},{"line_number":1279,"context_line":"                mock.ANY, task, {\u0027ipa-api-url\u0027: \u0027fake-api\u0027}, mode\u003d\u0027rescue\u0027)"},{"line_number":1280,"context_line":"            mock_node_power_action.assert_has_calls("},{"line_number":1281,"context_line":"                [mock.call(task, states.POWER_OFF),"},{"line_number":1282,"context_line":"                 mock.call(task, states.POWER_ON)])"}],"source_content_type":"text/x-python","patch_set":85,"id":"7f96bb07_cecd9666","line":1279,"in_reply_to":"7f96bb07_773487de","updated":"2018-01-19 09:21:46.000000000","message":"Done","commit_id":"142a29c21be377bd007bf6487970a1de77ee90a0"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9013b3688aa4826183f1a26d6af5bd482bf82644","unresolved":false,"context_lines":[{"line_number":1344,"context_line":"                                                 mock_prepare_instance,"},{"line_number":1345,"context_line":"                                                 mock_conf_tenant_net,"},{"line_number":1346,"context_line":"                                                 mock_remove_rescue_net):"},{"line_number":1347,"context_line":"        \"\"\"Test unrescue in case where boot driver prepares instance reboot.\"\"\""},{"line_number":1348,"context_line":"        self.config(manage_agent_boot\u003dFalse, group\u003d\u0027agent\u0027)"},{"line_number":1349,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":1350,"context_line":"            result \u003d task.driver.rescue.unrescue(task)"}],"source_content_type":"text/x-python","patch_set":89,"id":"5f93b717_b00ac223","line":1347,"updated":"2018-01-25 15:40:15.000000000","message":"s/prepares/does not prepare/","commit_id":"0d596aee4c12435b2d121203fb5b8483d984bdf7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3340982305950de60effbaf8ed7757f33816984f","unresolved":false,"context_lines":[{"line_number":1344,"context_line":"                                                 mock_prepare_instance,"},{"line_number":1345,"context_line":"                                                 mock_conf_tenant_net,"},{"line_number":1346,"context_line":"                                                 mock_remove_rescue_net):"},{"line_number":1347,"context_line":"        \"\"\"Test unrescue in case where boot driver prepares instance reboot.\"\"\""},{"line_number":1348,"context_line":"        self.config(manage_agent_boot\u003dFalse, group\u003d\u0027agent\u0027)"},{"line_number":1349,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":1350,"context_line":"            result \u003d task.driver.rescue.unrescue(task)"}],"source_content_type":"text/x-python","patch_set":89,"id":"5f93b717_24d18255","line":1347,"in_reply_to":"5f93b717_b00ac223","updated":"2018-01-26 14:32:21.000000000","message":"Done","commit_id":"0d596aee4c12435b2d121203fb5b8483d984bdf7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9013b3688aa4826183f1a26d6af5bd482bf82644","unresolved":false,"context_lines":[{"line_number":1375,"context_line":"        self.node.save()"},{"line_number":1376,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":1377,"context_line":"            task.driver.rescue.validate(task)"},{"line_number":1378,"context_line":"            mock_validate_network.assert_called_once_with("},{"line_number":1379,"context_line":"                CONF.neutron.rescuing_network, \u0027rescuing network\u0027,"},{"line_number":1380,"context_line":"                context\u003dtask.context)"},{"line_number":1381,"context_line":"            mock_boot_validate.assert_called_once_with(mock.ANY, task)"}],"source_content_type":"text/x-python","patch_set":89,"id":"5f93b717_5bb83f29","line":1378,"updated":"2018-01-25 15:40:15.000000000","message":"how is this true? I see task.driver.network.get_rescuing_network_uuid() being called. ARGH. It would have been easier if .get_rescuing_network_uuid had been mocked; took me several minutes to figure out what was going on.","commit_id":"0d596aee4c12435b2d121203fb5b8483d984bdf7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3340982305950de60effbaf8ed7757f33816984f","unresolved":false,"context_lines":[{"line_number":1375,"context_line":"        self.node.save()"},{"line_number":1376,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":1377,"context_line":"            task.driver.rescue.validate(task)"},{"line_number":1378,"context_line":"            mock_validate_network.assert_called_once_with("},{"line_number":1379,"context_line":"                CONF.neutron.rescuing_network, \u0027rescuing network\u0027,"},{"line_number":1380,"context_line":"                context\u003dtask.context)"},{"line_number":1381,"context_line":"            mock_boot_validate.assert_called_once_with(mock.ANY, task)"}],"source_content_type":"text/x-python","patch_set":89,"id":"5f93b717_84c97679","line":1378,"in_reply_to":"5f93b717_5bb83f29","updated":"2018-01-26 14:32:21.000000000","message":"Done","commit_id":"0d596aee4c12435b2d121203fb5b8483d984bdf7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9013b3688aa4826183f1a26d6af5bd482bf82644","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"        self.node.driver_info \u003d driver_info"},{"line_number":1407,"context_line":"        self.node.save()"},{"line_number":1408,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":1409,"context_line":"            self.assertRaises(exception.MissingParameterValue,"},{"line_number":1410,"context_line":"                              task.driver.rescue.validate, task)"},{"line_number":1411,"context_line":"            self.assertFalse(mock_validate_network.called)"},{"line_number":1412,"context_line":"            mock_boot_validate.assert_called_once_with(mock.ANY, task)"}],"source_content_type":"text/x-python","patch_set":89,"id":"5f93b717_bbcce389","line":1409,"updated":"2018-01-25 15:40:15.000000000","message":"i suppose we could do a regex to see if \u0027rescue_ramdisk\u0027 is in the exception msg.","commit_id":"0d596aee4c12435b2d121203fb5b8483d984bdf7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3340982305950de60effbaf8ed7757f33816984f","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"        self.node.driver_info \u003d driver_info"},{"line_number":1407,"context_line":"        self.node.save()"},{"line_number":1408,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":1409,"context_line":"            self.assertRaises(exception.MissingParameterValue,"},{"line_number":1410,"context_line":"                              task.driver.rescue.validate, task)"},{"line_number":1411,"context_line":"            self.assertFalse(mock_validate_network.called)"},{"line_number":1412,"context_line":"            mock_boot_validate.assert_called_once_with(mock.ANY, task)"}],"source_content_type":"text/x-python","patch_set":89,"id":"5f93b717_381446a0","line":1409,"in_reply_to":"5f93b717_bbcce389","updated":"2018-01-26 14:32:21.000000000","message":"Done","commit_id":"0d596aee4c12435b2d121203fb5b8483d984bdf7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9013b3688aa4826183f1a26d6af5bd482bf82644","unresolved":false,"context_lines":[{"line_number":1421,"context_line":"        self.node.save()"},{"line_number":1422,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":1423,"context_line":"            self.assertRaises(exception.MissingParameterValue,"},{"line_number":1424,"context_line":"                              task.driver.rescue.validate, task)"},{"line_number":1425,"context_line":"            self.assertFalse(mock_validate_network.called)"},{"line_number":1426,"context_line":"            mock_boot_validate.assert_called_once_with(mock.ANY, task)"},{"line_number":1427,"context_line":""}],"source_content_type":"text/x-python","patch_set":89,"id":"5f93b717_dbaa0f84","line":1424,"updated":"2018-01-25 15:40:15.000000000","message":"ditto for \u0027rescue_kernel\u0027","commit_id":"0d596aee4c12435b2d121203fb5b8483d984bdf7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3340982305950de60effbaf8ed7757f33816984f","unresolved":false,"context_lines":[{"line_number":1421,"context_line":"        self.node.save()"},{"line_number":1422,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":1423,"context_line":"            self.assertRaises(exception.MissingParameterValue,"},{"line_number":1424,"context_line":"                              task.driver.rescue.validate, task)"},{"line_number":1425,"context_line":"            self.assertFalse(mock_validate_network.called)"},{"line_number":1426,"context_line":"            mock_boot_validate.assert_called_once_with(mock.ANY, task)"},{"line_number":1427,"context_line":""}],"source_content_type":"text/x-python","patch_set":89,"id":"5f93b717_581912d5","line":1424,"in_reply_to":"5f93b717_dbaa0f84","updated":"2018-01-26 14:32:21.000000000","message":"Done","commit_id":"0d596aee4c12435b2d121203fb5b8483d984bdf7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9013b3688aa4826183f1a26d6af5bd482bf82644","unresolved":false,"context_lines":[{"line_number":1434,"context_line":"        self.node.instance_info \u003d instance_info"},{"line_number":1435,"context_line":"        self.node.save()"},{"line_number":1436,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":1437,"context_line":"            self.assertRaises(exception.MissingParameterValue,"},{"line_number":1438,"context_line":"                              task.driver.rescue.validate, task)"},{"line_number":1439,"context_line":"            self.assertFalse(mock_validate_network.called)"},{"line_number":1440,"context_line":"            mock_boot_validate.assert_called_once_with(mock.ANY, task)"}],"source_content_type":"text/x-python","patch_set":89,"id":"5f93b717_5b9eff63","line":1437,"updated":"2018-01-25 15:40:15.000000000","message":"ditto for rescue_password","commit_id":"0d596aee4c12435b2d121203fb5b8483d984bdf7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3340982305950de60effbaf8ed7757f33816984f","unresolved":false,"context_lines":[{"line_number":1434,"context_line":"        self.node.instance_info \u003d instance_info"},{"line_number":1435,"context_line":"        self.node.save()"},{"line_number":1436,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":1437,"context_line":"            self.assertRaises(exception.MissingParameterValue,"},{"line_number":1438,"context_line":"                              task.driver.rescue.validate, task)"},{"line_number":1439,"context_line":"            self.assertFalse(mock_validate_network.called)"},{"line_number":1440,"context_line":"            mock_boot_validate.assert_called_once_with(mock.ANY, task)"}],"source_content_type":"text/x-python","patch_set":89,"id":"5f93b717_f80d7e90","line":1437,"in_reply_to":"5f93b717_5b9eff63","updated":"2018-01-26 14:32:21.000000000","message":"Done","commit_id":"0d596aee4c12435b2d121203fb5b8483d984bdf7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9013b3688aa4826183f1a26d6af5bd482bf82644","unresolved":false,"context_lines":[{"line_number":1448,"context_line":"        self.node.instance_info \u003d instance_info"},{"line_number":1449,"context_line":"        self.node.save()"},{"line_number":1450,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":1451,"context_line":"            self.assertRaises(exception.InvalidParameterValue,"},{"line_number":1452,"context_line":"                              task.driver.rescue.validate, task)"},{"line_number":1453,"context_line":"            self.assertFalse(mock_validate_network.called)"},{"line_number":1454,"context_line":"            mock_boot_validate.assert_called_once_with(mock.ANY, task)"}],"source_content_type":"text/x-python","patch_set":89,"id":"5f93b717_1b8ab71a","line":1451,"updated":"2018-01-25 15:40:15.000000000","message":"ditto","commit_id":"0d596aee4c12435b2d121203fb5b8483d984bdf7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3340982305950de60effbaf8ed7757f33816984f","unresolved":false,"context_lines":[{"line_number":1448,"context_line":"        self.node.instance_info \u003d instance_info"},{"line_number":1449,"context_line":"        self.node.save()"},{"line_number":1450,"context_line":"        with task_manager.acquire(self.context, self.node.uuid) as task:"},{"line_number":1451,"context_line":"            self.assertRaises(exception.InvalidParameterValue,"},{"line_number":1452,"context_line":"                              task.driver.rescue.validate, task)"},{"line_number":1453,"context_line":"            self.assertFalse(mock_validate_network.called)"},{"line_number":1454,"context_line":"            mock_boot_validate.assert_called_once_with(mock.ANY, task)"}],"source_content_type":"text/x-python","patch_set":89,"id":"5f93b717_b827f612","line":1451,"in_reply_to":"5f93b717_1b8ab71a","updated":"2018-01-26 14:32:21.000000000","message":"Done","commit_id":"0d596aee4c12435b2d121203fb5b8483d984bdf7"}],"ironic/tests/unit/drivers/modules/test_agent_base_vendor.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9013b3688aa4826183f1a26d6af5bd482bf82644","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        log_mock.assert_called_once_with("},{"line_number":150,"context_line":"            \u0027Asynchronous exception: Failed checking if deploy is done. \u0027"},{"line_number":151,"context_line":"            \u0027Exception: LlamaException for node %(node)s\u0027,"},{"line_number":152,"context_line":"            {\u0027node\u0027: \u00271be26c0b-03f2-4d2e-ae87-c02d7f33c123\u0027})"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    @mock.patch.object(agent_base_vendor.HeartbeatMixin,"},{"line_number":155,"context_line":"                       \u0027deploy_has_started\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":89,"id":"5f93b717_b5d714c0","line":152,"updated":"2018-01-25 15:40:15.000000000","message":"this is odd. Why don\u0027t you just put the uuid in the string, it is hardcoded anyway. I suppose you could replace with task.node.uuid.\n\nI have to admit, I like the original string better. Although they are both not great, and now is not the time to clean it up, so this is fine.","commit_id":"0d596aee4c12435b2d121203fb5b8483d984bdf7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3340982305950de60effbaf8ed7757f33816984f","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        log_mock.assert_called_once_with("},{"line_number":150,"context_line":"            \u0027Asynchronous exception: Failed checking if deploy is done. \u0027"},{"line_number":151,"context_line":"            \u0027Exception: LlamaException for node %(node)s\u0027,"},{"line_number":152,"context_line":"            {\u0027node\u0027: \u00271be26c0b-03f2-4d2e-ae87-c02d7f33c123\u0027})"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    @mock.patch.object(agent_base_vendor.HeartbeatMixin,"},{"line_number":155,"context_line":"                       \u0027deploy_has_started\u0027, autospec\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":89,"id":"5f93b717_f8b7be85","line":152,"in_reply_to":"5f93b717_b5d714c0","updated":"2018-01-26 14:32:21.000000000","message":"Done","commit_id":"0d596aee4c12435b2d121203fb5b8483d984bdf7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9013b3688aa4826183f1a26d6af5bd482bf82644","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        log_mock.assert_called_once_with("},{"line_number":182,"context_line":"            \u0027Asynchronous exception: Failed checking if deploy is done. \u0027"},{"line_number":183,"context_line":"            \u0027Exception: LlamaException for node %(node)s\u0027,"},{"line_number":184,"context_line":"            {\u0027node\u0027: \u00271be26c0b-03f2-4d2e-ae87-c02d7f33c123\u0027})"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    @mock.patch.object(objects.node.Node, \u0027touch_provisioning\u0027, autospec\u003dTrue)"},{"line_number":187,"context_line":"    @mock.patch.object(agent_base_vendor.HeartbeatMixin,"}],"source_content_type":"text/x-python","patch_set":89,"id":"5f93b717_f0128ab1","line":184,"updated":"2018-01-25 15:40:15.000000000","message":"ditto","commit_id":"0d596aee4c12435b2d121203fb5b8483d984bdf7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3340982305950de60effbaf8ed7757f33816984f","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        log_mock.assert_called_once_with("},{"line_number":182,"context_line":"            \u0027Asynchronous exception: Failed checking if deploy is done. \u0027"},{"line_number":183,"context_line":"            \u0027Exception: LlamaException for node %(node)s\u0027,"},{"line_number":184,"context_line":"            {\u0027node\u0027: \u00271be26c0b-03f2-4d2e-ae87-c02d7f33c123\u0027})"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    @mock.patch.object(objects.node.Node, \u0027touch_provisioning\u0027, autospec\u003dTrue)"},{"line_number":187,"context_line":"    @mock.patch.object(agent_base_vendor.HeartbeatMixin,"}],"source_content_type":"text/x-python","patch_set":89,"id":"5f93b717_3863e61c","line":184,"in_reply_to":"5f93b717_f0128ab1","updated":"2018-01-26 14:32:21.000000000","message":"Done","commit_id":"0d596aee4c12435b2d121203fb5b8483d984bdf7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9013b3688aa4826183f1a26d6af5bd482bf82644","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                self.context, self.node.uuid, shared\u003dFalse) as task:"},{"line_number":290,"context_line":"            self.deploy.heartbeat(task, \u0027http://127.0.0.1:8080\u0027, \u00271.0.0\u0027)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        mock_finalize_rescue.assert_called_once_with(mock.ANY, task)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    @mock.patch.object(manager_utils, \u0027rescuing_error_handler\u0027)"},{"line_number":295,"context_line":"    @mock.patch.object(agent_base_vendor.HeartbeatMixin, \u0027_finalize_rescue\u0027,"}],"source_content_type":"text/x-python","patch_set":89,"id":"5f93b717_f54a7c7e","line":292,"updated":"2018-01-25 15:40:15.000000000","message":"i suppose you could check that rescuing_error_handler was not called. Otherwise how do we know that this succeeded?","commit_id":"0d596aee4c12435b2d121203fb5b8483d984bdf7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3340982305950de60effbaf8ed7757f33816984f","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                self.context, self.node.uuid, shared\u003dFalse) as task:"},{"line_number":290,"context_line":"            self.deploy.heartbeat(task, \u0027http://127.0.0.1:8080\u0027, \u00271.0.0\u0027)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        mock_finalize_rescue.assert_called_once_with(mock.ANY, task)"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    @mock.patch.object(manager_utils, \u0027rescuing_error_handler\u0027)"},{"line_number":295,"context_line":"    @mock.patch.object(agent_base_vendor.HeartbeatMixin, \u0027_finalize_rescue\u0027,"}],"source_content_type":"text/x-python","patch_set":89,"id":"5f93b717_f83a5ee5","line":292,"in_reply_to":"5f93b717_f54a7c7e","updated":"2018-01-26 14:32:21.000000000","message":"Done","commit_id":"0d596aee4c12435b2d121203fb5b8483d984bdf7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9013b3688aa4826183f1a26d6af5bd482bf82644","unresolved":false,"context_lines":[{"line_number":344,"context_line":"                impl \u003d \u0027flat\u0027"},{"line_number":345,"context_line":"            config_kwarg \u003d {\u0027enabled_%s_interfaces\u0027 % iface: [impl],"},{"line_number":346,"context_line":"                            \u0027default_%s_interface\u0027 % iface: impl}"},{"line_number":347,"context_line":"            self.config(**config_kwarg)"},{"line_number":348,"context_line":"        self.config(enabled_hardware_types\u003d[\u0027fake-hardware\u0027])"},{"line_number":349,"context_line":"        instance_info \u003d INSTANCE_INFO"},{"line_number":350,"context_line":"        driver_info \u003d DRIVER_INFO"}],"source_content_type":"text/x-python","patch_set":89,"id":"5f93b717_552ed0a5","line":347,"updated":"2018-01-25 15:40:15.000000000","message":"This all looks very similar to the setUp() in AgentDeployMixinBaseTest. Couldn\u0027t you subclass from that? It looks like the only diff is that you are setting the network interface to \u0027flat\u0027. Seems like you can do that and update the node\u0027s network interface too, after calling AgentDeployMixinBaseTest\u0027s setUp()?","commit_id":"0d596aee4c12435b2d121203fb5b8483d984bdf7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3340982305950de60effbaf8ed7757f33816984f","unresolved":false,"context_lines":[{"line_number":344,"context_line":"                impl \u003d \u0027flat\u0027"},{"line_number":345,"context_line":"            config_kwarg \u003d {\u0027enabled_%s_interfaces\u0027 % iface: [impl],"},{"line_number":346,"context_line":"                            \u0027default_%s_interface\u0027 % iface: impl}"},{"line_number":347,"context_line":"            self.config(**config_kwarg)"},{"line_number":348,"context_line":"        self.config(enabled_hardware_types\u003d[\u0027fake-hardware\u0027])"},{"line_number":349,"context_line":"        instance_info \u003d INSTANCE_INFO"},{"line_number":350,"context_line":"        driver_info \u003d DRIVER_INFO"}],"source_content_type":"text/x-python","patch_set":89,"id":"5f93b717_5b2d8c93","line":347,"in_reply_to":"5f93b717_552ed0a5","updated":"2018-01-26 14:32:21.000000000","message":"Done","commit_id":"0d596aee4c12435b2d121203fb5b8483d984bdf7"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9013b3688aa4826183f1a26d6af5bd482bf82644","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        self.node \u003d object_utils.create_test_node(self.context, **n)"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    @mock.patch.object(flat_network.FlatNetwork, \u0027configure_tenant_networks\u0027,"},{"line_number":361,"context_line":"                       spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":362,"context_line":"    @mock.patch.object(agent.AgentRescue, \u0027clean_up\u0027,"},{"line_number":363,"context_line":"                       spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":364,"context_line":"    @mock.patch.object(agent_client.AgentClient, \u0027finalize_rescue\u0027,"}],"source_content_type":"text/x-python","patch_set":89,"id":"5f93b717_b0916255","line":361,"updated":"2018-01-25 15:40:15.000000000","message":"if this is the only test/reason why the configs are diff in the setup, you don\u0027t need this. You can mock: task.driver.network.configure_tenant_networks \u003d mock.Mock()","commit_id":"0d596aee4c12435b2d121203fb5b8483d984bdf7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3340982305950de60effbaf8ed7757f33816984f","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        self.node \u003d object_utils.create_test_node(self.context, **n)"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    @mock.patch.object(flat_network.FlatNetwork, \u0027configure_tenant_networks\u0027,"},{"line_number":361,"context_line":"                       spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":362,"context_line":"    @mock.patch.object(agent.AgentRescue, \u0027clean_up\u0027,"},{"line_number":363,"context_line":"                       spec_set\u003dTrue, autospec\u003dTrue)"},{"line_number":364,"context_line":"    @mock.patch.object(agent_client.AgentClient, \u0027finalize_rescue\u0027,"}],"source_content_type":"text/x-python","patch_set":89,"id":"5f93b717_3be9a019","line":361,"in_reply_to":"5f93b717_b0916255","updated":"2018-01-26 14:32:21.000000000","message":"Done","commit_id":"0d596aee4c12435b2d121203fb5b8483d984bdf7"}],"ironic/tests/unit/drivers/modules/test_agent_client.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"ab4ff5fe59bcddd7948bbcdeced0894aef00079c","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        self.client._command.assert_called_once_with("},{"line_number":268,"context_line":"            node\u003dself.node, method\u003d\u0027standby.sync\u0027, params\u003d{}, wait\u003dTrue)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    def test_finalize_rescue(self):"},{"line_number":271,"context_line":"        self.client._command \u003d mock.MagicMock(spec_set\u003d[])"},{"line_number":272,"context_line":"        self.node.instance_info[\u0027rescue_password\u0027] \u003d \u0027password\u0027"},{"line_number":273,"context_line":"        expected_params \u003d {"}],"source_content_type":"text/x-python","patch_set":56,"id":"7f515b1d_bfcff67d","line":270,"range":{"start_line":270,"start_character":8,"end_line":270,"end_character":28},"updated":"2017-09-25 07:23:27.000000000","message":"nit: needs two underscores here for we are testing _finalize_rescue","commit_id":"4701e09b29e197c8637f72fd7ff49db4d1710154"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"0d3bbf64848681dffa77a8a8e106cfa7929beffc","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        self.client._command.assert_called_once_with("},{"line_number":268,"context_line":"            node\u003dself.node, method\u003d\u0027standby.sync\u0027, params\u003d{}, wait\u003dTrue)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    def test_finalize_rescue(self):"},{"line_number":271,"context_line":"        self.client._command \u003d mock.MagicMock(spec_set\u003d[])"},{"line_number":272,"context_line":"        self.node.instance_info[\u0027rescue_password\u0027] \u003d \u0027password\u0027"},{"line_number":273,"context_line":"        expected_params \u003d {"}],"source_content_type":"text/x-python","patch_set":56,"id":"7f515b1d_8d14eca1","line":270,"range":{"start_line":270,"start_character":8,"end_line":270,"end_character":28},"in_reply_to":"7f515b1d_bfcff67d","updated":"2017-09-27 16:31:32.000000000","message":"No. We are testing agent_client.finalize_rescue() here, though its gets called from agent_base_vendor._finalize_rescue()","commit_id":"4701e09b29e197c8637f72fd7ff49db4d1710154"}],"ironic/tests/unit/drivers/modules/test_deploy_utils.py":[{"author":{"_account_id":24828,"name":"Kaifeng Wang","email":"kaifeng.w@gmail.com","username":"wangkf"},"change_message_id":"b69c24e84edced631b5b6a90c4e04db6f9040be6","unresolved":false,"context_lines":[{"line_number":1924,"context_line":""},{"line_number":1925,"context_line":"    def test_parse_instance_info_good(self):"},{"line_number":1926,"context_line":"        # make sure we get back the expected things"},{"line_number":1927,"context_line":"        instance_info \u003d INST_INFO_DICT"},{"line_number":1928,"context_line":"        instance_info[\u0027configdrive\u0027] \u003d None"},{"line_number":1929,"context_line":"        node \u003d obj_utils.create_test_node("},{"line_number":1930,"context_line":"            self.context, driver\u003d\u0027fake_pxe\u0027,"},{"line_number":1931,"context_line":"            instance_info\u003dinstance_info,"}],"source_content_type":"text/x-python","patch_set":27,"id":"ffe62b97_6ddbd71a","line":1928,"range":{"start_line":1927,"start_character":8,"end_line":1928,"end_character":43},"updated":"2017-03-27 15:55:08.000000000","message":"seems not related to this patch.","commit_id":"0f81050cf6ca173f504835611f1c65fe74b6fdd9"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"fc8b2c891c6e0d972220763c934e4993c94f616a","unresolved":false,"context_lines":[{"line_number":1924,"context_line":""},{"line_number":1925,"context_line":"    def test_parse_instance_info_good(self):"},{"line_number":1926,"context_line":"        # make sure we get back the expected things"},{"line_number":1927,"context_line":"        instance_info \u003d INST_INFO_DICT"},{"line_number":1928,"context_line":"        instance_info[\u0027configdrive\u0027] \u003d None"},{"line_number":1929,"context_line":"        node \u003d obj_utils.create_test_node("},{"line_number":1930,"context_line":"            self.context, driver\u003d\u0027fake_pxe\u0027,"},{"line_number":1931,"context_line":"            instance_info\u003dinstance_info,"}],"source_content_type":"text/x-python","patch_set":27,"id":"ffe62b97_09f2919a","line":1928,"range":{"start_line":1927,"start_character":8,"end_line":1928,"end_character":43},"in_reply_to":"ffe62b97_6ddbd71a","updated":"2017-03-29 16:52:24.000000000","message":"Removed here and below. This was leftover from when this patch was going to add support for passing configdrive to IPA for static network configuration, but we\u0027ll save that for another patch.","commit_id":"0f81050cf6ca173f504835611f1c65fe74b6fdd9"}],"ironic/tests/unit/drivers/test_ipmi.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9013b3688aa4826183f1a26d6af5bd482bf82644","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            self._validate_interfaces(task, storage\u003dcinder.CinderStorage)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def test_override_with_agent_rescue(self):"},{"line_number":99,"context_line":"        self.config(enabled_rescue_interfaces\u003d[\u0027agent\u0027])"},{"line_number":100,"context_line":"        node \u003d obj_utils.create_test_node("},{"line_number":101,"context_line":"            self.context, driver\u003d\u0027ipmi\u0027,"},{"line_number":102,"context_line":"            rescue_interface\u003d\u0027agent\u0027)"}],"source_content_type":"text/x-python","patch_set":89,"id":"5f93b717_75f0ac91","line":99,"updated":"2018-01-25 15:40:15.000000000","message":"i think it might be better as [\u0027no-rescue\u0027, \u0027agent\u0027]\n\nso that if there is no override, the default would be no-rescue. With what you have, I think the default would be \u0027agent\u0027. If so, we don\u0027t know if the override worked, it could have taken the value from the config.","commit_id":"0d596aee4c12435b2d121203fb5b8483d984bdf7"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"3340982305950de60effbaf8ed7757f33816984f","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            self._validate_interfaces(task, storage\u003dcinder.CinderStorage)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def test_override_with_agent_rescue(self):"},{"line_number":99,"context_line":"        self.config(enabled_rescue_interfaces\u003d[\u0027agent\u0027])"},{"line_number":100,"context_line":"        node \u003d obj_utils.create_test_node("},{"line_number":101,"context_line":"            self.context, driver\u003d\u0027ipmi\u0027,"},{"line_number":102,"context_line":"            rescue_interface\u003d\u0027agent\u0027)"}],"source_content_type":"text/x-python","patch_set":89,"id":"5f93b717_dbc2fc85","line":99,"in_reply_to":"5f93b717_75f0ac91","updated":"2018-01-26 14:32:21.000000000","message":"Done","commit_id":"0d596aee4c12435b2d121203fb5b8483d984bdf7"}]}
