)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"0544cb42bbef9ee1b6451e59a7aa0af8c5fcc7e9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This change adds ironic.drivers.generic.GenericHardware which contains"},{"line_number":10,"context_line":"useful defaults. Other hardware types are recommended to derive from it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Add reasonable vendor-independent defaults to enabled_{deploy,raid,boot}_interfaces"},{"line_number":13,"context_line":"configuration options. Add an entry point for \"inspector\" inspect implementation."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Also adding ironic.drivers.generic.ManualManagementHardware. This hardware"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"1a6eadb0_4d944142","line":12,"updated":"2016-12-15 11:39:55.000000000","message":"lines are long","commit_id":"30c3ed312e91ab9bee5b8c611a8c36f857d5fd2b"}],"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"cf1fd427e6a124834cf61e082967411bd3f65cd7","unresolved":false,"context_lines":[{"line_number":104,"context_line":"# this value, please make sure that every enabled hardware"},{"line_number":105,"context_line":"# type will have the same set of enabled deploy interfaces on"},{"line_number":106,"context_line":"# every ironic-conductor service. (list value)"},{"line_number":107,"context_line":"#enabled_deploy_interfaces \u003d iscsi,http"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"# WARNING: This configuration option is part of the incomplete"},{"line_number":110,"context_line":"# driver composition work, changing it\u0027s setting has no"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"1a6eadb0_e7c26fe8","line":107,"range":{"start_line":107,"start_character":35,"end_line":107,"end_character":39},"updated":"2016-12-15 21:45:01.000000000","message":"Why is the agent deploy driver called \"http\"? Is there some sort of namespace conflict between this and the \"agent\" raid interface?","commit_id":"30c3ed312e91ab9bee5b8c611a8c36f857d5fd2b"}],"ironic/conf/default.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"ec5e6cd2f759b50a9dc39a116c1024785f610187","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                       \u0027A complete list of hardware types present on your \u0027"},{"line_number":109,"context_line":"                       \u0027system may be found by enumerating the \u0027"},{"line_number":110,"context_line":"                       \u0027\"ironic.hardware.types\" entrypoint.\u0027)),"},{"line_number":111,"context_line":"    # TODO(dtantsur): populate with production-ready values"},{"line_number":112,"context_line":"    cfg.ListOpt(\u0027enabled_boot_interfaces\u0027,"},{"line_number":113,"context_line":"                default\u003d[\u0027pxe\u0027],"},{"line_number":114,"context_line":"                help\u003d_ENABLED_IFACE_HELP_WITH_WARNING.format(\u0027boot\u0027)),"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a6eadb0_d5933d59","line":111,"updated":"2016-12-16 12:41:25.000000000","message":"Remove this? :)","commit_id":"30c3ed312e91ab9bee5b8c611a8c36f857d5fd2b"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"8b00491e455b1b12c5d81a05f1be7a98b1919e89","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                       \u0027\"ironic.hardware.types\" entrypoint.\u0027)),"},{"line_number":111,"context_line":"    # TODO(dtantsur): populate with production-ready values"},{"line_number":112,"context_line":"    cfg.ListOpt(\u0027enabled_boot_interfaces\u0027,"},{"line_number":113,"context_line":"                default\u003d[\u0027pxe\u0027],"},{"line_number":114,"context_line":"                help\u003d_ENABLED_IFACE_HELP_WITH_WARNING.format(\u0027boot\u0027)),"},{"line_number":115,"context_line":"    cfg.StrOpt(\u0027default_boot_interface\u0027,"},{"line_number":116,"context_line":"               help\u003d_DEFAULT_IFACE_HELP_WITH_WARNING.format(\u0027boot\u0027)),"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a6eadb0_4ce7b1ab","line":113,"updated":"2016-12-16 10:07:12.000000000","message":"We change default values for config option, and probably should mention it in release notes.","commit_id":"30c3ed312e91ab9bee5b8c611a8c36f857d5fd2b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"ec5e6cd2f759b50a9dc39a116c1024785f610187","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                       \u0027\"ironic.hardware.types\" entrypoint.\u0027)),"},{"line_number":111,"context_line":"    # TODO(dtantsur): populate with production-ready values"},{"line_number":112,"context_line":"    cfg.ListOpt(\u0027enabled_boot_interfaces\u0027,"},{"line_number":113,"context_line":"                default\u003d[\u0027pxe\u0027],"},{"line_number":114,"context_line":"                help\u003d_ENABLED_IFACE_HELP_WITH_WARNING.format(\u0027boot\u0027)),"},{"line_number":115,"context_line":"    cfg.StrOpt(\u0027default_boot_interface\u0027,"},{"line_number":116,"context_line":"               help\u003d_DEFAULT_IFACE_HELP_WITH_WARNING.format(\u0027boot\u0027)),"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a6eadb0_75b3490a","line":113,"in_reply_to":"1a6eadb0_4ce7b1ab","updated":"2016-12-16 12:41:25.000000000","message":"+1, though I think we should have one big reno for this at the end instead. People can\u0027t use this without the API anyway.","commit_id":"30c3ed312e91ab9bee5b8c611a8c36f857d5fd2b"}],"setup.cfg":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"6ee319cbbddcc4493aea18278bc582b1e616d988","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    no-console \u003d ironic.drivers.modules.noop:NoConsole"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"ironic.hardware.interfaces.deploy \u003d"},{"line_number":109,"context_line":"    http \u003d ironic.drivers.modules.agent:AgentDeploy"},{"line_number":110,"context_line":"    iscsi \u003d ironic.drivers.modules.iscsi_deploy:ISCSIDeploy"},{"line_number":111,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeDeploy"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":12,"id":"1a6eadb0_ab7041a5","line":109,"updated":"2016-12-15 21:53:00.000000000","message":"Why can\u0027t this just be agent for consistency with existing setups? If we don\u0027t want to use agent, I don\u0027t like http at all as an alternative.","commit_id":"30c3ed312e91ab9bee5b8c611a8c36f857d5fd2b"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"1d6a46b63956ff827a108919e5b9fb7b206c8759","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    no-console \u003d ironic.drivers.modules.noop:NoConsole"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"ironic.hardware.interfaces.deploy \u003d"},{"line_number":109,"context_line":"    http \u003d ironic.drivers.modules.agent:AgentDeploy"},{"line_number":110,"context_line":"    iscsi \u003d ironic.drivers.modules.iscsi_deploy:ISCSIDeploy"},{"line_number":111,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeDeploy"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":12,"id":"1a6eadb0_f5fbd944","line":109,"in_reply_to":"1a6eadb0_35b9d1cc","updated":"2016-12-16 12:49:00.000000000","message":"Now I have more thoughts on this:\nWe can have different deploy agents, IPA, Ansible we need to specify agent type in the name.\nMight be use iscsi, direct_ipa, direct_${agent_type}?","commit_id":"30c3ed312e91ab9bee5b8c611a8c36f857d5fd2b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"ec5e6cd2f759b50a9dc39a116c1024785f610187","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    no-console \u003d ironic.drivers.modules.noop:NoConsole"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"ironic.hardware.interfaces.deploy \u003d"},{"line_number":109,"context_line":"    http \u003d ironic.drivers.modules.agent:AgentDeploy"},{"line_number":110,"context_line":"    iscsi \u003d ironic.drivers.modules.iscsi_deploy:ISCSIDeploy"},{"line_number":111,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeDeploy"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":12,"id":"1a6eadb0_35b9d1cc","line":109,"in_reply_to":"1a6eadb0_4c59718d","updated":"2016-12-16 12:41:25.000000000","message":"Agree, I like direct and iscsi.","commit_id":"30c3ed312e91ab9bee5b8c611a8c36f857d5fd2b"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"f3798f6d262874e5e9e371883ad9bbf24de742b3","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    no-console \u003d ironic.drivers.modules.noop:NoConsole"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"ironic.hardware.interfaces.deploy \u003d"},{"line_number":109,"context_line":"    http \u003d ironic.drivers.modules.agent:AgentDeploy"},{"line_number":110,"context_line":"    iscsi \u003d ironic.drivers.modules.iscsi_deploy:ISCSIDeploy"},{"line_number":111,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeDeploy"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":12,"id":"1a6eadb0_f80ae4d0","line":109,"in_reply_to":"1a6eadb0_551e4d70","updated":"2016-12-16 16:32:05.000000000","message":"both ansible and ipa uses direct methods of writing images. Might be better to use agent name as deploy interface name i.e. ansible, ipa?","commit_id":"30c3ed312e91ab9bee5b8c611a8c36f857d5fd2b"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"8b00491e455b1b12c5d81a05f1be7a98b1919e89","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    no-console \u003d ironic.drivers.modules.noop:NoConsole"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"ironic.hardware.interfaces.deploy \u003d"},{"line_number":109,"context_line":"    http \u003d ironic.drivers.modules.agent:AgentDeploy"},{"line_number":110,"context_line":"    iscsi \u003d ironic.drivers.modules.iscsi_deploy:ISCSIDeploy"},{"line_number":111,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeDeploy"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":12,"id":"1a6eadb0_4c59718d","line":109,"in_reply_to":"1a6eadb0_ab7041a5","updated":"2016-12-16 10:07:12.000000000","message":"I don\u0027t like http either. According to spec deploy interface specifies which deploy approach is used (ISCSI or direct).\n\nCurrently agent can download image via HTTP/HTTPs but in future  the number of protocols may be extended, for example with torrents.\n\nMight be use: remote - for ISCSI deploy and direct - for AgentDeploy?","commit_id":"30c3ed312e91ab9bee5b8c611a8c36f857d5fd2b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"552c7852c716f2167e311c37d5cd2de553dd08e5","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    no-console \u003d ironic.drivers.modules.noop:NoConsole"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"ironic.hardware.interfaces.deploy \u003d"},{"line_number":109,"context_line":"    http \u003d ironic.drivers.modules.agent:AgentDeploy"},{"line_number":110,"context_line":"    iscsi \u003d ironic.drivers.modules.iscsi_deploy:ISCSIDeploy"},{"line_number":111,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeDeploy"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":12,"id":"1a6eadb0_551e4d70","line":109,"in_reply_to":"1a6eadb0_f5fbd944","updated":"2016-12-16 12:53:35.000000000","message":"I\u0027d prefer the same method to work similarly for different agent types. So I\u0027d keep iscsi, direct, ansible, etc.","commit_id":"30c3ed312e91ab9bee5b8c611a8c36f857d5fd2b"}]}