)]}'
{"ironic/drivers/modules/oneview/management.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"060d60aba66b768048d6dac5ee871ae1e7aec66d","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        if not deploy_utils.is_node_in_use_by_ironic(task.node):"},{"line_number":75,"context_line":"            raise exception.OneViewError("},{"line_number":76,"context_line":"                _(\"Node %s is not in use by ironic.\") % task.node.uuid)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @METRICS.timer(\u0027OneViewManagement.get_supported_boot_devices\u0027)"},{"line_number":79,"context_line":"    def get_supported_boot_devices(self, task):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_d89f5a4e","line":76,"updated":"2016-11-25 10:53:03.000000000","message":"Ironic conductor expects this method to raise either: InvalidParameterValue or UnsupportedDriverExtension. Anything else would break: https://github.com/openstack/ironic/blob/master/ironic/conductor/manager.py#L1425-L1426","commit_id":"603df99bbc5d7a60dbc28ceaa8e172dbcd90066e"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"ed27907304aa189f1eb824e8999735593c959d15","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        if not deploy_utils.is_node_in_use_by_ironic(task.node):"},{"line_number":75,"context_line":"            raise exception.OneViewError("},{"line_number":76,"context_line":"                _(\"Node %s is not in use by ironic.\") % task.node.uuid)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @METRICS.timer(\u0027OneViewManagement.get_supported_boot_devices\u0027)"},{"line_number":79,"context_line":"    def get_supported_boot_devices(self, task):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_ad9ad611","line":76,"in_reply_to":"5a74a57a_d89f5a4e","updated":"2016-11-29 15:51:25.000000000","message":"Good catch Lucas, I think should be a special case for process unexpected exception also in validate_driver_interfaces(), because third-party drivers can break this method.","commit_id":"603df99bbc5d7a60dbc28ceaa8e172dbcd90066e"},{"author":{"_account_id":23375,"name":"Stenio Araujo","email":"stenioaraujo@lsd.ufcg.edu.br","username":"stenioaraujo"},"change_message_id":"91d361fdb87c2a00b693ebbf4114e3a124121fcf","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        if not deploy_utils.is_node_in_use_by_ironic(task.node):"},{"line_number":75,"context_line":"            raise exception.OneViewError("},{"line_number":76,"context_line":"                _(\"Node %s is not in use by ironic.\") % task.node.uuid)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    @METRICS.timer(\u0027OneViewManagement.get_supported_boot_devices\u0027)"},{"line_number":79,"context_line":"    def get_supported_boot_devices(self, task):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_f7b101e1","line":76,"in_reply_to":"5a74a57a_d89f5a4e","updated":"2016-11-29 15:12:59.000000000","message":"Hi Lucas Alvares Gomes,\n\nIndeed, I did not see that. My idea was to reuse the errors raised by the other functions, since two of them raise OneViewError. My intention was to let them be OneViewError isntead of wraping them as InvalidParameterValue. Thank you for the heads up.","commit_id":"603df99bbc5d7a60dbc28ceaa8e172dbcd90066e"}]}
