)]}'
{"ironic/drivers/modules/agent_base_vendor.py":[{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"bf5e35ff83ad7f66306d3e9e24f7faed46259dd0","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                LOG.debug(\u0027Heartbeat from node %(node)s in maintenance mode; \u0027"},{"line_number":290,"context_line":"                          \u0027not taking any action.\u0027, {\u0027node\u0027: node.uuid})"},{"line_number":291,"context_line":"                return"},{"line_number":292,"context_line":"            elif (node.provision_state \u003d\u003d states.DEPLOYWAIT and"},{"line_number":293,"context_line":"                  not self.deploy_has_started(task)):"},{"line_number":294,"context_line":"                msg \u003d _(\u0027Node failed to deploy.\u0027)"},{"line_number":295,"context_line":"                self.continue_deploy(task)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_ef5c287f","line":292,"updated":"2017-01-11 22:46:55.000000000","message":"Just wondering if other states need to be checked as well, such as VERIFYING or ADOPTING.","commit_id":"c9a5d1b153cc707279755bcd64bcb841e7784ec8"},{"author":{"_account_id":19686,"name":"Ramamani Yeleswarapu","email":"ramamani.yeleswarapu@intel.com","username":"Rama_Y"},"change_message_id":"6cf963b36dee2258c35baa11112f878851b685e6","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                LOG.debug(\u0027Heartbeat from node %(node)s in maintenance mode; \u0027"},{"line_number":290,"context_line":"                          \u0027not taking any action.\u0027, {\u0027node\u0027: node.uuid})"},{"line_number":291,"context_line":"                return"},{"line_number":292,"context_line":"            elif (node.provision_state \u003d\u003d states.DEPLOYWAIT and"},{"line_number":293,"context_line":"                  not self.deploy_has_started(task)):"},{"line_number":294,"context_line":"                msg \u003d _(\u0027Node failed to deploy.\u0027)"},{"line_number":295,"context_line":"                self.continue_deploy(task)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_dbd14afd","line":292,"in_reply_to":"9a57fde8_233a62ce","updated":"2017-01-14 00:05:22.000000000","message":"Thanks.","commit_id":"c9a5d1b153cc707279755bcd64bcb841e7784ec8"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"324a6e45adb9afd07b534ce427286237dc77a101","unresolved":false,"context_lines":[{"line_number":289,"context_line":"                LOG.debug(\u0027Heartbeat from node %(node)s in maintenance mode; \u0027"},{"line_number":290,"context_line":"                          \u0027not taking any action.\u0027, {\u0027node\u0027: node.uuid})"},{"line_number":291,"context_line":"                return"},{"line_number":292,"context_line":"            elif (node.provision_state \u003d\u003d states.DEPLOYWAIT and"},{"line_number":293,"context_line":"                  not self.deploy_has_started(task)):"},{"line_number":294,"context_line":"                msg \u003d _(\u0027Node failed to deploy.\u0027)"},{"line_number":295,"context_line":"                self.continue_deploy(task)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a57fde8_233a62ce","line":292,"in_reply_to":"ba5201f7_ef5c287f","updated":"2017-01-12 09:30:56.000000000","message":"No, as there are only 4 states in which there is a legitimate possibility of a heartbeat from the agent, which are during deployment (DEPLOYING and DEPLOYWAIT) and cleaning (CLEANING and CLEANWAIT) - only in this states there should be an agent running in a ramdisk on the node. And due to async nature of agent operations, only in *WAIT states should ironic attempt to do something.\n\nBesides, this is just a copy of current method in AgentDeployMixin.","commit_id":"c9a5d1b153cc707279755bcd64bcb841e7784ec8"}]}