)]}'
{"ironic_tempest_plugin/config.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"4005f608537a0e0c698c20fd068373e6117ff7cd","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from tempest import config  # noqa"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"service_option \u003d cfg.BoolOpt(\u0027ironic\u0027,"},{"line_number":22,"context_line":"                             default\u003dTrue,"},{"line_number":23,"context_line":"                             help\u003d\u0027Whether or not ironic is expected to be \u0027"},{"line_number":24,"context_line":"                                  \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_1fc58f5a","line":21,"updated":"2016-11-30 08:36:22.000000000","message":"If we registering option that already registered it should have identical values as original. \n\nhttps://github.com/openstack/tempest/blob/master/tempest/config.py#L972\n\nFor now it should be False by default, and we should enable in in devstack plugin:\n\nhttps://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L1609\n\niniset $TEMPEST_CONFIG service_available ironic True","commit_id":"2ef6c9e5fbe40c9168756607bad4b81bde7d3fc5"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"d4aabfc5ae8a41e3e40fd82cbda379078fc53873","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from tempest import config  # noqa"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"service_option \u003d cfg.BoolOpt(\u0027ironic\u0027,"},{"line_number":22,"context_line":"                             default\u003dTrue,"},{"line_number":23,"context_line":"                             help\u003d\u0027Whether or not ironic is expected to be \u0027"},{"line_number":24,"context_line":"                                  \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_8ce16e01","line":21,"in_reply_to":"5a74a57a_0e81db8f","updated":"2016-11-30 12:25:49.000000000","message":"Why? It makes sense for it to be off by default in tempest, but if one is installing the ironic plugin, they probably expect it to be on, right?\n\nI don\u0027t mind changing it, just odd to me.","commit_id":"2ef6c9e5fbe40c9168756607bad4b81bde7d3fc5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"78d81ac3c3e1c1ac43d483739d02195e6040b211","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from tempest import config  # noqa"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"service_option \u003d cfg.BoolOpt(\u0027ironic\u0027,"},{"line_number":22,"context_line":"                             default\u003dTrue,"},{"line_number":23,"context_line":"                             help\u003d\u0027Whether or not ironic is expected to be \u0027"},{"line_number":24,"context_line":"                                  \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_0e81db8f","line":21,"in_reply_to":"5a74a57a_1fc58f5a","updated":"2016-11-30 10:16:02.000000000","message":"Agreed, we are just moving it around we should keep the same default behavior","commit_id":"2ef6c9e5fbe40c9168756607bad4b81bde7d3fc5"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"5b3a16c56aa066180ff9fa426eafcffb2b646426","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from tempest import config  # noqa"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"service_option \u003d cfg.BoolOpt(\u0027ironic\u0027,"},{"line_number":22,"context_line":"                             default\u003dTrue,"},{"line_number":23,"context_line":"                             help\u003d\u0027Whether or not ironic is expected to be \u0027"},{"line_number":24,"context_line":"                                  \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_0c747efb","line":21,"in_reply_to":"5a74a57a_8ce16e01","updated":"2016-11-30 12:39:26.000000000","message":"Done","commit_id":"2ef6c9e5fbe40c9168756607bad4b81bde7d3fc5"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"4005f608537a0e0c698c20fd068373e6117ff7cd","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"service_option \u003d cfg.BoolOpt(\u0027ironic\u0027,"},{"line_number":22,"context_line":"                             default\u003dTrue,"},{"line_number":23,"context_line":"                             help\u003d\u0027Whether or not ironic is expected to be \u0027"},{"line_number":24,"context_line":"                                  \u0027available\u0027)"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_bff81bc6","line":22,"range":{"start_line":22,"start_character":37,"end_line":22,"end_character":41},"updated":"2016-11-30 08:36:22.000000000","message":"s/True/False","commit_id":"2ef6c9e5fbe40c9168756607bad4b81bde7d3fc5"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"5b3a16c56aa066180ff9fa426eafcffb2b646426","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"service_option \u003d cfg.BoolOpt(\u0027ironic\u0027,"},{"line_number":22,"context_line":"                             default\u003dTrue,"},{"line_number":23,"context_line":"                             help\u003d\u0027Whether or not ironic is expected to be \u0027"},{"line_number":24,"context_line":"                                  \u0027available\u0027)"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_4c64b648","line":22,"range":{"start_line":22,"start_character":37,"end_line":22,"end_character":41},"in_reply_to":"5a74a57a_bff81bc6","updated":"2016-11-30 12:39:26.000000000","message":"Done","commit_id":"2ef6c9e5fbe40c9168756607bad4b81bde7d3fc5"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"4005f608537a0e0c698c20fd068373e6117ff7cd","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"service_option \u003d cfg.BoolOpt(\u0027ironic\u0027,"},{"line_number":22,"context_line":"                             default\u003dTrue,"},{"line_number":23,"context_line":"                             help\u003d\u0027Whether or not ironic is expected to be \u0027"},{"line_number":24,"context_line":"                                  \u0027available\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_5f30e79e","line":23,"range":{"start_line":23,"start_character":50,"end_line":23,"end_character":56},"updated":"2016-11-30 08:36:22.000000000","message":"s/ironic/Ironic","commit_id":"2ef6c9e5fbe40c9168756607bad4b81bde7d3fc5"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"5b3a16c56aa066180ff9fa426eafcffb2b646426","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"service_option \u003d cfg.BoolOpt(\u0027ironic\u0027,"},{"line_number":22,"context_line":"                             default\u003dTrue,"},{"line_number":23,"context_line":"                             help\u003d\u0027Whether or not ironic is expected to be \u0027"},{"line_number":24,"context_line":"                                  \u0027available\u0027)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_6c59728e","line":23,"range":{"start_line":23,"start_character":50,"end_line":23,"end_character":56},"in_reply_to":"5a74a57a_5f30e79e","updated":"2016-11-30 12:39:26.000000000","message":"Done","commit_id":"2ef6c9e5fbe40c9168756607bad4b81bde7d3fc5"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2d2f0b43151f58cba664c07d4de570374a698e50","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"service_option \u003d cfg.BoolOpt(\u0027ironic\u0027,"},{"line_number":22,"context_line":"                             default\u003dFalse,"},{"line_number":23,"context_line":"                             help\u003d\u0027Whether or not Ironic is expected to be \u0027"},{"line_number":24,"context_line":"                                  \u0027available\u0027)"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a71b18c_57346edd","line":22,"range":{"start_line":22,"start_character":37,"end_line":22,"end_character":42},"updated":"2016-12-01 07:56:15.000000000","message":"I see. may be after tempest patch land, we can make it True","commit_id":"be9ce2d47b65dd01f6a0e4fd5825f50f2908624d"}],"ironic_tempest_plugin/plugin.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"4005f608537a0e0c698c20fd068373e6117ff7cd","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        return full_test_dir, base_path"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def register_opts(self, conf):"},{"line_number":34,"context_line":"        config.register_opt(config.service_option,"},{"line_number":35,"context_line":"                            group\u003d\u0027service_available\u0027)"},{"line_number":36,"context_line":"        config.register_opt_group(conf, project_config.baremetal_group,"},{"line_number":37,"context_line":"                                  project_config.BaremetalGroup)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_ffe61343","line":35,"range":{"start_line":34,"start_character":8,"end_line":35,"end_character":54},"updated":"2016-11-30 08:36:22.000000000","message":"should be:\n\nconf.register_opt(project_config.service_option,\n                            group\u003d\u0027service_available\u0027)","commit_id":"2ef6c9e5fbe40c9168756607bad4b81bde7d3fc5"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"5b3a16c56aa066180ff9fa426eafcffb2b646426","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        return full_test_dir, base_path"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def register_opts(self, conf):"},{"line_number":34,"context_line":"        config.register_opt(config.service_option,"},{"line_number":35,"context_line":"                            group\u003d\u0027service_available\u0027)"},{"line_number":36,"context_line":"        config.register_opt_group(conf, project_config.baremetal_group,"},{"line_number":37,"context_line":"                                  project_config.BaremetalGroup)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_cc50c661","line":35,"range":{"start_line":34,"start_character":8,"end_line":35,"end_character":54},"in_reply_to":"5a74a57a_4cbe76d5","updated":"2016-11-30 12:39:26.000000000","message":"Done","commit_id":"2ef6c9e5fbe40c9168756607bad4b81bde7d3fc5"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"d4aabfc5ae8a41e3e40fd82cbda379078fc53873","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        return full_test_dir, base_path"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def register_opts(self, conf):"},{"line_number":34,"context_line":"        config.register_opt(config.service_option,"},{"line_number":35,"context_line":"                            group\u003d\u0027service_available\u0027)"},{"line_number":36,"context_line":"        config.register_opt_group(conf, project_config.baremetal_group,"},{"line_number":37,"context_line":"                                  project_config.BaremetalGroup)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_4cbe76d5","line":35,"range":{"start_line":34,"start_character":8,"end_line":35,"end_character":54},"in_reply_to":"5a74a57a_6ec08fe1","updated":"2016-11-30 12:25:49.000000000","message":"Good catch, thanks!","commit_id":"2ef6c9e5fbe40c9168756607bad4b81bde7d3fc5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"78d81ac3c3e1c1ac43d483739d02195e6040b211","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        return full_test_dir, base_path"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def register_opts(self, conf):"},{"line_number":34,"context_line":"        config.register_opt(config.service_option,"},{"line_number":35,"context_line":"                            group\u003d\u0027service_available\u0027)"},{"line_number":36,"context_line":"        config.register_opt_group(conf, project_config.baremetal_group,"},{"line_number":37,"context_line":"                                  project_config.BaremetalGroup)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_6ec08fe1","line":35,"range":{"start_line":34,"start_character":8,"end_line":35,"end_character":54},"in_reply_to":"5a74a57a_ffe61343","updated":"2016-11-30 10:16:02.000000000","message":"++","commit_id":"2ef6c9e5fbe40c9168756607bad4b81bde7d3fc5"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c9f35025583b60ade139207fa66ecb311d11738f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        return full_test_dir, base_path"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def register_opts(self, conf):"},{"line_number":34,"context_line":"        config.register_opt(project_config.service_option,"},{"line_number":35,"context_line":"                            group\u003d\u0027service_available\u0027)"},{"line_number":36,"context_line":"        config.register_opt_group(conf, project_config.baremetal_group,"},{"line_number":37,"context_line":"                                  project_config.BaremetalGroup)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_1cdae778","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":14},"updated":"2016-11-30 15:00:20.000000000","message":"s/config/conf","commit_id":"b566692564a640bcafdb423c597f4a6f06813ba0"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"37e677c1d0335df92d9d08b64ef7127aa3cc26ec","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        return full_test_dir, base_path"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def register_opts(self, conf):"},{"line_number":34,"context_line":"        config.register_opt(project_config.service_option,"},{"line_number":35,"context_line":"                            group\u003d\u0027service_available\u0027)"},{"line_number":36,"context_line":"        config.register_opt_group(conf, project_config.baremetal_group,"},{"line_number":37,"context_line":"                                  project_config.BaremetalGroup)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_5c70ccdc","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":14},"in_reply_to":"5a74a57a_1cdae778","updated":"2016-11-30 21:13:53.000000000","message":"Wow, I\u0027m an idiot, thanks","commit_id":"b566692564a640bcafdb423c597f4a6f06813ba0"}],"ironic_tempest_plugin/tests/scenario/baremetal_manager.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"4005f608537a0e0c698c20fd068373e6117ff7cd","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    @classmethod"},{"line_number":59,"context_line":"    def skip_checks(cls):"},{"line_number":60,"context_line":"        super(BaremetalScenarioTest, cls).skip_checks()"},{"line_number":61,"context_line":"        if CONF.network_feature_enabled.port_admin_state_change:"},{"line_number":62,"context_line":"            msg \u003d \"Port state change feature isn\u0027t supported by Ironic.\""},{"line_number":63,"context_line":"            raise cls.skipException(msg)"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_dcd96585","side":"PARENT","line":61,"updated":"2016-11-30 08:36:22.000000000","message":"please remove devstack part also: https://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L1626\n\nAlso please left here skip check if service_available.ironic\u003d\u003dFalse.","commit_id":"0bb8423bf38e194eb9e9e8e4fb6ee6d15a25e50b"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"5b3a16c56aa066180ff9fa426eafcffb2b646426","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    @classmethod"},{"line_number":59,"context_line":"    def skip_checks(cls):"},{"line_number":60,"context_line":"        super(BaremetalScenarioTest, cls).skip_checks()"},{"line_number":61,"context_line":"        if CONF.network_feature_enabled.port_admin_state_change:"},{"line_number":62,"context_line":"            msg \u003d \"Port state change feature isn\u0027t supported by Ironic.\""},{"line_number":63,"context_line":"            raise cls.skipException(msg)"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a74a57a_6cb5f27c","side":"PARENT","line":61,"in_reply_to":"5a74a57a_dcd96585","updated":"2016-11-30 12:39:26.000000000","message":"++ done","commit_id":"0bb8423bf38e194eb9e9e8e4fb6ee6d15a25e50b"},{"author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"change_message_id":"14903868248078f85d5e31794e679e479836a3bd","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @classmethod"},{"line_number":59,"context_line":"    def skip_checks(cls):"},{"line_number":60,"context_line":"        super(BaremetalScenarioTest, cls).skip_checks()"},{"line_number":61,"context_line":"        if not CONF.service_available.ironic:"},{"line_number":62,"context_line":"            raise cls.skipException(\u0027Ironic is not enabled.\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @classmethod"},{"line_number":65,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_56e4403a","line":62,"range":{"start_line":60,"start_character":0,"end_line":62,"end_character":61},"updated":"2016-11-30 14:27:55.000000000","message":"With default False, I\u0027d expect it will \"break\" inspector grenade, skip inspector test as it was with CONF.port_admin_state_change before.","commit_id":"b566692564a640bcafdb423c597f4a6f06813ba0"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c9f35025583b60ade139207fa66ecb311d11738f","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @classmethod"},{"line_number":59,"context_line":"    def skip_checks(cls):"},{"line_number":60,"context_line":"        super(BaremetalScenarioTest, cls).skip_checks()"},{"line_number":61,"context_line":"        if not CONF.service_available.ironic:"},{"line_number":62,"context_line":"            raise cls.skipException(\u0027Ironic is not enabled.\u0027)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @classmethod"},{"line_number":65,"context_line":"    def setup_clients(cls):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_9ced1728","line":62,"range":{"start_line":60,"start_character":0,"end_line":62,"end_character":61},"in_reply_to":"5a74a57a_56e4403a","updated":"2016-11-30 15:00:20.000000000","message":"It shouldn\u0027t inspector is installed with ironic, and service_available.ironic will be set to True by ironic\u0027s devstack plugin.","commit_id":"b566692564a640bcafdb423c597f4a6f06813ba0"}]}