)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"62482806cfc2cdeefffabb43fbb55209afafd7f1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Allow using resource classes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds a variable IRONIC_USE_RESOURCE_CLASSES, which defaults to False. If"},{"line_number":10,"context_line":"true, it will set a resource_class for each node, configure the"},{"line_number":11,"context_line":"baremetal flavor in nova to use it, and adjust the hypervisor-stats to"},{"line_number":12,"context_line":"use the placement engine instead."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I785264eae0dc8ebe29f58a9e73f33000ae70ebb1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3a461143_6e7c8bec","line":11,"range":{"start_line":10,"start_character":50,"end_line":11,"end_character":34},"updated":"2017-01-31 07:40:31.000000000","message":"The flavor is not configured to use resource classes it is only  a todo right?","commit_id":"867f2f52574e3c35d75037426223a71ec1f93562"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a9bf98e5a0a6503688ced7e773a14ea7ca6ca0ab","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Allow using resource classes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds a variable IRONIC_USE_RESOURCE_CLASSES, which defaults to False. If"},{"line_number":10,"context_line":"true, it will set a resource_class for each node, configure the"},{"line_number":11,"context_line":"baremetal flavor in nova to use it, and adjust the hypervisor-stats to"},{"line_number":12,"context_line":"use the placement engine instead."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I785264eae0dc8ebe29f58a9e73f33000ae70ebb1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3a461143_5a3a1be8","line":11,"range":{"start_line":10,"start_character":50,"end_line":11,"end_character":34},"in_reply_to":"3a461143_6e7c8bec","updated":"2017-01-31 13:47:35.000000000","message":"++ I\u0027m okay with todos, although they make the commit message misleading.","commit_id":"867f2f52574e3c35d75037426223a71ec1f93562"}],"devstack/lib/ironic":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a99de4d2c817530fc5c2cc5169d85dd3634123f8","unresolved":false,"context_lines":[{"line_number":1341,"context_line":"            --chassis_uuid $chassis_id \\"},{"line_number":1342,"context_line":"            --driver $IRONIC_DEPLOY_DRIVER \\"},{"line_number":1343,"context_line":"            --name $node_prefix-$total_nodes \\"},{"line_number":1344,"context_line":"            --resource-class $resource_class \\"},{"line_number":1345,"context_line":"            -p cpus\u003d$ironic_node_cpu\\"},{"line_number":1346,"context_line":"            -p memory_mb\u003d$ironic_node_ram\\"},{"line_number":1347,"context_line":"            -p local_gb\u003d$ironic_node_disk\\"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3a71b18c_e4708642","line":1344,"updated":"2016-12-06 21:23:48.000000000","message":"this will fail if resource_class is \"\".\n\nstack@jayf-devstack:~$ ironic node-create --ironic-api-version 1.21 --resource-class -p foo\u003dbar\nusage: ironic node-create [-c \u003cchassis\u003e] -d \u003cdriver\u003e [-i \u003ckey\u003dvalue\u003e]\n                          [-p \u003ckey\u003dvalue\u003e] [-e \u003ckey\u003dvalue\u003e] [-u \u003cuuid\u003e]\n                          [-n \u003cname\u003e]\n                          [--network-interface \u003cnetwork_interface\u003e]\n                          [--resource-class \u003cresource_class\u003e]","commit_id":"c7b9171f95f2b26d2b74e89696d130e28acb5d50"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bc1af400c0ba35ad81460798349eeed30cf10e83","unresolved":false,"context_lines":[{"line_number":1336,"context_line":"        fi"},{"line_number":1337,"context_line":""},{"line_number":1338,"context_line":"        local node_id"},{"line_number":1339,"context_line":"        node_id\u003d$(ironic --ironic-api-version 1.21 \\"},{"line_number":1340,"context_line":"            node-create $standalone_node_uuid \\"},{"line_number":1341,"context_line":"            --chassis_uuid $chassis_id \\"},{"line_number":1342,"context_line":"            --driver $IRONIC_DEPLOY_DRIVER \\"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5a3905b3_9dedcf27","line":1339,"updated":"2017-01-20 14:50:40.000000000","message":"With this, nodes are going to be created in enroll state. Will need to enroll-\u003emanageable-\u003eavailable. And move network interface setting here from L1366-1372. Or do the same thing with resource class as we do for net interface to avoid changing api version","commit_id":"8adabab0a69b1f034973bb538d590243bb04f9d4"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"e63da486c6f2bf301a7d45d5f22846b4d80b6275","unresolved":false,"context_lines":[{"line_number":1336,"context_line":"        fi"},{"line_number":1337,"context_line":""},{"line_number":1338,"context_line":"        local node_id"},{"line_number":1339,"context_line":"        node_id\u003d$(ironic --ironic-api-version 1.21 \\"},{"line_number":1340,"context_line":"            node-create $standalone_node_uuid \\"},{"line_number":1341,"context_line":"            --chassis_uuid $chassis_id \\"},{"line_number":1342,"context_line":"            --driver $IRONIC_DEPLOY_DRIVER \\"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5a3905b3_b9d9a885","line":1339,"in_reply_to":"5a3905b3_9dedcf27","updated":"2017-01-20 22:58:28.000000000","message":"it may be better to keep this as a variable somewhere, too (... $ironic_api_version), in case we need to bump this again later","commit_id":"8adabab0a69b1f034973bb538d590243bb04f9d4"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"c27f75388e4371c7769b6e5eb6e7af156b94aa3f","unresolved":false,"context_lines":[{"line_number":1336,"context_line":"        fi"},{"line_number":1337,"context_line":""},{"line_number":1338,"context_line":"        local node_id"},{"line_number":1339,"context_line":"        node_id\u003d$(ironic --ironic-api-version 1.21 \\"},{"line_number":1340,"context_line":"            node-create $standalone_node_uuid \\"},{"line_number":1341,"context_line":"            --chassis_uuid $chassis_id \\"},{"line_number":1342,"context_line":"            --driver $IRONIC_DEPLOY_DRIVER \\"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5a3905b3_e7efc784","line":1339,"in_reply_to":"5a3905b3_b9d9a885","updated":"2017-01-23 15:52:46.000000000","message":"vdrok, good point. Thanks. Might as well eat the pain and do it now.\n\nMario, idk, it might be a refactor, I\u0027ll leave it for later.","commit_id":"8adabab0a69b1f034973bb538d590243bb04f9d4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"3e5199ced5e8244712a12cb5227eb6934cd8a9e8","unresolved":false,"context_lines":[{"line_number":1341,"context_line":"            --chassis_uuid $chassis_id \\"},{"line_number":1342,"context_line":"            --driver $IRONIC_DEPLOY_DRIVER \\"},{"line_number":1343,"context_line":"            --name $node_prefix-$total_nodes \\"},{"line_number":1344,"context_line":"            $resource_class \\"},{"line_number":1345,"context_line":"            -p cpus\u003d$ironic_node_cpu\\"},{"line_number":1346,"context_line":"            -p memory_mb\u003d$ironic_node_ram\\"},{"line_number":1347,"context_line":"            -p local_gb\u003d$ironic_node_disk\\"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5a3905b3_ddaf5792","line":1344,"updated":"2017-01-20 14:52:07.000000000","message":"--resource-class $resource_class ? :)","commit_id":"8adabab0a69b1f034973bb538d590243bb04f9d4"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"c27f75388e4371c7769b6e5eb6e7af156b94aa3f","unresolved":false,"context_lines":[{"line_number":1341,"context_line":"            --chassis_uuid $chassis_id \\"},{"line_number":1342,"context_line":"            --driver $IRONIC_DEPLOY_DRIVER \\"},{"line_number":1343,"context_line":"            --name $node_prefix-$total_nodes \\"},{"line_number":1344,"context_line":"            $resource_class \\"},{"line_number":1345,"context_line":"            -p cpus\u003d$ironic_node_cpu\\"},{"line_number":1346,"context_line":"            -p memory_mb\u003d$ironic_node_ram\\"},{"line_number":1347,"context_line":"            -p local_gb\u003d$ironic_node_disk\\"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5a3905b3_6704b749","line":1344,"in_reply_to":"5a3905b3_3d785b2a","updated":"2017-01-23 15:52:46.000000000","message":":)","commit_id":"8adabab0a69b1f034973bb538d590243bb04f9d4"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bcdbf7a244db6ac5dd38de0fd022a4799f15ec80","unresolved":false,"context_lines":[{"line_number":1341,"context_line":"            --chassis_uuid $chassis_id \\"},{"line_number":1342,"context_line":"            --driver $IRONIC_DEPLOY_DRIVER \\"},{"line_number":1343,"context_line":"            --name $node_prefix-$total_nodes \\"},{"line_number":1344,"context_line":"            $resource_class \\"},{"line_number":1345,"context_line":"            -p cpus\u003d$ironic_node_cpu\\"},{"line_number":1346,"context_line":"            -p memory_mb\u003d$ironic_node_ram\\"},{"line_number":1347,"context_line":"            -p local_gb\u003d$ironic_node_disk\\"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5a3905b3_3d785b2a","line":1344,"in_reply_to":"5a3905b3_ddaf5792","updated":"2017-01-20 14:52:44.000000000","message":"Ah, it\u0027s already there, sorry","commit_id":"8adabab0a69b1f034973bb538d590243bb04f9d4"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"7afdba6e686211d9c9a23b789479b592f96d97ad","unresolved":false,"context_lines":[{"line_number":1540,"context_line":"        ironic $ironic_api_version port-create --address $mac_address --node $node_id $llc_opts"},{"line_number":1541,"context_line":""},{"line_number":1542,"context_line":"        # get things from enroll -\u003e available"},{"line_number":1543,"context_line":"        ironic node-set-provision-state $node_id manage --wait 60"},{"line_number":1544,"context_line":"        ironic node-set-provision-state $node_id provide --wait 600"},{"line_number":1545,"context_line":""},{"line_number":1546,"context_line":"        total_nodes\u003d$((total_nodes+1))"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"5a3905b3_bf658845","line":1543,"updated":"2017-01-24 16:46:13.000000000","message":"I would add here a big TODO to disable automated cleaning for all jobs, and test it on demand only.\n\nPlease use tempest timeout instead of hardcode.","commit_id":"acaffac37a75f6425dd088809e5811403cddc5de"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"7afdba6e686211d9c9a23b789479b592f96d97ad","unresolved":false,"context_lines":[{"line_number":1541,"context_line":""},{"line_number":1542,"context_line":"        # get things from enroll -\u003e available"},{"line_number":1543,"context_line":"        ironic node-set-provision-state $node_id manage --wait 60"},{"line_number":1544,"context_line":"        ironic node-set-provision-state $node_id provide --wait 600"},{"line_number":1545,"context_line":""},{"line_number":1546,"context_line":"        total_nodes\u003d$((total_nodes+1))"},{"line_number":1547,"context_line":"        total_cpus\u003d$((total_cpus+$ironic_node_cpu))"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"5a3905b3_7a2ece8c","line":1544,"updated":"2017-01-24 16:46:13.000000000","message":"ditto.","commit_id":"acaffac37a75f6425dd088809e5811403cddc5de"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"c6e59dcca5ef563eee9720323eb4aec660d3c55d","unresolved":false,"context_lines":[{"line_number":1541,"context_line":""},{"line_number":1542,"context_line":"        # get things from enroll -\u003e available"},{"line_number":1543,"context_line":"        ironic node-set-provision-state $node_id manage --wait 60"},{"line_number":1544,"context_line":"        ironic node-set-provision-state $node_id provide --wait 600"},{"line_number":1545,"context_line":""},{"line_number":1546,"context_line":"        total_nodes\u003d$((total_nodes+1))"},{"line_number":1547,"context_line":"        total_cpus\u003d$((total_cpus+$ironic_node_cpu))"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"5a3905b3_b050560c","line":1544,"in_reply_to":"5a3905b3_7a2ece8c","updated":"2017-01-24 17:36:17.000000000","message":"It is overkill for multinode and grenade where we have 7 Vms, we will spent more than 1h just waiting for devstack.","commit_id":"acaffac37a75f6425dd088809e5811403cddc5de"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"4eaa104d6a18129e8575c07ac571ee9c1160c409","unresolved":false,"context_lines":[{"line_number":1541,"context_line":""},{"line_number":1542,"context_line":"        # get things from enroll -\u003e available"},{"line_number":1543,"context_line":"        ironic node-set-provision-state $node_id manage --wait 60"},{"line_number":1544,"context_line":"        ironic node-set-provision-state $node_id provide --wait 600"},{"line_number":1545,"context_line":""},{"line_number":1546,"context_line":"        total_nodes\u003d$((total_nodes+1))"},{"line_number":1547,"context_line":"        total_cpus\u003d$((total_cpus+$ironic_node_cpu))"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"3a461143_bd143d44","line":1544,"in_reply_to":"5a3905b3_b050560c","updated":"2017-01-27 14:44:52.000000000","message":"Good point. I\u0027ll hack it for now with a node-update and come back later.","commit_id":"acaffac37a75f6425dd088809e5811403cddc5de"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b0b7360e2e36fd0e8e1eebff330043536f27bb65","unresolved":false,"context_lines":[{"line_number":1327,"context_line":"        fi"},{"line_number":1328,"context_line":""},{"line_number":1329,"context_line":"        local node_id"},{"line_number":1330,"context_line":"        node_id\u003d$(ironic --ironic-api-version 1.21 \\"},{"line_number":1331,"context_line":"            node-create $standalone_node_uuid \\"},{"line_number":1332,"context_line":"            --chassis_uuid $chassis_id \\"},{"line_number":1333,"context_line":"            --driver $IRONIC_DEPLOY_DRIVER \\"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"3a461143_2be1dcd0","line":1330,"updated":"2017-01-27 20:09:29.000000000","message":"due to api version 1.21 node added in enroll state.","commit_id":"43b9486720e451955e70cede11231f43e8c7368b"}]}
