)]}'
{"doc/source/admin/drivers/ilo.rst":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6ce7dfd4a7f87448a1d92e9f9066148418bc442c","unresolved":false,"context_lines":[{"line_number":825,"context_line":"  ``erase_devices``:"},{"line_number":826,"context_line":"    A inband cleaning step which performs disk erase on all the disks inclusive"},{"line_number":827,"context_line":"    of the disks visible to OS as well as the raw disks visible to Smart"},{"line_number":828,"context_line":"    Storage Administrator(SSA) available in HPE Proliant servers. This step"},{"line_number":829,"context_line":"    adds support to perform erase on the raw disks visible to SSA in"},{"line_number":830,"context_line":"    Proliant servers only with the ramdisk created using diskimage-builder"},{"line_number":831,"context_line":"    from Ocata release. By default, this step is disabled. See"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3f1d235d_4336cde9","line":828,"range":{"start_line":828,"start_character":31,"end_line":828,"end_character":64},"updated":"2017-07-11 03:30:13.000000000","message":"s/ \u0027 available in HPE Proliant servers\u0027 //","commit_id":"ed44a0ca966779fd65b8c276dfc502839833d662"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"c662cbdd247c74129963d1230fd8aa9b925a590f","unresolved":false,"context_lines":[{"line_number":825,"context_line":"  ``erase_devices``:"},{"line_number":826,"context_line":"    A inband cleaning step which performs disk erase on all the disks inclusive"},{"line_number":827,"context_line":"    of the disks visible to OS as well as the raw disks visible to Smart"},{"line_number":828,"context_line":"    Storage Administrator(SSA) available in HPE Proliant servers. This step"},{"line_number":829,"context_line":"    adds support to perform erase on the raw disks visible to SSA in"},{"line_number":830,"context_line":"    Proliant servers only with the ramdisk created using diskimage-builder"},{"line_number":831,"context_line":"    from Ocata release. By default, this step is disabled. See"}],"source_content_type":"text/x-rst","patch_set":17,"id":"3f1d235d_83a056a7","line":828,"range":{"start_line":828,"start_character":31,"end_line":828,"end_character":64},"in_reply_to":"3f1d235d_4336cde9","updated":"2017-07-11 11:50:55.000000000","message":"Done","commit_id":"ed44a0ca966779fd65b8c276dfc502839833d662"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6ce7dfd4a7f87448a1d92e9f9066148418bc442c","unresolved":false,"context_lines":[{"line_number":826,"context_line":"    A inband cleaning step which performs disk erase on all the disks inclusive"},{"line_number":827,"context_line":"    of the disks visible to OS as well as the raw disks visible to Smart"},{"line_number":828,"context_line":"    Storage Administrator(SSA) available in HPE Proliant servers. This step"},{"line_number":829,"context_line":"    adds support to perform erase on the raw disks visible to SSA in"},{"line_number":830,"context_line":"    Proliant servers only with the ramdisk created using diskimage-builder"},{"line_number":831,"context_line":"    from Ocata release. By default, this step is disabled. See"},{"line_number":832,"context_line":"    `Disk Erase Support`_."}],"source_content_type":"text/x-rst","patch_set":17,"id":"3f1d235d_234ab154","line":829,"range":{"start_line":829,"start_character":4,"end_line":829,"end_character":28},"updated":"2017-07-11 03:30:13.000000000","message":"s/ \u0027adds support to perform \u0027 / \u0027supports\u0027 /","commit_id":"ed44a0ca966779fd65b8c276dfc502839833d662"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"c662cbdd247c74129963d1230fd8aa9b925a590f","unresolved":false,"context_lines":[{"line_number":826,"context_line":"    A inband cleaning step which performs disk erase on all the disks inclusive"},{"line_number":827,"context_line":"    of the disks visible to OS as well as the raw disks visible to Smart"},{"line_number":828,"context_line":"    Storage Administrator(SSA) available in HPE Proliant servers. This step"},{"line_number":829,"context_line":"    adds support to perform erase on the raw disks visible to SSA in"},{"line_number":830,"context_line":"    Proliant servers only with the ramdisk created using diskimage-builder"},{"line_number":831,"context_line":"    from Ocata release. By default, this step is disabled. See"},{"line_number":832,"context_line":"    `Disk Erase Support`_."}],"source_content_type":"text/x-rst","patch_set":17,"id":"3f1d235d_63a3fab2","line":829,"range":{"start_line":829,"start_character":4,"end_line":829,"end_character":28},"in_reply_to":"3f1d235d_234ab154","updated":"2017-07-11 11:50:55.000000000","message":"Done","commit_id":"ed44a0ca966779fd65b8c276dfc502839833d662"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6ce7dfd4a7f87448a1d92e9f9066148418bc442c","unresolved":false,"context_lines":[{"line_number":829,"context_line":"    adds support to perform erase on the raw disks visible to SSA in"},{"line_number":830,"context_line":"    Proliant servers only with the ramdisk created using diskimage-builder"},{"line_number":831,"context_line":"    from Ocata release. By default, this step is disabled. See"},{"line_number":832,"context_line":"    `Disk Erase Support`_."},{"line_number":833,"context_line":""},{"line_number":834,"context_line":"* For in-band cleaning operations supported by ``agent_ilo`` driver, see"},{"line_number":835,"context_line":"  :ref:`InbandvsOutOfBandCleaning`."}],"source_content_type":"text/x-rst","patch_set":17,"id":"3f1d235d_83a7450c","line":832,"range":{"start_line":832,"start_character":25,"end_line":832,"end_character":26},"updated":"2017-07-11 03:30:13.000000000","message":"s// \u0027for more details.\u0027/","commit_id":"ed44a0ca966779fd65b8c276dfc502839833d662"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"c662cbdd247c74129963d1230fd8aa9b925a590f","unresolved":false,"context_lines":[{"line_number":829,"context_line":"    adds support to perform erase on the raw disks visible to SSA in"},{"line_number":830,"context_line":"    Proliant servers only with the ramdisk created using diskimage-builder"},{"line_number":831,"context_line":"    from Ocata release. By default, this step is disabled. See"},{"line_number":832,"context_line":"    `Disk Erase Support`_."},{"line_number":833,"context_line":""},{"line_number":834,"context_line":"* For in-band cleaning operations supported by ``agent_ilo`` driver, see"},{"line_number":835,"context_line":"  :ref:`InbandvsOutOfBandCleaning`."}],"source_content_type":"text/x-rst","patch_set":17,"id":"3f1d235d_a3c35257","line":832,"range":{"start_line":832,"start_character":25,"end_line":832,"end_character":26},"in_reply_to":"3f1d235d_83a7450c","updated":"2017-07-11 11:50:55.000000000","message":"Done","commit_id":"ed44a0ca966779fd65b8c276dfc502839833d662"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"18d242741a666c0763f1f5b56043bb8e702b17fc","unresolved":false,"context_lines":[{"line_number":823,"context_line":"  ``reset_ilo``:"},{"line_number":824,"context_line":"    Resets the iLO. By default, this step is disabled."},{"line_number":825,"context_line":"  ``erase_devices``:"},{"line_number":826,"context_line":"    A inband cleaning step which performs disk erase on all the disks inclusive"},{"line_number":827,"context_line":"    of the disks visible to OS as well as the raw disks visible to Smart"},{"line_number":828,"context_line":"    Storage Administrator(SSA). This step supports erase on the raw disks"},{"line_number":829,"context_line":"    visible to SSA in Proliant servers only with the ramdisk created using"}],"source_content_type":"text/x-rst","patch_set":18,"id":"1f1a1f67_6f61c339","line":826,"updated":"2017-07-21 08:09:56.000000000","message":"\"An inband clean step that\", s/inclusive of/including/","commit_id":"716cfcf9307901951e286097eeccf00f91c08d11"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"a06f991d4e2158578570e4e8363cd2208e9d27ca","unresolved":false,"context_lines":[{"line_number":823,"context_line":"  ``reset_ilo``:"},{"line_number":824,"context_line":"    Resets the iLO. By default, this step is disabled."},{"line_number":825,"context_line":"  ``erase_devices``:"},{"line_number":826,"context_line":"    A inband cleaning step which performs disk erase on all the disks inclusive"},{"line_number":827,"context_line":"    of the disks visible to OS as well as the raw disks visible to Smart"},{"line_number":828,"context_line":"    Storage Administrator(SSA). This step supports erase on the raw disks"},{"line_number":829,"context_line":"    visible to SSA in Proliant servers only with the ramdisk created using"}],"source_content_type":"text/x-rst","patch_set":18,"id":"1f1a1f67_9249df61","line":826,"in_reply_to":"1f1a1f67_6f61c339","updated":"2017-07-21 11:03:21.000000000","message":"Done","commit_id":"716cfcf9307901951e286097eeccf00f91c08d11"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"18d242741a666c0763f1f5b56043bb8e702b17fc","unresolved":false,"context_lines":[{"line_number":825,"context_line":"  ``erase_devices``:"},{"line_number":826,"context_line":"    A inband cleaning step which performs disk erase on all the disks inclusive"},{"line_number":827,"context_line":"    of the disks visible to OS as well as the raw disks visible to Smart"},{"line_number":828,"context_line":"    Storage Administrator(SSA). This step supports erase on the raw disks"},{"line_number":829,"context_line":"    visible to SSA in Proliant servers only with the ramdisk created using"},{"line_number":830,"context_line":"    diskimage-builder from Ocata release. By default, this step is disabled."},{"line_number":831,"context_line":"    See `Disk Erase Support`_ for more details."}],"source_content_type":"text/x-rst","patch_set":18,"id":"1f1a1f67_4f660754","line":828,"updated":"2017-07-21 08:09:56.000000000","message":"nit: missing space before (\n\ns/erase on/erasing of/","commit_id":"716cfcf9307901951e286097eeccf00f91c08d11"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"a06f991d4e2158578570e4e8363cd2208e9d27ca","unresolved":false,"context_lines":[{"line_number":825,"context_line":"  ``erase_devices``:"},{"line_number":826,"context_line":"    A inband cleaning step which performs disk erase on all the disks inclusive"},{"line_number":827,"context_line":"    of the disks visible to OS as well as the raw disks visible to Smart"},{"line_number":828,"context_line":"    Storage Administrator(SSA). This step supports erase on the raw disks"},{"line_number":829,"context_line":"    visible to SSA in Proliant servers only with the ramdisk created using"},{"line_number":830,"context_line":"    diskimage-builder from Ocata release. By default, this step is disabled."},{"line_number":831,"context_line":"    See `Disk Erase Support`_ for more details."}],"source_content_type":"text/x-rst","patch_set":18,"id":"1f1a1f67_d23f57b3","line":828,"in_reply_to":"1f1a1f67_4f660754","updated":"2017-07-21 11:03:21.000000000","message":"Done","commit_id":"716cfcf9307901951e286097eeccf00f91c08d11"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"18d242741a666c0763f1f5b56043bb8e702b17fc","unresolved":false,"context_lines":[{"line_number":1603,"context_line":"Disk Erase Support"},{"line_number":1604,"context_line":"^^^^^^^^^^^^^^^^^^"},{"line_number":1605,"context_line":""},{"line_number":1606,"context_line":"The `erase_devices` is an inband clean step supported by iLO drives. It"},{"line_number":1607,"context_line":"performs erase on all the disks inclusive of the disks visible to OS as"},{"line_number":1608,"context_line":"well as the raw disks visible to the Smart Storage Administrator(SSA)."},{"line_number":1609,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"1f1a1f67_2f5bcb87","line":1606,"updated":"2017-07-21 08:09:56.000000000","message":"nit: s/The `erase_devices`/``erase_devices``/","commit_id":"716cfcf9307901951e286097eeccf00f91c08d11"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"a06f991d4e2158578570e4e8363cd2208e9d27ca","unresolved":false,"context_lines":[{"line_number":1603,"context_line":"Disk Erase Support"},{"line_number":1604,"context_line":"^^^^^^^^^^^^^^^^^^"},{"line_number":1605,"context_line":""},{"line_number":1606,"context_line":"The `erase_devices` is an inband clean step supported by iLO drives. It"},{"line_number":1607,"context_line":"performs erase on all the disks inclusive of the disks visible to OS as"},{"line_number":1608,"context_line":"well as the raw disks visible to the Smart Storage Administrator(SSA)."},{"line_number":1609,"context_line":""}],"source_content_type":"text/x-rst","patch_set":18,"id":"1f1a1f67_126f0fc6","line":1606,"in_reply_to":"1f1a1f67_2f5bcb87","updated":"2017-07-21 11:03:21.000000000","message":"Done","commit_id":"716cfcf9307901951e286097eeccf00f91c08d11"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"18d242741a666c0763f1f5b56043bb8e702b17fc","unresolved":false,"context_lines":[{"line_number":1605,"context_line":""},{"line_number":1606,"context_line":"The `erase_devices` is an inband clean step supported by iLO drives. It"},{"line_number":1607,"context_line":"performs erase on all the disks inclusive of the disks visible to OS as"},{"line_number":1608,"context_line":"well as the raw disks visible to the Smart Storage Administrator(SSA)."},{"line_number":1609,"context_line":""},{"line_number":1610,"context_line":"This inband clean step requires ``ssacli`` utility starting from version"},{"line_number":1611,"context_line":"``2.60-19.0`` to perform the erase on physical disks. See the"}],"source_content_type":"text/x-rst","patch_set":18,"id":"1f1a1f67_0f600f32","line":1608,"updated":"2017-07-21 08:09:56.000000000","message":"similar changes as on line 825","commit_id":"716cfcf9307901951e286097eeccf00f91c08d11"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"a06f991d4e2158578570e4e8363cd2208e9d27ca","unresolved":false,"context_lines":[{"line_number":1605,"context_line":""},{"line_number":1606,"context_line":"The `erase_devices` is an inband clean step supported by iLO drives. It"},{"line_number":1607,"context_line":"performs erase on all the disks inclusive of the disks visible to OS as"},{"line_number":1608,"context_line":"well as the raw disks visible to the Smart Storage Administrator(SSA)."},{"line_number":1609,"context_line":""},{"line_number":1610,"context_line":"This inband clean step requires ``ssacli`` utility starting from version"},{"line_number":1611,"context_line":"``2.60-19.0`` to perform the erase on physical disks. See the"}],"source_content_type":"text/x-rst","patch_set":18,"id":"1f1a1f67_725f630e","line":1608,"in_reply_to":"1f1a1f67_0f600f32","updated":"2017-07-21 11:03:21.000000000","message":"Done","commit_id":"716cfcf9307901951e286097eeccf00f91c08d11"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"18d242741a666c0763f1f5b56043bb8e702b17fc","unresolved":false,"context_lines":[{"line_number":1614,"context_line":""},{"line_number":1615,"context_line":"The disk erasure via ``shred`` is used to erase disks visible to the OS"},{"line_number":1616,"context_line":"and its implementation is available in Ironic Python Agent. The raw disks"},{"line_number":1617,"context_line":"connected to the Smart Storage Controller is erased using Sanitize erase"},{"line_number":1618,"context_line":"which is a ssacli supported erase method. If Sanitize erase is not supported"},{"line_number":1619,"context_line":"on the Smart Storage Controller the disks are erased using One-pass"},{"line_number":1620,"context_line":"erase(overwrite with zeros)."}],"source_content_type":"text/x-rst","patch_set":18,"id":"1f1a1f67_ef54b356","line":1617,"updated":"2017-07-21 08:09:56.000000000","message":"s/is/are/ (\"disks\" is plural)","commit_id":"716cfcf9307901951e286097eeccf00f91c08d11"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"a06f991d4e2158578570e4e8363cd2208e9d27ca","unresolved":false,"context_lines":[{"line_number":1614,"context_line":""},{"line_number":1615,"context_line":"The disk erasure via ``shred`` is used to erase disks visible to the OS"},{"line_number":1616,"context_line":"and its implementation is available in Ironic Python Agent. The raw disks"},{"line_number":1617,"context_line":"connected to the Smart Storage Controller is erased using Sanitize erase"},{"line_number":1618,"context_line":"which is a ssacli supported erase method. If Sanitize erase is not supported"},{"line_number":1619,"context_line":"on the Smart Storage Controller the disks are erased using One-pass"},{"line_number":1620,"context_line":"erase(overwrite with zeros)."}],"source_content_type":"text/x-rst","patch_set":18,"id":"1f1a1f67_92b79f3b","line":1617,"in_reply_to":"1f1a1f67_ef54b356","updated":"2017-07-21 11:03:21.000000000","message":"Done","commit_id":"716cfcf9307901951e286097eeccf00f91c08d11"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"18d242741a666c0763f1f5b56043bb8e702b17fc","unresolved":false,"context_lines":[{"line_number":1617,"context_line":"connected to the Smart Storage Controller is erased using Sanitize erase"},{"line_number":1618,"context_line":"which is a ssacli supported erase method. If Sanitize erase is not supported"},{"line_number":1619,"context_line":"on the Smart Storage Controller the disks are erased using One-pass"},{"line_number":1620,"context_line":"erase(overwrite with zeros)."},{"line_number":1621,"context_line":""},{"line_number":1622,"context_line":"This clean step is supported when the agent ramdisk contains the"},{"line_number":1623,"context_line":"``Proliant Hardware Manager`` from the proliantutils version 2.3.0 or higher."}],"source_content_type":"text/x-rst","patch_set":18,"id":"1f1a1f67_cf51f764","line":1620,"updated":"2017-07-21 08:09:56.000000000","message":"nit: missing space before (","commit_id":"716cfcf9307901951e286097eeccf00f91c08d11"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"a06f991d4e2158578570e4e8363cd2208e9d27ca","unresolved":false,"context_lines":[{"line_number":1617,"context_line":"connected to the Smart Storage Controller is erased using Sanitize erase"},{"line_number":1618,"context_line":"which is a ssacli supported erase method. If Sanitize erase is not supported"},{"line_number":1619,"context_line":"on the Smart Storage Controller the disks are erased using One-pass"},{"line_number":1620,"context_line":"erase(overwrite with zeros)."},{"line_number":1621,"context_line":""},{"line_number":1622,"context_line":"This clean step is supported when the agent ramdisk contains the"},{"line_number":1623,"context_line":"``Proliant Hardware Manager`` from the proliantutils version 2.3.0 or higher."}],"source_content_type":"text/x-rst","patch_set":18,"id":"1f1a1f67_72b40336","line":1620,"in_reply_to":"1f1a1f67_cf51f764","updated":"2017-07-21 11:03:21.000000000","message":"Done","commit_id":"716cfcf9307901951e286097eeccf00f91c08d11"}],"doc/source/drivers/ilo.rst":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a1ec47563083e47cdbf836517569e566aa3ef604","unresolved":false,"context_lines":[{"line_number":1585,"context_line":"performed as part of automated clean step. See :ref:`InbandvsOutOfBandCleaning`"},{"line_number":1586,"context_line":"for more information on enable/disable a clean step."},{"line_number":1587,"context_line":""},{"line_number":1588,"context_line":"The Sanitize disk erase step is supported only with the deployment ramdisk"},{"line_number":1589,"context_line":"built from latest ``diskimage-builder``. iLO drivers uses Proliant"},{"line_number":1590,"context_line":"HardwareManager to perform the Sanitize Erase on the disks. See"},{"line_number":1591,"context_line":":ref:`DIB_raid_support` for more information to create the agent ramdisk."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a3c09a3_2b1143ad","line":1588,"range":{"start_line":1588,"start_character":4,"end_line":1588,"end_character":23},"updated":"2017-01-13 09:35:42.000000000","message":"Need to elaborate on Sanitize disk erase. Need to elaborate that it is done using ssacli utility. Also can we add a link to documentation about the same.","commit_id":"e289fb0581a4a48f9fa91801ee10fb2da6e0151a"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"3d7b88f11fdadf6e3f4c35b38e4ff9ac72a6da24","unresolved":false,"context_lines":[{"line_number":1585,"context_line":"performed as part of automated clean step. See :ref:`InbandvsOutOfBandCleaning`"},{"line_number":1586,"context_line":"for more information on enable/disable a clean step."},{"line_number":1587,"context_line":""},{"line_number":1588,"context_line":"The Sanitize disk erase step is supported only with the deployment ramdisk"},{"line_number":1589,"context_line":"built from latest ``diskimage-builder``. iLO drivers uses Proliant"},{"line_number":1590,"context_line":"HardwareManager to perform the Sanitize Erase on the disks. See"},{"line_number":1591,"context_line":":ref:`DIB_raid_support` for more information to create the agent ramdisk."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a3c09a3_aa0dd838","line":1588,"range":{"start_line":1588,"start_character":4,"end_line":1588,"end_character":23},"in_reply_to":"7a3c09a3_2b1143ad","updated":"2017-01-16 13:08:47.000000000","message":"Done","commit_id":"e289fb0581a4a48f9fa91801ee10fb2da6e0151a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a1ec47563083e47cdbf836517569e566aa3ef604","unresolved":false,"context_lines":[{"line_number":1586,"context_line":"for more information on enable/disable a clean step."},{"line_number":1587,"context_line":""},{"line_number":1588,"context_line":"The Sanitize disk erase step is supported only with the deployment ramdisk"},{"line_number":1589,"context_line":"built from latest ``diskimage-builder``. iLO drivers uses Proliant"},{"line_number":1590,"context_line":"HardwareManager to perform the Sanitize Erase on the disks. See"},{"line_number":1591,"context_line":":ref:`DIB_raid_support` for more information to create the agent ramdisk."},{"line_number":1592,"context_line":"If the Sanitize Erase is not supported, then it falls back to the generic"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a3c09a3_abd8d31e","line":1589,"range":{"start_line":1589,"start_character":11,"end_line":1589,"end_character":17},"updated":"2017-01-13 09:35:42.000000000","message":"the latest looks vague and latest would chaneg with time. Can you please add more details on things required in DIB to perform this step.","commit_id":"e289fb0581a4a48f9fa91801ee10fb2da6e0151a"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"3d7b88f11fdadf6e3f4c35b38e4ff9ac72a6da24","unresolved":false,"context_lines":[{"line_number":1586,"context_line":"for more information on enable/disable a clean step."},{"line_number":1587,"context_line":""},{"line_number":1588,"context_line":"The Sanitize disk erase step is supported only with the deployment ramdisk"},{"line_number":1589,"context_line":"built from latest ``diskimage-builder``. iLO drivers uses Proliant"},{"line_number":1590,"context_line":"HardwareManager to perform the Sanitize Erase on the disks. See"},{"line_number":1591,"context_line":":ref:`DIB_raid_support` for more information to create the agent ramdisk."},{"line_number":1592,"context_line":"If the Sanitize Erase is not supported, then it falls back to the generic"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a3c09a3_ca14e445","line":1589,"range":{"start_line":1589,"start_character":11,"end_line":1589,"end_character":17},"in_reply_to":"7a3c09a3_abd8d31e","updated":"2017-01-16 13:08:47.000000000","message":"Done","commit_id":"e289fb0581a4a48f9fa91801ee10fb2da6e0151a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"a1ec47563083e47cdbf836517569e566aa3ef604","unresolved":false,"context_lines":[{"line_number":1589,"context_line":"built from latest ``diskimage-builder``. iLO drivers uses Proliant"},{"line_number":1590,"context_line":"HardwareManager to perform the Sanitize Erase on the disks. See"},{"line_number":1591,"context_line":":ref:`DIB_raid_support` for more information to create the agent ramdisk."},{"line_number":1592,"context_line":"If the Sanitize Erase is not supported, then it falls back to the generic"},{"line_number":1593,"context_line":"hardware manager."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a3c09a3_4b6daf31","line":1593,"range":{"start_line":1592,"start_character":0,"end_line":1593,"end_character":17},"updated":"2017-01-13 09:35:42.000000000","message":"Need to elaborate on \u0027generic hardware manager\u0027","commit_id":"e289fb0581a4a48f9fa91801ee10fb2da6e0151a"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"3d7b88f11fdadf6e3f4c35b38e4ff9ac72a6da24","unresolved":false,"context_lines":[{"line_number":1589,"context_line":"built from latest ``diskimage-builder``. iLO drivers uses Proliant"},{"line_number":1590,"context_line":"HardwareManager to perform the Sanitize Erase on the disks. See"},{"line_number":1591,"context_line":":ref:`DIB_raid_support` for more information to create the agent ramdisk."},{"line_number":1592,"context_line":"If the Sanitize Erase is not supported, then it falls back to the generic"},{"line_number":1593,"context_line":"hardware manager."}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a3c09a3_ea0fe02b","line":1593,"range":{"start_line":1592,"start_character":0,"end_line":1593,"end_character":17},"in_reply_to":"7a3c09a3_4b6daf31","updated":"2017-01-16 13:08:47.000000000","message":"Done","commit_id":"e289fb0581a4a48f9fa91801ee10fb2da6e0151a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a86dcf2dd56abb7691e859f24ef3bd231d13134c","unresolved":false,"context_lines":[{"line_number":824,"context_line":"    Resets the iLO. By default, this step is disabled."},{"line_number":825,"context_line":"  ``erase_devices``:"},{"line_number":826,"context_line":"    Performs Sanitize Erase on disks. This step is supported with the"},{"line_number":827,"context_line":"    ramdisk created using latest diskimage-builder. By default, this step is"},{"line_number":828,"context_line":"    disabled. See :ref:`Sanitize_disk_erase`."},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"* For in-band cleaning operations supported by ``agent_ilo`` driver, see"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a3c09a3_582febf5","line":827,"updated":"2017-01-16 14:39:47.000000000","message":"\"latest\" will change with time, please specify a version (feel free to use the one released)","commit_id":"1f43c437ea2d2977bfe2e20a3e7e6bbcbb4c065e"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"b3575695c67999322f9b82a67e6cb4ca2f9e06e0","unresolved":false,"context_lines":[{"line_number":824,"context_line":"    Resets the iLO. By default, this step is disabled."},{"line_number":825,"context_line":"  ``erase_devices``:"},{"line_number":826,"context_line":"    Performs Sanitize Erase on disks. This step is supported with the"},{"line_number":827,"context_line":"    ramdisk created using latest diskimage-builder. By default, this step is"},{"line_number":828,"context_line":"    disabled. See :ref:`Sanitize_disk_erase`."},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"* For in-band cleaning operations supported by ``agent_ilo`` driver, see"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a3c09a3_68010338","line":827,"in_reply_to":"7a3c09a3_582febf5","updated":"2017-01-17 12:20:35.000000000","message":"Done","commit_id":"1f43c437ea2d2977bfe2e20a3e7e6bbcbb4c065e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a86dcf2dd56abb7691e859f24ef3bd231d13134c","unresolved":false,"context_lines":[{"line_number":1576,"context_line":".. _`Enabling HTTPS in Swift`: http://docs.openstack.org/project-install-guide/baremetal/draft/enabling-https.html#enabling-https-in-swift"},{"line_number":1577,"context_line":".. _`Enabling HTTPS in Image service`: http://docs.openstack.org/project-install-guide/baremetal/draft/enabling-https.html#enabling-https-in-image-service"},{"line_number":1578,"context_line":""},{"line_number":1579,"context_line":".. _Sanitize_disk_erase:"},{"line_number":1580,"context_line":""},{"line_number":1581,"context_line":"Sanitize Disk Erase Support"},{"line_number":1582,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a3c09a3_78366753","line":1579,"updated":"2017-01-16 14:39:47.000000000","message":"you don\u0027t need to create an explicit link to titles in the same file. just use `Sanitize Disk Erase Support`_ to refer to it","commit_id":"1f43c437ea2d2977bfe2e20a3e7e6bbcbb4c065e"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"b3575695c67999322f9b82a67e6cb4ca2f9e06e0","unresolved":false,"context_lines":[{"line_number":1576,"context_line":".. _`Enabling HTTPS in Swift`: http://docs.openstack.org/project-install-guide/baremetal/draft/enabling-https.html#enabling-https-in-swift"},{"line_number":1577,"context_line":".. _`Enabling HTTPS in Image service`: http://docs.openstack.org/project-install-guide/baremetal/draft/enabling-https.html#enabling-https-in-image-service"},{"line_number":1578,"context_line":""},{"line_number":1579,"context_line":".. _Sanitize_disk_erase:"},{"line_number":1580,"context_line":""},{"line_number":1581,"context_line":"Sanitize Disk Erase Support"},{"line_number":1582,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a3c09a3_969d7bbe","line":1579,"in_reply_to":"7a3c09a3_78366753","updated":"2017-01-17 12:20:35.000000000","message":"Done","commit_id":"1f43c437ea2d2977bfe2e20a3e7e6bbcbb4c065e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a86dcf2dd56abb7691e859f24ef3bd231d13134c","unresolved":false,"context_lines":[{"line_number":1581,"context_line":"Sanitize Disk Erase Support"},{"line_number":1582,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":1583,"context_line":""},{"line_number":1584,"context_line":"The Sanitize disk erase is the inband clean step supported by iLO drives. This is"},{"line_number":1585,"context_line":"performed as part of automated clean step. See :ref:`InbandvsOutOfBandCleaning`"},{"line_number":1586,"context_line":"for more information on enable/disable a clean step."},{"line_number":1587,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a3c09a3_98395344","line":1584,"updated":"2017-01-16 14:39:47.000000000","message":"nit: low case sanitize","commit_id":"1f43c437ea2d2977bfe2e20a3e7e6bbcbb4c065e"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"b3575695c67999322f9b82a67e6cb4ca2f9e06e0","unresolved":false,"context_lines":[{"line_number":1581,"context_line":"Sanitize Disk Erase Support"},{"line_number":1582,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":1583,"context_line":""},{"line_number":1584,"context_line":"The Sanitize disk erase is the inband clean step supported by iLO drives. This is"},{"line_number":1585,"context_line":"performed as part of automated clean step. See :ref:`InbandvsOutOfBandCleaning`"},{"line_number":1586,"context_line":"for more information on enable/disable a clean step."},{"line_number":1587,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a3c09a3_f6f6bff7","line":1584,"in_reply_to":"7a3c09a3_98395344","updated":"2017-01-17 12:20:35.000000000","message":"Done","commit_id":"1f43c437ea2d2977bfe2e20a3e7e6bbcbb4c065e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a86dcf2dd56abb7691e859f24ef3bd231d13134c","unresolved":false,"context_lines":[{"line_number":1592,"context_line":"``diskimage-builder`` with the element ``proliant-tools`` which installs the"},{"line_number":1593,"context_line":"ssacli utility to the ramdisk. iLO drivers uses Proliant HardwareManager to"},{"line_number":1594,"context_line":"perform the Sanitize Erase on the disks. See :ref:`DIB_raid_support` for more"},{"line_number":1595,"context_line":"information to create the agent ramdisk."},{"line_number":1596,"context_line":""},{"line_number":1597,"context_line":"If the Sanitize Erase is not supported, then it falls backs to the ``erase_devices``"},{"line_number":1598,"context_line":"performed by generic hardware manager. See :ref:`InbandvsOutOfBandCleaning`"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a3c09a3_b840cfa6","line":1595,"updated":"2017-01-16 14:39:47.000000000","message":"I don\u0027t see this clean step in the list of clean steps in your hardware manager: https://github.com/openstack/proliantutils/blob/6ca31c0c9d9b69e38d560bb0bd5dede7330ad668/proliantutils/ipa_hw_manager/hardware_manager.py#L39-L44. Is is missing for some reason?\n\nalso, do we need to bump required proliantutils version?","commit_id":"1f43c437ea2d2977bfe2e20a3e7e6bbcbb4c065e"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"b3575695c67999322f9b82a67e6cb4ca2f9e06e0","unresolved":false,"context_lines":[{"line_number":1592,"context_line":"``diskimage-builder`` with the element ``proliant-tools`` which installs the"},{"line_number":1593,"context_line":"ssacli utility to the ramdisk. iLO drivers uses Proliant HardwareManager to"},{"line_number":1594,"context_line":"perform the Sanitize Erase on the disks. See :ref:`DIB_raid_support` for more"},{"line_number":1595,"context_line":"information to create the agent ramdisk."},{"line_number":1596,"context_line":""},{"line_number":1597,"context_line":"If the Sanitize Erase is not supported, then it falls backs to the ``erase_devices``"},{"line_number":1598,"context_line":"performed by generic hardware manager. See :ref:`InbandvsOutOfBandCleaning`"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a3c09a3_5675d32f","line":1595,"in_reply_to":"7a3c09a3_b840cfa6","updated":"2017-01-17 12:20:35.000000000","message":"I missed out to add the clean step to the list. The change has been merged now. Thank you for pointing it out.\n\u003ealso, do we need to bump required proliantutils version?\nYes, we have to change the required proliantutils version.","commit_id":"1f43c437ea2d2977bfe2e20a3e7e6bbcbb4c065e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"a86dcf2dd56abb7691e859f24ef3bd231d13134c","unresolved":false,"context_lines":[{"line_number":1596,"context_line":""},{"line_number":1597,"context_line":"If the Sanitize Erase is not supported, then it falls backs to the ``erase_devices``"},{"line_number":1598,"context_line":"performed by generic hardware manager. See :ref:`InbandvsOutOfBandCleaning`"},{"line_number":1599,"context_line":"for more information on ``erase_devices`` performed by generic hardware manager."},{"line_number":1600,"context_line":""},{"line_number":1601,"context_line":".. _`ssacli documentation`: http://h20566.www2.hpe.com/hpsc/doc/public/display?docId\u003dc03909334"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a3c09a3_d83bdb36","line":1599,"updated":"2017-01-16 14:39:47.000000000","message":"this link does not have \"more information\" on erase_devices right now.","commit_id":"1f43c437ea2d2977bfe2e20a3e7e6bbcbb4c065e"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"b3575695c67999322f9b82a67e6cb4ca2f9e06e0","unresolved":false,"context_lines":[{"line_number":1596,"context_line":""},{"line_number":1597,"context_line":"If the Sanitize Erase is not supported, then it falls backs to the ``erase_devices``"},{"line_number":1598,"context_line":"performed by generic hardware manager. See :ref:`InbandvsOutOfBandCleaning`"},{"line_number":1599,"context_line":"for more information on ``erase_devices`` performed by generic hardware manager."},{"line_number":1600,"context_line":""},{"line_number":1601,"context_line":".. _`ssacli documentation`: http://h20566.www2.hpe.com/hpsc/doc/public/display?docId\u003dc03909334"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a3c09a3_961adb7b","line":1599,"in_reply_to":"7a3c09a3_d83bdb36","updated":"2017-01-17 12:20:35.000000000","message":"added a brief description of ``erase_devices`` performed by generic hardware manager.","commit_id":"1f43c437ea2d2977bfe2e20a3e7e6bbcbb4c065e"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4700d34b9e45757079d48ba56eb315646bc586f7","unresolved":false,"context_lines":[{"line_number":824,"context_line":"    Resets the iLO. By default, this step is disabled."},{"line_number":825,"context_line":"  ``erase_devices``:"},{"line_number":826,"context_line":"    Performs Sanitize Erase on disks. This step is supported with the"},{"line_number":827,"context_line":"    ramdisk created using diskimage-builder version 1.26.1. By default,"},{"line_number":828,"context_line":"    this step is disabled. See `Sanitize Disk Erase Support`_."},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"* For in-band cleaning operations supported by ``agent_ilo`` driver, see"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a3905b3_ae6d0e9a","line":827,"range":{"start_line":827,"start_character":52,"end_line":827,"end_character":59},"updated":"2017-01-20 04:06:21.000000000","message":"1.26.1 and beyond.","commit_id":"dd1af6e92c424727059b313b2ab11a8265fa19f1"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"c37184df42a8faf0e2e95dcb7878f97fb1ca9913","unresolved":false,"context_lines":[{"line_number":824,"context_line":"    Resets the iLO. By default, this step is disabled."},{"line_number":825,"context_line":"  ``erase_devices``:"},{"line_number":826,"context_line":"    Performs Sanitize Erase on disks. This step is supported with the"},{"line_number":827,"context_line":"    ramdisk created using diskimage-builder version 1.26.1. By default,"},{"line_number":828,"context_line":"    this step is disabled. See `Sanitize Disk Erase Support`_."},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"* For in-band cleaning operations supported by ``agent_ilo`` driver, see"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a3905b3_4348afcc","line":827,"range":{"start_line":827,"start_character":52,"end_line":827,"end_character":59},"in_reply_to":"5a3905b3_ae6d0e9a","updated":"2017-01-23 04:23:26.000000000","message":"Done","commit_id":"dd1af6e92c424727059b313b2ab11a8265fa19f1"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4700d34b9e45757079d48ba56eb315646bc586f7","unresolved":false,"context_lines":[{"line_number":849,"context_line":"  - clean_priority_erase_devices\u003d0"},{"line_number":850,"context_line":""},{"line_number":851,"context_line":".. note::"},{"line_number":852,"context_line":"   This option [ilo]clean_priority_erase_devices deprecated for removal. This"},{"line_number":853,"context_line":"   configuration option is duplicated by [deploy]erase_devices_priority, use"},{"line_number":854,"context_line":"   that instead."},{"line_number":855,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a3905b3_ee2c764c","line":852,"range":{"start_line":852,"start_character":64,"end_line":852,"end_character":72},"updated":"2017-01-20 04:06:21.000000000","message":"for removal in Pike release.","commit_id":"dd1af6e92c424727059b313b2ab11a8265fa19f1"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"c37184df42a8faf0e2e95dcb7878f97fb1ca9913","unresolved":false,"context_lines":[{"line_number":849,"context_line":"  - clean_priority_erase_devices\u003d0"},{"line_number":850,"context_line":""},{"line_number":851,"context_line":".. note::"},{"line_number":852,"context_line":"   This option [ilo]clean_priority_erase_devices deprecated for removal. This"},{"line_number":853,"context_line":"   configuration option is duplicated by [deploy]erase_devices_priority, use"},{"line_number":854,"context_line":"   that instead."},{"line_number":855,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a3905b3_233f2325","line":852,"range":{"start_line":852,"start_character":64,"end_line":852,"end_character":72},"in_reply_to":"5a3905b3_ee2c764c","updated":"2017-01-23 04:23:26.000000000","message":"Done","commit_id":"dd1af6e92c424727059b313b2ab11a8265fa19f1"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4700d34b9e45757079d48ba56eb315646bc586f7","unresolved":false,"context_lines":[{"line_number":1596,"context_line":"disks. See :ref:`DIB_raid_support` for more information to create the agent ramdisk."},{"line_number":1597,"context_line":""},{"line_number":1598,"context_line":"If the Sanitize Erase is not supported, then it falls backs to the ``erase_devices``"},{"line_number":1599,"context_line":"performed by generic hardware manager. It first tries to perform ATA disk erase"},{"line_number":1600,"context_line":"by using ``hdparm`` utility.  If ATA disk erase is not supported, it performs"},{"line_number":1601,"context_line":"software based disk erase using ``shred`` utility."},{"line_number":1602,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a3905b3_eea1d6aa","line":1599,"range":{"start_line":1599,"start_character":0,"end_line":1599,"end_character":38},"updated":"2017-01-20 04:06:21.000000000","message":"s/ performed by generic hardware manager./ implementation available in Ironic Python Agent./","commit_id":"dd1af6e92c424727059b313b2ab11a8265fa19f1"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"c37184df42a8faf0e2e95dcb7878f97fb1ca9913","unresolved":false,"context_lines":[{"line_number":1596,"context_line":"disks. See :ref:`DIB_raid_support` for more information to create the agent ramdisk."},{"line_number":1597,"context_line":""},{"line_number":1598,"context_line":"If the Sanitize Erase is not supported, then it falls backs to the ``erase_devices``"},{"line_number":1599,"context_line":"performed by generic hardware manager. It first tries to perform ATA disk erase"},{"line_number":1600,"context_line":"by using ``hdparm`` utility.  If ATA disk erase is not supported, it performs"},{"line_number":1601,"context_line":"software based disk erase using ``shred`` utility."},{"line_number":1602,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a3905b3_034227ae","line":1599,"range":{"start_line":1599,"start_character":0,"end_line":1599,"end_character":38},"in_reply_to":"5a3905b3_eea1d6aa","updated":"2017-01-23 04:23:26.000000000","message":"Done","commit_id":"dd1af6e92c424727059b313b2ab11a8265fa19f1"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4700d34b9e45757079d48ba56eb315646bc586f7","unresolved":false,"context_lines":[{"line_number":1596,"context_line":"disks. See :ref:`DIB_raid_support` for more information to create the agent ramdisk."},{"line_number":1597,"context_line":""},{"line_number":1598,"context_line":"If the Sanitize Erase is not supported, then it falls backs to the ``erase_devices``"},{"line_number":1599,"context_line":"performed by generic hardware manager. It first tries to perform ATA disk erase"},{"line_number":1600,"context_line":"by using ``hdparm`` utility.  If ATA disk erase is not supported, it performs"},{"line_number":1601,"context_line":"software based disk erase using ``shred`` utility."},{"line_number":1602,"context_line":""},{"line_number":1603,"context_line":".. _`ssacli documentation`: http://h20566.www2.hpe.com/hpsc/doc/public/display?docId\u003dc03909334"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a3905b3_2ede7e3f","line":1601,"range":{"start_line":1599,"start_character":39,"end_line":1601,"end_character":50},"updated":"2017-01-20 04:06:21.000000000","message":"We may not need to explain generic implementation of disk erase here.","commit_id":"dd1af6e92c424727059b313b2ab11a8265fa19f1"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"c37184df42a8faf0e2e95dcb7878f97fb1ca9913","unresolved":false,"context_lines":[{"line_number":1596,"context_line":"disks. See :ref:`DIB_raid_support` for more information to create the agent ramdisk."},{"line_number":1597,"context_line":""},{"line_number":1598,"context_line":"If the Sanitize Erase is not supported, then it falls backs to the ``erase_devices``"},{"line_number":1599,"context_line":"performed by generic hardware manager. It first tries to perform ATA disk erase"},{"line_number":1600,"context_line":"by using ``hdparm`` utility.  If ATA disk erase is not supported, it performs"},{"line_number":1601,"context_line":"software based disk erase using ``shred`` utility."},{"line_number":1602,"context_line":""},{"line_number":1603,"context_line":".. _`ssacli documentation`: http://h20566.www2.hpe.com/hpsc/doc/public/display?docId\u003dc03909334"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5a3905b3_e338bb3f","line":1601,"range":{"start_line":1599,"start_character":39,"end_line":1601,"end_character":50},"in_reply_to":"5a3905b3_2ede7e3f","updated":"2017-01-23 04:23:26.000000000","message":"Done","commit_id":"dd1af6e92c424727059b313b2ab11a8265fa19f1"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"fa3efaaa0180654af1231905f8bf2e5e49ab2365","unresolved":false,"context_lines":[{"line_number":1579,"context_line":"Sanitize Disk Erase Support"},{"line_number":1580,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":1581,"context_line":""},{"line_number":1582,"context_line":"The sanitize disk erase is the inband clean step supported by iLO drives. This is"},{"line_number":1583,"context_line":"performed as part of automated clean step. See :ref:`InbandvsOutOfBandCleaning`"},{"line_number":1584,"context_line":"for more information on enable/disable a clean step."},{"line_number":1585,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a3905b3_daede6f0","line":1582,"updated":"2017-01-25 04:37:58.000000000","message":"Please add the proliantutils version which has this feature","commit_id":"56d485c40058aad2c3e4127935eeedd8684dee69"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"732f3529f102064b52b5728ba4b6ff6e973969a1","unresolved":false,"context_lines":[{"line_number":1579,"context_line":"Sanitize Disk Erase Support"},{"line_number":1580,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":1581,"context_line":""},{"line_number":1582,"context_line":"The sanitize disk erase is the inband clean step supported by iLO drives. This is"},{"line_number":1583,"context_line":"performed as part of automated clean step. See :ref:`InbandvsOutOfBandCleaning`"},{"line_number":1584,"context_line":"for more information on enable/disable a clean step."},{"line_number":1585,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"5a3905b3_3a9421e7","line":1582,"in_reply_to":"5a3905b3_daede6f0","updated":"2017-01-25 09:39:41.000000000","message":"Done","commit_id":"56d485c40058aad2c3e4127935eeedd8684dee69"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6c80f0977f63b909ee23b2508a2b2ff7066ac785","unresolved":false,"context_lines":[{"line_number":1595,"context_line":"    export DIB_SSACLI_URL\u003d\u0027https://downloads.hpe.com/pub/softlib2/software1/pubsw-linux/p1857046646/v123474/ssacli-2.60-19.0.x86_64.rpm\u0027"},{"line_number":1596,"context_line":""},{"line_number":1597,"context_line":"iLO drivers uses Proliant HardwareManager to perform the Sanitize Erase on the"},{"line_number":1598,"context_line":"disks. See :ref:`DIB_raid_support` for more information to create the agent ramdisk."},{"line_number":1599,"context_line":""},{"line_number":1600,"context_line":"If the Sanitize Erase is not supported, then it falls backs to the ``erase_devices``"},{"line_number":1601,"context_line":"implementation available in Ironic Python Agent."}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a461143_ba3974f4","line":1598,"range":{"start_line":1598,"start_character":7,"end_line":1598,"end_character":84},"updated":"2017-01-30 09:18:30.000000000","message":"May be you can add a command line of disk-image-builder command listing all the options to build the image above @ L1596\n$ disk-image-create -o proliant-agent-ramdisk ironic-agent fedora proliant-tools iso","commit_id":"5a3d04af56b78decff701fd894e6a7418188cdf6"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"a479b9f6ef97e8095a4be80489632053f27a18d0","unresolved":false,"context_lines":[{"line_number":1595,"context_line":"    export DIB_SSACLI_URL\u003d\u0027https://downloads.hpe.com/pub/softlib2/software1/pubsw-linux/p1857046646/v123474/ssacli-2.60-19.0.x86_64.rpm\u0027"},{"line_number":1596,"context_line":""},{"line_number":1597,"context_line":"iLO drivers uses Proliant HardwareManager to perform the Sanitize Erase on the"},{"line_number":1598,"context_line":"disks. See :ref:`DIB_raid_support` for more information to create the agent ramdisk."},{"line_number":1599,"context_line":""},{"line_number":1600,"context_line":"If the Sanitize Erase is not supported, then it falls backs to the ``erase_devices``"},{"line_number":1601,"context_line":"implementation available in Ironic Python Agent."}],"source_content_type":"text/x-rst","patch_set":6,"id":"3a461143_273c85c7","line":1598,"range":{"start_line":1598,"start_character":7,"end_line":1598,"end_character":84},"in_reply_to":"3a461143_ba3974f4","updated":"2017-01-30 13:26:53.000000000","message":"Done","commit_id":"5a3d04af56b78decff701fd894e6a7418188cdf6"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"2fe95c5f4d222921713a0d16ac0ea7af00484dcd","unresolved":false,"context_lines":[{"line_number":824,"context_line":"    Resets the iLO. By default, this step is disabled."},{"line_number":825,"context_line":"  ``erase_devices``:"},{"line_number":826,"context_line":"    Performs Sanitize Erase on disks. This step is supported with the"},{"line_number":827,"context_line":"    ramdisk created using diskimage-builder from Ocata release. By"},{"line_number":828,"context_line":"    default, this step is disabled. See `Sanitize Disk Erase Support`_."},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"* For in-band cleaning operations supported by ``agent_ilo`` driver, see"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a461143_87acf58d","line":827,"updated":"2017-02-01 17:13:03.000000000","message":"This isn\u0027t accurate. Disks can be erased using any Ramdisk, even if in-bank erase is used. Please clarify this document to specify that the HP-specific disk sanitation support is what\u0027s only supported in that Ramdisk.\n\nAlso, the diskimage-builder ram disks are not tested in CI, and I\u0027m not sure advertising them here is wise as a result of that.","commit_id":"71024c2c0f8250f37a818723ed958bce89236a86"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"bec6d9f8f810918cc25fea73f2f65a1b747e8765","unresolved":false,"context_lines":[{"line_number":824,"context_line":"    Resets the iLO. By default, this step is disabled."},{"line_number":825,"context_line":"  ``erase_devices``:"},{"line_number":826,"context_line":"    Performs Sanitize Erase on disks. This step is supported with the"},{"line_number":827,"context_line":"    ramdisk created using diskimage-builder from Ocata release. By"},{"line_number":828,"context_line":"    default, this step is disabled. See `Sanitize Disk Erase Support`_."},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"* For in-band cleaning operations supported by ``agent_ilo`` driver, see"}],"source_content_type":"text/x-rst","patch_set":7,"id":"3a461143_50647048","line":827,"in_reply_to":"3a461143_87acf58d","updated":"2017-02-02 06:07:12.000000000","message":"We have tested this feature internally. Also, we are going ahead with inclusion on adding this feature test in `HP Proliant CI`.","commit_id":"71024c2c0f8250f37a818723ed958bce89236a86"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"63c186564fac198c8b092b105b30f53d3ad1cf0d","unresolved":false,"context_lines":[{"line_number":832,"context_line":"  :ref:`InbandvsOutOfBandCleaning`."},{"line_number":833,"context_line":""},{"line_number":834,"context_line":"* All the automated cleaning steps have an explicit configuration option for"},{"line_number":835,"context_line":"  priority. IHPE n order to disable or change the priority of the automated clean"},{"line_number":836,"context_line":"  steps, respective configuration option for priority should be updated in"},{"line_number":837,"context_line":"  ironic.conf."},{"line_number":838,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a461143_3687dc13","line":835,"range":{"start_line":835,"start_character":12,"end_line":835,"end_character":18},"updated":"2017-02-02 07:40:23.000000000","message":"typo....","commit_id":"781fe38032021967b66a0eb80e5625cfa58654f5"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"cfa065961aafc1a79574a5b21b5e68c1633d4d94","unresolved":false,"context_lines":[{"line_number":832,"context_line":"  :ref:`InbandvsOutOfBandCleaning`."},{"line_number":833,"context_line":""},{"line_number":834,"context_line":"* All the automated cleaning steps have an explicit configuration option for"},{"line_number":835,"context_line":"  priority. IHPE n order to disable or change the priority of the automated clean"},{"line_number":836,"context_line":"  steps, respective configuration option for priority should be updated in"},{"line_number":837,"context_line":"  ironic.conf."},{"line_number":838,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"3a461143_965ed074","line":835,"range":{"start_line":835,"start_character":12,"end_line":835,"end_character":18},"in_reply_to":"3a461143_3687dc13","updated":"2017-02-02 07:44:13.000000000","message":"Done","commit_id":"781fe38032021967b66a0eb80e5625cfa58654f5"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"914a00455a5a51c56cacd5a291f696de282e4147","unresolved":false,"context_lines":[{"line_number":850,"context_line":"  - clean_priority_erase_devices\u003d0"},{"line_number":851,"context_line":""},{"line_number":852,"context_line":".. note::"},{"line_number":853,"context_line":"   This option [ilo]clean_priority_erase_devices deprecated for removal in Pike"},{"line_number":854,"context_line":"   release. This configuration option is duplicated by"},{"line_number":855,"context_line":"   [deploy]erase_devices_priority, use that instead."},{"line_number":856,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a430d35_2dcaed6d","line":853,"updated":"2017-02-06 14:44:14.000000000","message":"If possible, instruct users to use the right option right away, unless that option is not yet available (and it should be, otherwise it can\u0027t be deprecated).","commit_id":"428de608ae7978068b04e7a9ccbf067c980e8d42"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"f4398257742b4f738e7b2c6875405035cdade069","unresolved":false,"context_lines":[{"line_number":850,"context_line":"  - clean_priority_erase_devices\u003d0"},{"line_number":851,"context_line":""},{"line_number":852,"context_line":".. note::"},{"line_number":853,"context_line":"   This option [ilo]clean_priority_erase_devices deprecated for removal in Pike"},{"line_number":854,"context_line":"   release. This configuration option is duplicated by"},{"line_number":855,"context_line":"   [deploy]erase_devices_priority, use that instead."},{"line_number":856,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a430d35_8d35a1f8","line":853,"in_reply_to":"1a430d35_2dcaed6d","updated":"2017-02-06 15:35:17.000000000","message":"+1","commit_id":"428de608ae7978068b04e7a9ccbf067c980e8d42"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"43e52774b16bc70042b46b649541790ef5d70ce4","unresolved":false,"context_lines":[{"line_number":850,"context_line":"  - clean_priority_erase_devices\u003d0"},{"line_number":851,"context_line":""},{"line_number":852,"context_line":".. note::"},{"line_number":853,"context_line":"   This option [ilo]clean_priority_erase_devices deprecated for removal in Pike"},{"line_number":854,"context_line":"   release. This configuration option is duplicated by"},{"line_number":855,"context_line":"   [deploy]erase_devices_priority, use that instead."},{"line_number":856,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a430d35_db8e6378","line":853,"in_reply_to":"1a430d35_2dcaed6d","updated":"2017-02-07 05:55:04.000000000","message":"Done","commit_id":"428de608ae7978068b04e7a9ccbf067c980e8d42"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d5c6f9c520b52058ac9d72d0a975404368c55d90","unresolved":false,"context_lines":[{"line_number":852,"context_line":".. note::"},{"line_number":853,"context_line":"   This option [ilo]clean_priority_erase_devices deprecated for removal in Pike"},{"line_number":854,"context_line":"   release. This configuration option is duplicated by"},{"line_number":855,"context_line":"   [deploy]erase_devices_priority, use that instead."},{"line_number":856,"context_line":""},{"line_number":857,"context_line":"For more information on node automated cleaning, see :ref:`automated_cleaning`"},{"line_number":858,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a430d35_4a90ffec","line":855,"range":{"start_line":855,"start_character":34,"end_line":855,"end_character":35},"updated":"2017-02-06 14:35:45.000000000","message":"nit: s/use/please use/","commit_id":"428de608ae7978068b04e7a9ccbf067c980e8d42"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"43e52774b16bc70042b46b649541790ef5d70ce4","unresolved":false,"context_lines":[{"line_number":852,"context_line":".. note::"},{"line_number":853,"context_line":"   This option [ilo]clean_priority_erase_devices deprecated for removal in Pike"},{"line_number":854,"context_line":"   release. This configuration option is duplicated by"},{"line_number":855,"context_line":"   [deploy]erase_devices_priority, use that instead."},{"line_number":856,"context_line":""},{"line_number":857,"context_line":"For more information on node automated cleaning, see :ref:`automated_cleaning`"},{"line_number":858,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a430d35_1beb8b14","line":855,"range":{"start_line":855,"start_character":34,"end_line":855,"end_character":35},"in_reply_to":"1a430d35_4a90ffec","updated":"2017-02-07 05:55:04.000000000","message":"Removed.","commit_id":"428de608ae7978068b04e7a9ccbf067c980e8d42"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d5c6f9c520b52058ac9d72d0a975404368c55d90","unresolved":false,"context_lines":[{"line_number":1581,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":1582,"context_line":""},{"line_number":1583,"context_line":"The sanitize disk erase is the inband clean step supported by iLO drives. It"},{"line_number":1584,"context_line":"is supported from the proliantutils version 2.2.0 or higher. This is"},{"line_number":1585,"context_line":"performed as part of automated clean step. See :ref:`InbandvsOutOfBandCleaning`"},{"line_number":1586,"context_line":"for more information on enable/disable a clean step."},{"line_number":1587,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a430d35_6a4bfb87","line":1584,"range":{"start_line":1584,"start_character":22,"end_line":1584,"end_character":59},"updated":"2017-02-06 14:35:45.000000000","message":"This should explicitly call out that it is when the agent ramdisk contains the hardware manager from this version of proliantutils.","commit_id":"428de608ae7978068b04e7a9ccbf067c980e8d42"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"43e52774b16bc70042b46b649541790ef5d70ce4","unresolved":false,"context_lines":[{"line_number":1581,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":1582,"context_line":""},{"line_number":1583,"context_line":"The sanitize disk erase is the inband clean step supported by iLO drives. It"},{"line_number":1584,"context_line":"is supported from the proliantutils version 2.2.0 or higher. This is"},{"line_number":1585,"context_line":"performed as part of automated clean step. See :ref:`InbandvsOutOfBandCleaning`"},{"line_number":1586,"context_line":"for more information on enable/disable a clean step."},{"line_number":1587,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a430d35_9e56895a","line":1584,"range":{"start_line":1584,"start_character":22,"end_line":1584,"end_character":59},"in_reply_to":"1a430d35_6a4bfb87","updated":"2017-02-07 05:55:04.000000000","message":"Done","commit_id":"428de608ae7978068b04e7a9ccbf067c980e8d42"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d5c6f9c520b52058ac9d72d0a975404368c55d90","unresolved":false,"context_lines":[{"line_number":1588,"context_line":"This inband clean step uses ``ssacli`` utility starting from version ``2.60-19.0``"},{"line_number":1589,"context_line":"to perform the erase on physical disks. See the `ssacli documentation`_"},{"line_number":1590,"context_line":"for more information on ssacli utility. iLO drivers uses ``Proliant Hardware Manager``"},{"line_number":1591,"context_line":"to perform the Sanitize Erase on the disks. Follow the below steps to create the"},{"line_number":1592,"context_line":"supported deployment ramdisk using ``diskimage-builder``."},{"line_number":1593,"context_line":""},{"line_number":1594,"context_line":"* Set ``DIB_SSACLI_URL`` as environment variable to install ssacli utility,"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a430d35_aa45e370","line":1591,"range":{"start_line":1591,"start_character":55,"end_line":1591,"end_character":66},"updated":"2017-02-06 14:35:45.000000000","message":"Nit: I would flip the word order and say \"steps below\"","commit_id":"428de608ae7978068b04e7a9ccbf067c980e8d42"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"43e52774b16bc70042b46b649541790ef5d70ce4","unresolved":false,"context_lines":[{"line_number":1588,"context_line":"This inband clean step uses ``ssacli`` utility starting from version ``2.60-19.0``"},{"line_number":1589,"context_line":"to perform the erase on physical disks. See the `ssacli documentation`_"},{"line_number":1590,"context_line":"for more information on ssacli utility. iLO drivers uses ``Proliant Hardware Manager``"},{"line_number":1591,"context_line":"to perform the Sanitize Erase on the disks. Follow the below steps to create the"},{"line_number":1592,"context_line":"supported deployment ramdisk using ``diskimage-builder``."},{"line_number":1593,"context_line":""},{"line_number":1594,"context_line":"* Set ``DIB_SSACLI_URL`` as environment variable to install ssacli utility,"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a430d35_7ed47dbc","line":1591,"range":{"start_line":1591,"start_character":55,"end_line":1591,"end_character":66},"in_reply_to":"1a430d35_aa45e370","updated":"2017-02-07 05:55:04.000000000","message":"removed","commit_id":"428de608ae7978068b04e7a9ccbf067c980e8d42"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"914a00455a5a51c56cacd5a291f696de282e4147","unresolved":false,"context_lines":[{"line_number":1588,"context_line":"This inband clean step uses ``ssacli`` utility starting from version ``2.60-19.0``"},{"line_number":1589,"context_line":"to perform the erase on physical disks. See the `ssacli documentation`_"},{"line_number":1590,"context_line":"for more information on ssacli utility. iLO drivers uses ``Proliant Hardware Manager``"},{"line_number":1591,"context_line":"to perform the Sanitize Erase on the disks. Follow the below steps to create the"},{"line_number":1592,"context_line":"supported deployment ramdisk using ``diskimage-builder``."},{"line_number":1593,"context_line":""},{"line_number":1594,"context_line":"* Set ``DIB_SSACLI_URL`` as environment variable to install ssacli utility,"},{"line_number":1595,"context_line":"  if not ``DIB_SSACLI_URL`` takes the default url provided, during deploy"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a430d35_6d895526","line":1592,"range":{"start_line":1591,"start_character":44,"end_line":1592,"end_character":57},"updated":"2017-02-06 14:44:14.000000000","message":"I would simply link to DIB docs on how to build such a ramdisk.","commit_id":"428de608ae7978068b04e7a9ccbf067c980e8d42"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"43e52774b16bc70042b46b649541790ef5d70ce4","unresolved":false,"context_lines":[{"line_number":1588,"context_line":"This inband clean step uses ``ssacli`` utility starting from version ``2.60-19.0``"},{"line_number":1589,"context_line":"to perform the erase on physical disks. See the `ssacli documentation`_"},{"line_number":1590,"context_line":"for more information on ssacli utility. iLO drivers uses ``Proliant Hardware Manager``"},{"line_number":1591,"context_line":"to perform the Sanitize Erase on the disks. Follow the below steps to create the"},{"line_number":1592,"context_line":"supported deployment ramdisk using ``diskimage-builder``."},{"line_number":1593,"context_line":""},{"line_number":1594,"context_line":"* Set ``DIB_SSACLI_URL`` as environment variable to install ssacli utility,"},{"line_number":1595,"context_line":"  if not ``DIB_SSACLI_URL`` takes the default url provided, during deploy"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a430d35_9e0e8939","line":1592,"range":{"start_line":1591,"start_character":44,"end_line":1592,"end_character":57},"in_reply_to":"1a430d35_6d895526","updated":"2017-02-07 05:55:04.000000000","message":"Done","commit_id":"428de608ae7978068b04e7a9ccbf067c980e8d42"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d5c6f9c520b52058ac9d72d0a975404368c55d90","unresolved":false,"context_lines":[{"line_number":1591,"context_line":"to perform the Sanitize Erase on the disks. Follow the below steps to create the"},{"line_number":1592,"context_line":"supported deployment ramdisk using ``diskimage-builder``."},{"line_number":1593,"context_line":""},{"line_number":1594,"context_line":"* Set ``DIB_SSACLI_URL`` as environment variable to install ssacli utility,"},{"line_number":1595,"context_line":"  if not ``DIB_SSACLI_URL`` takes the default url provided, during deploy"},{"line_number":1596,"context_line":"  ramdisk creation. For example::"},{"line_number":1597,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a430d35_aa3c03e3","line":1594,"updated":"2017-02-06 14:35:45.000000000","message":"nit: The seems more like documentation that should be in the diskimage-builder element... Not requiring any sort of explicit change, but it does to be inviting out of date documentation very easily as diskimage-builder tracks master for releases.  i.e. This documentation could be out of date in two weeks, and we would be unable to fix it in the stable branch.","commit_id":"428de608ae7978068b04e7a9ccbf067c980e8d42"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"43e52774b16bc70042b46b649541790ef5d70ce4","unresolved":false,"context_lines":[{"line_number":1591,"context_line":"to perform the Sanitize Erase on the disks. Follow the below steps to create the"},{"line_number":1592,"context_line":"supported deployment ramdisk using ``diskimage-builder``."},{"line_number":1593,"context_line":""},{"line_number":1594,"context_line":"* Set ``DIB_SSACLI_URL`` as environment variable to install ssacli utility,"},{"line_number":1595,"context_line":"  if not ``DIB_SSACLI_URL`` takes the default url provided, during deploy"},{"line_number":1596,"context_line":"  ramdisk creation. For example::"},{"line_number":1597,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a430d35_9edda9e2","line":1594,"in_reply_to":"1a430d35_aa3c03e3","updated":"2017-02-07 05:55:04.000000000","message":"Done","commit_id":"428de608ae7978068b04e7a9ccbf067c980e8d42"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"d5c6f9c520b52058ac9d72d0a975404368c55d90","unresolved":false,"context_lines":[{"line_number":1602,"context_line":""},{"line_number":1603,"context_line":"    disk-image-create -o proliant-agent-ramdisk ironic-agent fedora proliant-tools"},{"line_number":1604,"context_line":""},{"line_number":1605,"context_line":"If the Sanitize Erase is not supported, then it falls backs to the ``erase_devices``"},{"line_number":1606,"context_line":"implementation available in Ironic Python Agent."},{"line_number":1607,"context_line":""},{"line_number":1608,"context_line":".. _`ssacli documentation`: http://h20566.www2.hpe.com/hpsc/doc/public/display?docId\u003dc03909334"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a430d35_0d37f1e3","line":1606,"range":{"start_line":1605,"start_character":0,"end_line":1606,"end_character":48},"updated":"2017-02-06 14:35:45.000000000","message":"This really ought to be mentioned as part of the first paragraph...","commit_id":"428de608ae7978068b04e7a9ccbf067c980e8d42"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"914a00455a5a51c56cacd5a291f696de282e4147","unresolved":false,"context_lines":[{"line_number":1602,"context_line":""},{"line_number":1603,"context_line":"    disk-image-create -o proliant-agent-ramdisk ironic-agent fedora proliant-tools"},{"line_number":1604,"context_line":""},{"line_number":1605,"context_line":"If the Sanitize Erase is not supported, then it falls backs to the ``erase_devices``"},{"line_number":1606,"context_line":"implementation available in Ironic Python Agent."},{"line_number":1607,"context_line":""},{"line_number":1608,"context_line":".. _`ssacli documentation`: http://h20566.www2.hpe.com/hpsc/doc/public/display?docId\u003dc03909334"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a430d35_8d8cc136","line":1606,"range":{"start_line":1605,"start_character":0,"end_line":1606,"end_character":48},"in_reply_to":"1a430d35_0d37f1e3","updated":"2017-02-06 14:44:14.000000000","message":"+1","commit_id":"428de608ae7978068b04e7a9ccbf067c980e8d42"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"43e52774b16bc70042b46b649541790ef5d70ce4","unresolved":false,"context_lines":[{"line_number":1602,"context_line":""},{"line_number":1603,"context_line":"    disk-image-create -o proliant-agent-ramdisk ironic-agent fedora proliant-tools"},{"line_number":1604,"context_line":""},{"line_number":1605,"context_line":"If the Sanitize Erase is not supported, then it falls backs to the ``erase_devices``"},{"line_number":1606,"context_line":"implementation available in Ironic Python Agent."},{"line_number":1607,"context_line":""},{"line_number":1608,"context_line":".. _`ssacli documentation`: http://h20566.www2.hpe.com/hpsc/doc/public/display?docId\u003dc03909334"}],"source_content_type":"text/x-rst","patch_set":9,"id":"1a430d35_9e04c94a","line":1606,"range":{"start_line":1605,"start_character":0,"end_line":1606,"end_character":48},"in_reply_to":"1a430d35_0d37f1e3","updated":"2017-02-07 05:55:04.000000000","message":"Done","commit_id":"428de608ae7978068b04e7a9ccbf067c980e8d42"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6a9522e917e65cba83b6aec12da548be7cf822d3","unresolved":false,"context_lines":[{"line_number":824,"context_line":"    Resets the iLO. By default, this step is disabled."},{"line_number":825,"context_line":"  ``erase_devices``:"},{"line_number":826,"context_line":"    Performs Sanitize Erase on disks in HPE Proliant servers. This step"},{"line_number":827,"context_line":"    supports disk erase in Proliant servers only with the ramdisk"},{"line_number":828,"context_line":"    created using diskimage-builder from Ocata release. By default,"},{"line_number":829,"context_line":"    this step is disabled. See `Sanitize Disk Erase Support`_."},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"* For in-band cleaning operations supported by ``agent_ilo`` driver, see"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1a430d35_d0d607f0","line":828,"range":{"start_line":827,"start_character":44,"end_line":828,"end_character":54},"updated":"2017-02-08 09:41:22.000000000","message":"with the agent ramdisk. Refer to \u0027Sanitize Disk Erase Support\u0027_ for more details.","commit_id":"e986953caf557f811455d4379db6bb7efbe64564"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"6a9522e917e65cba83b6aec12da548be7cf822d3","unresolved":false,"context_lines":[{"line_number":1572,"context_line":""},{"line_number":1573,"context_line":"  disk-image-create -o proliant-agent-ramdisk ironic-agent fedora proliant-tools"},{"line_number":1574,"context_line":""},{"line_number":1575,"context_line":".. _`Enabling HTTPS in Swift`: http://docs.openstack.org/project-install-guide/baremetal/draft/enabling-https.html#enabling-https-in-swift"},{"line_number":1576,"context_line":".. _`Enabling HTTPS in Image service`: http://docs.openstack.org/project-install-guide/baremetal/draft/enabling-https.html#enabling-https-in-image-service"},{"line_number":1577,"context_line":""},{"line_number":1578,"context_line":"Sanitize Disk Erase Support"},{"line_number":1579,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1a430d35_b0741b36","line":1576,"range":{"start_line":1575,"start_character":0,"end_line":1576,"end_character":154},"updated":"2017-02-08 09:41:22.000000000","message":"These links should come in the last of the document.","commit_id":"e986953caf557f811455d4379db6bb7efbe64564"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"629c376aea1a775b5b5852199021ef32e4e7ec54","unresolved":false,"context_lines":[{"line_number":1572,"context_line":""},{"line_number":1573,"context_line":"  disk-image-create -o proliant-agent-ramdisk ironic-agent fedora proliant-tools"},{"line_number":1574,"context_line":""},{"line_number":1575,"context_line":".. _`Enabling HTTPS in Swift`: http://docs.openstack.org/project-install-guide/baremetal/draft/enabling-https.html#enabling-https-in-swift"},{"line_number":1576,"context_line":".. _`Enabling HTTPS in Image service`: http://docs.openstack.org/project-install-guide/baremetal/draft/enabling-https.html#enabling-https-in-image-service"},{"line_number":1577,"context_line":""},{"line_number":1578,"context_line":"Sanitize Disk Erase Support"},{"line_number":1579,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1a430d35_0e06b01c","line":1576,"range":{"start_line":1575,"start_character":0,"end_line":1576,"end_character":154},"in_reply_to":"1a430d35_b0741b36","updated":"2017-02-08 10:00:47.000000000","message":"Done","commit_id":"e986953caf557f811455d4379db6bb7efbe64564"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f57501558f6fd70d1b5977bfb685157f38ee326c","unresolved":false,"context_lines":[{"line_number":847,"context_line":"    - clean_priority_reset_bios_to_default\u003d10"},{"line_number":848,"context_line":"    - clean_priority_reset_secure_boot_keys_to_default\u003d20"},{"line_number":849,"context_line":"    - clean_priority_clear_secure_boot_keys\u003d0"},{"line_number":850,"context_line":"    - clean_priority_reset_ilo_credential\u003d30"},{"line_number":851,"context_line":""},{"line_number":852,"context_line":"  [deploy] section::"},{"line_number":853,"context_line":"    - erase_devices_priority\u003d0"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a430d35_8b636041","line":850,"updated":"2017-02-08 14:51:20.000000000","message":"the formatting of this paragraph is quite unusual. I suggest reformatting it similar to \"configuring glance\" in the beginning of the document:\n\n  .. in ironic.conf::\n\n      [ilo]\n      clean_priority_reset_ilo\u003d0\n      ...\n      [deploy]\n      erase_devices_priority\u003d0","commit_id":"8279aee5ac0a7fdcba9a06727b061230374d27b7"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"ed0a0bd01ba802615526ff84bd3020844e8d271f","unresolved":false,"context_lines":[{"line_number":847,"context_line":"    - clean_priority_reset_bios_to_default\u003d10"},{"line_number":848,"context_line":"    - clean_priority_reset_secure_boot_keys_to_default\u003d20"},{"line_number":849,"context_line":"    - clean_priority_clear_secure_boot_keys\u003d0"},{"line_number":850,"context_line":"    - clean_priority_reset_ilo_credential\u003d30"},{"line_number":851,"context_line":""},{"line_number":852,"context_line":"  [deploy] section::"},{"line_number":853,"context_line":"    - erase_devices_priority\u003d0"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a430d35_c8cc898b","line":850,"in_reply_to":"1a430d35_8b636041","updated":"2017-02-08 15:50:14.000000000","message":"Done","commit_id":"8279aee5ac0a7fdcba9a06727b061230374d27b7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f57501558f6fd70d1b5977bfb685157f38ee326c","unresolved":false,"context_lines":[{"line_number":1575,"context_line":"Sanitize Disk Erase Support"},{"line_number":1576,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":1577,"context_line":""},{"line_number":1578,"context_line":"The sanitize disk erase is the inband clean step supported by iLO drives. It"},{"line_number":1579,"context_line":"is supported when the agent ramdisk contains the ``Proliant Hardware Manager``"},{"line_number":1580,"context_line":"from the proliantutils version 2.2.0 or higher. If the Sanitize Erase is"},{"line_number":1581,"context_line":"not supported, then it falls backs to the ``erase_devices`` implementation"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a430d35_ab665c4e","line":1578,"updated":"2017-02-08 14:51:20.000000000","message":"nit: \"Sanitize disk erase is an inband...\"","commit_id":"8279aee5ac0a7fdcba9a06727b061230374d27b7"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"ed0a0bd01ba802615526ff84bd3020844e8d271f","unresolved":false,"context_lines":[{"line_number":1575,"context_line":"Sanitize Disk Erase Support"},{"line_number":1576,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":1577,"context_line":""},{"line_number":1578,"context_line":"The sanitize disk erase is the inband clean step supported by iLO drives. It"},{"line_number":1579,"context_line":"is supported when the agent ramdisk contains the ``Proliant Hardware Manager``"},{"line_number":1580,"context_line":"from the proliantutils version 2.2.0 or higher. If the Sanitize Erase is"},{"line_number":1581,"context_line":"not supported, then it falls backs to the ``erase_devices`` implementation"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a430d35_c8e56909","line":1578,"in_reply_to":"1a430d35_ab665c4e","updated":"2017-02-08 15:50:14.000000000","message":"Done","commit_id":"8279aee5ac0a7fdcba9a06727b061230374d27b7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f57501558f6fd70d1b5977bfb685157f38ee326c","unresolved":false,"context_lines":[{"line_number":1580,"context_line":"from the proliantutils version 2.2.0 or higher. If the Sanitize Erase is"},{"line_number":1581,"context_line":"not supported, then it falls backs to the ``erase_devices`` implementation"},{"line_number":1582,"context_line":"available in Ironic Python Agent. This clean step is performed as part of"},{"line_number":1583,"context_line":"automated clean step. See :ref:`InbandvsOutOfBandCleaning` for more information"},{"line_number":1584,"context_line":"on enable/disable a clean step."},{"line_number":1585,"context_line":""},{"line_number":1586,"context_line":"This inband clean step uses ``ssacli`` utility starting from version ``2.60-19.0``"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a430d35_cb59e88f","line":1583,"updated":"2017-02-08 14:51:20.000000000","message":"s/automated clean step/automated cleaning/","commit_id":"8279aee5ac0a7fdcba9a06727b061230374d27b7"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"ed0a0bd01ba802615526ff84bd3020844e8d271f","unresolved":false,"context_lines":[{"line_number":1580,"context_line":"from the proliantutils version 2.2.0 or higher. If the Sanitize Erase is"},{"line_number":1581,"context_line":"not supported, then it falls backs to the ``erase_devices`` implementation"},{"line_number":1582,"context_line":"available in Ironic Python Agent. This clean step is performed as part of"},{"line_number":1583,"context_line":"automated clean step. See :ref:`InbandvsOutOfBandCleaning` for more information"},{"line_number":1584,"context_line":"on enable/disable a clean step."},{"line_number":1585,"context_line":""},{"line_number":1586,"context_line":"This inband clean step uses ``ssacli`` utility starting from version ``2.60-19.0``"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a430d35_e8f065cb","line":1583,"in_reply_to":"1a430d35_cb59e88f","updated":"2017-02-08 15:50:14.000000000","message":"Done","commit_id":"8279aee5ac0a7fdcba9a06727b061230374d27b7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f57501558f6fd70d1b5977bfb685157f38ee326c","unresolved":false,"context_lines":[{"line_number":1581,"context_line":"not supported, then it falls backs to the ``erase_devices`` implementation"},{"line_number":1582,"context_line":"available in Ironic Python Agent. This clean step is performed as part of"},{"line_number":1583,"context_line":"automated clean step. See :ref:`InbandvsOutOfBandCleaning` for more information"},{"line_number":1584,"context_line":"on enable/disable a clean step."},{"line_number":1585,"context_line":""},{"line_number":1586,"context_line":"This inband clean step uses ``ssacli`` utility starting from version ``2.60-19.0``"},{"line_number":1587,"context_line":"to perform the erase on physical disks. See the `ssacli documentation`_"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a430d35_eb5ce47e","line":1584,"updated":"2017-02-08 14:51:20.000000000","message":"\"on enabling/disabling\"","commit_id":"8279aee5ac0a7fdcba9a06727b061230374d27b7"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"ed0a0bd01ba802615526ff84bd3020844e8d271f","unresolved":false,"context_lines":[{"line_number":1581,"context_line":"not supported, then it falls backs to the ``erase_devices`` implementation"},{"line_number":1582,"context_line":"available in Ironic Python Agent. This clean step is performed as part of"},{"line_number":1583,"context_line":"automated clean step. See :ref:`InbandvsOutOfBandCleaning` for more information"},{"line_number":1584,"context_line":"on enable/disable a clean step."},{"line_number":1585,"context_line":""},{"line_number":1586,"context_line":"This inband clean step uses ``ssacli`` utility starting from version ``2.60-19.0``"},{"line_number":1587,"context_line":"to perform the erase on physical disks. See the `ssacli documentation`_"}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a430d35_48c09950","line":1584,"in_reply_to":"1a430d35_eb5ce47e","updated":"2017-02-08 15:50:14.000000000","message":"Done","commit_id":"8279aee5ac0a7fdcba9a06727b061230374d27b7"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f57501558f6fd70d1b5977bfb685157f38ee326c","unresolved":false,"context_lines":[{"line_number":1583,"context_line":"automated clean step. See :ref:`InbandvsOutOfBandCleaning` for more information"},{"line_number":1584,"context_line":"on enable/disable a clean step."},{"line_number":1585,"context_line":""},{"line_number":1586,"context_line":"This inband clean step uses ``ssacli`` utility starting from version ``2.60-19.0``"},{"line_number":1587,"context_line":"to perform the erase on physical disks. See the `ssacli documentation`_"},{"line_number":1588,"context_line":"for more information on ssacli utility."},{"line_number":1589,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a430d35_0b585087","line":1586,"updated":"2017-02-08 14:51:20.000000000","message":"s/uses/requires/ for clarify","commit_id":"8279aee5ac0a7fdcba9a06727b061230374d27b7"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"ed0a0bd01ba802615526ff84bd3020844e8d271f","unresolved":false,"context_lines":[{"line_number":1583,"context_line":"automated clean step. See :ref:`InbandvsOutOfBandCleaning` for more information"},{"line_number":1584,"context_line":"on enable/disable a clean step."},{"line_number":1585,"context_line":""},{"line_number":1586,"context_line":"This inband clean step uses ``ssacli`` utility starting from version ``2.60-19.0``"},{"line_number":1587,"context_line":"to perform the erase on physical disks. See the `ssacli documentation`_"},{"line_number":1588,"context_line":"for more information on ssacli utility."},{"line_number":1589,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"1a430d35_68b3950a","line":1586,"in_reply_to":"1a430d35_0b585087","updated":"2017-02-08 15:50:14.000000000","message":"Done","commit_id":"8279aee5ac0a7fdcba9a06727b061230374d27b7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"115acd1254a5cc2de86587e084fe5eb4de90c01f","unresolved":false,"context_lines":[{"line_number":1578,"context_line":"The sanitize disk erase is an inband clean step supported by iLO drives. It"},{"line_number":1579,"context_line":"is supported when the agent ramdisk contains the ``Proliant Hardware Manager``"},{"line_number":1580,"context_line":"from the proliantutils version 2.2.0 or higher. If the Sanitize Erase is"},{"line_number":1581,"context_line":"not supported, then it falls backs to the ``erase_devices`` implementation"},{"line_number":1582,"context_line":"available in Ironic Python Agent. This clean step is performed as part of"},{"line_number":1583,"context_line":"automated cleaning. See :ref:`InbandvsOutOfBandCleaning` for more information"},{"line_number":1584,"context_line":"on enabling/disabling a clean step."}],"source_content_type":"text/x-rst","patch_set":13,"id":"fa31d9ce_180a1cd3","line":1581,"range":{"start_line":1581,"start_character":29,"end_line":1581,"end_character":34},"updated":"2017-02-10 10:16:50.000000000","message":"back\n\nor fallbacks?","commit_id":"b171bc05c9be5f79db87c63a38eddab38edc70b7"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"84388f839e525cb7fd4e39c98c85711a78cf9a05","unresolved":false,"context_lines":[{"line_number":1578,"context_line":"The sanitize disk erase is an inband clean step supported by iLO drives. It"},{"line_number":1579,"context_line":"is supported when the agent ramdisk contains the ``Proliant Hardware Manager``"},{"line_number":1580,"context_line":"from the proliantutils version 2.2.0 or higher. If the Sanitize Erase is"},{"line_number":1581,"context_line":"not supported, then it falls backs to the ``erase_devices`` implementation"},{"line_number":1582,"context_line":"available in Ironic Python Agent. This clean step is performed as part of"},{"line_number":1583,"context_line":"automated cleaning. See :ref:`InbandvsOutOfBandCleaning` for more information"},{"line_number":1584,"context_line":"on enabling/disabling a clean step."}],"source_content_type":"text/x-rst","patch_set":13,"id":"fa31d9ce_6972687e","line":1581,"range":{"start_line":1581,"start_character":29,"end_line":1581,"end_character":34},"in_reply_to":"fa31d9ce_180a1cd3","updated":"2017-02-10 11:32:00.000000000","message":"Done","commit_id":"b171bc05c9be5f79db87c63a38eddab38edc70b7"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"115acd1254a5cc2de86587e084fe5eb4de90c01f","unresolved":false,"context_lines":[{"line_number":1579,"context_line":"is supported when the agent ramdisk contains the ``Proliant Hardware Manager``"},{"line_number":1580,"context_line":"from the proliantutils version 2.2.0 or higher. If the Sanitize Erase is"},{"line_number":1581,"context_line":"not supported, then it falls backs to the ``erase_devices`` implementation"},{"line_number":1582,"context_line":"available in Ironic Python Agent. This clean step is performed as part of"},{"line_number":1583,"context_line":"automated cleaning. See :ref:`InbandvsOutOfBandCleaning` for more information"},{"line_number":1584,"context_line":"on enabling/disabling a clean step."},{"line_number":1585,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"fa31d9ce_f8038874","line":1582,"updated":"2017-02-10 10:16:50.000000000","message":"So, the get_clean_steps present in Proliant Hardware Manager returns 0 priority for erase_devices step. So it won\u0027t run by default, unless you explicitly set the priority in ironic config right? I see you mention it on L829, but would be good to repeat here I think.","commit_id":"b171bc05c9be5f79db87c63a38eddab38edc70b7"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"84388f839e525cb7fd4e39c98c85711a78cf9a05","unresolved":false,"context_lines":[{"line_number":1579,"context_line":"is supported when the agent ramdisk contains the ``Proliant Hardware Manager``"},{"line_number":1580,"context_line":"from the proliantutils version 2.2.0 or higher. If the Sanitize Erase is"},{"line_number":1581,"context_line":"not supported, then it falls backs to the ``erase_devices`` implementation"},{"line_number":1582,"context_line":"available in Ironic Python Agent. This clean step is performed as part of"},{"line_number":1583,"context_line":"automated cleaning. See :ref:`InbandvsOutOfBandCleaning` for more information"},{"line_number":1584,"context_line":"on enabling/disabling a clean step."},{"line_number":1585,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"fa31d9ce_a9f1c0cf","line":1582,"in_reply_to":"fa31d9ce_f8038874","updated":"2017-02-10 11:32:00.000000000","message":"Done","commit_id":"b171bc05c9be5f79db87c63a38eddab38edc70b7"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"2c668f5c034e8b5f234c45ac7dbe4fad1a874f1b","unresolved":false,"context_lines":[{"line_number":825,"context_line":"  ``erase_devices``:"},{"line_number":826,"context_line":"    Performs Sanitize Erase on disks in HPE Proliant servers. This step"},{"line_number":827,"context_line":"    supports disk erase in Proliant servers only with the ramdisk"},{"line_number":828,"context_line":"    created using diskimage-builder from Ocata release. By default,"},{"line_number":829,"context_line":"    this step is disabled. See `Sanitize Disk Erase Support`_."},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"* For in-band cleaning operations supported by ``agent_ilo`` driver, see"}],"source_content_type":"text/x-rst","patch_set":14,"id":"fa31d9ce_ae99ad70","line":828,"updated":"2017-02-10 20:59:48.000000000","message":"This is still not accurate. Disk erasure via shred worked in proliant servers before this release. We should not imply otherwise.\n\nI am still concerned about recommending a DIB-based ramdisk when it\u0027s not tested in upstream CI, but if it\u0027s used in iLO 3rd party CI, that sufficiently mitigates that concern.","commit_id":"f5c4174a142dc353fa70298da7f1e0f4e377b9d2"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4e7ebaa0e901f667ffeed13bb29b5483e9fda78a","unresolved":false,"context_lines":[{"line_number":823,"context_line":"  ``reset_ilo``:"},{"line_number":824,"context_line":"    Resets the iLO. By default, this step is disabled."},{"line_number":825,"context_line":"  ``erase_devices``:"},{"line_number":826,"context_line":"    Performs disk erase on all the disks which includes logical volumes and"},{"line_number":827,"context_line":"    raw disks visible to Smart Storage Administrator(SSA) available in HPE"},{"line_number":828,"context_line":"    Proliant servers. This step adds support to perform erase on both logical"},{"line_number":829,"context_line":"    volumes and raw disks in Proliant servers only with the ramdisk created"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f201791_77b32cea","line":826,"range":{"start_line":826,"start_character":56,"end_line":826,"end_character":71},"updated":"2017-06-28 06:12:58.000000000","message":"In case of DAS, logical volume would not be applicable. Would it be better  to indicate it \u0027OS visible\u0027 and \u0027raw\u0027 disk?","commit_id":"cd81c1a599be871bccd3225882c83889fe5d3fd8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4e7ebaa0e901f667ffeed13bb29b5483e9fda78a","unresolved":false,"context_lines":[{"line_number":823,"context_line":"  ``reset_ilo``:"},{"line_number":824,"context_line":"    Resets the iLO. By default, this step is disabled."},{"line_number":825,"context_line":"  ``erase_devices``:"},{"line_number":826,"context_line":"    Performs disk erase on all the disks which includes logical volumes and"},{"line_number":827,"context_line":"    raw disks visible to Smart Storage Administrator(SSA) available in HPE"},{"line_number":828,"context_line":"    Proliant servers. This step adds support to perform erase on both logical"},{"line_number":829,"context_line":"    volumes and raw disks in Proliant servers only with the ramdisk created"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f201791_37e4940c","line":826,"range":{"start_line":826,"start_character":4,"end_line":826,"end_character":40},"updated":"2017-06-28 06:12:58.000000000","message":"Need to mention that this is a an in-band cleaning step.","commit_id":"cd81c1a599be871bccd3225882c83889fe5d3fd8"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"f91cbb2fba5ac658c9121bfef7765b96f012c795","unresolved":false,"context_lines":[{"line_number":823,"context_line":"  ``reset_ilo``:"},{"line_number":824,"context_line":"    Resets the iLO. By default, this step is disabled."},{"line_number":825,"context_line":"  ``erase_devices``:"},{"line_number":826,"context_line":"    Performs disk erase on all the disks which includes logical volumes and"},{"line_number":827,"context_line":"    raw disks visible to Smart Storage Administrator(SSA) available in HPE"},{"line_number":828,"context_line":"    Proliant servers. This step adds support to perform erase on both logical"},{"line_number":829,"context_line":"    volumes and raw disks in Proliant servers only with the ramdisk created"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f201791_bd087e91","line":826,"range":{"start_line":826,"start_character":4,"end_line":826,"end_character":40},"in_reply_to":"5f201791_37e4940c","updated":"2017-06-28 10:28:47.000000000","message":"Done","commit_id":"cd81c1a599be871bccd3225882c83889fe5d3fd8"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"f91cbb2fba5ac658c9121bfef7765b96f012c795","unresolved":false,"context_lines":[{"line_number":823,"context_line":"  ``reset_ilo``:"},{"line_number":824,"context_line":"    Resets the iLO. By default, this step is disabled."},{"line_number":825,"context_line":"  ``erase_devices``:"},{"line_number":826,"context_line":"    Performs disk erase on all the disks which includes logical volumes and"},{"line_number":827,"context_line":"    raw disks visible to Smart Storage Administrator(SSA) available in HPE"},{"line_number":828,"context_line":"    Proliant servers. This step adds support to perform erase on both logical"},{"line_number":829,"context_line":"    volumes and raw disks in Proliant servers only with the ramdisk created"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f201791_9d0b828c","line":826,"range":{"start_line":826,"start_character":56,"end_line":826,"end_character":71},"in_reply_to":"5f201791_77b32cea","updated":"2017-06-28 10:28:47.000000000","message":"Done","commit_id":"cd81c1a599be871bccd3225882c83889fe5d3fd8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4e7ebaa0e901f667ffeed13bb29b5483e9fda78a","unresolved":false,"context_lines":[{"line_number":1600,"context_line":""},{"line_number":1601,"context_line":"  disk-image-create -o proliant-agent-ramdisk ironic-agent fedora proliant-tools"},{"line_number":1602,"context_line":""},{"line_number":1603,"context_line":"Sanitize Disk Erase Support"},{"line_number":1604,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":1605,"context_line":""},{"line_number":1606,"context_line":"The sanitize disk erase is an inband clean step supported by iLO drives. It"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f201791_14063621","line":1603,"range":{"start_line":1603,"start_character":0,"end_line":1603,"end_character":27},"updated":"2017-06-28 06:12:58.000000000","message":"I think the heading should be \u0027Disk Erase Support\u0027 instead of \u0027Sanitize Disk Erase Support\u0027 as \u0027Sanitize is just one of the supported mechanism.","commit_id":"cd81c1a599be871bccd3225882c83889fe5d3fd8"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"f91cbb2fba5ac658c9121bfef7765b96f012c795","unresolved":false,"context_lines":[{"line_number":1600,"context_line":""},{"line_number":1601,"context_line":"  disk-image-create -o proliant-agent-ramdisk ironic-agent fedora proliant-tools"},{"line_number":1602,"context_line":""},{"line_number":1603,"context_line":"Sanitize Disk Erase Support"},{"line_number":1604,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":1605,"context_line":""},{"line_number":1606,"context_line":"The sanitize disk erase is an inband clean step supported by iLO drives. It"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f201791_dd48dab3","line":1603,"range":{"start_line":1603,"start_character":0,"end_line":1603,"end_character":27},"in_reply_to":"5f201791_14063621","updated":"2017-06-28 10:28:47.000000000","message":"Done","commit_id":"cd81c1a599be871bccd3225882c83889fe5d3fd8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4e7ebaa0e901f667ffeed13bb29b5483e9fda78a","unresolved":false,"context_lines":[{"line_number":1603,"context_line":"Sanitize Disk Erase Support"},{"line_number":1604,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":1605,"context_line":""},{"line_number":1606,"context_line":"The sanitize disk erase is an inband clean step supported by iLO drives. It"},{"line_number":1607,"context_line":"performs erase on both logical volumes and raw disks visible to the Smart"},{"line_number":1608,"context_line":"Storage Administrator(SSA). The disk erasure via ``shred`` is used to erase"},{"line_number":1609,"context_line":"logical volumes on the server. The raw disks connected to the Smart Storage"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f201791_171bd872","line":1606,"range":{"start_line":1606,"start_character":4,"end_line":1606,"end_character":12},"updated":"2017-06-28 06:12:58.000000000","message":"nit: s/ \u0027sanitize disk erase\u0027 / \u0027erase_devices\u0027 /","commit_id":"cd81c1a599be871bccd3225882c83889fe5d3fd8"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"f91cbb2fba5ac658c9121bfef7765b96f012c795","unresolved":false,"context_lines":[{"line_number":1603,"context_line":"Sanitize Disk Erase Support"},{"line_number":1604,"context_line":"^^^^^^^^^^^^^^^^^^^^^^^^^^^"},{"line_number":1605,"context_line":""},{"line_number":1606,"context_line":"The sanitize disk erase is an inband clean step supported by iLO drives. It"},{"line_number":1607,"context_line":"performs erase on both logical volumes and raw disks visible to the Smart"},{"line_number":1608,"context_line":"Storage Administrator(SSA). The disk erasure via ``shred`` is used to erase"},{"line_number":1609,"context_line":"logical volumes on the server. The raw disks connected to the Smart Storage"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f201791_9d9a6211","line":1606,"range":{"start_line":1606,"start_character":4,"end_line":1606,"end_character":12},"in_reply_to":"5f201791_171bd872","updated":"2017-06-28 10:28:47.000000000","message":"Done","commit_id":"cd81c1a599be871bccd3225882c83889fe5d3fd8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4e7ebaa0e901f667ffeed13bb29b5483e9fda78a","unresolved":false,"context_lines":[{"line_number":1607,"context_line":"performs erase on both logical volumes and raw disks visible to the Smart"},{"line_number":1608,"context_line":"Storage Administrator(SSA). The disk erasure via ``shred`` is used to erase"},{"line_number":1609,"context_line":"logical volumes on the server. The raw disks connected to the Smart Storage"},{"line_number":1610,"context_line":"Controller is erased using Sanitize Erase. If Sanitize Erase is not supported"},{"line_number":1611,"context_line":"on the Smart Storage Controller the disks are erased using One-pass Erase"},{"line_number":1612,"context_line":"(overwrite with zeros)."},{"line_number":1613,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f201791_1749985e","line":1610,"range":{"start_line":1610,"start_character":27,"end_line":1610,"end_character":41},"updated":"2017-06-28 06:12:58.000000000","message":"May be you need to elaborate that \u0027Sanitize Erase\u0027 is a ssacli command option","commit_id":"cd81c1a599be871bccd3225882c83889fe5d3fd8"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"f91cbb2fba5ac658c9121bfef7765b96f012c795","unresolved":false,"context_lines":[{"line_number":1607,"context_line":"performs erase on both logical volumes and raw disks visible to the Smart"},{"line_number":1608,"context_line":"Storage Administrator(SSA). The disk erasure via ``shred`` is used to erase"},{"line_number":1609,"context_line":"logical volumes on the server. The raw disks connected to the Smart Storage"},{"line_number":1610,"context_line":"Controller is erased using Sanitize Erase. If Sanitize Erase is not supported"},{"line_number":1611,"context_line":"on the Smart Storage Controller the disks are erased using One-pass Erase"},{"line_number":1612,"context_line":"(overwrite with zeros)."},{"line_number":1613,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f201791_3d622e0b","line":1610,"range":{"start_line":1610,"start_character":27,"end_line":1610,"end_character":41},"in_reply_to":"5f201791_1749985e","updated":"2017-06-28 10:28:47.000000000","message":"Done","commit_id":"cd81c1a599be871bccd3225882c83889fe5d3fd8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4e7ebaa0e901f667ffeed13bb29b5483e9fda78a","unresolved":false,"context_lines":[{"line_number":1608,"context_line":"Storage Administrator(SSA). The disk erasure via ``shred`` is used to erase"},{"line_number":1609,"context_line":"logical volumes on the server. The raw disks connected to the Smart Storage"},{"line_number":1610,"context_line":"Controller is erased using Sanitize Erase. If Sanitize Erase is not supported"},{"line_number":1611,"context_line":"on the Smart Storage Controller the disks are erased using One-pass Erase"},{"line_number":1612,"context_line":"(overwrite with zeros)."},{"line_number":1613,"context_line":""},{"line_number":1614,"context_line":"This inband clean step requires ``ssacli`` utility starting from version"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f201791_3767f4eb","line":1611,"range":{"start_line":1611,"start_character":68,"end_line":1611,"end_character":73},"updated":"2017-06-28 06:12:58.000000000","message":"s/ Erase / erase","commit_id":"cd81c1a599be871bccd3225882c83889fe5d3fd8"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"f91cbb2fba5ac658c9121bfef7765b96f012c795","unresolved":false,"context_lines":[{"line_number":1608,"context_line":"Storage Administrator(SSA). The disk erasure via ``shred`` is used to erase"},{"line_number":1609,"context_line":"logical volumes on the server. The raw disks connected to the Smart Storage"},{"line_number":1610,"context_line":"Controller is erased using Sanitize Erase. If Sanitize Erase is not supported"},{"line_number":1611,"context_line":"on the Smart Storage Controller the disks are erased using One-pass Erase"},{"line_number":1612,"context_line":"(overwrite with zeros)."},{"line_number":1613,"context_line":""},{"line_number":1614,"context_line":"This inband clean step requires ``ssacli`` utility starting from version"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f201791_fd571625","line":1611,"range":{"start_line":1611,"start_character":68,"end_line":1611,"end_character":73},"in_reply_to":"5f201791_3767f4eb","updated":"2017-06-28 10:28:47.000000000","message":"Done","commit_id":"cd81c1a599be871bccd3225882c83889fe5d3fd8"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"4e7ebaa0e901f667ffeed13bb29b5483e9fda78a","unresolved":false,"context_lines":[{"line_number":1618,"context_line":""},{"line_number":1619,"context_line":"This clean step is supported when the agent ramdisk contains the"},{"line_number":1620,"context_line":"``Proliant Hardware Manager`` from the proliantutils version 2.3.0 or higher."},{"line_number":1621,"context_line":"If the Sanitize Erase is not supported, then it falls back to the"},{"line_number":1622,"context_line":"``erase_devices`` implementation available in Ironic Python Agent. This"},{"line_number":1623,"context_line":"clean step is performed as part of automated cleaning and it is disabled by"},{"line_number":1624,"context_line":"default. See :ref:`InbandvsOutOfBandCleaning` for more information on"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f201791_77856c06","line":1621,"range":{"start_line":1621,"start_character":0,"end_line":1621,"end_character":38},"updated":"2017-06-28 06:12:58.000000000","message":"I think if sanitize is not available it would fall to \u0027One-pass Erase \u0027. It would always use IPA based erase to clear OS-visible disks.","commit_id":"cd81c1a599be871bccd3225882c83889fe5d3fd8"},{"author":{"_account_id":15074,"name":"Aparna","email":"aparnavtce@gmail.com","username":"Aparna"},"change_message_id":"f91cbb2fba5ac658c9121bfef7765b96f012c795","unresolved":false,"context_lines":[{"line_number":1618,"context_line":""},{"line_number":1619,"context_line":"This clean step is supported when the agent ramdisk contains the"},{"line_number":1620,"context_line":"``Proliant Hardware Manager`` from the proliantutils version 2.3.0 or higher."},{"line_number":1621,"context_line":"If the Sanitize Erase is not supported, then it falls back to the"},{"line_number":1622,"context_line":"``erase_devices`` implementation available in Ironic Python Agent. This"},{"line_number":1623,"context_line":"clean step is performed as part of automated cleaning and it is disabled by"},{"line_number":1624,"context_line":"default. See :ref:`InbandvsOutOfBandCleaning` for more information on"}],"source_content_type":"text/x-rst","patch_set":15,"id":"5f201791_70f1ed00","line":1621,"range":{"start_line":1621,"start_character":0,"end_line":1621,"end_character":38},"in_reply_to":"5f201791_77856c06","updated":"2017-06-28 10:28:47.000000000","message":"Done","commit_id":"cd81c1a599be871bccd3225882c83889fe5d3fd8"}]}