)]}'
{"ironic/drivers/modules/agent.py":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"768531b089ab3b9bb2095e62c32d582d46d528b6","unresolved":false,"context_lines":[{"line_number":427,"context_line":"            manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":428,"context_line":"            task.driver.network.add_provisioning_network(task)"},{"line_number":429,"context_line":"        if node.provision_state \u003d\u003d states.ACTIVE:"},{"line_number":430,"context_line":"            task.driver.boot.prepare_instance(task)"},{"line_number":431,"context_line":"        elif node.provision_state !\u003d states.ADOPTING:"},{"line_number":432,"context_line":"            node.instance_info \u003d deploy_utils.build_instance_info_for_deploy("},{"line_number":433,"context_line":"                task)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_0c3726b1","line":430,"updated":"2016-12-22 15:03:08.000000000","message":"Looks good, but current implementation of pxe boot interface will do unneeded set boot device on HW in local boot case.","commit_id":"fef714e4a34f7250aa2a6dc1ac46a69c04a5f54a"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"0889cfb7051f334c312aa4d1fd52ba5b790a3295","unresolved":false,"context_lines":[{"line_number":427,"context_line":"            manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":428,"context_line":"            task.driver.network.add_provisioning_network(task)"},{"line_number":429,"context_line":"        if node.provision_state \u003d\u003d states.ACTIVE:"},{"line_number":430,"context_line":"            task.driver.boot.prepare_instance(task)"},{"line_number":431,"context_line":"        elif node.provision_state !\u003d states.ADOPTING:"},{"line_number":432,"context_line":"            node.instance_info \u003d deploy_utils.build_instance_info_for_deploy("},{"line_number":433,"context_line":"                task)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_796db031","line":430,"in_reply_to":"da4df55a_0c3726b1","updated":"2017-01-10 17:00:24.000000000","message":"I tried to fix this in the previous change in the chain.","commit_id":"fef714e4a34f7250aa2a6dc1ac46a69c04a5f54a"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"9bb3f2240735c74db1db83b68db3e01e1fe97349","unresolved":false,"context_lines":[{"line_number":427,"context_line":"            manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":428,"context_line":"            task.driver.network.add_provisioning_network(task)"},{"line_number":429,"context_line":"        if node.provision_state \u003d\u003d states.ACTIVE:"},{"line_number":430,"context_line":"            task.driver.boot.prepare_instance(task)"},{"line_number":431,"context_line":"        elif node.provision_state !\u003d states.ADOPTING:"},{"line_number":432,"context_line":"            node.instance_info \u003d deploy_utils.build_instance_info_for_deploy("},{"line_number":433,"context_line":"                task)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_2abcca6b","line":430,"in_reply_to":"da4df55a_0c3726b1","updated":"2016-12-22 16:25:23.000000000","message":"Yeah, we have this problem already -- here https://github.com/openstack/ironic/blob/12feff85d6826d198a424a1c25efcc3d3c591299/ironic/drivers/modules/agent.py#L299-L300 we do set boot device after https://github.com/openstack/ironic/blob/12feff85d6826d198a424a1c25efcc3d3c591299/ironic/drivers/modules/agent.py#L296 where we call boot.prepare_instance, and which has different logic for choosing boot device.\n\nAlso, we determine boot_mode by looking at default_boot_mode config option, so it seems in future, we\u0027ll have to set boot_option netboot in instance_info for nodes using agent drivers that want to netboot, as the default_boot_mode will change to local at some point. Just something to keep in mind.","commit_id":"fef714e4a34f7250aa2a6dc1ac46a69c04a5f54a"},{"author":{"_account_id":19072,"name":"Xavier","email":"marcusrafael@lsd.ufcg.edu.br","username":"marcusrafael"},"change_message_id":"ab1195efc9d9998aa34aa2640fce49d22035b199","unresolved":false,"context_lines":[{"line_number":426,"context_line":"            # options get added for the provisioning port."},{"line_number":427,"context_line":"            manager_utils.node_power_action(task, states.POWER_OFF)"},{"line_number":428,"context_line":"            task.driver.network.add_provisioning_network(task)"},{"line_number":429,"context_line":"        if node.provision_state \u003d\u003d states.ACTIVE:"},{"line_number":430,"context_line":"            task.driver.boot.prepare_instance(task)"},{"line_number":431,"context_line":"        elif node.provision_state !\u003d states.ADOPTING:"},{"line_number":432,"context_line":"            node.instance_info \u003d deploy_utils.build_instance_info_for_deploy("},{"line_number":433,"context_line":"                task)"},{"line_number":434,"context_line":"            node.save()"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba5201f7_2e2039b0","line":431,"range":{"start_line":429,"start_character":8,"end_line":431,"end_character":53},"updated":"2017-01-10 19:07:24.000000000","message":"Pavlo, please add a NOTE describing the change.","commit_id":"79010d6033042715db9736afdf891f4140910a00"}]}