)]}'
{"ironic/drivers/modules/agent.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7e0fdafa425e11a26c5941ff9b4cbbc32e38924b","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        deploy_utils.check_for_missing_params(params, error_msg)"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"        if not service_utils.is_glance_image(image_source):"},{"line_number":354,"context_line":"            if not node.driver_internal_info.get(\u0027image_checksum\u0027):"},{"line_number":355,"context_line":"                raise exception.MissingParameterValue(_("},{"line_number":356,"context_line":"                    \"image_source\u0027s image_checksum must be provided in \""},{"line_number":357,"context_line":"                    \"driver_internal_info for node %s\") % node.uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_259f7c04","line":354,"range":{"start_line":354,"start_character":5,"end_line":354,"end_character":67},"updated":"2016-12-08 16:11:11.000000000","message":"Moving image checksum is a hard breaking change for stand-alone deployments that rely upon supplying the image_checksum directly for the deployment.  A user cannot supply the information to driver_internal_info.","commit_id":"cbc628bdefb7d10150b929613f593bf6c43bcbe9"},{"author":{"_account_id":5805,"name":"Chris Krelle","email":"nobodycam@gmail.com","username":"nobodycam"},"change_message_id":"aff984ff5082418f2ff70388d60b42d80e4a1660","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        deploy_utils.check_for_missing_params(params, error_msg)"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"        if not service_utils.is_glance_image(image_source):"},{"line_number":354,"context_line":"            if not node.driver_internal_info.get(\u0027image_checksum\u0027):"},{"line_number":355,"context_line":"                raise exception.MissingParameterValue(_("},{"line_number":356,"context_line":"                    \"image_source\u0027s image_checksum must be provided in \""},{"line_number":357,"context_line":"                    \"driver_internal_info for node %s\") % node.uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_12bc796b","line":354,"range":{"start_line":354,"start_character":5,"end_line":354,"end_character":67},"in_reply_to":"3a71b18c_259f7c04","updated":"2016-12-08 19:38:26.000000000","message":"I fully agree with Julia here. using internal_info here will break standalone use of Ironic.","commit_id":"cbc628bdefb7d10150b929613f593bf6c43bcbe9"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7e0fdafa425e11a26c5941ff9b4cbbc32e38924b","unresolved":false,"context_lines":[{"line_number":1024,"context_line":"    is_whole_disk_image \u003d node.driver_internal_info.get(\u0027is_whole_disk_image\u0027)"},{"line_number":1025,"context_line":"    if not is_whole_disk_image:"},{"line_number":1026,"context_line":"        if not service_utils.is_glance_image(info[\u0027image_source\u0027]):"},{"line_number":1027,"context_line":"            info[\u0027kernel\u0027] \u003d node.driver_internal_info.get(\u0027kernel\u0027)"},{"line_number":1028,"context_line":"            info[\u0027ramdisk\u0027] \u003d node.driver_internal_info.get(\u0027ramdisk\u0027)"},{"line_number":1029,"context_line":""},{"line_number":1030,"context_line":"    error_msg \u003d (_(\"Cannot validate image information for node %s because one \""},{"line_number":1031,"context_line":"                   \"or more parameters are missing from its \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a71b18c_655ed446","line":1028,"range":{"start_line":1027,"start_character":4,"end_line":1028,"end_character":70},"updated":"2016-12-08 16:11:11.000000000","message":"Moving to driver_internal_info means that these are no longer user-settable which eliminates the ability for them to be defined if the image is not a glance image.  Effectively this removes stand-alone deployment capability for a partition image.","commit_id":"cbc628bdefb7d10150b929613f593bf6c43bcbe9"}]}