)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"4725245277f339d1e3f9e2109f94ae854ec84927","unresolved":false,"context_lines":[{"line_number":10,"context_line":"being deployed in UEFI mode without local boot."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This conditional is an inconsistency because whole disk images being"},{"line_number":13,"context_line":"deploying in non-UEFI mode don\u0027t need to explicitly set the boot_option"},{"line_number":14,"context_line":"from \"local\", also, in Ironic when deploying a whole disk image we"},{"line_number":15,"context_line":"already assume local boot by default."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da4df55a_6b46ea24","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":9},"updated":"2016-12-22 09:29:14.000000000","message":"deployed","commit_id":"c831ce33d1cdcf836544a0f123946ff7f45d125b"}],"ironic/tests/unit/drivers/modules/ilo/test_deploy.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"4725245277f339d1e3f9e2109f94ae854ec84927","unresolved":false,"context_lines":[{"line_number":694,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":695,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":696,"context_line":"            task.node.properties[\u0027capabilities\u0027] \u003d \u0027boot_mode:uefi\u0027"},{"line_number":697,"context_line":"            task.node.driver_internal_info[\u0027is_whole_disk_image\u0027] \u003d True"},{"line_number":698,"context_line":"            task.driver.deploy.prepare(task)"},{"line_number":699,"context_line":"            prepare_node_for_deploy_mock.assert_called_once_with(task)"},{"line_number":700,"context_line":"            pxe_prepare_mock.assert_called_once_with(mock.ANY, task)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da4df55a_ebe49a3c","line":697,"updated":"2016-12-22 09:29:14.000000000","message":"For greater clarity, I\u0027d set netboot explicitly for the test. Seems like previously the test was passing because of the presence of the default_boot_option config opt.","commit_id":"c831ce33d1cdcf836544a0f123946ff7f45d125b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"252909165e727969aec003c7a457d145ecd74d0c","unresolved":false,"context_lines":[{"line_number":694,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"},{"line_number":695,"context_line":"                                  shared\u003dFalse) as task:"},{"line_number":696,"context_line":"            task.node.properties[\u0027capabilities\u0027] \u003d \u0027boot_mode:uefi\u0027"},{"line_number":697,"context_line":"            task.node.driver_internal_info[\u0027is_whole_disk_image\u0027] \u003d True"},{"line_number":698,"context_line":"            task.driver.deploy.prepare(task)"},{"line_number":699,"context_line":"            prepare_node_for_deploy_mock.assert_called_once_with(task)"},{"line_number":700,"context_line":"            pxe_prepare_mock.assert_called_once_with(mock.ANY, task)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba5201f7_a487d3d5","line":697,"in_reply_to":"da4df55a_ebe49a3c","updated":"2017-01-04 11:46:46.000000000","message":"++ good point","commit_id":"c831ce33d1cdcf836544a0f123946ff7f45d125b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"735a842abe8ea0601766db4f20130ab72b7f3133","unresolved":false,"context_lines":[{"line_number":689,"context_line":"                       autospec\u003dTrue)"},{"line_number":690,"context_line":"    def test_prepare_whole_disk_image_uefi(self, prepare_node_for_deploy_mock,"},{"line_number":691,"context_line":"                                           pxe_prepare_mock):"},{"line_number":692,"context_line":"        cfg.CONF.set_override(\u0027default_boot_option\u0027, \u0027netboot\u0027, \u0027deploy\u0027)"},{"line_number":693,"context_line":"        self.node.provision_state \u003d states.DEPLOYING"},{"line_number":694,"context_line":"        self.node.save()"},{"line_number":695,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a57fde8_df094733","line":692,"range":{"start_line":692,"start_character":8,"end_line":692,"end_character":16},"updated":"2017-01-12 20:00:58.000000000","message":"ugh, ironic.CONF please :)","commit_id":"1b5799c29b648130e817c717ec0add5851ea14d4"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"deaea2ce5acc975795ac73b2a6587be72af4de5f","unresolved":false,"context_lines":[{"line_number":689,"context_line":"                       autospec\u003dTrue)"},{"line_number":690,"context_line":"    def test_prepare_whole_disk_image_uefi(self, prepare_node_for_deploy_mock,"},{"line_number":691,"context_line":"                                           pxe_prepare_mock):"},{"line_number":692,"context_line":"        cfg.CONF.set_override(\u0027default_boot_option\u0027, \u0027netboot\u0027, \u0027deploy\u0027)"},{"line_number":693,"context_line":"        self.node.provision_state \u003d states.DEPLOYING"},{"line_number":694,"context_line":"        self.node.save()"},{"line_number":695,"context_line":"        with task_manager.acquire(self.context, self.node.uuid,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a3c09a3_1141180c","line":692,"range":{"start_line":692,"start_character":8,"end_line":692,"end_character":16},"in_reply_to":"9a57fde8_df094733","updated":"2017-01-13 10:02:21.000000000","message":"Ouch, indeed. I will put a new patch-set fixing this heh","commit_id":"1b5799c29b648130e817c717ec0add5851ea14d4"}]}