)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5fc44a66deda50723c48f673e5ee25c1e2801f0c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sofiia Andriichenko \u003csandriichenko@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-09 12:18:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This adds a tempest tests for creating a node:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* test_create_node_uuid"},{"line_number":10,"context_line":"* test_create_node_name"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa31d9ce_68aa1b72","line":7,"updated":"2017-02-13 11:49:18.000000000","message":"Similar comment as on your other patch, please don\u0027t add punctuation on the end of commit title","commit_id":"01e1727a1cd282e4b01f359a9a1026f02019ba6b"},{"author":{"_account_id":20675,"name":"Sofiia Andriichenko","email":"sofiia.andriichenko@gmail.com","username":"SofiiaAndriichenko"},"change_message_id":"01d523f13664bdfe279f704810162780434698b4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sofiia Andriichenko \u003csandriichenko@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-09 12:18:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"This adds a tempest tests for creating a node:"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* test_create_node_uuid"},{"line_number":10,"context_line":"* test_create_node_name"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa31d9ce_3eac4135","line":7,"in_reply_to":"fa31d9ce_68aa1b72","updated":"2017-02-16 10:17:54.000000000","message":"Done","commit_id":"01e1727a1cd282e4b01f359a9a1026f02019ba6b"}],"ironic_tempest_plugin/services/baremetal/v1/json/baremetal_client.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a3f65a31996b7357d82cd94ad3e3bf44410f9b5d","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                               \u0027memory_mb\u0027: kwargs.get(\u0027memory_mb\u0027, 4096)},"},{"line_number":143,"context_line":"                \u0027driver\u0027: kwargs.get(\u0027driver\u0027, \u0027fake\u0027)}"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        skipped_args \u003d [\u0027cpu_arch\u0027, \u0027cpus\u0027, \u0027local_gb\u0027,"},{"line_number":146,"context_line":"                        \u0027memory_mb\u0027, \u0027driver\u0027, \u0027chassis_uuid\u0027]"},{"line_number":147,"context_line":"        for arg in kwargs:"},{"line_number":148,"context_line":"            if arg in skipped_args:"},{"line_number":149,"context_line":"                continue"},{"line_number":150,"context_line":"            node.update({arg: kwargs.get(arg)})"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a3905b3_e60a2d78","line":147,"range":{"start_line":145,"start_character":0,"end_line":147,"end_character":26},"updated":"2017-01-24 16:03:18.000000000","message":"Instead of skipping it, you could pop the values before so that it won\u0027t be included in the list afterwards. E.g:\n\n node \u003d {...\n        \u0027driver\u0027: kwargs.pop(\u0027driver\u0027, \u0027fake\u0027)}\n\n if kwargs:\n     node.update(kwargs)","commit_id":"a20e892283d977092b37694c74a6f3095c66a066"},{"author":{"_account_id":20675,"name":"Sofiia Andriichenko","email":"sofiia.andriichenko@gmail.com","username":"SofiiaAndriichenko"},"change_message_id":"da706a64e1712f07b9b4d36263af5b39b628709c","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                               \u0027memory_mb\u0027: kwargs.get(\u0027memory_mb\u0027, 4096)},"},{"line_number":143,"context_line":"                \u0027driver\u0027: kwargs.get(\u0027driver\u0027, \u0027fake\u0027)}"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        skipped_args \u003d [\u0027cpu_arch\u0027, \u0027cpus\u0027, \u0027local_gb\u0027,"},{"line_number":146,"context_line":"                        \u0027memory_mb\u0027, \u0027driver\u0027, \u0027chassis_uuid\u0027]"},{"line_number":147,"context_line":"        for arg in kwargs:"},{"line_number":148,"context_line":"            if arg in skipped_args:"},{"line_number":149,"context_line":"                continue"},{"line_number":150,"context_line":"            node.update({arg: kwargs.get(arg)})"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a430d35_8528ac34","line":147,"range":{"start_line":145,"start_character":0,"end_line":147,"end_character":26},"in_reply_to":"5a3905b3_e60a2d78","updated":"2017-02-08 15:35:33.000000000","message":"Done","commit_id":"a20e892283d977092b37694c74a6f3095c66a066"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5fc44a66deda50723c48f673e5ee25c1e2801f0c","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    def create_node(self, chassis_id\u003dNone, **kwargs):"},{"line_number":127,"context_line":"        \"\"\"Create a baremetal node with the specified parameters."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param chassis_id: The unique identifier of the chassis."},{"line_number":130,"context_line":"        :param cpu_arch: CPU architecture of the node. Default: x86_64."},{"line_number":131,"context_line":"        :param cpus: Number of CPUs. Default: 8."},{"line_number":132,"context_line":"        :param local_gb: Disk size. Default: 1024."},{"line_number":133,"context_line":"        :param memory_mb: Available RAM. Default: 4096."},{"line_number":134,"context_line":"        :param driver: Driver name. Default: \"fake\""},{"line_number":135,"context_line":"        :return: A tuple with the server response and the created node."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa31d9ce_c8422710","line":134,"range":{"start_line":129,"start_character":8,"end_line":134,"end_character":51},"updated":"2017-02-13 11:49:18.000000000","message":"Would be good to mention that we can pass other stuff now, maybe like the following:\n\n :param kwargs: A dictionary of parameters the node will\n   be created with. The following keys have a default\n   value - cpu_arch (CPU architecture of the node,\n   default: x86_64), ...","commit_id":"01e1727a1cd282e4b01f359a9a1026f02019ba6b"},{"author":{"_account_id":20675,"name":"Sofiia Andriichenko","email":"sofiia.andriichenko@gmail.com","username":"SofiiaAndriichenko"},"change_message_id":"01d523f13664bdfe279f704810162780434698b4","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    def create_node(self, chassis_id\u003dNone, **kwargs):"},{"line_number":127,"context_line":"        \"\"\"Create a baremetal node with the specified parameters."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param chassis_id: The unique identifier of the chassis."},{"line_number":130,"context_line":"        :param cpu_arch: CPU architecture of the node. Default: x86_64."},{"line_number":131,"context_line":"        :param cpus: Number of CPUs. Default: 8."},{"line_number":132,"context_line":"        :param local_gb: Disk size. Default: 1024."},{"line_number":133,"context_line":"        :param memory_mb: Available RAM. Default: 4096."},{"line_number":134,"context_line":"        :param driver: Driver name. Default: \"fake\""},{"line_number":135,"context_line":"        :return: A tuple with the server response and the created node."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa31d9ce_909e2305","line":134,"range":{"start_line":129,"start_character":8,"end_line":134,"end_character":51},"in_reply_to":"fa31d9ce_c8422710","updated":"2017-02-16 10:17:54.000000000","message":"Done","commit_id":"01e1727a1cd282e4b01f359a9a1026f02019ba6b"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"db171a0b42c46bb3b6515ce4f8587530f7ecb328","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        return self._show_request(\u0027drivers\u0027, driver_name)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @base.handle_errors"},{"line_number":126,"context_line":"    def create_node(self, chassis_id\u003dNone, **kwargs):"},{"line_number":127,"context_line":"        \"\"\"Create a baremetal node with the specified parameters."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param chassis_id: The unique identifier of the chassis."}],"source_content_type":"text/x-python","patch_set":7,"id":"fa31d9ce_6508ab92","line":126,"updated":"2017-02-17 13:55:02.000000000","message":"wondered if we could refactor this a bit. We passing exact properties keys in kwargs directly might be pass whole \u0027properties\u0027 dict as single key?","commit_id":"0f57265c15d6e1e109e74b7fc94298eb28a381eb"},{"author":{"_account_id":20675,"name":"Sofiia Andriichenko","email":"sofiia.andriichenko@gmail.com","username":"SofiiaAndriichenko"},"change_message_id":"4144fcb77c56402310324293aa1fdc8767b0815c","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        return self._show_request(\u0027drivers\u0027, driver_name)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @base.handle_errors"},{"line_number":126,"context_line":"    def create_node(self, chassis_id\u003dNone, **kwargs):"},{"line_number":127,"context_line":"        \"\"\"Create a baremetal node with the specified parameters."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param chassis_id: The unique identifier of the chassis."}],"source_content_type":"text/x-python","patch_set":7,"id":"ba2be162_99e86ee4","line":126,"in_reply_to":"fa31d9ce_6508ab92","updated":"2017-03-02 15:32:05.000000000","message":"Done","commit_id":"0f57265c15d6e1e109e74b7fc94298eb28a381eb"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"0c0d483a48047c0cc6ea538ba412b295c6381c59","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        \"\"\"Create a baremetal node with the specified parameters."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param chassis_id: The unique identifier of the chassis."},{"line_number":130,"context_line":"        :param cpu_arch: CPU architecture of the node. Default: x86_64."},{"line_number":131,"context_line":"        :param cpus: Number of CPUs. Default: 8."},{"line_number":132,"context_line":"        :param local_gb: Disk size. Default: 1024."},{"line_number":133,"context_line":"        :param memory_mb: Available RAM. Default: 4096."},{"line_number":134,"context_line":"        :param driver: Driver name. Default: \"fake\""},{"line_number":135,"context_line":"        :param kwargs: A dictionary of parameters the node will"},{"line_number":136,"context_line":"         be created with. The following keys have a default"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa31d9ce_04e1eafe","line":133,"range":{"start_line":130,"start_character":8,"end_line":133,"end_character":55},"updated":"2017-02-16 10:39:19.000000000","message":"I meant adding kwargs description instead of these, not in addition :)","commit_id":"0f57265c15d6e1e109e74b7fc94298eb28a381eb"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"249f94ff5bd996d4d3e5bdcbbc79698300744952","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        \"\"\"Create a baremetal node with the specified parameters."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param chassis_id: The unique identifier of the chassis."},{"line_number":130,"context_line":"        :param cpu_arch: CPU architecture of the node. Default: x86_64."},{"line_number":131,"context_line":"        :param cpus: Number of CPUs. Default: 8."},{"line_number":132,"context_line":"        :param local_gb: Disk size. Default: 1024."},{"line_number":133,"context_line":"        :param memory_mb: Available RAM. Default: 4096."},{"line_number":134,"context_line":"        :param driver: Driver name. Default: \"fake\""},{"line_number":135,"context_line":"        :param kwargs: A dictionary of parameters the node will"},{"line_number":136,"context_line":"         be created with. The following keys have a default"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa31d9ce_a05e4310","line":133,"range":{"start_line":130,"start_character":8,"end_line":133,"end_character":55},"in_reply_to":"fa31d9ce_04e1eafe","updated":"2017-02-16 13:08:10.000000000","message":"Agree, please remove these params.","commit_id":"0f57265c15d6e1e109e74b7fc94298eb28a381eb"},{"author":{"_account_id":20675,"name":"Sofiia Andriichenko","email":"sofiia.andriichenko@gmail.com","username":"SofiiaAndriichenko"},"change_message_id":"4144fcb77c56402310324293aa1fdc8767b0815c","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        \"\"\"Create a baremetal node with the specified parameters."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param chassis_id: The unique identifier of the chassis."},{"line_number":130,"context_line":"        :param cpu_arch: CPU architecture of the node. Default: x86_64."},{"line_number":131,"context_line":"        :param cpus: Number of CPUs. Default: 8."},{"line_number":132,"context_line":"        :param local_gb: Disk size. Default: 1024."},{"line_number":133,"context_line":"        :param memory_mb: Available RAM. Default: 4096."},{"line_number":134,"context_line":"        :param driver: Driver name. Default: \"fake\""},{"line_number":135,"context_line":"        :param kwargs: A dictionary of parameters the node will"},{"line_number":136,"context_line":"         be created with. The following keys have a default"}],"source_content_type":"text/x-python","patch_set":7,"id":"da36d5c6_94d6cec3","line":133,"range":{"start_line":130,"start_character":8,"end_line":133,"end_character":55},"in_reply_to":"fa31d9ce_04e1eafe","updated":"2017-03-02 15:32:05.000000000","message":"Done","commit_id":"0f57265c15d6e1e109e74b7fc94298eb28a381eb"},{"author":{"_account_id":20675,"name":"Sofiia Andriichenko","email":"sofiia.andriichenko@gmail.com","username":"SofiiaAndriichenko"},"change_message_id":"4144fcb77c56402310324293aa1fdc8767b0815c","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        \"\"\"Create a baremetal node with the specified parameters."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param chassis_id: The unique identifier of the chassis."},{"line_number":130,"context_line":"        :param cpu_arch: CPU architecture of the node. Default: x86_64."},{"line_number":131,"context_line":"        :param cpus: Number of CPUs. Default: 8."},{"line_number":132,"context_line":"        :param local_gb: Disk size. Default: 1024."},{"line_number":133,"context_line":"        :param memory_mb: Available RAM. Default: 4096."},{"line_number":134,"context_line":"        :param driver: Driver name. Default: \"fake\""},{"line_number":135,"context_line":"        :param kwargs: A dictionary of parameters the node will"},{"line_number":136,"context_line":"         be created with. The following keys have a default"}],"source_content_type":"text/x-python","patch_set":7,"id":"da36d5c6_b4dbd2ec","line":133,"range":{"start_line":130,"start_character":8,"end_line":133,"end_character":55},"in_reply_to":"fa31d9ce_a05e4310","updated":"2017-03-02 15:32:05.000000000","message":"Done","commit_id":"0f57265c15d6e1e109e74b7fc94298eb28a381eb"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"249f94ff5bd996d4d3e5bdcbbc79698300744952","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        :param cpus: Number of CPUs. Default: 8."},{"line_number":132,"context_line":"        :param local_gb: Disk size. Default: 1024."},{"line_number":133,"context_line":"        :param memory_mb: Available RAM. Default: 4096."},{"line_number":134,"context_line":"        :param driver: Driver name. Default: \"fake\""},{"line_number":135,"context_line":"        :param kwargs: A dictionary of parameters the node will"},{"line_number":136,"context_line":"         be created with. The following keys have a default"},{"line_number":137,"context_line":"         value - cpu_arch (CPU architecture of the node,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa31d9ce_e0859b59","line":134,"range":{"start_line":134,"start_character":8,"end_line":134,"end_character":51},"updated":"2017-02-16 13:08:10.000000000","message":"ditto","commit_id":"0f57265c15d6e1e109e74b7fc94298eb28a381eb"},{"author":{"_account_id":20675,"name":"Sofiia Andriichenko","email":"sofiia.andriichenko@gmail.com","username":"SofiiaAndriichenko"},"change_message_id":"4144fcb77c56402310324293aa1fdc8767b0815c","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        :param cpus: Number of CPUs. Default: 8."},{"line_number":132,"context_line":"        :param local_gb: Disk size. Default: 1024."},{"line_number":133,"context_line":"        :param memory_mb: Available RAM. Default: 4096."},{"line_number":134,"context_line":"        :param driver: Driver name. Default: \"fake\""},{"line_number":135,"context_line":"        :param kwargs: A dictionary of parameters the node will"},{"line_number":136,"context_line":"         be created with. The following keys have a default"},{"line_number":137,"context_line":"         value - cpu_arch (CPU architecture of the node,"}],"source_content_type":"text/x-python","patch_set":7,"id":"da36d5c6_d4d846f2","line":134,"range":{"start_line":134,"start_character":8,"end_line":134,"end_character":51},"in_reply_to":"fa31d9ce_e0859b59","updated":"2017-03-02 15:32:05.000000000","message":"Done","commit_id":"0f57265c15d6e1e109e74b7fc94298eb28a381eb"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"caf471d620c85f5f85ad50ea5118917750a811f8","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        return self._show_request(\u0027drivers\u0027, driver_name)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @base.handle_errors"},{"line_number":126,"context_line":"    def create_node(self, chassis_id\u003dNone, properties\u003dNone, **kwargs):"},{"line_number":127,"context_line":"        \"\"\"Create a baremetal node with the specified parameters."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param chassis_id: The unique identifier of the chassis."}],"source_content_type":"text/x-python","patch_set":8,"id":"ba2be162_089de309","line":126,"range":{"start_line":126,"start_character":43,"end_line":126,"end_character":68},"updated":"2017-03-03 09:40:53.000000000","message":"I think we can remove the properties param here.\nBoth properties and kwargs are same, so we can use kwargs same as the old code.\n\nCan you please explain the need of this change?","commit_id":"e3c02c3c001a6a029c0870088ff10133de8802ea"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"0b415af9e26cdda1867c98246e983294a528f50c","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        return self._show_request(\u0027drivers\u0027, driver_name)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @base.handle_errors"},{"line_number":126,"context_line":"    def create_node(self, chassis_id\u003dNone, properties\u003dNone, **kwargs):"},{"line_number":127,"context_line":"        \"\"\"Create a baremetal node with the specified parameters."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param chassis_id: The unique identifier of the chassis."}],"source_content_type":"text/x-python","patch_set":8,"id":"ffe62b97_7d4a42ac","line":126,"range":{"start_line":126,"start_character":43,"end_line":126,"end_character":68},"in_reply_to":"ba2be162_089de309","updated":"2017-03-28 09:54:06.000000000","message":"This is done for logical separation of the arguments. properties is a separate field in the node, and it contains things like cpu_arch etc. I think we should remove the L146-150 and only use properties. other stuff like \u0027driver\u0027 can still remain in kwargs.","commit_id":"e3c02c3c001a6a029c0870088ff10133de8802ea"},{"author":{"_account_id":20675,"name":"Sofiia Andriichenko","email":"sofiia.andriichenko@gmail.com","username":"SofiiaAndriichenko"},"change_message_id":"d169b3f106d1ca657023e2ecf5aa41f50af3dbbe","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        return self._show_request(\u0027drivers\u0027, driver_name)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @base.handle_errors"},{"line_number":126,"context_line":"    def create_node(self, chassis_id\u003dNone, properties\u003dNone, **kwargs):"},{"line_number":127,"context_line":"        \"\"\"Create a baremetal node with the specified parameters."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param chassis_id: The unique identifier of the chassis."}],"source_content_type":"text/x-python","patch_set":8,"id":"ffe62b97_31447a1b","line":126,"range":{"start_line":126,"start_character":43,"end_line":126,"end_character":68},"in_reply_to":"ffe62b97_7d4a42ac","updated":"2017-03-30 11:29:55.000000000","message":"Done","commit_id":"e3c02c3c001a6a029c0870088ff10133de8802ea"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"56719dacec2884fd4b56ffdd40df0b68b5a6eda2","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        node \u003d {\u0027chassis_uuid\u0027: chassis_id,"},{"line_number":141,"context_line":"                \u0027driver\u0027: kwargs.pop(\u0027driver\u0027, \u0027fake\u0027)}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        if properties:"},{"line_number":144,"context_line":"            node.update(properties\u003dproperties)"},{"line_number":145,"context_line":"        else:"},{"line_number":146,"context_line":"            node.update("},{"line_number":147,"context_line":"                properties\u003d{\u0027cpu_arch\u0027: kwargs.pop(\u0027cpu_arch\u0027, \u0027x86_64\u0027),"},{"line_number":148,"context_line":"                            \u0027cpus\u0027: kwargs.pop(\u0027cpus\u0027, 8),"},{"line_number":149,"context_line":"                            \u0027local_gb\u0027: kwargs.pop(\u0027local_gb\u0027, 1024),"},{"line_number":150,"context_line":"                            \u0027memory_mb\u0027: kwargs.pop(\u0027memory_mb\u0027, 4096)})"},{"line_number":151,"context_line":"        if kwargs:"},{"line_number":152,"context_line":"            node.update(kwargs)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        return self._create_request(\u0027nodes\u0027, node)"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ffe62b97_147f8815","line":152,"range":{"start_line":143,"start_character":8,"end_line":152,"end_character":31},"updated":"2017-03-28 12:47:37.000000000","message":"So then just simply:\n\nnode.update(properties)\n\n**kwargs parameters are not supposed to contain cpu_arch etc.","commit_id":"e3c02c3c001a6a029c0870088ff10133de8802ea"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"8e006bd8e5b29ca6b78ae295cecc0a6c5bfff433","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        node \u003d {\u0027chassis_uuid\u0027: chassis_id,"},{"line_number":141,"context_line":"                \u0027driver\u0027: kwargs.pop(\u0027driver\u0027, \u0027fake\u0027)}"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        if properties:"},{"line_number":144,"context_line":"            node.update(properties\u003dproperties)"},{"line_number":145,"context_line":"        else:"},{"line_number":146,"context_line":"            node.update("},{"line_number":147,"context_line":"                properties\u003d{\u0027cpu_arch\u0027: kwargs.pop(\u0027cpu_arch\u0027, \u0027x86_64\u0027),"},{"line_number":148,"context_line":"                            \u0027cpus\u0027: kwargs.pop(\u0027cpus\u0027, 8),"},{"line_number":149,"context_line":"                            \u0027local_gb\u0027: kwargs.pop(\u0027local_gb\u0027, 1024),"},{"line_number":150,"context_line":"                            \u0027memory_mb\u0027: kwargs.pop(\u0027memory_mb\u0027, 4096)})"},{"line_number":151,"context_line":"        if kwargs:"},{"line_number":152,"context_line":"            node.update(kwargs)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        return self._create_request(\u0027nodes\u0027, node)"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ffe62b97_54ce302d","line":152,"range":{"start_line":143,"start_character":8,"end_line":152,"end_character":31},"in_reply_to":"ffe62b97_147f8815","updated":"2017-03-28 12:50:03.000000000","message":"Ah, for sure check if properties are not None is needed","commit_id":"e3c02c3c001a6a029c0870088ff10133de8802ea"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"a2e67238a7678a32903eccd6fc6ab358d1fc3695","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        :param properties: A dictionary of parameters the node will"},{"line_number":147,"context_line":"         be created with. The following keys have a default"},{"line_number":148,"context_line":"         value - cpu_arch (CPU architecture of the node,"},{"line_number":149,"context_line":"         default: x86_64), cpus (number of CPUs, default: 8),"},{"line_number":150,"context_line":"         local_gb (disk size, default: 1024),"},{"line_number":151,"context_line":"         memory_mb (available RAM, default: 4096),"},{"line_number":152,"context_line":"        :param kwargs: driver (driver name, default: \"fake\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"dfeb2761_dc7ae086","line":149,"updated":"2017-03-31 16:58:31.000000000","message":"there are no defaults anymore for these properties, as you just pass them as-is on L160. We need either to add the logic of dealing with defaults, or to remove the mentions of defaults from the docstring (I\u0027m fine with both whatever you prefer)","commit_id":"03ce006911dd447d960cf3c9b64b7b5546567129"},{"author":{"_account_id":20675,"name":"Sofiia Andriichenko","email":"sofiia.andriichenko@gmail.com","username":"SofiiaAndriichenko"},"change_message_id":"2d215cd969050c87c90af55c1956a12dc85a0033","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        :param properties: A dictionary of parameters the node will"},{"line_number":147,"context_line":"         be created with. The following keys have a default"},{"line_number":148,"context_line":"         value - cpu_arch (CPU architecture of the node,"},{"line_number":149,"context_line":"         default: x86_64), cpus (number of CPUs, default: 8),"},{"line_number":150,"context_line":"         local_gb (disk size, default: 1024),"},{"line_number":151,"context_line":"         memory_mb (available RAM, default: 4096),"},{"line_number":152,"context_line":"        :param kwargs: driver (driver name, default: \"fake\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"dfeb2761_f19b6bc6","line":149,"in_reply_to":"dfeb2761_dc7ae086","updated":"2017-04-03 07:37:07.000000000","message":"Done","commit_id":"03ce006911dd447d960cf3c9b64b7b5546567129"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"11dbaa1370f6864ef71e2886786c00c0eb7efb4c","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        node \u003d {\u0027chassis_uuid\u0027: chassis_id,"},{"line_number":155,"context_line":"                \u0027driver\u0027: kwargs.pop(\u0027driver\u0027, \u0027fake\u0027)}"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        if properties:"},{"line_number":158,"context_line":"            node.update(properties\u003dproperties)"},{"line_number":159,"context_line":"        if kwargs:"},{"line_number":160,"context_line":"            node.update(kwargs)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        return self._create_request(\u0027nodes\u0027, node)"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"dfeb2761_11f92f4c","line":160,"range":{"start_line":157,"start_character":0,"end_line":160,"end_character":31},"updated":"2017-04-03 07:56:00.000000000","message":"What if I have properties and kwargs at the same time?","commit_id":"bb975c2c2b6da9a995f654533257f9bc78c5c5c6"},{"author":{"_account_id":20675,"name":"Sofiia Andriichenko","email":"sofiia.andriichenko@gmail.com","username":"SofiiaAndriichenko"},"change_message_id":"83be0c77179e5c49faf2d3f5dd3bbc54945cb7ce","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        node \u003d {\u0027chassis_uuid\u0027: chassis_id,"},{"line_number":155,"context_line":"                \u0027driver\u0027: kwargs.pop(\u0027driver\u0027, \u0027fake\u0027)}"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        if properties:"},{"line_number":158,"context_line":"            node.update(properties\u003dproperties)"},{"line_number":159,"context_line":"        if kwargs:"},{"line_number":160,"context_line":"            node.update(kwargs)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        return self._create_request(\u0027nodes\u0027, node)"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"dfeb2761_ecbcaedd","line":160,"range":{"start_line":157,"start_character":0,"end_line":160,"end_character":31},"in_reply_to":"dfeb2761_11f92f4c","updated":"2017-04-03 08:10:27.000000000","message":"properties and kwargs values will be added","commit_id":"bb975c2c2b6da9a995f654533257f9bc78c5c5c6"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"b4162428faba71448706aa6ad52f96acec14bf35","unresolved":false,"context_lines":[{"line_number":149,"context_line":"         local_gb (disk size), memory_mb (available RAM),"},{"line_number":150,"context_line":"        :param kwargs: driver (driver name)"},{"line_number":151,"context_line":"        :return: A tuple with the server response and the created node."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        \"\"\""},{"line_number":154,"context_line":"        node \u003d {\u0027chassis_uuid\u0027: chassis_id,"},{"line_number":155,"context_line":"                \u0027driver\u0027: kwargs.pop(\u0027driver\u0027, \u0027fake\u0027)}"}],"source_content_type":"text/x-python","patch_set":12,"id":"dfeb2761_5c3463fb","line":152,"updated":"2017-04-03 12:46:48.000000000","message":"We don\u0027t need empty line here","commit_id":"f0c17fe497d9fdf24d9a605ac270370730e7ae18"},{"author":{"_account_id":14614,"name":"Kyrylo Romanenko","display_name":"K.Romanenko","email":"romanenko-kv@hotmail.com","username":"kromanenko"},"change_message_id":"53106deb52daca2f7b7f80b4ccf70d17167304ac","unresolved":false,"context_lines":[{"line_number":149,"context_line":"         local_gb (disk size), memory_mb (available RAM),"},{"line_number":150,"context_line":"        :param kwargs: driver (driver name)"},{"line_number":151,"context_line":"        :return: A tuple with the server response and the created node."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        \"\"\""},{"line_number":154,"context_line":"        node \u003d {\u0027chassis_uuid\u0027: chassis_id,"},{"line_number":155,"context_line":"                \u0027driver\u0027: kwargs.pop(\u0027driver\u0027, \u0027fake\u0027)}"}],"source_content_type":"text/x-python","patch_set":12,"id":"dfeb2761_068445b0","line":152,"in_reply_to":"dfeb2761_5c3463fb","updated":"2017-04-03 13:50:26.000000000","message":"Agree, but it just was here like in many other methods. I do not know why are they here.","commit_id":"f0c17fe497d9fdf24d9a605ac270370730e7ae18"}],"ironic_tempest_plugin/tests/api/admin/base.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"0c0d483a48047c0cc6ea538ba412b295c6381c59","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        :param cpus: Number of CPUs. Default: 8."},{"line_number":149,"context_line":"        :param local_gb: Disk size. Default: 10."},{"line_number":150,"context_line":"        :param memory_mb: Available RAM. Default: 4096."},{"line_number":151,"context_line":"        :return: Created node."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        \"\"\""},{"line_number":154,"context_line":"        resp, body \u003d cls.client.create_node(chassis_id, cpu_arch\u003dcpu_arch,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa31d9ce_e4977638","line":151,"updated":"2017-02-16 10:39:19.000000000","message":"same here:\n\n :param kwargs: A dictionary of parameters the node will\n                be created with.\n\nNo need to add descriptions of other arguments as they are separately described here, and are the actual arguments, not members of kwargs.","commit_id":"0f57265c15d6e1e109e74b7fc94298eb28a381eb"},{"author":{"_account_id":20675,"name":"Sofiia Andriichenko","email":"sofiia.andriichenko@gmail.com","username":"SofiiaAndriichenko"},"change_message_id":"4144fcb77c56402310324293aa1fdc8767b0815c","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        :param cpus: Number of CPUs. Default: 8."},{"line_number":149,"context_line":"        :param local_gb: Disk size. Default: 10."},{"line_number":150,"context_line":"        :param memory_mb: Available RAM. Default: 4096."},{"line_number":151,"context_line":"        :return: Created node."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        \"\"\""},{"line_number":154,"context_line":"        resp, body \u003d cls.client.create_node(chassis_id, cpu_arch\u003dcpu_arch,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba2be162_d9c9067a","line":151,"in_reply_to":"fa31d9ce_e4977638","updated":"2017-03-02 15:32:05.000000000","message":"Done","commit_id":"0f57265c15d6e1e109e74b7fc94298eb28a381eb"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"db171a0b42c46bb3b6515ce4f8587530f7ecb328","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        :param cpus: Number of CPUs. Default: 8."},{"line_number":149,"context_line":"        :param local_gb: Disk size. Default: 10."},{"line_number":150,"context_line":"        :param memory_mb: Available RAM. Default: 4096."},{"line_number":151,"context_line":"        :return: Created node."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        \"\"\""},{"line_number":154,"context_line":"        resp, body \u003d cls.client.create_node(chassis_id, cpu_arch\u003dcpu_arch,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa31d9ce_e522db00","line":151,"in_reply_to":"fa31d9ce_e4977638","updated":"2017-02-17 13:55:02.000000000","message":"It confuses that we pass 1st level parameters with properties keys in single dict, might be refactor this?","commit_id":"0f57265c15d6e1e109e74b7fc94298eb28a381eb"},{"author":{"_account_id":20675,"name":"Sofiia Andriichenko","email":"sofiia.andriichenko@gmail.com","username":"SofiiaAndriichenko"},"change_message_id":"4144fcb77c56402310324293aa1fdc8767b0815c","unresolved":false,"context_lines":[{"line_number":148,"context_line":"        :param cpus: Number of CPUs. Default: 8."},{"line_number":149,"context_line":"        :param local_gb: Disk size. Default: 10."},{"line_number":150,"context_line":"        :param memory_mb: Available RAM. Default: 4096."},{"line_number":151,"context_line":"        :return: Created node."},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        \"\"\""},{"line_number":154,"context_line":"        resp, body \u003d cls.client.create_node(chassis_id, cpu_arch\u003dcpu_arch,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba2be162_99cf8e7e","line":151,"in_reply_to":"fa31d9ce_e522db00","updated":"2017-03-02 15:32:05.000000000","message":"Done","commit_id":"0f57265c15d6e1e109e74b7fc94298eb28a381eb"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"caf471d620c85f5f85ad50ea5118917750a811f8","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    def create_node(cls, chassis_id, properties\u003dNone, **kwargs):"},{"line_number":143,"context_line":"        \"\"\"Wrapper utility for creating test baremetal nodes."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        :param properties: A dictionary of parameters the node will"},{"line_number":146,"context_line":"         be created with. The following keys have a default"},{"line_number":147,"context_line":"         value - cpu_arch (CPU architecture of the node,"},{"line_number":148,"context_line":"         default: x86_64), cpus (number of CPUs, default: 8),"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba2be162_c8de6b10","line":145,"updated":"2017-03-03 09:40:53.000000000","message":"chassis_id is missing and kwargs too","commit_id":"e3c02c3c001a6a029c0870088ff10133de8802ea"},{"author":{"_account_id":20675,"name":"Sofiia Andriichenko","email":"sofiia.andriichenko@gmail.com","username":"SofiiaAndriichenko"},"change_message_id":"d169b3f106d1ca657023e2ecf5aa41f50af3dbbe","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    def create_node(cls, chassis_id, properties\u003dNone, **kwargs):"},{"line_number":143,"context_line":"        \"\"\"Wrapper utility for creating test baremetal nodes."},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        :param properties: A dictionary of parameters the node will"},{"line_number":146,"context_line":"         be created with. The following keys have a default"},{"line_number":147,"context_line":"         value - cpu_arch (CPU architecture of the node,"},{"line_number":148,"context_line":"         default: x86_64), cpus (number of CPUs, default: 8),"}],"source_content_type":"text/x-python","patch_set":8,"id":"ffe62b97_5ca9558e","line":145,"in_reply_to":"ba2be162_c8de6b10","updated":"2017-03-30 11:29:55.000000000","message":"Done","commit_id":"e3c02c3c001a6a029c0870088ff10133de8802ea"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"f8076edd93bb10ee5bca9a311fb5ec5ef83cdea2","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        :param chassis_id: The unique identifier of the chassis."},{"line_number":169,"context_line":"        :param cpu_arch: CPU architecture of the node. Default: x86."},{"line_number":170,"context_line":"        :param cpus: Number of CPUs. Default: 8."},{"line_number":171,"context_line":"        :param local_gb: Disk size. Default: 10."},{"line_number":172,"context_line":"        :param memory_mb: Available RAM. Default: 4096."},{"line_number":173,"context_line":"        :param kwargs: additional arguments passed as parameters for node."},{"line_number":174,"context_line":"        :return: A tuple with the server response and the created node."}],"source_content_type":"text/x-python","patch_set":11,"id":"dfeb2761_519e9754","line":171,"range":{"start_line":171,"start_character":26,"end_line":171,"end_character":48},"updated":"2017-04-03 07:49:23.000000000","message":"10 or 1024 ?","commit_id":"bb975c2c2b6da9a995f654533257f9bc78c5c5c6"}],"ironic_tempest_plugin/tests/api/admin/test_nodes.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5fc44a66deda50723c48f673e5ee25c1e2801f0c","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        _, loaded_node \u003d self.client.show_node(self.node[\u0027uuid\u0027])"},{"line_number":72,"context_line":"        self._assertExpected(self.node, loaded_node)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @decorators.idempotent_id(\u00270e3664cd-aff4-4250-8bf4-b6e4005fafe5\u0027)"},{"line_number":75,"context_line":"    def test_show_node_name(self):"},{"line_number":76,"context_line":"        self.useFixture("},{"line_number":77,"context_line":"            api_microversion_fixture.APIMicroversionFixture(\u00271.5\u0027))"},{"line_number":78,"context_line":"        name \u003d \u0027tempest-test-name\u0027"},{"line_number":79,"context_line":"        _, node \u003d self.create_node(self.chassis[\u0027uuid\u0027], name\u003dname)"},{"line_number":80,"context_line":"        _, loaded_node \u003d self.client.show_node(node[\u0027name\u0027])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        self._assertExpected(node, loaded_node)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @decorators.idempotent_id(\u00274ca123c4-160d-4d8d-a3f7-15feda812263\u0027)"},{"line_number":85,"context_line":"    def test_list_nodes(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa31d9ce_68177bed","line":82,"range":{"start_line":74,"start_character":4,"end_line":82,"end_character":47},"updated":"2017-02-13 11:49:18.000000000","message":"It is not really related to this patch, and you already have a similar test added on L236, I\u0027d just drop this one.","commit_id":"01e1727a1cd282e4b01f359a9a1026f02019ba6b"},{"author":{"_account_id":20675,"name":"Sofiia Andriichenko","email":"sofiia.andriichenko@gmail.com","username":"SofiiaAndriichenko"},"change_message_id":"eb5478496eb0220317a90491dbe43a1a4fe83bf3","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        _, loaded_node \u003d self.client.show_node(self.node[\u0027uuid\u0027])"},{"line_number":72,"context_line":"        self._assertExpected(self.node, loaded_node)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    @decorators.idempotent_id(\u00270e3664cd-aff4-4250-8bf4-b6e4005fafe5\u0027)"},{"line_number":75,"context_line":"    def test_show_node_name(self):"},{"line_number":76,"context_line":"        self.useFixture("},{"line_number":77,"context_line":"            api_microversion_fixture.APIMicroversionFixture(\u00271.5\u0027))"},{"line_number":78,"context_line":"        name \u003d \u0027tempest-test-name\u0027"},{"line_number":79,"context_line":"        _, node \u003d self.create_node(self.chassis[\u0027uuid\u0027], name\u003dname)"},{"line_number":80,"context_line":"        _, loaded_node \u003d self.client.show_node(node[\u0027name\u0027])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        self._assertExpected(node, loaded_node)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @decorators.idempotent_id(\u00274ca123c4-160d-4d8d-a3f7-15feda812263\u0027)"},{"line_number":85,"context_line":"    def test_list_nodes(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa31d9ce_dc88f173","line":82,"range":{"start_line":74,"start_character":4,"end_line":82,"end_character":47},"in_reply_to":"fa31d9ce_68177bed","updated":"2017-02-14 13:14:45.000000000","message":"I agree, it isn\u0027t related to this patch, I think test_create_node_uuid different from it","commit_id":"01e1727a1cd282e4b01f359a9a1026f02019ba6b"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"5fc44a66deda50723c48f673e5ee25c1e2801f0c","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        super(TestCreateNodes, self).setUp()"},{"line_number":227,"context_line":"        _, self.chassis \u003d self.create_chassis()"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    @decorators.idempotent_id(\u002763474e42-6439-49c8-b6d9-9d51322141df\u0027)"},{"line_number":230,"context_line":"    def test_create_node_uuid(self):"},{"line_number":231,"context_line":"        uuid \u003d data_utils.rand_uuid()"},{"line_number":232,"context_line":"        _, node \u003d self.create_node(self.chassis[\u0027uuid\u0027], uuid\u003duuid)"},{"line_number":233,"context_line":"        self.assertEqual(uuid, node[\u0027uuid\u0027])"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    @decorators.idempotent_id(\u0027aededdeb-f7be-494c-9a76-e3d8cbf3a921\u0027)"},{"line_number":236,"context_line":"    def test_create_node_name(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa31d9ce_a893334e","line":233,"range":{"start_line":229,"start_character":4,"end_line":233,"end_character":44},"updated":"2017-02-13 11:49:18.000000000","message":"I also don\u0027t think it\u0027s worth adding this one, we already have tests asserting that a usual create operation works fine, but maybe this one is fine.","commit_id":"01e1727a1cd282e4b01f359a9a1026f02019ba6b"},{"author":{"_account_id":10206,"name":"Madhuri Kumari","email":"madhuri.kumari@intel.com","username":"Madhuri"},"change_message_id":"caf471d620c85f5f85ad50ea5118917750a811f8","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                      \u0027memory_mb\u0027: \u00271024\u0027}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        _, body \u003d self.create_node(self.chassis[\u0027uuid\u0027], properties\u003dproperties)"},{"line_number":58,"context_line":"        self._assertExpected(properties, body[\u0027properties\u0027])"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    @decorators.idempotent_id(\u00279ade60a4-505e-4259-9ec4-71352cbbaf47\u0027)"},{"line_number":61,"context_line":"    def test_delete_node(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba2be162_e837affc","line":58,"updated":"2017-03-03 09:40:53.000000000","message":"Can you add test to check the default values of the cpu_arch, cpus etc?","commit_id":"e3c02c3c001a6a029c0870088ff10133de8802ea"},{"author":{"_account_id":20675,"name":"Sofiia Andriichenko","email":"sofiia.andriichenko@gmail.com","username":"SofiiaAndriichenko"},"change_message_id":"d169b3f106d1ca657023e2ecf5aa41f50af3dbbe","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                      \u0027memory_mb\u0027: \u00271024\u0027}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        _, body \u003d self.create_node(self.chassis[\u0027uuid\u0027], properties\u003dproperties)"},{"line_number":58,"context_line":"        self._assertExpected(properties, body[\u0027properties\u0027])"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    @decorators.idempotent_id(\u00279ade60a4-505e-4259-9ec4-71352cbbaf47\u0027)"},{"line_number":61,"context_line":"    def test_delete_node(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ffe62b97_7779d291","line":58,"in_reply_to":"ba2be162_e837affc","updated":"2017-03-30 11:29:55.000000000","message":"This change not related for my patch","commit_id":"e3c02c3c001a6a029c0870088ff10133de8802ea"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"7239f185ede643958eb232f64330282367563bd7","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        _, loaded_node \u003d self.client.show_node(self.node[\u0027uuid\u0027])"},{"line_number":65,"context_line":"        self._assertExpected(self.node, loaded_node)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @decorators.idempotent_id(\u00270e3664cd-aff4-4250-8bf4-b6e4005fafe5\u0027)"},{"line_number":68,"context_line":"    def test_show_node_name(self):"},{"line_number":69,"context_line":"        self.useFixture("},{"line_number":70,"context_line":"            api_microversion_fixture.APIMicroversionFixture(\u00271.5\u0027))"},{"line_number":71,"context_line":"        name \u003d \u0027tempest-test-name\u0027"},{"line_number":72,"context_line":"        _, node \u003d self.create_node(self.chassis[\u0027uuid\u0027], name\u003dname)"},{"line_number":73,"context_line":"        _, loaded_node \u003d self.client.show_node(node[\u0027name\u0027])"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        self._assertExpected(node, loaded_node)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @decorators.idempotent_id(\u00274ca123c4-160d-4d8d-a3f7-15feda812263\u0027)"},{"line_number":78,"context_line":"    def test_list_nodes(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"dfeb2761_b183a3cc","line":75,"range":{"start_line":67,"start_character":0,"end_line":75,"end_character":47},"updated":"2017-04-03 07:54:50.000000000","message":"You can add this check to the test `test_show_node`","commit_id":"bb975c2c2b6da9a995f654533257f9bc78c5c5c6"},{"author":{"_account_id":20675,"name":"Sofiia Andriichenko","email":"sofiia.andriichenko@gmail.com","username":"SofiiaAndriichenko"},"change_message_id":"83be0c77179e5c49faf2d3f5dd3bbc54945cb7ce","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        _, loaded_node \u003d self.client.show_node(self.node[\u0027uuid\u0027])"},{"line_number":65,"context_line":"        self._assertExpected(self.node, loaded_node)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @decorators.idempotent_id(\u00270e3664cd-aff4-4250-8bf4-b6e4005fafe5\u0027)"},{"line_number":68,"context_line":"    def test_show_node_name(self):"},{"line_number":69,"context_line":"        self.useFixture("},{"line_number":70,"context_line":"            api_microversion_fixture.APIMicroversionFixture(\u00271.5\u0027))"},{"line_number":71,"context_line":"        name \u003d \u0027tempest-test-name\u0027"},{"line_number":72,"context_line":"        _, node \u003d self.create_node(self.chassis[\u0027uuid\u0027], name\u003dname)"},{"line_number":73,"context_line":"        _, loaded_node \u003d self.client.show_node(node[\u0027name\u0027])"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        self._assertExpected(node, loaded_node)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    @decorators.idempotent_id(\u00274ca123c4-160d-4d8d-a3f7-15feda812263\u0027)"},{"line_number":78,"context_line":"    def test_list_nodes(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"dfeb2761_2c9f3660","line":75,"range":{"start_line":67,"start_character":0,"end_line":75,"end_character":47},"in_reply_to":"dfeb2761_b183a3cc","updated":"2017-04-03 08:10:27.000000000","message":"I don\u0027t agree with you, it should be two different tests","commit_id":"bb975c2c2b6da9a995f654533257f9bc78c5c5c6"},{"author":{"_account_id":17270,"name":"Sergii Turivnyi","email":"sturivnyi@mirantis.com","username":"sturivnyi"},"change_message_id":"7239f185ede643958eb232f64330282367563bd7","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        self.assertEqual(name, node[\u0027name\u0027])"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    @decorators.idempotent_id(\u0027cdd1eec2-6699-413c-ad95-d80cfa3a691c\u0027)"},{"line_number":297,"context_line":"    def test_create_node_maintenance(self):"},{"line_number":298,"context_line":"        maintenance \u003d True"},{"line_number":299,"context_line":"        _, node \u003d self.create_node(self.chassis[\u0027uuid\u0027],"},{"line_number":300,"context_line":"                                   maintenance\u003dmaintenance)"}],"source_content_type":"text/x-python","patch_set":11,"id":"dfeb2761_d1caa718","line":297,"range":{"start_line":297,"start_character":8,"end_line":297,"end_character":36},"updated":"2017-04-03 07:54:50.000000000","message":"This test is not clear for me. What are you trying to check?","commit_id":"bb975c2c2b6da9a995f654533257f9bc78c5c5c6"},{"author":{"_account_id":20675,"name":"Sofiia Andriichenko","email":"sofiia.andriichenko@gmail.com","username":"SofiiaAndriichenko"},"change_message_id":"11e6cf794b188b79973bc9618c46965b649d3e1a","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        self.assertEqual(name, node[\u0027name\u0027])"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    @decorators.idempotent_id(\u0027cdd1eec2-6699-413c-ad95-d80cfa3a691c\u0027)"},{"line_number":297,"context_line":"    def test_create_node_maintenance(self):"},{"line_number":298,"context_line":"        maintenance \u003d True"},{"line_number":299,"context_line":"        _, node \u003d self.create_node(self.chassis[\u0027uuid\u0027],"},{"line_number":300,"context_line":"                                   maintenance\u003dmaintenance)"}],"source_content_type":"text/x-python","patch_set":11,"id":"dfeb2761_672e78fb","line":297,"range":{"start_line":297,"start_character":8,"end_line":297,"end_character":36},"in_reply_to":"dfeb2761_d1caa718","updated":"2017-04-03 09:15:49.000000000","message":"I check node can be created in maintenance","commit_id":"bb975c2c2b6da9a995f654533257f9bc78c5c5c6"}]}