)]}'
{"devstack/lib/ironic":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b01f0e66c087c0585318662b01b3b8c00cf0d7f7","unresolved":false,"context_lines":[{"line_number":522,"context_line":"    port_config\u003d()"},{"line_number":523,"context_line":"    for vm_name in $(_ironic_bm_vm_names); do"},{"line_number":524,"context_line":"        port_config+\u003d(\"${pdu_port_number}:${vm_name}\")"},{"line_number":525,"context_line":"        $(( pdu_port_number++ ))"},{"line_number":526,"context_line":"    done"},{"line_number":527,"context_line":"    echo ${port_config[*]} | tr \u0027 \u0027 \u0027,\u0027"},{"line_number":528,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a6eadb0_5c035fb8","line":525,"range":{"start_line":525,"start_character":8,"end_line":525,"end_character":9},"updated":"2016-12-20 09:59:46.000000000","message":"So, this works but it gives me an error in the local test where the previous syntax was fine:\n\n~$ test\u003d1\n\n~$ $(( test++ ))\nbash: 1: command not found\n~$ echo $test\n2\n\n~$ (( test++ ))\n~$ echo $test\n3\n\n...\n\nHere\u0027s how I think we should do it:\n\n~$ test\u003d$(( test + 1 ))\n~$ echo $test\n4","commit_id":"cf32308cac4fc1bbbbe39984fc5dd9d336171600"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e3b382591b902756519f9959966e1f4b7b53747d","unresolved":false,"context_lines":[{"line_number":522,"context_line":"    port_config\u003d()"},{"line_number":523,"context_line":"    for vm_name in $(_ironic_bm_vm_names); do"},{"line_number":524,"context_line":"        port_config+\u003d(\"${pdu_port_number}:${vm_name}\")"},{"line_number":525,"context_line":"        $(( pdu_port_number++ ))"},{"line_number":526,"context_line":"    done"},{"line_number":527,"context_line":"    echo ${port_config[*]} | tr \u0027 \u0027 \u0027,\u0027"},{"line_number":528,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a6eadb0_42e29a02","line":525,"range":{"start_line":525,"start_character":8,"end_line":525,"end_character":9},"in_reply_to":"1a6eadb0_420e1a33","updated":"2016-12-20 10:29:19.000000000","message":"What about the suggestion of doing:\n\ntest\u003d$(( test + 1 ))\n\n...\n\nlucas@lucas-t460s tmp]$ cat increment.sh \ncounter\u003d1\nlist\u003d()\nfor name in a b c; do\n    list+\u003d(\"${counter}:${name}\")\n    counter\u003d$(( counter + 1 ))\ndone\necho ${list[*]}\n[lucas@lucas-t460s tmp]$ sh increment.sh \n1:a 2:b 3:c\n\nAnd bashate is happy too:\n\n(venv) [lucas@lucas-t460s tmp]$ bashate increment.sh \n(venv) [lucas@lucas-t460s tmp]$","commit_id":"cf32308cac4fc1bbbbe39984fc5dd9d336171600"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"71870b1f16c9028dcb880b7e861556ec188ebef4","unresolved":false,"context_lines":[{"line_number":522,"context_line":"    port_config\u003d()"},{"line_number":523,"context_line":"    for vm_name in $(_ironic_bm_vm_names); do"},{"line_number":524,"context_line":"        port_config+\u003d(\"${pdu_port_number}:${vm_name}\")"},{"line_number":525,"context_line":"        $(( pdu_port_number++ ))"},{"line_number":526,"context_line":"    done"},{"line_number":527,"context_line":"    echo ${port_config[*]} | tr \u0027 \u0027 \u0027,\u0027"},{"line_number":528,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"1a6eadb0_420e1a33","line":525,"range":{"start_line":525,"start_character":8,"end_line":525,"end_character":9},"in_reply_to":"1a6eadb0_5c035fb8","updated":"2016-12-20 10:23:36.000000000","message":"for me it still works, but produces errors\n\n  $ cat increment.sh \n  counter\u003d1\n  list\u003d()\n  for name in a b c; do\n      list+\u003d(\"${counter}:${name}\")\n      $(( counter++ ))\n  done\n  echo ${list[*]}\n  $ bash increment.sh\n  increment.sh: line 5: 1: command not found\n  increment.sh: line 5: 2: command not found\n  increment.sh: line 5: 3: command not found\n  1:a 2:b 3:c\n\nchanging $.. to `..` does the trick, and bashate is happy","commit_id":"cf32308cac4fc1bbbbe39984fc5dd9d336171600"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a2599900b126e0ce37875f3f1272a5a8321cad1b","unresolved":false,"context_lines":[{"line_number":522,"context_line":"    port_config\u003d()"},{"line_number":523,"context_line":"    for vm_name in $(_ironic_bm_vm_names); do"},{"line_number":524,"context_line":"        port_config+\u003d(\"${pdu_port_number}:${vm_name}\")"},{"line_number":525,"context_line":"        `(( pdu_port_number++ ))`"},{"line_number":526,"context_line":"    done"},{"line_number":527,"context_line":"    echo ${port_config[*]} | tr \u0027 \u0027 \u0027,\u0027"},{"line_number":528,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1a6eadb0_42d8da7f","line":525,"updated":"2016-12-20 10:30:45.000000000","message":"Backticks didn\u0027t work here:\n\n[lucas@lucas-t460s]$ test\u003d1\n[lucas@lucas-t460s]$ echo $test\n1\n[lucas@lucas-t460s]$ `(( test++ ))`\n[lucas@lucas-t460s]$ echo $test\n1\n\n...\n\nCoppying the comment from previous patch-set, what about:\n\n pdu_port_number\u003d$(( pdu_port_number + 1 ))\n\nlucas@lucas-t460s tmp]$ cat increment.sh \ncounter\u003d1\nlist\u003d()\nfor name in a b c; do\n    list+\u003d(\"${counter}:${name}\")\n    counter\u003d$(( counter + 1 ))\ndone\necho ${list[*]}\n\n[lucas@lucas-t460s tmp]$ sh increment.sh \n1:a 2:b 3:c\n\nAnd bashate is happy too:\n\n(venv) [lucas@lucas-t460s tmp]$ bashate increment.sh \n(venv) [lucas@lucas-t460s tmp]$","commit_id":"4b3712f24b9bb0f76549fba0dae3bc594831dcb9"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"b9f968ff4288abba8725ad88f2f6ee4a7affe0f7","unresolved":false,"context_lines":[{"line_number":522,"context_line":"    port_config\u003d()"},{"line_number":523,"context_line":"    for vm_name in $(_ironic_bm_vm_names); do"},{"line_number":524,"context_line":"        port_config+\u003d(\"${pdu_port_number}:${vm_name}\")"},{"line_number":525,"context_line":"        `(( pdu_port_number++ ))`"},{"line_number":526,"context_line":"    done"},{"line_number":527,"context_line":"    echo ${port_config[*]} | tr \u0027 \u0027 \u0027,\u0027"},{"line_number":528,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1a6eadb0_aa7c20b6","line":525,"in_reply_to":"1a6eadb0_42d8da7f","updated":"2016-12-20 12:40:37.000000000","message":"I think the difference is running from CLI (as you do) or from script (as I\u0027ve done in my example)\n\nBut indeed, \u0027++\u0027 is a bashism, and although we target bash explicitly, less of those might be better.","commit_id":"4b3712f24b9bb0f76549fba0dae3bc594831dcb9"}]}