)]}'
{"ironic/conf/inspector.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"c713deaa5e60d11503a3cdf2b00aae4cf045aaed","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    cfg.BoolOpt(\u0027enabled\u0027, default\u003dFalse,"},{"line_number":22,"context_line":"                help\u003d_(\u0027whether to enable inspection using ironic-inspector. \u0027"},{"line_number":23,"context_line":"                       \u0027This option does not affect new-style dynamic drivers \u0027"},{"line_number":24,"context_line":"                       \u0027and the fake_inspector driver.\u0027)),"},{"line_number":25,"context_line":"    cfg.StrOpt(\u0027service_url\u0027,"},{"line_number":26,"context_line":"               help\u003d_(\u0027ironic-inspector HTTP endpoint. If this is not set, \u0027"},{"line_number":27,"context_line":"                      \u0027the service catalog will be used.\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a57fde8_f45d57ed","line":24,"updated":"2017-01-12 17:44:52.000000000","message":"Shouldn\u0027t this be in a release note as well, so operators with this already set will know it\u0027s no longer effective?","commit_id":"cc303d908b7db896f18f9f6d3e8a110b4b20da3e"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e7931bd610f5ecca2eb8fa6edb3d620cafc5d414","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    cfg.BoolOpt(\u0027enabled\u0027, default\u003dFalse,"},{"line_number":22,"context_line":"                help\u003d_(\u0027whether to enable inspection using ironic-inspector. \u0027"},{"line_number":23,"context_line":"                       \u0027This option does not affect new-style dynamic drivers \u0027"},{"line_number":24,"context_line":"                       \u0027and the fake_inspector driver.\u0027)),"},{"line_number":25,"context_line":"    cfg.StrOpt(\u0027service_url\u0027,"},{"line_number":26,"context_line":"               help\u003d_(\u0027ironic-inspector HTTP endpoint. If this is not set, \u0027"},{"line_number":27,"context_line":"                      \u0027the service catalog will be used.\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a3c09a3_917f3aaa","line":24,"in_reply_to":"9a57fde8_74b0878c","updated":"2017-01-17 13:05:07.000000000","message":"Well, the comment about fake_inspector is definitely valid, and I think we can add a comment about new-style drivers a bit in advance. Will update the release note.","commit_id":"cc303d908b7db896f18f9f6d3e8a110b4b20da3e"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"1dc6561c32ecd0e3b907569a54d996bf32eee49b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    cfg.BoolOpt(\u0027enabled\u0027, default\u003dFalse,"},{"line_number":22,"context_line":"                help\u003d_(\u0027whether to enable inspection using ironic-inspector. \u0027"},{"line_number":23,"context_line":"                       \u0027This option does not affect new-style dynamic drivers \u0027"},{"line_number":24,"context_line":"                       \u0027and the fake_inspector driver.\u0027)),"},{"line_number":25,"context_line":"    cfg.StrOpt(\u0027service_url\u0027,"},{"line_number":26,"context_line":"               help\u003d_(\u0027ironic-inspector HTTP endpoint. If this is not set, \u0027"},{"line_number":27,"context_line":"                      \u0027the service catalog will be used.\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a57fde8_d474d3fe","line":24,"in_reply_to":"9a57fde8_94c7ab44","updated":"2017-01-12 17:57:41.000000000","message":"If this new config help text is not valid yet, it shouldn\u0027t be added yet then. Either we should notify the deployer in all places (config option + release note) or not at all, IMO.","commit_id":"cc303d908b7db896f18f9f6d3e8a110b4b20da3e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"b5f23b16f6e0c053ee11cbdbf2cd1002d5295c8d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    cfg.BoolOpt(\u0027enabled\u0027, default\u003dFalse,"},{"line_number":22,"context_line":"                help\u003d_(\u0027whether to enable inspection using ironic-inspector. \u0027"},{"line_number":23,"context_line":"                       \u0027This option does not affect new-style dynamic drivers \u0027"},{"line_number":24,"context_line":"                       \u0027and the fake_inspector driver.\u0027)),"},{"line_number":25,"context_line":"    cfg.StrOpt(\u0027service_url\u0027,"},{"line_number":26,"context_line":"               help\u003d_(\u0027ironic-inspector HTTP endpoint. If this is not set, \u0027"},{"line_number":27,"context_line":"                      \u0027the service catalog will be used.\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a57fde8_74b0878c","line":24,"in_reply_to":"9a57fde8_d474d3fe","updated":"2017-01-12 18:01:19.000000000","message":"Hm, good point.","commit_id":"cc303d908b7db896f18f9f6d3e8a110b4b20da3e"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"68076f4b6f5670a3ba9b616b9106238b29b56589","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    cfg.BoolOpt(\u0027enabled\u0027, default\u003dFalse,"},{"line_number":22,"context_line":"                help\u003d_(\u0027whether to enable inspection using ironic-inspector. \u0027"},{"line_number":23,"context_line":"                       \u0027This option does not affect new-style dynamic drivers \u0027"},{"line_number":24,"context_line":"                       \u0027and the fake_inspector driver.\u0027)),"},{"line_number":25,"context_line":"    cfg.StrOpt(\u0027service_url\u0027,"},{"line_number":26,"context_line":"               help\u003d_(\u0027ironic-inspector HTTP endpoint. If this is not set, \u0027"},{"line_number":27,"context_line":"                      \u0027the service catalog will be used.\u0027)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a57fde8_94c7ab44","line":24,"in_reply_to":"9a57fde8_f45d57ed","updated":"2017-01-12 17:53:46.000000000","message":"Not sure it makes sense to add it right now, hw types are not in hash ring yet iiuc, so you can\u0027t create a node with hw type from api.","commit_id":"cc303d908b7db896f18f9f6d3e8a110b4b20da3e"}],"ironic/drivers/modules/inspector.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b9d37b959de3305988af200d741fe6e6ae168d0d","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def _is_enabled():"},{"line_number":60,"context_line":"    return (CONF.inspector.enabled or"},{"line_number":61,"context_line":"            \u0027inspector\u0027 in CONF.enabled_inspect_interfaces)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"class Inspector(base.InspectInterface):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_249be373","line":61,"updated":"2017-01-11 08:25:02.000000000","message":"User may define custom inspect interface (or fake, which will be considered as disabled inspection at the moment) we should check here that enabled_inspect_interfaces is not equal to no-inspect.\n\nWondered if we should prohibit enabling no-inspect with any other inspec interface, it might confuse.","commit_id":"5afe9b526aafcb0bdb8991c89095a5d8c086d961"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"16c1f39d70838a063f5996508ebede159047df93","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def _is_enabled():"},{"line_number":60,"context_line":"    return (CONF.inspector.enabled or"},{"line_number":61,"context_line":"            \u0027inspector\u0027 in CONF.enabled_inspect_interfaces)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"class Inspector(base.InspectInterface):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_259596e3","line":61,"in_reply_to":"ba5201f7_249be373","updated":"2017-01-11 11:39:32.000000000","message":"I meant why we need to explicitly enable no-* interface when it actually do nothing, might be consider that no-* interfaces always enabled?","commit_id":"5afe9b526aafcb0bdb8991c89095a5d8c086d961"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"80915d4f722d5aecb8e8e19d5a1600363f82a906","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def _is_enabled():"},{"line_number":60,"context_line":"    return (CONF.inspector.enabled or"},{"line_number":61,"context_line":"            \u0027inspector\u0027 in CONF.enabled_inspect_interfaces)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"class Inspector(base.InspectInterface):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_0b30a3e7","line":61,"in_reply_to":"ba5201f7_259596e3","updated":"2017-01-11 12:00:42.000000000","message":"It\u0027s quite an unrelated discussion. no-* interfaces can be enabled and disabled, I\u0027m not sure why we should remove such ability.\n\nAs to custom interfaces... yeah, you\u0027re right, it\u0027s not a perfect idea.. I think I\u0027ll rework this patch.","commit_id":"5afe9b526aafcb0bdb8991c89095a5d8c086d961"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"68076f4b6f5670a3ba9b616b9106238b29b56589","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                         \"[inspector] enabled \u003d True.\"), driver_name)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def __init__(self):"},{"line_number":78,"context_line":"        if not CONF.inspector.enabled:"},{"line_number":79,"context_line":"            raise exception.DriverLoadError("},{"line_number":80,"context_line":"                _(\u0027ironic-inspector support is disabled\u0027))"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a57fde8_14bf3bd1","side":"PARENT","line":78,"updated":"2017-01-12 17:53:46.000000000","message":"If I understand correctly, this gets in the way as for dynamic drivers as invoke_on_load happens when stevedore loads it, would be good to clarify this in commit message.","commit_id":"c7781fccd5c13d2660bd3cdd7766183d24724489"}]}
