)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"9528ccafbfc25f299ed9b351fe8dc64bff598a9f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"the HashRing\u0027s __init__ method.  The documentation stated that the replicas"},{"line_number":14,"context_line":"argument defaulted to CONF.hash_distribution_replicas when it technically"},{"line_number":15,"context_line":"defaulted to None.  Even though replicas defaulted to None, the method logic"},{"line_number":16,"context_line":"would change it to CONF.hash_distribution_replicas if it was None."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I161183f5974686e7c92f92697b61c58fb6f77a26"},{"line_number":19,"context_line":"Closes-Bug: 1490406"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba5201f7_b7330ef5","line":16,"updated":"2017-01-06 23:17:13.000000000","message":"That is why the default is documented as CONF.hash_distribution_replicas. That is the actual default, regardless of what is in the method\u0027s argument list. It\u0027s an implementation detail. More details in my comment on the next file...","commit_id":"4974ae5cbd95bd70c370be0ac6be73d89cb9c615"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"426f2adefbf8347b263e26c9022f557011df8476","unresolved":false,"context_lines":[{"line_number":10,"context_line":"grammar.  A sentance has been reworded."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I161183f5974686e7c92f92697b61c58fb6f77a26"},{"line_number":13,"context_line":"Closes-Bug: 1490406"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba5201f7_fa2d7dfe","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":19},"updated":"2017-01-07 00:37:22.000000000","message":"Nit: Is this really the only change that applies to this bug at this point in time?  Seems more like partial to me.","commit_id":"4b4a44fe0fb857a28a5d9b78533ca0cd51f28298"},{"author":{"_account_id":24738,"name":"Peter Kendall","email":"pete@kendallp.net","username":"halprin"},"change_message_id":"15d292137bc13d65e25717b82ed878a5248fb81b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"grammar.  A sentance has been reworded."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I161183f5974686e7c92f92697b61c58fb6f77a26"},{"line_number":13,"context_line":"Closes-Bug: 1490406"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba5201f7_e3b3184b","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":19},"in_reply_to":"ba5201f7_fa2d7dfe","updated":"2017-01-07 03:58:19.000000000","message":"Correct, this is the only change that applies to the bug at this time.  The entire part of the bug about CONF.hash_distribution_replicas is not a problem.","commit_id":"4b4a44fe0fb857a28a5d9b78533ca0cd51f28298"}],"ironic/common/hash_ring.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"9528ccafbfc25f299ed9b351fe8dc64bff598a9f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      just one other host assigned to it."},{"line_number":40,"context_line":"    \"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def __init__(self, hosts, replicas\u003dCONF.hash_distribution_replicas):"},{"line_number":43,"context_line":"        \"\"\"Create a new hash ring across the specified hosts."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        :param hosts: an iterable of hosts which will be mapped."}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_d745f242","line":42,"updated":"2017-01-06 23:17:13.000000000","message":"This doesn\u0027t actually work. This file is imported before the config is loaded, and this method\u0027s arguments are parsed at import time. So, if we put this CONF option here, we always will have the default value, no matter what is in the config file.","commit_id":"4974ae5cbd95bd70c370be0ac6be73d89cb9c615"},{"author":{"_account_id":24738,"name":"Peter Kendall","email":"pete@kendallp.net","username":"halprin"},"change_message_id":"b1f1eedf5b5c9e8e5fc16c97d79064552f2aa73b","unresolved":false,"context_lines":[{"line_number":39,"context_line":"      just one other host assigned to it."},{"line_number":40,"context_line":"    \"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def __init__(self, hosts, replicas\u003dCONF.hash_distribution_replicas):"},{"line_number":43,"context_line":"        \"\"\"Create a new hash ring across the specified hosts."},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        :param hosts: an iterable of hosts which will be mapped."}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_f714b6a0","line":42,"in_reply_to":"ba5201f7_d745f242","updated":"2017-01-06 23:54:07.000000000","message":"Oh!  Thank you.  Reverted.","commit_id":"4974ae5cbd95bd70c370be0ac6be73d89cb9c615"}],"ironic/conf/default.py":[{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"9528ccafbfc25f299ed9b351fe8dc64bff598a9f","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                      \u0027A few thousand partitions should make rebalancing \u0027"},{"line_number":184,"context_line":"                      \u0027smooth in most cases. The default is suitable for up \u0027"},{"line_number":185,"context_line":"                      \u0027to a few hundred conductors. Too many partitions have \u0027"},{"line_number":186,"context_line":"                      \u0027a CPU impact.\u0027)),"},{"line_number":187,"context_line":"    cfg.IntOpt(\u0027hash_distribution_replicas\u0027,"},{"line_number":188,"context_line":"               default\u003d1,"},{"line_number":189,"context_line":"               help\u003d_(\u0027[Experimental Feature] \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_b7614ed5","line":186,"updated":"2017-01-06 23:17:13.000000000","message":"I think the old version is technically correct, though it isn\u0027t a full sentence. How about \"Configuring for too many partitions has a negative impact on CPU usage\"?","commit_id":"4974ae5cbd95bd70c370be0ac6be73d89cb9c615"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"b122387ade2337e601ab8709bec463522311e29f","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                      \u0027A few thousand partitions should make rebalancing \u0027"},{"line_number":184,"context_line":"                      \u0027smooth in most cases. The default is suitable for up \u0027"},{"line_number":185,"context_line":"                      \u0027to a few hundred conductors. Too many partitions have \u0027"},{"line_number":186,"context_line":"                      \u0027a CPU impact.\u0027)),"},{"line_number":187,"context_line":"    cfg.IntOpt(\u0027hash_distribution_replicas\u0027,"},{"line_number":188,"context_line":"               default\u003d1,"},{"line_number":189,"context_line":"               help\u003d_(\u0027[Experimental Feature] \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_8f76e303","line":186,"in_reply_to":"ba5201f7_575ca27c","updated":"2017-01-08 15:37:35.000000000","message":"Yep :)","commit_id":"4974ae5cbd95bd70c370be0ac6be73d89cb9c615"},{"author":{"_account_id":24738,"name":"Peter Kendall","email":"pete@kendallp.net","username":"halprin"},"change_message_id":"b1f1eedf5b5c9e8e5fc16c97d79064552f2aa73b","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                      \u0027A few thousand partitions should make rebalancing \u0027"},{"line_number":184,"context_line":"                      \u0027smooth in most cases. The default is suitable for up \u0027"},{"line_number":185,"context_line":"                      \u0027to a few hundred conductors. Too many partitions have \u0027"},{"line_number":186,"context_line":"                      \u0027a CPU impact.\u0027)),"},{"line_number":187,"context_line":"    cfg.IntOpt(\u0027hash_distribution_replicas\u0027,"},{"line_number":188,"context_line":"               default\u003d1,"},{"line_number":189,"context_line":"               help\u003d_(\u0027[Experimental Feature] \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba5201f7_575ca27c","line":186,"in_reply_to":"ba5201f7_b7614ed5","updated":"2017-01-06 23:54:07.000000000","message":"That sounds much better.\n\nAm I correct that because this configuration option doesn\u0027t configure the number of partitions itself, you used \"for\" in your proposed message?  I just want to make sure I understand.","commit_id":"4974ae5cbd95bd70c370be0ac6be73d89cb9c615"}]}
