)]}'
{"ironic/conductor/base_manager.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"f43181a05c3324bddae0c0b5deff12390770fa31","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        Registers a row in the database for each combination of"},{"line_number":241,"context_line":"        (hardware type, interface type, interface) that is supported and"},{"line_number":242,"context_line":"        enabled. Then validates against other conductors to check if the"},{"line_number":243,"context_line":"        set of registered hardware interfaces for a given hardware type is the"},{"line_number":244,"context_line":"        same, and warns if not (we can\u0027t error out, otherwise all conductors"},{"line_number":245,"context_line":"        must be restarted at once to change configuration)."}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_7c792e93","line":242,"updated":"2017-01-19 22:47:58.000000000","message":"I don\u0027t know. This part is a TODO; is it fair to describe it here? :)","commit_id":"f3dd4227a1d3aae13e76696ff44cc38690b134ae"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"696343c8a347c3018863f1418283e2cf63493db6","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        Registers a row in the database for each combination of"},{"line_number":241,"context_line":"        (hardware type, interface type, interface) that is supported and"},{"line_number":242,"context_line":"        enabled. Then validates against other conductors to check if the"},{"line_number":243,"context_line":"        set of registered hardware interfaces for a given hardware type is the"},{"line_number":244,"context_line":"        same, and warns if not (we can\u0027t error out, otherwise all conductors"},{"line_number":245,"context_line":"        must be restarted at once to change configuration)."}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_b196264a","line":242,"in_reply_to":"5a3905b3_1d31d1ec","updated":"2017-01-20 20:49:14.000000000","message":"Thanks for update, I need to dig more into driver composition...","commit_id":"f3dd4227a1d3aae13e76696ff44cc38690b134ae"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"394174e9a6ea00ceda2aac2137d51a5aa501c974","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        Registers a row in the database for each combination of"},{"line_number":241,"context_line":"        (hardware type, interface type, interface) that is supported and"},{"line_number":242,"context_line":"        enabled. Then validates against other conductors to check if the"},{"line_number":243,"context_line":"        set of registered hardware interfaces for a given hardware type is the"},{"line_number":244,"context_line":"        same, and warns if not (we can\u0027t error out, otherwise all conductors"},{"line_number":245,"context_line":"        must be restarted at once to change configuration)."}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_ad5c3e26","line":242,"in_reply_to":"5a3905b3_7c792e93","updated":"2017-01-19 23:46:36.000000000","message":"+1 to add TODO here, it may be treated as implemented thing otherwise...\n\nJust a thought... Might be allow to set enabled interfaces via Ironic API and store it in DB. When conductor starts it will read the values from DB if not applicable it should lead to failure. Also conductor may periodically poll list of enabled interface and reload local config","commit_id":"f3dd4227a1d3aae13e76696ff44cc38690b134ae"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"26b0f3c210f6b22cef77f2328ad81b653707e416","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"        Registers a row in the database for each combination of"},{"line_number":241,"context_line":"        (hardware type, interface type, interface) that is supported and"},{"line_number":242,"context_line":"        enabled. Then validates against other conductors to check if the"},{"line_number":243,"context_line":"        set of registered hardware interfaces for a given hardware type is the"},{"line_number":244,"context_line":"        same, and warns if not (we can\u0027t error out, otherwise all conductors"},{"line_number":245,"context_line":"        must be restarted at once to change configuration)."}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_1d31d1ec","line":242,"in_reply_to":"5a3905b3_ad5c3e26","updated":"2017-01-20 19:59:31.000000000","message":"Vasyl, please see the spec, we don\u0027t lead to failure, I don\u0027t think we should expose this config via API.\n\nWill update to make this a TODO.","commit_id":"f3dd4227a1d3aae13e76696ff44cc38690b134ae"}]}