)]}'
{"api-ref/source/baremetal-api-v1-node-management.inc":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a41e92a711dff48346654b1868a1ec5f69dacd57","unresolved":false,"context_lines":[{"line_number":232,"context_line":"can be used for hardware diagnostics, and actual support depends on a"},{"line_number":233,"context_line":"driver."},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"Normal response code: 204"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"Error codes:"},{"line_number":238,"context_line":"    - 400 (InvalidState)"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5a3905b3_b3eb0912","line":235,"updated":"2017-01-24 15:52:53.000000000","message":"nit: Would be good to have the string represtation of 204 like the error codes does have.\n\n204 (No content)\n\nThat said, I can see that other API endpoints in this file also doesn\u0027t include it. So ¯\\_(ツ)_/¯, nothing to do in this patch in particular.","commit_id":"629de336406df10cf9227814374130eb58944e74"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"c644e197bad87d47eca94a7e91470e1b08e34bef","unresolved":false,"context_lines":[{"line_number":232,"context_line":"can be used for hardware diagnostics, and actual support depends on a"},{"line_number":233,"context_line":"driver."},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"Normal response code: 204"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"Error codes:"},{"line_number":238,"context_line":"    - 400 (InvalidState)"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5a3905b3_a5455218","line":235,"in_reply_to":"5a3905b3_b3eb0912","updated":"2017-01-25 09:57:15.000000000","message":"I\u0027d like to fix that if the next patch set is necessary.","commit_id":"629de336406df10cf9227814374130eb58944e74"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"ae47227ab4edf969fb2574e5af467371deaf0c0b","unresolved":false,"context_lines":[{"line_number":235,"context_line":"Normal response code: 204"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"Error codes:"},{"line_number":238,"context_line":"    - 400 (InvalidState)"},{"line_number":239,"context_line":"    - 403 (Forbidden)"},{"line_number":240,"context_line":"    - 404 (NotFound)"},{"line_number":241,"context_line":"    - 406 (NotAcceptable)"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"3a461143_bdffe765","line":238,"range":{"start_line":238,"start_character":11,"end_line":238,"end_character":23},"updated":"2017-01-27 11:07:28.000000000","message":"just Invalid?","commit_id":"629de336406df10cf9227814374130eb58944e74"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"1ba841ffa138eca91bedcb8d30bb2fb6d191f42a","unresolved":false,"context_lines":[{"line_number":235,"context_line":"Normal response code: 204"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"Error codes:"},{"line_number":238,"context_line":"    - 400 (InvalidState)"},{"line_number":239,"context_line":"    - 403 (Forbidden)"},{"line_number":240,"context_line":"    - 404 (NotFound)"},{"line_number":241,"context_line":"    - 406 (NotAcceptable)"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"3a461143_8eeba212","line":238,"range":{"start_line":238,"start_character":11,"end_line":238,"end_character":23},"in_reply_to":"3a461143_bdffe765","updated":"2017-01-30 04:49:01.000000000","message":"I\u0027ll fix that.","commit_id":"629de336406df10cf9227814374130eb58944e74"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"ae47227ab4edf969fb2574e5af467371deaf0c0b","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    - 404 (NotFound)"},{"line_number":241,"context_line":"    - 406 (NotAcceptable)"},{"line_number":242,"context_line":"    - 409 (NodeLocked, ClientError)"},{"line_number":243,"context_line":"    - 503 (NoFreeConductorWorkers)"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Request"},{"line_number":246,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"3a461143_dd13d30b","line":243,"updated":"2017-01-27 11:07:28.000000000","message":"Hrm, does not look like it raises this one, inject_nmi seems to be synchronous, no workers are started for it.","commit_id":"629de336406df10cf9227814374130eb58944e74"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"1ba841ffa138eca91bedcb8d30bb2fb6d191f42a","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    - 404 (NotFound)"},{"line_number":241,"context_line":"    - 406 (NotAcceptable)"},{"line_number":242,"context_line":"    - 409 (NodeLocked, ClientError)"},{"line_number":243,"context_line":"    - 503 (NoFreeConductorWorkers)"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Request"},{"line_number":246,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"3a461143_0ee09228","line":243,"in_reply_to":"3a461143_dd13d30b","updated":"2017-01-30 04:49:01.000000000","message":"right, I\u0027ll fix that.","commit_id":"629de336406df10cf9227814374130eb58944e74"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a41e92a711dff48346654b1868a1ec5f69dacd57","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    - node_ident: node_ident"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"**Request to inject NMI to a node has to be empty dictionary:**"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":".. literalinclude:: samples/node-inject-nmi.json"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"Node State Summary"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5a3905b3_93a44d4b","line":254,"range":{"start_line":252,"start_character":0,"end_line":254,"end_character":48},"updated":"2017-01-24 15:52:53.000000000","message":"I find it a bit silly to have an empty json as example. Perhaps just saying that the request body should be empty (content-length 0) is enough ?","commit_id":"629de336406df10cf9227814374130eb58944e74"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"bc5b4f92bbefd70634d3f3e2294d02515011047c","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    - node_ident: node_ident"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"**Request to inject NMI to a node has to be empty dictionary:**"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":".. literalinclude:: samples/node-inject-nmi.json"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"Node State Summary"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"3a461143_f6ca7ba0","line":254,"range":{"start_line":252,"start_character":0,"end_line":254,"end_character":48},"in_reply_to":"3a461143_1c0596c1","updated":"2017-01-27 02:01:15.000000000","message":"Yes, that\u0027s exactly the case. Actually I didn\u0027t notice that too :-)\n\nhttps://review.openstack.org/#/c/424293/","commit_id":"629de336406df10cf9227814374130eb58944e74"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6a25076e8a19288e54fc3cebe880f2a2b0633b4f","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    - node_ident: node_ident"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"**Request to inject NMI to a node has to be empty dictionary:**"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":".. literalinclude:: samples/node-inject-nmi.json"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"Node State Summary"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"3a461143_d7ce52b3","line":254,"range":{"start_line":252,"start_character":0,"end_line":254,"end_character":48},"in_reply_to":"3a461143_f6ca7ba0","updated":"2017-01-27 10:05:46.000000000","message":"Oh well, thanks for the context","commit_id":"629de336406df10cf9227814374130eb58944e74"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"39e23c4e4f9ea9e670cc64f9776f00bb49685c26","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    - node_ident: node_ident"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"**Request to inject NMI to a node has to be empty dictionary:**"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":".. literalinclude:: samples/node-inject-nmi.json"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"Node State Summary"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"3a461143_1c0596c1","line":254,"range":{"start_line":252,"start_character":0,"end_line":254,"end_character":48},"in_reply_to":"5a3905b3_45782ef9","updated":"2017-01-26 09:53:17.000000000","message":"Oh, I thought it was possible to send a complete empty body (no {}) for this request. Isn\u0027t that the case ? We have to send the empty dict ?","commit_id":"629de336406df10cf9227814374130eb58944e74"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"c644e197bad87d47eca94a7e91470e1b08e34bef","unresolved":false,"context_lines":[{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    - node_ident: node_ident"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"**Request to inject NMI to a node has to be empty dictionary:**"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":".. literalinclude:: samples/node-inject-nmi.json"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"Node State Summary"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5a3905b3_45782ef9","line":254,"range":{"start_line":252,"start_character":0,"end_line":254,"end_character":48},"in_reply_to":"5a3905b3_93a44d4b","updated":"2017-01-25 09:57:15.000000000","message":"Lucus, the content-length of http boday has to be 2 for \u0027{}\u0027, do you mean that the length of \u0027{}\u0027 is 0?","commit_id":"629de336406df10cf9227814374130eb58944e74"}]}