)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e7bef8b159320b1979e288cbbfccb719081b1b06","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sam Betts \u003csam@code-smash.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-26 10:36:24 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Don\u0027t override device_owner for tenant network ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a vif is passed to us from nova as a tenant port we shouldn\u0027t"},{"line_number":10,"context_line":"change the device_owner or device_id because that is what links the port"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a461143_c4eec68a","line":7,"updated":"2017-01-26 15:42:06.000000000","message":"Now this is not needed, patch is ready for review :)","commit_id":"84f492a50f5c1618f2377a23fb51ba015aebb602"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"2275de83c7ea44291f3ec7b6ff343debe3806c9d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sam Betts \u003csam@code-smash.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-26 10:36:24 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Don\u0027t override device_owner for tenant network ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a vif is passed to us from nova as a tenant port we shouldn\u0027t"},{"line_number":10,"context_line":"change the device_owner or device_id because that is what links the port"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a461143_9245b571","line":7,"in_reply_to":"3a461143_c4eec68a","updated":"2017-01-27 11:59:44.000000000","message":"Done","commit_id":"84f492a50f5c1618f2377a23fb51ba015aebb602"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e7bef8b159320b1979e288cbbfccb719081b1b06","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I43c3af9f424a65211ef5a39f13e4810072997339"},{"line_number":16,"context_line":"Closes-Bug: #1656010"},{"line_number":17,"context_line":"Depends-On: I8318a682163f6a5b739be68ce56973c43d0e32f2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a461143_44dc96e4","line":17,"updated":"2017-01-26 15:42:06.000000000","message":"Do we need to depend on Neutron patch? The dependency should be reversed, ironic change should go first. After this is merged nova will receive notifications because device_owner will be compute:....\nAnd after that we may revert neutron patch.","commit_id":"84f492a50f5c1618f2377a23fb51ba015aebb602"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"2275de83c7ea44291f3ec7b6ff343debe3806c9d","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I43c3af9f424a65211ef5a39f13e4810072997339"},{"line_number":16,"context_line":"Closes-Bug: #1656010"},{"line_number":17,"context_line":"Depends-On: I8318a682163f6a5b739be68ce56973c43d0e32f2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a461143_b248f188","line":17,"in_reply_to":"3a461143_44dc96e4","updated":"2017-01-27 11:59:44.000000000","message":"Done","commit_id":"84f492a50f5c1618f2377a23fb51ba015aebb602"}],"ironic/drivers/modules/network/neutron.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e7bef8b159320b1979e288cbbfccb719081b1b06","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                        {\u0027opt_name\u0027: \u0027client-id\u0027, \u0027opt_value\u0027: client_id})"},{"line_number":194,"context_line":"            body \u003d {"},{"line_number":195,"context_line":"                \u0027port\u0027: {"},{"line_number":196,"context_line":"                    \u0027device_owner\u0027: \u0027baremetal:none\u0027,"},{"line_number":197,"context_line":"                    \u0027device_id\u0027: node.instance_uuid or node.uuid,"},{"line_number":198,"context_line":"                    \u0027admin_state_up\u0027: True,"},{"line_number":199,"context_line":"                    \u0027binding:vnic_type\u0027: \u0027baremetal\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_24394a42","side":"PARENT","line":196,"updated":"2017-01-26 15:42:06.000000000","message":"Please add a note above why we not passing device_owner here.","commit_id":"eae8e07132edf00bc5b51aa8342ad22ab3c2cc60"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"2275de83c7ea44291f3ec7b6ff343debe3806c9d","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                        {\u0027opt_name\u0027: \u0027client-id\u0027, \u0027opt_value\u0027: client_id})"},{"line_number":194,"context_line":"            body \u003d {"},{"line_number":195,"context_line":"                \u0027port\u0027: {"},{"line_number":196,"context_line":"                    \u0027device_owner\u0027: \u0027baremetal:none\u0027,"},{"line_number":197,"context_line":"                    \u0027device_id\u0027: node.instance_uuid or node.uuid,"},{"line_number":198,"context_line":"                    \u0027admin_state_up\u0027: True,"},{"line_number":199,"context_line":"                    \u0027binding:vnic_type\u0027: \u0027baremetal\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_724e8997","side":"PARENT","line":196,"in_reply_to":"3a461143_24394a42","updated":"2017-01-27 11:59:44.000000000","message":"Done","commit_id":"eae8e07132edf00bc5b51aa8342ad22ab3c2cc60"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a4e54dcc5ae6af8f0f083573ad9886f44129bb7d","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            # the user or nova."},{"line_number":198,"context_line":"            body \u003d {"},{"line_number":199,"context_line":"                \u0027port\u0027: {"},{"line_number":200,"context_line":"                    \u0027admin_state_up\u0027: True,"},{"line_number":201,"context_line":"                    \u0027binding:vnic_type\u0027: \u0027baremetal\u0027,"},{"line_number":202,"context_line":"                    \u0027binding:host_id\u0027: node.uuid,"},{"line_number":203,"context_line":"                    \u0027binding:profile\u0027: {"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_23c10e2f","line":200,"range":{"start_line":200,"start_character":21,"end_line":200,"end_character":43},"updated":"2017-01-27 15:40:09.000000000","message":"we shouldn\u0027t change admin_state for tenant port here.","commit_id":"cbdf5076d37df61d2e9c46a0a73c7ad65652b866"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ed33580b5db0c596efeca9f09acdc7c7b49eae59","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            # the user or nova."},{"line_number":198,"context_line":"            body \u003d {"},{"line_number":199,"context_line":"                \u0027port\u0027: {"},{"line_number":200,"context_line":"                    \u0027admin_state_up\u0027: True,"},{"line_number":201,"context_line":"                    \u0027binding:vnic_type\u0027: \u0027baremetal\u0027,"},{"line_number":202,"context_line":"                    \u0027binding:host_id\u0027: node.uuid,"},{"line_number":203,"context_line":"                    \u0027binding:profile\u0027: {"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_db56e6cc","line":200,"range":{"start_line":200,"start_character":21,"end_line":200,"end_character":43},"in_reply_to":"3a461143_23c10e2f","updated":"2017-02-01 11:42:25.000000000","message":"proposed fix: https://review.openstack.org/#/c/427603","commit_id":"cbdf5076d37df61d2e9c46a0a73c7ad65652b866"}],"tox.ini":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e7bef8b159320b1979e288cbbfccb719081b1b06","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"},{"line_number":7,"context_line":"usedevelop \u003d True"},{"line_number":8,"context_line":"install_command \u003d pip install --no-cache-dir -U -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} {opts} {packages}"},{"line_number":9,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":10,"context_line":"         PYTHONDONTWRITEBYTECODE \u003d 1"},{"line_number":11,"context_line":"         LANGUAGE\u003den_US"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3a461143_e4e022cf","line":8,"updated":"2017-01-26 15:42:06.000000000","message":"not related to this change.","commit_id":"84f492a50f5c1618f2377a23fb51ba015aebb602"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"2275de83c7ea44291f3ec7b6ff343debe3806c9d","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"},{"line_number":7,"context_line":"usedevelop \u003d True"},{"line_number":8,"context_line":"install_command \u003d pip install --no-cache-dir -U -c{env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} {opts} {packages}"},{"line_number":9,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":10,"context_line":"         PYTHONDONTWRITEBYTECODE \u003d 1"},{"line_number":11,"context_line":"         LANGUAGE\u003den_US"}],"source_content_type":"text/x-properties","patch_set":2,"id":"3a461143_721cc977","line":8,"in_reply_to":"3a461143_e4e022cf","updated":"2017-01-27 11:59:44.000000000","message":"Done","commit_id":"84f492a50f5c1618f2377a23fb51ba015aebb602"}]}