)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"1f433901a2539aa31787e45a2cc6a6cf5ada93b6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dao Cong Tien \u003ctiendc@vn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-26 17:02:40 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add hardware type irmc-s4 for iRMC S4 servers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I92c62a1680d4662dce5b1158b323192f35af7e9c"},{"line_number":10,"context_line":"Closes-Bug:#1659209"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a461143_6c595e5a","line":7,"range":{"start_line":7,"start_character":22,"end_line":7,"end_character":25},"updated":"2017-01-27 04:16:57.000000000","message":"please remove s4, since S4 is just a version number, iRMC is likely to become iRMC S5 in near future.\n\niRMC driver support iRMC S4 and later.","commit_id":"535d23b87e77032a912f4cb26aa149885f89a208"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1238b65bbbdd7944919776f52a422c5e9315bbf4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dao Cong Tien \u003ctiendc@vn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-27 13:10:32 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add hardware type \u0027irmc\u0027 for iRMC servers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I92c62a1680d4662dce5b1158b323192f35af7e9c"},{"line_number":10,"context_line":"Closes-Bug:#1659209"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a461143_116aaa1a","line":7,"updated":"2017-01-27 09:19:01.000000000","message":"+1","commit_id":"c97c7152fbb197df77073e06e6f955f37bea3791"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"f7532c58bc5d3a7d45ed1a49f0c9370d3c09fbf3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dao Cong Tien \u003ctiendc@vn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-27 13:10:32 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add hardware type \u0027irmc\u0027 for iRMC servers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I92c62a1680d4662dce5b1158b323192f35af7e9c"},{"line_number":10,"context_line":"Closes-Bug:#1659209"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a461143_68894726","line":7,"range":{"start_line":7,"start_character":29,"end_line":7,"end_character":33},"updated":"2017-01-27 06:48:31.000000000","message":"nit: s/iRMC/FUJITSU PRIMERGY/\n\nIt would be better to add some commit message.","commit_id":"c97c7152fbb197df77073e06e6f955f37bea3791"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"4610351bb112c5e9a2992d30e31cf2548966a01c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dao Cong Tien \u003ctiendc@vn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-01-27 13:10:32 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add hardware type \u0027irmc\u0027 for iRMC servers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I92c62a1680d4662dce5b1158b323192f35af7e9c"},{"line_number":10,"context_line":"Closes-Bug:#1659209"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a461143_d4f9e581","line":7,"range":{"start_line":7,"start_character":29,"end_line":7,"end_character":33},"in_reply_to":"3a461143_68894726","updated":"2017-01-31 17:18:47.000000000","message":"Done","commit_id":"c97c7152fbb197df77073e06e6f955f37bea3791"}],"ironic/drivers/irmc.py":[{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"1f433901a2539aa31787e45a2cc6a6cf5ada93b6","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self.inspect \u003d inspect.IRMCInspect()"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"class IRMCS4Hardware(generic.GenericHardware):"},{"line_number":85,"context_line":"    \"\"\"iRMC S4 hardware type.\"\"\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_2c2676ce","line":84,"range":{"start_line":84,"start_character":10,"end_line":84,"end_character":12},"updated":"2017-01-27 04:16:57.000000000","message":"ditto","commit_id":"535d23b87e77032a912f4cb26aa149885f89a208"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"242e605564bc51fb12f1507c49564650687e86f4","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self.inspect \u003d inspect.IRMCInspect()"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"class IRMCS4Hardware(generic.GenericHardware):"},{"line_number":85,"context_line":"    \"\"\"iRMC S4 hardware type.\"\"\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_c2f1396c","line":84,"range":{"start_line":84,"start_character":10,"end_line":84,"end_character":12},"in_reply_to":"3a461143_2c2676ce","updated":"2017-01-27 06:14:50.000000000","message":"Done","commit_id":"535d23b87e77032a912f4cb26aa149885f89a208"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"35ed795be4398ccdb6ebd7a2dad3819f0d88d349","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    @property"},{"line_number":88,"context_line":"    def supported_boot_interfaces(self):"},{"line_number":89,"context_line":"        \"\"\"List of supported boot interfaces.\"\"\""},{"line_number":90,"context_line":"        return [pxe.PXEBoot, boot.IRMCVirtualMediaBoot]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @property"},{"line_number":93,"context_line":"    def supported_console_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_296dac98","line":90,"updated":"2017-01-26 13:11:59.000000000","message":"Ditto, should pxe or virtualmedia be preferred?","commit_id":"535d23b87e77032a912f4cb26aa149885f89a208"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"242e605564bc51fb12f1507c49564650687e86f4","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    @property"},{"line_number":88,"context_line":"    def supported_boot_interfaces(self):"},{"line_number":89,"context_line":"        \"\"\"List of supported boot interfaces.\"\"\""},{"line_number":90,"context_line":"        return [pxe.PXEBoot, boot.IRMCVirtualMediaBoot]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @property"},{"line_number":93,"context_line":"    def supported_console_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_228afdbf","line":90,"in_reply_to":"3a461143_296dac98","updated":"2017-01-27 06:14:50.000000000","message":"Done. Now all iRMC interfaces are preferred.","commit_id":"535d23b87e77032a912f4cb26aa149885f89a208"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"275c11f914c536b2d5e6efd7bd4ca126daee848c","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    @property"},{"line_number":104,"context_line":"    def supported_inspect_interfaces(self):"},{"line_number":105,"context_line":"        \"\"\"List of supported inspect interfaces.\"\"\""},{"line_number":106,"context_line":"        return [inspector.Inspector, inspect.IRMCInspect,"},{"line_number":107,"context_line":"                noop.NoInspect]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_9704f815","line":106,"updated":"2017-01-26 12:44:56.000000000","message":"this makes Inspector more preferred than IRMCInspect. I wonder if it\u0027s something you actually want to do. If not, swap them in this list.","commit_id":"535d23b87e77032a912f4cb26aa149885f89a208"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"242e605564bc51fb12f1507c49564650687e86f4","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    @property"},{"line_number":104,"context_line":"    def supported_inspect_interfaces(self):"},{"line_number":105,"context_line":"        \"\"\"List of supported inspect interfaces.\"\"\""},{"line_number":106,"context_line":"        return [inspector.Inspector, inspect.IRMCInspect,"},{"line_number":107,"context_line":"                noop.NoInspect]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_629405e2","line":106,"in_reply_to":"3a461143_9704f815","updated":"2017-01-27 06:14:50.000000000","message":"Done. Now all iRMC interfaces are preferred.","commit_id":"535d23b87e77032a912f4cb26aa149885f89a208"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1238b65bbbdd7944919776f52a422c5e9315bbf4","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"class IRMCHardware(generic.GenericHardware):"},{"line_number":85,"context_line":"    \"\"\"iRMC hardware type.\"\"\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @property"},{"line_number":88,"context_line":"    def supported_boot_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_317966f7","line":85,"updated":"2017-01-27 09:19:01.000000000","message":"let\u0027s also expand this docstring with a proper name of hardware family (FUJITSU PRIMERGY is it?)","commit_id":"c97c7152fbb197df77073e06e6f955f37bea3791"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"4610351bb112c5e9a2992d30e31cf2548966a01c","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"class IRMCHardware(generic.GenericHardware):"},{"line_number":85,"context_line":"    \"\"\"iRMC hardware type.\"\"\""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @property"},{"line_number":88,"context_line":"    def supported_boot_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_bcfbf477","line":85,"in_reply_to":"3a461143_317966f7","updated":"2017-01-31 17:18:47.000000000","message":"Done","commit_id":"c97c7152fbb197df77073e06e6f955f37bea3791"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1238b65bbbdd7944919776f52a422c5e9315bbf4","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    @property"},{"line_number":99,"context_line":"    def supported_deploy_interfaces(self):"},{"line_number":100,"context_line":"        \"\"\"List of supported deploy interfaces.\"\"\""},{"line_number":101,"context_line":"        return [iscsi_deploy.ISCSIDeploy, agent.AgentDeploy]"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @property"},{"line_number":104,"context_line":"    def supported_inspect_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_517432fc","line":101,"updated":"2017-01-27 09:19:01.000000000","message":"this duplicates implementation in GenericHardware and can be safely removed","commit_id":"c97c7152fbb197df77073e06e6f955f37bea3791"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"4610351bb112c5e9a2992d30e31cf2548966a01c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    @property"},{"line_number":99,"context_line":"    def supported_deploy_interfaces(self):"},{"line_number":100,"context_line":"        \"\"\"List of supported deploy interfaces.\"\"\""},{"line_number":101,"context_line":"        return [iscsi_deploy.ISCSIDeploy, agent.AgentDeploy]"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    @property"},{"line_number":104,"context_line":"    def supported_inspect_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_14228d00","line":101,"in_reply_to":"3a461143_517432fc","updated":"2017-01-31 17:18:47.000000000","message":"Done","commit_id":"c97c7152fbb197df77073e06e6f955f37bea3791"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1238b65bbbdd7944919776f52a422c5e9315bbf4","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    @property"},{"line_number":110,"context_line":"    def supported_management_interfaces(self):"},{"line_number":111,"context_line":"        \"\"\"List of supported management interfaces.\"\"\""},{"line_number":112,"context_line":"        return [management.IRMCManagement]"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    @property"},{"line_number":115,"context_line":"    def supported_power_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_71612e39","line":112,"updated":"2017-01-27 09:19:01.000000000","message":"just asking: do you want to support IPMIManagement as well?","commit_id":"c97c7152fbb197df77073e06e6f955f37bea3791"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"4610351bb112c5e9a2992d30e31cf2548966a01c","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    @property"},{"line_number":110,"context_line":"    def supported_management_interfaces(self):"},{"line_number":111,"context_line":"        \"\"\"List of supported management interfaces.\"\"\""},{"line_number":112,"context_line":"        return [management.IRMCManagement]"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    @property"},{"line_number":115,"context_line":"    def supported_power_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_bc28549b","line":112,"in_reply_to":"3a461143_71612e39","updated":"2017-01-31 17:18:47.000000000","message":"All current classic drivers from Fujitsu use IRMCManagement. I would want to leave this unchanged unless there are comments from Fujitsu side.","commit_id":"c97c7152fbb197df77073e06e6f955f37bea3791"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"1238b65bbbdd7944919776f52a422c5e9315bbf4","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    @property"},{"line_number":115,"context_line":"    def supported_power_interfaces(self):"},{"line_number":116,"context_line":"        \"\"\"List of supported power interfaces.\"\"\""},{"line_number":117,"context_line":"        return [power.IRMCPower]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_9164da49","line":117,"updated":"2017-01-27 09:19:01.000000000","message":"ditto (again, just a question)","commit_id":"c97c7152fbb197df77073e06e6f955f37bea3791"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"4610351bb112c5e9a2992d30e31cf2548966a01c","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    @property"},{"line_number":115,"context_line":"    def supported_power_interfaces(self):"},{"line_number":116,"context_line":"        \"\"\"List of supported power interfaces.\"\"\""},{"line_number":117,"context_line":"        return [power.IRMCPower]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a461143_5ccdb02f","line":117,"in_reply_to":"3a461143_9164da49","updated":"2017-01-31 17:18:47.000000000","message":"ditto","commit_id":"c97c7152fbb197df77073e06e6f955f37bea3791"}],"ironic/tests/unit/drivers/test_irmc.py":[{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"1f433901a2539aa31787e45a2cc6a6cf5ada93b6","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                          irmc.IRMCVirtualMediaAgentDriver)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"class IRMCS4HardwareTestCase(db_base.DbTestCase):"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def setUp(self):"},{"line_number":120,"context_line":"        irmc.boot.check_share_fs_mounted_patcher.start()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_8c2bea93","line":117,"range":{"start_line":117,"start_character":10,"end_line":117,"end_character":12},"updated":"2017-01-27 04:16:57.000000000","message":"ditto.","commit_id":"535d23b87e77032a912f4cb26aa149885f89a208"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"242e605564bc51fb12f1507c49564650687e86f4","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                          irmc.IRMCVirtualMediaAgentDriver)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"class IRMCS4HardwareTestCase(db_base.DbTestCase):"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def setUp(self):"},{"line_number":120,"context_line":"        irmc.boot.check_share_fs_mounted_patcher.start()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_c2bf795e","line":117,"range":{"start_line":117,"start_character":10,"end_line":117,"end_character":12},"in_reply_to":"3a461143_8c2bea93","updated":"2017-01-27 06:14:50.000000000","message":"Done","commit_id":"535d23b87e77032a912f4cb26aa149885f89a208"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"1f433901a2539aa31787e45a2cc6a6cf5ada93b6","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        irmc.boot.check_share_fs_mounted_patcher.start()"},{"line_number":121,"context_line":"        self.addCleanup(irmc.boot.check_share_fs_mounted_patcher.stop)"},{"line_number":122,"context_line":"        super(IRMCS4HardwareTestCase, self).setUp()"},{"line_number":123,"context_line":"        self.config(enabled_hardware_types\u003d[\u0027irmc-s4\u0027],"},{"line_number":124,"context_line":"                    enabled_boot_interfaces\u003d[\u0027irmc-virtual-media-boot\u0027],"},{"line_number":125,"context_line":"                    enabled_console_interfaces\u003d[\u0027no-console\u0027],"},{"line_number":126,"context_line":"                    enabled_deploy_interfaces\u003d[\u0027iscsi\u0027, \u0027direct\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_0c161a55","line":123,"range":{"start_line":123,"start_character":49,"end_line":123,"end_character":52},"updated":"2017-01-27 04:16:57.000000000","message":"ditto","commit_id":"535d23b87e77032a912f4cb26aa149885f89a208"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"242e605564bc51fb12f1507c49564650687e86f4","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        irmc.boot.check_share_fs_mounted_patcher.start()"},{"line_number":121,"context_line":"        self.addCleanup(irmc.boot.check_share_fs_mounted_patcher.stop)"},{"line_number":122,"context_line":"        super(IRMCS4HardwareTestCase, self).setUp()"},{"line_number":123,"context_line":"        self.config(enabled_hardware_types\u003d[\u0027irmc-s4\u0027],"},{"line_number":124,"context_line":"                    enabled_boot_interfaces\u003d[\u0027irmc-virtual-media-boot\u0027],"},{"line_number":125,"context_line":"                    enabled_console_interfaces\u003d[\u0027no-console\u0027],"},{"line_number":126,"context_line":"                    enabled_deploy_interfaces\u003d[\u0027iscsi\u0027, \u0027direct\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_02ba616e","line":123,"range":{"start_line":123,"start_character":49,"end_line":123,"end_character":52},"in_reply_to":"3a461143_0c161a55","updated":"2017-01-27 06:14:50.000000000","message":"Done","commit_id":"535d23b87e77032a912f4cb26aa149885f89a208"},{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"1f433901a2539aa31787e45a2cc6a6cf5ada93b6","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                    enabled_raid_interfaces\u003d[\u0027no-raid\u0027, \u0027agent\u0027])"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def test_default_interfaces(self):"},{"line_number":133,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027irmc-s4\u0027)"},{"line_number":134,"context_line":"        with task_manager.acquire(self.context, node.id) as task:"},{"line_number":135,"context_line":"            self.assertIsInstance(task.driver.boot,"},{"line_number":136,"context_line":"                                  irmc.boot.IRMCVirtualMediaBoot)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_6c079e1c","line":133,"range":{"start_line":133,"start_character":68,"end_line":133,"end_character":71},"updated":"2017-01-27 04:16:57.000000000","message":"ditto","commit_id":"535d23b87e77032a912f4cb26aa149885f89a208"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"242e605564bc51fb12f1507c49564650687e86f4","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                    enabled_raid_interfaces\u003d[\u0027no-raid\u0027, \u0027agent\u0027])"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def test_default_interfaces(self):"},{"line_number":133,"context_line":"        node \u003d obj_utils.create_test_node(self.context, driver\u003d\u0027irmc-s4\u0027)"},{"line_number":134,"context_line":"        with task_manager.acquire(self.context, node.id) as task:"},{"line_number":135,"context_line":"            self.assertIsInstance(task.driver.boot,"},{"line_number":136,"context_line":"                                  irmc.boot.IRMCVirtualMediaBoot)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a461143_22b11d90","line":133,"range":{"start_line":133,"start_character":68,"end_line":133,"end_character":71},"in_reply_to":"3a461143_6c079e1c","updated":"2017-01-27 06:14:50.000000000","message":"Done","commit_id":"535d23b87e77032a912f4cb26aa149885f89a208"}],"releasenotes/notes/irmc-hardware-type-2ab4e1906d01fe22.yaml":[{"author":{"_account_id":13719,"name":"Naohiro Tamura","email":"naohirot.openstack@gmail.com","username":"nao"},"change_message_id":"f7532c58bc5d3a7d45ed1a49f0c9370d3c09fbf3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds new hardware type \u0027irmc\u0027 for iRMC servers."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3a461143_08e4430b","line":3,"range":{"start_line":3,"start_character":38,"end_line":3,"end_character":42},"updated":"2017-01-27 06:48:31.000000000","message":"nit: iRMC is not server, but BMC. s/iRMC/FUJITSU PRIMERGY/","commit_id":"c97c7152fbb197df77073e06e6f955f37bea3791"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"4610351bb112c5e9a2992d30e31cf2548966a01c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds new hardware type \u0027irmc\u0027 for iRMC servers."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3a461143_94acbda1","line":3,"range":{"start_line":3,"start_character":38,"end_line":3,"end_character":42},"in_reply_to":"3a461143_08e4430b","updated":"2017-01-31 17:18:47.000000000","message":"Done","commit_id":"c97c7152fbb197df77073e06e6f955f37bea3791"}],"setup.cfg":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"275c11f914c536b2d5e6efd7bd4ca126daee848c","unresolved":false,"context_lines":[{"line_number":92,"context_line":"ironic.hardware.interfaces.boot \u003d"},{"line_number":93,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeBoot"},{"line_number":94,"context_line":"    pxe \u003d ironic.drivers.modules.pxe:PXEBoot"},{"line_number":95,"context_line":"    irmc-virtual-media-boot \u003d ironic.drivers.modules.irmc.boot:IRMCVirtualMediaBoot"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"ironic.hardware.interfaces.console \u003d"},{"line_number":98,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeConsole"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"3a461143_b709f42e","line":95,"updated":"2017-01-26 12:44:56.000000000","message":"you don\u0027t need \"boot\" in the entrypoint name, just use \u0027irmc-virtual-media\u0027","commit_id":"535d23b87e77032a912f4cb26aa149885f89a208"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"275c11f914c536b2d5e6efd7bd4ca126daee848c","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeInspect"},{"line_number":108,"context_line":"    inspector \u003d ironic.drivers.modules.inspector:Inspector"},{"line_number":109,"context_line":"    no-inspect \u003d ironic.drivers.modules.noop:NoInspect"},{"line_number":110,"context_line":"    irmc-inspect \u003d ironic.drivers.modules.irmc.inspect:IRMCInspect"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"ironic.hardware.interfaces.management \u003d"},{"line_number":113,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeManagement"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"3a461143_d70e8033","line":110,"updated":"2017-01-26 12:44:56.000000000","message":"I suggest we don\u0027t duplicate \u0027inspect\u0027, just \u0027irmc\u0027","commit_id":"535d23b87e77032a912f4cb26aa149885f89a208"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"275c11f914c536b2d5e6efd7bd4ca126daee848c","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"ironic.hardware.interfaces.power \u003d"},{"line_number":122,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakePower"},{"line_number":123,"context_line":"    irmc-power \u003d ironic.drivers.modules.irmc.power:IRMCPower"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"ironic.hardware.interfaces.raid \u003d"},{"line_number":126,"context_line":"    agent \u003d ironic.drivers.modules.agent:AgentRAID"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"3a461143_f7137c5a","line":123,"updated":"2017-01-26 12:44:56.000000000","message":"ditto about \u0027power\u0027","commit_id":"535d23b87e77032a912f4cb26aa149885f89a208"}]}