)]}'
{"doc/source/deploy/multitenancy.rst":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"e4223f52b7be2c332e770ff00406a56fcc437d98","unresolved":false,"context_lines":[{"line_number":73,"context_line":"   requires that ``provisioning_network`` and ``cleaning_network``"},{"line_number":74,"context_line":"   configuration options are set to valid identifiers (UUID or name) of"},{"line_number":75,"context_line":"   networks in the  Networking service. If these options are not set correctly,"},{"line_number":76,"context_line":"   cleaning or provisioning will fail to start::"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    [neutron]"},{"line_number":79,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a461143_a926bfcb","line":76,"updated":"2017-01-27 16:31:12.000000000","message":"Actually, conductor will fail to start, as validate that is called on init_host raises exception.","commit_id":"1f1e4b3db4a9c88cddfec55b22c60d189039ddcd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"1447b78b42576d6ad44bc6630be740a3fded1def","unresolved":false,"context_lines":[{"line_number":73,"context_line":"   requires that ``provisioning_network`` and ``cleaning_network``"},{"line_number":74,"context_line":"   configuration options are set to valid identifiers (UUID or name) of"},{"line_number":75,"context_line":"   networks in the  Networking service. If these options are not set correctly,"},{"line_number":76,"context_line":"   cleaning or provisioning will fail to start::"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    [neutron]"},{"line_number":79,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a461143_c170db0d","line":76,"in_reply_to":"3a461143_2a126857","updated":"2017-01-31 16:22:41.000000000","message":"I was going to make the suggested changes, but I looked to see why I even did this patch (yes, I forgot). This is a follow up patch to another patch; the idea was to just fix the nits that were mentioned in the original patch https://review.openstack.org/#/c/378138/. It was meant to be purely grammatical changes that affect readability. Making more changes would be outside the scope of this patch.\n\nI don\u0027t disagree that there isn\u0027t room for improvement, but I think a separate patch should be done to address these comments. Also, if someone were to propose that patch (I doubt that it will be me), the very first sentence in this paragraph is odd. It talks about a provisioning network (which doesn\u0027t include cleaning), but then provisioning \u0026 cleaning networks are mentioned. So this paragraph could use a revamp.","commit_id":"1f1e4b3db4a9c88cddfec55b22c60d189039ddcd"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"275fa9d99f1b0012df6ac3f654e233e6b4785e2f","unresolved":false,"context_lines":[{"line_number":73,"context_line":"   requires that ``provisioning_network`` and ``cleaning_network``"},{"line_number":74,"context_line":"   configuration options are set to valid identifiers (UUID or name) of"},{"line_number":75,"context_line":"   networks in the  Networking service. If these options are not set correctly,"},{"line_number":76,"context_line":"   cleaning or provisioning will fail to start::"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    [neutron]"},{"line_number":79,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a461143_2a126857","line":76,"in_reply_to":"3a461143_7e98b61c","updated":"2017-01-31 10:56:38.000000000","message":"maybe \"..configuration options are set (otherwise conductor will fail to start) and their value are valid identifiers (UUID or name) of networks in Networking service (otherwise cleaning or provisioning will fail to start)\"","commit_id":"1f1e4b3db4a9c88cddfec55b22c60d189039ddcd"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"4d3f52b00a50825c9bd1a8a84b7715eb62c37a14","unresolved":false,"context_lines":[{"line_number":73,"context_line":"   requires that ``provisioning_network`` and ``cleaning_network``"},{"line_number":74,"context_line":"   configuration options are set to valid identifiers (UUID or name) of"},{"line_number":75,"context_line":"   networks in the  Networking service. If these options are not set correctly,"},{"line_number":76,"context_line":"   cleaning or provisioning will fail to start::"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    [neutron]"},{"line_number":79,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a461143_7e98b61c","line":76,"in_reply_to":"3a461143_83e6f712","updated":"2017-01-31 09:30:03.000000000","message":"If talking about 2nd case the wording looks like correct, not sure if we should describe what means \u0027set correctly\u0027 in more detail like: \"The networks with provided identifiers should exist in Networking service. In case name is provided administrator is responsible to keep name unique among all tenant networks, as Networking service doesn\u0027t guarantee network name uniqueness.","commit_id":"1f1e4b3db4a9c88cddfec55b22c60d189039ddcd"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b521df863e93c93d9034690501b023fce7ea91c6","unresolved":false,"context_lines":[{"line_number":73,"context_line":"   requires that ``provisioning_network`` and ``cleaning_network``"},{"line_number":74,"context_line":"   configuration options are set to valid identifiers (UUID or name) of"},{"line_number":75,"context_line":"   networks in the  Networking service. If these options are not set correctly,"},{"line_number":76,"context_line":"   cleaning or provisioning will fail to start::"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    [neutron]"},{"line_number":79,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a461143_fa985cc2","line":76,"in_reply_to":"3a461143_a926bfcb","updated":"2017-01-30 08:46:26.000000000","message":"It depends:\nIf no values are set -  conductor will fail to start.\nIf wrong value is specified (not a valid network uuid or name) conductor will start successfully but cleaning/provisioning will not work.\n\nMight be add it to documentation?","commit_id":"1f1e4b3db4a9c88cddfec55b22c60d189039ddcd"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"deebbf530df86fb59a2c0e75a280542b8bc975ea","unresolved":false,"context_lines":[{"line_number":73,"context_line":"   requires that ``provisioning_network`` and ``cleaning_network``"},{"line_number":74,"context_line":"   configuration options are set to valid identifiers (UUID or name) of"},{"line_number":75,"context_line":"   networks in the  Networking service. If these options are not set correctly,"},{"line_number":76,"context_line":"   cleaning or provisioning will fail to start::"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    [neutron]"},{"line_number":79,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":1,"id":"fa31d9ce_d1e1faff","line":76,"in_reply_to":"3a461143_c170db0d","updated":"2017-02-13 10:02:20.000000000","message":"Cool,\n\nSeems like we all agree that the proposed version here is good enough.","commit_id":"1f1e4b3db4a9c88cddfec55b22c60d189039ddcd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0a6846746b5d50f4dcf29d3c574f013c80f501df","unresolved":false,"context_lines":[{"line_number":73,"context_line":"   requires that ``provisioning_network`` and ``cleaning_network``"},{"line_number":74,"context_line":"   configuration options are set to valid identifiers (UUID or name) of"},{"line_number":75,"context_line":"   networks in the  Networking service. If these options are not set correctly,"},{"line_number":76,"context_line":"   cleaning or provisioning will fail to start::"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    [neutron]"},{"line_number":79,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a461143_83e6f712","line":76,"in_reply_to":"3a461143_c65f4ae3","updated":"2017-01-30 23:14:15.000000000","message":"I agree with Lucas. Also, the previous sentence says ...\u0027 requires that ... are set to valid identifiers...\u0027 So the \u0027If these options are not set correctly\u0027 carries on from there; ie, that they are not set to valid identifiers.\n\nAlso, if you look at the help for these configs, it sez that they are required. (We could copy the help here, but some people don\u0027t like that.)\n\nAnyway, if you would like it clarified because it is unclear, please provide the wording for me.","commit_id":"1f1e4b3db4a9c88cddfec55b22c60d189039ddcd"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4d3f31ce0123a99369eb50a8d5e232c6daf5a495","unresolved":false,"context_lines":[{"line_number":73,"context_line":"   requires that ``provisioning_network`` and ``cleaning_network``"},{"line_number":74,"context_line":"   configuration options are set to valid identifiers (UUID or name) of"},{"line_number":75,"context_line":"   networks in the  Networking service. If these options are not set correctly,"},{"line_number":76,"context_line":"   cleaning or provisioning will fail to start::"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    [neutron]"},{"line_number":79,"context_line":"    ..."}],"source_content_type":"text/x-rst","patch_set":1,"id":"3a461143_c65f4ae3","line":76,"in_reply_to":"3a461143_fa985cc2","updated":"2017-01-30 10:34:31.000000000","message":"Seems the documentation is talking about the 2nd case here where the conductor starts but fails later on.\n\nI think this is good enough, the first case is true for pretty much every mandatory configuration option (conductor won\u0027t start if not set).","commit_id":"1f1e4b3db4a9c88cddfec55b22c60d189039ddcd"}]}