)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"85db6b80bc15a8f5ca85e40bfe6cc1f785c50f27","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The mock module has been added to Python 3.3 as unittest.mock."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The third party mock module doesn\u0027t seem to be maintained anymore:"},{"line_number":12,"context_line":"the last commit was in April 2013. unittest.mock is more recent,"},{"line_number":13,"context_line":"has less bugs and is compatible with Python 3.4. There are"},{"line_number":14,"context_line":"bugs on Python 3 in the third party mock module,"},{"line_number":15,"context_line":"examples:"},{"line_number":16,"context_line":"* https://code.google.com/p/mock/issues/detail?id\u003d225"},{"line_number":17,"context_line":"* https://code.google.com/p/mock/issues/detail?id\u003d234"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"oslotest prepares mock for six in oslotest/__init__.py as follow:"},{"line_number":20,"context_line":"six.add_move(six.MovedModule(\u0027mock\u0027, \u0027mock\u0027, \u0027unittest.mock\u0027)) and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa31d9ce_b0022008","line":17,"range":{"start_line":11,"start_character":0,"end_line":17,"end_character":53},"updated":"2017-02-16 09:09:45.000000000","message":"According to pipy [0] new home of mock module is [1] and the latest commits are dated by 2016.\n\n[0] https://pypi.python.org/pypi/mock\n[1] https://github.com/testing-cabal/mock/commits/master\n\nIt just a backport for python 2.7 of unittest.mock which is available starting from python 3.3\n\nPlease fix commit message.","commit_id":"1d7c93e427b0520ac427402f0583794c665330ae"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"3e84d5ee05bab445d584368ee09bad8c2d33c14f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The mock module has been added to Python 3.3 as unittest.mock."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The third party mock module doesn\u0027t seem to be maintained anymore:"},{"line_number":12,"context_line":"the last commit was in April 2013. unittest.mock is more recent,"},{"line_number":13,"context_line":"has less bugs and is compatible with Python 3.4. There are"},{"line_number":14,"context_line":"bugs on Python 3 in the third party mock module,"},{"line_number":15,"context_line":"examples:"},{"line_number":16,"context_line":"* https://code.google.com/p/mock/issues/detail?id\u003d225"},{"line_number":17,"context_line":"* https://code.google.com/p/mock/issues/detail?id\u003d234"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"oslotest prepares mock for six in oslotest/__init__.py as follow:"},{"line_number":20,"context_line":"six.add_move(six.MovedModule(\u0027mock\u0027, \u0027mock\u0027, \u0027unittest.mock\u0027)) and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa31d9ce_7072684b","line":17,"range":{"start_line":11,"start_character":0,"end_line":17,"end_character":53},"in_reply_to":"fa31d9ce_b0022008","updated":"2017-02-16 09:22:23.000000000","message":"Done","commit_id":"1d7c93e427b0520ac427402f0583794c665330ae"}],"ironic/tests/__init__.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bbf74da06cd6ad04f7d0cd994c2b987a98d2fe4c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# six.add_move(six.MovedModule(\u0027mock\u0027, \u0027mock\u0027, \u0027unittest.mock\u0027)) and"},{"line_number":3,"context_line":"# ironic imports oslotest before importing test submodules to setup"},{"line_number":4,"context_line":"# six.moves for mock, then \"from six.moves import mock\" works well."},{"line_number":5,"context_line":"import oslotest  # noqa"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_3a49d8b7","line":5,"updated":"2017-02-15 13:48:40.000000000","message":"Would it be better to move this to unittests foder? As they should be the only consumers of mock.","commit_id":"b595b4864eb47fe509994658c156306de5df3a31"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"f857e141e5ad8e301e81a16ab4cba6af677204dc","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# six.add_move(six.MovedModule(\u0027mock\u0027, \u0027mock\u0027, \u0027unittest.mock\u0027)) and"},{"line_number":3,"context_line":"# ironic imports oslotest before importing test submodules to setup"},{"line_number":4,"context_line":"# six.moves for mock, then \"from six.moves import mock\" works well."},{"line_number":5,"context_line":"import oslotest  # noqa"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_4d3a549a","line":5,"in_reply_to":"fa31d9ce_3a49d8b7","updated":"2017-02-15 14:04:15.000000000","message":"yes, we can","commit_id":"b595b4864eb47fe509994658c156306de5df3a31"}],"ironic/tests/unit/drivers/modules/test_console_utils.py":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"bbf74da06cd6ad04f7d0cd994c2b987a98d2fe4c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from oslo_config import cfg"},{"line_number":31,"context_line":"from oslo_utils import netutils"},{"line_number":32,"context_line":"from six.moves import mock"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"from ironic.common import exception"},{"line_number":36,"context_line":"from ironic.drivers.modules import console_utils"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_9a0ba47c","line":33,"updated":"2017-02-15 13:48:40.000000000","message":"nit - extra line","commit_id":"b595b4864eb47fe509994658c156306de5df3a31"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"f857e141e5ad8e301e81a16ab4cba6af677204dc","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from oslo_config import cfg"},{"line_number":31,"context_line":"from oslo_utils import netutils"},{"line_number":32,"context_line":"from six.moves import mock"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"from ironic.common import exception"},{"line_number":36,"context_line":"from ironic.drivers.modules import console_utils"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa31d9ce_eda14895","line":33,"in_reply_to":"fa31d9ce_9a0ba47c","updated":"2017-02-15 14:04:15.000000000","message":"Done","commit_id":"b595b4864eb47fe509994658c156306de5df3a31"}]}
