)]}'
{"ironic/api/controllers/v1/driver.py":[{"author":{"_account_id":10453,"name":"octopuszhang","email":"zhangyf@rc.inesa.com","username":"1"},"change_message_id":"bde884689c3e9e4bb90950c1d2b567ac07987d7a","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                       the \u0027type\u0027 field and default/enabled interfaces fields."},{"line_number":118,"context_line":"        :param interface_info: optional list of dicts of hardware interface"},{"line_number":119,"context_line":"                               info."},{"line_number":120,"context_line":"        :returns: an API-serializable driver object."},{"line_number":121,"context_line":"        \"\"\""},{"line_number":122,"context_line":"        driver \u003d Driver()"},{"line_number":123,"context_line":"        driver.name \u003d name"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_13405635","line":120,"range":{"start_line":120,"start_character":18,"end_line":120,"end_character":20},"updated":"2017-02-16 09:41:44.000000000","message":"I suggest that you fix all kind of error like this in this project, or the value of this patch is too small.","commit_id":"f2d88f04a7f08195af6a379013146650c1d0165b"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"221c04c36c5003129b6efe4150d2a04053cf0ccc","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                       the \u0027type\u0027 field and default/enabled interfaces fields."},{"line_number":118,"context_line":"        :param interface_info: optional list of dicts of hardware interface"},{"line_number":119,"context_line":"                               info."},{"line_number":120,"context_line":"        :returns: an API-serializable driver object."},{"line_number":121,"context_line":"        \"\"\""},{"line_number":122,"context_line":"        driver \u003d Driver()"},{"line_number":123,"context_line":"        driver.name \u003d name"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_617b6a2a","line":120,"range":{"start_line":120,"start_character":18,"end_line":120,"end_character":20},"in_reply_to":"fa31d9ce_13405635","updated":"2017-02-16 15:13:16.000000000","message":"Please, there is no end to the stuff that can be improved in ironic. I don\u0027t think this warrants changing, whether we put \u0027an\u0027 there or not. should we also then change in L112, to \u0027the name of a driver or a hardware type\u0027?","commit_id":"f2d88f04a7f08195af6a379013146650c1d0165b"},{"author":{"_account_id":22226,"name":"Varun Gadiraju","email":"varun.gadiraju@intel.com","username":"gadirajv"},"change_message_id":"e7f863aaa37e498b78ff64645a57e820401f0454","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                       the \u0027type\u0027 field and default/enabled interfaces fields."},{"line_number":118,"context_line":"        :param interface_info: optional list of dicts of hardware interface"},{"line_number":119,"context_line":"                               info."},{"line_number":120,"context_line":"        :returns: an API-serializable driver object."},{"line_number":121,"context_line":"        \"\"\""},{"line_number":122,"context_line":"        driver \u003d Driver()"},{"line_number":123,"context_line":"        driver.name \u003d name"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_bc4e36bf","line":120,"range":{"start_line":120,"start_character":18,"end_line":120,"end_character":20},"in_reply_to":"fa31d9ce_617b6a2a","updated":"2017-02-17 18:43:27.000000000","message":"this does not need to be changed. In technical writing there is no need for an article (a/an) preceding the noun in instances like this. Don\u0027t worry about making these sorts of changes, there is no error :)","commit_id":"f2d88f04a7f08195af6a379013146650c1d0165b"},{"author":{"_account_id":22226,"name":"Varun Gadiraju","email":"varun.gadiraju@intel.com","username":"gadirajv"},"change_message_id":"e7f863aaa37e498b78ff64645a57e820401f0454","unresolved":false,"context_lines":[{"line_number":242,"context_line":"class DriverPassthruController(rest.RestController):"},{"line_number":243,"context_line":"    \"\"\"REST controller for driver passthru."},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    This controller allows vendors to expose cross-node functionality in the"},{"line_number":246,"context_line":"    Ironic API. Ironic will merely relay the message from here to the specified"},{"line_number":247,"context_line":"    driver, no introspection will be made in the message body."},{"line_number":248,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa31d9ce_fcc6ee14","line":245,"range":{"start_line":245,"start_character":20,"end_line":245,"end_character":26},"updated":"2017-02-17 18:43:27.000000000","message":"this is fine. However, +1 Ruby\u0027s comment that these changes have little effect because this typo is for just a comment in a code file, not a published doc. The comment was already understood clearly - this change is a technical nitpick that doesn\u0027t really make a difference. Typos in docs, however, are issues and are worthwhile fixes.","commit_id":"f2d88f04a7f08195af6a379013146650c1d0165b"}]}
