)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"5fdf70c6d3c35e56b4cfccd1fc3aaa644d316e63","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shivanand Tendulker \u003cstendulker@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-28 22:51:05 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add hardware type for HPE Proliant iLO 4 based servers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added Hardware types \u0027hpe-ilo-virtual-media\u0027 and \u0027hpe-ilo-pxe\u0027"},{"line_number":10,"context_line":"for HPE Proliant iLO 4 based servers"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba2be162_c9214a4f","line":7,"range":{"start_line":7,"start_character":35,"end_line":7,"end_character":40},"updated":"2017-03-02 11:22:38.000000000","message":"I am not sure about this. Do we need to specify iLO version?","commit_id":"704afeee316eba93bf870ac9889c03c75853408a"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"5fdf70c6d3c35e56b4cfccd1fc3aaa644d316e63","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shivanand Tendulker \u003cstendulker@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-28 22:51:05 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add hardware type for HPE Proliant iLO 4 based servers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added Hardware types \u0027hpe-ilo-virtual-media\u0027 and \u0027hpe-ilo-pxe\u0027"},{"line_number":10,"context_line":"for HPE Proliant iLO 4 based servers"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba2be162_a945f617","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":17},"updated":"2017-03-02 11:22:38.000000000","message":"nit: \"types\"","commit_id":"704afeee316eba93bf870ac9889c03c75853408a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2ccedc5dfd7a55e13ca7c94cdee5245507127725","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shivanand Tendulker \u003cstendulker@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-28 22:51:05 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add hardware type for HPE Proliant iLO 4 based servers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added Hardware types \u0027hpe-ilo-virtual-media\u0027 and \u0027hpe-ilo-pxe\u0027"},{"line_number":10,"context_line":"for HPE Proliant iLO 4 based servers"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba2be162_b839a9d9","line":7,"range":{"start_line":7,"start_character":13,"end_line":7,"end_character":17},"in_reply_to":"ba2be162_a945f617","updated":"2017-03-03 03:12:45.000000000","message":"Done","commit_id":"704afeee316eba93bf870ac9889c03c75853408a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2ccedc5dfd7a55e13ca7c94cdee5245507127725","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Shivanand Tendulker \u003cstendulker@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-02-28 22:51:05 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add hardware type for HPE Proliant iLO 4 based servers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added Hardware types \u0027hpe-ilo-virtual-media\u0027 and \u0027hpe-ilo-pxe\u0027"},{"line_number":10,"context_line":"for HPE Proliant iLO 4 based servers"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba2be162_d81bbd71","line":7,"range":{"start_line":7,"start_character":35,"end_line":7,"end_character":40},"in_reply_to":"ba2be162_c9214a4f","updated":"2017-03-03 03:12:45.000000000","message":"Yes. These types are applicable only for iLO 4 based servers.","commit_id":"704afeee316eba93bf870ac9889c03c75853408a"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"c1bee8d4a2e8ad159a7ac0abda329b67ed5a8532","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add hardware type for HPE ProLiant servers based on iLO 4"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added hardware type \u0027ilo\u0027 for HPE ProLiant servers based on iLO 4"},{"line_number":10,"context_line":"management engine."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id2186717633630fabe11041634759adb3b74a0f9"},{"line_number":13,"context_line":"Closes-Bug: #1666787"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a1ced50_fc173b42","line":10,"updated":"2017-03-22 18:32:50.000000000","message":"What will we use when iLO 5 machines exist? Should this be \u0027ilo4\u0027?","commit_id":"8072c16492dca0b2fcbbb4245717b86e6b00fcdd"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e49326167ffb21f7cb48f80207be2d1beb5b41ee","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add hardware type for HPE ProLiant servers based on iLO 4"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added hardware type \u0027ilo\u0027 for HPE ProLiant servers based on iLO 4"},{"line_number":10,"context_line":"management engine."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id2186717633630fabe11041634759adb3b74a0f9"},{"line_number":13,"context_line":"Closes-Bug: #1666787"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ffe62b97_b0351afa","line":10,"in_reply_to":"1a1ced50_fc173b42","updated":"2017-03-24 12:12:28.000000000","message":"iLO5 systems would only support Redfish. These interfaces may not work as is.  We have not tested this on iLO5 hardware and hence the message.","commit_id":"8072c16492dca0b2fcbbb4245717b86e6b00fcdd"}],"ironic/drivers/ilo.py":[{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"5fdf70c6d3c35e56b4cfccd1fc3aaa644d316e63","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from ironic.drivers import base"},{"line_number":23,"context_line":"from ironic.drivers import generic"},{"line_number":24,"context_line":"from ironic.drivers.modules import agent"},{"line_number":25,"context_line":"from ironic.drivers.modules.ilo import boot"},{"line_number":26,"context_line":"from ironic.drivers.modules.ilo import console"},{"line_number":27,"context_line":"from ironic.drivers.modules.ilo import deploy"},{"line_number":28,"context_line":"from ironic.drivers.modules.ilo import inspect"},{"line_number":29,"context_line":"from ironic.drivers.modules.ilo import management"},{"line_number":30,"context_line":"from ironic.drivers.modules.ilo import power"},{"line_number":31,"context_line":"from ironic.drivers.modules.ilo import vendor"},{"line_number":32,"context_line":"from ironic.drivers.modules import inspector"},{"line_number":33,"context_line":"from ironic.drivers.modules import ipmitool"},{"line_number":34,"context_line":"from ironic.drivers.modules import noop"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_73092bdd","line":31,"range":{"start_line":25,"start_character":0,"end_line":31,"end_character":45},"updated":"2017-03-02 11:22:38.000000000","message":"Suggest to rename them to reflect the load path while importing so as to improve the readability. \n\nfrom ironic.drivers.modules.ilo import boot as ilo_boot\nfrom ironic.drivers.modules.ilo import console as ilo_console\nfrom ironic.drivers.modules.ilo import deploy as ilo_deploy","commit_id":"704afeee316eba93bf870ac9889c03c75853408a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2ccedc5dfd7a55e13ca7c94cdee5245507127725","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from ironic.drivers import base"},{"line_number":23,"context_line":"from ironic.drivers import generic"},{"line_number":24,"context_line":"from ironic.drivers.modules import agent"},{"line_number":25,"context_line":"from ironic.drivers.modules.ilo import boot"},{"line_number":26,"context_line":"from ironic.drivers.modules.ilo import console"},{"line_number":27,"context_line":"from ironic.drivers.modules.ilo import deploy"},{"line_number":28,"context_line":"from ironic.drivers.modules.ilo import inspect"},{"line_number":29,"context_line":"from ironic.drivers.modules.ilo import management"},{"line_number":30,"context_line":"from ironic.drivers.modules.ilo import power"},{"line_number":31,"context_line":"from ironic.drivers.modules.ilo import vendor"},{"line_number":32,"context_line":"from ironic.drivers.modules import inspector"},{"line_number":33,"context_line":"from ironic.drivers.modules import ipmitool"},{"line_number":34,"context_line":"from ironic.drivers.modules import noop"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_8acf2e7e","line":31,"range":{"start_line":25,"start_character":0,"end_line":31,"end_character":45},"in_reply_to":"ba2be162_73092bdd","updated":"2017-03-03 03:12:45.000000000","message":"This is out of scope for this patch.","commit_id":"704afeee316eba93bf870ac9889c03c75853408a"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"5fdf70c6d3c35e56b4cfccd1fc3aaa644d316e63","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self.raid \u003d agent.AgentRAID()"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"class IloVirtualMediaHardware(generic.GenericHardware):"},{"line_number":90,"context_line":"    \"\"\"iLO Virtual Media hardware type."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    iLO Virtual Media hardware type is targeted for iLO 4 based Proliant Gen8"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_d396574b","line":89,"range":{"start_line":89,"start_character":6,"end_line":89,"end_character":21},"updated":"2017-03-02 11:22:38.000000000","message":"I can see below that we are defining a class \"IloPxeHardware\" which is derived from \"IloVirtualMediaHardware\". IMO this is paradoxical in the sense that \"pxe\" boot and \"virtual media\" boot are the base properties for which we made a choice to divide them into different classes. \n    I suggest, we create a base class \"HPEIloHardware\"/ \"IloHardware\", define default interfaces and derive \"IloPxeHardware\"  and \"IloVirtualMediaHardware\" from it to override the necessary interfaces. For instance in both classes we can override \"supported_boot_interfaces\" and \"supported_deploy_interfaces\". Like, for the case of \"IloVirtualMediaHardware\":\n\n    @property\n    def supported_boot_interfaces(self):\n        \"\"\"List of supported boot interfaces.\"\"\"\n        return [boot.IloVirtualMediaBoot]\n\n    @property\n    def supported_deploy_interfaces(self):\n        \"\"\"List of supported deploy interfaces.\"\"\"\n        return [deploy.IloVirtualMediaAgentDeploy]","commit_id":"704afeee316eba93bf870ac9889c03c75853408a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2ccedc5dfd7a55e13ca7c94cdee5245507127725","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self.raid \u003d agent.AgentRAID()"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"class IloVirtualMediaHardware(generic.GenericHardware):"},{"line_number":90,"context_line":"    \"\"\"iLO Virtual Media hardware type."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    iLO Virtual Media hardware type is targeted for iLO 4 based Proliant Gen8"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_ca59265c","line":89,"range":{"start_line":89,"start_character":6,"end_line":89,"end_character":21},"in_reply_to":"ba2be162_d396574b","updated":"2017-03-03 03:12:45.000000000","message":"I understand, but any class that derives from GenericHardware would have pre-defined deploy and boot interfaces which are not applicable to iLODriver types, hence have defined them in this fashion.","commit_id":"704afeee316eba93bf870ac9889c03c75853408a"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"5fdf70c6d3c35e56b4cfccd1fc3aaa644d316e63","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    @property"},{"line_number":102,"context_line":"    def supported_deploy_interfaces(self):"},{"line_number":103,"context_line":"        \"\"\"List of supported deploy interfaces.\"\"\""},{"line_number":104,"context_line":"        return [deploy.IloVirtualMediaAgentDeploy]"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    @property"},{"line_number":107,"context_line":"    def supported_console_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_33c1732f","line":104,"range":{"start_line":104,"start_character":23,"end_line":104,"end_character":50},"updated":"2017-03-02 11:22:38.000000000","message":"May be the name \"IloAgentDeploy\" aptly suits here.","commit_id":"704afeee316eba93bf870ac9889c03c75853408a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2ccedc5dfd7a55e13ca7c94cdee5245507127725","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    @property"},{"line_number":102,"context_line":"    def supported_deploy_interfaces(self):"},{"line_number":103,"context_line":"        \"\"\"List of supported deploy interfaces.\"\"\""},{"line_number":104,"context_line":"        return [deploy.IloVirtualMediaAgentDeploy]"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    @property"},{"line_number":107,"context_line":"    def supported_console_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_caae8684","line":104,"range":{"start_line":104,"start_character":23,"end_line":104,"end_character":50},"in_reply_to":"ba2be162_33c1732f","updated":"2017-03-03 03:12:45.000000000","message":"deploy.IloVirtualMediaAgentDeploy is the existing class name\nhttps://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/deploy.py#L241","commit_id":"704afeee316eba93bf870ac9889c03c75853408a"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"ac9cad9df6dca276465b61a6c7655ba5cfbefbeb","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    \"\"\"iLO PXE hardware type."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    iLO PXE hardware type is targeted for iLO 4 based Proliant Gen8"},{"line_number":133,"context_line":"    and Gen9 servers for PXE based provisioning."},{"line_number":134,"context_line":"    \"\"\""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_7cb693dd","line":133,"range":{"start_line":133,"start_character":25,"end_line":133,"end_character":28},"updated":"2017-03-01 12:45:26.000000000","message":"nit:PXE boot and ISCSI based provisioning.","commit_id":"704afeee316eba93bf870ac9889c03c75853408a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2ccedc5dfd7a55e13ca7c94cdee5245507127725","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    \"\"\"iLO PXE hardware type."},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    iLO PXE hardware type is targeted for iLO 4 based Proliant Gen8"},{"line_number":133,"context_line":"    and Gen9 servers for PXE based provisioning."},{"line_number":134,"context_line":"    \"\"\""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_38a219fe","line":133,"range":{"start_line":133,"start_character":25,"end_line":133,"end_character":28},"in_reply_to":"ba2be162_7cb693dd","updated":"2017-03-03 03:12:45.000000000","message":"Done","commit_id":"704afeee316eba93bf870ac9889c03c75853408a"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"1f4f09afa5b7cac99abc2153e89e8149c78abffe","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    @property"},{"line_number":113,"context_line":"    def supported_inspect_interfaces(self):"},{"line_number":114,"context_line":"        \"\"\"List of supported inspect interfaces.\"\"\""},{"line_number":115,"context_line":"        return [inspect.IloInspect, inspector.Inspector,"},{"line_number":116,"context_line":"                noop.NoInspect]"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_11f2c76f","line":115,"range":{"start_line":115,"start_character":36,"end_line":115,"end_character":55},"updated":"2017-03-08 07:30:09.000000000","message":"We cannot have this until Inspector supports virtual media.","commit_id":"bc38a94c09dcd4de3f9e2dec0e4280807832209d"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"1f4f09afa5b7cac99abc2153e89e8149c78abffe","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    iLO PXE hardware type is targeted for iLO 4 based Proliant Gen8"},{"line_number":133,"context_line":"    and Gen9 servers for PXE boot and ISCSI based provisioning."},{"line_number":134,"context_line":"    \"\"\""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    @property"},{"line_number":137,"context_line":"    def supported_boot_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a30ddce_b1fd7b3c","line":134,"updated":"2017-03-08 07:30:09.000000000","message":"The supported_inspect_interfaces() can be added here for pxe hardware and Inspector support can also be added.","commit_id":"bc38a94c09dcd4de3f9e2dec0e4280807832209d"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f8551297553243e2b2cceb0daa0504c089540aae","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self.raid \u003d agent.AgentRAID()"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"class IloVirtualMediaHardware(generic.GenericHardware):"},{"line_number":90,"context_line":"    \"\"\"iLO Virtual Media hardware type."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    iLO Virtual Media hardware type is targeted for iLO 4 based Proliant Gen8"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_b975f9fa","line":89,"updated":"2017-03-10 11:47:31.000000000","message":"this is not how things are designed. You need to have one IloHardware type with two boot options: IloVirtualMediaBoot and PXEBoot. You may have to consolidate two deploy classes in one.","commit_id":"346e0f4e1737ef4b22caebf0ed5110f5dc5d8bee"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"360e70abfab6ad784d7f4e4a357003e3f4f050cb","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self.raid \u003d agent.AgentRAID()"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"class IloVirtualMediaHardware(generic.GenericHardware):"},{"line_number":90,"context_line":"    \"\"\"iLO Virtual Media hardware type."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    iLO Virtual Media hardware type is targeted for iLO 4 based Proliant Gen8"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_da9a9b6d","line":89,"in_reply_to":"9a30ddce_74c6289b","updated":"2017-03-10 12:54:38.000000000","message":"\u003e one cannot use deploy.IloVirtualMediaAgentDeploy with pxe.PXEBoot\n\nyou need to fix the deploy method(s) to not imply a boot one. this may involve additions to the boot interface. but what you\u0027re creating is not a hardware type, it\u0027s a classic driver with new API.","commit_id":"346e0f4e1737ef4b22caebf0ed5110f5dc5d8bee"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6c395b03fd175459638c73084f1752e633af5c0b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self.raid \u003d agent.AgentRAID()"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"class IloVirtualMediaHardware(generic.GenericHardware):"},{"line_number":90,"context_line":"    \"\"\"iLO Virtual Media hardware type."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    iLO Virtual Media hardware type is targeted for iLO 4 based Proliant Gen8"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_74c6289b","line":89,"in_reply_to":"9a30ddce_b975f9fa","updated":"2017-03-10 12:27:27.000000000","message":"They were separated as one cannot use deploy.IloVirtualMediaAgentDeploy with pxe.PXEBoot. It would fail. Hence the separation. Else it would need to handle it through documentation.","commit_id":"346e0f4e1737ef4b22caebf0ed5110f5dc5d8bee"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"87ede0dc16b5ce939dab533d24d3b279a225eb46","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self.raid \u003d agent.AgentRAID()"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"class IloVirtualMediaHardware(generic.GenericHardware):"},{"line_number":90,"context_line":"    \"\"\"iLO Virtual Media hardware type."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    iLO Virtual Media hardware type is targeted for iLO 4 based Proliant Gen8"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_0ed7984b","line":89,"in_reply_to":"9a30ddce_da9a9b6d","updated":"2017-03-10 13:17:36.000000000","message":"I think combination of deploy.IloVirtualMediaAgentDeploy  and pxe.IloPXEBoot  should just work. I will test and get back to you as long as node has driver_info properties that could satisfy respective interfaces.","commit_id":"346e0f4e1737ef4b22caebf0ed5110f5dc5d8bee"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f8551297553243e2b2cceb0daa0504c089540aae","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    @property"},{"line_number":118,"context_line":"    def supported_management_interfaces(self):"},{"line_number":119,"context_line":"        \"\"\"List of supported management interfaces.\"\"\""},{"line_number":120,"context_line":"        return [management.IloManagement]"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @property"},{"line_number":123,"context_line":"    def supported_power_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_d972ad10","line":120,"updated":"2017-03-10 11:47:31.000000000","message":"you allow IPMIPower below, won\u0027t it make sense to allow allow IPMIManagement here?","commit_id":"346e0f4e1737ef4b22caebf0ed5110f5dc5d8bee"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"360e70abfab6ad784d7f4e4a357003e3f4f050cb","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    @property"},{"line_number":118,"context_line":"    def supported_management_interfaces(self):"},{"line_number":119,"context_line":"        \"\"\"List of supported management interfaces.\"\"\""},{"line_number":120,"context_line":"        return [management.IloManagement]"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @property"},{"line_number":123,"context_line":"    def supported_power_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_7a7e0f1a","line":120,"in_reply_to":"9a30ddce_54d4c4bb","updated":"2017-03-10 12:54:38.000000000","message":"Let\u0027s drop IPMIPower for now maybe? We can always add it later.","commit_id":"346e0f4e1737ef4b22caebf0ed5110f5dc5d8bee"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6c395b03fd175459638c73084f1752e633af5c0b","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    @property"},{"line_number":118,"context_line":"    def supported_management_interfaces(self):"},{"line_number":119,"context_line":"        \"\"\"List of supported management interfaces.\"\"\""},{"line_number":120,"context_line":"        return [management.IloManagement]"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @property"},{"line_number":123,"context_line":"    def supported_power_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_54d4c4bb","line":120,"in_reply_to":"9a30ddce_d972ad10","updated":"2017-03-10 12:27:27.000000000","message":"Oh my mistake. I thought nmi_inject is part of Power interface. BUt its part of management interface.\nNMI inject supported as a power operation in few of the ProLiant platforms. http://h22208.www2.hpe.com/eginfolib/servers/docs/HPRestfultool/iLo4/data_model_reference.html\n\nSince NMI is not consistently supported through iLO wanted to add IPMI interface for the same.\nBut if I were to add IPMIManagement as supported interfaces then one cannot use the iLO based deploy and boot interfaces. This hardware type would have to support all the boot and deploy interfaces from GenericHardware\n\nMay be we can implement inject_nmi as part of the IloPower and fallback to IPMIPower implementation internally.\n\nWhat do you suggest?","commit_id":"346e0f4e1737ef4b22caebf0ed5110f5dc5d8bee"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f8551297553243e2b2cceb0daa0504c089540aae","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        return [power.IloPower, ipmitool.IPMIPower]"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"class IloPxeHardware(IloVirtualMediaHardware):"},{"line_number":129,"context_line":"    \"\"\"iLO PXE hardware type."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    iLO PXE hardware type is targeted for iLO 4 based Proliant Gen8"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_f961313a","line":128,"updated":"2017-03-10 11:47:31.000000000","message":"this should not exist as a separate hardware type.","commit_id":"346e0f4e1737ef4b22caebf0ed5110f5dc5d8bee"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"360e70abfab6ad784d7f4e4a357003e3f4f050cb","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        return [power.IloPower, ipmitool.IPMIPower]"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"class IloPxeHardware(IloVirtualMediaHardware):"},{"line_number":129,"context_line":"    \"\"\"iLO PXE hardware type."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    iLO PXE hardware type is targeted for iLO 4 based Proliant Gen8"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_5a9ceb5c","line":128,"in_reply_to":"9a30ddce_b4e340a3","updated":"2017-03-10 12:54:38.000000000","message":"My comments stays the same: for one hardware we need one hardware type. I\u0027m absolutely -2 on having two hardware types for the same hardware. I\u0027m open to required additions to the boot interface and/or other interfaces to allow you to fix your deploy interfaces to be boot-agnostic.","commit_id":"346e0f4e1737ef4b22caebf0ed5110f5dc5d8bee"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6c395b03fd175459638c73084f1752e633af5c0b","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        return [power.IloPower, ipmitool.IPMIPower]"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"class IloPxeHardware(IloVirtualMediaHardware):"},{"line_number":129,"context_line":"    \"\"\"iLO PXE hardware type."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    iLO PXE hardware type is targeted for iLO 4 based Proliant Gen8"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_b4e340a3","line":128,"in_reply_to":"9a30ddce_f961313a","updated":"2017-03-10 12:27:27.000000000","message":"Same as above","commit_id":"346e0f4e1737ef4b22caebf0ed5110f5dc5d8bee"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5b2a3c62659593726ccf929be2856e4ace7ba347","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    @property"},{"line_number":101,"context_line":"    def supported_deploy_interfaces(self):"},{"line_number":102,"context_line":"        \"\"\"List of supported deploy interfaces.\"\"\""},{"line_number":103,"context_line":"        return [deploy.IloVirtualMediaAgentDeploy]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @property"},{"line_number":106,"context_line":"    def supported_console_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a1ced50_d338b2d5","line":103,"updated":"2017-03-22 17:28:59.000000000","message":"I assume you made sure that PXEBoot works with IloVirtualMediaAgentDeploy. If so, let us rename it to just IloAgentDeploy? Otherwise it looks confusing.\n\nAlso, do I get it right that you don\u0027t want to support iSCSI deploy with this hardware type? It\u0027s worth mentioning in the release note.","commit_id":"8072c16492dca0b2fcbbb4245717b86e6b00fcdd"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e49326167ffb21f7cb48f80207be2d1beb5b41ee","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    @property"},{"line_number":101,"context_line":"    def supported_deploy_interfaces(self):"},{"line_number":102,"context_line":"        \"\"\"List of supported deploy interfaces.\"\"\""},{"line_number":103,"context_line":"        return [deploy.IloVirtualMediaAgentDeploy]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @property"},{"line_number":106,"context_line":"    def supported_console_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ffe62b97_330fd42f","line":103,"in_reply_to":"1a1ced50_d338b2d5","updated":"2017-03-24 12:12:28.000000000","message":"Ok. But if we change the class to IloVirtualMediaAgentDeploy it would affect the classic drivers as well. Changing the classname should not have any impact on classic driver end-user as all that he cares about is the driver-name \u0027agent_ilo\u0027.\n\nSince functionality wise iscsi and agent based deploy are same. Were thinking of keeping only agent based deploy. \nDo you see any issue in restricting it to agent based deploy?\nWill update release notes as well.","commit_id":"8072c16492dca0b2fcbbb4245717b86e6b00fcdd"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"c1bee8d4a2e8ad159a7ac0abda329b67ed5a8532","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    @property"},{"line_number":117,"context_line":"    def supported_management_interfaces(self):"},{"line_number":118,"context_line":"        \"\"\"List of supported management interfaces.\"\"\""},{"line_number":119,"context_line":"        return [management.IloManagement]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @property"},{"line_number":122,"context_line":"    def supported_power_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a1ced50_813d04df","line":119,"updated":"2017-03-22 18:32:50.000000000","message":"Does IPMI work with these machines?","commit_id":"8072c16492dca0b2fcbbb4245717b86e6b00fcdd"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e49326167ffb21f7cb48f80207be2d1beb5b41ee","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    @property"},{"line_number":117,"context_line":"    def supported_management_interfaces(self):"},{"line_number":118,"context_line":"        \"\"\"List of supported management interfaces.\"\"\""},{"line_number":119,"context_line":"        return [management.IloManagement]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    @property"},{"line_number":122,"context_line":"    def supported_power_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ffe62b97_73267cba","line":119,"in_reply_to":"1a1ced50_813d04df","updated":"2017-03-24 12:12:28.000000000","message":"It should work. But have not tested it.","commit_id":"8072c16492dca0b2fcbbb4245717b86e6b00fcdd"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"c1bee8d4a2e8ad159a7ac0abda329b67ed5a8532","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    @property"},{"line_number":122,"context_line":"    def supported_power_interfaces(self):"},{"line_number":123,"context_line":"        \"\"\"List of supported power interfaces.\"\"\""},{"line_number":124,"context_line":"        return [power.IloPower]"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a1ced50_c1237cbb","line":124,"updated":"2017-03-22 18:32:50.000000000","message":"Ditto","commit_id":"8072c16492dca0b2fcbbb4245717b86e6b00fcdd"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e49326167ffb21f7cb48f80207be2d1beb5b41ee","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    @property"},{"line_number":122,"context_line":"    def supported_power_interfaces(self):"},{"line_number":123,"context_line":"        \"\"\"List of supported power interfaces.\"\"\""},{"line_number":124,"context_line":"        return [power.IloPower]"}],"source_content_type":"text/x-python","patch_set":5,"id":"ffe62b97_533b78d0","line":124,"in_reply_to":"1a1ced50_c1237cbb","updated":"2017-03-24 12:12:28.000000000","message":"It should work. But have not tested it.","commit_id":"8072c16492dca0b2fcbbb4245717b86e6b00fcdd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8069c6a47c50ad385fbb4108cd5e0d5cbc1c6e92","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    @property"},{"line_number":96,"context_line":"    def supported_boot_interfaces(self):"},{"line_number":97,"context_line":"        \"\"\"List of supported boot interfaces.\"\"\""},{"line_number":98,"context_line":"        return [boot.IloVirtualMediaBoot, pxe.PXEBoot]"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @property"},{"line_number":101,"context_line":"    def supported_deploy_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"dfeb2761_5c9ea3b8","line":98,"range":{"start_line":98,"start_character":42,"end_line":98,"end_character":53},"updated":"2017-04-03 12:24:40.000000000","message":"should be new IloPXEBoot","commit_id":"a9f8686f9ad5f0706c1206a75b59517d4d56ca24"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"308c2fbc10a27e680cc1ef35ee10fb42c5849f97","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    @property"},{"line_number":96,"context_line":"    def supported_boot_interfaces(self):"},{"line_number":97,"context_line":"        \"\"\"List of supported boot interfaces.\"\"\""},{"line_number":98,"context_line":"        return [boot.IloVirtualMediaBoot, pxe.PXEBoot]"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @property"},{"line_number":101,"context_line":"    def supported_deploy_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"dfeb2761_2544bfb6","line":98,"range":{"start_line":98,"start_character":42,"end_line":98,"end_character":53},"in_reply_to":"dfeb2761_5c9ea3b8","updated":"2017-04-04 15:40:08.000000000","message":"Done","commit_id":"a9f8686f9ad5f0706c1206a75b59517d4d56ca24"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"8069c6a47c50ad385fbb4108cd5e0d5cbc1c6e92","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    @property"},{"line_number":101,"context_line":"    def supported_deploy_interfaces(self):"},{"line_number":102,"context_line":"        \"\"\"List of supported deploy interfaces.\"\"\""},{"line_number":103,"context_line":"        return [agent.AgentDeploy]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @property"},{"line_number":106,"context_line":"    def supported_console_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"dfeb2761_bcb80f2a","line":103,"updated":"2017-04-03 12:24:40.000000000","message":"I\u0027d prefer we don\u0027t exclude IscsiDeploy, unless it\u0027s impossible to make work with iLO","commit_id":"a9f8686f9ad5f0706c1206a75b59517d4d56ca24"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3c217e563a4755e6808837057bcd9d96fcdedd88","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        self.raid \u003d agent.AgentRAID()"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class IloHardware(generic.GenericHardware):"},{"line_number":88,"context_line":"    \"\"\"iLO hardware type."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    iLO hardware type is targeted for iLO 4 based Proliant Gen8"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ff52f3f_ae34904b","line":87,"updated":"2017-04-13 15:49:47.000000000","message":"My preference (don\u0027t know if it is a nit or not), is for new hardware type classes to be at the top of the file, not the bottom. Because we want people to using the new hardware types, so I want them to be easy to see. (For eg, see \u0027ipmi.py\u0027 file.)","commit_id":"60589a7237a05592e5b8845238b525d954035a60"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2cfe9d5a59bedadb0d45d406e7eba065220658da","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        self.raid \u003d agent.AgentRAID()"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class IloHardware(generic.GenericHardware):"},{"line_number":88,"context_line":"    \"\"\"iLO hardware type."},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    iLO hardware type is targeted for iLO 4 based Proliant Gen8"}],"source_content_type":"text/x-python","patch_set":7,"id":"7ffa3b31_5647d84c","line":87,"in_reply_to":"9ff52f3f_ae34904b","updated":"2017-04-16 04:24:50.000000000","message":"Done","commit_id":"60589a7237a05592e5b8845238b525d954035a60"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3c217e563a4755e6808837057bcd9d96fcdedd88","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    @property"},{"line_number":100,"context_line":"    def supported_deploy_interfaces(self):"},{"line_number":101,"context_line":"        \"\"\"List of supported deploy interfaces.\"\"\""},{"line_number":102,"context_line":"        return [agent.AgentDeploy]"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @property"},{"line_number":105,"context_line":"    def supported_console_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ff52f3f_2e92c0f7","line":102,"updated":"2017-04-13 15:49:47.000000000","message":"so why isn\u0027t ISCSIDeploy here? Without it, it won\u0027t be possible to get a driver like IloVirtualMediaIscsiDriver\n\nI see that there are comments in the patch about this, but there is nothing IN the patch about it. My suggestion is to add a comment here that iscsi is not going to be supported, and also in the commit message.\n\nI think we plan on deprecating the classic drivers at some point, which means it won\u0027t be possible to get something like IloVirtualMediaIscsiDriver. I guess we\u0027ll cross that bridge when we get there.","commit_id":"60589a7237a05592e5b8845238b525d954035a60"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2cfe9d5a59bedadb0d45d406e7eba065220658da","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    @property"},{"line_number":100,"context_line":"    def supported_deploy_interfaces(self):"},{"line_number":101,"context_line":"        \"\"\"List of supported deploy interfaces.\"\"\""},{"line_number":102,"context_line":"        return [agent.AgentDeploy]"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    @property"},{"line_number":105,"context_line":"    def supported_console_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7ffa3b31_5660f8ce","line":102,"in_reply_to":"9ff52f3f_2e92c0f7","updated":"2017-04-16 04:24:50.000000000","message":"The reason being all the Ironic features supported by ISCSIDeploy are supported with agentDeploy. There is no additional advantage of having iscsi based deploy except for the cases wherein instance images(qcow2) are larger than RAM size of the bare metal. That also could be overcome by using \u0027raw\u0027 images.\nTo avoid the additional driver supportability and reduce test matrix, we are not supporting ISCSI based deploy.\nHowever, if any user insists for ISCSI based deploy, we would surely enable the same.\nDo let us know if we are missing any usecase wherein ISCSIDeploy is necessary.","commit_id":"60589a7237a05592e5b8845238b525d954035a60"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"53d89d743b69143d01ec147eca4611ca897adfe2","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def supported_deploy_interfaces(self):"},{"line_number":50,"context_line":"        \"\"\"List of supported deploy interfaces.\"\"\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        # (Note) It does not support ISCSI based deploy (iscsi.ISCSIDeploy())"},{"line_number":53,"context_line":"        # mechanism."},{"line_number":54,"context_line":"        return [agent.AgentDeploy]"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7ffa3b31_ddd18bfd","line":52,"updated":"2017-04-18 17:23:58.000000000","message":"s/(Note)/Note(shivanand)/ (or whatever your nic is, I forgot)","commit_id":"d75f216dad6a21f8e83d4e762233f017bef670df"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2dac005bd9f9d8b94ff86ac1e92494af89a4fb43","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def supported_deploy_interfaces(self):"},{"line_number":50,"context_line":"        \"\"\"List of supported deploy interfaces.\"\"\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        # (Note) It does not support ISCSI based deploy (iscsi.ISCSIDeploy())"},{"line_number":53,"context_line":"        # mechanism."},{"line_number":54,"context_line":"        return [agent.AgentDeploy]"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7ffa3b31_757cc3b4","line":52,"in_reply_to":"7ffa3b31_ddd18bfd","updated":"2017-04-19 03:44:14.000000000","message":"Done","commit_id":"d75f216dad6a21f8e83d4e762233f017bef670df"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"53d89d743b69143d01ec147eca4611ca897adfe2","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        \"\"\"List of supported deploy interfaces.\"\"\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        # (Note) It does not support ISCSI based deploy (iscsi.ISCSIDeploy())"},{"line_number":53,"context_line":"        # mechanism."},{"line_number":54,"context_line":"        return [agent.AgentDeploy]"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":9,"id":"7ffa3b31_dd898bca","line":53,"updated":"2017-04-18 17:23:58.000000000","message":"I\u0027d like to add \u0027so that there is no dynamic driver equivalent to IloVirtualMediaIscsiDriver (iscsi_ilo).\u0027 This is important, because when/if we deprecate classic drivers, it means that anyone using iscsi_ilo may have to make more changes than just changing the driver name/interfaces for a node.\n\nAlso why? Maybe add some of your comment:\n\nThe reason being all the Ironic features supported by ISCSIDeploy are supported with agentDeploy. There is no additional advantage of having iscsi based deploy except for the cases wherein instance images(qcow2) are larger than RAM size of the bare metal. That also could be overcome by using \u0027raw\u0027 images.\nTo avoid the additional driver supportability and reduce test matrix, we are not supporting ISCSI based deploy.\nHowever, if any user insists for ISCSI based deploy, we would surely enable the same.","commit_id":"d75f216dad6a21f8e83d4e762233f017bef670df"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2dac005bd9f9d8b94ff86ac1e92494af89a4fb43","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        \"\"\"List of supported deploy interfaces.\"\"\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        # (Note) It does not support ISCSI based deploy (iscsi.ISCSIDeploy())"},{"line_number":53,"context_line":"        # mechanism."},{"line_number":54,"context_line":"        return [agent.AgentDeploy]"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":9,"id":"7ffa3b31_b5092b32","line":53,"in_reply_to":"7ffa3b31_dd898bca","updated":"2017-04-19 03:44:14.000000000","message":"Yes. That would be better. Done.","commit_id":"d75f216dad6a21f8e83d4e762233f017bef670df"}],"ironic/tests/unit/drivers/test_ilo.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"53d89d743b69143d01ec147eca4611ca897adfe2","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                          ilo.IloVirtualMediaAgentDriver)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"class IloHardwareTestCase(db_base.DbTestCase):"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def setUp(self):"},{"line_number":91,"context_line":"        super(IloHardwareTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":9,"id":"7ffa3b31_1d3c93e0","line":88,"updated":"2017-04-18 17:23:58.000000000","message":"similar thing, nit, I\u0027d prefer if this was the first test class.","commit_id":"d75f216dad6a21f8e83d4e762233f017bef670df"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2dac005bd9f9d8b94ff86ac1e92494af89a4fb43","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                          ilo.IloVirtualMediaAgentDriver)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"class IloHardwareTestCase(db_base.DbTestCase):"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def setUp(self):"},{"line_number":91,"context_line":"        super(IloHardwareTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":9,"id":"7ffa3b31_901d1d68","line":88,"in_reply_to":"7ffa3b31_1d3c93e0","updated":"2017-04-19 03:44:14.000000000","message":"Done","commit_id":"d75f216dad6a21f8e83d4e762233f017bef670df"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"53d89d743b69143d01ec147eca4611ca897adfe2","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                                  noop.NoVendor)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def test_override_with_pxe(self):"},{"line_number":149,"context_line":"        self.config(enabled_boot_interfaces\u003d[\u0027ilo-virtual-media\u0027, \u0027ilo-pxe\u0027])"},{"line_number":150,"context_line":"        node \u003d obj_utils.create_test_node("},{"line_number":151,"context_line":"            self.context, driver\u003d\u0027ilo\u0027,"},{"line_number":152,"context_line":"            deploy_interface\u003d\u0027direct\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7ffa3b31_2023a2aa","line":149,"updated":"2017-04-18 17:23:58.000000000","message":"this isn\u0027t needed, is it? L93 above does this.","commit_id":"d75f216dad6a21f8e83d4e762233f017bef670df"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2dac005bd9f9d8b94ff86ac1e92494af89a4fb43","unresolved":false,"context_lines":[{"line_number":146,"context_line":"                                  noop.NoVendor)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def test_override_with_pxe(self):"},{"line_number":149,"context_line":"        self.config(enabled_boot_interfaces\u003d[\u0027ilo-virtual-media\u0027, \u0027ilo-pxe\u0027])"},{"line_number":150,"context_line":"        node \u003d obj_utils.create_test_node("},{"line_number":151,"context_line":"            self.context, driver\u003d\u0027ilo\u0027,"},{"line_number":152,"context_line":"            deploy_interface\u003d\u0027direct\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7ffa3b31_10234daa","line":149,"in_reply_to":"7ffa3b31_2023a2aa","updated":"2017-04-19 03:44:14.000000000","message":"Done","commit_id":"d75f216dad6a21f8e83d4e762233f017bef670df"}],"releasenotes/notes/ilo-hardware-type-48fd1c8bccd70659.yaml":[{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"6266920c8e0134879b2563fd88a00ee4ef0696ff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds new hardware type \u0027ilo\u0027 for iLO 4 based Proliant Gen 8 and"},{"line_number":4,"context_line":"    Gen 9 servers."},{"line_number":5,"context_line":"    \u0027ilo\u0027 hardware type will support virtual media and PXE based"},{"line_number":6,"context_line":"    provisioning using HPE iLO 4 management engine."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3a1ff146_87cfa8b2","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":12},"updated":"2017-03-14 14:12:44.000000000","message":"s/Adds new/Adds a new","commit_id":"8072c16492dca0b2fcbbb4245717b86e6b00fcdd"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e49326167ffb21f7cb48f80207be2d1beb5b41ee","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Adds new hardware type \u0027ilo\u0027 for iLO 4 based Proliant Gen 8 and"},{"line_number":4,"context_line":"    Gen 9 servers."},{"line_number":5,"context_line":"    \u0027ilo\u0027 hardware type will support virtual media and PXE based"},{"line_number":6,"context_line":"    provisioning using HPE iLO 4 management engine."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ffe62b97_7382fc51","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":12},"in_reply_to":"3a1ff146_87cfa8b2","updated":"2017-03-24 12:12:28.000000000","message":"Done","commit_id":"8072c16492dca0b2fcbbb4245717b86e6b00fcdd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"3c217e563a4755e6808837057bcd9d96fcdedd88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9ff52f3f_8ee1cc01","line":8,"updated":"2017-04-13 15:49:47.000000000","message":"I think we should also mention the ilo-related interfaces that you added. And/or the supported interfaces. Or do others think that is too much. Also, I forgot -- how were we going to document which interfaces were available for hardware types? Was it just via the API?","commit_id":"60589a7237a05592e5b8845238b525d954035a60"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2cfe9d5a59bedadb0d45d406e7eba065220658da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7ffa3b31_56b59830","line":8,"in_reply_to":"9ff52f3f_8ee1cc01","updated":"2017-04-16 04:24:50.000000000","message":"Updated. I think we would need additional documentation on driver page. Will update the iLO documentation based on the common feature documentation.","commit_id":"60589a7237a05592e5b8845238b525d954035a60"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"53d89d743b69143d01ec147eca4611ca897adfe2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    management - \u0027ilo\u0027"},{"line_number":13,"context_line":"    network - \u0027flat\u0027, \u0027no-op\u0027 and \u0027neutron\u0027"},{"line_number":14,"context_line":"    power - \u0027ilo\u0027"},{"line_number":15,"context_line":"    raid - \u0027no-raid\u0027 and \u0027agent\u0027"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7ffa3b31_fdb9e7e8","line":15,"updated":"2017-04-18 17:23:58.000000000","message":"Formatting is wonky: http://docs-draft.openstack.org/04/439404/9/check/gate-ironic-releasenotes/f8ff04a//releasenotes/build/html/unreleased.html.\n\nTry something like\n\nIt supports the following driver interfaces:\n\n* boot: ``ilo-virtual-media`` and ``ilo-pxe``\n* console: ``ilo`` and ``no-console``\netc","commit_id":"d75f216dad6a21f8e83d4e762233f017bef670df"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"2dac005bd9f9d8b94ff86ac1e92494af89a4fb43","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    management - \u0027ilo\u0027"},{"line_number":13,"context_line":"    network - \u0027flat\u0027, \u0027no-op\u0027 and \u0027neutron\u0027"},{"line_number":14,"context_line":"    power - \u0027ilo\u0027"},{"line_number":15,"context_line":"    raid - \u0027no-raid\u0027 and \u0027agent\u0027"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"7ffa3b31_30d64951","line":15,"in_reply_to":"7ffa3b31_fdb9e7e8","updated":"2017-04-19 03:44:14.000000000","message":"Done","commit_id":"d75f216dad6a21f8e83d4e762233f017bef670df"}],"setup.cfg":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f8551297553243e2b2cceb0daa0504c089540aae","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeBoot"},{"line_number":87,"context_line":"    pxe \u003d ironic.drivers.modules.pxe:PXEBoot"},{"line_number":88,"context_line":"    irmc-virtual-media \u003d ironic.drivers.modules.irmc.boot:IRMCVirtualMediaBoot"},{"line_number":89,"context_line":"    hpe-ilo-virtual-media \u003d ironic.drivers.modules.ilo.boot:IloVirtualMediaBoot"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"ironic.hardware.interfaces.console \u003d"},{"line_number":92,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeConsole"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"9a30ddce_1967e54d","line":89,"updated":"2017-03-10 11:47:31.000000000","message":"I suggest dropping \"hpe\" (here and below) to make it less verbose. I don\u0027t think anyone else has \"ilo\" and we don\u0027t have \"hpe\" prefix in old drivers.","commit_id":"346e0f4e1737ef4b22caebf0ed5110f5dc5d8bee"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6c395b03fd175459638c73084f1752e633af5c0b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeBoot"},{"line_number":87,"context_line":"    pxe \u003d ironic.drivers.modules.pxe:PXEBoot"},{"line_number":88,"context_line":"    irmc-virtual-media \u003d ironic.drivers.modules.irmc.boot:IRMCVirtualMediaBoot"},{"line_number":89,"context_line":"    hpe-ilo-virtual-media \u003d ironic.drivers.modules.ilo.boot:IloVirtualMediaBoot"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"ironic.hardware.interfaces.console \u003d"},{"line_number":92,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeConsole"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"9a30ddce_f49698ee","line":89,"in_reply_to":"9a30ddce_1967e54d","updated":"2017-03-10 12:27:27.000000000","message":"ok","commit_id":"346e0f4e1737ef4b22caebf0ed5110f5dc5d8bee"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f8551297553243e2b2cceb0daa0504c089540aae","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    iscsi \u003d ironic.drivers.modules.iscsi_deploy:ISCSIDeploy"},{"line_number":101,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeDeploy"},{"line_number":102,"context_line":"    hpe-ilo-direct \u003d ironic.drivers.modules.ilo.deploy:IloVirtualMediaAgentDeploy"},{"line_number":103,"context_line":"    hpe-ilo-pxe \u003d ironic.drivers.modules.ilo.deploy:IloPXEDeploy"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"ironic.hardware.interfaces.inspect \u003d"},{"line_number":106,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeInspect"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"9a30ddce_3958298a","line":103,"updated":"2017-03-10 11:47:31.000000000","message":"there seem to be some mess around iLO deploy methods, that may require cleaning up now. you have to make sure that ilo-direct and ilo-iscsi (don\u0027t call it PXE please, PXE is a boot method) work with all supported boot interfaces, pxe and ilo-virtual-media in your case.","commit_id":"346e0f4e1737ef4b22caebf0ed5110f5dc5d8bee"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"6c395b03fd175459638c73084f1752e633af5c0b","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    iscsi \u003d ironic.drivers.modules.iscsi_deploy:ISCSIDeploy"},{"line_number":101,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeDeploy"},{"line_number":102,"context_line":"    hpe-ilo-direct \u003d ironic.drivers.modules.ilo.deploy:IloVirtualMediaAgentDeploy"},{"line_number":103,"context_line":"    hpe-ilo-pxe \u003d ironic.drivers.modules.ilo.deploy:IloPXEDeploy"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"ironic.hardware.interfaces.inspect \u003d"},{"line_number":106,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeInspect"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"9a30ddce_3f7ac977","line":103,"in_reply_to":"9a30ddce_3958298a","updated":"2017-03-10 12:27:27.000000000","message":"Ok. Will change the name.","commit_id":"346e0f4e1737ef4b22caebf0ed5110f5dc5d8bee"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f8551297553243e2b2cceb0daa0504c089540aae","unresolved":false,"context_lines":[{"line_number":148,"context_line":"    ipmi \u003d ironic.drivers.ipmi:IPMIHardware"},{"line_number":149,"context_line":"    irmc \u003d ironic.drivers.irmc:IRMCHardware"},{"line_number":150,"context_line":"    hpe-ilo-vmedia \u003d ironic.drivers.ilo:IloVirtualMediaHardware"},{"line_number":151,"context_line":"    hpe-ilo-pxe \u003d ironic.drivers.ilo:IloPxeHardware"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"ironic.database.migration_backend \u003d"},{"line_number":154,"context_line":"    sqlalchemy \u003d ironic.db.sqlalchemy.migration"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"9a30ddce_595ddd77","line":151,"updated":"2017-03-10 11:47:31.000000000","message":"should be just one \"ilo\"","commit_id":"346e0f4e1737ef4b22caebf0ed5110f5dc5d8bee"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5b2a3c62659593726ccf929be2856e4ace7ba347","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    direct \u003d ironic.drivers.modules.agent:AgentDeploy"},{"line_number":100,"context_line":"    iscsi \u003d ironic.drivers.modules.iscsi_deploy:ISCSIDeploy"},{"line_number":101,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeDeploy"},{"line_number":102,"context_line":"    ilo \u003d ironic.drivers.modules.ilo.deploy:IloVirtualMediaAgentDeploy"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"ironic.hardware.interfaces.inspect \u003d"},{"line_number":105,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeInspect"}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"1a1ced50_f333eef3","line":102,"updated":"2017-03-22 17:28:59.000000000","message":"if it\u0027s similar to \"direct\" (former \"agent\") deploy method, should we maybe call it \"ilo-direct\"?","commit_id":"8072c16492dca0b2fcbbb4245717b86e6b00fcdd"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e49326167ffb21f7cb48f80207be2d1beb5b41ee","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    direct \u003d ironic.drivers.modules.agent:AgentDeploy"},{"line_number":100,"context_line":"    iscsi \u003d ironic.drivers.modules.iscsi_deploy:ISCSIDeploy"},{"line_number":101,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeDeploy"},{"line_number":102,"context_line":"    ilo \u003d ironic.drivers.modules.ilo.deploy:IloVirtualMediaAgentDeploy"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"ironic.hardware.interfaces.inspect \u003d"},{"line_number":105,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeInspect"}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"ffe62b97_b39f64b3","line":102,"in_reply_to":"1a1ced50_9c16474a","updated":"2017-03-24 12:12:28.000000000","message":"The prepare() and tear_down() and reboot_to_instance() methods has additional code to handle UEFI secure boot mode.\nhttps://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/deploy.py#L287\nhttps://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/deploy.py#L276\nhttps://github.com/openstack/ironic/blob/master/ironic/drivers/modules/ilo/deploy.py#L339-L342","commit_id":"8072c16492dca0b2fcbbb4245717b86e6b00fcdd"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"c1bee8d4a2e8ad159a7ac0abda329b67ed5a8532","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    direct \u003d ironic.drivers.modules.agent:AgentDeploy"},{"line_number":100,"context_line":"    iscsi \u003d ironic.drivers.modules.iscsi_deploy:ISCSIDeploy"},{"line_number":101,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeDeploy"},{"line_number":102,"context_line":"    ilo \u003d ironic.drivers.modules.ilo.deploy:IloVirtualMediaAgentDeploy"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"ironic.hardware.interfaces.inspect \u003d"},{"line_number":105,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeInspect"}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"1a1ced50_9c16474a","line":102,"in_reply_to":"1a1ced50_f333eef3","updated":"2017-03-22 18:32:50.000000000","message":"I am curious what\u0027s different about this deploy driver. Why wouldn\u0027t this just use \"direct\" or \"iscsi\"? There shouldn\u0027t be anything hardware specific there.","commit_id":"8072c16492dca0b2fcbbb4245717b86e6b00fcdd"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e49326167ffb21f7cb48f80207be2d1beb5b41ee","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    direct \u003d ironic.drivers.modules.agent:AgentDeploy"},{"line_number":100,"context_line":"    iscsi \u003d ironic.drivers.modules.iscsi_deploy:ISCSIDeploy"},{"line_number":101,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeDeploy"},{"line_number":102,"context_line":"    ilo \u003d ironic.drivers.modules.ilo.deploy:IloVirtualMediaAgentDeploy"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"ironic.hardware.interfaces.inspect \u003d"},{"line_number":105,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeInspect"}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"ffe62b97_73743c9a","line":102,"in_reply_to":"1a1ced50_f333eef3","updated":"2017-03-24 12:12:28.000000000","message":"Since it supports only one type of deploy hence named it as \u0027ilo\u0027. Can change it as \u0027ilo-direct\u0027. That would be more explicit.","commit_id":"8072c16492dca0b2fcbbb4245717b86e6b00fcdd"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"923c01c87f9c195f4bffc9c657ab849c4b5b2063","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    direct \u003d ironic.drivers.modules.agent:AgentDeploy"},{"line_number":100,"context_line":"    iscsi \u003d ironic.drivers.modules.iscsi_deploy:ISCSIDeploy"},{"line_number":101,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeDeploy"},{"line_number":102,"context_line":"    ilo \u003d ironic.drivers.modules.ilo.deploy:IloVirtualMediaAgentDeploy"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"ironic.hardware.interfaces.inspect \u003d"},{"line_number":105,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeInspect"}],"source_content_type":"text/x-ttcn-cfg","patch_set":5,"id":"ffe62b97_a7970c91","line":102,"in_reply_to":"ffe62b97_b39f64b3","updated":"2017-03-24 13:36:50.000000000","message":"We talked on IRC about it a bit, and I think it should be possible to move these bits to your BootInteface, and then just use generic deploy methods. I\u0027m totally fine if it involves extending boot interface with more methods, and calling them from existing deploy interface implementations.","commit_id":"8072c16492dca0b2fcbbb4245717b86e6b00fcdd"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"0f74859999ca6438fb43d4171c59313c7a44796e","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    inspector \u003d ironic.drivers.modules.inspector:Inspector"},{"line_number":107,"context_line":"    no-inspect \u003d ironic.drivers.modules.noop:NoInspect"},{"line_number":108,"context_line":"    irmc \u003d ironic.drivers.modules.irmc.inspect:IRMCInspect"},{"line_number":109,"context_line":"    ilo \u003d ironic.drivers.modules.ilo.inspect:IloInspect"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"ironic.hardware.interfaces.management \u003d"},{"line_number":112,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeManagement"}],"source_content_type":"text/x-ttcn-cfg","patch_set":11,"id":"5ff73747_46fcff6e","line":109,"updated":"2017-05-01 19:03:02.000000000","message":"darn, we didn\u0027t take the opportunity to order these alphabetically. oh well.","commit_id":"f5390c097f90dc577c4202df6cc7e03dcd571a15"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d3fe78d092bf8ca98b3af368e84723abc0051689","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    inspector \u003d ironic.drivers.modules.inspector:Inspector"},{"line_number":107,"context_line":"    no-inspect \u003d ironic.drivers.modules.noop:NoInspect"},{"line_number":108,"context_line":"    irmc \u003d ironic.drivers.modules.irmc.inspect:IRMCInspect"},{"line_number":109,"context_line":"    ilo \u003d ironic.drivers.modules.ilo.inspect:IloInspect"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"ironic.hardware.interfaces.management \u003d"},{"line_number":112,"context_line":"    fake \u003d ironic.drivers.modules.fake:FakeManagement"}],"source_content_type":"text/x-ttcn-cfg","patch_set":11,"id":"5ff73747_2310b7ff","line":109,"in_reply_to":"5ff73747_46fcff6e","updated":"2017-05-02 06:42:44.000000000","message":"Makes sense to fix it. Done.","commit_id":"f5390c097f90dc577c4202df6cc7e03dcd571a15"}]}