)]}'
{"devstack/lib/ironic":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"7e62647fc180bcffab84f0f733eb4526164f57bc","unresolved":false,"context_lines":[{"line_number":1978,"context_line":"}"},{"line_number":1979,"context_line":""},{"line_number":1980,"context_line":"function setup_vxlan_network {"},{"line_number":1981,"context_line":"    # Connect multinode bmswitchs together with a tunnel to simulate a single physical network"},{"line_number":1982,"context_line":"    # We use a VXLAN tunnel because some CI node providers don\u0027t allow GRE"},{"line_number":1983,"context_line":"    if [[ \"$HOST_TOPOLOGY_ROLE\" \u003d\u003d \"primary\" ]]; then"},{"line_number":1984,"context_line":"        local id"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ba2be162_5365e31b","line":1981,"updated":"2017-03-02 20:29:15.000000000","message":"can we do this in more transparent fashion? ie there will be a period of time when https://review.openstack.org/#/c/419391/ is merged and current patch not multinode will be broken.\n\nHere we can check if bridge was precreated by devstack-gate just skip configuration here and if not proceed wdyt?\n\nIt takes time to merge patches to devstack-gate, I don\u0027t want to rely on them so much.\n\nWe can cleanup safe wrap once devstack-gate is cleanuped.","commit_id":"85393750f89a5698fa65ad7a405e39b11e995fca"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"352326f35c1cc3a4405b3dc1249105376e77e65b","unresolved":false,"context_lines":[{"line_number":1978,"context_line":"}"},{"line_number":1979,"context_line":""},{"line_number":1980,"context_line":"function setup_vxlan_network {"},{"line_number":1981,"context_line":"    # Connect multinode bmswitchs together with a tunnel to simulate a single physical network"},{"line_number":1982,"context_line":"    # We use a VXLAN tunnel because some CI node providers don\u0027t allow GRE"},{"line_number":1983,"context_line":"    if [[ \"$HOST_TOPOLOGY_ROLE\" \u003d\u003d \"primary\" ]]; then"},{"line_number":1984,"context_line":"        local id"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"ba2be162_af4e966c","line":1981,"in_reply_to":"ba2be162_5365e31b","updated":"2017-03-03 12:31:31.000000000","message":"Done","commit_id":"85393750f89a5698fa65ad7a405e39b11e995fca"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a5afb87446fbc0c0a85d233ea49231250fdc7e84","unresolved":false,"context_lines":[{"line_number":1921,"context_line":"        done"},{"line_number":1922,"context_line":"    elif [[ \"$HOST_TOPOLOGY_ROLE\" \u003d\u003d \"subnode\" ]]; then"},{"line_number":1923,"context_line":"        sudo ip link del dev bmswitchup"},{"line_number":1924,"context_line":"    fi "},{"line_number":1925,"context_line":""},{"line_number":1926,"context_line":"    sudo ovs-vsctl --if-exists del-br $IRONIC_VM_NETWORK_BRIDGE"},{"line_number":1927,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba2be162_67b90915","line":1924,"updated":"2017-03-03 22:24:47.000000000","message":"whitespace pep8 failure","commit_id":"44d61a721c331f24595255ea01925049dfa823e7"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"e284c0e8d4f5d14fb18bd905248f6c3a5b3dc009","unresolved":false,"context_lines":[{"line_number":1921,"context_line":"        done"},{"line_number":1922,"context_line":"    elif [[ \"$HOST_TOPOLOGY_ROLE\" \u003d\u003d \"subnode\" ]]; then"},{"line_number":1923,"context_line":"        sudo ip link del dev bmswitchup"},{"line_number":1924,"context_line":"    fi "},{"line_number":1925,"context_line":""},{"line_number":1926,"context_line":"    sudo ovs-vsctl --if-exists del-br $IRONIC_VM_NETWORK_BRIDGE"},{"line_number":1927,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba2be162_48fce9b7","line":1924,"in_reply_to":"ba2be162_67b90915","updated":"2017-03-06 13:43:18.000000000","message":"Done","commit_id":"44d61a721c331f24595255ea01925049dfa823e7"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a5afb87446fbc0c0a85d233ea49231250fdc7e84","unresolved":false,"context_lines":[{"line_number":1996,"context_line":"    local old_vxlan_bridge"},{"line_number":1997,"context_line":"    old_vxlan_bridge\u003d$(sudo ovs-vsctl show | grep br_ironic_vxlan)"},{"line_number":1998,"context_line":""},{"line_number":1999,"context_line":"    if [[ -n \"${old_vxlan_bridge}\" ]]; then"},{"line_number":2000,"context_line":"        # If vxlan bridge already exists just plumb that and return"},{"line_number":2001,"context_line":"        sudo ip link add dev brbm_vxlan type veth peer name vxlan_brbm"},{"line_number":2002,"context_line":"        sudo ip link set brbm_vxlan up"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba2be162_c7b39508","line":1999,"range":{"start_line":1999,"start_character":7,"end_line":1999,"end_character":37},"updated":"2017-03-03 22:24:47.000000000","message":"nit: if sudo ovs-vsctl show |grep -q br_ironic_vxlan; then ...","commit_id":"44d61a721c331f24595255ea01925049dfa823e7"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a5afb87446fbc0c0a85d233ea49231250fdc7e84","unresolved":false,"context_lines":[{"line_number":1998,"context_line":""},{"line_number":1999,"context_line":"    if [[ -n \"${old_vxlan_bridge}\" ]]; then"},{"line_number":2000,"context_line":"        # If vxlan bridge already exists just plumb that and return"},{"line_number":2001,"context_line":"        sudo ip link add dev brbm_vxlan type veth peer name vxlan_brbm"},{"line_number":2002,"context_line":"        sudo ip link set brbm_vxlan up"},{"line_number":2003,"context_line":"        sudo ip link set vxlan_brbm up"},{"line_number":2004,"context_line":"        sudo ovs-vsctl add-port $IRONIC_VM_NETWORK_BRIDGE brbm_vxlan"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba2be162_07992d7c","line":2001,"range":{"start_line":2001,"start_character":29,"end_line":2001,"end_character":33},"updated":"2017-03-03 22:24:47.000000000","message":"nit: s brbm/${IRONIC_VM_NETWORK_BRIDGE}","commit_id":"44d61a721c331f24595255ea01925049dfa823e7"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"e284c0e8d4f5d14fb18bd905248f6c3a5b3dc009","unresolved":false,"context_lines":[{"line_number":1998,"context_line":""},{"line_number":1999,"context_line":"    if [[ -n \"${old_vxlan_bridge}\" ]]; then"},{"line_number":2000,"context_line":"        # If vxlan bridge already exists just plumb that and return"},{"line_number":2001,"context_line":"        sudo ip link add dev brbm_vxlan type veth peer name vxlan_brbm"},{"line_number":2002,"context_line":"        sudo ip link set brbm_vxlan up"},{"line_number":2003,"context_line":"        sudo ip link set vxlan_brbm up"},{"line_number":2004,"context_line":"        sudo ovs-vsctl add-port $IRONIC_VM_NETWORK_BRIDGE brbm_vxlan"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba2be162_c8d5391c","line":2001,"range":{"start_line":2001,"start_character":29,"end_line":2001,"end_character":33},"in_reply_to":"ba2be162_07992d7c","updated":"2017-03-06 13:43:18.000000000","message":"Done","commit_id":"44d61a721c331f24595255ea01925049dfa823e7"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a5afb87446fbc0c0a85d233ea49231250fdc7e84","unresolved":false,"context_lines":[{"line_number":2017,"context_line":"            sudo ovs-vsctl add-port $IRONIC_VM_NETWORK_BRIDGE bmswdown$id"},{"line_number":2018,"context_line":"        done"},{"line_number":2019,"context_line":"    elif [[ \"$HOST_TOPOLOGY_ROLE\" \u003d\u003d \"subnode\" ]]; then"},{"line_number":2020,"context_line":"        sudo ip link add bmswitchup type vxlan id 1 remote $SERVICE_HOST local $HOST_IP dstport 4789"},{"line_number":2021,"context_line":"        sudo ip link set bmswitchup up"},{"line_number":2022,"context_line":"        sudo ovs-vsctl add-port $IRONIC_VM_NETWORK_BRIDGE bmswitchup"},{"line_number":2023,"context_line":"    fi  "}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba2be162_7d7c38ec","line":2020,"range":{"start_line":2020,"start_character":50,"end_line":2020,"end_character":51},"updated":"2017-03-03 22:24:47.000000000","message":"wondered if we want to pick uniq vni for each tunnel?\nand avoid overlap with neutron range\n\nhttps://github.com/openstack-infra/devstack-gate/blob/0cf5c616f904de07c9a7711bd15d362e4b46a5b3/functions.sh#L1053\n\nhttps://github.com/openstack-infra/devstack-gate/blob/0cf5c616f904de07c9a7711bd15d362e4b46a5b3/functions.sh#L1034","commit_id":"44d61a721c331f24595255ea01925049dfa823e7"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"e284c0e8d4f5d14fb18bd905248f6c3a5b3dc009","unresolved":false,"context_lines":[{"line_number":2017,"context_line":"            sudo ovs-vsctl add-port $IRONIC_VM_NETWORK_BRIDGE bmswdown$id"},{"line_number":2018,"context_line":"        done"},{"line_number":2019,"context_line":"    elif [[ \"$HOST_TOPOLOGY_ROLE\" \u003d\u003d \"subnode\" ]]; then"},{"line_number":2020,"context_line":"        sudo ip link add bmswitchup type vxlan id 1 remote $SERVICE_HOST local $HOST_IP dstport 4789"},{"line_number":2021,"context_line":"        sudo ip link set bmswitchup up"},{"line_number":2022,"context_line":"        sudo ovs-vsctl add-port $IRONIC_VM_NETWORK_BRIDGE bmswitchup"},{"line_number":2023,"context_line":"    fi  "}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba2be162_c891b948","line":2020,"range":{"start_line":2020,"start_character":50,"end_line":2020,"end_character":51},"in_reply_to":"ba2be162_7d7c38ec","updated":"2017-03-06 13:43:18.000000000","message":"This is a one (primary) to many (subnodes) tunnel, so I think we only need to pick one vxlan id, but I think we should be careful about collisions with Neutron.","commit_id":"44d61a721c331f24595255ea01925049dfa823e7"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a5afb87446fbc0c0a85d233ea49231250fdc7e84","unresolved":false,"context_lines":[{"line_number":2020,"context_line":"        sudo ip link add bmswitchup type vxlan id 1 remote $SERVICE_HOST local $HOST_IP dstport 4789"},{"line_number":2021,"context_line":"        sudo ip link set bmswitchup up"},{"line_number":2022,"context_line":"        sudo ovs-vsctl add-port $IRONIC_VM_NETWORK_BRIDGE bmswitchup"},{"line_number":2023,"context_line":"    fi  "},{"line_number":2024,"context_line":"}"},{"line_number":2025,"context_line":""},{"line_number":2026,"context_line":"# Restore xtrace + pipefail"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba2be162_e7433911","line":2023,"range":{"start_line":2023,"start_character":6,"end_line":2023,"end_character":8},"updated":"2017-03-03 22:24:47.000000000","message":"whitespace pep8 failure","commit_id":"44d61a721c331f24595255ea01925049dfa823e7"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"e284c0e8d4f5d14fb18bd905248f6c3a5b3dc009","unresolved":false,"context_lines":[{"line_number":2020,"context_line":"        sudo ip link add bmswitchup type vxlan id 1 remote $SERVICE_HOST local $HOST_IP dstport 4789"},{"line_number":2021,"context_line":"        sudo ip link set bmswitchup up"},{"line_number":2022,"context_line":"        sudo ovs-vsctl add-port $IRONIC_VM_NETWORK_BRIDGE bmswitchup"},{"line_number":2023,"context_line":"    fi  "},{"line_number":2024,"context_line":"}"},{"line_number":2025,"context_line":""},{"line_number":2026,"context_line":"# Restore xtrace + pipefail"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba2be162_23ad169b","line":2023,"range":{"start_line":2023,"start_character":6,"end_line":2023,"end_character":8},"in_reply_to":"ba2be162_e7433911","updated":"2017-03-06 13:43:18.000000000","message":"Done","commit_id":"44d61a721c331f24595255ea01925049dfa823e7"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"eccb44c2ad6d6321157f5ff1cda2bf8e41cee0de","unresolved":false,"context_lines":[{"line_number":2013,"context_line":"        local id"},{"line_number":2014,"context_line":"        for node in $HOST_TOPOLOGY_SUBNODES; do"},{"line_number":2015,"context_line":"            id\u003d$(echo $node | cut -d \u0027.\u0027 -f 4)"},{"line_number":2016,"context_line":"            sudo ip link add bmswdown$id type vxlan id 20000 remote $node local $HOST_IP dstport 4789"},{"line_number":2017,"context_line":"            sudo ip link set bmswdown$id up"},{"line_number":2018,"context_line":"            sudo ovs-vsctl add-port $IRONIC_VM_NETWORK_BRIDGE bmswdown$id"},{"line_number":2019,"context_line":"        done"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba2be162_8354edca","line":2016,"range":{"start_line":2016,"start_character":55,"end_line":2016,"end_character":60},"updated":"2017-03-06 20:17:20.000000000","message":"It is impossible to add interface with the same VID and local address\n\nhttp://paste.openstack.org/show/601643/","commit_id":"dec585dce27ce04685d0b2dbba7d3cf466d2215f"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"6d86739b5daed6ddd4971365ed57e3c3a54ac2f3","unresolved":false,"context_lines":[{"line_number":2013,"context_line":"        local id"},{"line_number":2014,"context_line":"        for node in $HOST_TOPOLOGY_SUBNODES; do"},{"line_number":2015,"context_line":"            id\u003d$(echo $node | cut -d \u0027.\u0027 -f 4)"},{"line_number":2016,"context_line":"            sudo ip link add bmswdown$id type vxlan id 20000 remote $node local $HOST_IP dstport 4789"},{"line_number":2017,"context_line":"            sudo ip link set bmswdown$id up"},{"line_number":2018,"context_line":"            sudo ovs-vsctl add-port $IRONIC_VM_NETWORK_BRIDGE bmswdown$id"},{"line_number":2019,"context_line":"        done"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ba2be162_e3d68926","line":2016,"range":{"start_line":2016,"start_character":37,"end_line":2016,"end_character":40},"updated":"2017-03-06 20:18:50.000000000","message":"putting last octet here might be not unique, as primary and subnode may be in different networks, so theirs last octet is the same","commit_id":"dec585dce27ce04685d0b2dbba7d3cf466d2215f"}]}