)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"cdaa0aa1180ef16b55526cfb593deb6a2d6321d6","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-03-02 15:41:45 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Follow up patch of 3428cb74f0a6fe05c23cf00dc66da4c1d9766409"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I1e5f632d687c1cebab895cc91958d502b9fce884"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba2be162_914ca99f","line":8,"updated":"2017-03-03 03:16:51.000000000","message":"would be good to add that it adds a test and updates the release notes.\n\nwould have been good to put the same bugs as for the original patch.","commit_id":"dd3b6df9fce577e1c5ae8e891eca3aedd2d6c8af"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"dcebf8275c0efa8b57d31fa028e6588b578a0eee","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Joanna Taryma \u003cjoanna.taryma@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-03 09:29:16 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Follow up patch of 3428cb74f0a6fe05c23cf00dc66da4c1d9766409"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I1e5f632d687c1cebab895cc91958d502b9fce884"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba2be162_b9b236e3","line":7,"updated":"2017-03-04 20:53:25.000000000","message":"This is not an obvious description for those not following that patch. Please describe what you actually did, even if it\u0027s just like \"Fix small issues in the database configuration\" or something high-level like that.","commit_id":"3f5c7bbb6e867db3063d34c06ad7966508cc8abb"},{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"a298d437b11bc77bd39027a90b550eb6f4afa4de","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Joanna Taryma \u003cjoanna.taryma@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-06 09:03:34 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Follow up patch of 3428cb74f0a6fe05c23cf00dc66da4c1d9766409"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Remove overwriting the default value of db_max_retries."},{"line_number":10,"context_line":"Add information about db_max_retries configuration option to the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba2be162_cf1b6e7f","line":7,"updated":"2017-03-06 18:52:59.000000000","message":"Can you make this more specifically declarative of the change? Perhaps something like \"Update config options for db retries\" or similar? This line should still be in the body of the note though, it\u0027s just not useful to someone reading a short log.","commit_id":"73e850024ca11e144cef38ac9f2598c63fd21a29"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"f0c891c1f2b6454c2eeddd432f4ca0a6d57cc975","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Joanna Taryma \u003cjoanna.taryma@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-06 09:03:34 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Follow up patch of 3428cb74f0a6fe05c23cf00dc66da4c1d9766409"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Remove overwriting the default value of db_max_retries."},{"line_number":10,"context_line":"Add information about db_max_retries configuration option to the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a30ddce_4904af16","line":7,"in_reply_to":"ba2be162_a872b0ae","updated":"2017-03-07 19:24:06.000000000","message":"+1 on a better subject message.","commit_id":"73e850024ca11e144cef38ac9f2598c63fd21a29"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"9766bd2e6e91e0acef0fa63b93b37d8ac9f49295","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Joanna Taryma \u003cjoanna.taryma@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-06 09:03:34 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Follow up patch of 3428cb74f0a6fe05c23cf00dc66da4c1d9766409"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Remove overwriting the default value of db_max_retries."},{"line_number":10,"context_line":"Add information about db_max_retries configuration option to the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba2be162_a872b0ae","line":7,"in_reply_to":"ba2be162_cf1b6e7f","updated":"2017-03-06 19:42:41.000000000","message":"If you split this into two patches and this is the one with the release note update, this could be \u0027Update the release note for DB deadlocking\u0027\n\nAnd then below somewhere, you could put, \u0027This is a follow up to 342...\u0027.\n\nYou could also put Related-Bug: .. with the same bug associated with the db dead locking. Or Partial-Bug. Or something like that; I can never remember...","commit_id":"73e850024ca11e144cef38ac9f2598c63fd21a29"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"67866e0e3fcaf75e09c06ed5d8dbb1d2dc1648af","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove overwriting the default value of db_max_retries."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Follow up patch of 3428cb74f0a6fe05c23cf00dc66da4c1d9766409"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Remove overwriting the default value of db_max_retries. Adjust the default"},{"line_number":12,"context_line":"value of db_max_retries in sample config and release note."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a30ddce_09c5125a","line":9,"range":{"start_line":9,"start_character":1,"end_line":9,"end_character":59},"updated":"2017-03-09 08:49:33.000000000","message":"Please remove this, it doesn\u0027t look like followup now.","commit_id":"487840467d4eeed857b7a200d90c457ca76dcbb2"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"23fc3fb229875c481714bd610ab08137e2503529","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove overwriting the default value of db_max_retries."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Follow up patch of 3428cb74f0a6fe05c23cf00dc66da4c1d9766409"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Remove overwriting the default value of db_max_retries. Adjust the default"},{"line_number":12,"context_line":"value of db_max_retries in sample config and release note."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a30ddce_f5479174","line":9,"range":{"start_line":9,"start_character":1,"end_line":9,"end_character":59},"in_reply_to":"9a30ddce_09c5125a","updated":"2017-03-09 21:56:37.000000000","message":"Done","commit_id":"487840467d4eeed857b7a200d90c457ca76dcbb2"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"623179b29f4534b0ab3898597acc5c9f355af955","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Follow up patch of 3428cb74f0a6fe05c23cf00dc66da4c1d9766409"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Remove overwriting the default value of db_max_retries. Adjust the default"},{"line_number":12,"context_line":"value of db_max_retries in sample config and release note."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1e5f632d687c1cebab895cc91958d502b9fce884"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a30ddce_2d45a216","line":12,"updated":"2017-03-08 14:17:19.000000000","message":"I feel like this commit is missing the big issue.\n\nThis patch, from the user\u0027s point of view, changes the way something works. It changes the default value for the maximum number of tries to access the DB when it is locked. From 5 times to 20 times. In order to make this change, this patch does as you describe here.\n\nI think to do this, given that the code has landed, we need a bug to track it. It may be a follow up to the original patch, but it is a bug now.","commit_id":"487840467d4eeed857b7a200d90c457ca76dcbb2"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"67866e0e3fcaf75e09c06ed5d8dbb1d2dc1648af","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Follow up patch of 3428cb74f0a6fe05c23cf00dc66da4c1d9766409"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Remove overwriting the default value of db_max_retries. Adjust the default"},{"line_number":12,"context_line":"value of db_max_retries in sample config and release note."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1e5f632d687c1cebab895cc91958d502b9fce884"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a30ddce_89866211","line":12,"in_reply_to":"9a30ddce_2b3665e6","updated":"2017-03-09 08:49:33.000000000","message":"Remove overwriting the default value of db_max_retries, instead use default value defined by oslo-db which is 20.","commit_id":"487840467d4eeed857b7a200d90c457ca76dcbb2"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f99eec7d1762d23e38e3513f75f979679ac5a03a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Follow up patch of 3428cb74f0a6fe05c23cf00dc66da4c1d9766409"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Remove overwriting the default value of db_max_retries. Adjust the default"},{"line_number":12,"context_line":"value of db_max_retries in sample config and release note."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1e5f632d687c1cebab895cc91958d502b9fce884"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a30ddce_2b3665e6","line":12,"in_reply_to":"9a30ddce_2d45a216","updated":"2017-03-08 17:01:44.000000000","message":"I don\u0027t want to add the values explicitly. 20 is something that is set outside ironic repo, so I don\u0027t want this commit to be outdated if oslo.db changes the default of db_max_retries. The truth is that what this commit does is removing the overwrite for oslo.db\u0027s default. Not changing from x to y.","commit_id":"487840467d4eeed857b7a200d90c457ca76dcbb2"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"23fc3fb229875c481714bd610ab08137e2503529","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Follow up patch of 3428cb74f0a6fe05c23cf00dc66da4c1d9766409"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Remove overwriting the default value of db_max_retries. Adjust the default"},{"line_number":12,"context_line":"value of db_max_retries in sample config and release note."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1e5f632d687c1cebab895cc91958d502b9fce884"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a30ddce_2868f0b8","line":12,"in_reply_to":"9a30ddce_89866211","updated":"2017-03-09 21:56:37.000000000","message":"Done","commit_id":"487840467d4eeed857b7a200d90c457ca76dcbb2"}],"etc/ironic/ironic.conf.sample":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"623179b29f4534b0ab3898597acc5c9f355af955","unresolved":false,"context_lines":[{"line_number":1251,"context_line":"# Maximum retries in case of connection error or deadlock"},{"line_number":1252,"context_line":"# error before error is raised. Set to -1 to specify an"},{"line_number":1253,"context_line":"# infinite retry count. (integer value)"},{"line_number":1254,"context_line":"#db_max_retries \u003d 20"},{"line_number":1255,"context_line":""},{"line_number":1256,"context_line":""},{"line_number":1257,"context_line":"[deploy]"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"9a30ddce_4db01644","line":1254,"updated":"2017-03-08 14:17:19.000000000","message":"just so i know, did you manually edit this file or did you regenerate it?","commit_id":"487840467d4eeed857b7a200d90c457ca76dcbb2"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"23fc3fb229875c481714bd610ab08137e2503529","unresolved":false,"context_lines":[{"line_number":1251,"context_line":"# Maximum retries in case of connection error or deadlock"},{"line_number":1252,"context_line":"# error before error is raised. Set to -1 to specify an"},{"line_number":1253,"context_line":"# infinite retry count. (integer value)"},{"line_number":1254,"context_line":"#db_max_retries \u003d 20"},{"line_number":1255,"context_line":""},{"line_number":1256,"context_line":""},{"line_number":1257,"context_line":"[deploy]"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"9a30ddce_b5519938","line":1254,"in_reply_to":"9a30ddce_0fba8e6e","updated":"2017-03-09 21:56:37.000000000","message":"Done","commit_id":"487840467d4eeed857b7a200d90c457ca76dcbb2"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f99eec7d1762d23e38e3513f75f979679ac5a03a","unresolved":false,"context_lines":[{"line_number":1251,"context_line":"# Maximum retries in case of connection error or deadlock"},{"line_number":1252,"context_line":"# error before error is raised. Set to -1 to specify an"},{"line_number":1253,"context_line":"# infinite retry count. (integer value)"},{"line_number":1254,"context_line":"#db_max_retries \u003d 20"},{"line_number":1255,"context_line":""},{"line_number":1256,"context_line":""},{"line_number":1257,"context_line":"[deploy]"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"9a30ddce_0fba8e6e","line":1254,"in_reply_to":"9a30ddce_4db01644","updated":"2017-03-08 17:01:44.000000000","message":"I manually reverted. Generated config comes with a bunch of other changes.","commit_id":"487840467d4eeed857b7a200d90c457ca76dcbb2"},{"author":{"_account_id":22724,"name":"Galyna Zholtkevych","email":"galynazholtkevych1991@gmail.com","username":"gzholtkevych"},"change_message_id":"7cd1d21191420e57ee38c32fa407d21396cea344","unresolved":false,"context_lines":[{"line_number":1251,"context_line":"# Maximum retries in case of connection error or deadlock"},{"line_number":1252,"context_line":"# error before error is raised. Set to -1 to specify an"},{"line_number":1253,"context_line":"# infinite retry count. (integer value)"},{"line_number":1254,"context_line":"#db_max_retries \u003d 5"},{"line_number":1255,"context_line":""},{"line_number":1256,"context_line":""},{"line_number":1257,"context_line":"[deploy]"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"9a30ddce_7d5d2446","side":"PARENT","line":1254,"range":{"start_line":1254,"start_character":17,"end_line":1254,"end_character":19},"updated":"2017-03-10 15:06:08.000000000","message":"all other changes to sample config are not related to this patch and should be better proposed as a separate patch refreshing the config sample","commit_id":"e2e53409815da2eca637bb3c427b2dd456356ec4"}],"ironic/conf/database.py":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"ef616b87dc2f6cde782f8592bf4ef9d6b7c13769","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def register_opts(conf):"},{"line_number":28,"context_line":"    conf.register_opts(opts, group\u003d\u0027database\u0027)"},{"line_number":29,"context_line":"    # Change the oslo_db side default to 5"},{"line_number":30,"context_line":"    conf.import_opt(\u0027db_max_retries\u0027, \u0027ironic.db.api\u0027, group\u003d\u0027database\u0027)"},{"line_number":31,"context_line":"    conf.set_default(\u0027db_max_retries\u0027, 5, group\u003d\u0027database\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_da70cda6","side":"PARENT","line":29,"updated":"2017-03-03 20:59:13.000000000","message":"I know a hacky way to set this value in our sample to 5, but we should be sured what exactly we want :)","commit_id":"fec55f4a113591a6ff725f66d8ec36b89a033e61"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"bfe3444f8a84a23a4aa91148968b4ca32f023acd","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"def register_opts(conf):"},{"line_number":28,"context_line":"    conf.register_opts(opts, group\u003d\u0027database\u0027)"},{"line_number":29,"context_line":"    # Change the oslo_db side default to 5"},{"line_number":30,"context_line":"    conf.import_opt(\u0027db_max_retries\u0027, \u0027ironic.db.api\u0027, group\u003d\u0027database\u0027)"},{"line_number":31,"context_line":"    conf.set_default(\u0027db_max_retries\u0027, 5, group\u003d\u0027database\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba2be162_bad079ca","side":"PARENT","line":29,"in_reply_to":"ba2be162_da70cda6","updated":"2017-03-03 21:11:27.000000000","message":"we can add here https://github.com/openstack/ironic/blob/master/tox.ini#L59 bash call to do sed /#db_max_retries \u003d 20/#db_max_retries \u003d 5 ...","commit_id":"fec55f4a113591a6ff725f66d8ec36b89a033e61"}],"releasenotes/notes/add-db-deadlock-handling-6bc10076537f3727.yaml":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"e09c0de4277c518bd8e6b823844145c0cdbe3b9d","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  - Adds DBDeadlock handling which may improve stability when using Galera."},{"line_number":7,"context_line":"    See https://bugs.launchpad.net/ironic/+bug/1639338. Adds configuration"},{"line_number":8,"context_line":"    option ``[database]db_max_retries`` that specifies the number of"},{"line_number":9,"context_line":"    retries with a default of 5."},{"line_number":10,"context_line":"upgrade:"},{"line_number":11,"context_line":"  - All DB API methods doing database writes now retry on deadlock. The"},{"line_number":12,"context_line":"    ``[database]db_max_retries`` configuration option specifies the maximum"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba2be162_fb2da546","line":9,"range":{"start_line":9,"start_character":19,"end_line":9,"end_character":31},"updated":"2017-03-03 16:32:30.000000000","message":"if regenerate sample the default value will be changed to 20. I left a comment in original patch, please fix that also might be another follow-up :)","commit_id":"dd3b6df9fce577e1c5ae8e891eca3aedd2d6c8af"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"cdaa0aa1180ef16b55526cfb593deb6a2d6321d6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"upgrade:"},{"line_number":11,"context_line":"  - All DB API methods doing database writes now retry on deadlock. The"},{"line_number":12,"context_line":"    ``[database]db_max_retries`` configuration option specifies the maximum"},{"line_number":13,"context_line":"    number of times to retry, and can be customized if necessary. It is 5 by"},{"line_number":14,"context_line":"    default."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ba2be162_718f35cc","line":13,"updated":"2017-03-03 03:16:51.000000000","message":"I liked the British spelling, but this is fine too.","commit_id":"dd3b6df9fce577e1c5ae8e891eca3aedd2d6c8af"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a38fcbd816782637cd947c76e2913bc345882524","unresolved":false,"context_lines":[{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - Adds DBDeadlock handling which may improve stability when using Galera."},{"line_number":7,"context_line":"    See https://bugs.launchpad.net/ironic/+bug/1639338. Number of retries"},{"line_number":8,"context_line":"    depends on the configuration option ``[database]db_max_retries`` with a"},{"line_number":9,"context_line":"    default of 20."},{"line_number":10,"context_line":"upgrade:"},{"line_number":11,"context_line":"  - All DB API methods doing database writes now retry on deadlock. The"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a30ddce_7204f314","line":8,"updated":"2017-03-07 22:11:04.000000000","message":"I wonder if we should state the actual amount value or not. Since we are using the default value.","commit_id":"e36b281a0405cabb4d5406418d9faaaa12ec0777"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"8fa12cb075ee3bcc7574d81e51720afd7ebdcaa5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"features:"},{"line_number":6,"context_line":"  - Adds DBDeadlock handling which may improve stability when using Galera."},{"line_number":7,"context_line":"    See https://bugs.launchpad.net/ironic/+bug/1639338. Number of retries"},{"line_number":8,"context_line":"    depends on the configuration option ``[database]db_max_retries`` with a"},{"line_number":9,"context_line":"    default of 20."},{"line_number":10,"context_line":"upgrade:"},{"line_number":11,"context_line":"  - All DB API methods doing database writes now retry on deadlock. The"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a30ddce_f248e32f","line":8,"in_reply_to":"9a30ddce_7204f314","updated":"2017-03-07 22:16:18.000000000","message":"I had the same thought, but was\u0027t sure. If oslo changes the value, this note will get outdated. Will fix :)!","commit_id":"e36b281a0405cabb4d5406418d9faaaa12ec0777"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"623179b29f4534b0ab3898597acc5c9f355af955","unresolved":false,"context_lines":[{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - All DB API methods doing database writes now retry on deadlock. The"},{"line_number":11,"context_line":"    ``[database]db_max_retries`` configuration option specifies the maximum"},{"line_number":12,"context_line":"    number of times to retry, and can be customised if necessary. It is 5 by"},{"line_number":13,"context_line":"    default."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a30ddce_ad5ef20f","line":12,"updated":"2017-03-08 14:17:19.000000000","message":"does this need to change?","commit_id":"487840467d4eeed857b7a200d90c457ca76dcbb2"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"23fc3fb229875c481714bd610ab08137e2503529","unresolved":false,"context_lines":[{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - All DB API methods doing database writes now retry on deadlock. The"},{"line_number":11,"context_line":"    ``[database]db_max_retries`` configuration option specifies the maximum"},{"line_number":12,"context_line":"    number of times to retry, and can be customised if necessary. It is 5 by"},{"line_number":13,"context_line":"    default."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a30ddce_357769d4","line":12,"in_reply_to":"9a30ddce_0f71aee0","updated":"2017-03-09 21:56:37.000000000","message":"Done","commit_id":"487840467d4eeed857b7a200d90c457ca76dcbb2"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"f99eec7d1762d23e38e3513f75f979679ac5a03a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"upgrade:"},{"line_number":10,"context_line":"  - All DB API methods doing database writes now retry on deadlock. The"},{"line_number":11,"context_line":"    ``[database]db_max_retries`` configuration option specifies the maximum"},{"line_number":12,"context_line":"    number of times to retry, and can be customised if necessary. It is 5 by"},{"line_number":13,"context_line":"    default."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a30ddce_0f71aee0","line":12,"in_reply_to":"9a30ddce_ad5ef20f","updated":"2017-03-08 17:01:44.000000000","message":"yes it does. thanks! Will fix after it is decided on what the actual fix should be.","commit_id":"487840467d4eeed857b7a200d90c457ca76dcbb2"}]}