)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"570b1d385048b06d9c00ec5a75bfcc8c0f309286","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tao Li \u003clitao3721@126.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-10 09:24:16 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Address a shell sytax mistake"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Missing space before \u0027]\u0027 in addressed line and change it to"},{"line_number":10,"context_line":"another better format."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a30ddce_07f15201","line":7,"range":{"start_line":7,"start_character":16,"end_line":7,"end_character":21},"updated":"2017-03-10 02:05:19.000000000","message":"syntax","commit_id":"a185f22f3649386a544e6e229324aff818ca86dd"}],"devstack/lib/ironic":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"94eb2115ef02181257a9b85678d0d1f95ba9aaff","unresolved":false,"context_lines":[{"line_number":800,"context_line":"    fi"},{"line_number":801,"context_line":""},{"line_number":802,"context_line":"    # Create the logs directory when saving the deploy logs to the filesystem"},{"line_number":803,"context_line":"    if [ \"$IRONIC_DEPLOY_LOGS_STORAGE_BACKEND\" \u003d \"local\" ] \u0026\u0026 [ \"$IRONIC_DEPLOY_LOGS_COLLECT\" !\u003d \"never\" ]; then"},{"line_number":804,"context_line":"        sudo install -d -o $STACK_USER $IRONIC_DEPLOY_LOGS_LOCAL_PATH"},{"line_number":805,"context_line":"    fi"},{"line_number":806,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9a30ddce_dedd4fe1","line":803,"range":{"start_line":803,"start_character":7,"end_line":803,"end_character":106},"updated":"2017-03-09 20:16:02.000000000","message":"better to rewrite\n[[ \"$IRONIC_DEPLOY_LOGS_STORAGE_BACKEND\" \u003d\u003d \"local\"  \u0026\u0026  \"$IRONIC_DEPLOY_LOGS_COLLECT\" !\u003d \"never\" ]]; then ...","commit_id":"b5aabad357a5e8e5733d5be629e33ef05f7154ed"},{"author":{"_account_id":9610,"name":"Tao Li","email":"litao3721@126.com","username":"Litao"},"change_message_id":"4ec477161c515ef2b6c0360a4fe7b63f087d1583","unresolved":false,"context_lines":[{"line_number":800,"context_line":"    fi"},{"line_number":801,"context_line":""},{"line_number":802,"context_line":"    # Create the logs directory when saving the deploy logs to the filesystem"},{"line_number":803,"context_line":"    if [ \"$IRONIC_DEPLOY_LOGS_STORAGE_BACKEND\" \u003d \"local\" ] \u0026\u0026 [ \"$IRONIC_DEPLOY_LOGS_COLLECT\" !\u003d \"never\" ]; then"},{"line_number":804,"context_line":"        sudo install -d -o $STACK_USER $IRONIC_DEPLOY_LOGS_LOCAL_PATH"},{"line_number":805,"context_line":"    fi"},{"line_number":806,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"9a30ddce_593ecf28","line":803,"range":{"start_line":803,"start_character":7,"end_line":803,"end_character":106},"in_reply_to":"9a30ddce_dedd4fe1","updated":"2017-03-10 01:14:55.000000000","message":"Done","commit_id":"b5aabad357a5e8e5733d5be629e33ef05f7154ed"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"5c02dae1f57c2c0e6c62548f1765f7e30dd7e0d0","unresolved":false,"context_lines":[{"line_number":801,"context_line":""},{"line_number":802,"context_line":"    # Create the logs directory when saving the deploy logs to the filesystem"},{"line_number":803,"context_line":"    if [[ \"$IRONIC_DEPLOY_LOGS_STORAGE_BACKEND\" \u003d\u003d \"local\" \u0026\u0026 \"$IRONIC_DEPLOY_LOGS_COLLECT\" !\u003d \"never\" ]]; then"},{"line_number":804,"context_line":"        sudo install -d -o $STACK_USER $IRONIC_DEPLOY_LOGS_LOCAL_PATH"},{"line_number":805,"context_line":"    fi"},{"line_number":806,"context_line":"}"},{"line_number":807,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9a30ddce_726725b7","line":804,"updated":"2017-03-10 06:39:46.000000000","message":"So the problem with fixing this is when this runs, it creates all the directory but only the final directory is owned by the stack user. All the intermediate directories are owned by root.\n\nThis is causing the failure.\n\nAs can be seen here:\nhttp://logs.openstack.org/46/443546/3/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-pxe_ipmitool-tinyipa-ubuntu-xenial/0238413/logs/devstacklog.txt.gz#_2017-03-10_06_11_31_691\n\nIt creates the directory: /opt/stack/new/ironic-bm-logs/deploy_logs\n\nSo /opt/stack/new/ironic-bm-logs/ is owned by root, and later that causes it to fail when it tries to write into that directory.","commit_id":"c19ea2d8c7fe1045cd31098dbc230fe684c8f8a6"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"a441e3896f991cf42f04c9d82839fe9b3ba870da","unresolved":false,"context_lines":[{"line_number":801,"context_line":""},{"line_number":802,"context_line":"    # Create the logs directory when saving the deploy logs to the filesystem"},{"line_number":803,"context_line":"    if [[ \"$IRONIC_DEPLOY_LOGS_STORAGE_BACKEND\" \u003d\u003d \"local\" \u0026\u0026 \"$IRONIC_DEPLOY_LOGS_COLLECT\" !\u003d \"never\" ]]; then"},{"line_number":804,"context_line":"        install -d -o $STACK_USER $IRONIC_DEPLOY_LOGS_LOCAL_PATH"},{"line_number":805,"context_line":"    fi"},{"line_number":806,"context_line":"}"},{"line_number":807,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"9a30ddce_21a1a6f8","line":804,"range":{"start_line":804,"start_character":19,"end_line":804,"end_character":33},"updated":"2017-03-13 15:38:33.000000000","message":"If removing the \u0027sudo\u0027 then the -o probably shouldn\u0027t be kept, since only the super-user can use -o.","commit_id":"aec3663604e1767e6549a4cb830c7d3ae37f2668"}]}