)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c50b05231210a48e09ce5dfd5b28bb8fc1a3c503","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     anascko \u003covoshchana@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-14 00:29:05 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds use wsgi without port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Can use wsgi without port"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"5a22e58a_4220334a","line":7,"updated":"2017-03-14 10:52:31.000000000","message":"Let\u0027s rephrase the commit message, it\u0027s not clear now:\n\n [devstack] Also serve API from /baremetal endpoint on shared HTTP port\n\n The long-standing goal in OpenStack is to stop using custom ports for services\n and only use subpaths like /identity or /compute. This change enables the\n /baremetal subpath in our devstack plugin.\n\nor something like that","commit_id":"d44c52eb081ce916aa8fa8b3c996baa1c8bf7886"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"4ac6864e915179207c8bee87c4e7111c7d3a67c2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     anascko \u003covoshchana@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-03-14 00:29:05 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds use wsgi without port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Can use wsgi without port"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"5a22e58a_b91759ec","line":7,"in_reply_to":"5a22e58a_4220334a","updated":"2017-03-14 13:05:01.000000000","message":"Thanks Dmitry for review\nSorry I forgot to set \"workflow \" and patch was not ready\nBut all your comments I\u0027ll accept and improve :)","commit_id":"d44c52eb081ce916aa8fa8b3c996baa1c8bf7886"}],"devstack/files/apache-ironic-api.template":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"da0c18ec79cec79273c04d97416e0cdacd5370ca","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    Options +ExecCGI"},{"line_number":46,"context_line":"    WSGIProcessGroup ironic-api"},{"line_number":47,"context_line":"    WSGIApplicationGroup %{GLOBAL}"},{"line_number":48,"context_line":"    WSGIPassAuthorization On"},{"line_number":49,"context_line":"\u003c/Location\u003e"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"dfeb2761_e4e6f944","line":48,"updated":"2017-04-03 14:18:24.000000000","message":"now access logs are stored in general log file ironic specific one is empty http://logs.openstack.org/37/444337/18/check/gate-ironic-dsvm-standalone-ubuntu-xenial-nv/ea1ceb3/logs/apache/ironic-api-access.txt.gz","commit_id":"a940be4435dc3aeb90057b12be9e24cec402a776"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"983f01966b5014fd993075e502bdc1d8d672aa5c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    Options +ExecCGI"},{"line_number":46,"context_line":"    WSGIProcessGroup ironic-api"},{"line_number":47,"context_line":"    WSGIApplicationGroup %{GLOBAL}"},{"line_number":48,"context_line":"    WSGIPassAuthorization On"},{"line_number":49,"context_line":"\u003c/Location\u003e"}],"source_content_type":"application/octet-stream","patch_set":20,"id":"dfeb2761_f18a1919","line":48,"updated":"2017-04-04 11:30:07.000000000","message":"nit: access logs are still stored in wrong place http://logs.openstack.org/37/444337/20/check/gate-ironic-dsvm-standalone-ubuntu-xenial/c637e35/logs/apache/ironic-api-access.txt.gz\nI\u0027m ok to fix it as follow-up, as other services store them in default place.","commit_id":"b9b75a6354fa069913882e3f51e06ed2f2ac6370"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"fa9e2af12a6fab8de877754ed46853631b80fdc4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    Options +ExecCGI"},{"line_number":46,"context_line":"    WSGIProcessGroup ironic-api"},{"line_number":47,"context_line":"    WSGIApplicationGroup %{GLOBAL}"},{"line_number":48,"context_line":"    WSGIPassAuthorization On"},{"line_number":49,"context_line":"\u003c/Location\u003e"}],"source_content_type":"application/octet-stream","patch_set":20,"id":"dfeb2761_e0f6bc63","line":48,"in_reply_to":"dfeb2761_f18a1919","updated":"2017-04-04 14:06:43.000000000","message":"Thanks, Vasyl\nYes, all services wrote to access log to one the file, but maybe it incorrect?","commit_id":"b9b75a6354fa069913882e3f51e06ed2f2ac6370"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"7feff1e3866c1d10cc28bbcfab248bfdb938e915","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    Options +ExecCGI"},{"line_number":46,"context_line":"    WSGIProcessGroup ironic-api"},{"line_number":47,"context_line":"    WSGIApplicationGroup %{GLOBAL}"},{"line_number":48,"context_line":"    WSGIPassAuthorization On"},{"line_number":49,"context_line":"\u003c/Location\u003e"}],"source_content_type":"application/octet-stream","patch_set":22,"id":"bff0334d_5e50db0a","line":48,"updated":"2017-04-07 06:11:00.000000000","message":"please fix the logs, as it was pointed earlier.","commit_id":"d036d4bf6f5b6a7541d119574c7343bc5eae7e74"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"4fa33355d47a030d8fce2e56e958385f86079694","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    Options +ExecCGI"},{"line_number":46,"context_line":"    WSGIProcessGroup ironic-api"},{"line_number":47,"context_line":"    WSGIApplicationGroup %{GLOBAL}"},{"line_number":48,"context_line":"    WSGIPassAuthorization On"},{"line_number":49,"context_line":"\u003c/Location\u003e"}],"source_content_type":"application/octet-stream","patch_set":22,"id":"7ffa3b31_c3203aaf","line":48,"in_reply_to":"7ffa3b31_d1662b2a","updated":"2017-04-20 19:24:40.000000000","message":"It is possible to write logs per location, en example is http://stackoverflow.com/questions/1460757/generate-access-logs-for-different-subdirectories-in-apache","commit_id":"d036d4bf6f5b6a7541d119574c7343bc5eae7e74"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"5a8f261dfc10a2882f36e534bdcc3fd2499b1e5a","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    Options +ExecCGI"},{"line_number":46,"context_line":"    WSGIProcessGroup ironic-api"},{"line_number":47,"context_line":"    WSGIApplicationGroup %{GLOBAL}"},{"line_number":48,"context_line":"    WSGIPassAuthorization On"},{"line_number":49,"context_line":"\u003c/Location\u003e"}],"source_content_type":"application/octet-stream","patch_set":22,"id":"7ffa3b31_d1662b2a","line":48,"in_reply_to":"bff0334d_5e50db0a","updated":"2017-04-18 07:53:57.000000000","message":"Thanks Vasyl\nBut seems ironic writes log to general file\nhttp://logs.openstack.org/99/437299/37/check/gate-tempest-dsvm-ironic-ipa-wholedisk-bios-agent_ipmitool-tinyipa-ubuntu-xenial/9aae39b/logs/apache/access.txt.gz\nMay, as wrote Mario and Dmitry better to remove access log?","commit_id":"d036d4bf6f5b6a7541d119574c7343bc5eae7e74"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"9f876b1efacd095493527d1504878925b660da05","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    WSGIPassAuthorization On"},{"line_number":25,"context_line":"    ErrorLogFormat \"%M\""},{"line_number":26,"context_line":"    ErrorLog /var/log/%APACHE_NAME%/ironic-api.log"},{"line_number":27,"context_line":"    CustomLog /var/log/%APACHE_NAME%/ironic-api-access.log combined"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    \u003cDirectory %IRONIC_WSGI_DIR%\u003e"},{"line_number":30,"context_line":"        WSGIProcessGroup ironic-api"}],"source_content_type":"application/octet-stream","patch_set":24,"id":"bff0334d_960cca41","line":27,"updated":"2017-04-10 11:39:04.000000000","message":"we may stop creating this file, it seems unused now: http://logs.openstack.org/37/444337/24/check/gate-ironic-dsvm-standalone-ubuntu-xenial/453ce41/logs/apache/ironic-api-access.txt.gz","commit_id":"8328edaa3dbd90aa85b56cd3e0e311630035b876"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"a964bd7ff8184ed44cf38be62dda61289009270b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    WSGIPassAuthorization On"},{"line_number":25,"context_line":"    ErrorLogFormat \"%M\""},{"line_number":26,"context_line":"    ErrorLog /var/log/%APACHE_NAME%/ironic-api.log"},{"line_number":27,"context_line":"    CustomLog /var/log/%APACHE_NAME%/ironic-api-access.log combined"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    \u003cDirectory %IRONIC_WSGI_DIR%\u003e"},{"line_number":30,"context_line":"        WSGIProcessGroup ironic-api"}],"source_content_type":"application/octet-stream","patch_set":24,"id":"bff0334d_a07f4864","line":27,"in_reply_to":"bff0334d_960cca41","updated":"2017-04-11 21:38:53.000000000","message":"+1, I think. I\u0027m fine with this happening on a different patch though","commit_id":"8328edaa3dbd90aa85b56cd3e0e311630035b876"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"83798d38b72ebd8a3bcda3d53eeb5b6d94833014","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    WSGIPassAuthorization On"},{"line_number":25,"context_line":"    ErrorLogFormat \"%M\""},{"line_number":26,"context_line":"    ErrorLog /var/log/%APACHE_NAME%/ironic-api.log"},{"line_number":27,"context_line":"    CustomLog /var/log/%APACHE_NAME%/ironic-api-access.log combined"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    \u003cDirectory %IRONIC_WSGI_DIR%\u003e"},{"line_number":30,"context_line":"        WSGIProcessGroup ironic-api"}],"source_content_type":"application/octet-stream","patch_set":24,"id":"7ffa3b31_91eae3a9","line":27,"in_reply_to":"bff0334d_960cca41","updated":"2017-04-18 07:44:21.000000000","message":"Thanks Dmitry,\nBut all access logs write in general log file\nhttp://logs.openstack.org/37/444337/24/check/gate-ironic-dsvm-standalone-ubuntu-xenial/453ce41/logs/apache/access.txt.gz","commit_id":"8328edaa3dbd90aa85b56cd3e0e311630035b876"}],"devstack/lib/ironic":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c50b05231210a48e09ce5dfd5b28bb8fc1a3c503","unresolved":false,"context_lines":[{"line_number":974,"context_line":"    iniset $IRONIC_CONF_FILE conductor automated_clean $IRONIC_AUTOMATED_CLEAN_ENABLED"},{"line_number":975,"context_line":""},{"line_number":976,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"True\" ]]; then"},{"line_number":977,"context_line":"    iniset $IRONIC_CONF_FILE api public_endpoint $IRONIC_HOSTPORT"},{"line_number":978,"context_line":"    fi"},{"line_number":979,"context_line":""},{"line_number":980,"context_line":"    cp -p $IRONIC_DIR/etc/ironic/policy.json $IRONIC_POLICY_JSON"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"5a22e58a_621d2f0f","line":977,"updated":"2017-03-14 10:52:31.000000000","message":"nit: indentation missing","commit_id":"d44c52eb081ce916aa8fa8b3c996baa1c8bf7886"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"4ac6864e915179207c8bee87c4e7111c7d3a67c2","unresolved":false,"context_lines":[{"line_number":974,"context_line":"    iniset $IRONIC_CONF_FILE conductor automated_clean $IRONIC_AUTOMATED_CLEAN_ENABLED"},{"line_number":975,"context_line":""},{"line_number":976,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"True\" ]]; then"},{"line_number":977,"context_line":"    iniset $IRONIC_CONF_FILE api public_endpoint $IRONIC_HOSTPORT"},{"line_number":978,"context_line":"    fi"},{"line_number":979,"context_line":""},{"line_number":980,"context_line":"    cp -p $IRONIC_DIR/etc/ironic/policy.json $IRONIC_POLICY_JSON"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"5a22e58a_99f1bdd0","line":977,"in_reply_to":"5a22e58a_621d2f0f","updated":"2017-03-14 13:05:01.000000000","message":"Done","commit_id":"d44c52eb081ce916aa8fa8b3c996baa1c8bf7886"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"c50b05231210a48e09ce5dfd5b28bb8fc1a3c503","unresolved":false,"context_lines":[{"line_number":1030,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" !\u003d \"True\" ]]; then"},{"line_number":1031,"context_line":"        iniset $IRONIC_CONF_FILE conductor api_url $IRONIC_SERVICE_PROTOCOL://$SERVICE_HOST:$IRONIC_SERVICE_PORT"},{"line_number":1032,"context_line":"    else"},{"line_number":1033,"context_line":"        iniset $IRONIC_CONF_FILE conductor api_url $IRONIC_SERVICE_PROTOCOL://$IRONIC_HOSTPORT"},{"line_number":1034,"context_line":"    fi"},{"line_number":1035,"context_line":"    if [[ -n \"$IRONIC_CALLBACK_TIMEOUT\" ]]; then"},{"line_number":1036,"context_line":"        iniset $IRONIC_CONF_FILE conductor deploy_callback_timeout $IRONIC_CALLBACK_TIMEOUT"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"5a22e58a_821a2b16","line":1033,"updated":"2017-03-14 10:52:31.000000000","message":"you can just leave this variant, there is no need for a condition. without WSGI SERVICE_HOST:IRONIC_SERVICE_PORT is the same as IRONIC_HOSTPORT","commit_id":"d44c52eb081ce916aa8fa8b3c996baa1c8bf7886"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"4ac6864e915179207c8bee87c4e7111c7d3a67c2","unresolved":false,"context_lines":[{"line_number":1030,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" !\u003d \"True\" ]]; then"},{"line_number":1031,"context_line":"        iniset $IRONIC_CONF_FILE conductor api_url $IRONIC_SERVICE_PROTOCOL://$SERVICE_HOST:$IRONIC_SERVICE_PORT"},{"line_number":1032,"context_line":"    else"},{"line_number":1033,"context_line":"        iniset $IRONIC_CONF_FILE conductor api_url $IRONIC_SERVICE_PROTOCOL://$IRONIC_HOSTPORT"},{"line_number":1034,"context_line":"    fi"},{"line_number":1035,"context_line":"    if [[ -n \"$IRONIC_CALLBACK_TIMEOUT\" ]]; then"},{"line_number":1036,"context_line":"        iniset $IRONIC_CONF_FILE conductor deploy_callback_timeout $IRONIC_CALLBACK_TIMEOUT"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"5a22e58a_d9b975ee","line":1033,"in_reply_to":"5a22e58a_821a2b16","updated":"2017-03-14 13:05:01.000000000","message":"Done","commit_id":"d44c52eb081ce916aa8fa8b3c996baa1c8bf7886"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"97ccf9abe30e932f1af92782373699c8fc4ac2bf","unresolved":false,"context_lines":[{"line_number":1681,"context_line":"    sudo iptables -I INPUT -p udp --dport 67:68 --sport 67:68 -j ACCEPT || true"},{"line_number":1682,"context_line":"    # nodes boot from TFTP and callback to the API server listening on $HOST_IP"},{"line_number":1683,"context_line":"    sudo iptables -I INPUT -d $IRONIC_TFTPSERVER_IP -p udp --dport 69 -j ACCEPT || true"},{"line_number":1684,"context_line":"    sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1685,"context_line":"    if is_deployed_by_agent; then"},{"line_number":1686,"context_line":"        # agent ramdisk gets instance image from swift"},{"line_number":1687,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport ${SWIFT_DEFAULT_BIND_PORT:-8080} -j ACCEPT || true"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"5a22e58a_229ed756","line":1684,"updated":"2017-03-14 10:56:18.000000000","message":"we may have to update this one to enable the default port..","commit_id":"d44c52eb081ce916aa8fa8b3c996baa1c8bf7886"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"4ac6864e915179207c8bee87c4e7111c7d3a67c2","unresolved":false,"context_lines":[{"line_number":1681,"context_line":"    sudo iptables -I INPUT -p udp --dport 67:68 --sport 67:68 -j ACCEPT || true"},{"line_number":1682,"context_line":"    # nodes boot from TFTP and callback to the API server listening on $HOST_IP"},{"line_number":1683,"context_line":"    sudo iptables -I INPUT -d $IRONIC_TFTPSERVER_IP -p udp --dport 69 -j ACCEPT || true"},{"line_number":1684,"context_line":"    sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1685,"context_line":"    if is_deployed_by_agent; then"},{"line_number":1686,"context_line":"        # agent ramdisk gets instance image from swift"},{"line_number":1687,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport ${SWIFT_DEFAULT_BIND_PORT:-8080} -j ACCEPT || true"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"5a22e58a_9920ddf9","line":1684,"in_reply_to":"5a22e58a_229ed756","updated":"2017-03-14 13:05:01.000000000","message":"Thanks Dmitry\nI didn\u0027t look at iptables rules and supposed that rule exist for default port, and test was passed in this case\nI\u0027ll resolve it","commit_id":"d44c52eb081ce916aa8fa8b3c996baa1c8bf7886"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"b4a85fdfc42c9489d283a71361be57ee0e13b283","unresolved":false,"context_lines":[{"line_number":273,"context_line":"    IRONIC_SERVICE_PORT\u003d${IRONIC_SERVICE_PORT:-6385}"},{"line_number":274,"context_line":"    IRONIC_HOSTPORT\u003d${IRONIC_HOSTPORT:-$SERVICE_HOST:$IRONIC_SERVICE_PORT}"},{"line_number":275,"context_line":"else"},{"line_number":276,"context_line":"    IRONIC_SERVICE_PORT\u003d${IRONIC_SERVICE_PORT:-80}"},{"line_number":277,"context_line":"    IRONIC_HOSTPORT\u003d${IRONIC_HOSTPORT:-$SERVICE_HOST/baremetal}"},{"line_number":278,"context_line":"fi"},{"line_number":279,"context_line":"# Enable iPXE"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"3a1ff146_a5c56a5c","line":276,"updated":"2017-03-14 23:01:32.000000000","message":"So what if I set IRONIC_SERVICE_PORT\u003d8080 ?\n\nIRONIC_HOSTPORT doesn\u0027t seem to care what was set for IRONIC_SERVICE_PORT","commit_id":"1713e02452226d2e798b72d1222e5d51ed440fbb"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"743d6ee8f925a92ca1f50425212899f10055ad4c","unresolved":false,"context_lines":[{"line_number":273,"context_line":"    IRONIC_SERVICE_PORT\u003d${IRONIC_SERVICE_PORT:-6385}"},{"line_number":274,"context_line":"    IRONIC_HOSTPORT\u003d${IRONIC_HOSTPORT:-$SERVICE_HOST:$IRONIC_SERVICE_PORT}"},{"line_number":275,"context_line":"else"},{"line_number":276,"context_line":"    IRONIC_SERVICE_PORT\u003d${IRONIC_SERVICE_PORT:-80}"},{"line_number":277,"context_line":"    IRONIC_HOSTPORT\u003d${IRONIC_HOSTPORT:-$SERVICE_HOST/baremetal}"},{"line_number":278,"context_line":"fi"},{"line_number":279,"context_line":"# Enable iPXE"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"3a1ff146_b7b02e8d","line":276,"in_reply_to":"3a1ff146_a5c56a5c","updated":"2017-03-15 08:59:08.000000000","message":"Thanks John\nIRONIC_HOSTPORT doesn\u0027t need this var, but we need it in iptables rule\nhttps://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L1673\nI didn\u0027t find rule for 80 port in devstack","commit_id":"1713e02452226d2e798b72d1222e5d51ed440fbb"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"0e0785055ef7cca119d675d88731e51db63a266b","unresolved":false,"context_lines":[{"line_number":273,"context_line":"    IRONIC_SERVICE_PORT\u003d${IRONIC_SERVICE_PORT:-6385}"},{"line_number":274,"context_line":"    IRONIC_HOSTPORT\u003d${IRONIC_HOSTPORT:-$SERVICE_HOST:$IRONIC_SERVICE_PORT}"},{"line_number":275,"context_line":"else"},{"line_number":276,"context_line":"    IRONIC_SERVICE_PORT\u003d${IRONIC_SERVICE_PORT:-80}"},{"line_number":277,"context_line":"    IRONIC_HOSTPORT\u003d${IRONIC_HOSTPORT:-$SERVICE_HOST/baremetal}"},{"line_number":278,"context_line":"fi"},{"line_number":279,"context_line":"# Enable iPXE"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"1a1ced50_090cad41","line":276,"in_reply_to":"3a1ff146_b7b02e8d","updated":"2017-03-16 17:03:13.000000000","message":"Right, so if someone sets it to port 8080, then we will ignore that for the endpoint, but open the firewall port for 8080.","commit_id":"1713e02452226d2e798b72d1222e5d51ed440fbb"},{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"5e82367d8a249c636d5c84add507b16de286e117","unresolved":false,"context_lines":[{"line_number":272,"context_line":"if [[ \"$IRONIC_USE_MOD_WSGI\" !\u003d \"True\" ]]; then"},{"line_number":273,"context_line":"    IRONIC_SERVICE_PORT\u003d${IRONIC_SERVICE_PORT:-6385}"},{"line_number":274,"context_line":"    IRONIC_HOSTPORT\u003d${IRONIC_HOSTPORT:-$SERVICE_HOST:$IRONIC_SERVICE_PORT}"},{"line_number":275,"context_line":"else"},{"line_number":276,"context_line":"    IRONIC_SERVICE_PORT\u003d80"},{"line_number":277,"context_line":"    IRONIC_HOSTPORT\u003d${IRONIC_HOSTPORT:-$SERVICE_HOST/baremetal}"},{"line_number":278,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"1a1ced50_5b9ac715","line":275,"updated":"2017-03-17 13:38:27.000000000","message":"Please add a comment that we only support MOD_WSGI on port 80\n\nAlso what happens when we start supporting HTTPS?","commit_id":"af4931794bb212aeff92b0db19a1a94759f0e1b8"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"21a897517a154e0794c8141bcf3984ceaf602a16","unresolved":false,"context_lines":[{"line_number":272,"context_line":"if [[ \"$IRONIC_USE_MOD_WSGI\" !\u003d \"True\" ]]; then"},{"line_number":273,"context_line":"    IRONIC_SERVICE_PORT\u003d${IRONIC_SERVICE_PORT:-6385}"},{"line_number":274,"context_line":"    IRONIC_HOSTPORT\u003d${IRONIC_HOSTPORT:-$SERVICE_HOST:$IRONIC_SERVICE_PORT}"},{"line_number":275,"context_line":"else"},{"line_number":276,"context_line":"    IRONIC_SERVICE_PORT\u003d80"},{"line_number":277,"context_line":"    IRONIC_HOSTPORT\u003d${IRONIC_HOSTPORT:-$SERVICE_HOST/baremetal}"},{"line_number":278,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"ffe62b97_8569608c","line":275,"in_reply_to":"1a1ced50_5b9ac715","updated":"2017-03-27 11:26:55.000000000","message":"For SSL I prepare another patch, but it not ready\nhttps://review.openstack.org/#/c/442402/\nAbout comment\u0027s I\u0027ll add it in iptables section","commit_id":"af4931794bb212aeff92b0db19a1a94759f0e1b8"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"541aa9cf176ab0169305c2afdab4c213b27849d7","unresolved":false,"context_lines":[{"line_number":970,"context_line":"    iniset $IRONIC_CONF_FILE oslo_policy policy_file $IRONIC_POLICY_JSON"},{"line_number":971,"context_line":""},{"line_number":972,"context_line":"    iniset_rpc_backend ironic $IRONIC_CONF_FILE"},{"line_number":973,"context_line":"    iniset $IRONIC_CONF_FILE api port $IRONIC_SERVICE_PORT"},{"line_number":974,"context_line":""},{"line_number":975,"context_line":"    iniset $IRONIC_CONF_FILE conductor automated_clean $IRONIC_AUTOMATED_CLEAN_ENABLED"},{"line_number":976,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"1a1ced50_5b31e7a1","line":973,"updated":"2017-03-17 13:39:27.000000000","message":"Do we need to write it in case of apache? it seems to be used only when the service running by itself? OTOH it does not seem to make any harm.","commit_id":"af4931794bb212aeff92b0db19a1a94759f0e1b8"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"21a897517a154e0794c8141bcf3984ceaf602a16","unresolved":false,"context_lines":[{"line_number":970,"context_line":"    iniset $IRONIC_CONF_FILE oslo_policy policy_file $IRONIC_POLICY_JSON"},{"line_number":971,"context_line":""},{"line_number":972,"context_line":"    iniset_rpc_backend ironic $IRONIC_CONF_FILE"},{"line_number":973,"context_line":"    iniset $IRONIC_CONF_FILE api port $IRONIC_SERVICE_PORT"},{"line_number":974,"context_line":""},{"line_number":975,"context_line":"    iniset $IRONIC_CONF_FILE conductor automated_clean $IRONIC_AUTOMATED_CLEAN_ENABLED"},{"line_number":976,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"ffe62b97_65909c44","line":973,"in_reply_to":"1a1ced50_5b31e7a1","updated":"2017-03-27 11:26:55.000000000","message":"Thanks Vladyslav,\nYou are right we need it only for WSGI","commit_id":"af4931794bb212aeff92b0db19a1a94759f0e1b8"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"541aa9cf176ab0169305c2afdab4c213b27849d7","unresolved":false,"context_lines":[{"line_number":1678,"context_line":"    sudo iptables -I INPUT -p udp --dport 67:68 --sport 67:68 -j ACCEPT || true"},{"line_number":1679,"context_line":"    # nodes boot from TFTP and callback to the API server listening on $HOST_IP"},{"line_number":1680,"context_line":"    sudo iptables -I INPUT -d $IRONIC_TFTPSERVER_IP -p udp --dport 69 -j ACCEPT || true"},{"line_number":1681,"context_line":"    sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1682,"context_line":"    if is_deployed_by_agent; then"},{"line_number":1683,"context_line":"        # agent ramdisk gets instance image from swift"},{"line_number":1684,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport ${SWIFT_DEFAULT_BIND_PORT:-8080} -j ACCEPT || true"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"1a1ced50_7bab038a","line":1681,"updated":"2017-03-17 13:39:27.000000000","message":"Do we need to fiddle with port 80 in case of apache? there is also a corresponding iptables -D line further in the file. Maybe some other service like keystone already does it?","commit_id":"af4931794bb212aeff92b0db19a1a94759f0e1b8"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"21a897517a154e0794c8141bcf3984ceaf602a16","unresolved":false,"context_lines":[{"line_number":1678,"context_line":"    sudo iptables -I INPUT -p udp --dport 67:68 --sport 67:68 -j ACCEPT || true"},{"line_number":1679,"context_line":"    # nodes boot from TFTP and callback to the API server listening on $HOST_IP"},{"line_number":1680,"context_line":"    sudo iptables -I INPUT -d $IRONIC_TFTPSERVER_IP -p udp --dport 69 -j ACCEPT || true"},{"line_number":1681,"context_line":"    sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1682,"context_line":"    if is_deployed_by_agent; then"},{"line_number":1683,"context_line":"        # agent ramdisk gets instance image from swift"},{"line_number":1684,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport ${SWIFT_DEFAULT_BIND_PORT:-8080} -j ACCEPT || true"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"ffe62b97_e5602c04","line":1681,"in_reply_to":"1a1ced50_7bab038a","updated":"2017-03-27 11:26:55.000000000","message":"If we don\u0027t add this rule we would have a problem when try create server. Because in default all traffic for host service follow through \"lo-interface\".","commit_id":"af4931794bb212aeff92b0db19a1a94759f0e1b8"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"92760c32f23bb9af3a589324c9b4f4a437f44872","unresolved":false,"context_lines":[{"line_number":1680,"context_line":"    sudo iptables -I INPUT -p udp --dport 67:68 --sport 67:68 -j ACCEPT || true"},{"line_number":1681,"context_line":"    # nodes boot from TFTP and callback to the API server listening on $HOST_IP"},{"line_number":1682,"context_line":"    sudo iptables -I INPUT -d $IRONIC_TFTPSERVER_IP -p udp --dport 69 -j ACCEPT || true"},{"line_number":1683,"context_line":"    # For ironic api running under apache we need create rule for default apache port,"},{"line_number":1684,"context_line":"    #because it don\u0027t create by default when apache is installed"},{"line_number":1685,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"},{"line_number":1686,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"dfeb2761_6cad1987","line":1683,"range":{"start_line":1683,"start_character":45,"end_line":1683,"end_character":56},"updated":"2017-04-04 04:23:59.000000000","message":"we need to create","commit_id":"a940be4435dc3aeb90057b12be9e24cec402a776"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"f27a6c9762c7743a3c4f4250f28225a768a265a5","unresolved":false,"context_lines":[{"line_number":1680,"context_line":"    sudo iptables -I INPUT -p udp --dport 67:68 --sport 67:68 -j ACCEPT || true"},{"line_number":1681,"context_line":"    # nodes boot from TFTP and callback to the API server listening on $HOST_IP"},{"line_number":1682,"context_line":"    sudo iptables -I INPUT -d $IRONIC_TFTPSERVER_IP -p udp --dport 69 -j ACCEPT || true"},{"line_number":1683,"context_line":"    # For ironic api running under apache we need create rule for default apache port,"},{"line_number":1684,"context_line":"    #because it don\u0027t create by default when apache is installed"},{"line_number":1685,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"},{"line_number":1686,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"dfeb2761_82c6e199","line":1683,"range":{"start_line":1683,"start_character":45,"end_line":1683,"end_character":56},"in_reply_to":"dfeb2761_6cad1987","updated":"2017-04-04 09:20:18.000000000","message":"Thanks Rushil,\nI resolved it","commit_id":"a940be4435dc3aeb90057b12be9e24cec402a776"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"da0c18ec79cec79273c04d97416e0cdacd5370ca","unresolved":false,"context_lines":[{"line_number":1681,"context_line":"    # nodes boot from TFTP and callback to the API server listening on $HOST_IP"},{"line_number":1682,"context_line":"    sudo iptables -I INPUT -d $IRONIC_TFTPSERVER_IP -p udp --dport 69 -j ACCEPT || true"},{"line_number":1683,"context_line":"    # For ironic api running under apache we need create rule for default apache port,"},{"line_number":1684,"context_line":"    #because it don\u0027t create by default when apache is installed"},{"line_number":1685,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"},{"line_number":1686,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1687,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"dfeb2761_290efa3a","line":1684,"updated":"2017-04-03 14:18:24.000000000","message":"nit: missed space","commit_id":"a940be4435dc3aeb90057b12be9e24cec402a776"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"92760c32f23bb9af3a589324c9b4f4a437f44872","unresolved":false,"context_lines":[{"line_number":1681,"context_line":"    # nodes boot from TFTP and callback to the API server listening on $HOST_IP"},{"line_number":1682,"context_line":"    sudo iptables -I INPUT -d $IRONIC_TFTPSERVER_IP -p udp --dport 69 -j ACCEPT || true"},{"line_number":1683,"context_line":"    # For ironic api running under apache we need create rule for default apache port,"},{"line_number":1684,"context_line":"    #because it don\u0027t create by default when apache is installed"},{"line_number":1685,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"},{"line_number":1686,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1687,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"dfeb2761_0cbc4db9","line":1684,"range":{"start_line":1684,"start_character":16,"end_line":1684,"end_character":21},"updated":"2017-04-04 04:23:59.000000000","message":"s/don\u0027t/doesn\u0027t","commit_id":"a940be4435dc3aeb90057b12be9e24cec402a776"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"f27a6c9762c7743a3c4f4250f28225a768a265a5","unresolved":false,"context_lines":[{"line_number":1681,"context_line":"    # nodes boot from TFTP and callback to the API server listening on $HOST_IP"},{"line_number":1682,"context_line":"    sudo iptables -I INPUT -d $IRONIC_TFTPSERVER_IP -p udp --dport 69 -j ACCEPT || true"},{"line_number":1683,"context_line":"    # For ironic api running under apache we need create rule for default apache port,"},{"line_number":1684,"context_line":"    #because it don\u0027t create by default when apache is installed"},{"line_number":1685,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"},{"line_number":1686,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1687,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"dfeb2761_22bb950e","line":1684,"range":{"start_line":1684,"start_character":16,"end_line":1684,"end_character":21},"in_reply_to":"dfeb2761_0cbc4db9","updated":"2017-04-04 09:20:18.000000000","message":"Done","commit_id":"a940be4435dc3aeb90057b12be9e24cec402a776"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"f27a6c9762c7743a3c4f4250f28225a768a265a5","unresolved":false,"context_lines":[{"line_number":1681,"context_line":"    # nodes boot from TFTP and callback to the API server listening on $HOST_IP"},{"line_number":1682,"context_line":"    sudo iptables -I INPUT -d $IRONIC_TFTPSERVER_IP -p udp --dport 69 -j ACCEPT || true"},{"line_number":1683,"context_line":"    # For ironic api running under apache we need create rule for default apache port,"},{"line_number":1684,"context_line":"    #because it don\u0027t create by default when apache is installed"},{"line_number":1685,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"},{"line_number":1686,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1687,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"dfeb2761_42c0d97b","line":1684,"in_reply_to":"dfeb2761_290efa3a","updated":"2017-04-04 09:20:18.000000000","message":"Thanks, Vasyl\nDone","commit_id":"a940be4435dc3aeb90057b12be9e24cec402a776"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"da0c18ec79cec79273c04d97416e0cdacd5370ca","unresolved":false,"context_lines":[{"line_number":1964,"context_line":"    sudo rm -rf /etc/xinetd.d/tftp /etc/init/tftpd-hpa.override"},{"line_number":1965,"context_line":"    restart_service xinetd"},{"line_number":1966,"context_line":"    sudo iptables -D INPUT -d $HOST_IP -p udp --dport 69 -j ACCEPT || true"},{"line_number":1967,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"},{"line_number":1968,"context_line":"        sudo iptables -D INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1969,"context_line":"    else"},{"line_number":1970,"context_line":"        sudo iptables -D INPUT -d $HOST_IP -p tcp --dport $80 -j ACCEPT || true"}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"dfeb2761_043c3dbd","line":1967,"updated":"2017-04-03 14:18:24.000000000","message":"no need for this check just try to delete both when cleanup.","commit_id":"a940be4435dc3aeb90057b12be9e24cec402a776"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"92760c32f23bb9af3a589324c9b4f4a437f44872","unresolved":false,"context_lines":[{"line_number":1964,"context_line":"    sudo rm -rf /etc/xinetd.d/tftp /etc/init/tftpd-hpa.override"},{"line_number":1965,"context_line":"    restart_service xinetd"},{"line_number":1966,"context_line":"    sudo iptables -D INPUT -d $HOST_IP -p udp --dport 69 -j ACCEPT || true"},{"line_number":1967,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"},{"line_number":1968,"context_line":"        sudo iptables -D INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1969,"context_line":"    else"},{"line_number":1970,"context_line":"        sudo iptables -D INPUT -d $HOST_IP -p tcp --dport $80 -j ACCEPT || true"}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"dfeb2761_accc416a","line":1967,"in_reply_to":"dfeb2761_043c3dbd","updated":"2017-04-04 04:23:59.000000000","message":"+1","commit_id":"a940be4435dc3aeb90057b12be9e24cec402a776"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"f27a6c9762c7743a3c4f4250f28225a768a265a5","unresolved":false,"context_lines":[{"line_number":1964,"context_line":"    sudo rm -rf /etc/xinetd.d/tftp /etc/init/tftpd-hpa.override"},{"line_number":1965,"context_line":"    restart_service xinetd"},{"line_number":1966,"context_line":"    sudo iptables -D INPUT -d $HOST_IP -p udp --dport 69 -j ACCEPT || true"},{"line_number":1967,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"},{"line_number":1968,"context_line":"        sudo iptables -D INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1969,"context_line":"    else"},{"line_number":1970,"context_line":"        sudo iptables -D INPUT -d $HOST_IP -p tcp --dport $80 -j ACCEPT || true"}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"dfeb2761_c20f49df","line":1967,"in_reply_to":"dfeb2761_043c3dbd","updated":"2017-04-04 09:20:18.000000000","message":"Thanks, Vasyl\nI thinks it good idea","commit_id":"a940be4435dc3aeb90057b12be9e24cec402a776"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"f27a6c9762c7743a3c4f4250f28225a768a265a5","unresolved":false,"context_lines":[{"line_number":1964,"context_line":"    sudo rm -rf /etc/xinetd.d/tftp /etc/init/tftpd-hpa.override"},{"line_number":1965,"context_line":"    restart_service xinetd"},{"line_number":1966,"context_line":"    sudo iptables -D INPUT -d $HOST_IP -p udp --dport 69 -j ACCEPT || true"},{"line_number":1967,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"},{"line_number":1968,"context_line":"        sudo iptables -D INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1969,"context_line":"    else"},{"line_number":1970,"context_line":"        sudo iptables -D INPUT -d $HOST_IP -p tcp --dport $80 -j ACCEPT || true"}],"source_content_type":"application/x-shellscript","patch_set":18,"id":"dfeb2761_a2120508","line":1967,"in_reply_to":"dfeb2761_accc416a","updated":"2017-04-04 09:20:18.000000000","message":"Done","commit_id":"a940be4435dc3aeb90057b12be9e24cec402a776"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"324b2a15b88e1fa99845e241cdbbc115d82615eb","unresolved":false,"context_lines":[{"line_number":1966,"context_line":"    restart_service xinetd"},{"line_number":1967,"context_line":"    sudo iptables -D INPUT -d $HOST_IP -p udp --dport 69 -j ACCEPT || true"},{"line_number":1968,"context_line":"    sudo iptables -D INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1969,"context_line":"    sudo iptables -D INPUT -d $HOST_IP -p tcp --dport $80 -j ACCEPT || true"},{"line_number":1970,"context_line":"    if is_deployed_by_agent; then"},{"line_number":1971,"context_line":"        # agent ramdisk gets instance image from swift"},{"line_number":1972,"context_line":"        sudo iptables -D INPUT -d $HOST_IP -p tcp --dport ${SWIFT_DEFAULT_BIND_PORT:-8080} -j ACCEPT || true"}],"source_content_type":"application/x-shellscript","patch_set":20,"id":"dfeb2761_666884b8","line":1969,"updated":"2017-04-04 14:35:23.000000000","message":"incorrect $ before 80","commit_id":"b9b75a6354fa069913882e3f51e06ed2f2ac6370"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"67c6d193b6a6fd38158a47b80b21f19df664afde","unresolved":false,"context_lines":[{"line_number":1966,"context_line":"    restart_service xinetd"},{"line_number":1967,"context_line":"    sudo iptables -D INPUT -d $HOST_IP -p udp --dport 69 -j ACCEPT || true"},{"line_number":1968,"context_line":"    sudo iptables -D INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1969,"context_line":"    sudo iptables -D INPUT -d $HOST_IP -p tcp --dport $80 -j ACCEPT || true"},{"line_number":1970,"context_line":"    if is_deployed_by_agent; then"},{"line_number":1971,"context_line":"        # agent ramdisk gets instance image from swift"},{"line_number":1972,"context_line":"        sudo iptables -D INPUT -d $HOST_IP -p tcp --dport ${SWIFT_DEFAULT_BIND_PORT:-8080} -j ACCEPT || true"}],"source_content_type":"application/x-shellscript","patch_set":20,"id":"dfeb2761_9a299ce7","line":1969,"in_reply_to":"dfeb2761_666884b8","updated":"2017-04-04 15:15:23.000000000","message":"Thanks, Dmitry\nSorry for this mistake, it was recklessly from my side","commit_id":"b9b75a6354fa069913882e3f51e06ed2f2ac6370"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"8b519033d29b9efb0b43e905ac0c25885754bac6","unresolved":false,"context_lines":[{"line_number":1680,"context_line":"    sudo iptables -I INPUT -p udp --dport 67:68 --sport 67:68 -j ACCEPT || true"},{"line_number":1681,"context_line":"    # nodes boot from TFTP and callback to the API server listening on $HOST_IP"},{"line_number":1682,"context_line":"    sudo iptables -I INPUT -d $IRONIC_TFTPSERVER_IP -p udp --dport 69 -j ACCEPT || true"},{"line_number":1683,"context_line":"    # For ironic api running under apache we need to create rule for default apache port,"},{"line_number":1684,"context_line":"    #because it doesn\u0027t create by default when apache is installed"},{"line_number":1685,"context_line":""},{"line_number":1686,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":21,"id":"dfeb2761_cbb0668d","line":1683,"updated":"2017-04-05 00:08:14.000000000","message":"I find this comment confusing, since from what I understand in both cases it\u0027s running under apache?\nI\u0027d rephrase so it indicates the actual scenario. Moving this comment above line 1689 is also a good idea.\n\ns/rule/a rule/\ns/it doesn\u0027t create/it is not created/","commit_id":"108c77e129b438b5e4fec36754ef3f58bf703ffe"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"73296d87029eb18f5461d18dc1eb2777de6c8633","unresolved":false,"context_lines":[{"line_number":1680,"context_line":"    sudo iptables -I INPUT -p udp --dport 67:68 --sport 67:68 -j ACCEPT || true"},{"line_number":1681,"context_line":"    # nodes boot from TFTP and callback to the API server listening on $HOST_IP"},{"line_number":1682,"context_line":"    sudo iptables -I INPUT -d $IRONIC_TFTPSERVER_IP -p udp --dport 69 -j ACCEPT || true"},{"line_number":1683,"context_line":"    # For ironic api running under apache we need to create rule for default apache port,"},{"line_number":1684,"context_line":"    #because it doesn\u0027t create by default when apache is installed"},{"line_number":1685,"context_line":""},{"line_number":1686,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":21,"id":"dfeb2761_967a79b7","line":1683,"in_reply_to":"dfeb2761_cbb0668d","updated":"2017-04-05 10:21:46.000000000","message":"Thanks Joanna,\nNow when ironic API is installed under apache it uses port, in this patch we use path instead of port  for WSGI, and all services will be working in default port 80 or 443 if it uses ssl (it\u0027s another patch)","commit_id":"108c77e129b438b5e4fec36754ef3f58bf703ffe"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"8b519033d29b9efb0b43e905ac0c25885754bac6","unresolved":false,"context_lines":[{"line_number":1686,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"},{"line_number":1687,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1688,"context_line":"    else"},{"line_number":1689,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport 80 -j ACCEPT || true"},{"line_number":1690,"context_line":"    fi"},{"line_number":1691,"context_line":"    if is_deployed_by_agent; then"},{"line_number":1692,"context_line":"        # agent ramdisk gets instance image from swift"}],"source_content_type":"application/x-shellscript","patch_set":21,"id":"dfeb2761_2b6b52f1","line":1689,"updated":"2017-04-05 00:08:14.000000000","message":"I think it may be a good idea to have a variable for that instead of using a magic number.\nIn case of aliasing, it attaches to horizon apache instance, hence the question - can user specify a different port for it, e.g. 8080?","commit_id":"108c77e129b438b5e4fec36754ef3f58bf703ffe"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"73296d87029eb18f5461d18dc1eb2777de6c8633","unresolved":false,"context_lines":[{"line_number":1686,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"},{"line_number":1687,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1688,"context_line":"    else"},{"line_number":1689,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport 80 -j ACCEPT || true"},{"line_number":1690,"context_line":"    fi"},{"line_number":1691,"context_line":"    if is_deployed_by_agent; then"},{"line_number":1692,"context_line":"        # agent ramdisk gets instance image from swift"}],"source_content_type":"application/x-shellscript","patch_set":21,"id":"dfeb2761_99de2ad8","line":1689,"in_reply_to":"dfeb2761_2b6b52f1","updated":"2017-04-05 10:21:46.000000000","message":"I had a patch with var $IRONIC_SERVICE_PORT, but it was not good idea for secure reason\nhttps://review.openstack.org/#/c/444337/14/devstack/lib/ironic@276\nAnd it won\u0027t have problem with horizon or other services","commit_id":"108c77e129b438b5e4fec36754ef3f58bf703ffe"},{"author":{"_account_id":22042,"name":"Chris Smart","email":"distroguy@gmail.com","username":"csmart"},"change_message_id":"14b52a6777a38aa32daa106ac373dbfe532c00f3","unresolved":false,"context_lines":[{"line_number":274,"context_line":"if [[ \"$IRONIC_USE_MOD_WSGI\" !\u003d \"True\" ]]; then"},{"line_number":275,"context_line":"    IRONIC_HOSTPORT\u003d${IRONIC_HOSTPORT:-$SERVICE_HOST:$IRONIC_SERVICE_PORT}"},{"line_number":276,"context_line":"else"},{"line_number":277,"context_line":"    IRONIC_HOSTPORT\u003d${IRONIC_HOSTPORT:-$SERVICE_HOST/baremetal}"},{"line_number":278,"context_line":"fi"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"# Enable iPXE"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"dfeb2761_db95c288","line":277,"updated":"2017-04-05 12:03:03.000000000","message":"Just a thought, we\u0027re using ${:-} here so what if IRONIC_HOSTPORT already exists and is set to a port rather than a path? will this cause a problem later?\n\ni.e. you\u0027re expecting to use a path if IRONIC_USE_MOD_WSGI is set to true, but you won\u0027t actually be if IRONIC_HOSTPORT already exists and is set to a port.","commit_id":"d036d4bf6f5b6a7541d119574c7343bc5eae7e74"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"7feff1e3866c1d10cc28bbcfab248bfdb938e915","unresolved":false,"context_lines":[{"line_number":274,"context_line":"if [[ \"$IRONIC_USE_MOD_WSGI\" !\u003d \"True\" ]]; then"},{"line_number":275,"context_line":"    IRONIC_HOSTPORT\u003d${IRONIC_HOSTPORT:-$SERVICE_HOST:$IRONIC_SERVICE_PORT}"},{"line_number":276,"context_line":"else"},{"line_number":277,"context_line":"    IRONIC_HOSTPORT\u003d${IRONIC_HOSTPORT:-$SERVICE_HOST/baremetal}"},{"line_number":278,"context_line":"fi"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"# Enable iPXE"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"bff0334d_d39e2462","line":277,"in_reply_to":"bff0334d_33b9d72d","updated":"2017-04-07 06:11:00.000000000","message":"I\u0027m ok with this as is, we can\u0027t prevent user from creating non working combinations.\nPicking IRONIC_HOSTPORT here will allow user to override ironic service host for example, as we do not have a separate IRONIC_SERVICE_HOST variable which we probably should introduce in future.","commit_id":"d036d4bf6f5b6a7541d119574c7343bc5eae7e74"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"6aac053c8115e2a869b743b0656ae547ecf14676","unresolved":false,"context_lines":[{"line_number":274,"context_line":"if [[ \"$IRONIC_USE_MOD_WSGI\" !\u003d \"True\" ]]; then"},{"line_number":275,"context_line":"    IRONIC_HOSTPORT\u003d${IRONIC_HOSTPORT:-$SERVICE_HOST:$IRONIC_SERVICE_PORT}"},{"line_number":276,"context_line":"else"},{"line_number":277,"context_line":"    IRONIC_HOSTPORT\u003d${IRONIC_HOSTPORT:-$SERVICE_HOST/baremetal}"},{"line_number":278,"context_line":"fi"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"# Enable iPXE"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"bff0334d_8ad14f26","line":277,"in_reply_to":"bff0334d_33b9d72d","updated":"2017-04-09 22:12:33.000000000","message":"Thanks, Joanna\nvar IRONIC_HOSTPORT we can change or renamed if it\u0027s mislead you, but It\u0027s not goal of this patch. When we use WSGI we don\u0027t use ports. As it works now in keystone","commit_id":"d036d4bf6f5b6a7541d119574c7343bc5eae7e74"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"6aac053c8115e2a869b743b0656ae547ecf14676","unresolved":false,"context_lines":[{"line_number":274,"context_line":"if [[ \"$IRONIC_USE_MOD_WSGI\" !\u003d \"True\" ]]; then"},{"line_number":275,"context_line":"    IRONIC_HOSTPORT\u003d${IRONIC_HOSTPORT:-$SERVICE_HOST:$IRONIC_SERVICE_PORT}"},{"line_number":276,"context_line":"else"},{"line_number":277,"context_line":"    IRONIC_HOSTPORT\u003d${IRONIC_HOSTPORT:-$SERVICE_HOST/baremetal}"},{"line_number":278,"context_line":"fi"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"# Enable iPXE"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"bff0334d_2ac4835e","line":277,"in_reply_to":"bff0334d_d39e2462","updated":"2017-04-09 22:12:33.000000000","message":"Thanks Vasyl for your help in comments","commit_id":"d036d4bf6f5b6a7541d119574c7343bc5eae7e74"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"d6ba8be32f44a2202673a9874795ab79aad0077a","unresolved":false,"context_lines":[{"line_number":274,"context_line":"if [[ \"$IRONIC_USE_MOD_WSGI\" !\u003d \"True\" ]]; then"},{"line_number":275,"context_line":"    IRONIC_HOSTPORT\u003d${IRONIC_HOSTPORT:-$SERVICE_HOST:$IRONIC_SERVICE_PORT}"},{"line_number":276,"context_line":"else"},{"line_number":277,"context_line":"    IRONIC_HOSTPORT\u003d${IRONIC_HOSTPORT:-$SERVICE_HOST/baremetal}"},{"line_number":278,"context_line":"fi"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"# Enable iPXE"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"bff0334d_33b9d72d","line":277,"in_reply_to":"dfeb2761_db95c288","updated":"2017-04-07 00:29:11.000000000","message":"I think that if it\u0027s set, it should be used, because this is what user wants to be used (even for wsgi)... Oksana - WDYT?\nThe naming in your comment confuses me - just to clarify HOSTPORT is not a port, it\u0027s a whole path w/o protocol. IRONIC_SERVICE_PORT is a port (that is supposed to be replaced with \u0027/baremetal\u0027 if HOSTPORT is not set).","commit_id":"d036d4bf6f5b6a7541d119574c7343bc5eae7e74"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"6aac053c8115e2a869b743b0656ae547ecf14676","unresolved":false,"context_lines":[{"line_number":274,"context_line":"if [[ \"$IRONIC_USE_MOD_WSGI\" !\u003d \"True\" ]]; then"},{"line_number":275,"context_line":"    IRONIC_HOSTPORT\u003d${IRONIC_HOSTPORT:-$SERVICE_HOST:$IRONIC_SERVICE_PORT}"},{"line_number":276,"context_line":"else"},{"line_number":277,"context_line":"    IRONIC_HOSTPORT\u003d${IRONIC_HOSTPORT:-$SERVICE_HOST/baremetal}"},{"line_number":278,"context_line":"fi"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"# Enable iPXE"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"bff0334d_0a309f9e","line":277,"in_reply_to":"dfeb2761_db95c288","updated":"2017-04-09 22:12:33.000000000","message":"Thanks, Chris\nСertainly, we would have a problem if used incorrectly var, but we can get this issue with any incorrect value of variable.\nYou are right that better use harded value, becouse we preordination a path in apache conf \"/baremetal\"","commit_id":"d036d4bf6f5b6a7541d119574c7343bc5eae7e74"},{"author":{"_account_id":22042,"name":"Chris Smart","email":"distroguy@gmail.com","username":"csmart"},"change_message_id":"14b52a6777a38aa32daa106ac373dbfe532c00f3","unresolved":false,"context_lines":[{"line_number":975,"context_line":"    iniset $IRONIC_CONF_FILE conductor automated_clean $IRONIC_AUTOMATED_CLEAN_ENABLED"},{"line_number":976,"context_line":""},{"line_number":977,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"True\" ]]; then"},{"line_number":978,"context_line":"        iniset $IRONIC_CONF_FILE api public_endpoint $IRONIC_SERVICE_PROTOCOL://$IRONIC_HOSTPORT"},{"line_number":979,"context_line":"    else"},{"line_number":980,"context_line":"        iniset $IRONIC_CONF_FILE api port $IRONIC_SERVICE_PORT"},{"line_number":981,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"dfeb2761_9be05a28","line":978,"updated":"2017-04-05 12:03:03.000000000","message":"See comment above, what happens if IRONIC_HOSTPORT is a port rather than a path at this point?","commit_id":"d036d4bf6f5b6a7541d119574c7343bc5eae7e74"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"7feff1e3866c1d10cc28bbcfab248bfdb938e915","unresolved":false,"context_lines":[{"line_number":975,"context_line":"    iniset $IRONIC_CONF_FILE conductor automated_clean $IRONIC_AUTOMATED_CLEAN_ENABLED"},{"line_number":976,"context_line":""},{"line_number":977,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"True\" ]]; then"},{"line_number":978,"context_line":"        iniset $IRONIC_CONF_FILE api public_endpoint $IRONIC_SERVICE_PROTOCOL://$IRONIC_HOSTPORT"},{"line_number":979,"context_line":"    else"},{"line_number":980,"context_line":"        iniset $IRONIC_CONF_FILE api port $IRONIC_SERVICE_PORT"},{"line_number":981,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"bff0334d_3e22b7a5","line":978,"in_reply_to":"dfeb2761_9be05a28","updated":"2017-04-07 06:11:00.000000000","message":"we will not prevent user from creating non-working combinations.","commit_id":"d036d4bf6f5b6a7541d119574c7343bc5eae7e74"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"d6ba8be32f44a2202673a9874795ab79aad0077a","unresolved":false,"context_lines":[{"line_number":1680,"context_line":"    sudo iptables -I INPUT -p udp --dport 67:68 --sport 67:68 -j ACCEPT || true"},{"line_number":1681,"context_line":"    # nodes boot from TFTP and callback to the API server listening on $HOST_IP"},{"line_number":1682,"context_line":"    sudo iptables -I INPUT -d $IRONIC_TFTPSERVER_IP -p udp --dport 69 -j ACCEPT || true"},{"line_number":1683,"context_line":"    # We need to create a rule for default apache\u0027s port,"},{"line_number":1684,"context_line":"    # it\u0027s disables possibility to specify another port in WSGI mode"},{"line_number":1685,"context_line":""},{"line_number":1686,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"bff0334d_1369338a","line":1683,"updated":"2017-04-07 00:29:11.000000000","message":"s/\u0027s//","commit_id":"d036d4bf6f5b6a7541d119574c7343bc5eae7e74"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"d6ba8be32f44a2202673a9874795ab79aad0077a","unresolved":false,"context_lines":[{"line_number":1681,"context_line":"    # nodes boot from TFTP and callback to the API server listening on $HOST_IP"},{"line_number":1682,"context_line":"    sudo iptables -I INPUT -d $IRONIC_TFTPSERVER_IP -p udp --dport 69 -j ACCEPT || true"},{"line_number":1683,"context_line":"    # We need to create a rule for default apache\u0027s port,"},{"line_number":1684,"context_line":"    # it\u0027s disables possibility to specify another port in WSGI mode"},{"line_number":1685,"context_line":""},{"line_number":1686,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"},{"line_number":1687,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"bff0334d_b30f27e0","line":1684,"updated":"2017-04-07 00:29:11.000000000","message":"s/\u0027s//\ns/another//\ns/in/for/","commit_id":"d036d4bf6f5b6a7541d119574c7343bc5eae7e74"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"6aac053c8115e2a869b743b0656ae547ecf14676","unresolved":false,"context_lines":[{"line_number":1681,"context_line":"    # nodes boot from TFTP and callback to the API server listening on $HOST_IP"},{"line_number":1682,"context_line":"    sudo iptables -I INPUT -d $IRONIC_TFTPSERVER_IP -p udp --dport 69 -j ACCEPT || true"},{"line_number":1683,"context_line":"    # We need to create a rule for default apache\u0027s port,"},{"line_number":1684,"context_line":"    # it\u0027s disables possibility to specify another port in WSGI mode"},{"line_number":1685,"context_line":""},{"line_number":1686,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"},{"line_number":1687,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"bff0334d_4a9c6769","line":1684,"in_reply_to":"bff0334d_7363d8b2","updated":"2017-04-09 22:12:33.000000000","message":"Thanks, this comments resolves many questions","commit_id":"d036d4bf6f5b6a7541d119574c7343bc5eae7e74"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"7feff1e3866c1d10cc28bbcfab248bfdb938e915","unresolved":false,"context_lines":[{"line_number":1681,"context_line":"    # nodes boot from TFTP and callback to the API server listening on $HOST_IP"},{"line_number":1682,"context_line":"    sudo iptables -I INPUT -d $IRONIC_TFTPSERVER_IP -p udp --dport 69 -j ACCEPT || true"},{"line_number":1683,"context_line":"    # We need to create a rule for default apache\u0027s port,"},{"line_number":1684,"context_line":"    # it\u0027s disables possibility to specify another port in WSGI mode"},{"line_number":1685,"context_line":""},{"line_number":1686,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"},{"line_number":1687,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"bff0334d_7363d8b2","line":1684,"in_reply_to":"bff0334d_b30f27e0","updated":"2017-04-07 06:11:00.000000000","message":"I would rephrase it and say: \"To use named /baremetal endpoint we should open default apache port.\"","commit_id":"d036d4bf6f5b6a7541d119574c7343bc5eae7e74"},{"author":{"_account_id":22042,"name":"Chris Smart","email":"distroguy@gmail.com","username":"csmart"},"change_message_id":"14b52a6777a38aa32daa106ac373dbfe532c00f3","unresolved":false,"context_lines":[{"line_number":1686,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"},{"line_number":1687,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1688,"context_line":"    else"},{"line_number":1689,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport 80 -j ACCEPT || true"},{"line_number":1690,"context_line":"    fi"},{"line_number":1691,"context_line":"    if is_deployed_by_agent; then"},{"line_number":1692,"context_line":"        # agent ramdisk gets instance image from swift"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"dfeb2761_7bd47620","line":1689,"updated":"2017-04-05 12:03:03.000000000","message":"I don\u0027t know what I\u0027m talking about, but it appears to be possible to set IRONIC_SERVICE_PORT above, but this hard-codes it to 80 if we\u0027re using Apache? Is it possible that this can mismatch?","commit_id":"d036d4bf6f5b6a7541d119574c7343bc5eae7e74"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"6aac053c8115e2a869b743b0656ae547ecf14676","unresolved":false,"context_lines":[{"line_number":1686,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"},{"line_number":1687,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1688,"context_line":"    else"},{"line_number":1689,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport 80 -j ACCEPT || true"},{"line_number":1690,"context_line":"    fi"},{"line_number":1691,"context_line":"    if is_deployed_by_agent; then"},{"line_number":1692,"context_line":"        # agent ramdisk gets instance image from swift"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"bff0334d_ca96373f","line":1689,"in_reply_to":"bff0334d_536fbb91","updated":"2017-04-09 22:12:33.000000000","message":"Thank you ever so much :)","commit_id":"d036d4bf6f5b6a7541d119574c7343bc5eae7e74"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"7feff1e3866c1d10cc28bbcfab248bfdb938e915","unresolved":false,"context_lines":[{"line_number":1686,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"},{"line_number":1687,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1688,"context_line":"    else"},{"line_number":1689,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport 80 -j ACCEPT || true"},{"line_number":1690,"context_line":"    fi"},{"line_number":1691,"context_line":"    if is_deployed_by_agent; then"},{"line_number":1692,"context_line":"        # agent ramdisk gets instance image from swift"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"bff0334d_b3684087","line":1689,"in_reply_to":"bff0334d_536fbb91","updated":"2017-04-07 06:11:00.000000000","message":"correct, the whole idea of this patch to use named endpoint, instead of port based. Named endpoints will always use default apache port for now.","commit_id":"d036d4bf6f5b6a7541d119574c7343bc5eae7e74"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"6aac053c8115e2a869b743b0656ae547ecf14676","unresolved":false,"context_lines":[{"line_number":1686,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"},{"line_number":1687,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1688,"context_line":"    else"},{"line_number":1689,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport 80 -j ACCEPT || true"},{"line_number":1690,"context_line":"    fi"},{"line_number":1691,"context_line":"    if is_deployed_by_agent; then"},{"line_number":1692,"context_line":"        # agent ramdisk gets instance image from swift"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"bff0334d_aa9bf363","line":1689,"in_reply_to":"bff0334d_5e87bb62","updated":"2017-04-09 22:12:33.000000000","message":"Thanks Vasyl,\nI appreciate it!","commit_id":"d036d4bf6f5b6a7541d119574c7343bc5eae7e74"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"19cdb46e6a5671e26173eb74bd105cf9ef4fc03a","unresolved":false,"context_lines":[{"line_number":1686,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"},{"line_number":1687,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1688,"context_line":"    else"},{"line_number":1689,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport 80 -j ACCEPT || true"},{"line_number":1690,"context_line":"    fi"},{"line_number":1691,"context_line":"    if is_deployed_by_agent; then"},{"line_number":1692,"context_line":"        # agent ramdisk gets instance image from swift"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"bff0334d_5e87bb62","line":1689,"in_reply_to":"bff0334d_b3684087","updated":"2017-04-07 06:13:26.000000000","message":"just a note: this rule really should be configured by devstack by default, as all services who uses named endpoints requires this 80 port is open.","commit_id":"d036d4bf6f5b6a7541d119574c7343bc5eae7e74"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"6aac053c8115e2a869b743b0656ae547ecf14676","unresolved":false,"context_lines":[{"line_number":1686,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"},{"line_number":1687,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1688,"context_line":"    else"},{"line_number":1689,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport 80 -j ACCEPT || true"},{"line_number":1690,"context_line":"    fi"},{"line_number":1691,"context_line":"    if is_deployed_by_agent; then"},{"line_number":1692,"context_line":"        # agent ramdisk gets instance image from swift"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"bff0334d_2a72434a","line":1689,"in_reply_to":"dfeb2761_7bd47620","updated":"2017-04-09 22:12:33.000000000","message":"I do not know what I can add, because Joanna and Vasyl have fully responded","commit_id":"d036d4bf6f5b6a7541d119574c7343bc5eae7e74"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"d6ba8be32f44a2202673a9874795ab79aad0077a","unresolved":false,"context_lines":[{"line_number":1686,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"},{"line_number":1687,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1688,"context_line":"    else"},{"line_number":1689,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport 80 -j ACCEPT || true"},{"line_number":1690,"context_line":"    fi"},{"line_number":1691,"context_line":"    if is_deployed_by_agent; then"},{"line_number":1692,"context_line":"        # agent ramdisk gets instance image from swift"}],"source_content_type":"application/x-shellscript","patch_set":22,"id":"bff0334d_536fbb91","line":1689,"in_reply_to":"dfeb2761_7bd47620","updated":"2017-04-07 00:29:11.000000000","message":"ironic service port is used in case of wsgi set to False. This means ironic is not attached to main apache instance running on server as alias /baremetal (which is horizon on port :80 for devstack) but creates ironic\u0027s own port is created. \nSo in case of non-wsgi it\u0027s hosted on \u003chost\u003e:6385 (if I remember the port properly). With wsgi its \u003chost\u003e:80/baremetal (short: \u003chost\u003e/baremetal)","commit_id":"d036d4bf6f5b6a7541d119574c7343bc5eae7e74"},{"author":{"_account_id":23883,"name":"Joanna Taryma","email":"joanna.taryma@intel.com","username":"jtaryma"},"change_message_id":"94c025b6889705fbabdeb962ca87af5133e662b5","unresolved":false,"context_lines":[{"line_number":274,"context_line":"if [[ \"$IRONIC_USE_MOD_WSGI\" !\u003d \"True\" ]]; then"},{"line_number":275,"context_line":"    IRONIC_HOSTPORT\u003d${IRONIC_HOSTPORT:-$SERVICE_HOST:$IRONIC_SERVICE_PORT}"},{"line_number":276,"context_line":"else"},{"line_number":277,"context_line":"    IRONIC_HOSTPORT\u003d${IRONIC_HOSTPORT:-$SERVICE_HOST/baremetal}"},{"line_number":278,"context_line":"fi"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"# Enable iPXE"}],"source_content_type":"application/x-shellscript","patch_set":24,"id":"bff0334d_47ce792d","line":277,"updated":"2017-04-10 23:15:49.000000000","message":"Oksana - I am sorry if I mislead you in patch 22, I meant that the way Chris commented on variables confused me. Code looks perfectly fine.","commit_id":"8328edaa3dbd90aa85b56cd3e0e311630035b876"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"09d59c4c051ecc25990819449456ab66945039e1","unresolved":false,"context_lines":[{"line_number":1681,"context_line":"    # nodes boot from TFTP and callback to the API server listening on $HOST_IP"},{"line_number":1682,"context_line":"    sudo iptables -I INPUT -d $IRONIC_TFTPSERVER_IP -p udp --dport 69 -j ACCEPT || true"},{"line_number":1683,"context_line":"    # To use named /baremetal endpoint we should open default apache port"},{"line_number":1684,"context_line":""},{"line_number":1685,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"},{"line_number":1686,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1687,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":24,"id":"bff0334d_4034fcdd","line":1684,"updated":"2017-04-11 21:36:44.000000000","message":"your use of a blank line here is odd. It separates the comment from the code. I suppose it might be considered a nit, except that it doesn\u0027t seem like a good idea.","commit_id":"8328edaa3dbd90aa85b56cd3e0e311630035b876"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"a964bd7ff8184ed44cf38be62dda61289009270b","unresolved":false,"context_lines":[{"line_number":1681,"context_line":"    # nodes boot from TFTP and callback to the API server listening on $HOST_IP"},{"line_number":1682,"context_line":"    sudo iptables -I INPUT -d $IRONIC_TFTPSERVER_IP -p udp --dport 69 -j ACCEPT || true"},{"line_number":1683,"context_line":"    # To use named /baremetal endpoint we should open default apache port"},{"line_number":1684,"context_line":""},{"line_number":1685,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"},{"line_number":1686,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1687,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":24,"id":"bff0334d_6048202c","line":1684,"in_reply_to":"bff0334d_4034fcdd","updated":"2017-04-11 21:38:53.000000000","message":"+1, please remove the line if you have to do another patch set","commit_id":"8328edaa3dbd90aa85b56cd3e0e311630035b876"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"83798d38b72ebd8a3bcda3d53eeb5b6d94833014","unresolved":false,"context_lines":[{"line_number":1681,"context_line":"    # nodes boot from TFTP and callback to the API server listening on $HOST_IP"},{"line_number":1682,"context_line":"    sudo iptables -I INPUT -d $IRONIC_TFTPSERVER_IP -p udp --dport 69 -j ACCEPT || true"},{"line_number":1683,"context_line":"    # To use named /baremetal endpoint we should open default apache port"},{"line_number":1684,"context_line":""},{"line_number":1685,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"},{"line_number":1686,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1687,"context_line":"    else"}],"source_content_type":"application/x-shellscript","patch_set":24,"id":"7ffa3b31_7122b754","line":1684,"in_reply_to":"bff0334d_4034fcdd","updated":"2017-04-18 07:44:21.000000000","message":"Thanks Ruby\nI\u0027ll resolve it","commit_id":"8328edaa3dbd90aa85b56cd3e0e311630035b876"},{"author":{"_account_id":13295,"name":"Mario Villaplana","email":"mario.villaplana@gmail.com","username":"mariojv"},"change_message_id":"a964bd7ff8184ed44cf38be62dda61289009270b","unresolved":false,"context_lines":[{"line_number":1965,"context_line":"    restart_service xinetd"},{"line_number":1966,"context_line":"    sudo iptables -D INPUT -d $HOST_IP -p udp --dport 69 -j ACCEPT || true"},{"line_number":1967,"context_line":"    sudo iptables -D INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1968,"context_line":"    sudo iptables -D INPUT -d $HOST_IP -p tcp --dport 80 -j ACCEPT || true"},{"line_number":1969,"context_line":"    if is_deployed_by_agent; then"},{"line_number":1970,"context_line":"        # agent ramdisk gets instance image from swift"},{"line_number":1971,"context_line":"        sudo iptables -D INPUT -d $HOST_IP -p tcp --dport ${SWIFT_DEFAULT_BIND_PORT:-8080} -j ACCEPT || true"}],"source_content_type":"application/x-shellscript","patch_set":24,"id":"bff0334d_c07c8c73","line":1968,"updated":"2017-04-11 21:38:53.000000000","message":"Shouldn\u0027t this be conditional on IRONIC_USE_MOD_WSGI \u003d\u003d True?","commit_id":"8328edaa3dbd90aa85b56cd3e0e311630035b876"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"83798d38b72ebd8a3bcda3d53eeb5b6d94833014","unresolved":false,"context_lines":[{"line_number":1965,"context_line":"    restart_service xinetd"},{"line_number":1966,"context_line":"    sudo iptables -D INPUT -d $HOST_IP -p udp --dport 69 -j ACCEPT || true"},{"line_number":1967,"context_line":"    sudo iptables -D INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1968,"context_line":"    sudo iptables -D INPUT -d $HOST_IP -p tcp --dport 80 -j ACCEPT || true"},{"line_number":1969,"context_line":"    if is_deployed_by_agent; then"},{"line_number":1970,"context_line":"        # agent ramdisk gets instance image from swift"},{"line_number":1971,"context_line":"        sudo iptables -D INPUT -d $HOST_IP -p tcp --dport ${SWIFT_DEFAULT_BIND_PORT:-8080} -j ACCEPT || true"}],"source_content_type":"application/x-shellscript","patch_set":24,"id":"7ffa3b31_71951740","line":1968,"in_reply_to":"bff0334d_c07c8c73","updated":"2017-04-18 07:44:21.000000000","message":"Thanks Mario\nBut I suppose it not good idea becouse in cleaning mode we wouldn\u0027t have variable from local.conf","commit_id":"8328edaa3dbd90aa85b56cd3e0e311630035b876"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"51b9550eb498fa8fe1e85a51c23a7ffe92c0d4fb","unresolved":false,"context_lines":[{"line_number":1965,"context_line":"    restart_service xinetd"},{"line_number":1966,"context_line":"    sudo iptables -D INPUT -d $HOST_IP -p udp --dport 69 -j ACCEPT || true"},{"line_number":1967,"context_line":"    sudo iptables -D INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1968,"context_line":"    sudo iptables -D INPUT -d $HOST_IP -p tcp --dport 80 -j ACCEPT || true"},{"line_number":1969,"context_line":"    if is_deployed_by_agent; then"},{"line_number":1970,"context_line":"        # agent ramdisk gets instance image from swift"},{"line_number":1971,"context_line":"        sudo iptables -D INPUT -d $HOST_IP -p tcp --dport ${SWIFT_DEFAULT_BIND_PORT:-8080} -j ACCEPT || true"}],"source_content_type":"application/x-shellscript","patch_set":24,"id":"7ffa3b31_b6ca7517","line":1968,"in_reply_to":"bff0334d_c07c8c73","updated":"2017-04-18 07:07:50.000000000","message":"this is cleanup function we should rely here on local.conf vars as less as possible, since user may update local.conf before running unstack.sh.","commit_id":"8328edaa3dbd90aa85b56cd3e0e311630035b876"}]}