)]}'
{"devstack/lib/ironic":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a47e9d58ef77f597ce9930b1b71d73901d16c0f4","unresolved":false,"context_lines":[{"line_number":1520,"context_line":"                node_options+\u003d\" -i snmp_outlet\u003d$pdu_outlet\""},{"line_number":1521,"context_line":"            elif is_deployed_by_redfish; then"},{"line_number":1522,"context_line":"                # TODO(lucasagomes): Parametize the port number"},{"line_number":1523,"context_line":"                node_options+\u003d\"-i redfish_system_id\u003d$node_name\""},{"line_number":1524,"context_line":"            fi"},{"line_number":1525,"context_line":"            # Local-link-connection options"},{"line_number":1526,"context_line":"            if [[ \"${IRONIC_USE_LINK_LOCAL}\" \u003d\u003d \"True\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3a1ff146_2468a7ba","line":1523,"updated":"2017-03-14 17:25:40.000000000","message":"This TODO should be removed and it\u0027s missing a space before the \"-id\"","commit_id":"dbfd06d9c3a7b422154af6ad9c475d5540552158"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6f1385fcdc3d0831411de54cc7913827902b4b2e","unresolved":false,"context_lines":[{"line_number":1045,"context_line":"            die $LINENO \"Please make sure that the redfish hardware type, power \\"},{"line_number":1046,"context_line":"                        and management interfaces are enabled. Take a look at the \\"},{"line_number":1047,"context_line":"                        IRONIC_ENABLED_HARDWARE_TYPES, IRONIC_ENABLED_POWER_INTERFACES \\"},{"line_number":1048,"context_line":"                        and IRONIC_ENABLED_MANAGEMENT_INTERFACES for DevStack.\""},{"line_number":1049,"context_line":"        fi"},{"line_number":1050,"context_line":"    fi"},{"line_number":1051,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3a1ff146_f99fc600","line":1048,"range":{"start_line":1048,"start_character":64,"end_line":1048,"end_character":65},"updated":"2017-03-16 11:02:31.000000000","message":"configuration options","commit_id":"e1573ba35eb8031ef11df2fa8f500bb0ca3811e5"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"819e8f5a001a22c495a2e20640ebb4bb52b0ae4b","unresolved":false,"context_lines":[{"line_number":663,"context_line":"# (flask and libvirt-python) I don\u0027t wanna mix up these dependencies because"},{"line_number":664,"context_line":"# the less dependencies the library has the better (currently it\u0027s only"},{"line_number":665,"context_line":"# requests and six). So ideas are welcome here, so far the only thing I"},{"line_number":666,"context_line":"# can think of is to split the simulator on it\u0027s own repository."},{"line_number":667,"context_line":"function setup_redfish_simulator {"},{"line_number":668,"context_line":"    local sushy_dir\u003d${GITDIR[\"sushy\"]}"},{"line_number":669,"context_line":"    if [ ! -d $sushy_dir ]; then"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ffe62b97_4d8ed3d0","line":666,"updated":"2017-03-27 15:53:08.000000000","message":"Could you move the simulator into virtualbmc?","commit_id":"0eb66cb0219243b4fe16c7456abd8a1365906a65"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fd0c105bd618e16d6709e7cdfe74c41c196d369f","unresolved":false,"context_lines":[{"line_number":663,"context_line":"# (flask and libvirt-python) I don\u0027t wanna mix up these dependencies because"},{"line_number":664,"context_line":"# the less dependencies the library has the better (currently it\u0027s only"},{"line_number":665,"context_line":"# requests and six). So ideas are welcome here, so far the only thing I"},{"line_number":666,"context_line":"# can think of is to split the simulator on it\u0027s own repository."},{"line_number":667,"context_line":"function setup_redfish_simulator {"},{"line_number":668,"context_line":"    local sushy_dir\u003d${GITDIR[\"sushy\"]}"},{"line_number":669,"context_line":"    if [ ! -d $sushy_dir ]; then"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ffe62b97_d8e743e4","line":666,"in_reply_to":"ffe62b97_4d8ed3d0","updated":"2017-03-27 16:02:54.000000000","message":"So, we could but I don\u0027t know if we should. Because I think that the virtualbmc project won\u0027t exist for longer. The latest version of QEMU already supports emulating an IPMI device [0] so it\u0027s just a matter of time to have it included in the distros (specially the ubuntu LTS that we use in gate, may take a while ) \n\n[0] I haven\u0027t tested yet","commit_id":"0eb66cb0219243b4fe16c7456abd8a1365906a65"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"819e8f5a001a22c495a2e20640ebb4bb52b0ae4b","unresolved":false,"context_lines":[{"line_number":671,"context_line":"    fi"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"    cd $sushy_dir"},{"line_number":674,"context_line":"    sudo pip install -r tools/mockup_server_libvirt/requirements.txt"},{"line_number":675,"context_line":"    sudo tox -elibvirt-simulator -- --port $IRONIC_REDFISH_SIMULATOR_PORT 1\u003e /dev/null \u0026"},{"line_number":676,"context_line":"    cd -"},{"line_number":677,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ffe62b97_0d50cb31","line":674,"updated":"2017-03-27 15:53:08.000000000","message":"I think it\u0027s preferred to use the pip_install helper function.","commit_id":"0eb66cb0219243b4fe16c7456abd8a1365906a65"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fd0c105bd618e16d6709e7cdfe74c41c196d369f","unresolved":false,"context_lines":[{"line_number":671,"context_line":"    fi"},{"line_number":672,"context_line":""},{"line_number":673,"context_line":"    cd $sushy_dir"},{"line_number":674,"context_line":"    sudo pip install -r tools/mockup_server_libvirt/requirements.txt"},{"line_number":675,"context_line":"    sudo tox -elibvirt-simulator -- --port $IRONIC_REDFISH_SIMULATOR_PORT 1\u003e /dev/null \u0026"},{"line_number":676,"context_line":"    cd -"},{"line_number":677,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ffe62b97_d8286335","line":674,"in_reply_to":"ffe62b97_0d50cb31","updated":"2017-03-27 16:02:54.000000000","message":"Yeah, we don\u0027t have a release of sushy yet... that\u0027s why I have to do it for now.","commit_id":"0eb66cb0219243b4fe16c7456abd8a1365906a65"},{"author":{"_account_id":18893,"name":"Miles Gould","email":"mgould@redhat.com","username":"pozorvlak"},"change_message_id":"819e8f5a001a22c495a2e20640ebb4bb52b0ae4b","unresolved":false,"context_lines":[{"line_number":672,"context_line":""},{"line_number":673,"context_line":"    cd $sushy_dir"},{"line_number":674,"context_line":"    sudo pip install -r tools/mockup_server_libvirt/requirements.txt"},{"line_number":675,"context_line":"    sudo tox -elibvirt-simulator -- --port $IRONIC_REDFISH_SIMULATOR_PORT 1\u003e /dev/null \u0026"},{"line_number":676,"context_line":"    cd -"},{"line_number":677,"context_line":"}"},{"line_number":678,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ffe62b97_ad255fc4","line":675,"updated":"2017-03-27 15:53:08.000000000","message":"If you\u0027re running the simulator inside a tox virtualenv, shouldn\u0027t you install its requirements in that virtualenv rather than globally?","commit_id":"0eb66cb0219243b4fe16c7456abd8a1365906a65"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"fd0c105bd618e16d6709e7cdfe74c41c196d369f","unresolved":false,"context_lines":[{"line_number":672,"context_line":""},{"line_number":673,"context_line":"    cd $sushy_dir"},{"line_number":674,"context_line":"    sudo pip install -r tools/mockup_server_libvirt/requirements.txt"},{"line_number":675,"context_line":"    sudo tox -elibvirt-simulator -- --port $IRONIC_REDFISH_SIMULATOR_PORT 1\u003e /dev/null \u0026"},{"line_number":676,"context_line":"    cd -"},{"line_number":677,"context_line":"}"},{"line_number":678,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"ffe62b97_b8e0fffb","line":675,"in_reply_to":"ffe62b97_ad255fc4","updated":"2017-03-27 16:02:54.000000000","message":"True that, it would yeah","commit_id":"0eb66cb0219243b4fe16c7456abd8a1365906a65"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"4b42ec5d03cead5880671d2dd4b1750307d55890","unresolved":false,"context_lines":[{"line_number":686,"context_line":"    fi"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"    cd $sushy_dir"},{"line_number":689,"context_line":"    sudo pip install -r tools/mockup_server_libvirt/requirements.txt"},{"line_number":690,"context_line":"    sudo tox -elibvirt-simulator -- --port $IRONIC_REDFISH_SIMULATOR_PORT 1\u003e /dev/null \u0026"},{"line_number":691,"context_line":"    cd -"},{"line_number":692,"context_line":"}"},{"line_number":693,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"bff0334d_5790954e","line":690,"range":{"start_line":689,"start_character":4,"end_line":690,"end_character":88},"updated":"2017-04-08 11:53:42.000000000","message":"please change it to sudo -H ...","commit_id":"705edca48ab8675196cea93497e9a916e44556a9"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"dd62273d2a06d7fe4c50e517a8b2dd83dfe26b93","unresolved":false,"context_lines":[{"line_number":304,"context_line":"IRONIC_VPDU_SNMPDRIVER\u003d${IRONIC_VPDU_SNMPDRIVER:-apc_rackpdu}"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"# Redfish configs"},{"line_number":307,"context_line":"IRONIC_REDFISH_EMULATOR_PORT\u003d${IRONIC_REDFISH_EMULATOR_PORT:-8000}"},{"line_number":308,"context_line":"IRONIC_REDFISH_EMULATOR_PID_FILE\u003d${IRONIC_REDFISH_EMULATOR_PID_FILE:-/var/run/sushy-emulator.pid}"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"# To explicitly enable configuration of Glance with Swift"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"7ffa3b31_41376900","line":307,"updated":"2017-04-21 15:14:59.000000000","message":"I suspect it\u0027s a heavily overused port.. maybe pick something more random?","commit_id":"f7b66c5fe25b89ca2f6ef07ca81b01dd63dea164"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1d1f6dbe66fd2fd9597b383df171f636b76176b1","unresolved":false,"context_lines":[{"line_number":304,"context_line":"IRONIC_VPDU_SNMPDRIVER\u003d${IRONIC_VPDU_SNMPDRIVER:-apc_rackpdu}"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"# Redfish configs"},{"line_number":307,"context_line":"IRONIC_REDFISH_EMULATOR_PORT\u003d${IRONIC_REDFISH_EMULATOR_PORT:-8000}"},{"line_number":308,"context_line":"IRONIC_REDFISH_EMULATOR_PID_FILE\u003d${IRONIC_REDFISH_EMULATOR_PID_FILE:-/var/run/sushy-emulator.pid}"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"# To explicitly enable configuration of Glance with Swift"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"7ffa3b31_7728e795","line":307,"in_reply_to":"7ffa3b31_41376900","updated":"2017-04-21 16:05:25.000000000","message":"True that, ++","commit_id":"f7b66c5fe25b89ca2f6ef07ca81b01dd63dea164"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"dd62273d2a06d7fe4c50e517a8b2dd83dfe26b93","unresolved":false,"context_lines":[{"line_number":677,"context_line":"    stop_redfish_emulator"},{"line_number":678,"context_line":"    # gunicorn is used to daemonize a flask application, in this case"},{"line_number":679,"context_line":"    # the sushy emulator"},{"line_number":680,"context_line":"    pip_install \"gunicorn\""},{"line_number":681,"context_line":"    pip_install \"sushy-tools\""},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"    sudo gunicorn sushy_tools.emulator.main:app -b \u0027127.0.0.1:$IRONIC_REDFISH_EMULATOR_PORT\u0027 --pid $IRONIC_REDFISH_EMULATOR_PID_FILE --daemon"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"7ffa3b31_213a1de6","line":680,"updated":"2017-04-21 15:14:59.000000000","message":"can\u0027t we install gunicorn from OS packages rather than pip? anyway, this should be pip_install_gr","commit_id":"f7b66c5fe25b89ca2f6ef07ca81b01dd63dea164"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1d1f6dbe66fd2fd9597b383df171f636b76176b1","unresolved":false,"context_lines":[{"line_number":677,"context_line":"    stop_redfish_emulator"},{"line_number":678,"context_line":"    # gunicorn is used to daemonize a flask application, in this case"},{"line_number":679,"context_line":"    # the sushy emulator"},{"line_number":680,"context_line":"    pip_install \"gunicorn\""},{"line_number":681,"context_line":"    pip_install \"sushy-tools\""},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"    sudo gunicorn sushy_tools.emulator.main:app -b \u0027127.0.0.1:$IRONIC_REDFISH_EMULATOR_PORT\u0027 --pid $IRONIC_REDFISH_EMULATOR_PID_FILE --daemon"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"7ffa3b31_f20ac51d","line":680,"in_reply_to":"7ffa3b31_213a1de6","updated":"2017-04-21 16:05:25.000000000","message":"We can yeah, let\u0027s do it","commit_id":"f7b66c5fe25b89ca2f6ef07ca81b01dd63dea164"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"dd62273d2a06d7fe4c50e517a8b2dd83dfe26b93","unresolved":false,"context_lines":[{"line_number":678,"context_line":"    # gunicorn is used to daemonize a flask application, in this case"},{"line_number":679,"context_line":"    # the sushy emulator"},{"line_number":680,"context_line":"    pip_install \"gunicorn\""},{"line_number":681,"context_line":"    pip_install \"sushy-tools\""},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"    sudo gunicorn sushy_tools.emulator.main:app -b \u0027127.0.0.1:$IRONIC_REDFISH_EMULATOR_PORT\u0027 --pid $IRONIC_REDFISH_EMULATOR_PID_FILE --daemon"},{"line_number":684,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"7ffa3b31_013de1db","line":681,"updated":"2017-04-21 15:14:59.000000000","message":"this should go to setup_redfish for clarity","commit_id":"f7b66c5fe25b89ca2f6ef07ca81b01dd63dea164"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1d1f6dbe66fd2fd9597b383df171f636b76176b1","unresolved":false,"context_lines":[{"line_number":678,"context_line":"    # gunicorn is used to daemonize a flask application, in this case"},{"line_number":679,"context_line":"    # the sushy emulator"},{"line_number":680,"context_line":"    pip_install \"gunicorn\""},{"line_number":681,"context_line":"    pip_install \"sushy-tools\""},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"    sudo gunicorn sushy_tools.emulator.main:app -b \u0027127.0.0.1:$IRONIC_REDFISH_EMULATOR_PORT\u0027 --pid $IRONIC_REDFISH_EMULATOR_PID_FILE --daemon"},{"line_number":684,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"7ffa3b31_1221b19f","line":681,"in_reply_to":"7ffa3b31_013de1db","updated":"2017-04-21 16:05:25.000000000","message":"Done","commit_id":"f7b66c5fe25b89ca2f6ef07ca81b01dd63dea164"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"dd62273d2a06d7fe4c50e517a8b2dd83dfe26b93","unresolved":false,"context_lines":[{"line_number":680,"context_line":"    pip_install \"gunicorn\""},{"line_number":681,"context_line":"    pip_install \"sushy-tools\""},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"    sudo gunicorn sushy_tools.emulator.main:app -b \u0027127.0.0.1:$IRONIC_REDFISH_EMULATOR_PORT\u0027 --pid $IRONIC_REDFISH_EMULATOR_PID_FILE --daemon"},{"line_number":684,"context_line":"}"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"function stop_redfish_emulator {"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"7ffa3b31_e12795c9","line":683,"updated":"2017-04-21 15:14:59.000000000","message":"we already have apache + mod_wsgi in devstack, let\u0027s use it maybe?","commit_id":"f7b66c5fe25b89ca2f6ef07ca81b01dd63dea164"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1d1f6dbe66fd2fd9597b383df171f636b76176b1","unresolved":false,"context_lines":[{"line_number":680,"context_line":"    pip_install \"gunicorn\""},{"line_number":681,"context_line":"    pip_install \"sushy-tools\""},{"line_number":682,"context_line":""},{"line_number":683,"context_line":"    sudo gunicorn sushy_tools.emulator.main:app -b \u0027127.0.0.1:$IRONIC_REDFISH_EMULATOR_PORT\u0027 --pid $IRONIC_REDFISH_EMULATOR_PID_FILE --daemon"},{"line_number":684,"context_line":"}"},{"line_number":685,"context_line":""},{"line_number":686,"context_line":"function stop_redfish_emulator {"}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"7ffa3b31_52797991","line":683,"in_reply_to":"7ffa3b31_e12795c9","updated":"2017-04-21 16:05:25.000000000","message":"yeah, that\u0027s possible as well ++","commit_id":"f7b66c5fe25b89ca2f6ef07ca81b01dd63dea164"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"dd62273d2a06d7fe4c50e517a8b2dd83dfe26b93","unresolved":false,"context_lines":[{"line_number":1093,"context_line":"                \"a look at the IRONIC_ENABLED_HARDWARE_TYPES,\" \\"},{"line_number":1094,"context_line":"                \"IRONIC_ENABLED_POWER_INTERFACES and\" \\"},{"line_number":1095,"context_line":"                \"IRONIC_ENABLED_MANAGEMENT_INTERFACES configuration options\" \\"},{"line_number":1096,"context_line":"                \"for DevStack\""},{"line_number":1097,"context_line":"        fi"},{"line_number":1098,"context_line":"    fi"},{"line_number":1099,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"7ffa3b31_c12259b9","line":1096,"updated":"2017-04-21 15:14:59.000000000","message":"let\u0027s maybe do it automatically if the hardware type is enabled?","commit_id":"f7b66c5fe25b89ca2f6ef07ca81b01dd63dea164"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1d1f6dbe66fd2fd9597b383df171f636b76176b1","unresolved":false,"context_lines":[{"line_number":1093,"context_line":"                \"a look at the IRONIC_ENABLED_HARDWARE_TYPES,\" \\"},{"line_number":1094,"context_line":"                \"IRONIC_ENABLED_POWER_INTERFACES and\" \\"},{"line_number":1095,"context_line":"                \"IRONIC_ENABLED_MANAGEMENT_INTERFACES configuration options\" \\"},{"line_number":1096,"context_line":"                \"for DevStack\""},{"line_number":1097,"context_line":"        fi"},{"line_number":1098,"context_line":"    fi"},{"line_number":1099,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":11,"id":"7ffa3b31_32a14df9","line":1096,"in_reply_to":"7ffa3b31_c12259b9","updated":"2017-04-21 16:05:25.000000000","message":"++","commit_id":"f7b66c5fe25b89ca2f6ef07ca81b01dd63dea164"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ab5464596ea0cbb7b34d51cc1976bcd9aca02d7f","unresolved":false,"context_lines":[{"line_number":1098,"context_line":"    iniset $IRONIC_CONF_FILE DEFAULT enabled_hardware_types $IRONIC_ENABLED_HARDWARE_TYPES"},{"line_number":1099,"context_line":""},{"line_number":1100,"context_line":"    if is_deployed_by_redfish; then"},{"line_number":1101,"context_line":"        if [[ \"$IRONIC_ENABLED_HARDWARE_TYPES\" !\u003d *\"redfish\"* ]]; then"},{"line_number":1102,"context_line":"            die $LINENO \"Please make sure that the redfish hardware\" \\"},{"line_number":1103,"context_line":"                \"type, is enabled. Take a look at the \" \\"},{"line_number":1104,"context_line":"                \"IRONIC_ENABLED_HARDWARE_TYPES configuration option\" \\"},{"line_number":1105,"context_line":"                \"for DevStack\""},{"line_number":1106,"context_line":"        else"},{"line_number":1107,"context_line":"            # TODO(lucasagomes): We need to make it easier to configure"},{"line_number":1108,"context_line":"            # specific driver interfaces in DevStack"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"5ff73747_25e2e002","line":1105,"range":{"start_line":1101,"start_character":1,"end_line":1105,"end_character":30},"updated":"2017-05-02 23:40:23.000000000","message":"I believe it should be part of is_deployed_by_redfish() so that it doesnt fail after all the setup is done.","commit_id":"c5682dcf5fe5f73ae0af968c29649a24d534c39f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ea128a7ed1c50f09a189e741da412cdfebb94d2c","unresolved":false,"context_lines":[{"line_number":1098,"context_line":"    iniset $IRONIC_CONF_FILE DEFAULT enabled_hardware_types $IRONIC_ENABLED_HARDWARE_TYPES"},{"line_number":1099,"context_line":""},{"line_number":1100,"context_line":"    if is_deployed_by_redfish; then"},{"line_number":1101,"context_line":"        if [[ \"$IRONIC_ENABLED_HARDWARE_TYPES\" !\u003d *\"redfish\"* ]]; then"},{"line_number":1102,"context_line":"            die $LINENO \"Please make sure that the redfish hardware\" \\"},{"line_number":1103,"context_line":"                \"type, is enabled. Take a look at the \" \\"},{"line_number":1104,"context_line":"                \"IRONIC_ENABLED_HARDWARE_TYPES configuration option\" \\"},{"line_number":1105,"context_line":"                \"for DevStack\""},{"line_number":1106,"context_line":"        else"},{"line_number":1107,"context_line":"            # TODO(lucasagomes): We need to make it easier to configure"},{"line_number":1108,"context_line":"            # specific driver interfaces in DevStack"}],"source_content_type":"application/x-shellscript","patch_set":13,"id":"5ff73747_c1f686fa","line":1105,"range":{"start_line":1101,"start_character":1,"end_line":1105,"end_character":30},"in_reply_to":"5ff73747_25e2e002","updated":"2017-05-03 08:34:19.000000000","message":"Hmm I agree about having this being checked earlier, but not in is_deployed_by_redfish() cause that\u0027s called in many places.","commit_id":"c5682dcf5fe5f73ae0af968c29649a24d534c39f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"0dd16c5d0a616d0a4f80b783239c36be8f1ca84e","unresolved":false,"context_lines":[{"line_number":570,"context_line":"# the redfish driver"},{"line_number":571,"context_line":"if is_deployed_by_redfish \u0026\u0026 [[ \"$IRONIC_ENABLED_HARDWARE_TYPES\" !\u003d *\"redfish\"* ]]; then"},{"line_number":572,"context_line":"    die $LINENO \"Please make sure that the redfish hardware\" \\"},{"line_number":573,"context_line":"        \"type, is enabled. Take a look at the \" \\"},{"line_number":574,"context_line":"        \"IRONIC_ENABLED_HARDWARE_TYPES configuration option\" \\"},{"line_number":575,"context_line":"        \"for DevStack\""},{"line_number":576,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"5ff73747_0750fe31","line":573,"range":{"start_line":573,"start_character":13,"end_line":573,"end_character":14},"updated":"2017-05-03 09:56:42.000000000","message":"this comma makes no sense here... I will remove if I happen to submit another patch-set","commit_id":"9697ae6b18b96fceb89bd337251e9a783f4e9808"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"ca0ca7d5737a70ef85149f761ffee9fe2f32b0a7","unresolved":false,"context_lines":[{"line_number":570,"context_line":"# the redfish driver"},{"line_number":571,"context_line":"if is_deployed_by_redfish \u0026\u0026 [[ \"$IRONIC_ENABLED_HARDWARE_TYPES\" !\u003d *\"redfish\"* ]]; then"},{"line_number":572,"context_line":"    die $LINENO \"Please make sure that the redfish hardware\" \\"},{"line_number":573,"context_line":"        \"type, is enabled. Take a look at the \" \\"},{"line_number":574,"context_line":"        \"IRONIC_ENABLED_HARDWARE_TYPES configuration option\" \\"},{"line_number":575,"context_line":"        \"for DevStack\""},{"line_number":576,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"5ff73747_35832459","line":573,"range":{"start_line":573,"start_character":13,"end_line":573,"end_character":14},"in_reply_to":"5ff73747_0750fe31","updated":"2017-05-03 10:42:01.000000000","message":"++","commit_id":"9697ae6b18b96fceb89bd337251e9a783f4e9808"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e8fff2359223659a3657fbc120562381de7fe716","unresolved":false,"context_lines":[{"line_number":690,"context_line":"    if is_ubuntu; then"},{"line_number":691,"context_line":"        install_package gunicorn"},{"line_number":692,"context_line":"    else"},{"line_number":693,"context_line":"        pip_install \"gunicorn\""},{"line_number":694,"context_line":"    fi"},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"    sudo gunicorn sushy_tools.emulator.main:app --bind \"${HOST_IP}:${IRONIC_REDFISH_EMULATOR_PORT}\" \\"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"5ff73747_167dcee6","line":693,"updated":"2017-05-03 12:24:50.000000000","message":"nit: pip_install_gr","commit_id":"9697ae6b18b96fceb89bd337251e9a783f4e9808"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6e82e37b452e6f93e3628ecc221fc2c636b2e300","unresolved":false,"context_lines":[{"line_number":690,"context_line":"    if is_ubuntu; then"},{"line_number":691,"context_line":"        install_package gunicorn"},{"line_number":692,"context_line":"    else"},{"line_number":693,"context_line":"        pip_install \"gunicorn\""},{"line_number":694,"context_line":"    fi"},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"    sudo gunicorn sushy_tools.emulator.main:app --bind \"${HOST_IP}:${IRONIC_REDFISH_EMULATOR_PORT}\" \\"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"5ff73747_6dd8bc7e","line":693,"in_reply_to":"5ff73747_167dcee6","updated":"2017-05-03 12:53:15.000000000","message":"++","commit_id":"9697ae6b18b96fceb89bd337251e9a783f4e9808"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e8fff2359223659a3657fbc120562381de7fe716","unresolved":false,"context_lines":[{"line_number":709,"context_line":"        setup_dev_lib \"sushy\""},{"line_number":710,"context_line":"    else"},{"line_number":711,"context_line":"        # TODO(lucasagomes): use pip_install_gr once sushy is added to"},{"line_number":712,"context_line":"        # the global requirements"},{"line_number":713,"context_line":"        pip_install \"sushy\""},{"line_number":714,"context_line":"    fi"},{"line_number":715,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"5ff73747_f68142c5","line":712,"updated":"2017-05-03 12:24:50.000000000","message":"I don\u0027t think it ever will: it\u0027s a driver dependency after all.. but pysnmp is there, hmmm. so yeah, maybe it should be there.","commit_id":"9697ae6b18b96fceb89bd337251e9a783f4e9808"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"00eda1f256cbb003a5c156379c0f844ee0eaa52b","unresolved":false,"context_lines":[{"line_number":709,"context_line":"        setup_dev_lib \"sushy\""},{"line_number":710,"context_line":"    else"},{"line_number":711,"context_line":"        # TODO(lucasagomes): use pip_install_gr once sushy is added to"},{"line_number":712,"context_line":"        # the global requirements"},{"line_number":713,"context_line":"        pip_install \"sushy\""},{"line_number":714,"context_line":"    fi"},{"line_number":715,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"3f044301_4baab185","line":712,"in_reply_to":"5ff73747_6df43cd0","updated":"2017-05-03 22:24:01.000000000","message":"If we are gate testing with devstack, it absolutely makes sense to track gr and upper constraints accordingly because of stable branches. I\u0027m +1 to getting it in gr, especially since it crosses vendors.","commit_id":"9697ae6b18b96fceb89bd337251e9a783f4e9808"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6e82e37b452e6f93e3628ecc221fc2c636b2e300","unresolved":false,"context_lines":[{"line_number":709,"context_line":"        setup_dev_lib \"sushy\""},{"line_number":710,"context_line":"    else"},{"line_number":711,"context_line":"        # TODO(lucasagomes): use pip_install_gr once sushy is added to"},{"line_number":712,"context_line":"        # the global requirements"},{"line_number":713,"context_line":"        pip_install \"sushy\""},{"line_number":714,"context_line":"    fi"},{"line_number":715,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"5ff73747_6df43cd0","line":712,"in_reply_to":"5ff73747_f68142c5","updated":"2017-05-03 12:53:15.000000000","message":"Yeah, I don\u0027t know... We recently added virtualbmc to g-r because of a issue with the stable branches right ? So we may want to do the same with sushy to avoid similar problems.\n\nNot sure, I\u0027m fine removing this TODO as well.","commit_id":"9697ae6b18b96fceb89bd337251e9a783f4e9808"}]}
