)]}'
{"ironic/drivers/modules/ilo/boot.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8e3afed6748475dd4cd0bfa670e47a778f45dda5","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    \"\"\""},{"line_number":245,"context_line":"    info \u003d {}"},{"line_number":246,"context_line":"    info.update(parse_driver_info(node))"},{"line_number":247,"context_line":"    info.update(deploy_utils.get_image_instance_info(node))"},{"line_number":248,"context_line":"    return info"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_d3e2eb2f","line":247,"range":{"start_line":247,"start_character":4,"end_line":247,"end_character":59},"updated":"2017-03-24 06:27:38.000000000","message":"Any reason for changing order of these methods?","commit_id":"4e2b9c0249449d0ca6a968c55edb849a6bc93e2f"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"a1ec558ee79bd8bd74ee2fbb2331f1ba411cee0c","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    \"\"\""},{"line_number":245,"context_line":"    info \u003d {}"},{"line_number":246,"context_line":"    info.update(parse_driver_info(node))"},{"line_number":247,"context_line":"    info.update(deploy_utils.get_image_instance_info(node))"},{"line_number":248,"context_line":"    return info"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_f2839403","line":247,"range":{"start_line":247,"start_character":4,"end_line":247,"end_character":59},"in_reply_to":"ffe62b97_d3e2eb2f","updated":"2017-03-24 14:17:35.000000000","message":"Yes. Because we want the boot interface validation before the deploy interface. However IMHO, this validation doesn\u0027t make sense at all here, as the same thing is already validated as part of the boot interface, and we get to here only when the validation succeeds. But in any case validating the boot interface related stuff before deploy always makes sense. What do you think?","commit_id":"4e2b9c0249449d0ca6a968c55edb849a6bc93e2f"}],"ironic/drivers/modules/ilo/deploy.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8e3afed6748475dd4cd0bfa670e47a778f45dda5","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            in instance_info for non-Glance image."},{"line_number":215,"context_line":"        \"\"\""},{"line_number":216,"context_line":"        super(IloVirtualMediaIscsiDeploy, self).validate(task)"},{"line_number":217,"context_line":"        _validate(task)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    @METRICS.timer(\u0027IloVirtualMediaIscsiDeploy.prepare\u0027)"},{"line_number":220,"context_line":"    def prepare(self, task):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_f39def66","line":217,"range":{"start_line":217,"start_character":8,"end_line":217,"end_character":23},"updated":"2017-03-24 06:27:38.000000000","message":"Any reason to change order of method calls?","commit_id":"4e2b9c0249449d0ca6a968c55edb849a6bc93e2f"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"a1ec558ee79bd8bd74ee2fbb2331f1ba411cee0c","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            in instance_info for non-Glance image."},{"line_number":215,"context_line":"        \"\"\""},{"line_number":216,"context_line":"        super(IloVirtualMediaIscsiDeploy, self).validate(task)"},{"line_number":217,"context_line":"        _validate(task)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    @METRICS.timer(\u0027IloVirtualMediaIscsiDeploy.prepare\u0027)"},{"line_number":220,"context_line":"    def prepare(self, task):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_d239b041","line":217,"range":{"start_line":217,"start_character":8,"end_line":217,"end_character":23},"in_reply_to":"ffe62b97_f39def66","updated":"2017-03-24 14:17:35.000000000","message":"The super class handles the boot interface validation here before deploy interface which is what we want to call the super class method. Say for instance, if \"ilo_deploy_iso\" and \"instance_info\" both are missing, the deploy should fail saying \"Missing ilo_deploy_iso\" since thats the first prerequisite.","commit_id":"4e2b9c0249449d0ca6a968c55edb849a6bc93e2f"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"8e3afed6748475dd4cd0bfa670e47a778f45dda5","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        \"\"\""},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        super(IloVirtualMediaAgentDeploy, self).validate(task)"},{"line_number":254,"context_line":"        _validate(task)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    @METRICS.timer(\u0027IloVirtualMediaAgentDeploy.tear_down\u0027)"},{"line_number":257,"context_line":"    @task_manager.require_exclusive_lock"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_104f26be","line":254,"range":{"start_line":254,"start_character":8,"end_line":254,"end_character":23},"updated":"2017-03-24 06:27:38.000000000","message":"Any reason to change the order of method calls?","commit_id":"4e2b9c0249449d0ca6a968c55edb849a6bc93e2f"},{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"a1ec558ee79bd8bd74ee2fbb2331f1ba411cee0c","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        \"\"\""},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        super(IloVirtualMediaAgentDeploy, self).validate(task)"},{"line_number":254,"context_line":"        _validate(task)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    @METRICS.timer(\u0027IloVirtualMediaAgentDeploy.tear_down\u0027)"},{"line_number":257,"context_line":"    @task_manager.require_exclusive_lock"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_5245a0b2","line":254,"range":{"start_line":254,"start_character":8,"end_line":254,"end_character":23},"in_reply_to":"ffe62b97_104f26be","updated":"2017-03-24 14:17:35.000000000","message":"ditto.","commit_id":"4e2b9c0249449d0ca6a968c55edb849a6bc93e2f"}]}