)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"dd91e6f69e33e633eda90b5bac407008bc88af18","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Copy and append to static lists"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"core_interfaces and standard_interfaces are both static members of BaseDriver"},{"line_number":10,"context_line":"we need to take a copy of them before appending to them."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic6edc5e49a25849c7871dbc9e6e1d5a5eb229e57"},{"line_number":13,"context_line":"Closes-Bug: #1672457"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ffe62b97_99d0e8f9","line":10,"range":{"start_line":10,"start_character":8,"end_line":10,"end_character":22},"updated":"2017-03-24 16:46:35.000000000","message":"nit: in this patchset copy does not used directly","commit_id":"9f28bd6112f8f9cdbdc13bfb1df87f6c4e302e31"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"f7ee075f8d63d313fb3d378ed320568f079c7a49","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Copy and append to static lists"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"core_interfaces and standard_interfaces are both static members of BaseDriver"},{"line_number":10,"context_line":"we need to take a copy of them before appending to them."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic6edc5e49a25849c7871dbc9e6e1d5a5eb229e57"},{"line_number":13,"context_line":"Closes-Bug: #1672457"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ffe62b97_f9501435","line":10,"range":{"start_line":10,"start_character":8,"end_line":10,"end_character":22},"in_reply_to":"ffe62b97_99d0e8f9","updated":"2017-03-24 16:49:25.000000000","message":"will update if doing another revision.","commit_id":"9f28bd6112f8f9cdbdc13bfb1df87f6c4e302e31"}],"ironic/drivers/base.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"606937bbb7b8ba7b2fc06ec4e1314f1129b323cc","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    class, as well as appended to core_interfaces or standard_interfaces here."},{"line_number":165,"context_line":"    \"\"\""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    # we need to take a copy of these as they are static and appending to them"},{"line_number":168,"context_line":"    # changes them in all classes that inherit from BaseDriver"},{"line_number":169,"context_line":"    core_interfaces \u003d copy.copy(BaseDriver.core_interfaces)"},{"line_number":170,"context_line":"    standard_interfaces \u003d copy.copy(BaseDriver.standard_interfaces)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def __init__(self):"},{"line_number":173,"context_line":"        self.network \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_e12aa7e5","line":170,"range":{"start_line":167,"start_character":0,"end_line":170,"end_character":67},"updated":"2017-03-24 11:52:51.000000000","message":"what if we make it even simpler:\n\n core_interfaces \u003d BaseDriver.core_interfaces + [\u0027network\u0027]\n standard_interfaces \u003d BaseDriver.standard_interfaces + [\u0027storage\u0027]\n\n?","commit_id":"824f1ed1bffd21321a50faad34187d84ba22088b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"bb4b015a07d607744950b62a2c12dce075eff9c4","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    class, as well as appended to core_interfaces or standard_interfaces here."},{"line_number":165,"context_line":"    \"\"\""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    # we need to take a copy of these as they are static and appending to them"},{"line_number":168,"context_line":"    # changes them in all classes that inherit from BaseDriver"},{"line_number":169,"context_line":"    core_interfaces \u003d copy.copy(BaseDriver.core_interfaces)"},{"line_number":170,"context_line":"    standard_interfaces \u003d copy.copy(BaseDriver.standard_interfaces)"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def __init__(self):"},{"line_number":173,"context_line":"        self.network \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffe62b97_e194e7ea","line":170,"range":{"start_line":167,"start_character":0,"end_line":170,"end_character":67},"in_reply_to":"ffe62b97_e12aa7e5","updated":"2017-03-24 12:01:41.000000000","message":"+1\n\nNote that the constructor is also initiating two variables: \"network\" and \"storage\", perhaps we can add them here as well and just get right of the whole __init__() ?\n\n class BareDriver(BaseDriver):\n\n     network \u003d None\n     \"\"\"blah blah blah\"\"\"\n\n     storage \u003d None\n     \"\"\"blah blah blah\"\"\"\n\n     core_interfaces \u003d BaseDriver.core_interfaces + [\u0027network\u0027]\n\n     standard_interfaces \u003d BaseDriver.standard_interfaces + [\u0027storage\u0027]","commit_id":"824f1ed1bffd21321a50faad34187d84ba22088b"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"23565c731a9c6bdb6219f6c88094aaa3e5bf4c18","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    \"\"\""},{"line_number":132,"context_line":"    standard_interfaces.append(\u0027raid\u0027)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    @abc.abstractmethod"},{"line_number":135,"context_line":"    def __init__(self):"},{"line_number":136,"context_line":"        pass"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_53b5a230","line":134,"range":{"start_line":134,"start_character":4,"end_line":134,"end_character":23},"updated":"2017-03-24 14:58:15.000000000","message":"this is terrible, I think we should remove it..","commit_id":"c9694be433b63a1b8fc3b72959cbfee2ce00d5b2"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"46d2e142177bbc24addbe7afa114226b0ad77bf7","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    \"\"\""},{"line_number":179,"context_line":"    standard_interfaces \u003d BaseDriver.standard_interfaces + [\u0027storage\u0027]"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def __init__(self):"},{"line_number":182,"context_line":"        pass"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"ALL_INTERFACES \u003d set(BareDriver().all_interfaces)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_cd7111e3","line":182,"range":{"start_line":181,"start_character":0,"end_line":182,"end_character":12},"updated":"2017-03-24 14:42:18.000000000","message":"Can be removed","commit_id":"c9694be433b63a1b8fc3b72959cbfee2ce00d5b2"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"b774b3e36579851c8824da6c360237b2cc294041","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    \"\"\""},{"line_number":179,"context_line":"    standard_interfaces \u003d BaseDriver.standard_interfaces + [\u0027storage\u0027]"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def __init__(self):"},{"line_number":182,"context_line":"        pass"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"ALL_INTERFACES \u003d set(BareDriver().all_interfaces)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_18361905","line":182,"range":{"start_line":181,"start_character":0,"end_line":182,"end_character":12},"in_reply_to":"ffe62b97_cd7111e3","updated":"2017-03-24 14:55:32.000000000","message":"I got this, so didn\u0027t try\n    http://paste.openstack.org/show/604055/","commit_id":"c9694be433b63a1b8fc3b72959cbfee2ce00d5b2"},{"author":{"_account_id":7711,"name":"Yuriy Zveryanskyy","email":"yzveryanskyy@mirantis.com","username":"yuriyz"},"change_message_id":"eac1875a3dc5f60347f01f0278015c2748c7417f","unresolved":false,"context_lines":[{"line_number":178,"context_line":"    \"\"\""},{"line_number":179,"context_line":"    standard_interfaces \u003d BaseDriver.standard_interfaces + [\u0027storage\u0027]"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def __init__(self):"},{"line_number":182,"context_line":"        pass"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"ALL_INTERFACES \u003d set(BareDriver().all_interfaces)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffe62b97_987349e8","line":182,"range":{"start_line":181,"start_character":0,"end_line":182,"end_character":12},"in_reply_to":"ffe62b97_cd7111e3","updated":"2017-03-24 14:54:41.000000000","message":"It\u0027s abstractmethod in base (l134).","commit_id":"c9694be433b63a1b8fc3b72959cbfee2ce00d5b2"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0fddb5363fa02c37e5d7c0cce0b63fba3a92ba51","unresolved":false,"context_lines":[{"line_number":132,"context_line":"    standard_interfaces.append(\u0027raid\u0027)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def __init__(self):"},{"line_number":135,"context_line":"        pass"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    @property"},{"line_number":138,"context_line":"    def all_interfaces(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"ffe62b97_f4f4995d","line":135,"updated":"2017-03-24 17:05:54.000000000","message":"nit: this is completely redundant now","commit_id":"9f28bd6112f8f9cdbdc13bfb1df87f6c4e302e31"}],"releasenotes/notes/bug-1672457-563d5354b41b060e.yaml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"0fddb5363fa02c37e5d7c0cce0b63fba3a92ba51","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixed a bug that was causing an increase in CPU usage over time."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ffe62b97_d4e99580","line":3,"updated":"2017-03-24 17:05:54.000000000","message":"nit: I\u0027d prefer a bit more detailed release note.","commit_id":"9f28bd6112f8f9cdbdc13bfb1df87f6c4e302e31"}]}
