)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"55c88aff15441b82b0b77f10071a1561c6750ced","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     kesper \u003cparesh.h.sao@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-04-07 09:45:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change to avoid deploy iso image getting created even provided"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds change in ironic devstack plugin to avoid"},{"line_number":10,"context_line":"deploy iso image from getting created even it is available."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bff0334d_e077053a","line":7,"range":{"start_line":7,"start_character":33,"end_line":7,"end_character":53},"updated":"2017-04-07 10:04:30.000000000","message":"May be:\ns/ \u0027getting created even\u0027 / \u0027being built when\u0027 /","commit_id":"90a2b1e419875e73b96fed7bc83ab489ad951371"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"12b50632928d3bcf2832fd895e828265e1c6e04f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     kesper \u003cparesh.h.sao@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-04-07 09:45:04 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change to avoid deploy iso image getting created even provided"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds change in ironic devstack plugin to avoid"},{"line_number":10,"context_line":"deploy iso image from getting created even it is available."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bff0334d_4086b1dd","line":7,"range":{"start_line":7,"start_character":33,"end_line":7,"end_character":53},"in_reply_to":"bff0334d_e077053a","updated":"2017-04-07 10:08:25.000000000","message":"Done","commit_id":"90a2b1e419875e73b96fed7bc83ab489ad951371"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"55c88aff15441b82b0b77f10071a1561c6750ced","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Change to avoid deploy iso image getting created even provided"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds change in ironic devstack plugin to avoid"},{"line_number":10,"context_line":"deploy iso image from getting created even it is available."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie7b417001687c19aed001e74f5c40dfd0ddde5cc"},{"line_number":13,"context_line":"Closes-bug: #1680763"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bff0334d_409c715c","line":10,"range":{"start_line":10,"start_character":38,"end_line":10,"end_character":42},"updated":"2017-04-07 10:04:30.000000000","message":"s/ even / when /","commit_id":"90a2b1e419875e73b96fed7bc83ab489ad951371"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"12b50632928d3bcf2832fd895e828265e1c6e04f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Change to avoid deploy iso image getting created even provided"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds change in ironic devstack plugin to avoid"},{"line_number":10,"context_line":"deploy iso image from getting created even it is available."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie7b417001687c19aed001e74f5c40dfd0ddde5cc"},{"line_number":13,"context_line":"Closes-bug: #1680763"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bff0334d_0068a91e","line":10,"range":{"start_line":10,"start_character":38,"end_line":10,"end_character":42},"in_reply_to":"bff0334d_409c715c","updated":"2017-04-07 10:08:25.000000000","message":"Done","commit_id":"90a2b1e419875e73b96fed7bc83ab489ad951371"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"42b6b0aa6d583095cda644e2d1f3696131b870cd","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Change to avoid deploy iso image being built when provided"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds change in ironic devstack plugin to avoid"},{"line_number":10,"context_line":"deploy iso image from getting created even it is available."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie7b417001687c19aed001e74f5c40dfd0ddde5cc"},{"line_number":13,"context_line":"Closes-bug: #1680763"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"bff0334d_7bfd8a6c","line":10,"range":{"start_line":10,"start_character":38,"end_line":10,"end_character":58},"updated":"2017-04-11 09:58:11.000000000","message":"s/ \u0027even it is available.\u0027 / \u0027when it is provided.\u0027 /","commit_id":"aad3315048706155b6b44b226fbc9ac624d64d39"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"b96ba441e3dfecc0dcf6a323299cc548dc8c5d5c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Change to avoid deploy iso image being built when provided"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds change in ironic devstack plugin to avoid"},{"line_number":10,"context_line":"deploy iso image from getting created even it is available."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie7b417001687c19aed001e74f5c40dfd0ddde5cc"},{"line_number":13,"context_line":"Closes-bug: #1680763"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"bff0334d_d9edbeb7","line":10,"range":{"start_line":10,"start_character":38,"end_line":10,"end_character":58},"in_reply_to":"bff0334d_7bfd8a6c","updated":"2017-04-11 10:48:47.000000000","message":"Done","commit_id":"aad3315048706155b6b44b226fbc9ac624d64d39"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"645edffd02de9a02f123dc55c98ee1a369c161e2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     kesper \u003cparesh.h.sao@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-04-11 11:02:54 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change to avoid building of deploy iso when provided"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds change in ironic devstack plugin to avoid"},{"line_number":10,"context_line":"deploy iso image from getting created when it is provided."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"bff0334d_a4a06ef5","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":52},"updated":"2017-04-12 07:55:49.000000000","message":"Even if iso exist we still need to build deploy kernel and ramdisk right?","commit_id":"d7349c898e194c3859fdfcc43b96da9798700276"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"a4b0408d5efe8e119321d14100421bb2193c943d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     kesper \u003cparesh.h.sao@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-04-11 11:02:54 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change to avoid building of deploy iso when provided"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds change in ironic devstack plugin to avoid"},{"line_number":10,"context_line":"deploy iso image from getting created when it is provided."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"bff0334d_c44807b4","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":52},"in_reply_to":"bff0334d_a4a06ef5","updated":"2017-04-12 12:57:54.000000000","message":"if we are using agent based deploy and we are providing iso we dont need to build kernel/ramdisk and if not then we have to build only iso not kenel/ramdisk.","commit_id":"d7349c898e194c3859fdfcc43b96da9798700276"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"bf7df164ee0170ec7b17d7d763fca9512934000e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     kesper \u003cparesh.h.sao@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-04-11 11:02:54 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change to avoid building of deploy iso when provided"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds change in ironic devstack plugin to avoid"},{"line_number":10,"context_line":"deploy iso image from getting created when it is provided."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9ff52f3f_7cff7067","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":52},"in_reply_to":"bff0334d_c44807b4","updated":"2017-04-13 09:17:48.000000000","message":"kernel and ramdisk are not required as a separate files if deploy iso is provided. The kernel and ramdisk are bundled into the iso file.\nWhen one needs to build deploy iso, the IPA build wold first build kernel and ramdiska and then package them into the iso.","commit_id":"d7349c898e194c3859fdfcc43b96da9798700276"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"645edffd02de9a02f123dc55c98ee1a369c161e2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Change to avoid building of deploy iso when provided"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds change in ironic devstack plugin to avoid"},{"line_number":10,"context_line":"deploy iso image from getting created when it is provided."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie7b417001687c19aed001e74f5c40dfd0ddde5cc"},{"line_number":13,"context_line":"Closes-bug: #1680763"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"bff0334d_a47bce89","line":10,"updated":"2017-04-12 07:55:49.000000000","message":"Please describe in more details what was done in commit. I see at least new variable IRONIC_AGENT_ISO_URL that is not mentioned here.","commit_id":"d7349c898e194c3859fdfcc43b96da9798700276"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"a4b0408d5efe8e119321d14100421bb2193c943d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Change to avoid building of deploy iso when provided"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds change in ironic devstack plugin to avoid"},{"line_number":10,"context_line":"deploy iso image from getting created when it is provided."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ie7b417001687c19aed001e74f5c40dfd0ddde5cc"},{"line_number":13,"context_line":"Closes-bug: #1680763"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"bff0334d_e4fb0b44","line":10,"in_reply_to":"bff0334d_a47bce89","updated":"2017-04-12 12:57:54.000000000","message":"Done","commit_id":"d7349c898e194c3859fdfcc43b96da9798700276"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ed97e73aec1bb1ec2660c2ab7b43cc2191b0ad24","unresolved":false,"context_lines":[{"line_number":11,"context_line":"is true and deploy iso is provided."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie7b417001687c19aed001e74f5c40dfd0ddde5cc"},{"line_number":14,"context_line":"Closes-bug: #1680763"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"3fa7e38b_b37da61d","line":14,"updated":"2019-10-07 21:55:10.000000000","message":"Ironic uses storyboard now, so in addition to \"Closes-Bug\" you\u0027ll want to add \"Story\" and \"Task\" tags from storyboard. The story number matches the launchpad bug number for the purposes of migration, but you\u0027ll need to look in Storyboard to find the task number and add it.","commit_id":"5cd5c7e0b447e8cdb47eed6d852723e6c88e3bc6"}],"devstack/lib/ironic":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"55c88aff15441b82b0b77f10071a1561c6750ced","unresolved":false,"context_lines":[{"line_number":1879,"context_line":"    if [[ \"$HOST_TOPOLOGY_ROLE\" !\u003d \u0027subnode\u0027 ]]; then"},{"line_number":1880,"context_line":"        echo_summary \"Creating and uploading baremetal images for ironic\""},{"line_number":1881,"context_line":"        "},{"line_number":1882,"context_line":"        if ( is_deploy_iso_required \u0026\u0026 [ -e \"$IRONIC_DEPLOY_ISO\" ] ); then"},{"line_number":1883,"context_line":"           $build_required\u003dfalse"},{"line_number":1884,"context_line":"        else"},{"line_number":1885,"context_line":"           if [ ! -e \"$IRONIC_DEPLOY_RAMDISK\" ] || [ ! -e \"$IRONIC_DEPLOY_KERNEL\" ]; then"},{"line_number":1886,"context_line":"              $build_required\u003dtrue"},{"line_number":1887,"context_line":"           else"},{"line_number":1888,"context_line":"              $build_required\u003dfalse"},{"line_number":1889,"context_line":"           fi"},{"line_number":1890,"context_line":"        fi "},{"line_number":1891,"context_line":"         "},{"line_number":1892,"context_line":"        if [ $build_required ]; then"},{"line_number":1893,"context_line":"            # files don\u0027t exist, need to build them"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bff0334d_a0a1fdab","line":1890,"range":{"start_line":1882,"start_character":8,"end_line":1890,"end_character":11},"updated":"2017-04-07 10:04:30.000000000","message":"To simplify a bit, can we do this as:-\n \nlocal  build_required\u003dfalse\n  # For virtual media based deploy\n  if is_deploy_iso_required ; then\n      if ! -e \"$IRONIC_DEPLOY_ISO\" ] ); then\n           $build_required\u003dtrue\n  else\n  # For pxe media based deploy\n      if [ ! -e \"$IRONIC_DEPLOY_RAMDISK\" ] || [ ! -e \"$IRONIC_DEPLOY_KERNEL\" ]; then\n          $build_required\u003dtrue\n  fi","commit_id":"90a2b1e419875e73b96fed7bc83ab489ad951371"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"12b50632928d3bcf2832fd895e828265e1c6e04f","unresolved":false,"context_lines":[{"line_number":1879,"context_line":"    if [[ \"$HOST_TOPOLOGY_ROLE\" !\u003d \u0027subnode\u0027 ]]; then"},{"line_number":1880,"context_line":"        echo_summary \"Creating and uploading baremetal images for ironic\""},{"line_number":1881,"context_line":"        "},{"line_number":1882,"context_line":"        if ( is_deploy_iso_required \u0026\u0026 [ -e \"$IRONIC_DEPLOY_ISO\" ] ); then"},{"line_number":1883,"context_line":"           $build_required\u003dfalse"},{"line_number":1884,"context_line":"        else"},{"line_number":1885,"context_line":"           if [ ! -e \"$IRONIC_DEPLOY_RAMDISK\" ] || [ ! -e \"$IRONIC_DEPLOY_KERNEL\" ]; then"},{"line_number":1886,"context_line":"              $build_required\u003dtrue"},{"line_number":1887,"context_line":"           else"},{"line_number":1888,"context_line":"              $build_required\u003dfalse"},{"line_number":1889,"context_line":"           fi"},{"line_number":1890,"context_line":"        fi "},{"line_number":1891,"context_line":"         "},{"line_number":1892,"context_line":"        if [ $build_required ]; then"},{"line_number":1893,"context_line":"            # files don\u0027t exist, need to build them"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"bff0334d_a0621d3d","line":1890,"range":{"start_line":1882,"start_character":8,"end_line":1890,"end_character":11},"in_reply_to":"bff0334d_a0a1fdab","updated":"2017-04-07 10:08:25.000000000","message":"Done","commit_id":"90a2b1e419875e73b96fed7bc83ab489ad951371"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"c8ace76da9709a446d3961eec182c3d2a29fb8d1","unresolved":false,"context_lines":[{"line_number":1880,"context_line":"        echo_summary \"Creating and uploading baremetal images for ironic\""},{"line_number":1881,"context_line":"        # For virtual media based deploy "},{"line_number":1882,"context_line":"        if is_deploy_iso_required; then"},{"line_number":1883,"context_line":"           if [ ! -e \"$IRONIC_DEPLOY_ISO\" ]; then"},{"line_number":1884,"context_line":"              $build_required\u003dtrue"},{"line_number":1885,"context_line":"           fi"},{"line_number":1886,"context_line":"        # For pxe media based deploy"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"bff0334d_f0de900f","line":1883,"range":{"start_line":1883,"start_character":8,"end_line":1883,"end_character":11},"updated":"2017-04-08 19:15:01.000000000","message":"The indent here is not a multiple of 4 and that is why pep8 is failing.","commit_id":"2ee377bc6f9f7799409439a680c4d188b5de3004"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"467e2444c1cb7e5062208c1ac2931f2ba62938b7","unresolved":false,"context_lines":[{"line_number":1880,"context_line":"        echo_summary \"Creating and uploading baremetal images for ironic\""},{"line_number":1881,"context_line":"        # For virtual media based deploy "},{"line_number":1882,"context_line":"        if is_deploy_iso_required; then"},{"line_number":1883,"context_line":"           if [ ! -e \"$IRONIC_DEPLOY_ISO\" ]; then"},{"line_number":1884,"context_line":"              $build_required\u003dtrue"},{"line_number":1885,"context_line":"           fi"},{"line_number":1886,"context_line":"        # For pxe media based deploy"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"bff0334d_cdf08e00","line":1883,"range":{"start_line":1883,"start_character":8,"end_line":1883,"end_character":11},"in_reply_to":"bff0334d_f0de900f","updated":"2017-04-10 04:49:44.000000000","message":"Done","commit_id":"2ee377bc6f9f7799409439a680c4d188b5de3004"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"c8ace76da9709a446d3961eec182c3d2a29fb8d1","unresolved":false,"context_lines":[{"line_number":1881,"context_line":"        # For virtual media based deploy "},{"line_number":1882,"context_line":"        if is_deploy_iso_required; then"},{"line_number":1883,"context_line":"           if [ ! -e \"$IRONIC_DEPLOY_ISO\" ]; then"},{"line_number":1884,"context_line":"              $build_required\u003dtrue"},{"line_number":1885,"context_line":"           fi"},{"line_number":1886,"context_line":"        # For pxe media based deploy"},{"line_number":1887,"context_line":"        else"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"bff0334d_b0e488e1","line":1884,"updated":"2017-04-08 19:15:01.000000000","message":"Same comment as above","commit_id":"2ee377bc6f9f7799409439a680c4d188b5de3004"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"467e2444c1cb7e5062208c1ac2931f2ba62938b7","unresolved":false,"context_lines":[{"line_number":1881,"context_line":"        # For virtual media based deploy "},{"line_number":1882,"context_line":"        if is_deploy_iso_required; then"},{"line_number":1883,"context_line":"           if [ ! -e \"$IRONIC_DEPLOY_ISO\" ]; then"},{"line_number":1884,"context_line":"              $build_required\u003dtrue"},{"line_number":1885,"context_line":"           fi"},{"line_number":1886,"context_line":"        # For pxe media based deploy"},{"line_number":1887,"context_line":"        else"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"bff0334d_adf54aef","line":1884,"in_reply_to":"bff0334d_b0e488e1","updated":"2017-04-10 04:49:44.000000000","message":"Done","commit_id":"2ee377bc6f9f7799409439a680c4d188b5de3004"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"c8ace76da9709a446d3961eec182c3d2a29fb8d1","unresolved":false,"context_lines":[{"line_number":1882,"context_line":"        if is_deploy_iso_required; then"},{"line_number":1883,"context_line":"           if [ ! -e \"$IRONIC_DEPLOY_ISO\" ]; then"},{"line_number":1884,"context_line":"              $build_required\u003dtrue"},{"line_number":1885,"context_line":"           fi"},{"line_number":1886,"context_line":"        # For pxe media based deploy"},{"line_number":1887,"context_line":"        else"},{"line_number":1888,"context_line":"           if [ ! -e \"$IRONIC_DEPLOY_RAMDISK\" ] || [ ! -e \"$IRONIC_DEPLOY_KERNEL\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"bff0334d_70d28002","line":1885,"updated":"2017-04-08 19:15:01.000000000","message":"Same comment as above","commit_id":"2ee377bc6f9f7799409439a680c4d188b5de3004"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"467e2444c1cb7e5062208c1ac2931f2ba62938b7","unresolved":false,"context_lines":[{"line_number":1882,"context_line":"        if is_deploy_iso_required; then"},{"line_number":1883,"context_line":"           if [ ! -e \"$IRONIC_DEPLOY_ISO\" ]; then"},{"line_number":1884,"context_line":"              $build_required\u003dtrue"},{"line_number":1885,"context_line":"           fi"},{"line_number":1886,"context_line":"        # For pxe media based deploy"},{"line_number":1887,"context_line":"        else"},{"line_number":1888,"context_line":"           if [ ! -e \"$IRONIC_DEPLOY_RAMDISK\" ] || [ ! -e \"$IRONIC_DEPLOY_KERNEL\" ]; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"bff0334d_8dde066b","line":1885,"in_reply_to":"bff0334d_70d28002","updated":"2017-04-10 04:49:44.000000000","message":"Done","commit_id":"2ee377bc6f9f7799409439a680c4d188b5de3004"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"c8ace76da9709a446d3961eec182c3d2a29fb8d1","unresolved":false,"context_lines":[{"line_number":1885,"context_line":"           fi"},{"line_number":1886,"context_line":"        # For pxe media based deploy"},{"line_number":1887,"context_line":"        else"},{"line_number":1888,"context_line":"           if [ ! -e \"$IRONIC_DEPLOY_RAMDISK\" ] || [ ! -e \"$IRONIC_DEPLOY_KERNEL\" ]; then"},{"line_number":1889,"context_line":"              $build_required\u003dtrue"},{"line_number":1890,"context_line":"           fi"},{"line_number":1891,"context_line":"        fi "}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"bff0334d_50cf7c55","line":1888,"updated":"2017-04-08 19:15:01.000000000","message":"Same comment as above","commit_id":"2ee377bc6f9f7799409439a680c4d188b5de3004"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"467e2444c1cb7e5062208c1ac2931f2ba62938b7","unresolved":false,"context_lines":[{"line_number":1885,"context_line":"           fi"},{"line_number":1886,"context_line":"        # For pxe media based deploy"},{"line_number":1887,"context_line":"        else"},{"line_number":1888,"context_line":"           if [ ! -e \"$IRONIC_DEPLOY_RAMDISK\" ] || [ ! -e \"$IRONIC_DEPLOY_KERNEL\" ]; then"},{"line_number":1889,"context_line":"              $build_required\u003dtrue"},{"line_number":1890,"context_line":"           fi"},{"line_number":1891,"context_line":"        fi "}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"bff0334d_6ddbc27b","line":1888,"in_reply_to":"bff0334d_50cf7c55","updated":"2017-04-10 04:49:44.000000000","message":"Done","commit_id":"2ee377bc6f9f7799409439a680c4d188b5de3004"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"c8ace76da9709a446d3961eec182c3d2a29fb8d1","unresolved":false,"context_lines":[{"line_number":1886,"context_line":"        # For pxe media based deploy"},{"line_number":1887,"context_line":"        else"},{"line_number":1888,"context_line":"           if [ ! -e \"$IRONIC_DEPLOY_RAMDISK\" ] || [ ! -e \"$IRONIC_DEPLOY_KERNEL\" ]; then"},{"line_number":1889,"context_line":"              $build_required\u003dtrue"},{"line_number":1890,"context_line":"           fi"},{"line_number":1891,"context_line":"        fi "},{"line_number":1892,"context_line":"         "}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"bff0334d_30d8781c","line":1889,"updated":"2017-04-08 19:15:01.000000000","message":"Same comment as above","commit_id":"2ee377bc6f9f7799409439a680c4d188b5de3004"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"467e2444c1cb7e5062208c1ac2931f2ba62938b7","unresolved":false,"context_lines":[{"line_number":1886,"context_line":"        # For pxe media based deploy"},{"line_number":1887,"context_line":"        else"},{"line_number":1888,"context_line":"           if [ ! -e \"$IRONIC_DEPLOY_RAMDISK\" ] || [ ! -e \"$IRONIC_DEPLOY_KERNEL\" ]; then"},{"line_number":1889,"context_line":"              $build_required\u003dtrue"},{"line_number":1890,"context_line":"           fi"},{"line_number":1891,"context_line":"        fi "},{"line_number":1892,"context_line":"         "}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"bff0334d_4de47e3c","line":1889,"in_reply_to":"bff0334d_30d8781c","updated":"2017-04-10 04:49:44.000000000","message":"Done","commit_id":"2ee377bc6f9f7799409439a680c4d188b5de3004"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"c8ace76da9709a446d3961eec182c3d2a29fb8d1","unresolved":false,"context_lines":[{"line_number":1887,"context_line":"        else"},{"line_number":1888,"context_line":"           if [ ! -e \"$IRONIC_DEPLOY_RAMDISK\" ] || [ ! -e \"$IRONIC_DEPLOY_KERNEL\" ]; then"},{"line_number":1889,"context_line":"              $build_required\u003dtrue"},{"line_number":1890,"context_line":"           fi"},{"line_number":1891,"context_line":"        fi "},{"line_number":1892,"context_line":"         "},{"line_number":1893,"context_line":"        if [ $build_required ]; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"bff0334d_10d574e5","line":1890,"updated":"2017-04-08 19:15:01.000000000","message":"Same comment as above","commit_id":"2ee377bc6f9f7799409439a680c4d188b5de3004"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"467e2444c1cb7e5062208c1ac2931f2ba62938b7","unresolved":false,"context_lines":[{"line_number":1887,"context_line":"        else"},{"line_number":1888,"context_line":"           if [ ! -e \"$IRONIC_DEPLOY_RAMDISK\" ] || [ ! -e \"$IRONIC_DEPLOY_KERNEL\" ]; then"},{"line_number":1889,"context_line":"              $build_required\u003dtrue"},{"line_number":1890,"context_line":"           fi"},{"line_number":1891,"context_line":"        fi "},{"line_number":1892,"context_line":"         "},{"line_number":1893,"context_line":"        if [ $build_required ]; then"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"bff0334d_2de13a2b","line":1890,"in_reply_to":"bff0334d_10d574e5","updated":"2017-04-10 04:49:44.000000000","message":"Done","commit_id":"2ee377bc6f9f7799409439a680c4d188b5de3004"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"c8ace76da9709a446d3961eec182c3d2a29fb8d1","unresolved":false,"context_lines":[{"line_number":1888,"context_line":"           if [ ! -e \"$IRONIC_DEPLOY_RAMDISK\" ] || [ ! -e \"$IRONIC_DEPLOY_KERNEL\" ]; then"},{"line_number":1889,"context_line":"              $build_required\u003dtrue"},{"line_number":1890,"context_line":"           fi"},{"line_number":1891,"context_line":"        fi "},{"line_number":1892,"context_line":"         "},{"line_number":1893,"context_line":"        if [ $build_required ]; then"},{"line_number":1894,"context_line":"            # files don\u0027t exist, need to build them"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"bff0334d_f007b081","line":1891,"updated":"2017-04-08 19:15:01.000000000","message":"Same comment as above","commit_id":"2ee377bc6f9f7799409439a680c4d188b5de3004"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"467e2444c1cb7e5062208c1ac2931f2ba62938b7","unresolved":false,"context_lines":[{"line_number":1888,"context_line":"           if [ ! -e \"$IRONIC_DEPLOY_RAMDISK\" ] || [ ! -e \"$IRONIC_DEPLOY_KERNEL\" ]; then"},{"line_number":1889,"context_line":"              $build_required\u003dtrue"},{"line_number":1890,"context_line":"           fi"},{"line_number":1891,"context_line":"        fi "},{"line_number":1892,"context_line":"         "},{"line_number":1893,"context_line":"        if [ $build_required ]; then"},{"line_number":1894,"context_line":"            # files don\u0027t exist, need to build them"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"bff0334d_0dd43647","line":1891,"in_reply_to":"bff0334d_f007b081","updated":"2017-04-10 04:49:44.000000000","message":"Done","commit_id":"2ee377bc6f9f7799409439a680c4d188b5de3004"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"42b6b0aa6d583095cda644e2d1f3696131b870cd","unresolved":false,"context_lines":[{"line_number":212,"context_line":"# Configure URLs required to download ramdisk if we\u0027re not building it, and"},{"line_number":213,"context_line":"# IRONIC_DEPLOY_RAMDISK/KERNEL or the RAMDISK/KERNEL_URLs have not been"},{"line_number":214,"context_line":"# preconfigured."},{"line_number":215,"context_line":"if [[ ! -e \"$IRONIC_DEPLOY_ISO\" \u0026\u0026 \"$IRONIC_BUILD_DEPLOY_RAMDISK\" \u003d\u003d \"False\" \u0026\u0026 \\"},{"line_number":216,"context_line":"        ! (-e \"$IRONIC_DEPLOY_RAMDISK\" \u0026\u0026 -e \"$IRONIC_DEPLOY_KERNEL\") \u0026\u0026 \\"},{"line_number":217,"context_line":"        (-z \"$IRONIC_AGENT_KERNEL_URL\" || -z \"$IRONIC_AGENT_RAMDISK_URL\") ]]; then"},{"line_number":218,"context_line":"    case $IRONIC_RAMDISK_TYPE in"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"bff0334d_3e6b70b7","line":215,"range":{"start_line":215,"start_character":6,"end_line":215,"end_character":31},"updated":"2017-04-11 09:58:11.000000000","message":"I think this check should be based on is_deploy_iso_required()\n if [[  ! is_deploy_iso_required \u0026\u0026 ...]]","commit_id":"aad3315048706155b6b44b226fbc9ac624d64d39"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"b96ba441e3dfecc0dcf6a323299cc548dc8c5d5c","unresolved":false,"context_lines":[{"line_number":212,"context_line":"# Configure URLs required to download ramdisk if we\u0027re not building it, and"},{"line_number":213,"context_line":"# IRONIC_DEPLOY_RAMDISK/KERNEL or the RAMDISK/KERNEL_URLs have not been"},{"line_number":214,"context_line":"# preconfigured."},{"line_number":215,"context_line":"if [[ ! -e \"$IRONIC_DEPLOY_ISO\" \u0026\u0026 \"$IRONIC_BUILD_DEPLOY_RAMDISK\" \u003d\u003d \"False\" \u0026\u0026 \\"},{"line_number":216,"context_line":"        ! (-e \"$IRONIC_DEPLOY_RAMDISK\" \u0026\u0026 -e \"$IRONIC_DEPLOY_KERNEL\") \u0026\u0026 \\"},{"line_number":217,"context_line":"        (-z \"$IRONIC_AGENT_KERNEL_URL\" || -z \"$IRONIC_AGENT_RAMDISK_URL\") ]]; then"},{"line_number":218,"context_line":"    case $IRONIC_RAMDISK_TYPE in"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"bff0334d_59376e4e","line":215,"range":{"start_line":215,"start_character":6,"end_line":215,"end_character":31},"in_reply_to":"bff0334d_3e6b70b7","updated":"2017-04-11 10:48:47.000000000","message":"Done","commit_id":"aad3315048706155b6b44b226fbc9ac624d64d39"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"645edffd02de9a02f123dc55c98ee1a369c161e2","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"# Configure URLs required to download ramdisk if we\u0027re not building it, and"},{"line_number":229,"context_line":"# IRONIC_DEPLOY_RAMDISK/KERNEL or the RAMDISK/KERNEL_URLs have not been"},{"line_number":230,"context_line":"# preconfigured."},{"line_number":231,"context_line":"if is_deploy_iso_required; then"},{"line_number":232,"context_line":"    if [[ ! -e \"$IRONIC_DEPLOY_ISO\" \u0026\u0026 -z \"$IRONIC_AGENT_ISO_URL\" ]]; then"},{"line_number":233,"context_line":"        IRONIC_AGENT_ISO_URL\u003d${IRONIC_AGENT_ISO_URL:-}"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"bff0334d_26ed85b6","line":230,"updated":"2017-04-12 07:55:49.000000000","message":"this comment is related to code that starting on L236","commit_id":"d7349c898e194c3859fdfcc43b96da9798700276"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"a4b0408d5efe8e119321d14100421bb2193c943d","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"# Configure URLs required to download ramdisk if we\u0027re not building it, and"},{"line_number":229,"context_line":"# IRONIC_DEPLOY_RAMDISK/KERNEL or the RAMDISK/KERNEL_URLs have not been"},{"line_number":230,"context_line":"# preconfigured."},{"line_number":231,"context_line":"if is_deploy_iso_required; then"},{"line_number":232,"context_line":"    if [[ ! -e \"$IRONIC_DEPLOY_ISO\" \u0026\u0026 -z \"$IRONIC_AGENT_ISO_URL\" ]]; then"},{"line_number":233,"context_line":"        IRONIC_AGENT_ISO_URL\u003d${IRONIC_AGENT_ISO_URL:-}"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"bff0334d_8468bff4","line":230,"in_reply_to":"bff0334d_26ed85b6","updated":"2017-04-12 12:57:54.000000000","message":"Done","commit_id":"d7349c898e194c3859fdfcc43b96da9798700276"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"faf31ef85e2f65cf72f418a9942cfcfadd5ee972","unresolved":false,"context_lines":[{"line_number":228,"context_line":"# Configure URLs required to download ramdisk if we\u0027re not building it, and"},{"line_number":229,"context_line":"# IRONIC_DEPLOY_RAMDISK/KERNEL or the RAMDISK/KERNEL_URLs have not been"},{"line_number":230,"context_line":"# preconfigured."},{"line_number":231,"context_line":"if is_deploy_iso_required; then"},{"line_number":232,"context_line":"    if [[ ! -e \"$IRONIC_DEPLOY_ISO\" \u0026\u0026 -z \"$IRONIC_AGENT_ISO_URL\" ]]; then"},{"line_number":233,"context_line":"        IRONIC_AGENT_ISO_URL\u003d${IRONIC_AGENT_ISO_URL:-}"},{"line_number":234,"context_line":"    fi"},{"line_number":235,"context_line":"else"},{"line_number":236,"context_line":"    if [[ \"$IRONIC_BUILD_DEPLOY_RAMDISK\" \u003d\u003d \"False\" \u0026\u0026 \\"},{"line_number":237,"context_line":"        ! (-e \"$IRONIC_DEPLOY_RAMDISK\" \u0026\u0026 -e \"$IRONIC_DEPLOY_KERNEL\") \u0026\u0026 \\"},{"line_number":238,"context_line":"        (-z \"$IRONIC_AGENT_KERNEL_URL\" || -z \"$IRONIC_AGENT_RAMDISK_URL\") ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"bff0334d_81920356","line":235,"range":{"start_line":231,"start_character":0,"end_line":235,"end_character":4},"updated":"2017-04-12 03:25:48.000000000","message":"There is nothing done in this block. It tries to set the variable IRONIC_AGENT_ISO_URL with its own value which is empty.\n\nI think all you can achieve this by:-\nif ! is_deploy_iso_required; then\n    if [[ \"$IRONIC_BUILD_DEPLOY_RAMDISK\" \u003d\u003d \"False\" \u0026\u0026 \\\n...","commit_id":"d7349c898e194c3859fdfcc43b96da9798700276"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"d2fa51ea5341273793e14149a673e3470bca76c0","unresolved":false,"context_lines":[{"line_number":228,"context_line":"# Configure URLs required to download ramdisk if we\u0027re not building it, and"},{"line_number":229,"context_line":"# IRONIC_DEPLOY_RAMDISK/KERNEL or the RAMDISK/KERNEL_URLs have not been"},{"line_number":230,"context_line":"# preconfigured."},{"line_number":231,"context_line":"if is_deploy_iso_required; then"},{"line_number":232,"context_line":"    if [[ ! -e \"$IRONIC_DEPLOY_ISO\" \u0026\u0026 -z \"$IRONIC_AGENT_ISO_URL\" ]]; then"},{"line_number":233,"context_line":"        IRONIC_AGENT_ISO_URL\u003d${IRONIC_AGENT_ISO_URL:-}"},{"line_number":234,"context_line":"    fi"},{"line_number":235,"context_line":"else"},{"line_number":236,"context_line":"    if [[ \"$IRONIC_BUILD_DEPLOY_RAMDISK\" \u003d\u003d \"False\" \u0026\u0026 \\"},{"line_number":237,"context_line":"        ! (-e \"$IRONIC_DEPLOY_RAMDISK\" \u0026\u0026 -e \"$IRONIC_DEPLOY_KERNEL\") \u0026\u0026 \\"},{"line_number":238,"context_line":"        (-z \"$IRONIC_AGENT_KERNEL_URL\" || -z \"$IRONIC_AGENT_RAMDISK_URL\") ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"bff0334d_441529e4","line":235,"range":{"start_line":231,"start_character":0,"end_line":235,"end_character":4},"in_reply_to":"bff0334d_81920356","updated":"2017-04-12 04:14:49.000000000","message":"Done","commit_id":"d7349c898e194c3859fdfcc43b96da9798700276"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"645edffd02de9a02f123dc55c98ee1a369c161e2","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        IRONIC_AGENT_ISO_URL\u003d${IRONIC_AGENT_ISO_URL:-}"},{"line_number":234,"context_line":"    fi"},{"line_number":235,"context_line":"else"},{"line_number":236,"context_line":"    if [[ \"$IRONIC_BUILD_DEPLOY_RAMDISK\" \u003d\u003d \"False\" \u0026\u0026 \\"},{"line_number":237,"context_line":"        ! (-e \"$IRONIC_DEPLOY_RAMDISK\" \u0026\u0026 -e \"$IRONIC_DEPLOY_KERNEL\") \u0026\u0026 \\"},{"line_number":238,"context_line":"        (-z \"$IRONIC_AGENT_KERNEL_URL\" || -z \"$IRONIC_AGENT_RAMDISK_URL\") ]]; then"},{"line_number":239,"context_line":"        case $IRONIC_RAMDISK_TYPE in"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"bff0334d_66f70d8d","line":236,"updated":"2017-04-12 07:55:49.000000000","message":"why it was moved here? wrong indentation.","commit_id":"d7349c898e194c3859fdfcc43b96da9798700276"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"a4b0408d5efe8e119321d14100421bb2193c943d","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        IRONIC_AGENT_ISO_URL\u003d${IRONIC_AGENT_ISO_URL:-}"},{"line_number":234,"context_line":"    fi"},{"line_number":235,"context_line":"else"},{"line_number":236,"context_line":"    if [[ \"$IRONIC_BUILD_DEPLOY_RAMDISK\" \u003d\u003d \"False\" \u0026\u0026 \\"},{"line_number":237,"context_line":"        ! (-e \"$IRONIC_DEPLOY_RAMDISK\" \u0026\u0026 -e \"$IRONIC_DEPLOY_KERNEL\") \u0026\u0026 \\"},{"line_number":238,"context_line":"        (-z \"$IRONIC_AGENT_KERNEL_URL\" || -z \"$IRONIC_AGENT_RAMDISK_URL\") ]]; then"},{"line_number":239,"context_line":"        case $IRONIC_RAMDISK_TYPE in"}],"source_content_type":"application/x-shellscript","patch_set":10,"id":"bff0334d_bf2aac7b","line":236,"in_reply_to":"bff0334d_66f70d8d","updated":"2017-04-12 12:57:54.000000000","message":"Done","commit_id":"d7349c898e194c3859fdfcc43b96da9798700276"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"363ac65485c0159d38d4e36ba3c751d1646cdfe3","unresolved":false,"context_lines":[{"line_number":1876,"context_line":""},{"line_number":1877,"context_line":"    local ironic_deploy_kernel_name"},{"line_number":1878,"context_line":"    local ironic_deploy_ramdisk_name"},{"line_number":1879,"context_line":"    local build_required\u003dfalse"},{"line_number":1880,"context_line":"    ironic_deploy_kernel_name\u003d$(basename $IRONIC_DEPLOY_KERNEL)"},{"line_number":1881,"context_line":"    ironic_deploy_ramdisk_name\u003d$(basename $IRONIC_DEPLOY_RAMDISK)"},{"line_number":1882,"context_line":"    if [[ \"$HOST_TOPOLOGY_ROLE\" !\u003d \u0027subnode\u0027 ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"7ffa3b31_415fdb71","line":1879,"updated":"2017-04-18 14:34:46.000000000","message":"all the changes that are required are contained in this function, why have you shuffled the code in other places?","commit_id":"b5619683ebf1f94b71529ff1ab6b755663c6da32"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"bfd4b2d6ac18e1bb52d0e9cd94525ac5471380a0","unresolved":false,"context_lines":[{"line_number":1876,"context_line":""},{"line_number":1877,"context_line":"    local ironic_deploy_kernel_name"},{"line_number":1878,"context_line":"    local ironic_deploy_ramdisk_name"},{"line_number":1879,"context_line":"    local build_required\u003dfalse"},{"line_number":1880,"context_line":"    ironic_deploy_kernel_name\u003d$(basename $IRONIC_DEPLOY_KERNEL)"},{"line_number":1881,"context_line":"    ironic_deploy_ramdisk_name\u003d$(basename $IRONIC_DEPLOY_RAMDISK)"},{"line_number":1882,"context_line":"    if [[ \"$HOST_TOPOLOGY_ROLE\" !\u003d \u0027subnode\u0027 ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":12,"id":"7ffa3b31_cb4bf628","line":1879,"in_reply_to":"7ffa3b31_415fdb71","updated":"2017-04-19 04:17:53.000000000","message":"Here changes are to avoid building deploy iso when it was given, and the other change adds a check to stop executing those statements, which were trying to download deploy kernel/ramdisk and returns an error even when deploy iso is given.","commit_id":"b5619683ebf1f94b71529ff1ab6b755663c6da32"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"a7d3d49b635f2f538c4942d1416c070a0debd71e","unresolved":false,"context_lines":[{"line_number":591,"context_line":"    if [[ -n $interface_implementations ]]; then"},{"line_number":592,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_${interface_name}_interfaces $interface_implementations"},{"line_number":593,"context_line":"    fi"},{"line_number":594,"context_line":"}"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"IRONIC_DEFAULT_IMAGE_NAME\u003dcirros-${CIRROS_VERSION}-x86_64-uec"},{"line_number":597,"context_line":"if [[ \"$IRONIC_BOOT_MODE\" \u003d\u003d \"uefi\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"bf57530f_186071a5","line":594,"updated":"2017-09-20 18:58:52.000000000","message":"I might be missing something but this function doesn\u0027t seem to be used. Please remove from this patchset. Thanks!","commit_id":"d5027f48937c18fe3010d43277f5788d8f9e8902"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"60a6e281205c86bb320c6b644757ef01653c880e","unresolved":false,"context_lines":[{"line_number":591,"context_line":"    if [[ -n $interface_implementations ]]; then"},{"line_number":592,"context_line":"        iniset $IRONIC_CONF_FILE DEFAULT enabled_${interface_name}_interfaces $interface_implementations"},{"line_number":593,"context_line":"    fi"},{"line_number":594,"context_line":"}"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"IRONIC_DEFAULT_IMAGE_NAME\u003dcirros-${CIRROS_VERSION}-x86_64-uec"},{"line_number":597,"context_line":"if [[ \"$IRONIC_BOOT_MODE\" \u003d\u003d \"uefi\" ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"1f485f77_5eeb87af","line":594,"in_reply_to":"bf57530f_186071a5","updated":"2017-11-10 06:24:36.000000000","message":"Done","commit_id":"d5027f48937c18fe3010d43277f5788d8f9e8902"},{"author":{"_account_id":11929,"name":"Michael Turek","email":"mjturek@linux.vnet.ibm.com","username":"mjturek"},"change_message_id":"a7d3d49b635f2f538c4942d1416c070a0debd71e","unresolved":false,"context_lines":[{"line_number":2057,"context_line":"    ironic_deploy_ramdisk_name\u003d$(basename $IRONIC_DEPLOY_RAMDISK)"},{"line_number":2058,"context_line":"    if [[ \"$HOST_TOPOLOGY_ROLE\" !\u003d \u0027subnode\u0027 ]]; then"},{"line_number":2059,"context_line":"        echo_summary \"Creating and uploading baremetal images for ironic\""},{"line_number":2060,"context_line":"        # For virtual media based deploy "},{"line_number":2061,"context_line":"        if is_deploy_iso_required; then"},{"line_number":2062,"context_line":"            if [ ! -e \"$IRONIC_DEPLOY_ISO\" ]; then"},{"line_number":2063,"context_line":"                build_required\u003dtrue"}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"bf57530f_f8647dbb","line":2060,"updated":"2017-09-20 18:58:52.000000000","message":"nit - Trailing space here","commit_id":"d5027f48937c18fe3010d43277f5788d8f9e8902"},{"author":{"_account_id":22271,"name":"paresh","email":"paresh.sao@hpe.com","username":"kesper"},"change_message_id":"60a6e281205c86bb320c6b644757ef01653c880e","unresolved":false,"context_lines":[{"line_number":2057,"context_line":"    ironic_deploy_ramdisk_name\u003d$(basename $IRONIC_DEPLOY_RAMDISK)"},{"line_number":2058,"context_line":"    if [[ \"$HOST_TOPOLOGY_ROLE\" !\u003d \u0027subnode\u0027 ]]; then"},{"line_number":2059,"context_line":"        echo_summary \"Creating and uploading baremetal images for ironic\""},{"line_number":2060,"context_line":"        # For virtual media based deploy "},{"line_number":2061,"context_line":"        if is_deploy_iso_required; then"},{"line_number":2062,"context_line":"            if [ ! -e \"$IRONIC_DEPLOY_ISO\" ]; then"},{"line_number":2063,"context_line":"                build_required\u003dtrue"}],"source_content_type":"application/x-shellscript","patch_set":17,"id":"1f485f77_bedcbb18","line":2060,"in_reply_to":"bf57530f_f8647dbb","updated":"2017-11-10 06:24:36.000000000","message":"Done","commit_id":"d5027f48937c18fe3010d43277f5788d8f9e8902"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8c87765c8ae5e37461c07a49c948a5282f62a5b3","unresolved":false,"context_lines":[{"line_number":2602,"context_line":"    if [[ \"$HOST_TOPOLOGY_ROLE\" !\u003d \u0027subnode\u0027 ]]; then"},{"line_number":2603,"context_line":"        echo_summary \"Creating and uploading baremetal images for ironic\""},{"line_number":2604,"context_line":""},{"line_number":2605,"context_line":"\tif is_deploy_iso_required; then"},{"line_number":2606,"context_line":"            if [ ! -e \"$IRONIC_DEPLOY_ISO\" ]; then"},{"line_number":2607,"context_line":"                build_required\u003dtrue"},{"line_number":2608,"context_line":"            fi"}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"3fa7e38b_f340fe09","line":2605,"range":{"start_line":2605,"start_character":0,"end_line":2605,"end_character":1},"updated":"2019-10-07 21:50:42.000000000","message":"This is a tab and should likely be removed for spaces.","commit_id":"5cd5c7e0b447e8cdb47eed6d852723e6c88e3bc6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8c87765c8ae5e37461c07a49c948a5282f62a5b3","unresolved":false,"context_lines":[{"line_number":2612,"context_line":"            fi"},{"line_number":2613,"context_line":"        fi"},{"line_number":2614,"context_line":""},{"line_number":2615,"context_line":"        if build_required; then"},{"line_number":2616,"context_line":"            # files don\u0027t exist, need to build them"},{"line_number":2617,"context_line":"            if [ \"$IRONIC_BUILD_DEPLOY_RAMDISK\" \u003d \"True\" ]; then"},{"line_number":2618,"context_line":"                # we can build them only if we\u0027re not offline"}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"3fa7e38b_73540ecb","line":2615,"range":{"start_line":2615,"start_character":11,"end_line":2615,"end_character":26},"updated":"2019-10-07 21:50:42.000000000","message":"This might not be working as expected because build_required is a variable, not a method, and being handled like a variable it should be referred to as such. The is_deploy_iso_required call is actually a method defined elsewhere in the file.","commit_id":"5cd5c7e0b447e8cdb47eed6d852723e6c88e3bc6"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"8c87765c8ae5e37461c07a49c948a5282f62a5b3","unresolved":false,"context_lines":[{"line_number":2614,"context_line":""},{"line_number":2615,"context_line":"        if build_required; then"},{"line_number":2616,"context_line":"            # files don\u0027t exist, need to build them"},{"line_number":2617,"context_line":"            if [ \"$IRONIC_BUILD_DEPLOY_RAMDISK\" \u003d \"True\" ]; then"},{"line_number":2618,"context_line":"                # we can build them only if we\u0027re not offline"},{"line_number":2619,"context_line":"                if [ \"$OFFLINE\" !\u003d \"True\" ]; then"},{"line_number":2620,"context_line":"                    build_ipa_ramdisk $IRONIC_DEPLOY_KERNEL $IRONIC_DEPLOY_RAMDISK $IRONIC_DEPLOY_ISO"}],"source_content_type":"application/x-shellscript","patch_set":19,"id":"3fa7e38b_f30ebee3","line":2617,"range":{"start_line":2617,"start_character":17,"end_line":2617,"end_character":57},"updated":"2019-10-07 21:50:42.000000000","message":"Why not use the existing variable?","commit_id":"5cd5c7e0b447e8cdb47eed6d852723e6c88e3bc6"}]}