)]}'
{"devstack/files/apache-ironic-api-redirect.template":[{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"bd46fb416f8b46f34b77b40e2c2065d0d9fd8d55","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# Ironic API through mod_wsgi.  This version assumes you are"},{"line_number":15,"context_line":"# running devstack to configure the software."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Listen %IRONIC_SERVICE_PORT%"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"\u003cVirtualHost *:%IRONIC_SERVICE_PORT%\u003e"},{"line_number":20,"context_line":"    Redirect 307 / %IRONIC_SERVICE_PROTOCOL%://%IRONIC_SERVICE_HOST%:%IRONIC_SERVICE_PORT%/"}],"source_content_type":"application/octet-stream","patch_set":27,"id":"5ff73747_55ebdeda","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":28},"updated":"2017-04-27 12:31:51.000000000","message":"What happen if we will use path instead of port ?","commit_id":"210bc37830c2f2e9101f4b50b93ac5e2f72a8572"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a5131de2fa5fd0547c2f19dc4cef4e0a5a793b15","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# Ironic API through mod_wsgi.  This version assumes you are"},{"line_number":15,"context_line":"# running devstack to configure the software."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Listen %IRONIC_SERVICE_PORT%"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"\u003cVirtualHost *:%IRONIC_SERVICE_PORT%\u003e"},{"line_number":20,"context_line":"    Redirect 307 / %IRONIC_SERVICE_PROTOCOL%://%IRONIC_SERVICE_HOST%:%IRONIC_SERVICE_PORT%/"}],"source_content_type":"application/octet-stream","patch_set":27,"id":"5ff73747_e8678cb6","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":28},"in_reply_to":"5ff73747_55ebdeda","updated":"2017-04-28 09:13:10.000000000","message":"We do not run ironic under apache in grenade, we will switch to apache in next release. This part will be reworked at that time.","commit_id":"210bc37830c2f2e9101f4b50b93ac5e2f72a8572"}],"devstack/lib/ironic":[{"author":{"_account_id":14760,"name":"John L. Villalovos","email":"openstack.org@sodarock.com","username":"jlvillal"},"change_message_id":"f5ce76411132802b6ddc736097a220424ac56941","unresolved":false,"context_lines":[{"line_number":1712,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"},{"line_number":1713,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1714,"context_line":"        sudo iptables -I INPUT -d $IRONIC_HTTP_SERVER -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1715,"context_line":"        sudo iptables -I FORWARD -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1716,"context_line":"    else"},{"line_number":1717,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport 80 -j ACCEPT || true"},{"line_number":1718,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"7ffa3b31_f4d4f249","line":1715,"updated":"2017-04-21 16:42:07.000000000","message":"A comment about this might be good. Wasn\u0027t immediately obvious to me what this is for.","commit_id":"210bc37830c2f2e9101f4b50b93ac5e2f72a8572"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a5131de2fa5fd0547c2f19dc4cef4e0a5a793b15","unresolved":false,"context_lines":[{"line_number":1712,"context_line":"    if [[ \"$IRONIC_USE_MOD_WSGI\" \u003d\u003d \"False\" ]]; then"},{"line_number":1713,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1714,"context_line":"        sudo iptables -I INPUT -d $IRONIC_HTTP_SERVER -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1715,"context_line":"        sudo iptables -I FORWARD -p tcp --dport $IRONIC_SERVICE_PORT -j ACCEPT || true"},{"line_number":1716,"context_line":"    else"},{"line_number":1717,"context_line":"        sudo iptables -I INPUT -d $HOST_IP -p tcp --dport 80 -j ACCEPT || true"},{"line_number":1718,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":27,"id":"5ff73747_c8d4d022","line":1715,"in_reply_to":"7ffa3b31_f4d4f249","updated":"2017-04-28 09:13:10.000000000","message":"Done","commit_id":"210bc37830c2f2e9101f4b50b93ac5e2f72a8572"}],"devstack/upgrade/upgrade.sh":[{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"712f1d534b4cbec7f1ac91c030909db0cc1710de","unresolved":false,"context_lines":[{"line_number":103,"context_line":"wait_for_keystone"},{"line_number":104,"context_line":"start_nova_compute"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"ensure_services_started $ensure_started"},{"line_number":109,"context_line":"# NOTE(vsaienko) just check that API works, we do not expect any downtime here as service is UP on"}],"source_content_type":"text/x-sh","patch_set":11,"id":"7ffa3b31_4b3edcda","line":106,"updated":"2017-04-18 13:51:19.000000000","message":"nit - redundant empty line.","commit_id":"3689e1e9dddac08218e24cf227faeb7a62ccf330"},{"author":{"_account_id":12356,"name":"Vladyslav Drok","email":"vdrok@mirantis.com","username":"vdrok"},"change_message_id":"712f1d534b4cbec7f1ac91c030909db0cc1710de","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"ensure_services_started $ensure_started"},{"line_number":109,"context_line":"# NOTE(vsaienko) just check that API works, we do not expect any downtime here as service is UP on"},{"line_number":110,"context_line":"# subnode, in case of packet loss we have buil-in retry in ironic client."},{"line_number":111,"context_line":"openstack baremetal node list"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"if [[ -n \"$ensure_stopped\" ]]; then"},{"line_number":114,"context_line":"    ensure_services_stopped $ensure_stopped"}],"source_content_type":"text/x-sh","patch_set":11,"id":"7ffa3b31_8b34e4fc","line":111,"range":{"start_line":109,"start_character":0,"end_line":111,"end_character":29},"updated":"2017-04-18 13:51:19.000000000","message":"Hrm, I\u0027d rather remove this if there is no reason to keep it, we should have checked that the service has started on the previous line.","commit_id":"3689e1e9dddac08218e24cf227faeb7a62ccf330"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"59c7fe6764b93da5d0870c3944142cd0db7c0b9e","unresolved":false,"context_lines":[{"line_number":80,"context_line":"# Don\u0027t succeed unless the services come up"},{"line_number":81,"context_line":"logs_exist\u003d\"ir-cond\""},{"line_number":82,"context_line":"# NOTE(vsaienko) ironic upgrade process has pre-requirement that ironic-conductors should be"},{"line_number":83,"context_line":"# upgraded before ironic-api. Grenade is launched on primary node, where we have ir-api and"},{"line_number":84,"context_line":"# ir-cond runnning. Do not start ir-api on primary node after upgrade to avoid situation when we"},{"line_number":85,"context_line":"# have new ir-api (primary) and old ir-cond (subnode) as it is not allowed by upgrade procedure."},{"line_number":86,"context_line":"# Instead redirect all requests destinied to ir-api on primary node to subnode."}],"source_content_type":"text/x-sh","patch_set":27,"id":"5ff73747_96a7420c","line":83,"updated":"2017-04-26 22:00:45.000000000","message":"s/we have/we have new/","commit_id":"210bc37830c2f2e9101f4b50b93ac5e2f72a8572"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a5131de2fa5fd0547c2f19dc4cef4e0a5a793b15","unresolved":false,"context_lines":[{"line_number":80,"context_line":"# Don\u0027t succeed unless the services come up"},{"line_number":81,"context_line":"logs_exist\u003d\"ir-cond\""},{"line_number":82,"context_line":"# NOTE(vsaienko) ironic upgrade process has pre-requirement that ironic-conductors should be"},{"line_number":83,"context_line":"# upgraded before ironic-api. Grenade is launched on primary node, where we have ir-api and"},{"line_number":84,"context_line":"# ir-cond runnning. Do not start ir-api on primary node after upgrade to avoid situation when we"},{"line_number":85,"context_line":"# have new ir-api (primary) and old ir-cond (subnode) as it is not allowed by upgrade procedure."},{"line_number":86,"context_line":"# Instead redirect all requests destinied to ir-api on primary node to subnode."}],"source_content_type":"text/x-sh","patch_set":27,"id":"5ff73747_28e57409","line":83,"in_reply_to":"5ff73747_96a7420c","updated":"2017-04-28 09:13:10.000000000","message":"Done","commit_id":"210bc37830c2f2e9101f4b50b93ac5e2f72a8572"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"59c7fe6764b93da5d0870c3944142cd0db7c0b9e","unresolved":false,"context_lines":[{"line_number":81,"context_line":"logs_exist\u003d\"ir-cond\""},{"line_number":82,"context_line":"# NOTE(vsaienko) ironic upgrade process has pre-requirement that ironic-conductors should be"},{"line_number":83,"context_line":"# upgraded before ironic-api. Grenade is launched on primary node, where we have ir-api and"},{"line_number":84,"context_line":"# ir-cond runnning. Do not start ir-api on primary node after upgrade to avoid situation when we"},{"line_number":85,"context_line":"# have new ir-api (primary) and old ir-cond (subnode) as it is not allowed by upgrade procedure."},{"line_number":86,"context_line":"# Instead redirect all requests destinied to ir-api on primary node to subnode."},{"line_number":87,"context_line":"if [[ \"$HOST_TOPOLOGY_ROLE\" \u003d\u003d \u0027primary\u0027 ]]; then"}],"source_content_type":"text/x-sh","patch_set":27,"id":"5ff73747_b67b5e79","line":84,"updated":"2017-04-26 22:00:45.000000000","message":"Might just be me cuz I don\u0027t know how grenade works, wondering if it is worth\n\ns/running./running. (Subnode has old ironic api \u0026 conductor services running.)/\n\nOk, I misunderstood something. I think you mean s/ir-cond running/ir-cond installed/.  Basically, primary node has new api \u0026 conductor code installed, and we want conductor running, api not running, and api requests redirected to subnode ir-api.","commit_id":"210bc37830c2f2e9101f4b50b93ac5e2f72a8572"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"59c7fe6764b93da5d0870c3944142cd0db7c0b9e","unresolved":false,"context_lines":[{"line_number":83,"context_line":"# upgraded before ironic-api. Grenade is launched on primary node, where we have ir-api and"},{"line_number":84,"context_line":"# ir-cond runnning. Do not start ir-api on primary node after upgrade to avoid situation when we"},{"line_number":85,"context_line":"# have new ir-api (primary) and old ir-cond (subnode) as it is not allowed by upgrade procedure."},{"line_number":86,"context_line":"# Instead redirect all requests destinied to ir-api on primary node to subnode."},{"line_number":87,"context_line":"if [[ \"$HOST_TOPOLOGY_ROLE\" \u003d\u003d \u0027primary\u0027 ]]; then"},{"line_number":88,"context_line":"    disable_service ir-api"},{"line_number":89,"context_line":"    ensure_stopped+\u003d\u0027ironic-api\u0027"}],"source_content_type":"text/x-sh","patch_set":27,"id":"5ff73747_f629e689","line":86,"updated":"2017-04-26 22:00:45.000000000","message":"nit: s/destinied/destined/\n\nSo that we are testing requests to old ir-api (on subnode), and old ir-api talks to new \u0026 old ir-conductors? (or does old ir-api talk to new ir-conductor on primary node)?\n\nGuess I\u0027m asking for documentation on how the testing is set up!","commit_id":"210bc37830c2f2e9101f4b50b93ac5e2f72a8572"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a5131de2fa5fd0547c2f19dc4cef4e0a5a793b15","unresolved":false,"context_lines":[{"line_number":83,"context_line":"# upgraded before ironic-api. Grenade is launched on primary node, where we have ir-api and"},{"line_number":84,"context_line":"# ir-cond runnning. Do not start ir-api on primary node after upgrade to avoid situation when we"},{"line_number":85,"context_line":"# have new ir-api (primary) and old ir-cond (subnode) as it is not allowed by upgrade procedure."},{"line_number":86,"context_line":"# Instead redirect all requests destinied to ir-api on primary node to subnode."},{"line_number":87,"context_line":"if [[ \"$HOST_TOPOLOGY_ROLE\" \u003d\u003d \u0027primary\u0027 ]]; then"},{"line_number":88,"context_line":"    disable_service ir-api"},{"line_number":89,"context_line":"    ensure_stopped+\u003d\u0027ironic-api\u0027"}],"source_content_type":"text/x-sh","patch_set":27,"id":"5ff73747_0b6192d3","line":86,"in_reply_to":"5ff73747_f629e689","updated":"2017-04-28 09:13:10.000000000","message":"rephrase this.","commit_id":"210bc37830c2f2e9101f4b50b93ac5e2f72a8572"},{"author":{"_account_id":23330,"name":"Oksana Voshchana","email":"anascko@gmail.com","username":"Oksana"},"change_message_id":"bd46fb416f8b46f34b77b40e2c2065d0d9fd8d55","unresolved":false,"context_lines":[{"line_number":85,"context_line":"# have new ir-api (primary) and old ir-cond (subnode) as it is not allowed by upgrade procedure."},{"line_number":86,"context_line":"# Instead redirect all requests destinied to ir-api on primary node to subnode."},{"line_number":87,"context_line":"if [[ \"$HOST_TOPOLOGY_ROLE\" \u003d\u003d \u0027primary\u0027 ]]; then"},{"line_number":88,"context_line":"    disable_service ir-api"},{"line_number":89,"context_line":"    ensure_stopped+\u003d\u0027ironic-api\u0027"},{"line_number":90,"context_line":"    ironic_apache_conf\u003d$(apache_site_config_for ironic-api-redirect)"},{"line_number":91,"context_line":"    sudo cp $IRONIC_DEVSTACK_FILES_DIR/apache-ironic-api-redirect.template $ironic_apache_conf"}],"source_content_type":"text/x-sh","patch_set":27,"id":"5ff73747_75bdba00","line":88,"range":{"start_line":88,"start_character":4,"end_line":88,"end_character":26},"updated":"2017-04-27 12:31:51.000000000","message":"Need we in this step remove apache config for ironic if ir-api was running under wsgi?","commit_id":"210bc37830c2f2e9101f4b50b93ac5e2f72a8572"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"a5131de2fa5fd0547c2f19dc4cef4e0a5a793b15","unresolved":false,"context_lines":[{"line_number":85,"context_line":"# have new ir-api (primary) and old ir-cond (subnode) as it is not allowed by upgrade procedure."},{"line_number":86,"context_line":"# Instead redirect all requests destinied to ir-api on primary node to subnode."},{"line_number":87,"context_line":"if [[ \"$HOST_TOPOLOGY_ROLE\" \u003d\u003d \u0027primary\u0027 ]]; then"},{"line_number":88,"context_line":"    disable_service ir-api"},{"line_number":89,"context_line":"    ensure_stopped+\u003d\u0027ironic-api\u0027"},{"line_number":90,"context_line":"    ironic_apache_conf\u003d$(apache_site_config_for ironic-api-redirect)"},{"line_number":91,"context_line":"    sudo cp $IRONIC_DEVSTACK_FILES_DIR/apache-ironic-api-redirect.template $ironic_apache_conf"}],"source_content_type":"text/x-sh","patch_set":27,"id":"5ff73747_6ba7f60c","line":88,"range":{"start_line":88,"start_character":4,"end_line":88,"end_character":26},"in_reply_to":"5ff73747_75bdba00","updated":"2017-04-28 09:13:10.000000000","message":"please see my previous reply.","commit_id":"210bc37830c2f2e9101f4b50b93ac5e2f72a8572"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"cdf1be08e7bfc95516dd85479daf48359b16f7ff","unresolved":false,"context_lines":[{"line_number":84,"context_line":"# node and not upgraded (old) services on subnode."},{"line_number":85,"context_line":"# According to Ironic upgrade procedure, we shouldn\u0027t have upgraded (new) ironic-api and not upgraded (old)"},{"line_number":86,"context_line":"# ironic-conductor. By setting redirect of API requests from primary node to subnode during upgrade"},{"line_number":87,"context_line":"# allow to satisfy ironic upgrade requirements."},{"line_number":88,"context_line":"if [[ \"$HOST_TOPOLOGY_ROLE\" \u003d\u003d \u0027primary\u0027 ]]; then"},{"line_number":89,"context_line":"    disable_service ir-api"},{"line_number":90,"context_line":"    ensure_stopped+\u003d\u0027ironic-api\u0027"}],"source_content_type":"text/x-sh","patch_set":29,"id":"5ff73747_98b02ddf","line":87,"updated":"2017-05-02 17:35:35.000000000","message":"So the testing set up is:\n\n1. no new ironic-api\n2. API requests to primary node are redirected to old ironic-api\n3. new ironic-conductor, pinned to old release\n4. old ironic-conductor\n\nHow do we control which API requests via (old) ironic-api, go to new vs old ironic-conductor? I don\u0027t think we can (or at least, not with the existing testing setup.) But I guess that\u0027s outside the scope of this patch.","commit_id":"fdf6f89a231870fc230c4b15caf098be34d498f1"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"cdf1be08e7bfc95516dd85479daf48359b16f7ff","unresolved":false,"context_lines":[{"line_number":87,"context_line":"# allow to satisfy ironic upgrade requirements."},{"line_number":88,"context_line":"if [[ \"$HOST_TOPOLOGY_ROLE\" \u003d\u003d \u0027primary\u0027 ]]; then"},{"line_number":89,"context_line":"    disable_service ir-api"},{"line_number":90,"context_line":"    ensure_stopped+\u003d\u0027ironic-api\u0027"},{"line_number":91,"context_line":"    ironic_apache_conf\u003d$(apache_site_config_for ironic-api-redirect)"},{"line_number":92,"context_line":"    sudo cp $IRONIC_DEVSTACK_FILES_DIR/apache-ironic-api-redirect.template $ironic_apache_conf"},{"line_number":93,"context_line":"    sudo sed -e \""}],"source_content_type":"text/x-sh","patch_set":29,"id":"5ff73747_38259909","line":90,"updated":"2017-05-02 17:35:35.000000000","message":"nit, for consistency, looks like this should have blank space at the end.","commit_id":"fdf6f89a231870fc230c4b15caf098be34d498f1"}]}
