)]}'
{"ironic/drivers/modules/ssh.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e5037dd9bea2191201afdc11ca7d5e7c69cc81ed","unresolved":false,"context_lines":[{"line_number":588,"context_line":"    the value of that property."},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"    This functionality is required because VirtualBox does not"},{"line_number":591,"context_line":"    support setting the boot device while the node is active."},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"    This function should be called when the node is powered off."},{"line_number":594,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_e264d7bb","line":591,"range":{"start_line":591,"start_character":54,"end_line":591,"end_character":60},"updated":"2017-04-17 03:44:10.000000000","message":"s/ \u0027active\u0027 /\u0027in powered on state\u0027\n\nNode being \u0027active\u0027 has a different meaning in Ironic as \u0027active\u0027 is an Ironic state.","commit_id":"9308f4493e51010c0758baa32c819c3cefd8e46a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e5037dd9bea2191201afdc11ca7d5e7c69cc81ed","unresolved":false,"context_lines":[{"line_number":600,"context_line":"    device \u003d driver_internal_info.pop(\u0027vbox_target_boot_device\u0027, None)"},{"line_number":601,"context_line":"    if device is not None:"},{"line_number":602,"context_line":"        task.driver.management.set_boot_device(task, device)"},{"line_number":603,"context_line":"        node.driver_internal_info \u003d driver_internal_info"},{"line_number":604,"context_line":"        node.save()"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"def _vbox_store_target_boot_device(node, device):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_226abf7f","line":604,"range":{"start_line":603,"start_character":8,"end_line":604,"end_character":19},"updated":"2017-04-17 03:44:10.000000000","message":"This is not required as you are not changing node.driver_internal_info.\nDo you mean to clear node.driver_internal_info[\u0027vbox_target_boot_device\u0027] and then save it?","commit_id":"9308f4493e51010c0758baa32c819c3cefd8e46a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"e5037dd9bea2191201afdc11ca7d5e7c69cc81ed","unresolved":false,"context_lines":[{"line_number":611,"context_line":"    typically when the node is next powered on."},{"line_number":612,"context_line":""},{"line_number":613,"context_line":"    This functionality is required because VirtualBox does not"},{"line_number":614,"context_line":"    support setting the boot device while the node is active."},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"    :param node: the Node of interest."},{"line_number":617,"context_line":"    :param device: the boot device."}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_e20977dd","line":614,"range":{"start_line":614,"start_character":54,"end_line":614,"end_character":60},"updated":"2017-04-17 03:44:10.000000000","message":"ditto","commit_id":"9308f4493e51010c0758baa32c819c3cefd8e46a"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"55ef19272ea54e5721e85a2308f3a8ad482e1353","unresolved":false,"context_lines":[{"line_number":601,"context_line":"    device \u003d driver_internal_info.pop(\u0027vbox_target_boot_device\u0027, None)"},{"line_number":602,"context_line":"    if device is not None:"},{"line_number":603,"context_line":"        task.driver.management.set_boot_device(task, device)"},{"line_number":604,"context_line":"        node.save()"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"def _vbox_store_target_boot_device(node, device):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_abec5129","line":604,"range":{"start_line":604,"start_character":8,"end_line":604,"end_character":19},"updated":"2017-04-18 02:21:48.000000000","message":"Your code in patch set 2 was right. You were doing driver_internal_info.pop() My mistake, I misread it as driver_internal_info.get(). Please put back code as in patch set 2.\n\nnode.driver_internal_info \u003d driver_internal_info\nnode.save()","commit_id":"681c33ef8f630d875a4d9ed53fa6c0005b6c1e49"}]}