)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"f8029e9372523c2cb3719d800b83c6b7abd8152d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, VirtualPDU uses \u0027libvirtd\u0027 group, which errors since this"},{"line_number":10,"context_line":"group is not used anymore on ubuntu because we now use the same group"},{"line_number":11,"context_line":"that debian uses \u0027libvirt\u0027."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This commit change the used group to \u0027libvirt\u0027. This is the right group"},{"line_number":14,"context_line":"and it\u0027s allowed to do changes on virsh."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5ff73747_d6028fb4","line":11,"range":{"start_line":11,"start_character":16,"end_line":11,"end_character":17},"updated":"2017-04-26 02:18:01.000000000","message":"\u0027s/ / i.e. \u0027","commit_id":"7c265a5eac5c37bea7b3ac036177204e487ec2c4"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"f8029e9372523c2cb3719d800b83c6b7abd8152d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"that debian uses \u0027libvirt\u0027."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This commit change the used group to \u0027libvirt\u0027. This is the right group"},{"line_number":14,"context_line":"and it\u0027s allowed to do changes on virsh."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"I would rather use LIBVIRT_GROUP however a bug in the selection logic"},{"line_number":17,"context_line":"sets it to \u0027libvirtd\u0027 group as soon as it exists, even if both exists."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5ff73747_5628bf32","line":14,"range":{"start_line":14,"start_character":20,"end_line":14,"end_character":22},"updated":"2017-04-26 02:18:01.000000000","message":"s/do/make","commit_id":"7c265a5eac5c37bea7b3ac036177204e487ec2c4"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"840df7ff87d0e06c9ecd9c2391ac87477f563769","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This commit change the used group to \u0027libvirt\u0027. This is the right group"},{"line_number":14,"context_line":"and it\u0027s allowed to do changes on virsh."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"I would rather use LIBVIRT_GROUP however a bug in the selection logic"},{"line_number":17,"context_line":"sets it to \u0027libvirtd\u0027 group as soon as it exists, even if both exists."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Iddb61356b8a92184ca60a078ea9d929e5b51e629"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5ff73747_278bac1f","line":16,"updated":"2017-04-26 13:44:43.000000000","message":"Did you file a bug for this?","commit_id":"7c265a5eac5c37bea7b3ac036177204e487ec2c4"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"f8029e9372523c2cb3719d800b83c6b7abd8152d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"and it\u0027s allowed to do changes on virsh."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"I would rather use LIBVIRT_GROUP however a bug in the selection logic"},{"line_number":17,"context_line":"sets it to \u0027libvirtd\u0027 group as soon as it exists, even if both exists."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Iddb61356b8a92184ca60a078ea9d929e5b51e629"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5ff73747_96d3e738","line":17,"range":{"start_line":17,"start_character":63,"end_line":17,"end_character":69},"updated":"2017-04-26 02:18:01.000000000","message":"s/exists/exist","commit_id":"7c265a5eac5c37bea7b3ac036177204e487ec2c4"}],"devstack/lib/ironic":[{"author":{"_account_id":20902,"name":"Félix Bouliane","email":"fbouliane@inap.com","username":"fbouliane"},"change_message_id":"9ab11d0a16e6bf030640ce9a0e063ca8ac97540f","unresolved":false,"context_lines":[{"line_number":1244,"context_line":""},{"line_number":1245,"context_line":"# Starts VirtualPDU"},{"line_number":1246,"context_line":"function start_virtualpdu {"},{"line_number":1247,"context_line":"    run_process ir-vpdu \"virtualpdu $IRONIC_VPDU_CONFIG_FILE\" ${LIBVIRT_GROUP}"},{"line_number":1248,"context_line":"}"},{"line_number":1249,"context_line":""},{"line_number":1250,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"7ffa3b31_16c27b34","line":1247,"range":{"start_line":1247,"start_character":64,"end_line":1247,"end_character":77},"updated":"2017-04-14 20:19:37.000000000","message":"not sure if I should use STACK_USER instead ...","commit_id":"d007ec4b53673b5013c7ccef2026c4d06bb83122"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"9f484e50d9e47753621d9e113c71f1bf51457992","unresolved":false,"context_lines":[{"line_number":1244,"context_line":""},{"line_number":1245,"context_line":"# Starts VirtualPDU"},{"line_number":1246,"context_line":"function start_virtualpdu {"},{"line_number":1247,"context_line":"    run_process ir-vpdu \"virtualpdu $IRONIC_VPDU_CONFIG_FILE\" ${STACK_USER}"},{"line_number":1248,"context_line":"}"},{"line_number":1249,"context_line":""},{"line_number":1250,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7ffa3b31_429eeb63","line":1247,"range":{"start_line":1247,"start_character":64,"end_line":1247,"end_character":74},"updated":"2017-04-17 03:48:31.000000000","message":"It should be prefixed with \u0027IRONIC\u0027 so user could know that this variable is being used by Ironic plugin.\n\nSince we do not use this anywhere else in the stack. Would it be better to name it something like IRONIC_VPDU_USER?","commit_id":"6df867b7a35c036924ea4cf7bce31c386a0d7658"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a3131b0dff1d36981402addef2f92ea9994bc3bc","unresolved":false,"context_lines":[{"line_number":1244,"context_line":""},{"line_number":1245,"context_line":"# Starts VirtualPDU"},{"line_number":1246,"context_line":"function start_virtualpdu {"},{"line_number":1247,"context_line":"    run_process ir-vpdu \"virtualpdu $IRONIC_VPDU_CONFIG_FILE\" ${STACK_USER}"},{"line_number":1248,"context_line":"}"},{"line_number":1249,"context_line":""},{"line_number":1250,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7ffa3b31_bfdfdad4","line":1247,"range":{"start_line":1247,"start_character":64,"end_line":1247,"end_character":74},"in_reply_to":"7ffa3b31_429eeb63","updated":"2017-04-18 15:14:52.000000000","message":"@Shiv, if you look elsewhere, you\u0027ll see ${STACK_USER} being used, eg L808 and L974.\n\nWhat I am not sure of, is whether ${STACK_USER} is better than ${LIBVIRT_GROUP}.","commit_id":"6df867b7a35c036924ea4cf7bce31c386a0d7658"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"2080f9fe8018824f6859fb7ebc48c003c0889c5b","unresolved":false,"context_lines":[{"line_number":1244,"context_line":""},{"line_number":1245,"context_line":"# Starts VirtualPDU"},{"line_number":1246,"context_line":"function start_virtualpdu {"},{"line_number":1247,"context_line":"    run_process ir-vpdu \"virtualpdu $IRONIC_VPDU_CONFIG_FILE\" ${STACK_USER}"},{"line_number":1248,"context_line":"}"},{"line_number":1249,"context_line":""},{"line_number":1250,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7ffa3b31_3ab518ce","line":1247,"range":{"start_line":1247,"start_character":64,"end_line":1247,"end_character":74},"in_reply_to":"7ffa3b31_9aa1ccac","updated":"2017-04-18 15:30:42.000000000","message":"infra update libvirt recently and new libvirt uses another group libivrtd. I think here you should pick LIBVIRT_GROUP automatically like it done\n\nhttps://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L960-L971","commit_id":"6df867b7a35c036924ea4cf7bce31c386a0d7658"},{"author":{"_account_id":20902,"name":"Félix Bouliane","email":"fbouliane@inap.com","username":"fbouliane"},"change_message_id":"9ab0cce0940f7402fd27041632437847765714b8","unresolved":false,"context_lines":[{"line_number":1244,"context_line":""},{"line_number":1245,"context_line":"# Starts VirtualPDU"},{"line_number":1246,"context_line":"function start_virtualpdu {"},{"line_number":1247,"context_line":"    run_process ir-vpdu \"virtualpdu $IRONIC_VPDU_CONFIG_FILE\" ${STACK_USER}"},{"line_number":1248,"context_line":"}"},{"line_number":1249,"context_line":""},{"line_number":1250,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7ffa3b31_9aa1ccac","line":1247,"range":{"start_line":1247,"start_character":64,"end_line":1247,"end_character":74},"in_reply_to":"7ffa3b31_9ad30c39","updated":"2017-04-18 15:27:51.000000000","message":"sorry, typo, I meant LIBVIRT_GROUP.","commit_id":"6df867b7a35c036924ea4cf7bce31c386a0d7658"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"c134b056dabe825a025d707a45fd95db99b200a9","unresolved":false,"context_lines":[{"line_number":1244,"context_line":""},{"line_number":1245,"context_line":"# Starts VirtualPDU"},{"line_number":1246,"context_line":"function start_virtualpdu {"},{"line_number":1247,"context_line":"    run_process ir-vpdu \"virtualpdu $IRONIC_VPDU_CONFIG_FILE\" ${STACK_USER}"},{"line_number":1248,"context_line":"}"},{"line_number":1249,"context_line":""},{"line_number":1250,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7ffa3b31_9ad30c39","line":1247,"range":{"start_line":1247,"start_character":64,"end_line":1247,"end_character":74},"in_reply_to":"7ffa3b31_9f63fe1a","updated":"2017-04-18 15:26:15.000000000","message":"Discussed briefly with vdrok, he thinks LIBVIRT_GROUP would be better than STACK_USER (which is more in line with what was there originally).\n\nI did a quick grep, don\u0027t see LIBVIRT_USER defined/used anywhere. Did you try LIBVIRT_GROUP?","commit_id":"6df867b7a35c036924ea4cf7bce31c386a0d7658"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"2080f9fe8018824f6859fb7ebc48c003c0889c5b","unresolved":false,"context_lines":[{"line_number":1244,"context_line":""},{"line_number":1245,"context_line":"# Starts VirtualPDU"},{"line_number":1246,"context_line":"function start_virtualpdu {"},{"line_number":1247,"context_line":"    run_process ir-vpdu \"virtualpdu $IRONIC_VPDU_CONFIG_FILE\" ${STACK_USER}"},{"line_number":1248,"context_line":"}"},{"line_number":1249,"context_line":""},{"line_number":1250,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7ffa3b31_3af638fb","line":1247,"range":{"start_line":1247,"start_character":64,"end_line":1247,"end_character":74},"in_reply_to":"7ffa3b31_9f63fe1a","updated":"2017-04-18 15:30:42.000000000","message":"please don\u0027t use hardcoded libvirt group name it should be picked automatically. https://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L960-L968","commit_id":"6df867b7a35c036924ea4cf7bce31c386a0d7658"},{"author":{"_account_id":20902,"name":"Félix Bouliane","email":"fbouliane@inap.com","username":"fbouliane"},"change_message_id":"cc9399777454c4a137357f4d319f19860a55b898","unresolved":false,"context_lines":[{"line_number":1244,"context_line":""},{"line_number":1245,"context_line":"# Starts VirtualPDU"},{"line_number":1246,"context_line":"function start_virtualpdu {"},{"line_number":1247,"context_line":"    run_process ir-vpdu \"virtualpdu $IRONIC_VPDU_CONFIG_FILE\" ${STACK_USER}"},{"line_number":1248,"context_line":"}"},{"line_number":1249,"context_line":""},{"line_number":1250,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7ffa3b31_9f63fe1a","line":1247,"range":{"start_line":1247,"start_character":64,"end_line":1247,"end_character":74},"in_reply_to":"7ffa3b31_bfdfdad4","updated":"2017-04-18 15:17:12.000000000","message":"IMO it should be LIBVIRT_USER, but it doesn\u0027t seems to work. Im still trying to figure out what the bug is (gate failing).","commit_id":"6df867b7a35c036924ea4cf7bce31c386a0d7658"},{"author":{"_account_id":7080,"name":"Mathieu Mitchell","email":"mat128@gmail.com","username":"mat128"},"change_message_id":"9933ea49d3427b46775af8423bb4438eeb5b2b02","unresolved":false,"context_lines":[{"line_number":1244,"context_line":""},{"line_number":1245,"context_line":"# Starts VirtualPDU"},{"line_number":1246,"context_line":"function start_virtualpdu {"},{"line_number":1247,"context_line":"    run_process ir-vpdu \"virtualpdu $IRONIC_VPDU_CONFIG_FILE\" libvirt"},{"line_number":1248,"context_line":"}"},{"line_number":1249,"context_line":""},{"line_number":1250,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"7ffa3b31_84e5e3aa","line":1247,"updated":"2017-04-18 22:59:15.000000000","message":"This seems reasonable unless there was an easy way to retrieve the libvirt user/group.","commit_id":"7c265a5eac5c37bea7b3ac036177204e487ec2c4"}]}