)]}'
{"ironic_tempest_plugin/services/baremetal/v1/json/baremetal_client.py":[{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"d53f75d4bf71d6134f13c4c222bae9832acfea35","unresolved":false,"context_lines":[{"line_number":323,"context_line":"                                 target)"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    @base.handle_errors"},{"line_number":326,"context_line":"    def set_node_provision_state(self, node_uuid, state, optional\u003dNone):"},{"line_number":327,"context_line":"        \"\"\"Set provision state of the specified node."},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"        :param node_uuid: The unique identifier of the node."}],"source_content_type":"text/x-python","patch_set":1,"id":"7ffa3b31_368a73be","line":326,"range":{"start_line":326,"start_character":57,"end_line":326,"end_character":65},"updated":"2017-04-21 06:26:45.000000000","message":"why is this change required?","commit_id":"e124d8292b60d5140df88c4cd59f9a66050d6b93"}],"ironic_tempest_plugin/tests/scenario/baremetal_standalone_manager.py":[{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"6f6dbb29f0d6fee9b0ae1316c3ebe1dfa7426782","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        else:"},{"line_number":294,"context_line":"            self.assertNotIn(expected, result)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def check_manual_cleaning(self, node, clean_steps):"},{"line_number":297,"context_line":"        \"\"\"Performs manual cleaning"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        The following actions are executed:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5ff73747_d5f67b5d","line":296,"updated":"2017-05-01 16:55:28.000000000","message":"Now, tempest is complaining because you increased the number of arguments needed in the definition. Please refer to http://logs.openstack.org/30/458730/6/check/gate-ironic-dsvm-standalone-ubuntu-xenial/fa722ec/console.html.gz. And I don\u0027t understand why you have to update an existing test and not create a new test for this?","commit_id":"6a9774529ee263141a964320422b50e6860914d2"},{"author":{"_account_id":22977,"name":"Anshul Jain","email":"theanshuljain@gmail.com","username":"jaianshu"},"change_message_id":"c97e1f592830b85abc3947594bf97a0aa7694041","unresolved":false,"context_lines":[{"line_number":293,"context_line":"        else:"},{"line_number":294,"context_line":"            self.assertNotIn(expected, result)"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"    def check_manual_cleaning(self, node, clean_steps):"},{"line_number":297,"context_line":"        \"\"\"Performs manual cleaning"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        The following actions are executed:"}],"source_content_type":"text/x-python","patch_set":6,"id":"ff82abbf_35d26629","line":296,"in_reply_to":"5ff73747_d5f67b5d","updated":"2017-11-29 11:43:18.000000000","message":"this is now part of parent patch..let me do a recheck and get latest data. Thanks.","commit_id":"6a9774529ee263141a964320422b50e6860914d2"}],"ironic_tempest_plugin/tests/scenario/test_baremetal_advanced_ops.py":[{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4394dd920782381dd45236749048828ce4c7ee3a","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from ironic_tempest_plugin.services.baremetal import base"},{"line_number":21,"context_line":"from ironic_tempest_plugin.tests.scenario import baremetal_manager as bm"},{"line_number":22,"context_line":"from ironic_tempest_plugin.tests.scenario import baremetal_standalone_manager as bsm"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":"CONF \u003d config.CONF"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_76d5fb42","line":22,"updated":"2017-04-26 02:15:18.000000000","message":"Line too long and that is why pep8 is complaining. Line should be less than 80 characters.","commit_id":"c12f606cfeae69888159bd972bc4c69884979ec7"},{"author":{"_account_id":22977,"name":"Anshul Jain","email":"theanshuljain@gmail.com","username":"jaianshu"},"change_message_id":"148e0621c84383cef70dd2626f3368002dc8e76e","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from ironic_tempest_plugin.services.baremetal import base"},{"line_number":21,"context_line":"from ironic_tempest_plugin.tests.scenario import baremetal_manager as bm"},{"line_number":22,"context_line":"from ironic_tempest_plugin.tests.scenario import baremetal_standalone_manager as bsm"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":"CONF \u003d config.CONF"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_3c507132","line":22,"in_reply_to":"5ff73747_76d5fb42","updated":"2017-04-26 08:54:46.000000000","message":"Done","commit_id":"c12f606cfeae69888159bd972bc4c69884979ec7"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4394dd920782381dd45236749048828ce4c7ee3a","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":"CONF \u003d config.CONF"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class TestRaidConfig(bsm.BaremetalStandaloneManager,"},{"line_number":28,"context_line":"                     bm.BaremetalScenarioTest"},{"line_number":29,"context_line":"                    ):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_565afff2","line":26,"updated":"2017-04-26 02:15:18.000000000","message":"Expected 2 blank lines. That is why pep8 is complaining.","commit_id":"c12f606cfeae69888159bd972bc4c69884979ec7"},{"author":{"_account_id":22977,"name":"Anshul Jain","email":"theanshuljain@gmail.com","username":"jaianshu"},"change_message_id":"148e0621c84383cef70dd2626f3368002dc8e76e","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":"CONF \u003d config.CONF"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class TestRaidConfig(bsm.BaremetalStandaloneManager,"},{"line_number":28,"context_line":"                     bm.BaremetalScenarioTest"},{"line_number":29,"context_line":"                    ):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_dc606d04","line":26,"in_reply_to":"5ff73747_565afff2","updated":"2017-04-26 08:54:46.000000000","message":"Done","commit_id":"c12f606cfeae69888159bd972bc4c69884979ec7"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4394dd920782381dd45236749048828ce4c7ee3a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"class TestRaidConfig(bsm.BaremetalStandaloneManager,"},{"line_number":28,"context_line":"                     bm.BaremetalScenarioTest"},{"line_number":29,"context_line":"                    ):"},{"line_number":30,"context_line":"    \"\"\" The test aims to verify the raid configuration performed to the node as part of cleaning."},{"line_number":31,"context_line":"    The following steps are followed as part of testing:"},{"line_number":32,"context_line":"        * Pick a random available node."},{"line_number":33,"context_line":"        * Assign the raid configuration to the selected node"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_16747767","line":30,"updated":"2017-04-26 02:15:18.000000000","message":"Line too long and that is why pep8 is complaining. Line should be less than 80 characters.","commit_id":"c12f606cfeae69888159bd972bc4c69884979ec7"},{"author":{"_account_id":22977,"name":"Anshul Jain","email":"theanshuljain@gmail.com","username":"jaianshu"},"change_message_id":"148e0621c84383cef70dd2626f3368002dc8e76e","unresolved":false,"context_lines":[{"line_number":27,"context_line":"class TestRaidConfig(bsm.BaremetalStandaloneManager,"},{"line_number":28,"context_line":"                     bm.BaremetalScenarioTest"},{"line_number":29,"context_line":"                    ):"},{"line_number":30,"context_line":"    \"\"\" The test aims to verify the raid configuration performed to the node as part of cleaning."},{"line_number":31,"context_line":"    The following steps are followed as part of testing:"},{"line_number":32,"context_line":"        * Pick a random available node."},{"line_number":33,"context_line":"        * Assign the raid configuration to the selected node"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_bc5b6152","line":30,"in_reply_to":"5ff73747_16747767","updated":"2017-04-26 08:54:46.000000000","message":"Done","commit_id":"c12f606cfeae69888159bd972bc4c69884979ec7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"680bc5327c5f84c8c6456b91476533e0e534fb3b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        * Perform cleaning with assigned raid configuration"},{"line_number":35,"context_line":"        * Verify the raid configuration"},{"line_number":36,"context_line":"        * Bring back the node to available state"},{"line_number":37,"context_line":"    NOTE: proliant-utils should be part of your deploy image for inband raid config."},{"line_number":38,"context_line":"    \"\"\""},{"line_number":39,"context_line":"    def get_storage_details(self, node_uuid):"},{"line_number":40,"context_line":"        node_details \u003d self.get_node(node_uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_91bf95fa","line":37,"range":{"start_line":37,"start_character":10,"end_line":37,"end_character":24},"updated":"2017-04-25 08:45:57.000000000","message":"s/proliant-utils/proliantutils\nproliantutils is specific to ilo drivers/HPE proliant hardwares. DRAC may have different hardware manager.\nrather you can say, the RAID hardware manager should be part of the deploy ramdisk/iso. For Example: for HPE proliant hardwares, proliantutils needs to be part of the deplot ramdisk/iso.","commit_id":"c12f606cfeae69888159bd972bc4c69884979ec7"},{"author":{"_account_id":22977,"name":"Anshul Jain","email":"theanshuljain@gmail.com","username":"jaianshu"},"change_message_id":"148e0621c84383cef70dd2626f3368002dc8e76e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        * Perform cleaning with assigned raid configuration"},{"line_number":35,"context_line":"        * Verify the raid configuration"},{"line_number":36,"context_line":"        * Bring back the node to available state"},{"line_number":37,"context_line":"    NOTE: proliant-utils should be part of your deploy image for inband raid config."},{"line_number":38,"context_line":"    \"\"\""},{"line_number":39,"context_line":"    def get_storage_details(self, node_uuid):"},{"line_number":40,"context_line":"        node_details \u003d self.get_node(node_uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_2cd7444e","line":37,"range":{"start_line":37,"start_character":10,"end_line":37,"end_character":24},"in_reply_to":"5ff73747_91bf95fa","updated":"2017-04-26 08:54:46.000000000","message":"Done","commit_id":"c12f606cfeae69888159bd972bc4c69884979ec7"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4394dd920782381dd45236749048828ce4c7ee3a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        * Perform cleaning with assigned raid configuration"},{"line_number":35,"context_line":"        * Verify the raid configuration"},{"line_number":36,"context_line":"        * Bring back the node to available state"},{"line_number":37,"context_line":"    NOTE: proliant-utils should be part of your deploy image for inband raid config."},{"line_number":38,"context_line":"    \"\"\""},{"line_number":39,"context_line":"    def get_storage_details(self, node_uuid):"},{"line_number":40,"context_line":"        node_details \u003d self.get_node(node_uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_f66eab94","line":37,"range":{"start_line":37,"start_character":10,"end_line":37,"end_character":24},"in_reply_to":"5ff73747_91bf95fa","updated":"2017-04-26 02:15:18.000000000","message":"Line too long and that is why pep8 is complaining. Line should be less than 80 characters.","commit_id":"c12f606cfeae69888159bd972bc4c69884979ec7"},{"author":{"_account_id":22977,"name":"Anshul Jain","email":"theanshuljain@gmail.com","username":"jaianshu"},"change_message_id":"148e0621c84383cef70dd2626f3368002dc8e76e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        * Perform cleaning with assigned raid configuration"},{"line_number":35,"context_line":"        * Verify the raid configuration"},{"line_number":36,"context_line":"        * Bring back the node to available state"},{"line_number":37,"context_line":"    NOTE: proliant-utils should be part of your deploy image for inband raid config."},{"line_number":38,"context_line":"    \"\"\""},{"line_number":39,"context_line":"    def get_storage_details(self, node_uuid):"},{"line_number":40,"context_line":"        node_details \u003d self.get_node(node_uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_5c321d12","line":37,"range":{"start_line":37,"start_character":10,"end_line":37,"end_character":24},"in_reply_to":"5ff73747_f66eab94","updated":"2017-04-26 08:54:46.000000000","message":"Done","commit_id":"c12f606cfeae69888159bd972bc4c69884979ec7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"680bc5327c5f84c8c6456b91476533e0e534fb3b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        * Verify the raid configuration"},{"line_number":36,"context_line":"        * Bring back the node to available state"},{"line_number":37,"context_line":"    NOTE: proliant-utils should be part of your deploy image for inband raid config."},{"line_number":38,"context_line":"    \"\"\""},{"line_number":39,"context_line":"    def get_storage_details(self, node_uuid):"},{"line_number":40,"context_line":"        node_details \u003d self.get_node(node_uuid)"},{"line_number":41,"context_line":"        storage_info \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_f182594f","line":38,"updated":"2017-04-25 08:45:57.000000000","message":"Add a method to do initial validation for driver. if driver supports raid interface, then only raid tests should be run.","commit_id":"c12f606cfeae69888159bd972bc4c69884979ec7"},{"author":{"_account_id":22977,"name":"Anshul Jain","email":"theanshuljain@gmail.com","username":"jaianshu"},"change_message_id":"148e0621c84383cef70dd2626f3368002dc8e76e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        * Verify the raid configuration"},{"line_number":36,"context_line":"        * Bring back the node to available state"},{"line_number":37,"context_line":"    NOTE: proliant-utils should be part of your deploy image for inband raid config."},{"line_number":38,"context_line":"    \"\"\""},{"line_number":39,"context_line":"    def get_storage_details(self, node_uuid):"},{"line_number":40,"context_line":"        node_details \u003d self.get_node(node_uuid)"},{"line_number":41,"context_line":"        storage_info \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_58ea49ac","line":38,"in_reply_to":"5ff73747_f182594f","updated":"2017-04-26 08:54:46.000000000","message":"done.\nassociated the driver details for the class to be updated for the node.","commit_id":"c12f606cfeae69888159bd972bc4c69884979ec7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"680bc5327c5f84c8c6456b91476533e0e534fb3b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        * Bring back the node to available state"},{"line_number":37,"context_line":"    NOTE: proliant-utils should be part of your deploy image for inband raid config."},{"line_number":38,"context_line":"    \"\"\""},{"line_number":39,"context_line":"    def get_storage_details(self, node_uuid):"},{"line_number":40,"context_line":"        node_details \u003d self.get_node(node_uuid)"},{"line_number":41,"context_line":"        storage_info \u003d {}"},{"line_number":42,"context_line":"        storage_info[\"size_gb\"] \u003d node_details[\"raid_config\"][\"logical_disks\"][0][\"size_gb\"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_b147311e","line":39,"range":{"start_line":39,"start_character":7,"end_line":39,"end_character":28},"updated":"2017-04-25 08:45:57.000000000","message":"s/get_storage_details/get_node_raid_config_details","commit_id":"c12f606cfeae69888159bd972bc4c69884979ec7"},{"author":{"_account_id":22977,"name":"Anshul Jain","email":"theanshuljain@gmail.com","username":"jaianshu"},"change_message_id":"148e0621c84383cef70dd2626f3368002dc8e76e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        * Bring back the node to available state"},{"line_number":37,"context_line":"    NOTE: proliant-utils should be part of your deploy image for inband raid config."},{"line_number":38,"context_line":"    \"\"\""},{"line_number":39,"context_line":"    def get_storage_details(self, node_uuid):"},{"line_number":40,"context_line":"        node_details \u003d self.get_node(node_uuid)"},{"line_number":41,"context_line":"        storage_info \u003d {}"},{"line_number":42,"context_line":"        storage_info[\"size_gb\"] \u003d node_details[\"raid_config\"][\"logical_disks\"][0][\"size_gb\"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_2ca064f4","line":39,"range":{"start_line":39,"start_character":7,"end_line":39,"end_character":28},"in_reply_to":"5ff73747_b147311e","updated":"2017-04-26 08:54:46.000000000","message":"Done","commit_id":"c12f606cfeae69888159bd972bc4c69884979ec7"},{"author":{"_account_id":11878,"name":"Rushil Chugh","email":"rushil.chugh@gmail.com","username":"rushil"},"change_message_id":"4394dd920782381dd45236749048828ce4c7ee3a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def get_storage_details(self, node_uuid):"},{"line_number":40,"context_line":"        node_details \u003d self.get_node(node_uuid)"},{"line_number":41,"context_line":"        storage_info \u003d {}"},{"line_number":42,"context_line":"        storage_info[\"size_gb\"] \u003d node_details[\"raid_config\"][\"logical_disks\"][0][\"size_gb\"]"},{"line_number":43,"context_line":"        storage_info[\"raid_level\"] \u003d node_details[\"raid_config\"][\"logical_disks\"][0][\"raid_level\"]"},{"line_number":44,"context_line":"        storage_info[\"physical_disks\"] \u003d node_details[\"raid_config\"][\"logical_disks\"][0][\"physical_disks\"]"},{"line_number":45,"context_line":"        storage_info[\"number_of_physical_disks\"] \u003d len(storage_info[\"physical_disks\"])"},{"line_number":46,"context_line":"        storage_info[\"disk_type\"] \u003d node_details[\"raid_config\"][\"physical_disks\"][0][\"disk_type\"]"},{"line_number":47,"context_line":"        return storage_info"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def manual_cleaning(self, node, clean_steps\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_76085bd8","line":46,"range":{"start_line":42,"start_character":8,"end_line":46,"end_character":97},"updated":"2017-04-26 02:15:18.000000000","message":"Lines too long and that is why pep8 is complaining. Line should be less than 80 characters.","commit_id":"c12f606cfeae69888159bd972bc4c69884979ec7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"680bc5327c5f84c8c6456b91476533e0e534fb3b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        storage_info \u003d {}"},{"line_number":42,"context_line":"        storage_info[\"size_gb\"] \u003d node_details[\"raid_config\"][\"logical_disks\"][0][\"size_gb\"]"},{"line_number":43,"context_line":"        storage_info[\"raid_level\"] \u003d node_details[\"raid_config\"][\"logical_disks\"][0][\"raid_level\"]"},{"line_number":44,"context_line":"        storage_info[\"physical_disks\"] \u003d node_details[\"raid_config\"][\"logical_disks\"][0][\"physical_disks\"]"},{"line_number":45,"context_line":"        storage_info[\"number_of_physical_disks\"] \u003d len(storage_info[\"physical_disks\"])"},{"line_number":46,"context_line":"        storage_info[\"disk_type\"] \u003d node_details[\"raid_config\"][\"physical_disks\"][0][\"disk_type\"]"},{"line_number":47,"context_line":"        return storage_info"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def manual_cleaning(self, node, clean_steps\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_91c5553f","line":46,"range":{"start_line":44,"start_character":0,"end_line":46,"end_character":97},"updated":"2017-04-25 08:45:57.000000000","message":"we dont assert for these. Possibly you can remove these or add assertion for them.","commit_id":"c12f606cfeae69888159bd972bc4c69884979ec7"},{"author":{"_account_id":22977,"name":"Anshul Jain","email":"theanshuljain@gmail.com","username":"jaianshu"},"change_message_id":"148e0621c84383cef70dd2626f3368002dc8e76e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        storage_info \u003d {}"},{"line_number":42,"context_line":"        storage_info[\"size_gb\"] \u003d node_details[\"raid_config\"][\"logical_disks\"][0][\"size_gb\"]"},{"line_number":43,"context_line":"        storage_info[\"raid_level\"] \u003d node_details[\"raid_config\"][\"logical_disks\"][0][\"raid_level\"]"},{"line_number":44,"context_line":"        storage_info[\"physical_disks\"] \u003d node_details[\"raid_config\"][\"logical_disks\"][0][\"physical_disks\"]"},{"line_number":45,"context_line":"        storage_info[\"number_of_physical_disks\"] \u003d len(storage_info[\"physical_disks\"])"},{"line_number":46,"context_line":"        storage_info[\"disk_type\"] \u003d node_details[\"raid_config\"][\"physical_disks\"][0][\"disk_type\"]"},{"line_number":47,"context_line":"        return storage_info"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def manual_cleaning(self, node, clean_steps\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_6c60accf","line":46,"range":{"start_line":44,"start_character":0,"end_line":46,"end_character":97},"in_reply_to":"5ff73747_91c5553f","updated":"2017-04-26 08:54:46.000000000","message":"removed","commit_id":"c12f606cfeae69888159bd972bc4c69884979ec7"},{"author":{"_account_id":11297,"name":"Nisha Agarwal","email":"agarwalnisha1980@gmail.com","username":"Nisha"},"change_message_id":"680bc5327c5f84c8c6456b91476533e0e534fb3b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        storage_info[\"disk_type\"] \u003d node_details[\"raid_config\"][\"physical_disks\"][0][\"disk_type\"]"},{"line_number":47,"context_line":"        return storage_info"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def manual_cleaning(self, node, clean_steps\u003dNone):"},{"line_number":50,"context_line":"        self.set_node_provision_state(node[\u0027uuid\u0027], \u0027manage\u0027)"},{"line_number":51,"context_line":"        self.wait_provisioning_state("},{"line_number":52,"context_line":"            node[\u0027uuid\u0027],"},{"line_number":53,"context_line":"            [bm.BaremetalProvisionStates.MANAGEABLE],"},{"line_number":54,"context_line":"            timeout\u003dCONF.baremetal.unprovision_timeout,"},{"line_number":55,"context_line":"            interval\u003d30)"},{"line_number":56,"context_line":"        self.set_node_provision_state("},{"line_number":57,"context_line":"            node[\u0027uuid\u0027], \u0027clean\u0027, clean_steps\u003dclean_steps)"},{"line_number":58,"context_line":"        self.wait_provisioning_state("},{"line_number":59,"context_line":"            node[\u0027uuid\u0027],"},{"line_number":60,"context_line":"            [bm.BaremetalProvisionStates.MANAGEABLE],"},{"line_number":61,"context_line":"            timeout\u003dCONF.baremetal.unprovision_timeout*10,"},{"line_number":62,"context_line":"            interval\u003d30)"},{"line_number":63,"context_line":"        self.set_node_provision_state(node[\u0027uuid\u0027], \u0027provide\u0027)"},{"line_number":64,"context_line":"        self.wait_provisioning_state("},{"line_number":65,"context_line":"            node[\u0027uuid\u0027],"},{"line_number":66,"context_line":"            [bm.BaremetalProvisionStates.NOSTATE,"},{"line_number":67,"context_line":"             bm.BaremetalProvisionStates.AVAILABLE],"},{"line_number":68,"context_line":"            timeout\u003dCONF.baremetal.unprovision_timeout,"},{"line_number":69,"context_line":"            interval\u003d30)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def verify_raid_conf(self, node_uuid, verify_raid):"},{"line_number":72,"context_line":"        storage_info \u003d self.get_storage_details(node_uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_51846d5e","line":69,"range":{"start_line":49,"start_character":4,"end_line":69,"end_character":24},"updated":"2017-04-25 08:45:57.000000000","message":"try to use it from parent patch after refactoring the code.","commit_id":"c12f606cfeae69888159bd972bc4c69884979ec7"},{"author":{"_account_id":22977,"name":"Anshul Jain","email":"theanshuljain@gmail.com","username":"jaianshu"},"change_message_id":"148e0621c84383cef70dd2626f3368002dc8e76e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        storage_info[\"disk_type\"] \u003d node_details[\"raid_config\"][\"physical_disks\"][0][\"disk_type\"]"},{"line_number":47,"context_line":"        return storage_info"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def manual_cleaning(self, node, clean_steps\u003dNone):"},{"line_number":50,"context_line":"        self.set_node_provision_state(node[\u0027uuid\u0027], \u0027manage\u0027)"},{"line_number":51,"context_line":"        self.wait_provisioning_state("},{"line_number":52,"context_line":"            node[\u0027uuid\u0027],"},{"line_number":53,"context_line":"            [bm.BaremetalProvisionStates.MANAGEABLE],"},{"line_number":54,"context_line":"            timeout\u003dCONF.baremetal.unprovision_timeout,"},{"line_number":55,"context_line":"            interval\u003d30)"},{"line_number":56,"context_line":"        self.set_node_provision_state("},{"line_number":57,"context_line":"            node[\u0027uuid\u0027], \u0027clean\u0027, clean_steps\u003dclean_steps)"},{"line_number":58,"context_line":"        self.wait_provisioning_state("},{"line_number":59,"context_line":"            node[\u0027uuid\u0027],"},{"line_number":60,"context_line":"            [bm.BaremetalProvisionStates.MANAGEABLE],"},{"line_number":61,"context_line":"            timeout\u003dCONF.baremetal.unprovision_timeout*10,"},{"line_number":62,"context_line":"            interval\u003d30)"},{"line_number":63,"context_line":"        self.set_node_provision_state(node[\u0027uuid\u0027], \u0027provide\u0027)"},{"line_number":64,"context_line":"        self.wait_provisioning_state("},{"line_number":65,"context_line":"            node[\u0027uuid\u0027],"},{"line_number":66,"context_line":"            [bm.BaremetalProvisionStates.NOSTATE,"},{"line_number":67,"context_line":"             bm.BaremetalProvisionStates.AVAILABLE],"},{"line_number":68,"context_line":"            timeout\u003dCONF.baremetal.unprovision_timeout,"},{"line_number":69,"context_line":"            interval\u003d30)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def verify_raid_conf(self, node_uuid, verify_raid):"},{"line_number":72,"context_line":"        storage_info \u003d self.get_storage_details(node_uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ff73747_93fe50ac","line":69,"range":{"start_line":49,"start_character":4,"end_line":69,"end_character":24},"in_reply_to":"5ff73747_51846d5e","updated":"2017-04-26 08:54:46.000000000","message":"refactored it.\nHave updated the upstream function of check_manual_cleaning() also to make it more generic.","commit_id":"c12f606cfeae69888159bd972bc4c69884979ec7"}]}
