)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c9163f53c0aaaf0d83323a2a3e5ebcf10a86dbae","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Start enforcing config variables type in tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Otherwise we will miss changes that will break us once new oslo.config is out."},{"line_number":10,"context_line":"Also fix already merged tests for Redfish."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iffd4c64c495fc3666527b41911a5a07601db7c9b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5ff73747_7e4ab280","line":9,"updated":"2017-04-24 13:49:14.000000000","message":"Nit: long line","commit_id":"3e6303403ba5749121111ce5b6d375883b4a423f"}],"ironic/tests/base.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c9163f53c0aaaf0d83323a2a3e5ebcf10a86dbae","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def config(self, **kw):"},{"line_number":153,"context_line":"        \"\"\"Override config options for a test.\"\"\""},{"line_number":154,"context_line":"        kw.setdefault(\u0027enforce_type\u0027, True)"},{"line_number":155,"context_line":"        self.cfg_fixture.config(**kw)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def set_defaults(self, **kw):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_be35daf9","line":154,"updated":"2017-04-24 13:49:14.000000000","message":"Might be good to indicate why this is important in the code...","commit_id":"3e6303403ba5749121111ce5b6d375883b4a423f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a3b379ec6956125447cb73ee55c9c1d45770e069","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def config(self, **kw):"},{"line_number":153,"context_line":"        \"\"\"Override config options for a test.\"\"\""},{"line_number":154,"context_line":"        kw.setdefault(\u0027enforce_type\u0027, True)"},{"line_number":155,"context_line":"        self.cfg_fixture.config(**kw)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def set_defaults(self, **kw):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_e198626b","line":154,"in_reply_to":"5ff73747_be35daf9","updated":"2017-04-24 14:30:59.000000000","message":"++. We need to get better at commenting because people come and go :-(","commit_id":"3e6303403ba5749121111ce5b6d375883b4a423f"}],"ironic/tests/unit/drivers/modules/redfish/test_utils.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"c9163f53c0aaaf0d83323a2a3e5ebcf10a86dbae","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        fake_conn.get_system.assert_called_once_with("},{"line_number":126,"context_line":"            \u0027/redfish/v1/Systems/FAKESYSTEM\u0027)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    @mock.patch(\u0027time.sleep\u0027, autospec\u003dTrue)"},{"line_number":129,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.redfish.utils.sushy\u0027)"},{"line_number":130,"context_line":"    def test_get_system_resource_connection_error_retry(self, mock_sushy,"},{"line_number":131,"context_line":"                                                        mock_sleep):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_9e6c5e09","line":128,"updated":"2017-04-24 13:49:14.000000000","message":"I guess I\u0027m curious why... but LGTM since it would likely speed testing along some by not actually sleeping.","commit_id":"3e6303403ba5749121111ce5b6d375883b4a423f"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"a3b379ec6956125447cb73ee55c9c1d45770e069","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        fake_conn.get_system.assert_called_once_with("},{"line_number":126,"context_line":"            \u0027/redfish/v1/Systems/FAKESYSTEM\u0027)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    @mock.patch(\u0027time.sleep\u0027, autospec\u003dTrue)"},{"line_number":129,"context_line":"    @mock.patch(\u0027ironic.drivers.modules.redfish.utils.sushy\u0027)"},{"line_number":130,"context_line":"    def test_get_system_resource_connection_error_retry(self, mock_sushy,"},{"line_number":131,"context_line":"                                                        mock_sleep):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_e10d0291","line":128,"in_reply_to":"5ff73747_9e6c5e09","updated":"2017-04-24 14:30:59.000000000","message":"@Julia. We need (should) mock all calls to time in our unit tests, otherwise, the tests will actually wait that amount of time, which as you say, isn\u0027t good.","commit_id":"3e6303403ba5749121111ce5b6d375883b4a423f"}]}
