)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"1a00961f92e3f1bc3d9208ede5a9ea9576988ec8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"in error state in ironic."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I83cef7fafac4e22ebf5eb4fe83f6da26ec132c99"},{"line_number":20,"context_line":"Closes-Bug: #1657892"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ff0f0b1f_d6d3bc37","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":20},"updated":"2017-05-19 04:12:57.000000000","message":"Need to add \"cherry picked from commit 0b23a041f1111ad112d28619fa020173805edbbe\"","commit_id":"dcd14d6f09055a904716771bbb3195c7e5dd1526"},{"author":{"_account_id":20035,"name":"Fellype Cavalcante","email":"fellypefca@lsd.ufcg.edu.br","username":"fellypefca"},"change_message_id":"a94f5cfdf23e69189df20e4fc6b28a5deb682fe1","unresolved":false,"context_lines":[{"line_number":17,"context_line":"in error state in ironic."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I83cef7fafac4e22ebf5eb4fe83f6da26ec132c99"},{"line_number":20,"context_line":"Closes-Bug: #1657892"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ff0f0b1f_64bf88d0","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":20},"in_reply_to":"ff0f0b1f_d6d3bc37","updated":"2017-05-19 14:23:50.000000000","message":"Done","commit_id":"dcd14d6f09055a904716771bbb3195c7e5dd1526"}],"ironic/drivers/modules/oneview/deploy_utils.py":[{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"1ac01b6854323eaa92e550143b50af1ddd25d4bc","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    :param node: an ironic node object"},{"line_number":131,"context_line":"    :returns: Boolean value. True if node is in use by ironic,"},{"line_number":132,"context_line":"              False otherwise."},{"line_number":133,"context_line":"    :raises OneViewError: if not possible to get OneView\u0027s informations"},{"line_number":134,"context_line":"             for the given node, if not possible to retrieve Server Hardware"},{"line_number":135,"context_line":"             from OneView."},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_7385b6ce","line":133,"range":{"start_line":133,"start_character":59,"end_line":133,"end_character":71},"updated":"2017-04-28 05:30:43.000000000","message":"nit: s/informations/information/","commit_id":"16c616d43a33230489321a689135224f495e223c"},{"author":{"_account_id":20035,"name":"Fellype Cavalcante","email":"fellypefca@lsd.ufcg.edu.br","username":"fellypefca"},"change_message_id":"70113c689137cd4736d9ae9e1be3aed7300ab829","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    :param node: an ironic node object"},{"line_number":131,"context_line":"    :returns: Boolean value. True if node is in use by ironic,"},{"line_number":132,"context_line":"              False otherwise."},{"line_number":133,"context_line":"    :raises OneViewError: if not possible to get OneView\u0027s informations"},{"line_number":134,"context_line":"             for the given node, if not possible to retrieve Server Hardware"},{"line_number":135,"context_line":"             from OneView."},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_60310ca3","line":133,"range":{"start_line":133,"start_character":59,"end_line":133,"end_character":71},"in_reply_to":"5ff73747_7385b6ce","updated":"2017-05-02 11:33:11.000000000","message":"Done","commit_id":"16c616d43a33230489321a689135224f495e223c"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"1ac01b6854323eaa92e550143b50af1ddd25d4bc","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    if (server_hardware.server_profile_uri not in (None, \u0027\u0027) and"},{"line_number":163,"context_line":"            applied_sp_uri \u003d\u003d server_hardware.server_profile_uri):"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        LOG.warning(_LW(\"Node %s is in use by ironic.\"),"},{"line_number":166,"context_line":"                    node.uuid)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_93e722ad","line":165,"range":{"start_line":165,"start_character":20,"end_line":165,"end_character":23},"updated":"2017-04-28 05:30:43.000000000","message":"As I know, we don\u0027t use _LW, _LE, _LI in openstack projects anymore. Please see https://bugs.launchpad.net/ironic/+bug/1674374.","commit_id":"16c616d43a33230489321a689135224f495e223c"},{"author":{"_account_id":20035,"name":"Fellype Cavalcante","email":"fellypefca@lsd.ufcg.edu.br","username":"fellypefca"},"change_message_id":"70113c689137cd4736d9ae9e1be3aed7300ab829","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    if (server_hardware.server_profile_uri not in (None, \u0027\u0027) and"},{"line_number":163,"context_line":"            applied_sp_uri \u003d\u003d server_hardware.server_profile_uri):"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        LOG.warning(_LW(\"Node %s is in use by ironic.\"),"},{"line_number":166,"context_line":"                    node.uuid)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_a0fdd4b2","line":165,"range":{"start_line":165,"start_character":20,"end_line":165,"end_character":23},"in_reply_to":"5ff73747_93e722ad","updated":"2017-05-02 11:33:11.000000000","message":"Hi, Dao Cong Tien.\n\nThis patch is a backport to Newton. That change is for Pike patches onwards.","commit_id":"16c616d43a33230489321a689135224f495e223c"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"fc3fea9708b15a5882efc23264a62e981e2b0ebb","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    if (server_hardware.server_profile_uri not in (None, \u0027\u0027) and"},{"line_number":163,"context_line":"            applied_sp_uri \u003d\u003d server_hardware.server_profile_uri):"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        LOG.warning(_LW(\"Node %s is in use by ironic.\"),"},{"line_number":166,"context_line":"                    node.uuid)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_39d578ba","line":165,"range":{"start_line":165,"start_character":20,"end_line":165,"end_character":23},"in_reply_to":"5ff73747_a0fdd4b2","updated":"2017-05-04 03:38:59.000000000","message":"Understood. Thanks.\nBy the way, I think you should not log a message here, just return True/False. I notice in _deallocate_server_hardware_from_ironic() you call this method, and for both cases of In use/Not in use, a warning will be raised. It seems not very reasonable.","commit_id":"16c616d43a33230489321a689135224f495e223c"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"1ac01b6854323eaa92e550143b50af1ddd25d4bc","unresolved":false,"context_lines":[{"line_number":350,"context_line":"            oneview_client.delete_server_profile(server_profile_uuid)"},{"line_number":351,"context_line":"            _del_applied_server_profile_uri_field(node)"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"            LOG.info(_LI(\"Server Profile %(server_profile_uuid)s was deleted \""},{"line_number":354,"context_line":"                         \"from node %(node_uuid)s in OneView.\"),"},{"line_number":355,"context_line":"                     {\u0027server_profile_uuid\u0027: server_profile_uuid,"},{"line_number":356,"context_line":"                      \u0027node_uuid\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_13fb1247","line":353,"range":{"start_line":353,"start_character":21,"end_line":353,"end_character":24},"updated":"2017-04-28 05:30:43.000000000","message":"ditto","commit_id":"16c616d43a33230489321a689135224f495e223c"},{"author":{"_account_id":18320,"name":"Dao Cong Tien","email":"tiendc@vn.fujitsu.com","username":"TienDC"},"change_message_id":"1ac01b6854323eaa92e550143b50af1ddd25d4bc","unresolved":false,"context_lines":[{"line_number":361,"context_line":"            raise exception.OneViewError(error\u003dmsg)"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":"    else:"},{"line_number":364,"context_line":"        LOG.warning(_LW(\"Cannot deallocate node %(node_uuid)s \""},{"line_number":365,"context_line":"                        \"in OneView because it is not in use by \""},{"line_number":366,"context_line":"                        \"ironic.\"), {\u0027node_uuid\u0027: node.uuid})"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_b39b3e16","line":364,"range":{"start_line":364,"start_character":20,"end_line":364,"end_character":23},"updated":"2017-04-28 05:30:43.000000000","message":"ditto","commit_id":"16c616d43a33230489321a689135224f495e223c"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5c765fef4307c7cc89cec998fccda17dba23e437","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    if (server_hardware.server_profile_uri not in (None, \u0027\u0027) and"},{"line_number":163,"context_line":"            applied_sp_uri \u003d\u003d server_hardware.server_profile_uri):"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        LOG.warning(_LW(\"Node %s is in use by ironic.\"),"},{"line_number":166,"context_line":"                    node.uuid)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_f3b8e476","line":165,"range":{"start_line":165,"start_character":20,"end_line":165,"end_character":23},"updated":"2017-05-09 09:48:12.000000000","message":"Remove log translation.\ns/ \u0027_LW\u0027 / /","commit_id":"b94682abc8fa6f0aa00785417e0e7ccf24669e18"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"5c765fef4307c7cc89cec998fccda17dba23e437","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    if (server_hardware.server_profile_uri not in (None, \u0027\u0027) and"},{"line_number":163,"context_line":"            applied_sp_uri \u003d\u003d server_hardware.server_profile_uri):"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        LOG.warning(_LW(\"Node %s is in use by ironic.\"),"},{"line_number":166,"context_line":"                    node.uuid)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_b3b25c93","line":165,"range":{"start_line":165,"start_character":8,"end_line":165,"end_character":19},"updated":"2017-05-09 09:48:12.000000000","message":"Should this be \u0027warning\u0027? may be it can be \u0027info\u0027?","commit_id":"b94682abc8fa6f0aa00785417e0e7ccf24669e18"},{"author":{"_account_id":20035,"name":"Fellype Cavalcante","email":"fellypefca@lsd.ufcg.edu.br","username":"fellypefca"},"change_message_id":"efeeb302070537e23a2946ecfeab6ce3cb74e28b","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    if (server_hardware.server_profile_uri not in (None, \u0027\u0027) and"},{"line_number":163,"context_line":"            applied_sp_uri \u003d\u003d server_hardware.server_profile_uri):"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        LOG.warning(_LW(\"Node %s is in use by ironic.\"),"},{"line_number":166,"context_line":"                    node.uuid)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_99b2e193","line":165,"range":{"start_line":165,"start_character":8,"end_line":165,"end_character":19},"in_reply_to":"3f044301_b3b25c93","updated":"2017-05-09 11:59:43.000000000","message":"Done","commit_id":"b94682abc8fa6f0aa00785417e0e7ccf24669e18"},{"author":{"_account_id":20035,"name":"Fellype Cavalcante","email":"fellypefca@lsd.ufcg.edu.br","username":"fellypefca"},"change_message_id":"efeeb302070537e23a2946ecfeab6ce3cb74e28b","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    if (server_hardware.server_profile_uri not in (None, \u0027\u0027) and"},{"line_number":163,"context_line":"            applied_sp_uri \u003d\u003d server_hardware.server_profile_uri):"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        LOG.warning(_LW(\"Node %s is in use by ironic.\"),"},{"line_number":166,"context_line":"                    node.uuid)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_b9bb5d70","line":165,"range":{"start_line":165,"start_character":20,"end_line":165,"end_character":23},"in_reply_to":"3f044301_f3b8e476","updated":"2017-05-09 11:59:43.000000000","message":"Done","commit_id":"b94682abc8fa6f0aa00785417e0e7ccf24669e18"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"18bac0b00b467f81af346c95b23f570a9ba72741","unresolved":false,"context_lines":[{"line_number":135,"context_line":"             from OneView."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    \"\"\""},{"line_number":138,"context_line":"    oneview_info \u003d common.get_oneview_info(node)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    oneview_client \u003d common.get_oneview_client()"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f013ff3_1607201f","line":138,"range":{"start_line":138,"start_character":19,"end_line":138,"end_character":42},"updated":"2017-05-15 05:00:15.000000000","message":"It can raise OneViewInvalidNodeParameter. Do this needs to be handled and translated to OneViewError?","commit_id":"dcd14d6f09055a904716771bbb3195c7e5dd1526"},{"author":{"_account_id":21775,"name":"Ricardo Araújo Santos","email":"ricardo@lsd.ufcg.edu.br","username":"ricardoas"},"change_message_id":"e2de644463366e97536c57de83a9f2d1010d20d7","unresolved":false,"context_lines":[{"line_number":135,"context_line":"             from OneView."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    \"\"\""},{"line_number":138,"context_line":"    oneview_info \u003d common.get_oneview_info(node)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    oneview_client \u003d common.get_oneview_client()"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f013ff3_6951bed8","line":138,"range":{"start_line":138,"start_character":19,"end_line":138,"end_character":42},"in_reply_to":"1f013ff3_1607201f","updated":"2017-05-16 11:17:51.000000000","message":"Agreed","commit_id":"dcd14d6f09055a904716771bbb3195c7e5dd1526"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"18bac0b00b467f81af346c95b23f570a9ba72741","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    \"\"\""},{"line_number":138,"context_line":"    oneview_info \u003d common.get_oneview_info(node)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    oneview_client \u003d common.get_oneview_client()"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    sh_uuid \u003d oneview_utils.get_uuid_from_uri("},{"line_number":143,"context_line":"        oneview_info.get(\"server_hardware_uri\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f013ff3_e1187076","line":140,"range":{"start_line":140,"start_character":21,"end_line":140,"end_character":46},"updated":"2017-05-15 05:00:15.000000000","message":"This can throw oneview_exception.OneViewConnectionError and might need handling here.  I see this being not handled anywhere in the existing code as well...","commit_id":"dcd14d6f09055a904716771bbb3195c7e5dd1526"},{"author":{"_account_id":21775,"name":"Ricardo Araújo Santos","email":"ricardo@lsd.ufcg.edu.br","username":"ricardoas"},"change_message_id":"e2de644463366e97536c57de83a9f2d1010d20d7","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    \"\"\""},{"line_number":138,"context_line":"    oneview_info \u003d common.get_oneview_info(node)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    oneview_client \u003d common.get_oneview_client()"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    sh_uuid \u003d oneview_utils.get_uuid_from_uri("},{"line_number":143,"context_line":"        oneview_info.get(\"server_hardware_uri\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f013ff3_c9f8d2c5","line":140,"range":{"start_line":140,"start_character":21,"end_line":140,"end_character":46},"in_reply_to":"1f013ff3_e1187076","updated":"2017-05-16 11:17:51.000000000","message":"Agreed too... how do you think we should proceed, Shivanand? Update this exception handling at master code and open a later backport? As we are soon to be replacing this client at master code, my guess is to fix this here for now.","commit_id":"dcd14d6f09055a904716771bbb3195c7e5dd1526"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"18bac0b00b467f81af346c95b23f570a9ba72741","unresolved":false,"context_lines":[{"line_number":350,"context_line":"            _del_applied_server_profile_uri_field(node)"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"            LOG.info(_(\"Server Profile %(server_profile_uuid)s was deleted \""},{"line_number":353,"context_line":"                     \"from node %(node_uuid)s in OneView.\"),"},{"line_number":354,"context_line":"                     {\u0027server_profile_uuid\u0027: server_profile_uuid,"},{"line_number":355,"context_line":"                      \u0027node_uuid\u0027: node.uuid})"},{"line_number":356,"context_line":"        except (ValueError, oneview_exception.OneViewException) as e:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f013ff3_615b402e","line":353,"range":{"start_line":353,"start_character":22,"end_line":353,"end_character":26},"updated":"2017-05-15 05:00:15.000000000","message":"nit: s/ \u0027from\u0027 / \u0027for\u0027 /","commit_id":"dcd14d6f09055a904716771bbb3195c7e5dd1526"}]}
