)]}'
{"devstack/lib/ironic":[{"author":{"_account_id":18781,"name":"vinay muddu","email":"vinay50muddu@yahoo.com","username":"vmud213"},"change_message_id":"17612d38189205380d897386061dda98be87385b","unresolved":false,"context_lines":[{"line_number":2045,"context_line":"    image_uuid\u003d$(openstack image show $IRONIC_PARTITIONED_IMAGE_NAME -f value -c id)"},{"line_number":2046,"context_line":"    iniset $TEMPEST_CONFIG baremetal partition_image_ref $image_uuid"},{"line_number":2047,"context_line":""},{"line_number":2048,"context_line":"    if ! is_service_enabled swift; then"},{"line_number":2049,"context_line":"        iniset $TEMPEST_CONFIG baremetal whole_disk_image_url \"http://$IRONIC_HTTP_SERVER:$IRONIC_HTTP_PORT/${IRONIC_WHOLEDISK_IMAGE_NAME}.img\""},{"line_number":2050,"context_line":"        iniset $TEMPEST_CONFIG baremetal whole_disk_image_checksum $(md5sum $FILES/${IRONIC_WHOLEDISK_IMAGE_NAME}.img)"},{"line_number":2051,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5ff73747_4cea5e0f","line":2048,"range":{"start_line":2048,"start_character":7,"end_line":2048,"end_character":33},"updated":"2017-04-26 12:58:03.000000000","message":"We still require to test if IRONIC_IPXE_ENABLED is True as ipxe requires http server setup.\nif ! is_service_enabled_swift || [[ \"$IRONIC_IPXE_ENABLED\" \u003d\u003d \"True\" ]] ;","commit_id":"b2087e3b0097a8bf671c750ea8c9be4b6ea44324"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"3a1e829c299b120cb73969bc223a76c3ed404bf6","unresolved":false,"context_lines":[{"line_number":2045,"context_line":"    image_uuid\u003d$(openstack image show $IRONIC_PARTITIONED_IMAGE_NAME -f value -c id)"},{"line_number":2046,"context_line":"    iniset $TEMPEST_CONFIG baremetal partition_image_ref $image_uuid"},{"line_number":2047,"context_line":""},{"line_number":2048,"context_line":"    if ! is_service_enabled swift; then"},{"line_number":2049,"context_line":"        iniset $TEMPEST_CONFIG baremetal whole_disk_image_url \"http://$IRONIC_HTTP_SERVER:$IRONIC_HTTP_PORT/${IRONIC_WHOLEDISK_IMAGE_NAME}.img\""},{"line_number":2050,"context_line":"        iniset $TEMPEST_CONFIG baremetal whole_disk_image_checksum $(md5sum $FILES/${IRONIC_WHOLEDISK_IMAGE_NAME}.img)"},{"line_number":2051,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5ff73747_59495030","line":2048,"range":{"start_line":2048,"start_character":7,"end_line":2048,"end_character":33},"in_reply_to":"5ff73747_4cea5e0f","updated":"2017-05-03 08:02:41.000000000","message":"Done","commit_id":"b2087e3b0097a8bf671c750ea8c9be4b6ea44324"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b41ff19279af969c8e53257106b9095cdbf244b8","unresolved":false,"context_lines":[{"line_number":185,"context_line":"# Ironic IPA ramdisk type, supported types are:"},{"line_number":186,"context_line":"IRONIC_SUPPORTED_RAMDISK_TYPES_RE\u003d\"^(coreos|tinyipa|dib)$\""},{"line_number":187,"context_line":"IRONIC_RAMDISK_TYPE\u003d${IRONIC_RAMDISK_TYPE:-tinyipa}"},{"line_number":188,"context_line":"IRONIC_STANDALONE\u003d$(trueorfalse False IRONIC_STANDALONE)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"# Confirm we have a supported ramdisk type or fail early."},{"line_number":191,"context_line":"if [[ ! \"$IRONIC_RAMDISK_TYPE\" \u003d~ $IRONIC_SUPPORTED_RAMDISK_TYPES_RE ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"1f1a1f67_52cb4c1d","line":188,"updated":"2017-07-21 08:48:11.000000000","message":"Do we really need this, once installed ironic we can run ironic standalone test.","commit_id":"165e67f17c414f43bfb1f8b9c3921cb5ffabb47d"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"638a4482b522cf1d359e7ec80d66dfa8c1d21b45","unresolved":false,"context_lines":[{"line_number":185,"context_line":"# Ironic IPA ramdisk type, supported types are:"},{"line_number":186,"context_line":"IRONIC_SUPPORTED_RAMDISK_TYPES_RE\u003d\"^(coreos|tinyipa|dib)$\""},{"line_number":187,"context_line":"IRONIC_RAMDISK_TYPE\u003d${IRONIC_RAMDISK_TYPE:-tinyipa}"},{"line_number":188,"context_line":"IRONIC_STANDALONE\u003d$(trueorfalse False IRONIC_STANDALONE)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"# Confirm we have a supported ramdisk type or fail early."},{"line_number":191,"context_line":"if [[ ! \"$IRONIC_RAMDISK_TYPE\" \u003d~ $IRONIC_SUPPORTED_RAMDISK_TYPES_RE ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ff346bd7_f6725f11","line":188,"in_reply_to":"1f1a1f67_52cb4c1d","updated":"2017-07-24 03:48:10.000000000","message":"It is getting used in L2049. We are using this for setting the whole_disk_image_url. There is no check in setting the image_url in standalone test cases for wholedisk image.\nhttps://github.com/openstack/ironic/blob/8aea4f1e294f3a22bc00306c50737c0a2e742cc8/ironic_tempest_plugin/tests/scenario/ironic_standalone/test_basic_ops.py#L38","commit_id":"165e67f17c414f43bfb1f8b9c3921cb5ffabb47d"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"b67d84a0b62c165f74d67dd574308286cc9a62ab","unresolved":false,"context_lines":[{"line_number":185,"context_line":"# Ironic IPA ramdisk type, supported types are:"},{"line_number":186,"context_line":"IRONIC_SUPPORTED_RAMDISK_TYPES_RE\u003d\"^(coreos|tinyipa|dib)$\""},{"line_number":187,"context_line":"IRONIC_RAMDISK_TYPE\u003d${IRONIC_RAMDISK_TYPE:-tinyipa}"},{"line_number":188,"context_line":"IRONIC_STANDALONE\u003d$(trueorfalse False IRONIC_STANDALONE)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"# Confirm we have a supported ramdisk type or fail early."},{"line_number":191,"context_line":"if [[ ! \"$IRONIC_RAMDISK_TYPE\" \u003d~ $IRONIC_SUPPORTED_RAMDISK_TYPES_RE ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ff346bd7_da159241","line":188,"in_reply_to":"ff346bd7_1dc3545f","updated":"2017-07-28 06:25:01.000000000","message":"Done","commit_id":"165e67f17c414f43bfb1f8b9c3921cb5ffabb47d"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b757c9277802f39ab1815247cb7ad936a756b182","unresolved":false,"context_lines":[{"line_number":185,"context_line":"# Ironic IPA ramdisk type, supported types are:"},{"line_number":186,"context_line":"IRONIC_SUPPORTED_RAMDISK_TYPES_RE\u003d\"^(coreos|tinyipa|dib)$\""},{"line_number":187,"context_line":"IRONIC_RAMDISK_TYPE\u003d${IRONIC_RAMDISK_TYPE:-tinyipa}"},{"line_number":188,"context_line":"IRONIC_STANDALONE\u003d$(trueorfalse False IRONIC_STANDALONE)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"# Confirm we have a supported ramdisk type or fail early."},{"line_number":191,"context_line":"if [[ ! \"$IRONIC_RAMDISK_TYPE\" \u003d~ $IRONIC_SUPPORTED_RAMDISK_TYPES_RE ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ff346bd7_ab495e60","line":188,"in_reply_to":"ff346bd7_f6725f11","updated":"2017-07-28 08:25:30.000000000","message":"I see so you don\u0027t use ipxe on ilo jobs? And you store images on some external HTTP server?","commit_id":"165e67f17c414f43bfb1f8b9c3921cb5ffabb47d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"2515a9d1350ad5853505433ef1c3bf6e942eaca1","unresolved":false,"context_lines":[{"line_number":185,"context_line":"# Ironic IPA ramdisk type, supported types are:"},{"line_number":186,"context_line":"IRONIC_SUPPORTED_RAMDISK_TYPES_RE\u003d\"^(coreos|tinyipa|dib)$\""},{"line_number":187,"context_line":"IRONIC_RAMDISK_TYPE\u003d${IRONIC_RAMDISK_TYPE:-tinyipa}"},{"line_number":188,"context_line":"IRONIC_STANDALONE\u003d$(trueorfalse False IRONIC_STANDALONE)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"# Confirm we have a supported ramdisk type or fail early."},{"line_number":191,"context_line":"if [[ ! \"$IRONIC_RAMDISK_TYPE\" \u003d~ $IRONIC_SUPPORTED_RAMDISK_TYPES_RE ]]; then"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"ff346bd7_1dc3545f","line":188,"in_reply_to":"ff346bd7_f6725f11","updated":"2017-07-26 18:16:30.000000000","message":"It seems like \u0027IRONIC_STANDALONE\u0027 may be too generic. Would something with a more explicit name be better? eg \u0027IRONIC_WHOLE_DISK_IMAGE\u0027? Default to False. And if IRONIC_IPX_ENABLED is true, set this to true. The in L2049, you can just check for this new flag? (just some ideas I\u0027m throwing out there).\n\nAlso, you grouped/put this under the comment in L185 -- does the comment also apply to this new variable?","commit_id":"165e67f17c414f43bfb1f8b9c3921cb5ffabb47d"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"84ce12100ad958492b600b7863ba7700033efc6d","unresolved":false,"context_lines":[{"line_number":2222,"context_line":"    image_uuid\u003d$(openstack image show $IRONIC_PARTITIONED_IMAGE_NAME -f value -c id)"},{"line_number":2223,"context_line":"    iniset $TEMPEST_CONFIG baremetal partition_image_ref $image_uuid"},{"line_number":2224,"context_line":""},{"line_number":2225,"context_line":"    if [[ -n \"${IRONIC_HTTP_SERVER:\u003d}\" || \"$IRONIC_IPXE_ENABLED\" \u003d\u003d \"True\" ]]; then"},{"line_number":2226,"context_line":"        iniset $TEMPEST_CONFIG baremetal whole_disk_image_url \"http://$IRONIC_HTTP_SERVER:$IRONIC_HTTP_PORT/${IRONIC_WHOLEDISK_IMAGE_NAME}.img\""},{"line_number":2227,"context_line":"        iniset $TEMPEST_CONFIG baremetal whole_disk_image_checksum $(md5sum $FILES/${IRONIC_WHOLEDISK_IMAGE_NAME}.img)"},{"line_number":2228,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f436f4f_90288d34","line":2225,"range":{"start_line":2225,"start_character":13,"end_line":2225,"end_character":38},"updated":"2017-08-10 05:00:37.000000000","message":"Shouldn\u0027t this be \nif [[ -n \"${IRONIC_HTTP_SERVER}\" || ... ]]; then","commit_id":"b112f884b6fc47b41588b5cada25f6192628a960"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"c9f29c1030d9fe26ea343b79c4625e42fef53ad1","unresolved":false,"context_lines":[{"line_number":2222,"context_line":"    image_uuid\u003d$(openstack image show $IRONIC_PARTITIONED_IMAGE_NAME -f value -c id)"},{"line_number":2223,"context_line":"    iniset $TEMPEST_CONFIG baremetal partition_image_ref $image_uuid"},{"line_number":2224,"context_line":""},{"line_number":2225,"context_line":"    if [[ -n \"${IRONIC_HTTP_SERVER:\u003d}\" || \"$IRONIC_IPXE_ENABLED\" \u003d\u003d \"True\" ]]; then"},{"line_number":2226,"context_line":"        iniset $TEMPEST_CONFIG baremetal whole_disk_image_url \"http://$IRONIC_HTTP_SERVER:$IRONIC_HTTP_PORT/${IRONIC_WHOLEDISK_IMAGE_NAME}.img\""},{"line_number":2227,"context_line":"        iniset $TEMPEST_CONFIG baremetal whole_disk_image_checksum $(md5sum $FILES/${IRONIC_WHOLEDISK_IMAGE_NAME}.img)"},{"line_number":2228,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9f436f4f_50db45ec","line":2225,"range":{"start_line":2225,"start_character":13,"end_line":2225,"end_character":38},"in_reply_to":"9f436f4f_90288d34","updated":"2017-08-10 05:20:38.000000000","message":"Done","commit_id":"b112f884b6fc47b41588b5cada25f6192628a960"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"a8d335ead80bd9216cd91e7fd62c06b0631d827e","unresolved":false,"context_lines":[{"line_number":2211,"context_line":"    image_uuid\u003d$(openstack image show $IRONIC_PARTITIONED_IMAGE_NAME -f value -c id)"},{"line_number":2212,"context_line":"    iniset $TEMPEST_CONFIG baremetal partition_image_ref $image_uuid"},{"line_number":2213,"context_line":""},{"line_number":2214,"context_line":"    if [[ -n \"${IRONIC_HTTP_SERVER}\" || \"$IRONIC_IPXE_ENABLED\" \u003d\u003d \"True\" ]]; then"},{"line_number":2215,"context_line":"        iniset $TEMPEST_CONFIG baremetal whole_disk_image_url \"http://$IRONIC_HTTP_SERVER:$IRONIC_HTTP_PORT/${IRONIC_WHOLEDISK_IMAGE_NAME}.img\""},{"line_number":2216,"context_line":"        iniset $TEMPEST_CONFIG baremetal whole_disk_image_checksum $(md5sum $FILES/${IRONIC_WHOLEDISK_IMAGE_NAME}.img)"},{"line_number":2217,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"bf8cb3f7_8c36a4b4","line":2214,"updated":"2017-12-20 23:09:18.000000000","message":"Any reason behind this?","commit_id":"c26384eb5a455ac481da52c4e2f94bf63f969f42"},{"author":{"_account_id":19604,"name":"ankit","email":"ankit.dhn31@gmail.com","username":"ankit"},"change_message_id":"198e64187ee850475539e9317c3c90f4f6b34903","unresolved":false,"context_lines":[{"line_number":2211,"context_line":"    image_uuid\u003d$(openstack image show $IRONIC_PARTITIONED_IMAGE_NAME -f value -c id)"},{"line_number":2212,"context_line":"    iniset $TEMPEST_CONFIG baremetal partition_image_ref $image_uuid"},{"line_number":2213,"context_line":""},{"line_number":2214,"context_line":"    if [[ -n \"${IRONIC_HTTP_SERVER}\" || \"$IRONIC_IPXE_ENABLED\" \u003d\u003d \"True\" ]]; then"},{"line_number":2215,"context_line":"        iniset $TEMPEST_CONFIG baremetal whole_disk_image_url \"http://$IRONIC_HTTP_SERVER:$IRONIC_HTTP_PORT/${IRONIC_WHOLEDISK_IMAGE_NAME}.img\""},{"line_number":2216,"context_line":"        iniset $TEMPEST_CONFIG baremetal whole_disk_image_checksum $(md5sum $FILES/${IRONIC_WHOLEDISK_IMAGE_NAME}.img)"},{"line_number":2217,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"7f96bb07_6f4d803c","line":2214,"in_reply_to":"bf8cb3f7_8c36a4b4","updated":"2018-01-18 08:53:40.000000000","message":"As we are not using IPXE but we need whole_disk_image_url and whole_disk_image_checksum to be set as we are using web server and not glance.","commit_id":"c26384eb5a455ac481da52c4e2f94bf63f969f42"}]}