)]}'
{"ironic/api/app.py":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6427722936183731e4dedc35f03f1d47098034d4","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        \u0027X-Auth-Token\u0027,"},{"line_number":49,"context_line":"        base.Version.max_string,"},{"line_number":50,"context_line":"        base.Version.min_string,"},{"line_number":51,"context_line":"        base.Version.string"},{"line_number":52,"context_line":"    ]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_464d1f3c","line":51,"updated":"2017-05-01 18:59:49.000000000","message":"instead of copying the values from cors_middleware.CORS.simple_headers, wouldn\u0027t it be better to do something like simple_headers \u003d cors_middleware.CORS.simple_headers + [\u0027X-Auth-Token\u0027, base.Version*...]","commit_id":"0057f2e567b4a281335d145d7917d807f51f0e85"},{"author":{"_account_id":20970,"name":"Honza Pokorny","email":"honza@redhat.com","username":"hpokorny"},"change_message_id":"1cb6526f91c8b8d32005463cb38aa020c5344da5","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        \u0027X-Auth-Token\u0027,"},{"line_number":49,"context_line":"        base.Version.max_string,"},{"line_number":50,"context_line":"        base.Version.min_string,"},{"line_number":51,"context_line":"        base.Version.string"},{"line_number":52,"context_line":"    ]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_4ffa9d42","line":51,"in_reply_to":"5ff73747_464d1f3c","updated":"2017-05-04 18:23:04.000000000","message":"Done","commit_id":"0057f2e567b4a281335d145d7917d807f51f0e85"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"195a485c5273f7edb767e24aa7fabc858b4581f7","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        base.Version.max_string,"},{"line_number":50,"context_line":"        base.Version.min_string,"},{"line_number":51,"context_line":"        base.Version.string"},{"line_number":52,"context_line":"    ]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"def get_pecan_config():"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_867c4772","line":52,"updated":"2017-05-01 18:42:46.000000000","message":"let\u0027s avoid duplicating the list in oslo:\n\n simple_headers \u003d cors_middleware.CORS.simple_headers + [\n     base.Version.max_string,\n     ...\n ]","commit_id":"0057f2e567b4a281335d145d7917d807f51f0e85"},{"author":{"_account_id":20970,"name":"Honza Pokorny","email":"honza@redhat.com","username":"hpokorny"},"change_message_id":"1cb6526f91c8b8d32005463cb38aa020c5344da5","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        base.Version.max_string,"},{"line_number":50,"context_line":"        base.Version.min_string,"},{"line_number":51,"context_line":"        base.Version.string"},{"line_number":52,"context_line":"    ]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"def get_pecan_config():"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_6ffd5939","line":52,"in_reply_to":"5ff73747_867c4772","updated":"2017-05-04 18:23:04.000000000","message":"Done","commit_id":"0057f2e567b4a281335d145d7917d807f51f0e85"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6427722936183731e4dedc35f03f1d47098034d4","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    app \u003d IronicCORS(app, CONF)"},{"line_number":107,"context_line":"    cors_middleware.set_defaults("},{"line_number":108,"context_line":"        allow_headers\u003d[base.Version.max_string, base.Version.min_string,"},{"line_number":109,"context_line":"                       base.Version.string],"},{"line_number":110,"context_line":"        allow_methods\u003d[\u0027GET\u0027, \u0027PUT\u0027, \u0027POST\u0027, \u0027DELETE\u0027, \u0027PATCH\u0027],"},{"line_number":111,"context_line":"        expose_headers\u003d[base.Version.max_string, base.Version.min_string,"},{"line_number":112,"context_line":"                        base.Version.string]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_ab16eca6","line":109,"updated":"2017-05-01 18:59:49.000000000","message":"so is this still needed?","commit_id":"0057f2e567b4a281335d145d7917d807f51f0e85"},{"author":{"_account_id":20970,"name":"Honza Pokorny","email":"honza@redhat.com","username":"hpokorny"},"change_message_id":"9faffbec73545e1733d3146698d96cc223c28b69","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    app \u003d IronicCORS(app, CONF)"},{"line_number":107,"context_line":"    cors_middleware.set_defaults("},{"line_number":108,"context_line":"        allow_headers\u003d[base.Version.max_string, base.Version.min_string,"},{"line_number":109,"context_line":"                       base.Version.string],"},{"line_number":110,"context_line":"        allow_methods\u003d[\u0027GET\u0027, \u0027PUT\u0027, \u0027POST\u0027, \u0027DELETE\u0027, \u0027PATCH\u0027],"},{"line_number":111,"context_line":"        expose_headers\u003d[base.Version.max_string, base.Version.min_string,"},{"line_number":112,"context_line":"                        base.Version.string]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_3ae9cd19","line":109,"in_reply_to":"5ff73747_ab16eca6","updated":"2017-05-04 18:32:06.000000000","message":"Done","commit_id":"0057f2e567b4a281335d145d7917d807f51f0e85"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"6427722936183731e4dedc35f03f1d47098034d4","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        allow_methods\u003d[\u0027GET\u0027, \u0027PUT\u0027, \u0027POST\u0027, \u0027DELETE\u0027, \u0027PATCH\u0027],"},{"line_number":111,"context_line":"        expose_headers\u003d[base.Version.max_string, base.Version.min_string,"},{"line_number":112,"context_line":"                        base.Version.string]"},{"line_number":113,"context_line":"    )"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    return app"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_a68f4328","line":113,"updated":"2017-05-01 18:59:49.000000000","message":"I\u0027m not totally sure I understand the code in oslo.middleware, but it seems to me that whatever the problem is with allow_headers, we may have a similar issue with allow_methods and expose_headers.\n\nI am wondering if there is another way to solve this. It looks like they are all configurable via cors config options. Would it work to set the default values of those cors config options instead?\n\nI don\u0027t know if it\u0027ll work or not (I don\u0027t have time to look into it and don\u0027t quite understand the code patch used here) but we did something similar for default_log_levels: https://github.com/openstack/ironic/blob/6196e58270e696cfe81e76338bccc44251666160/ironic/conf/opts.py#L87","commit_id":"0057f2e567b4a281335d145d7917d807f51f0e85"},{"author":{"_account_id":20970,"name":"Honza Pokorny","email":"honza@redhat.com","username":"hpokorny"},"change_message_id":"9faffbec73545e1733d3146698d96cc223c28b69","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        allow_methods\u003d[\u0027GET\u0027, \u0027PUT\u0027, \u0027POST\u0027, \u0027DELETE\u0027, \u0027PATCH\u0027],"},{"line_number":111,"context_line":"        expose_headers\u003d[base.Version.max_string, base.Version.min_string,"},{"line_number":112,"context_line":"                        base.Version.string]"},{"line_number":113,"context_line":"    )"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    return app"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_5ae37934","line":113,"in_reply_to":"3f044301_2f31910c","updated":"2017-05-04 18:32:06.000000000","message":"Unittest added to show that headers are correctly exposed","commit_id":"0057f2e567b4a281335d145d7917d807f51f0e85"},{"author":{"_account_id":20970,"name":"Honza Pokorny","email":"honza@redhat.com","username":"hpokorny"},"change_message_id":"1cb6526f91c8b8d32005463cb38aa020c5344da5","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        allow_methods\u003d[\u0027GET\u0027, \u0027PUT\u0027, \u0027POST\u0027, \u0027DELETE\u0027, \u0027PATCH\u0027],"},{"line_number":111,"context_line":"        expose_headers\u003d[base.Version.max_string, base.Version.min_string,"},{"line_number":112,"context_line":"                        base.Version.string]"},{"line_number":113,"context_line":"    )"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    return app"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_2f31910c","line":113,"in_reply_to":"5ff73747_a68f4328","updated":"2017-05-04 18:23:04.000000000","message":"Overriding allow_methods and expose_headers doesn\u0027t seem to be needed.  I can add a unittest to provide a more definitive answer.\n\nUsing defaults won\u0027t work because whatever the user sets in /etc/ironic/ironic.conf will override that.","commit_id":"0057f2e567b4a281335d145d7917d807f51f0e85"}]}
