)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"9ee917162b371f41b0a7057240b8cfda41a0814d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ngo Quoc Cuong \u003ccuongnq@vn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-03 10:01:52 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove translation of log messages from ironic/drivers/modules/"},{"line_number":8,"context_line":"and ironic/drivers/ (not include sub-folder)"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"i18n team has decided not to translate the logs because it seems"},{"line_number":11,"context_line":"like it\u0027s not very useful"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5ff73747_ea35e0a9","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":44},"updated":"2017-05-03 03:22:30.000000000","message":"Commit summary needs to be a single line followed by a blank line. May be you can say:-\n\"Remove translation of log messages from ironic/drivers\"\n\nAnd specifics of the folders being covered can be added into the detailed commit message.","commit_id":"2d7e665d3a0d831dbd43bb4b26b456576b5306d3"},{"author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"change_message_id":"4de9a96037fbeb7ec3aaee966060a6a9fae7c31f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ngo Quoc Cuong \u003ccuongnq@vn.fujitsu.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-03 10:01:52 +0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove translation of log messages from ironic/drivers/modules/"},{"line_number":8,"context_line":"and ironic/drivers/ (not include sub-folder)"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"i18n team has decided not to translate the logs because it seems"},{"line_number":11,"context_line":"like it\u0027s not very useful"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5ff73747_ca2ea4f9","line":8,"range":{"start_line":7,"start_character":0,"end_line":8,"end_character":44},"in_reply_to":"5ff73747_ea35e0a9","updated":"2017-05-03 03:45:21.000000000","message":"Done","commit_id":"2d7e665d3a0d831dbd43bb4b26b456576b5306d3"}],"ironic/drivers/modules/deploy_utils.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d137dd297311358aa9572146ef5c6517299fb6a1","unresolved":false,"context_lines":[{"line_number":528,"context_line":"        msg2 \u003d (\u0027Internal error. Node %(node)s in provision state \u0027"},{"line_number":529,"context_line":"                \u0027\"%(state)s\" could not transition to a failed state.\u0027"},{"line_number":530,"context_line":"                % {\u0027node\u0027: node.uuid, \u0027state\u0027: node.provision_state})"},{"line_number":531,"context_line":"        LOG.exception(msg2)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"    if CONF.deploy.power_off_after_deploy_failure:"},{"line_number":534,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_85be6bab","line":531,"range":{"start_line":531,"start_character":21,"end_line":531,"end_character":27},"updated":"2017-05-02 10:59:52.000000000","message":"nit: Variable msg2 can be avoided by passing the message into LOG.exception(...)","commit_id":"843f77484459e5c35e41efe70cd6f4acb4eb78b6"},{"author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"change_message_id":"5d49b4f4a8c4d1d790973d6e6e96143256998814","unresolved":false,"context_lines":[{"line_number":528,"context_line":"        msg2 \u003d (\u0027Internal error. Node %(node)s in provision state \u0027"},{"line_number":529,"context_line":"                \u0027\"%(state)s\" could not transition to a failed state.\u0027"},{"line_number":530,"context_line":"                % {\u0027node\u0027: node.uuid, \u0027state\u0027: node.provision_state})"},{"line_number":531,"context_line":"        LOG.exception(msg2)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"    if CONF.deploy.power_off_after_deploy_failure:"},{"line_number":534,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_773addcd","line":531,"range":{"start_line":531,"start_character":21,"end_line":531,"end_character":27},"in_reply_to":"5ff73747_85be6bab","updated":"2017-05-03 02:54:20.000000000","message":"Done","commit_id":"843f77484459e5c35e41efe70cd6f4acb4eb78b6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d137dd297311358aa9572146ef5c6517299fb6a1","unresolved":false,"context_lines":[{"line_number":538,"context_line":"                    \u0027failure. This may be a serious condition. Node \u0027"},{"line_number":539,"context_line":"                    \u0027should be removed from Ironic or put in maintenance \u0027"},{"line_number":540,"context_line":"                    \u0027mode until the problem is resolved.\u0027 % node.uuid)"},{"line_number":541,"context_line":"            LOG.exception(msg2)"},{"line_number":542,"context_line":"    # NOTE(deva): node_power_action() erases node.last_error"},{"line_number":543,"context_line":"    #             so we need to set it here."},{"line_number":544,"context_line":"    node.last_error \u003d msg"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_45e2a3d6","line":541,"range":{"start_line":541,"start_character":26,"end_line":541,"end_character":30},"updated":"2017-05-02 10:59:52.000000000","message":"ditto","commit_id":"843f77484459e5c35e41efe70cd6f4acb4eb78b6"},{"author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"change_message_id":"5d49b4f4a8c4d1d790973d6e6e96143256998814","unresolved":false,"context_lines":[{"line_number":538,"context_line":"                    \u0027failure. This may be a serious condition. Node \u0027"},{"line_number":539,"context_line":"                    \u0027should be removed from Ironic or put in maintenance \u0027"},{"line_number":540,"context_line":"                    \u0027mode until the problem is resolved.\u0027 % node.uuid)"},{"line_number":541,"context_line":"            LOG.exception(msg2)"},{"line_number":542,"context_line":"    # NOTE(deva): node_power_action() erases node.last_error"},{"line_number":543,"context_line":"    #             so we need to set it here."},{"line_number":544,"context_line":"    node.last_error \u003d msg"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_5737e1e4","line":541,"range":{"start_line":541,"start_character":26,"end_line":541,"end_character":30},"in_reply_to":"5ff73747_45e2a3d6","updated":"2017-05-03 02:54:20.000000000","message":"Done","commit_id":"843f77484459e5c35e41efe70cd6f4acb4eb78b6"}],"ironic/drivers/modules/image_cache.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d137dd297311358aa9572146ef5c6517299fb6a1","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"            LOG.info(\"Master cache miss for image %(href)s, \""},{"line_number":132,"context_line":"                     \"starting download\","},{"line_number":133,"context_line":"                     {\u0027href\u0027: href})"},{"line_number":134,"context_line":"            self._download_image("},{"line_number":135,"context_line":"                href, master_path, dest_path, ctx\u003dctx, force_raw\u003dforce_raw)"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_65c91f24","line":133,"range":{"start_line":133,"start_character":21,"end_line":133,"end_character":36},"updated":"2017-05-02 10:59:52.000000000","message":"nit: This can move up @ L132.","commit_id":"843f77484459e5c35e41efe70cd6f4acb4eb78b6"},{"author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"change_message_id":"5d49b4f4a8c4d1d790973d6e6e96143256998814","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"            LOG.info(\"Master cache miss for image %(href)s, \""},{"line_number":132,"context_line":"                     \"starting download\","},{"line_number":133,"context_line":"                     {\u0027href\u0027: href})"},{"line_number":134,"context_line":"            self._download_image("},{"line_number":135,"context_line":"                href, master_path, dest_path, ctx\u003dctx, force_raw\u003dforce_raw)"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_373455de","line":133,"range":{"start_line":133,"start_character":21,"end_line":133,"end_character":36},"in_reply_to":"5ff73747_65c91f24","updated":"2017-05-03 02:54:20.000000000","message":"Done","commit_id":"843f77484459e5c35e41efe70cd6f4acb4eb78b6"}],"ironic/drivers/modules/ipmitool.py":[{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d137dd297311358aa9572146ef5c6517299fb6a1","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                        (num_tries \u003d\u003d 0) or"},{"line_number":442,"context_line":"                        not err_list):"},{"line_number":443,"context_line":"                        LOG.error(\u0027IPMI Error while attempting \"%(cmd)s\" \u0027"},{"line_number":444,"context_line":"                                  \u0027for node %(node) s. Error: %(error)s\u0027, {"},{"line_number":445,"context_line":"                                      \u0027node\u0027: driver_info[\u0027uuid\u0027],"},{"line_number":446,"context_line":"                                      \u0027cmd\u0027: e.cmd, \u0027error\u0027: e"},{"line_number":447,"context_line":"                                  })"},{"line_number":448,"context_line":"                    else:"},{"line_number":449,"context_line":"                        ctxt.reraise \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_fd102752","line":446,"range":{"start_line":444,"start_character":34,"end_line":446,"end_character":62},"updated":"2017-05-02 10:59:52.000000000","message":"nit: Better to write as:\nLOG.error(\u0027IPMI Error while attempting \"%(cmd)s\" \u0027\n          \u0027for node %(node) s. Error: %(error)s\u0027,\n          {\u0027node\u0027: driver_info[\u0027uuid\u0027],\n           \u0027cmd\u0027: e.cmd, \u0027error\u0027: e})","commit_id":"843f77484459e5c35e41efe70cd6f4acb4eb78b6"},{"author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"change_message_id":"5d49b4f4a8c4d1d790973d6e6e96143256998814","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                        (num_tries \u003d\u003d 0) or"},{"line_number":442,"context_line":"                        not err_list):"},{"line_number":443,"context_line":"                        LOG.error(\u0027IPMI Error while attempting \"%(cmd)s\" \u0027"},{"line_number":444,"context_line":"                                  \u0027for node %(node) s. Error: %(error)s\u0027, {"},{"line_number":445,"context_line":"                                      \u0027node\u0027: driver_info[\u0027uuid\u0027],"},{"line_number":446,"context_line":"                                      \u0027cmd\u0027: e.cmd, \u0027error\u0027: e"},{"line_number":447,"context_line":"                                  })"},{"line_number":448,"context_line":"                    else:"},{"line_number":449,"context_line":"                        ctxt.reraise \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_173159ed","line":446,"range":{"start_line":444,"start_character":34,"end_line":446,"end_character":62},"in_reply_to":"5ff73747_fd102752","updated":"2017-05-03 02:54:20.000000000","message":"Done","commit_id":"843f77484459e5c35e41efe70cd6f4acb4eb78b6"},{"author":{"_account_id":11076,"name":"Shivanand Tendulker","email":"stendulker@gmail.com","username":"stendulker"},"change_message_id":"d137dd297311358aa9572146ef5c6517299fb6a1","unresolved":false,"context_lines":[{"line_number":449,"context_line":"                        ctxt.reraise \u003d False"},{"line_number":450,"context_line":"                        LOG.warning(\u0027IPMI Error encountered, retrying \u0027"},{"line_number":451,"context_line":"                                    \u0027\"%(cmd)s\" for node %(node)s. \u0027"},{"line_number":452,"context_line":"                                    \u0027Error: %(error)s\u0027, {"},{"line_number":453,"context_line":"                                        \u0027node\u0027: driver_info[\u0027uuid\u0027],"},{"line_number":454,"context_line":"                                        \u0027cmd\u0027: e.cmd, \u0027error\u0027: e"},{"line_number":455,"context_line":"                                    })"},{"line_number":456,"context_line":"            finally:"},{"line_number":457,"context_line":"                LAST_CMD_TIME[driver_info[\u0027address\u0027]] \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_bd1a9f6c","line":454,"range":{"start_line":452,"start_character":35,"end_line":454,"end_character":64},"updated":"2017-05-02 10:59:52.000000000","message":"ditto","commit_id":"843f77484459e5c35e41efe70cd6f4acb4eb78b6"},{"author":{"_account_id":25720,"name":"Ngo Quoc Cuong","email":"cuongngo.ict@gmail.com","username":"cuongnq"},"change_message_id":"5d49b4f4a8c4d1d790973d6e6e96143256998814","unresolved":false,"context_lines":[{"line_number":449,"context_line":"                        ctxt.reraise \u003d False"},{"line_number":450,"context_line":"                        LOG.warning(\u0027IPMI Error encountered, retrying \u0027"},{"line_number":451,"context_line":"                                    \u0027\"%(cmd)s\" for node %(node)s. \u0027"},{"line_number":452,"context_line":"                                    \u0027Error: %(error)s\u0027, {"},{"line_number":453,"context_line":"                                        \u0027node\u0027: driver_info[\u0027uuid\u0027],"},{"line_number":454,"context_line":"                                        \u0027cmd\u0027: e.cmd, \u0027error\u0027: e"},{"line_number":455,"context_line":"                                    })"},{"line_number":456,"context_line":"            finally:"},{"line_number":457,"context_line":"                LAST_CMD_TIME[driver_info[\u0027address\u0027]] \u003d time.time()"}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_f74b8d5c","line":454,"range":{"start_line":452,"start_character":35,"end_line":454,"end_character":64},"in_reply_to":"5ff73747_bd1a9f6c","updated":"2017-05-03 02:54:20.000000000","message":"Done","commit_id":"843f77484459e5c35e41efe70cd6f4acb4eb78b6"}]}